4 crcchecker is a tool to used to enforce that .api messages do not change.
5 API files with a semantic version < 1.0.0 are ignored.
13 from subprocess import run, PIPE, check_output, CalledProcessError
15 # pylint: disable=subprocess-run-check
17 ROOTDIR = os.path.dirname(os.path.realpath(__file__)) + "/../.."
18 APIGENBIN = f"{ROOTDIR}/src/tools/vppapigen/vppapigen.py"
21 def crc_from_apigen(revision, filename):
22 """Runs vppapigen with crc plugin returning a JSON object with CRCs for
23 all APIs in filename"""
24 if not revision and not os.path.isfile(filename):
25 print(f"skipping: {filename}", file=sys.stderr)
26 # Return <class 'set'> instead of <class 'dict'>
31 f"{APIGENBIN} --git-revision {revision} --includedir src "
32 f"--input {filename} CRC"
35 apigen = f"{APIGENBIN} --includedir src --input {filename} CRC"
36 returncode = run(apigen.split(), stdout=PIPE, stderr=PIPE)
37 if returncode.returncode == 2: # No such file
38 print(f"skipping: {revision}:{filename} {returncode}", file=sys.stderr)
40 if returncode.returncode != 0:
42 f"vppapigen failed for {revision}:{filename} with "
43 "command\n {apigen}\n error: {rv}",
44 returncode.stderr.decode("ascii"),
49 return json.loads(returncode.stdout)
52 def dict_compare(dict1, dict2):
53 """Compare two dictionaries returning added, removed, modified
55 d1_keys = set(dict1.keys())
56 d2_keys = set(dict2.keys())
57 intersect_keys = d1_keys.intersection(d2_keys)
58 added = d1_keys - d2_keys
59 removed = d2_keys - d1_keys
61 o: (dict1[o], dict2[o])
62 for o in intersect_keys
63 if dict1[o]["crc"] != dict2[o]["crc"]
65 same = set(o for o in intersect_keys if dict1[o] == dict2[o])
66 return added, removed, modified, same
69 def filelist_from_git_ls():
70 """Returns a list of all api files in the git repository"""
72 git_ls = "git ls-files *.api"
73 returncode = run(git_ls.split(), stdout=PIPE, stderr=PIPE)
74 if returncode.returncode != 0:
75 sys.exit(returncode.returncode)
77 for line in returncode.stdout.decode("ascii").split("\n"):
83 def is_uncommitted_changes():
84 """Returns true if there are uncommitted changes in the repo"""
85 # Don't run this check in the Jenkins CI
86 if os.getenv("FDIOTOOLS_IMAGE") is None:
87 git_status = "git status --porcelain -uno"
88 returncode = run(git_status.split(), stdout=PIPE, stderr=PIPE)
89 if returncode.returncode != 0:
90 sys.exit(returncode.returncode)
97 def filelist_from_git_grep(filename):
98 """Returns a list of api files that this <filename> api files imports."""
101 returncode = check_output(
102 f'git grep -e "import .*{filename}"' " -- *.api", shell=True
104 except CalledProcessError:
106 for line in returncode.decode("ascii").split("\n"):
108 filename, _ = line.split(":")
109 filelist.append(filename)
113 def filelist_from_patchset(pattern):
114 """Returns list of api files in changeset and the list of api
115 files they import."""
118 "((git diff HEAD~1.. --name-only;git ls-files -m) | "
119 'sort -u | grep "\\.api$")'
122 res = check_output(git_cmd, shell=True)
123 except CalledProcessError:
126 # Check for dependencies (imports)
128 for line in res.decode("ascii").split("\n"):
131 if not re.search(pattern, line):
133 filelist.append(line)
134 imported_files.extend(filelist_from_git_grep(os.path.basename(line)))
136 filelist.extend(imported_files)
140 def is_deprecated(message):
141 """Given a message, return True if message is deprecated"""
142 if "options" in message:
143 if "deprecated" in message["options"]:
145 # recognize the deprecated format
147 "status" in message["options"]
148 and message["options"]["status"] == "deprecated"
150 print("WARNING: please use 'option deprecated;'")
155 def is_in_progress(message):
156 """Given a message, return True if message is marked as in_progress"""
157 if "options" in message:
158 if "in_progress" in message["options"]:
160 # recognize the deprecated format
162 "status" in message["options"]
163 and message["options"]["status"] == "in_progress"
165 print("WARNING: please use 'option in_progress;'")
170 def report(new, old):
171 """Given a dictionary of new crcs and old crcs, print all the
172 added, removed, modified, in-progress, deprecated messages.
173 Return the number of backwards incompatible changes made."""
175 # pylint: disable=too-many-branches
177 new.pop("_version", None)
178 old.pop("_version", None)
179 added, removed, modified, _ = dict_compare(new, old)
180 backwards_incompatible = 0
182 # print the full list of in-progress messages
183 # they should eventually either disappear of become supported
185 newversion = int(new[k]["version"])
186 if newversion == 0 or is_in_progress(new[k]):
187 print(f"in-progress: {k}")
191 oldversion = int(old[k]["version"])
192 if oldversion > 0 and not is_deprecated(old[k]) and not is_in_progress(old[k]):
193 backwards_incompatible += 1
194 print(f"removed: ** {k}")
196 print(f"removed: {k}")
197 for k in modified.keys():
198 oldversion = int(old[k]["version"])
199 newversion = int(new[k]["version"])
200 if oldversion > 0 and not is_in_progress(old[k]):
201 backwards_incompatible += 1
202 print(f"modified: ** {k}")
204 print(f"modified: {k}")
206 # check which messages are still there but were marked for deprecation
208 newversion = int(new[k]["version"])
209 if newversion > 0 and is_deprecated(new[k]):
211 if not is_deprecated(old[k]):
212 print(f"deprecated: {k}")
214 print(f"added+deprecated: {k}")
216 return backwards_incompatible
219 def check_patchset():
220 """Compare the changes to API messages in this changeset.
221 Ignores API files with version < 1.0.0.
222 Only considers API files located under the src directory in the repo.
224 files = filelist_from_patchset("^src/")
229 for filename in files:
230 # Ignore files that have version < 1.0.0
231 _ = crc_from_apigen(None, filename)
232 # Ignore removed files
233 if isinstance(_, set) == 0:
234 if isinstance(_, set) == 0 and _["_version"]["major"] == "0":
238 oldcrcs.update(crc_from_apigen(revision, filename))
240 backwards_incompatible = report(newcrcs, oldcrcs)
241 if backwards_incompatible:
242 # alert on changing production API
244 "crcchecker: Changing production APIs in an incompatible way",
250 print("* VPP CHECKAPI SUCCESSFULLY COMPLETED")
255 """Main entry point."""
256 parser = argparse.ArgumentParser(description="VPP CRC checker.")
257 parser.add_argument("--git-revision", help="Git revision to compare against")
259 "--dump-manifest", action="store_true", help="Dump CRC for all messages"
264 help="Check patchset for backwards incompatbile changes",
266 parser.add_argument("files", nargs="*")
267 parser.add_argument("--diff", help="Files to compare (on filesystem)", nargs=2)
269 args = parser.parse_args()
271 if args.diff and args.files:
277 oldcrcs = crc_from_apigen(None, args.diff[0])
278 newcrcs = crc_from_apigen(None, args.diff[1])
279 backwards_incompatible = report(newcrcs, oldcrcs)
282 # Dump CRC for messages in given files / revision
283 if args.dump_manifest:
284 files = args.files if args.files else filelist_from_git_ls()
286 for filename in files:
287 crcs.update(crc_from_apigen(args.git_revision, filename))
288 for k, value in crcs.items():
289 print(f"{k}: {value}")
292 # Find changes between current patchset and given revision (previous)
293 if args.check_patchset:
294 if args.git_revision:
295 print("Argument git-revision ignored", file=sys.stderr)
296 # Check there are no uncomitted changes
297 if is_uncommitted_changes():
298 print("Please stash or commit changes in workspace", file=sys.stderr)
303 # Find changes between current workspace and revision
304 # Find changes between a given file and a revision
305 files = args.files if args.files else filelist_from_git_ls()
307 revision = args.git_revision if args.git_revision else "HEAD~1"
312 newcrcs.update(crc_from_apigen(None, file))
313 oldcrcs.update(crc_from_apigen(revision, file))
315 backwards_incompatible = report(newcrcs, oldcrcs)
317 if args.check_patchset:
318 if backwards_incompatible:
319 # alert on changing production API
321 "crcchecker: Changing production APIs in an incompatible way",
327 print("* VPP CHECKAPI SUCCESSFULLY COMPLETED")
331 if __name__ == "__main__":