2 * Copyright (c) 2015 Cisco and/or its affiliates.
3 * Licensed under the Apache License, Version 2.0 (the "License");
4 * you may not use this file except in compliance with the License.
5 * You may obtain a copy of the License at:
7 * http://www.apache.org/licenses/LICENSE-2.0
9 * Unless required by applicable law or agreed to in writing, software
10 * distributed under the License is distributed on an "AS IS" BASIS,
11 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 * See the License for the specific language governing permissions and
13 * limitations under the License.
15 #include <vnet/vnet.h>
16 #include <vppinfra/vec.h>
17 #include <vppinfra/error.h>
18 #include <vppinfra/format.h>
19 #include <vppinfra/bitmap.h>
20 #include <vppinfra/linux/sysfs.h>
21 #include <vlib/unix/unix.h>
24 #include <vnet/vnet.h>
25 #include <vnet/ethernet/ethernet.h>
26 #include <vnet/interface/rx_queue_funcs.h>
27 #include <dpdk/buffer.h>
28 #include <dpdk/device/dpdk.h>
29 #include <dpdk/cryptodev/cryptodev.h>
30 #include <vlib/pci/pci.h>
31 #include <vlib/vmbus/vmbus.h>
40 #include <sys/mount.h>
45 #include <dpdk/device/dpdk_priv.h>
47 dpdk_main_t dpdk_main;
48 dpdk_config_main_t dpdk_config_main;
50 #define LINK_STATE_ELOGS 0
52 /* dev_info.speed_capa -> interface name mapppings */
57 } if_name_prefixes[] = {
58 /* sorted, higher speed first */
59 { ETH_LINK_SPEED_200G, "TwoHundredGigabitEthernet" },
60 { ETH_LINK_SPEED_100G, "HundredGigabitEthernet" },
61 { ETH_LINK_SPEED_56G, "FiftySixGigabitEthernet" },
62 { ETH_LINK_SPEED_50G, "FiftyGigabitEthernet" },
63 { ETH_LINK_SPEED_40G, "FortyGigabitEthernet" },
64 { ETH_LINK_SPEED_25G, "TwentyFiveGigabitEthernet" },
65 { ETH_LINK_SPEED_20G, "TwentyGigabitEthernet" },
66 { ETH_LINK_SPEED_10G, "TenGigabitEthernet" },
67 { ETH_LINK_SPEED_5G, "FiveGigabitEthernet" },
68 { ETH_LINK_SPEED_2_5G, "TwoDotFiveGigabitEthernet" },
69 { ETH_LINK_SPEED_1G, "GigabitEthernet" },
73 dpdk_set_max_frame_size (vnet_main_t *vnm, vnet_hw_interface_t *hi,
76 dpdk_main_t *dm = &dpdk_main;
77 dpdk_device_t *xd = vec_elt_at_index (dm->devices, hi->dev_instance);
81 mtu = frame_size - xd->driver_frame_overhead;
83 rv = rte_eth_dev_set_mtu (xd->port_id, mtu);
87 dpdk_log_err ("[%u] rte_eth_dev_set_mtu failed (mtu %u, rv %d)",
88 xd->port_id, mtu, rv);
92 return vnet_error (VNET_ERR_UNSUPPORTED,
93 "dpdk driver doesn't support MTU change");
95 return vnet_error (VNET_ERR_BUSY, "port is running");
97 return vnet_error (VNET_ERR_INVALID_VALUE, "invalid MTU");
99 return vnet_error (VNET_ERR_BUG,
100 "unexpected return value %d returned from "
101 "rte_eth_dev_set_mtu(...)",
106 dpdk_log_debug ("[%u] max_frame_size set to %u by setting MTU to %u",
107 xd->port_id, frame_size, mtu);
113 dpdk_flag_change (vnet_main_t * vnm, vnet_hw_interface_t * hi, u32 flags)
115 dpdk_main_t *dm = &dpdk_main;
116 dpdk_device_t *xd = vec_elt_at_index (dm->devices, hi->dev_instance);
117 u32 old = (xd->flags & DPDK_DEVICE_FLAG_PROMISC) != 0;
121 case ETHERNET_INTERFACE_FLAG_DEFAULT_L3:
122 /* set to L3/non-promisc mode */
123 dpdk_device_flag_set (xd, DPDK_DEVICE_FLAG_PROMISC, 0);
125 case ETHERNET_INTERFACE_FLAG_ACCEPT_ALL:
126 dpdk_device_flag_set (xd, DPDK_DEVICE_FLAG_PROMISC, 1);
132 if (xd->flags & DPDK_DEVICE_FLAG_ADMIN_UP)
134 if (xd->flags & DPDK_DEVICE_FLAG_PROMISC)
135 rte_eth_promiscuous_enable (xd->port_id);
137 rte_eth_promiscuous_disable (xd->port_id);
143 /* The function check_l3cache helps check if Level 3 cache exists or not on current CPUs
144 return value 1: exist.
145 return value 0: not exist.
153 const char *sys_cache_dir = "/sys/devices/system/cpu/cpu0/cache";
154 DIR *dir_cache = opendir (sys_cache_dir);
156 if (dir_cache == NULL)
159 while ((dp = readdir (dir_cache)) != NULL)
161 if (dp->d_type == DT_DIR)
164 int level_cache = -1;
166 p = format (p, "%s/%s/%s%c", sys_cache_dir, dp->d_name, "level", 0);
167 if ((err = clib_sysfs_read ((char *) p, "%d", &level_cache)))
168 clib_error_free (err);
170 if (level_cache == 3)
172 closedir (dir_cache);
178 if (dir_cache != NULL)
179 closedir (dir_cache);
184 static dpdk_device_config_t *
185 dpdk_find_startup_config (struct rte_eth_dev_info *di)
187 dpdk_main_t *dm = &dpdk_main;
188 struct rte_pci_device *pci_dev;
189 struct rte_vmbus_device *vmbus_dev;
190 vlib_pci_addr_t pci_addr;
191 vlib_vmbus_addr_t vmbus_addr;
194 if ((pci_dev = dpdk_get_pci_device (di)))
196 pci_addr.domain = pci_dev->addr.domain;
197 pci_addr.bus = pci_dev->addr.bus;
198 pci_addr.slot = pci_dev->addr.devid;
199 pci_addr.function = pci_dev->addr.function;
201 hash_get (dm->conf->device_config_index_by_pci_addr, pci_addr.as_u32);
204 if ((vmbus_dev = dpdk_get_vmbus_device (di)))
206 unformat_input_t input_vmbus;
207 unformat_init_string (&input_vmbus, di->device->name,
208 strlen (di->device->name));
209 if (unformat (&input_vmbus, "%U", unformat_vlib_vmbus_addr, &vmbus_addr))
210 p = mhash_get (&dm->conf->device_config_index_by_vmbus_addr,
212 unformat_free (&input_vmbus);
216 return pool_elt_at_index (dm->conf->dev_confs, p[0]);
217 return &dm->conf->default_devconf;
220 static clib_error_t *
221 dpdk_lib_init (dpdk_main_t * dm)
223 vnet_main_t *vnm = vnet_get_main ();
225 vlib_thread_main_t *tm = vlib_get_thread_main ();
226 vnet_device_main_t *vdm = &vnet_device_main;
227 vnet_sw_interface_t *sw;
228 vnet_hw_interface_t *hi;
232 /* vlib_buffer_t template */
233 vec_validate_aligned (dm->per_thread_data, tm->n_vlib_mains - 1,
234 CLIB_CACHE_LINE_BYTES);
235 for (int i = 0; i < tm->n_vlib_mains; i++)
237 dpdk_per_thread_data_t *ptd = vec_elt_at_index (dm->per_thread_data, i);
238 clib_memset (&ptd->buffer_template, 0, sizeof (vlib_buffer_t));
239 vnet_buffer (&ptd->buffer_template)->sw_if_index[VLIB_TX] = (u32) ~ 0;
243 dm->conf->interface_name_format_decimal ? "%d/%d/%d" : "%x/%x/%x";
245 /* device config defaults */
246 dm->default_port_conf.n_rx_desc = DPDK_NB_RX_DESC_DEFAULT;
247 dm->default_port_conf.n_tx_desc = DPDK_NB_TX_DESC_DEFAULT;
248 dm->default_port_conf.n_rx_queues = 1;
249 dm->default_port_conf.n_tx_queues = tm->n_vlib_mains;
250 dm->default_port_conf.rss_hf = ETH_RSS_IP | ETH_RSS_UDP | ETH_RSS_TCP;
251 dm->default_port_conf.max_lro_pkt_size = DPDK_MAX_LRO_SIZE_DEFAULT;
253 if ((clib_mem_get_default_hugepage_size () == 2 << 20) &&
254 check_l3cache () == 0)
255 dm->default_port_conf.n_rx_desc = dm->default_port_conf.n_tx_desc = 512;
257 RTE_ETH_FOREACH_DEV (port_id)
261 struct rte_eth_dev_info di;
262 dpdk_device_config_t *devconf = 0;
263 vnet_eth_interface_registration_t eir = {};
266 if (!rte_eth_dev_is_valid_port (port_id))
269 if ((rv = rte_eth_dev_info_get (port_id, &di)) != 0)
271 dpdk_log_warn ("[%u] failed to get device info. skipping device.",
278 dpdk_log_warn ("[%u] missing device info. Skipping '%s' device",
279 port_id, di.driver_name);
283 devconf = dpdk_find_startup_config (&di);
285 /* If device is blacklisted, we should skip it */
286 if (devconf->is_blacklisted)
288 dpdk_log_notice ("[%d] Device %s blacklisted. Skipping...", port_id,
293 vec_add2_aligned (dm->devices, xd, 1, CLIB_CACHE_LINE_BYTES);
294 xd->port_id = port_id;
295 xd->device_index = xd - dm->devices;
296 xd->per_interface_next_index = ~0;
298 clib_memcpy (&xd->conf, &dm->default_port_conf,
299 sizeof (dpdk_port_conf_t));
301 /* find driver datea for this PMD */
302 if ((dr = dpdk_driver_find (di.driver_name, &xd->if_desc)))
305 xd->supported_flow_actions = dr->supported_flow_actions;
306 xd->conf.disable_rss = dr->mq_mode_none;
307 xd->conf.disable_rx_scatter = dr->disable_rx_scatter;
308 xd->conf.enable_rxq_int = dr->enable_rxq_int;
309 if (dr->use_intel_phdr_cksum)
310 dpdk_device_flag_set (xd, DPDK_DEVICE_FLAG_INTEL_PHDR_CKSUM, 1);
311 if (dr->int_unmaskable)
312 dpdk_device_flag_set (xd, DPDK_DEVICE_FLAG_INT_UNMASKABLE, 1);
315 dpdk_log_warn ("[%u] unknown driver '%s'", port_id, di.driver_name);
319 xd->name = devconf->name;
323 struct rte_pci_device *pci_dev;
324 if (dr && dr->interface_name_prefix)
326 /* prefix override by driver */
327 xd->name = format (xd->name, "%s", dr->interface_name_prefix);
331 /* interface name prefix from speed_capa */
332 u64 mask = ~((if_name_prefixes[0].link_speed << 1) - 1);
334 if (di.speed_capa & mask)
335 dpdk_log_warn ("[%u] unknown speed capability 0x%x reported",
336 xd->port_id, di.speed_capa & mask);
338 for (int i = 0; i < ARRAY_LEN (if_name_prefixes); i++)
339 if (if_name_prefixes[i].link_speed & di.speed_capa)
342 format (xd->name, "%s", if_name_prefixes[i].pfx);
346 xd->name = format (xd->name, "Ethernet");
349 if (dr && dr->interface_number_from_port_id)
350 xd->name = format (xd->name, "%u", port_id);
351 else if ((pci_dev = dpdk_get_pci_device (&di)))
352 xd->name = format (xd->name, if_num_fmt, pci_dev->addr.bus,
353 pci_dev->addr.devid, pci_dev->addr.function);
355 xd->name = format (xd->name, "%u", port_id);
358 /* Handle representor devices that share the same PCI ID */
359 if ((di.switch_info.domain_id != RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID) &&
360 (di.switch_info.port_id != (uint16_t) -1))
361 xd->name = format (xd->name, "/%d", di.switch_info.port_id);
363 /* number of RX and TX queues */
364 if (devconf->num_tx_queues > 0)
366 if (di.max_tx_queues < devconf->num_tx_queues)
367 dpdk_log_warn ("[%u] Configured number of TX queues (%u) is "
368 "bigger than maximum supported (%u)",
369 port_id, devconf->num_tx_queues, di.max_tx_queues);
370 xd->conf.n_tx_queues = devconf->num_tx_queues;
373 xd->conf.n_tx_queues = clib_min (di.max_tx_queues, xd->conf.n_tx_queues);
375 if (devconf->num_rx_queues > 1 &&
376 di.max_rx_queues >= devconf->num_rx_queues)
378 xd->conf.n_rx_queues = devconf->num_rx_queues;
381 u64 unsupported_bits;
382 xd->conf.rss_hf = devconf->rss_fn;
383 unsupported_bits = xd->conf.rss_hf;
384 unsupported_bits &= ~di.flow_type_rss_offloads;
385 if (unsupported_bits)
386 dpdk_log_warn ("Unsupported RSS hash functions: %U",
387 format_dpdk_rss_hf_name, unsupported_bits);
389 xd->conf.rss_hf &= di.flow_type_rss_offloads;
390 dpdk_log_debug ("[%u] rss_hf: %U", port_id, format_dpdk_rss_hf_name,
394 #ifndef RTE_VLAN_HLEN
395 #define RTE_VLAN_HLEN 4
397 xd->driver_frame_overhead =
398 RTE_ETHER_HDR_LEN + 2 * RTE_VLAN_HLEN + RTE_ETHER_CRC_LEN;
399 #if RTE_VERSION >= RTE_VERSION_NUM(21, 11, 0, 0)
400 q = di.max_rx_pktlen - di.max_mtu;
402 if (q < xd->driver_frame_overhead && q > 0)
403 xd->driver_frame_overhead = q;
404 dpdk_log_debug ("[%u] min_mtu: %u, max_mtu: %u, min_rx_bufsize: %u, "
405 "max_rx_pktlen: %u, max_lro_pkt_size: %u",
406 xd->port_id, di.min_mtu, di.max_mtu, di.min_rx_bufsize,
407 di.max_rx_pktlen, di.max_lro_pkt_size);
409 dpdk_log_debug ("[%u] driver frame overhead is %u", port_id,
410 xd->driver_frame_overhead);
412 /* number of RX and TX tescriptors */
413 if (devconf->num_rx_desc)
414 xd->conf.n_rx_desc = devconf->num_rx_desc;
415 else if (dr && dr->n_rx_desc)
416 xd->conf.n_rx_desc = dr->n_rx_desc;
418 if (devconf->num_tx_desc)
419 xd->conf.n_tx_desc = devconf->num_tx_desc;
420 else if (dr && dr->n_tx_desc)
421 xd->conf.n_tx_desc = dr->n_tx_desc;
424 "[%u] n_rx_queues: %u n_tx_queues: %u n_rx_desc: %u n_tx_desc: %u",
425 port_id, xd->conf.n_rx_queues, xd->conf.n_tx_queues,
426 xd->conf.n_rx_desc, xd->conf.n_tx_desc);
428 vec_validate_aligned (xd->rx_queues, xd->conf.n_rx_queues - 1,
429 CLIB_CACHE_LINE_BYTES);
431 rte_eth_macaddr_get (port_id, (void *) addr);
433 /* create interface */
434 eir.dev_class_index = dpdk_device_class.index;
435 eir.dev_instance = xd->device_index;
437 eir.cb.flag_change = dpdk_flag_change;
438 eir.cb.set_max_frame_size = dpdk_set_max_frame_size;
439 xd->hw_if_index = vnet_eth_register_interface (vnm, &eir);
440 hi = vnet_get_hw_interface (vnm, xd->hw_if_index);
441 hi->numa_node = xd->cpu_socket = (i8) rte_eth_dev_socket_id (port_id);
442 sw = vnet_get_hw_sw_interface (vnm, xd->hw_if_index);
443 xd->sw_if_index = sw->sw_if_index;
444 dpdk_log_debug ("[%u] interface %s created", port_id, hi->name);
446 ethernet_set_flags (vnm, xd->hw_if_index,
447 ETHERNET_INTERFACE_FLAG_DEFAULT_L3);
449 /* assign worker threads */
450 vnet_hw_if_set_input_node (vnm, xd->hw_if_index, dpdk_input_node.index);
451 if (devconf->workers)
455 clib_bitmap_foreach (j, devconf->workers)
457 dpdk_rx_queue_t *rxq = vec_elt_at_index (xd->rx_queues, q);
458 rxq->queue_index = vnet_hw_if_register_rx_queue (
459 vnm, xd->hw_if_index, q++, vdm->first_worker_thread_index + j);
463 for (q = 0; q < xd->conf.n_rx_queues; q++)
465 dpdk_rx_queue_t *rxq = vec_elt_at_index (xd->rx_queues, q);
466 rxq->queue_index = vnet_hw_if_register_rx_queue (
467 vnm, xd->hw_if_index, q, VNET_HW_IF_RXQ_THREAD_ANY);
470 if (devconf->tso == DPDK_DEVICE_TSO_ON)
472 /*tcp_udp checksum must be enabled*/
473 if (xd->conf.enable_tcp_udp_checksum == 0)
474 dpdk_log_warn ("[%u] TCP/UDP checksum offload must be enabled",
476 else if ((di.tx_offload_capa & DEV_TX_OFFLOAD_TCP_TSO) == 0)
477 dpdk_log_warn ("[%u] TSO not supported by device", xd->port_id);
479 xd->conf.enable_tso = 1;
482 if (devconf->max_lro_pkt_size)
483 xd->conf.max_lro_pkt_size = devconf->max_lro_pkt_size;
485 dpdk_device_setup (xd);
487 /* rss queues should be configured after dpdk_device_setup() */
488 if (devconf->rss_queues)
490 if (vnet_hw_interface_set_rss_queues (vnet_get_main (), hi,
491 devconf->rss_queues))
492 dpdk_log_warn ("[%u] Failed to set rss queues", port_id);
495 if (vec_len (xd->errors))
496 dpdk_log_err ("[%u] setup failed Errors:\n %U", port_id,
497 format_dpdk_device_errors, xd);
500 for (int i = 0; i < vec_len (dm->devices); i++)
501 vnet_hw_if_update_runtime_data (vnm, dm->devices[i].hw_if_index);
507 dpdk_bind_devices_to_uio (dpdk_config_main_t * conf)
509 vlib_main_t *vm = vlib_get_main ();
512 int num_whitelisted = vec_len (conf->dev_confs);
513 vlib_pci_device_info_t *d = 0;
514 vlib_pci_addr_t *addr = 0, *addrs;
517 addrs = vlib_pci_get_all_dev_addrs ();
519 vec_foreach (addr, addrs)
521 dpdk_device_config_t * devconf = 0;
522 vec_reset_length (pci_addr);
523 pci_addr = format (pci_addr, "%U%c", format_vlib_pci_addr, addr, 0);
526 vlib_pci_free_device_info (d);
529 d = vlib_pci_get_device_info (vm, addr, &error);
532 vlib_log_warn (dpdk_main.log_default, "%U", format_clib_error, error);
533 clib_error_free (error);
537 if (d->device_class != PCI_CLASS_NETWORK_ETHERNET && d->device_class != PCI_CLASS_PROCESSOR_CO)
542 uword * p = hash_get (conf->device_config_index_by_pci_addr, addr->as_u32);
550 devconf = pool_elt_at_index (conf->dev_confs, p[0]);
553 /* Enforce Device blacklist by vendor and device */
554 for (i = 0; i < vec_len (conf->blacklist_by_pci_vendor_and_device); i++)
557 vendor = (u16)(conf->blacklist_by_pci_vendor_and_device[i] >> 16);
558 device = (u16)(conf->blacklist_by_pci_vendor_and_device[i] & 0xFFFF);
559 if (d->vendor_id == vendor && d->device_id == device)
562 * Expected case: device isn't whitelisted,
567 /* Device is blacklisted */
568 pool_get (conf->dev_confs, devconf);
569 hash_set (conf->device_config_index_by_pci_addr, addr->as_u32,
570 devconf - conf->dev_confs);
571 devconf->pci_addr.as_u32 = addr->as_u32;
572 devconf->dev_addr_type = VNET_DEV_ADDR_PCI;
573 devconf->is_blacklisted = 1;
576 else /* explicitly whitelisted, ignore the device blacklist */
582 if (d->vendor_id == 0x1af4 &&
583 (d->device_id == VIRTIO_PCI_LEGACY_DEVICEID_NET ||
584 d->device_id == VIRTIO_PCI_MODERN_DEVICEID_NET))
587 else if (d->vendor_id == 0x15ad && d->device_id == 0x07b0)
590 * For vmxnet3 PCI, unless it is explicitly specified in the whitelist,
591 * the default is to put it in the blacklist.
595 pool_get (conf->dev_confs, devconf);
596 hash_set (conf->device_config_index_by_pci_addr, addr->as_u32,
597 devconf - conf->dev_confs);
598 devconf->pci_addr.as_u32 = addr->as_u32;
599 devconf->is_blacklisted = 1;
602 /* all Intel network devices */
603 else if (d->vendor_id == 0x8086 && d->device_class == PCI_CLASS_NETWORK_ETHERNET)
605 /* all Intel QAT devices VFs */
606 else if (d->vendor_id == 0x8086 && d->device_class == PCI_CLASS_PROCESSOR_CO &&
607 (d->device_id == 0x0443 || d->device_id == 0x18a1 || d->device_id == 0x19e3 ||
608 d->device_id == 0x37c9 || d->device_id == 0x6f55))
611 else if (d->vendor_id == 0x1137 &&
612 (d->device_id == 0x0043 || d->device_id == 0x0071))
615 else if (d->vendor_id == 0x1425 && (d->device_id & 0xe000) == 0x4000)
617 /* Amazon Elastic Network Adapter */
618 else if (d->vendor_id == 0x1d0f && d->device_id >= 0xec20 && d->device_id <= 0xec21)
620 /* Cavium Network Adapter */
621 else if (d->vendor_id == 0x177d && d->device_id == 0x9712)
623 /* Cavium FastlinQ QL41000 Series */
624 else if (d->vendor_id == 0x1077 && d->device_id >= 0x8070 && d->device_id <= 0x8090)
626 /* Mellanox CX3, CX3VF */
627 else if (d->vendor_id == 0x15b3 && d->device_id >= 0x1003 && d->device_id <= 0x1004)
631 /* Mellanox CX4, CX4VF, CX4LX, CX4LXVF, CX5, CX5VF, CX5EX, CX5EXVF */
632 else if (d->vendor_id == 0x15b3 && d->device_id >= 0x1013 && d->device_id <= 0x101a)
636 /* Mellanox CX6, CX6VF, CX6DX, CX6DXVF */
637 else if (d->vendor_id == 0x15b3 && d->device_id >= 0x101b && d->device_id <= 0x101e)
641 /* Broadcom NetXtreme S, and E series only */
642 else if (d->vendor_id == 0x14e4 &&
643 ((d->device_id >= 0x16c0 &&
644 d->device_id != 0x16c6 && d->device_id != 0x16c7 &&
645 d->device_id != 0x16dd && d->device_id != 0x16f7 &&
646 d->device_id != 0x16fd && d->device_id != 0x16fe &&
647 d->device_id != 0x170d && d->device_id != 0x170c &&
648 d->device_id != 0x170e && d->device_id != 0x1712 &&
649 d->device_id != 0x1713) ||
650 (d->device_id == 0x1604 || d->device_id == 0x1605 ||
651 d->device_id == 0x1614 || d->device_id == 0x1606 ||
652 d->device_id == 0x1609 || d->device_id == 0x1614)))
656 dpdk_log_warn ("Unsupported PCI device 0x%04x:0x%04x found "
657 "at PCI address %s\n", (u16) d->vendor_id, (u16) d->device_id,
662 error = vlib_pci_bind_to_uio (vm, addr, (char *) conf->uio_driver_name);
668 pool_get (conf->dev_confs, devconf);
669 hash_set (conf->device_config_index_by_pci_addr, addr->as_u32,
670 devconf - conf->dev_confs);
671 devconf->pci_addr.as_u32 = addr->as_u32;
673 devconf->dev_addr_type = VNET_DEV_ADDR_PCI;
674 devconf->is_blacklisted = 1;
675 clib_error_report (error);
680 vlib_pci_free_device_info (d);
684 dpdk_bind_vmbus_devices_to_uio (dpdk_config_main_t * conf)
687 vlib_vmbus_addr_t *addrs, *addr = 0;
688 int num_whitelisted = vec_len (conf->dev_confs);
691 addrs = vlib_vmbus_get_all_dev_addrs ();
694 vec_foreach (addr, addrs)
696 dpdk_device_config_t *devconf = 0;
700 mhash_get (&conf->device_config_index_by_vmbus_addr, addr);
703 /* No devices blacklisted, but have whitelisted. blacklist all
705 pool_get (conf->dev_confs, devconf);
706 mhash_set (&conf->device_config_index_by_vmbus_addr, addr,
707 devconf - conf->dev_confs, 0);
708 devconf->vmbus_addr = *addr;
709 devconf->dev_addr_type = VNET_DEV_ADDR_VMBUS;
710 devconf->is_blacklisted = 1;
715 devconf = pool_elt_at_index (conf->dev_confs, p[0]);
718 /* Enforce Device blacklist by vmbus_addr */
719 for (i = 0; i < vec_len (conf->blacklist_by_vmbus_addr); i++)
721 vlib_vmbus_addr_t *a1 = &conf->blacklist_by_vmbus_addr[i];
722 vlib_vmbus_addr_t *a2 = addr;
723 if (memcmp (a1, a2, sizeof (vlib_vmbus_addr_t)) == 0)
727 /* Device not whitelisted */
728 pool_get (conf->dev_confs, devconf);
729 mhash_set (&conf->device_config_index_by_vmbus_addr, addr,
730 devconf - conf->dev_confs, 0);
731 devconf->vmbus_addr = *addr;
732 devconf->dev_addr_type = VNET_DEV_ADDR_VMBUS;
733 devconf->is_blacklisted = 1;
743 error = vlib_vmbus_bind_to_uio (addr);
748 pool_get (conf->dev_confs, devconf);
749 mhash_set (&conf->device_config_index_by_vmbus_addr, addr,
750 devconf - conf->dev_confs, 0);
751 devconf->vmbus_addr = *addr;
753 devconf->dev_addr_type = VNET_DEV_ADDR_VMBUS;
754 devconf->is_blacklisted = 1;
755 clib_error_report (error);
762 unformat_max_simd_bitwidth (unformat_input_t *input, va_list *va)
764 uword *max_simd_bitwidth = va_arg (*va, uword *);
766 while (unformat_check_input (input) != UNFORMAT_END_OF_INPUT)
768 if (!unformat (input, "%u", max_simd_bitwidth))
771 if (*max_simd_bitwidth != DPDK_MAX_SIMD_BITWIDTH_256 &&
772 *max_simd_bitwidth != DPDK_MAX_SIMD_BITWIDTH_512)
780 static clib_error_t *
781 dpdk_device_config (dpdk_config_main_t *conf, void *addr,
782 dpdk_device_addr_type_t addr_type, unformat_input_t *input,
785 clib_error_t *error = 0;
787 dpdk_device_config_t *devconf = 0;
788 unformat_input_t sub_input;
792 devconf = &conf->default_devconf;
794 else if (addr_type == VNET_DEV_ADDR_PCI)
796 p = hash_get (conf->device_config_index_by_pci_addr,
797 ((vlib_pci_addr_t *) (addr))->as_u32);
801 pool_get (conf->dev_confs, devconf);
802 hash_set (conf->device_config_index_by_pci_addr,
803 ((vlib_pci_addr_t *) (addr))->as_u32,
804 devconf - conf->dev_confs);
807 return clib_error_return (0,
808 "duplicate configuration for PCI address %U",
809 format_vlib_pci_addr, addr);
811 else if (addr_type == VNET_DEV_ADDR_VMBUS)
813 p = mhash_get (&conf->device_config_index_by_vmbus_addr,
814 (vlib_vmbus_addr_t *) (addr));
818 pool_get (conf->dev_confs, devconf);
819 mhash_set (&conf->device_config_index_by_vmbus_addr, addr,
820 devconf - conf->dev_confs, 0);
823 return clib_error_return (
824 0, "duplicate configuration for VMBUS address %U",
825 format_vlib_vmbus_addr, addr);
828 if (addr_type == VNET_DEV_ADDR_PCI)
830 devconf->pci_addr.as_u32 = ((vlib_pci_addr_t *) (addr))->as_u32;
831 devconf->tso = DPDK_DEVICE_TSO_DEFAULT;
832 devconf->dev_addr_type = VNET_DEV_ADDR_PCI;
834 else if (addr_type == VNET_DEV_ADDR_VMBUS)
836 devconf->vmbus_addr = *((vlib_vmbus_addr_t *) (addr));
837 devconf->tso = DPDK_DEVICE_TSO_DEFAULT;
838 devconf->dev_addr_type = VNET_DEV_ADDR_VMBUS;
844 unformat_skip_white_space (input);
845 while (unformat_check_input (input) != UNFORMAT_END_OF_INPUT)
847 if (unformat (input, "num-rx-queues %u", &devconf->num_rx_queues))
849 else if (unformat (input, "num-tx-queues %u", &devconf->num_tx_queues))
851 else if (unformat (input, "num-rx-desc %u", &devconf->num_rx_desc))
853 else if (unformat (input, "num-tx-desc %u", &devconf->num_tx_desc))
855 else if (unformat (input, "name %v", &devconf->name))
857 else if (unformat (input, "workers %U", unformat_bitmap_list,
862 (input, "rss %U", unformat_vlib_cli_sub_input, &sub_input))
864 error = unformat_rss_fn (&sub_input, &devconf->rss_fn);
868 else if (unformat (input, "tso on"))
870 devconf->tso = DPDK_DEVICE_TSO_ON;
872 else if (unformat (input, "tso off"))
874 devconf->tso = DPDK_DEVICE_TSO_OFF;
876 else if (unformat (input, "devargs %s", &devconf->devargs))
878 else if (unformat (input, "rss-queues %U",
879 unformat_bitmap_list, &devconf->rss_queues))
881 else if (unformat (input, "max-lro-pkt-size %u",
882 &devconf->max_lro_pkt_size))
886 error = clib_error_return (0, "unknown input `%U'",
887 format_unformat_error, input);
895 if (devconf->workers && devconf->num_rx_queues == 0)
896 devconf->num_rx_queues = clib_bitmap_count_set_bits (devconf->workers);
897 else if (devconf->workers &&
898 clib_bitmap_count_set_bits (devconf->workers) !=
899 devconf->num_rx_queues)
900 error = clib_error_return (0,
901 "%U: number of worker threads must be "
902 "equal to number of rx queues",
903 format_vlib_pci_addr, addr);
908 static clib_error_t *
909 dpdk_log_read_ready (clib_file_t * uf)
911 unformat_input_t input;
918 uword len = vec_len (s);
919 vec_resize (s, len + n_try);
921 n = read (uf->file_descriptor, s + len, n_try);
922 if (n < 0 && errno != EAGAIN)
923 return clib_error_return_unix (0, "read");
924 _vec_len (s) = len + (n < 0 ? 0 : n);
927 unformat_init_vector (&input, s);
929 while (unformat_user (&input, unformat_line, &line))
934 /* unfortunatelly DPDK polutes log with this error messages
935 * even when we pass --in-memory which means no secondary process */
936 if (strstr ((char *) line, "WARNING! Base virtual address hint"))
938 else if (strstr ((char *) line, "This may cause issues with mapping "
939 "memory into secondary processes"))
943 dpdk_log_notice ("%v", line);
947 unformat_free (&input);
951 static clib_error_t *
952 dpdk_config (vlib_main_t * vm, unformat_input_t * input)
954 dpdk_main_t *dm = &dpdk_main;
955 clib_error_t *error = 0;
956 dpdk_config_main_t *conf = &dpdk_config_main;
957 vlib_thread_main_t *tm = vlib_get_thread_main ();
958 dpdk_device_config_t *devconf;
959 vlib_pci_addr_t pci_addr = { 0 };
960 vlib_vmbus_addr_t vmbus_addr = { 0 };
961 unformat_input_t sub_input;
962 uword default_hugepage_sz, x;
965 int num_whitelisted = 0;
966 int eal_no_hugetlb = 0;
971 u8 *huge_dir_path = 0;
972 u32 vendor, device, domain, bus, func;
977 format (0, "%s/hugepages%c", vlib_unix_get_runtime_dir (), 0);
979 conf->device_config_index_by_pci_addr = hash_create (0, sizeof (uword));
980 mhash_init (&conf->device_config_index_by_vmbus_addr, sizeof (uword),
981 sizeof (vlib_vmbus_addr_t));
983 while (unformat_check_input (input) != UNFORMAT_END_OF_INPUT)
986 if (unformat (input, "no-hugetlb"))
988 vec_add1 (conf->eal_init_args, (u8 *) "--no-huge");
991 else if (unformat (input, "telemetry"))
992 conf->enable_telemetry = 1;
994 else if (unformat (input, "enable-tcp-udp-checksum"))
996 dm->default_port_conf.enable_tcp_udp_checksum = 1;
997 if (unformat (input, "enable-outer-checksum-offload"))
998 dm->default_port_conf.enable_outer_checksum_offload = 1;
1000 else if (unformat (input, "no-tx-checksum-offload"))
1001 dm->default_port_conf.disable_tx_checksum_offload = 1;
1003 else if (unformat (input, "decimal-interface-names"))
1004 conf->interface_name_format_decimal = 1;
1006 else if (unformat (input, "no-multi-seg"))
1007 dm->default_port_conf.disable_multi_seg = 1;
1008 else if (unformat (input, "enable-lro"))
1009 dm->default_port_conf.enable_lro = 1;
1010 else if (unformat (input, "max-simd-bitwidth %U",
1011 unformat_max_simd_bitwidth, &conf->max_simd_bitwidth))
1013 else if (unformat (input, "dev default %U", unformat_vlib_cli_sub_input,
1017 dpdk_device_config (conf, 0, VNET_DEV_ADDR_ANY, &sub_input, 1);
1024 (input, "dev %U %U", unformat_vlib_pci_addr, &pci_addr,
1025 unformat_vlib_cli_sub_input, &sub_input))
1027 error = dpdk_device_config (conf, &pci_addr, VNET_DEV_ADDR_PCI,
1035 else if (unformat (input, "dev %U", unformat_vlib_pci_addr, &pci_addr))
1038 dpdk_device_config (conf, &pci_addr, VNET_DEV_ADDR_PCI, 0, 0);
1045 else if (unformat (input, "dev %U %U", unformat_vlib_vmbus_addr,
1046 &vmbus_addr, unformat_vlib_cli_sub_input, &sub_input))
1048 error = dpdk_device_config (conf, &vmbus_addr, VNET_DEV_ADDR_VMBUS,
1056 else if (unformat (input, "dev %U", unformat_vlib_vmbus_addr,
1060 dpdk_device_config (conf, &vmbus_addr, VNET_DEV_ADDR_VMBUS, 0, 0);
1067 else if (unformat (input, "uio-driver %s", &conf->uio_driver_name))
1069 else if (unformat (input, "socket-mem %s", &socket_mem))
1071 else if (unformat (input, "no-pci"))
1074 tmp = format (0, "--no-pci%c", 0);
1075 vec_add1 (conf->eal_init_args, tmp);
1077 else if (unformat (input, "blacklist %U", unformat_vlib_vmbus_addr,
1080 vec_add1 (conf->blacklist_by_vmbus_addr, vmbus_addr);
1084 (input, "blacklist %x:%x:%x.%x", &domain, &bus, &device, &func))
1086 tmp = format (0, "-b%c", 0);
1087 vec_add1 (conf->eal_init_args, tmp);
1089 format (0, "%04x:%02x:%02x.%x%c", domain, bus, device, func, 0);
1090 vec_add1 (conf->eal_init_args, tmp);
1092 else if (unformat (input, "blacklist %x:%x", &vendor, &device))
1094 u32 blacklist_entry;
1095 if (vendor > 0xFFFF)
1096 return clib_error_return (0, "blacklist PCI vendor out of range");
1097 if (device > 0xFFFF)
1098 return clib_error_return (0, "blacklist PCI device out of range");
1099 blacklist_entry = (vendor << 16) | (device & 0xffff);
1100 vec_add1 (conf->blacklist_by_pci_vendor_and_device,
1103 else if (unformat (input, "no-vmbus"))
1106 tmp = format (0, "--no-vmbus%c", 0);
1107 vec_add1 (conf->eal_init_args, tmp);
1111 else if (unformat(input, #a)) \
1113 tmp = format (0, "--%s%c", #a, 0); \
1114 vec_add1 (conf->eal_init_args, tmp); \
1116 foreach_eal_double_hyphen_predicate_arg
1119 else if (unformat(input, #a " %s", &s)) \
1121 if (!strncmp(#a, "file-prefix", 11)) \
1123 tmp = format (0, "--%s%c", #a, 0); \
1124 vec_add1 (conf->eal_init_args, tmp); \
1126 if (!strncmp(#a, "vdev", 4)) \
1127 if (strstr((char*)s, "af_packet")) \
1128 clib_warning ("af_packet obsoleted. Use CLI 'create host-interface'."); \
1129 vec_add1 (conf->eal_init_args, s); \
1131 foreach_eal_double_hyphen_arg
1134 else if (unformat(input, #a " %s", &s)) \
1136 tmp = format (0, "-%s%c", #b, 0); \
1137 vec_add1 (conf->eal_init_args, tmp); \
1139 vec_add1 (conf->eal_init_args, s); \
1141 foreach_eal_single_hyphen_arg
1143 else if (unformat (input, "default"))
1146 else if (unformat_skip_white_space (input))
1150 error = clib_error_return (0, "unknown input `%U'",
1151 format_unformat_error, input);
1156 if (!conf->uio_driver_name)
1157 conf->uio_driver_name = format (0, "auto%c", 0);
1159 if (eal_no_hugetlb == 0)
1161 vec_add1 (conf->eal_init_args, (u8 *) "--in-memory");
1163 default_hugepage_sz = clib_mem_get_default_hugepage_size ();
1166 clib_bitmap_foreach (x, tm->cpu_socket_bitmap)
1170 /* preallocate at least 16MB of hugepages per socket,
1171 if more is needed it is up to consumer to preallocate more */
1172 n_pages = round_pow2 ((uword) 16 << 20, default_hugepage_sz);
1173 n_pages /= default_hugepage_sz;
1175 if ((e = clib_sysfs_prealloc_hugepages(x, 0, n_pages)))
1176 clib_error_report (e);
1181 /* on/off dpdk's telemetry thread */
1182 if (conf->enable_telemetry == 0)
1184 vec_add1 (conf->eal_init_args, (u8 *) "--no-telemetry");
1189 tmp = format (0, "--file-prefix%c", 0);
1190 vec_add1 (conf->eal_init_args, tmp);
1191 tmp = format (0, "vpp%c", 0);
1192 vec_add1 (conf->eal_init_args, tmp);
1198 if (no_pci == 0 && geteuid () == 0)
1199 dpdk_bind_devices_to_uio (conf);
1201 if (no_vmbus == 0 && geteuid () == 0)
1202 dpdk_bind_vmbus_devices_to_uio (conf);
1205 if (devconf->x == 0 && conf->default_devconf.x > 0) \
1206 devconf->x = conf->default_devconf.x ;
1208 pool_foreach (devconf, conf->dev_confs) {
1210 /* default per-device config items */
1211 foreach_dpdk_device_config_item
1213 /* copy tso config from default device */
1216 /* copy tso config from default device */
1219 /* copy rss_queues config from default device */
1222 /* assume that default is PCI */
1223 fmt_func = format_vlib_pci_addr;
1224 fmt_addr = &devconf->pci_addr;
1226 if (devconf->dev_addr_type == VNET_DEV_ADDR_VMBUS)
1228 fmt_func = format_vlib_vmbus_addr;
1229 fmt_addr = &devconf->vmbus_addr;
1232 /* add DPDK EAL whitelist/blacklist entry */
1233 if (num_whitelisted > 0 && devconf->is_blacklisted == 0)
1235 tmp = format (0, "-a%c", 0);
1236 vec_add1 (conf->eal_init_args, tmp);
1237 if (devconf->devargs)
1240 format (0, "%U,%s%c", fmt_func, fmt_addr, devconf->devargs, 0);
1244 tmp = format (0, "%U%c", fmt_func, fmt_addr, 0);
1246 vec_add1 (conf->eal_init_args, tmp);
1248 else if (num_whitelisted == 0 && devconf->is_blacklisted != 0)
1250 tmp = format (0, "-b%c", 0);
1251 vec_add1 (conf->eal_init_args, tmp);
1252 tmp = format (0, "%U%c", fmt_func, fmt_addr, 0);
1253 vec_add1 (conf->eal_init_args, tmp);
1260 clib_warning ("socket-mem argument is deprecated");
1262 /* NULL terminate the "argv" vector, in case of stupidity */
1263 vec_add1 (conf->eal_init_args, 0);
1264 _vec_len (conf->eal_init_args) -= 1;
1266 /* Set up DPDK eal and packet mbuf pool early. */
1268 int log_fds[2] = { 0 };
1269 if (pipe (log_fds) == 0)
1271 if (fcntl (log_fds[1], F_SETFL, O_NONBLOCK) == 0)
1273 FILE *f = fdopen (log_fds[1], "a");
1274 if (f && rte_openlog_stream (f) == 0)
1276 clib_file_t t = { 0 };
1277 t.read_function = dpdk_log_read_ready;
1278 t.file_descriptor = log_fds[0];
1279 t.description = format (0, "DPDK logging pipe");
1280 clib_file_add (&file_main, &t);
1290 vm = vlib_get_main ();
1292 /* make copy of args as rte_eal_init tends to mess up with arg array */
1293 for (i = 1; i < vec_len (conf->eal_init_args); i++)
1294 conf->eal_init_args_str = format (conf->eal_init_args_str, "%s ",
1295 conf->eal_init_args[i]);
1297 vec_terminate_c_string (conf->eal_init_args_str);
1299 dpdk_log_notice ("EAL init args: %s", conf->eal_init_args_str);
1300 ret = rte_eal_init (vec_len (conf->eal_init_args),
1301 (char **) conf->eal_init_args);
1303 /* enable the AVX-512 vPMDs in DPDK */
1304 if (clib_cpu_supports_avx512_bitalg () &&
1305 conf->max_simd_bitwidth == DPDK_MAX_SIMD_BITWIDTH_DEFAULT)
1306 rte_vect_set_max_simd_bitwidth (RTE_VECT_SIMD_512);
1307 else if (conf->max_simd_bitwidth != DPDK_MAX_SIMD_BITWIDTH_DEFAULT)
1308 rte_vect_set_max_simd_bitwidth (conf->max_simd_bitwidth ==
1309 DPDK_MAX_SIMD_BITWIDTH_256 ?
1313 /* lazy umount hugepages */
1314 umount2 ((char *) huge_dir_path, MNT_DETACH);
1315 rmdir ((char *) huge_dir_path);
1316 vec_free (huge_dir_path);
1319 return clib_error_return (0, "rte_eal_init returned %d", ret);
1321 /* main thread 1st */
1322 if ((error = dpdk_buffer_pools_create (vm)))
1329 VLIB_CONFIG_FUNCTION (dpdk_config, "dpdk");
1332 dpdk_update_link_state (dpdk_device_t * xd, f64 now)
1334 vnet_main_t *vnm = vnet_get_main ();
1335 struct rte_eth_link prev_link = xd->link;
1337 u8 hw_flags_chg = 0;
1339 xd->time_last_link_update = now ? now : xd->time_last_link_update;
1340 clib_memset (&xd->link, 0, sizeof (xd->link));
1341 rte_eth_link_get_nowait (xd->port_id, &xd->link);
1343 if (LINK_STATE_ELOGS)
1345 ELOG_TYPE_DECLARE (e) =
1348 "update-link-state: sw_if_index %d, admin_up %d,"
1349 "old link_state %d new link_state %d",.format_args = "i4i1i1i1",};
1358 ed = ELOG_DATA (&vlib_global_main.elog_main, e);
1359 ed->sw_if_index = xd->sw_if_index;
1360 ed->admin_up = (xd->flags & DPDK_DEVICE_FLAG_ADMIN_UP) != 0;
1361 ed->old_link_state = (u8)
1362 vnet_hw_interface_is_link_up (vnm, xd->hw_if_index);
1363 ed->new_link_state = (u8) xd->link.link_status;
1366 if ((xd->link.link_duplex != prev_link.link_duplex))
1369 switch (xd->link.link_duplex)
1371 case ETH_LINK_HALF_DUPLEX:
1372 hw_flags |= VNET_HW_INTERFACE_FLAG_HALF_DUPLEX;
1374 case ETH_LINK_FULL_DUPLEX:
1375 hw_flags |= VNET_HW_INTERFACE_FLAG_FULL_DUPLEX;
1381 if (xd->link.link_speed != prev_link.link_speed)
1382 vnet_hw_interface_set_link_speed (vnm, xd->hw_if_index,
1383 xd->link.link_speed * 1000);
1385 if (xd->link.link_status != prev_link.link_status)
1389 if (xd->link.link_status)
1390 hw_flags |= VNET_HW_INTERFACE_FLAG_LINK_UP;
1395 if (LINK_STATE_ELOGS)
1397 ELOG_TYPE_DECLARE (e) =
1400 "update-link-state: sw_if_index %d, new flags %d",.format_args
1408 ed = ELOG_DATA (&vlib_global_main.elog_main, e);
1409 ed->sw_if_index = xd->sw_if_index;
1410 ed->flags = hw_flags;
1412 vnet_hw_interface_set_flags (vnm, xd->hw_if_index, hw_flags);
1417 dpdk_process (vlib_main_t * vm, vlib_node_runtime_t * rt, vlib_frame_t * f)
1419 clib_error_t *error;
1420 dpdk_main_t *dm = &dpdk_main;
1422 vlib_thread_main_t *tm = vlib_get_thread_main ();
1424 error = dpdk_lib_init (dm);
1427 clib_error_report (error);
1429 if (dpdk_cryptodev_init)
1431 error = dpdk_cryptodev_init (vm);
1434 vlib_log_warn (dpdk_main.log_cryptodev, "%U", format_clib_error,
1436 clib_error_free (error);
1440 tm->worker_thread_release = 1;
1442 f64 now = vlib_time_now (vm);
1443 vec_foreach (xd, dm->devices)
1445 dpdk_update_link_state (xd, now);
1451 * check each time through the loop in case intervals are changed
1453 f64 min_wait = dm->link_state_poll_interval < dm->stat_poll_interval ?
1454 dm->link_state_poll_interval : dm->stat_poll_interval;
1456 vlib_process_wait_for_event_or_clock (vm, min_wait);
1458 if (dm->admin_up_down_in_progress)
1459 /* skip the poll if an admin up down is in progress (on any interface) */
1462 vec_foreach (xd, dm->devices)
1464 f64 now = vlib_time_now (vm);
1465 if ((now - xd->time_last_stats_update) >= dm->stat_poll_interval)
1466 dpdk_update_counters (xd, now);
1467 if ((now - xd->time_last_link_update) >= dm->link_state_poll_interval)
1468 dpdk_update_link_state (xd, now);
1477 VLIB_REGISTER_NODE (dpdk_process_node,static) = {
1478 .function = dpdk_process,
1479 .type = VLIB_NODE_TYPE_PROCESS,
1480 .name = "dpdk-process",
1481 .process_log2_n_stack_bytes = 17,
1485 static clib_error_t *
1486 dpdk_init (vlib_main_t * vm)
1488 dpdk_main_t *dm = &dpdk_main;
1489 clib_error_t *error = 0;
1491 /* verify that structs are cacheline aligned */
1492 STATIC_ASSERT (offsetof (dpdk_device_t, cacheline0) == 0,
1493 "Cache line marker must be 1st element in dpdk_device_t");
1494 STATIC_ASSERT (offsetof (dpdk_device_t, cacheline1) ==
1495 CLIB_CACHE_LINE_BYTES,
1496 "Data in cache line 0 is bigger than cache line size");
1497 STATIC_ASSERT (offsetof (frame_queue_trace_t, cacheline0) == 0,
1498 "Cache line marker must be 1st element in frame_queue_trace_t");
1500 dpdk_cli_reference ();
1502 dm->conf = &dpdk_config_main;
1504 vec_add1 (dm->conf->eal_init_args, (u8 *) "vnet");
1506 dm->stat_poll_interval = DPDK_STATS_POLL_INTERVAL;
1507 dm->link_state_poll_interval = DPDK_LINK_POLL_INTERVAL;
1509 dm->log_default = vlib_log_register_class ("dpdk", 0);
1510 dm->log_cryptodev = vlib_log_register_class ("dpdk", "cryptodev");
1515 VLIB_INIT_FUNCTION (dpdk_init);
1517 static clib_error_t *
1518 dpdk_worker_thread_init (vlib_main_t *vm)
1520 if (rte_thread_register () < 0)
1521 clib_panic ("dpdk: cannot register thread %u - %s", vm->thread_index,
1522 rte_strerror (rte_errno));
1526 VLIB_WORKER_INIT_FUNCTION (dpdk_worker_thread_init);