2 * Copyright (c) 2016-2019 Cisco and/or its affiliates.
3 * Licensed under the Apache License, Version 2.0 (the "License");
4 * you may not use this file except in compliance with the License.
5 * You may obtain a copy of the License at:
7 * http://www.apache.org/licenses/LICENSE-2.0
9 * Unless required by applicable law or agreed to in writing, software
10 * distributed under the License is distributed on an "AS IS" BASIS,
11 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 * See the License for the specific language governing permissions and
13 * limitations under the License.
16 #include <svm/fifo_segment.h>
17 #include <vppinfra/mem.h>
20 fsh_alloc_aligned (fifo_segment_header_t *fsh, uword size, uword align)
22 uword cur_pos, cur_pos_align, new_pos;
24 cur_pos = clib_atomic_load_relax_n (&fsh->byte_index);
25 cur_pos_align = round_pow2_u64 (cur_pos, align);
26 size = round_pow2_u64 (size, align);
27 new_pos = cur_pos_align + size;
29 if (new_pos >= fsh->max_byte_index)
32 while (!clib_atomic_cmp_and_swap_acq_relax (&fsh->byte_index, &cur_pos,
33 &new_pos, 1 /* weak */))
35 cur_pos_align = round_pow2_u64 (cur_pos, align);
36 new_pos = cur_pos_align + size;
37 if (new_pos >= fsh->max_byte_index)
40 return uword_to_pointer ((u8 *) fsh + cur_pos_align, void *);
44 fsh_alloc (fifo_segment_header_t *fsh, uword size)
46 return fsh_alloc_aligned (fsh, size, 8);
49 static inline fifo_segment_slice_t *
50 fsh_slice_get (fifo_segment_header_t * fsh, u32 slice_index)
52 return &fsh->slices[slice_index];
55 static inline fifo_slice_private_t *
56 fs_slice_private_get (fifo_segment_t *fs, u32 slice_index)
58 ASSERT (slice_index < fs->n_slices);
59 return &fs->slices[slice_index];
62 static char *fifo_segment_mem_status_strings[] = {
63 #define _(sym,str) str,
64 foreach_segment_mem_status
69 fsh_n_free_bytes (fifo_segment_header_t * fsh)
71 uword cur_pos = clib_atomic_load_relax_n (&fsh->byte_index);
72 ASSERT (fsh->max_byte_index > cur_pos);
73 return fsh->max_byte_index - cur_pos;
77 fsh_cached_bytes_add (fifo_segment_header_t * fsh, uword size)
79 clib_atomic_fetch_add_rel (&fsh->n_cached_bytes, size);
83 fsh_cached_bytes_sub (fifo_segment_header_t * fsh, uword size)
85 clib_atomic_fetch_sub_rel (&fsh->n_cached_bytes, size);
89 fsh_n_cached_bytes (fifo_segment_header_t * fsh)
91 uword n_cached = clib_atomic_load_relax_n (&fsh->n_cached_bytes);
96 fsh_active_fifos_update (fifo_segment_header_t * fsh, int inc)
98 clib_atomic_fetch_add_rel (&fsh->n_active_fifos, inc);
102 fsh_n_active_fifos (fifo_segment_header_t * fsh)
104 return clib_atomic_load_relax_n (&fsh->n_active_fifos);
108 fs_virtual_mem (fifo_segment_t *fs)
110 fifo_segment_header_t *fsh = fs->h;
111 fifo_segment_slice_t *fss;
115 for (i = 0; i < fs->n_slices; i++)
117 fss = fsh_slice_get (fsh, i);
118 total_vm += clib_atomic_load_relax_n (&fss->virtual_mem);
124 fsh_virtual_mem_update (fifo_segment_header_t * fsh, u32 slice_index,
127 fifo_segment_slice_t *fss = fsh_slice_get (fsh, slice_index);
128 fss->virtual_mem += n_bytes;
132 fss_chunk_fl_index_is_valid (fifo_segment_slice_t *fss, u32 fl_index)
134 return (fl_index < FS_CHUNK_VEC_LEN);
137 #define FS_CL_HEAD_MASK 0xFFFFFFFFFFFF
138 #define FS_CL_HEAD_TMASK 0xFFFF000000000000
139 #define FS_CL_HEAD_TINC (1ULL << 48)
141 static svm_fifo_chunk_t *
142 fss_chunk_free_list_head (fifo_segment_header_t *fsh,
143 fifo_segment_slice_t *fss, u32 fl_index)
145 fs_sptr_t headsp = clib_atomic_load_relax_n (&fss->free_chunks[fl_index]);
146 return fs_chunk_ptr (fsh, headsp & FS_CL_HEAD_MASK);
150 fss_chunk_free_list_push (fifo_segment_header_t *fsh,
151 fifo_segment_slice_t *fss, u32 fl_index,
154 fs_sptr_t old_head, new_head, csp;
156 csp = fs_chunk_sptr (fsh, c);
157 ASSERT (csp <= FS_CL_HEAD_MASK);
158 old_head = clib_atomic_load_acq_n (&fss->free_chunks[fl_index]);
162 c->next = old_head & FS_CL_HEAD_MASK;
163 new_head = csp + ((old_head + FS_CL_HEAD_TINC) & FS_CL_HEAD_TMASK);
165 while (!__atomic_compare_exchange (&fss->free_chunks[fl_index], &old_head,
166 &new_head, 0 /* weak */, __ATOMIC_RELEASE,
171 fss_chunk_free_list_push_list (fifo_segment_header_t *fsh,
172 fifo_segment_slice_t *fss, u32 fl_index,
173 svm_fifo_chunk_t *head, svm_fifo_chunk_t *tail)
175 fs_sptr_t old_head, new_head, headsp;
177 headsp = fs_chunk_sptr (fsh, head);
178 ASSERT (headsp <= FS_CL_HEAD_MASK);
179 old_head = clib_atomic_load_acq_n (&fss->free_chunks[fl_index]);
183 tail->next = old_head & FS_CL_HEAD_MASK;
184 new_head = headsp + ((old_head + FS_CL_HEAD_TINC) & FS_CL_HEAD_TMASK);
186 while (!__atomic_compare_exchange (&fss->free_chunks[fl_index], &old_head,
187 &new_head, 0 /* weak */, __ATOMIC_RELEASE,
191 static svm_fifo_chunk_t *
192 fss_chunk_free_list_pop (fifo_segment_header_t *fsh, fifo_segment_slice_t *fss,
195 fs_sptr_t old_head, new_head;
198 ASSERT (fss_chunk_fl_index_is_valid (fss, fl_index));
200 old_head = clib_atomic_load_acq_n (&fss->free_chunks[fl_index]);
202 /* Lock-free stacks are affected by ABA if a side allocates a chunk and
203 * shortly thereafter frees it. To circumvent that, reuse the upper bits
204 * of the head of the list shared pointer, i.e., offset to where the chunk
205 * is, as a tag. The tag is incremented with each push/pop operation and
206 * therefore collisions can only happen if an element is popped and pushed
207 * exactly after a complete wrap of the tag (16 bits). It's unlikely either
208 * of the sides will be descheduled for that long */
211 if (!(old_head & FS_CL_HEAD_MASK))
213 c = fs_chunk_ptr (fsh, old_head & FS_CL_HEAD_MASK);
214 new_head = c->next + ((old_head + FS_CL_HEAD_TINC) & FS_CL_HEAD_TMASK);
216 while (!__atomic_compare_exchange (&fss->free_chunks[fl_index], &old_head,
217 &new_head, 0 /* weak */, __ATOMIC_RELEASE,
224 fss_fifo_free_list_push (fifo_segment_header_t *fsh, fifo_segment_slice_t *fss,
225 svm_fifo_shared_t *sf)
227 sf->next = fss->free_fifos;
228 fss->free_fifos = fs_sptr (fsh, sf);
232 fss_fifo_free_list_push_list (fifo_segment_header_t *fsh,
233 fifo_segment_slice_t *fss,
234 svm_fifo_shared_t *head, svm_fifo_shared_t *tail)
236 tail->next = fss->free_fifos;
237 fss->free_fifos = fs_sptr (fsh, head);
241 fss_fifo_free_list_pop (fifo_segment_header_t *fsh, fifo_segment_slice_t *fss)
243 svm_fifo_shared_t *sf;
244 sf = fs_ptr (fsh, fss->free_fifos);
245 fss->free_fifos = sf->next;
250 pfss_fifo_add_active_list (fifo_slice_private_t *pfss, svm_fifo_t *f)
252 if (pfss->active_fifos)
254 pfss->active_fifos->prev = f;
255 f->next = pfss->active_fifos;
257 pfss->active_fifos = f;
261 pfss_fifo_del_active_list (fifo_slice_private_t *pfss, svm_fifo_t *f)
263 if (f->flags & SVM_FIFO_F_LL_TRACKED)
266 f->prev->next = f->next;
268 pfss->active_fifos = f->next;
270 f->next->prev = f->prev;
275 fss_fl_chunk_bytes (fifo_segment_slice_t * fss)
277 return clib_atomic_load_relax_n (&fss->n_fl_chunk_bytes);
281 fss_fl_chunk_bytes_add (fifo_segment_slice_t * fss, uword size)
283 clib_atomic_fetch_add_relax (&fss->n_fl_chunk_bytes, size);
287 fss_fl_chunk_bytes_sub (fifo_segment_slice_t * fss, uword size)
289 clib_atomic_fetch_sub_relax (&fss->n_fl_chunk_bytes, size);
293 * Initialize fifo segment shared header
296 fifo_segment_init (fifo_segment_t * fs)
298 u32 align = 8, offset = 2 * 4096, slices_sz, i;
299 uword max_fifo, seg_start, seg_sz;
300 fifo_segment_header_t *fsh;
301 ssvm_shared_header_t *sh;
304 /* TODO remove ssvm heap entirely */
307 seg_data = (u8 *) sh + offset;
308 seg_sz = sh->ssvm_size - offset;
310 fs->n_slices = clib_max (fs->n_slices, 1);
311 slices_sz = sizeof (fifo_segment_slice_t) * fs->n_slices;
313 seg_start = round_pow2_u64 (pointer_to_uword (seg_data), align);
314 fsh = uword_to_pointer (seg_start, void *);
315 CLIB_MEM_UNPOISON (fsh, seg_sz);
316 memset (fsh, 0, sizeof (*fsh) + slices_sz);
318 fsh->byte_index = sizeof (*fsh) + slices_sz;
319 fsh->max_byte_index = seg_sz;
320 fsh->n_slices = fs->n_slices;
321 max_fifo = clib_min ((seg_sz - slices_sz) / 2, FIFO_SEGMENT_MAX_FIFO_SIZE);
322 fsh->max_log2_fifo_size = min_log2 (max_fifo);
323 fsh->n_cached_bytes = 0;
324 fsh->n_reserved_bytes = fsh->byte_index;
325 fsh->start_byte_index = fsh->byte_index;
326 ASSERT (fsh->max_byte_index <= sh->ssvm_size - offset);
328 fs->max_byte_index = fsh->max_byte_index;
330 sh->opaque[0] = (void *) ((u8 *) fsh - (u8 *) fs->ssvm.sh);
332 /* Allow random offsets */
333 fs->ssvm.sh->ssvm_va = 0;
335 vec_validate (fs->slices, fs->n_slices - 1);
336 for (i = 0; i < fs->n_slices; i++)
337 fs->slices[i].fifos =
338 clib_mem_bulk_init (sizeof (svm_fifo_t), CLIB_CACHE_LINE_BYTES, 32);
345 * Create a fifo segment and initialize as master
348 fifo_segment_create (fifo_segment_main_t * sm, fifo_segment_create_args_t * a)
354 /* Allocate a fresh segment */
355 pool_get_zero (sm->segments, fs);
357 baseva = a->segment_type == SSVM_SEGMENT_PRIVATE ? ~0ULL : sm->next_baseva;
358 fs->ssvm.ssvm_size = a->segment_size;
359 fs->ssvm.is_server = 1;
360 fs->ssvm.my_pid = getpid ();
361 fs->ssvm.name = format (0, "%s%c", a->segment_name, 0);
362 fs->ssvm.requested_va = baseva;
364 if ((rv = ssvm_server_init (&fs->ssvm, a->segment_type)))
366 pool_put (sm->segments, fs);
370 /* Note: requested_va updated due to seg base addr randomization */
371 sm->next_baseva = fs->ssvm.sh->ssvm_va + fs->ssvm.ssvm_size;
373 fifo_segment_init (fs);
374 vec_add1 (a->new_segment_indices, fs - sm->segments);
379 * Attach as slave to a fifo segment
382 fifo_segment_attach (fifo_segment_main_t * sm, fifo_segment_create_args_t * a)
384 fifo_segment_header_t *fsh;
388 pool_get_zero (sm->segments, fs);
390 fs->ssvm.ssvm_size = a->segment_size;
391 fs->ssvm.my_pid = getpid ();
392 fs->ssvm.name = format (0, "%s%c", a->segment_name, 0);
393 fs->ssvm.requested_va = 0;
394 if (a->segment_type == SSVM_SEGMENT_MEMFD)
395 fs->ssvm.fd = a->memfd_fd;
397 fs->ssvm.attach_timeout = sm->timeout_in_seconds;
399 if ((rv = ssvm_client_init (&fs->ssvm, a->segment_type)))
401 pool_put (sm->segments, fs);
405 /* Probably a segment without fifos */
406 if (!fs->ssvm.sh->opaque[0])
409 fsh = fs->h = (void *) fs->ssvm.sh + (uword) fs->ssvm.sh->opaque[0];
410 fs->max_byte_index = fsh->max_byte_index;
411 vec_validate (fs->slices, 0);
412 fs->slices[0].fifos =
413 clib_mem_bulk_init (sizeof (svm_fifo_t), CLIB_CACHE_LINE_BYTES, 32);
416 vec_add1 (a->new_segment_indices, fs - sm->segments);
421 fifo_segment_delete (fifo_segment_main_t * sm, fifo_segment_t * s)
423 fifo_segment_cleanup (s);
424 ssvm_delete (&s->ssvm);
425 clib_memset (s, 0xfe, sizeof (*s));
426 pool_put (sm->segments, s);
430 fifo_segment_index (fifo_segment_main_t * sm, fifo_segment_t * s)
432 return s - sm->segments;
436 fifo_segment_get_segment (fifo_segment_main_t * sm, u32 segment_index)
438 return pool_elt_at_index (sm->segments, segment_index);
442 fifo_segment_get_segment_if_valid (fifo_segment_main_t *sm, u32 segment_index)
444 if (pool_is_free_index (sm->segments, segment_index))
446 return pool_elt_at_index (sm->segments, segment_index);
450 fifo_segment_info (fifo_segment_t * seg, char **address, size_t * size)
452 *address = (char *) seg->ssvm.sh->ssvm_va;
453 *size = seg->ssvm.ssvm_size;
457 fifo_segment_main_init (fifo_segment_main_t * sm, u64 baseva,
458 u32 timeout_in_seconds)
460 sm->next_baseva = baseva;
461 sm->timeout_in_seconds = timeout_in_seconds;
465 fs_freelist_for_size (u32 size)
467 if (PREDICT_FALSE (size < FIFO_SEGMENT_MIN_FIFO_SIZE))
469 return clib_min (max_log2 (size) - FIFO_SEGMENT_MIN_LOG2_FIFO_SIZE,
470 FS_CHUNK_VEC_LEN - 1);
474 fs_freelist_index_to_size (u32 fl_index)
476 return 1 << (fl_index + FIFO_SEGMENT_MIN_LOG2_FIFO_SIZE);
480 fs_chunk_size_is_valid (fifo_segment_header_t * fsh, u32 size)
483 * 4K minimum. It's not likely that anything good will happen
484 * with a smaller FIFO.
486 return size >= FIFO_SEGMENT_MIN_FIFO_SIZE &&
487 size <= (1ULL << fsh->max_log2_fifo_size);
491 fs_try_alloc_multi_chunk (fifo_segment_header_t * fsh,
492 fifo_segment_slice_t * fss, u32 data_bytes)
494 u32 fl_index, fl_size, n_alloc = 0, req_bytes = data_bytes;
495 svm_fifo_chunk_t *c, *first = 0, *next;
497 fl_index = fs_freelist_for_size (req_bytes);
501 fl_size = fs_freelist_index_to_size (fl_index);
505 c = fss_chunk_free_list_pop (fsh, fss, fl_index);
508 c->next = fs_chunk_sptr (fsh, first);
511 req_bytes -= clib_min (fl_size, req_bytes);
515 /* Failed to allocate with smaller chunks */
518 /* Free all chunks if any allocated */
522 fl_index = fs_freelist_for_size (c->length);
523 next = fs_chunk_ptr (fsh, c->next);
524 fss_chunk_free_list_push (fsh, fss, fl_index, c);
529 /* As last attempt, try allocating a chunk larger than
530 * the requested size, if possible */
531 fl_index = fs_freelist_for_size (data_bytes) + 1;
532 if (!fss_chunk_fl_index_is_valid (fss, fl_index))
534 first = fss_chunk_free_list_pop (fsh, fss, fl_index);
538 n_alloc = fs_freelist_index_to_size (fl_index);
544 fl_size = fl_size >> 1;
549 fss_fl_chunk_bytes_sub (fss, n_alloc);
550 fsh_cached_bytes_sub (fsh, n_alloc);
555 fsh_try_alloc_fifo_hdr_batch (fifo_segment_header_t * fsh,
556 fifo_segment_slice_t * fss, u32 batch_size)
558 svm_fifo_shared_t *f, *head = 0, *tail;
563 ASSERT (batch_size != 0);
565 size = (uword) sizeof (*f) * batch_size;
567 fmem = fsh_alloc_aligned (fsh, size, CLIB_CACHE_LINE_BYTES);
571 /* Carve fifo hdr space */
572 tail = f = (svm_fifo_shared_t *) fmem;
573 for (i = 0; i < batch_size; i++)
575 clib_memset (f, 0, sizeof (*f));
576 f->next = fs_sptr (fsh, head);
579 f = (svm_fifo_shared_t *) fmem;
582 fss_fifo_free_list_push_list (fsh, fss, head, tail);
588 fsh_try_alloc_chunk_batch (fifo_segment_header_t * fsh,
589 fifo_segment_slice_t * fss,
590 u32 fl_index, u32 batch_size)
592 svm_fifo_chunk_t *c, *head = 0, *tail;
593 uword size, total_chunk_bytes;
594 u32 rounded_data_size;
598 ASSERT (batch_size != 0);
600 rounded_data_size = fs_freelist_index_to_size (fl_index);
601 total_chunk_bytes = (uword) batch_size *rounded_data_size;
602 size = (uword) (sizeof (*c) + rounded_data_size) * batch_size;
604 cmem = fsh_alloc_aligned (fsh, size, 8 /* chunk hdr is 24B */);
608 /* Carve fifo + chunk space */
609 tail = c = (svm_fifo_chunk_t *) cmem;
610 for (i = 0; i < batch_size; i++)
613 c->length = rounded_data_size;
614 c->next = fs_chunk_sptr (fsh, head);
616 cmem += sizeof (*c) + rounded_data_size;
617 c = (svm_fifo_chunk_t *) cmem;
620 fss_chunk_free_list_push_list (fsh, fss, fl_index, head, tail);
621 fss->num_chunks[fl_index] += batch_size;
622 fss_fl_chunk_bytes_add (fss, total_chunk_bytes);
623 fsh_cached_bytes_add (fsh, total_chunk_bytes);
629 fs_try_alloc_fifo_batch (fifo_segment_header_t * fsh,
630 fifo_segment_slice_t * fss,
631 u32 fl_index, u32 batch_size)
633 if (fsh_try_alloc_fifo_hdr_batch (fsh, fss, batch_size))
635 return fsh_try_alloc_chunk_batch (fsh, fss, fl_index, batch_size);
638 static svm_fifo_shared_t *
639 fsh_try_alloc_fifo_hdr (fifo_segment_header_t *fsh, fifo_segment_slice_t *fss)
641 svm_fifo_shared_t *sf;
643 if (!fss->free_fifos)
645 if (fsh_try_alloc_fifo_hdr_batch (fsh, fss,
646 FIFO_SEGMENT_ALLOC_BATCH_SIZE))
650 sf = fss_fifo_free_list_pop (fsh, fss);
651 clib_memset (sf, 0, sizeof (*sf));
656 static svm_fifo_chunk_t *
657 fsh_try_alloc_chunk (fifo_segment_header_t * fsh,
658 fifo_segment_slice_t * fss, u32 data_bytes)
663 fl_index = fs_freelist_for_size (data_bytes);
666 c = fss_chunk_free_list_pop (fsh, fss, fl_index);
670 fss_fl_chunk_bytes_sub (fss, fs_freelist_index_to_size (fl_index));
671 fsh_cached_bytes_sub (fsh, fs_freelist_index_to_size (fl_index));
675 u32 chunk_size, batch = FIFO_SEGMENT_ALLOC_BATCH_SIZE;
678 chunk_size = fs_freelist_index_to_size (fl_index);
679 n_free = fsh_n_free_bytes (fsh);
681 if (chunk_size <= n_free)
683 batch = chunk_size * batch <= n_free ? batch : 1;
684 if (!fsh_try_alloc_chunk_batch (fsh, fss, fl_index, batch))
687 /* Failed to allocate larger chunk, try to allocate multi-chunk
688 * that is close to what was actually requested */
689 if (data_bytes <= fss_fl_chunk_bytes (fss))
691 c = fs_try_alloc_multi_chunk (fsh, fss, data_bytes);
694 batch = n_free / FIFO_SEGMENT_MIN_FIFO_SIZE;
695 if (!batch || fsh_try_alloc_chunk_batch (fsh, fss, 0, batch))
698 if (data_bytes <= fss_fl_chunk_bytes (fss) + n_free)
700 u32 min_size = FIFO_SEGMENT_MIN_FIFO_SIZE;
701 if (n_free < min_size)
703 batch = (data_bytes - fss_fl_chunk_bytes (fss)) / min_size;
704 batch = clib_min (batch + 1, n_free / min_size);
705 if (fsh_try_alloc_chunk_batch (fsh, fss, 0, batch))
707 c = fs_try_alloc_multi_chunk (fsh, fss, data_bytes);
717 * Try to allocate new fifo
719 * Tries the following steps in order:
720 * - grab fifo and chunk from freelists
721 * - batch fifo and chunk allocation
722 * - single fifo allocation
723 * - grab multiple fifo chunks from freelists
725 static svm_fifo_shared_t *
726 fs_try_alloc_fifo (fifo_segment_header_t *fsh, u32 slice_index, u32 data_bytes)
728 fifo_segment_slice_t *fss;
729 u32 fl_index, min_size;
731 svm_fifo_shared_t *sf = 0;
733 fss = fsh_slice_get (fsh, slice_index);
734 min_size = clib_max ((fsh->pct_first_alloc * data_bytes) / 100, 4096);
735 fl_index = fs_freelist_for_size (min_size);
737 if (!fss_chunk_fl_index_is_valid (fss, fl_index))
740 sf = fsh_try_alloc_fifo_hdr (fsh, fss);
744 c = fsh_try_alloc_chunk (fsh, fss, min_size);
747 fss_fifo_free_list_push (fsh, fss, sf);
751 sf->start_chunk = fs_chunk_sptr (fsh, c);
753 c = fs_chunk_ptr (fsh, c->next);
754 sf->end_chunk = fs_chunk_sptr (fsh, c);
755 sf->size = data_bytes;
756 sf->slice_index = slice_index;
762 fsh_alloc_chunk (fifo_segment_header_t * fsh, u32 slice_index, u32 chunk_size)
764 fifo_segment_slice_t *fss;
767 fss = fsh_slice_get (fsh, slice_index);
768 c = fsh_try_alloc_chunk (fsh, fss, chunk_size);
774 fsh_slice_collect_chunks (fifo_segment_header_t * fsh,
775 fifo_segment_slice_t * fss, svm_fifo_chunk_t * c)
777 u32 n_collect = 0, fl_index;
778 svm_fifo_chunk_t *next;
782 CLIB_MEM_UNPOISON (c, sizeof (*c));
783 next = fs_chunk_ptr (fsh, c->next);
784 fl_index = fs_freelist_for_size (c->length);
785 fss_chunk_free_list_push (fsh, fss, fl_index, c);
786 n_collect += fs_freelist_index_to_size (fl_index);
790 fss_fl_chunk_bytes_add (fss, n_collect);
791 fsh_cached_bytes_add (fsh, n_collect);
795 fsh_collect_chunks (fifo_segment_header_t * fsh, u32 slice_index,
796 svm_fifo_chunk_t * c)
798 fifo_segment_slice_t *fss;
799 fss = fsh_slice_get (fsh, slice_index);
800 fsh_slice_collect_chunks (fsh, fss, c);
804 fs_fifo_alloc (fifo_segment_t *fs, u32 slice_index)
806 fifo_slice_private_t *pfss = &fs->slices[slice_index];
809 f = clib_mem_bulk_alloc (pfss->fifos);
810 clib_memset (f, 0, sizeof (*f));
815 fs_fifo_free (fifo_segment_t *fs, svm_fifo_t *f, u32 slice_index)
817 fifo_slice_private_t *pfss;
820 clib_memset (f, 0xfc, sizeof (*f));
822 pfss = &fs->slices[slice_index];
823 clib_mem_bulk_free (pfss->fifos, f);
827 fifo_segment_cleanup (fifo_segment_t *fs)
832 for (slice_index = 0; slice_index < fs->n_slices; slice_index++)
833 clib_mem_bulk_destroy (fs->slices[slice_index].fifos);
835 vec_free (fs->slices);
837 vec_foreach (fs->mqs, mq)
838 svm_msg_q_cleanup (mq);
844 * Allocate fifo in fifo segment
847 fifo_segment_alloc_fifo_w_slice (fifo_segment_t * fs, u32 slice_index,
848 u32 data_bytes, fifo_segment_ftype_t ftype)
850 fifo_segment_header_t *fsh = fs->h;
851 fifo_slice_private_t *pfss;
852 fifo_segment_slice_t *fss;
853 svm_fifo_shared_t *sf;
856 ASSERT (slice_index < fs->n_slices);
858 if (PREDICT_FALSE (data_bytes > 1 << fsh->max_log2_fifo_size))
861 sf = fs_try_alloc_fifo (fsh, slice_index, data_bytes);
865 f = fs_fifo_alloc (fs, slice_index);
869 svm_fifo_init (f, data_bytes);
871 fss = fsh_slice_get (fsh, slice_index);
872 pfss = fs_slice_private_get (fs, slice_index);
874 /* If rx fifo type add to active fifos list. When cleaning up segment,
875 * we need a list of active sessions that should be disconnected. Since
876 * both rx and tx fifos keep pointers to the session, it's enough to track
878 if (ftype == FIFO_SEGMENT_RX_FIFO)
880 pfss_fifo_add_active_list (pfss, f);
881 f->flags |= SVM_FIFO_F_LL_TRACKED;
884 fsh_active_fifos_update (fsh, 1);
885 fss->virtual_mem += svm_fifo_size (f);
892 fifo_segment_alloc_fifo_w_offset (fifo_segment_t *fs, uword offset)
894 svm_fifo_t *f = fs_fifo_alloc (fs, 0);
895 svm_fifo_shared_t *sf;
897 sf = (svm_fifo_shared_t *) ((u8 *) fs->h + offset);
901 f->ooos_list_head = OOO_SEGMENT_INVALID_INDEX;
902 f->segment_index = SVM_FIFO_INVALID_INDEX;
908 fifo_segment_duplicate_fifo (fifo_segment_t *fs, svm_fifo_t *f)
910 svm_fifo_t *nf = fs_fifo_alloc (fs, 0);
911 clib_memcpy (nf, f, sizeof (*f));
916 * Free fifo allocated in fifo segment
919 fifo_segment_free_fifo (fifo_segment_t * fs, svm_fifo_t * f)
921 fifo_segment_header_t *fsh = fs->h;
922 fifo_slice_private_t *pfss;
923 fifo_segment_slice_t *fss;
924 svm_fifo_shared_t *sf;
926 ASSERT (f->refcnt > 0);
932 * Cleanup shared state
936 fss = fsh_slice_get (fsh, sf->slice_index);
937 pfss = fs_slice_private_get (fs, sf->slice_index);
939 /* Free fifo chunks */
940 fsh_slice_collect_chunks (fsh, fss, fs_chunk_ptr (fsh, f->shr->start_chunk));
942 sf->start_chunk = sf->end_chunk = 0;
943 sf->head_chunk = sf->tail_chunk = 0;
945 /* Add to free list */
946 fss_fifo_free_list_push (fsh, fss, sf);
948 fss->virtual_mem -= svm_fifo_size (f);
951 * Cleanup private state
954 /* Remove from active list. Only rx fifos are tracked */
955 if (f->flags & SVM_FIFO_F_LL_TRACKED)
957 pfss_fifo_del_active_list (pfss, f);
958 f->flags &= ~SVM_FIFO_F_LL_TRACKED;
961 svm_fifo_free_chunk_lookup (f);
962 svm_fifo_free_ooo_data (f);
966 sf->master_session_index = ~0;
967 f->master_thread_index = ~0;
970 f->ooo_enq = f->ooo_deq = 0;
973 fs_fifo_free (fs, f, f->shr->slice_index);
975 fsh_active_fifos_update (fsh, -1);
979 fifo_segment_free_client_fifo (fifo_segment_t *fs, svm_fifo_t *f)
981 fs_fifo_free (fs, f, 0 /* clients attach fifos in slice 0 */);
985 fifo_segment_detach_fifo (fifo_segment_t *fs, svm_fifo_t **f)
987 fifo_slice_private_t *pfss;
988 fifo_segment_slice_t *fss;
992 slice_index = of->master_thread_index;
993 fss = fsh_slice_get (fs->h, slice_index);
994 pfss = fs_slice_private_get (fs, slice_index);
995 fss->virtual_mem -= svm_fifo_size (of);
996 if (of->flags & SVM_FIFO_F_LL_TRACKED)
997 pfss_fifo_del_active_list (pfss, of);
999 /* Collect chunks that were provided in return for those detached */
1000 fsh_slice_collect_chunks (fs->h, fss, of->chunks_at_attach);
1001 of->chunks_at_attach = 0;
1003 /* Collect hdr that was provided in return for the detached */
1004 fss_fifo_free_list_push (fs->h, fss, of->hdr_at_attach);
1005 of->hdr_at_attach = 0;
1007 clib_mem_bulk_free (pfss->fifos, *f);
1012 fifo_segment_attach_fifo (fifo_segment_t *fs, svm_fifo_t **f, u32 slice_index)
1014 svm_fifo_chunk_t *c, *nc, *pc = 0;
1015 fifo_slice_private_t *pfss;
1016 fifo_segment_slice_t *fss;
1017 svm_fifo_t *nf, *of;
1019 nf = fs_fifo_alloc (fs, slice_index);
1020 clib_memcpy_fast (nf, *f, sizeof (*nf));
1022 fss = fsh_slice_get (fs->h, slice_index);
1023 pfss = fs_slice_private_get (fs, slice_index);
1024 fss->virtual_mem += svm_fifo_size (nf);
1025 nf->next = nf->prev = 0;
1026 if (nf->flags & SVM_FIFO_F_LL_TRACKED)
1027 pfss_fifo_add_active_list (pfss, nf);
1029 /* Allocate shared hdr and chunks to be collected at detach in return
1030 * for those that are being attached now */
1032 of->hdr_at_attach = fsh_try_alloc_fifo_hdr (fs->h, fss);
1034 c = fs_chunk_ptr (fs->h, nf->shr->start_chunk);
1035 of->chunks_at_attach = pc = fsh_try_alloc_chunk (fs->h, fss, c->length);
1037 while ((c = fs_chunk_ptr (fs->h, c->next)))
1039 nc = fsh_try_alloc_chunk (fs->h, fss, c->length);
1040 pc->next = fs_chunk_sptr (fs->h, nc);
1044 nf->shr->slice_index = slice_index;
1049 fifo_segment_fifo_offset (svm_fifo_t *f)
1051 return (u8 *) f->shr - (u8 *) f->fs_hdr;
1055 fifo_segment_alloc_chunk_w_slice (fifo_segment_t *fs, u32 slice_index,
1058 fifo_segment_header_t *fsh = fs->h;
1059 fifo_segment_slice_t *fss;
1061 fss = fsh_slice_get (fsh, slice_index);
1062 return fsh_try_alloc_chunk (fsh, fss, chunk_size);
1066 fifo_segment_collect_chunk (fifo_segment_t *fs, u32 slice_index,
1067 svm_fifo_chunk_t *c)
1069 fsh_collect_chunks (fs->h, slice_index, c);
1073 fifo_segment_chunk_offset (fifo_segment_t *fs, svm_fifo_chunk_t *c)
1075 return (u8 *) c - (u8 *) fs->h;
1079 fifo_segment_msg_q_alloc (fifo_segment_t *fs, u32 mq_index,
1080 svm_msg_q_cfg_t *cfg)
1082 fifo_segment_header_t *fsh = fs->h;
1083 svm_msg_q_shared_t *smq;
1090 u32 n_mqs = clib_max (fs->h->n_mqs, 1);
1091 vec_validate (fs->mqs, n_mqs - 1);
1094 size = svm_msg_q_size_to_alloc (cfg);
1095 base = fsh_alloc_aligned (fsh, size, 8);
1096 fsh->n_reserved_bytes += size;
1098 smq = svm_msg_q_init (base, cfg);
1099 mq = vec_elt_at_index (fs->mqs, mq_index);
1100 svm_msg_q_attach (mq, smq);
1106 fifo_segment_msg_q_attach (fifo_segment_t *fs, uword offset, u32 mq_index)
1112 u32 n_mqs = clib_max (fs->h->n_mqs, 1);
1113 vec_validate (fs->mqs, n_mqs - 1);
1116 mq = vec_elt_at_index (fs->mqs, mq_index);
1120 svm_msg_q_shared_t *smq;
1121 smq = (svm_msg_q_shared_t *) ((u8 *) fs->h + offset);
1122 svm_msg_q_attach (mq, smq);
1125 ASSERT (fifo_segment_msg_q_offset (fs, mq_index) == offset);
1131 fifo_segment_msg_qs_discover (fifo_segment_t *fs, int *fds, u32 n_fds)
1133 svm_msg_q_shared_t *smq;
1135 uword offset = 0, n_alloced;
1138 n_mqs = fs->h->n_mqs;
1139 if (n_fds && n_mqs != n_fds)
1141 clib_warning ("expected %u fds got %u", n_mqs, n_fds);
1145 vec_validate (fs->mqs, n_mqs - 1);
1146 n_alloced = fs->h->n_reserved_bytes - fs->h->start_byte_index;
1147 ASSERT (n_alloced % n_mqs == 0);
1148 size = n_alloced / n_mqs;
1150 offset = fs->h->start_byte_index;
1151 for (i = 0; i < n_mqs; i++)
1153 mq = vec_elt_at_index (fs->mqs, i);
1154 smq = (svm_msg_q_shared_t *) ((u8 *) fs->h + offset);
1155 svm_msg_q_attach (mq, smq);
1157 svm_msg_q_set_eventfd (mq, fds[i]);
1163 fifo_segment_msg_q_offset (fifo_segment_t *fs, u32 mq_index)
1165 svm_msg_q_t *mq = vec_elt_at_index (fs->mqs, mq_index);
1170 return (uword) ((u8 *) mq->q.shr - (u8 *) fs->h) -
1171 sizeof (svm_msg_q_shared_t);
1175 fifo_segment_prealloc_fifo_hdrs (fifo_segment_t * fs, u32 slice_index,
1178 fifo_segment_header_t *fsh = fs->h;
1179 fifo_segment_slice_t *fss;
1181 fss = fsh_slice_get (fsh, slice_index);
1182 return fsh_try_alloc_fifo_hdr_batch (fsh, fss, batch_size);
1186 fifo_segment_prealloc_fifo_chunks (fifo_segment_t * fs, u32 slice_index,
1187 u32 chunk_size, u32 batch_size)
1189 fifo_segment_header_t *fsh = fs->h;
1190 fifo_segment_slice_t *fss;
1193 if (!fs_chunk_size_is_valid (fsh, chunk_size))
1195 clib_warning ("chunk size out of range %d", chunk_size);
1199 fl_index = fs_freelist_for_size (chunk_size);
1200 fss = fsh_slice_get (fsh, slice_index);
1202 return fsh_try_alloc_chunk_batch (fsh, fss, fl_index, batch_size);
1206 * Pre-allocates fifo pairs in fifo segment
1209 fifo_segment_preallocate_fifo_pairs (fifo_segment_t * fs,
1210 u32 rx_fifo_size, u32 tx_fifo_size,
1213 u32 rx_rounded_data_size, tx_rounded_data_size, pair_size, pairs_to_alloc;
1214 u32 hdrs, pairs_per_slice, alloc_now;
1215 fifo_segment_header_t *fsh = fs->h;
1216 int rx_fl_index, tx_fl_index, i;
1217 fifo_segment_slice_t *fss;
1218 uword space_available;
1220 /* Parameter check */
1221 if (rx_fifo_size == 0 || tx_fifo_size == 0 || *n_fifo_pairs == 0)
1224 if (!fs_chunk_size_is_valid (fsh, rx_fifo_size))
1226 clib_warning ("rx fifo_size out of range %d", rx_fifo_size);
1230 if (!fs_chunk_size_is_valid (fsh, tx_fifo_size))
1232 clib_warning ("tx fifo_size out of range %d", tx_fifo_size);
1236 rx_rounded_data_size = (1 << (max_log2 (rx_fifo_size)));
1237 rx_fl_index = fs_freelist_for_size (rx_fifo_size);
1238 tx_rounded_data_size = (1 << (max_log2 (tx_fifo_size)));
1239 tx_fl_index = fs_freelist_for_size (tx_fifo_size);
1241 hdrs = sizeof (svm_fifo_t) + sizeof (svm_fifo_chunk_t);
1243 /* Calculate space requirements */
1244 pair_size = 2 * hdrs + rx_rounded_data_size + tx_rounded_data_size;
1245 space_available = fsh_n_free_bytes (fsh);
1246 pairs_to_alloc = space_available / pair_size;
1247 pairs_to_alloc = clib_min (pairs_to_alloc, *n_fifo_pairs);
1248 pairs_per_slice = pairs_to_alloc / fs->n_slices;
1249 pairs_per_slice += pairs_to_alloc % fs->n_slices ? 1 : 0;
1251 if (!pairs_per_slice)
1254 for (i = 0; i < fs->n_slices; i++)
1256 alloc_now = clib_min (pairs_per_slice, *n_fifo_pairs);
1260 fss = fsh_slice_get (fsh, i);
1261 if (fs_try_alloc_fifo_batch (fsh, fss, rx_fl_index, alloc_now))
1262 clib_warning ("rx prealloc failed: pairs %u", alloc_now);
1263 if (fs_try_alloc_fifo_batch (fsh, fss, tx_fl_index, alloc_now))
1264 clib_warning ("tx prealloc failed: pairs %u", alloc_now);
1266 /* Account for the pairs allocated */
1267 *n_fifo_pairs -= alloc_now;
1272 * Get number of active fifos
1275 fifo_segment_num_fifos (fifo_segment_t * fs)
1277 return fsh_n_active_fifos (fs->h);
1281 fs_slice_num_free_fifos (fifo_segment_header_t *fsh, fifo_segment_slice_t *fss)
1283 svm_fifo_shared_t *f;
1286 f = fs_ptr (fsh, fss->free_fifos);
1292 f = fs_ptr (fsh, f->next);
1299 fifo_segment_num_free_fifos (fifo_segment_t * fs)
1301 fifo_segment_header_t *fsh = fs->h;
1302 fifo_segment_slice_t *fss;
1306 for (slice_index = 0; slice_index < fs->n_slices; slice_index++)
1308 fss = fsh_slice_get (fsh, slice_index);
1309 count += fs_slice_num_free_fifos (fsh, fss);
1315 fs_slice_num_free_chunks (fifo_segment_header_t *fsh,
1316 fifo_segment_slice_t *fss, u32 size)
1318 u32 count = 0, rounded_size, fl_index;
1319 svm_fifo_chunk_t *c;
1322 /* Count all free chunks? */
1325 for (i = 0; i < FS_CHUNK_VEC_LEN; i++)
1327 c = fss_chunk_free_list_head (fsh, fss, i);
1333 c = fs_chunk_ptr (fsh, c->next);
1340 rounded_size = (1 << (max_log2 (size)));
1341 fl_index = fs_freelist_for_size (rounded_size);
1343 if (fl_index >= FS_CHUNK_VEC_LEN)
1346 c = fss_chunk_free_list_head (fsh, fss, fl_index);
1352 c = fs_chunk_ptr (fsh, c->next);
1359 fifo_segment_num_free_chunks (fifo_segment_t * fs, u32 size)
1361 fifo_segment_header_t *fsh = fs->h;
1362 fifo_segment_slice_t *fss;
1366 for (slice_index = 0; slice_index < fs->n_slices; slice_index++)
1368 fss = fsh_slice_get (fsh, slice_index);
1369 count += fs_slice_num_free_chunks (fsh, fss, size);
1375 fifo_segment_size (fifo_segment_t * fs)
1377 return fs->h->max_byte_index - fs->h->n_reserved_bytes;
1381 fs_has_reached_mem_limit (fifo_segment_t *fs)
1383 return (fs->flags & FIFO_SEGMENT_F_MEM_LIMIT) ? 1 : 0;
1387 fs_reset_mem_limit (fifo_segment_t *fs)
1389 fs->flags &= ~FIFO_SEGMENT_F_MEM_LIMIT;
1393 fifo_segment_alloc (fifo_segment_t *fs, uword size)
1395 void *rv = fsh_alloc (fs->h, size);
1396 /* Mark externally allocated bytes as reserved. This helps
1397 * @ref fifo_segment_size report bytes used only for fifos */
1398 fs->h->n_reserved_bytes += size;
1403 fifo_segment_free_bytes (fifo_segment_t * fs)
1405 return fsh_n_free_bytes (fs->h);
1409 fifo_segment_cached_bytes (fifo_segment_t * fs)
1411 return fsh_n_cached_bytes (fs->h);
1415 fifo_segment_available_bytes (fifo_segment_t * fs)
1417 return fsh_n_free_bytes (fs->h) + fsh_n_cached_bytes (fs->h);
1421 fifo_segment_fl_chunk_bytes (fifo_segment_t * fs)
1423 fifo_segment_header_t *fsh = fs->h;
1424 fifo_segment_slice_t *fss;
1428 for (slice_index = 0; slice_index < fs->n_slices; slice_index++)
1430 fss = fsh_slice_get (fsh, slice_index);
1431 n_bytes += fss_fl_chunk_bytes (fss);
1438 fifo_segment_has_fifos (fifo_segment_t * fs)
1440 return (fsh_n_active_fifos (fs->h) != 0);
1444 fifo_segment_get_slice_fifo_list (fifo_segment_t * fs, u32 slice_index)
1446 fifo_slice_private_t *pfss;
1448 pfss = fs_slice_private_get (fs, slice_index);
1449 return pfss->active_fifos;
1453 fifo_segment_get_mem_usage (fifo_segment_t * fs)
1457 size = fifo_segment_size (fs);
1459 size - fifo_segment_free_bytes (fs) - fifo_segment_cached_bytes (fs);
1460 return (in_use * 100) / size;
1463 fifo_segment_mem_status_t
1464 fifo_segment_determine_status (fifo_segment_t *fs, u8 usage)
1466 if (!fs->high_watermark || !fs->low_watermark)
1467 return MEMORY_PRESSURE_NO_PRESSURE;
1469 /* once the no-memory is detected, the status continues
1470 * until memory usage gets below the high watermark
1472 if (fs_has_reached_mem_limit (fs))
1474 if (usage >= fs->high_watermark)
1475 return MEMORY_PRESSURE_NO_MEMORY;
1477 fs_reset_mem_limit (fs);
1480 if (usage >= fs->high_watermark)
1481 return MEMORY_PRESSURE_HIGH_PRESSURE;
1483 else if (usage >= fs->low_watermark)
1484 return MEMORY_PRESSURE_LOW_PRESSURE;
1486 return MEMORY_PRESSURE_NO_PRESSURE;
1489 fifo_segment_mem_status_t
1490 fifo_segment_get_mem_status (fifo_segment_t * fs)
1492 u8 usage = fifo_segment_get_mem_usage (fs);
1494 return fifo_segment_determine_status (fs, usage);
1498 format_fifo_segment_type (u8 * s, va_list * args)
1501 sp = va_arg (*args, fifo_segment_t *);
1502 ssvm_segment_type_t st = ssvm_type (&sp->ssvm);
1504 if (st == SSVM_SEGMENT_PRIVATE)
1505 s = format (s, "%s", "private");
1506 else if (st == SSVM_SEGMENT_MEMFD)
1507 s = format (s, "%s", "memfd");
1508 else if (st == SSVM_SEGMENT_SHM)
1509 s = format (s, "%s", "shm");
1511 s = format (s, "%s", "unknown");
1516 * Segment format function
1519 format_fifo_segment (u8 * s, va_list * args)
1521 u32 count, indent, active_fifos, free_fifos;
1522 fifo_segment_t *fs = va_arg (*args, fifo_segment_t *);
1523 int verbose __attribute__ ((unused)) = va_arg (*args, int);
1524 uword est_chunk_bytes, est_free_seg_bytes, free_chunks;
1525 uword chunk_bytes = 0, free_seg_bytes, chunk_size;
1526 uword tracked_cached_bytes;
1527 uword fifo_hdr = 0, reserved;
1528 fifo_segment_header_t *fsh;
1529 fifo_segment_slice_t *fss;
1530 svm_fifo_chunk_t *c;
1535 uword allocated, in_use, virt;
1537 fifo_segment_mem_status_t mem_st;
1539 indent = format_get_indent (s) + 2;
1543 s = format (s, "%-20s%10s%15s%15s%15s%15s", "Name", "Type",
1544 "HeapSize (M)", "ActiveFifos", "FreeFifos", "Address");
1548 fifo_segment_info (fs, &address, &size);
1549 active_fifos = fifo_segment_num_fifos (fs);
1550 free_fifos = fifo_segment_num_free_fifos (fs);
1552 s = format (s, "%-20v%10U%15llu%15u%15u%15llx", ssvm_name (&fs->ssvm),
1553 format_fifo_segment_type, fs, size >> 20ULL, active_fifos,
1554 free_fifos, address);
1561 free_chunks = fifo_segment_num_free_chunks (fs, ~0);
1564 format (s, "\n\n%UFree/Allocated chunks by size:\n", format_white_space,
1567 s = format (s, "\n");
1569 for (slice_index = 0; slice_index < fs->n_slices; slice_index++)
1571 fss = fsh_slice_get (fsh, slice_index);
1572 for (i = 0; i < FS_CHUNK_VEC_LEN; i++)
1574 c = fss_chunk_free_list_head (fsh, fss, i);
1575 if (c == 0 && fss->num_chunks[i] == 0)
1580 c = fs_chunk_ptr (fsh, c->next);
1584 chunk_size = fs_freelist_index_to_size (i);
1585 s = format (s, "%U%-5u kB: %u/%u\n", format_white_space, indent + 2,
1586 chunk_size >> 10, count, fss->num_chunks[i]);
1588 chunk_bytes += count * chunk_size;
1592 fifo_hdr = free_fifos * sizeof (svm_fifo_t);
1593 est_chunk_bytes = fifo_segment_fl_chunk_bytes (fs);
1594 est_free_seg_bytes = fifo_segment_free_bytes (fs);
1595 free_seg_bytes = fifo_segment_free_bytes (fs);
1596 tracked_cached_bytes = fifo_segment_cached_bytes (fs);
1597 allocated = fifo_segment_size (fs);
1598 in_use = fifo_segment_size (fs) - est_free_seg_bytes - tracked_cached_bytes;
1599 usage = (100.0 * in_use) / allocated;
1600 mem_st = fifo_segment_get_mem_status (fs);
1601 virt = fs_virtual_mem (fs);
1602 reserved = fsh->n_reserved_bytes;
1604 s = format (s, "\n%Useg free bytes: %U (%lu) estimated: %U (%lu) reserved:"
1605 " %U (%lu)\n", format_white_space, indent + 2,
1606 format_memory_size, free_seg_bytes, free_seg_bytes,
1607 format_memory_size, est_free_seg_bytes, est_free_seg_bytes,
1608 format_memory_size, reserved, reserved);
1609 s = format (s, "%Uchunk free bytes: %U (%lu) estimated: %U (%lu) tracked:"
1610 " %U (%lu)\n", format_white_space, indent + 2,
1611 format_memory_size, chunk_bytes, chunk_bytes,
1612 format_memory_size, est_chunk_bytes, est_chunk_bytes,
1613 format_memory_size, tracked_cached_bytes, tracked_cached_bytes);
1614 s = format (s, "%Ufifo active: %u hdr free: %u bytes: %U (%u) \n",
1615 format_white_space, indent + 2, fsh->n_active_fifos, free_fifos,
1616 format_memory_size, fifo_hdr, fifo_hdr);
1617 s = format (s, "%Usegment usage: %.2f%% (%U / %U) virt: %U status: %s\n",
1618 format_white_space, indent + 2, usage, format_memory_size,
1619 in_use, format_memory_size, allocated, format_memory_size, virt,
1620 fifo_segment_mem_status_strings[mem_st]);
1621 s = format (s, "\n");
1627 * fd.io coding-style-patch-verification: ON
1630 * eval: (c-set-style "gnu")