Code Review
/
vpp.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
docs: better docs, mv doxygen to sphinx
[vpp.git]
/
docs
/
developer
/
corearchitecture
/
multiarch
/
nodefns.rst
diff --git
a/docs/gettingstarted/developers/multiarch/nodefns.rst
b/docs/developer/corearchitecture/multiarch/nodefns.rst
similarity index 97%
rename from
docs/gettingstarted/developers/multiarch/nodefns.rst
rename to
docs/developer/corearchitecture/multiarch/nodefns.rst
index
a43d40e
..
9647e64
100644
(file)
--- a/
docs/gettingstarted/developers/multiarch/nodefns.rst
+++ b/
docs/developer/corearchitecture/multiarch/nodefns.rst
@@
-23,9
+23,9
@@
Details
-------
Declare the node dispatch function as shown, using the VLIB\_NODE\_FN macro. The
-------
Declare the node dispatch function as shown, using the VLIB\_NODE\_FN macro. The
-name of the node function **MUST** match the name of the graph node.
+name of the node function **MUST** match the name of the graph node.
-::
+::
VLIB_NODE_FN (ip4_sdp_node) (vlib_main_t * vm, vlib_node_runtime_t * node,
vlib_frame_t * frame)
VLIB_NODE_FN (ip4_sdp_node) (vlib_main_t * vm, vlib_node_runtime_t * node,
vlib_frame_t * frame)
@@
-36,7
+36,7
@@
name of the node function **MUST** match the name of the graph node.
else
return ip46_sdp_inline (vm, node, frame, 1 /* is_ip4 */ ,
0 /* is_trace */ );
else
return ip46_sdp_inline (vm, node, frame, 1 /* is_ip4 */ ,
0 /* is_trace */ );
- }
+ }
We need to generate *precisely one copy* of the
vlib_node_registration_t, error strings, and packet trace decode function.
We need to generate *precisely one copy* of the
vlib_node_registration_t, error strings, and packet trace decode function.
@@
-103,13
+103,13
@@
is structured that way, make *ABSOLUTELY CERTAIN* to use the
::
always_inline uword
::
always_inline uword
- ip46_sdp_inline (vlib_main_t * vm, vlib_node_runtime_t * node,
+ ip46_sdp_inline (vlib_main_t * vm, vlib_node_runtime_t * node,
vlib_frame_t * frame,
int is_ip4, int is_trace)
{ ... }
Otherwise, the compiler is highly likely NOT to build multiple
vlib_frame_t * frame,
int is_ip4, int is_trace)
{ ... }
Otherwise, the compiler is highly likely NOT to build multiple
-versions of the guts of your dispatch function.
+versions of the guts of your dispatch function.
It's fairly easy to spot this mistake in "perf top." If you see, for
example, a bunch of functions with names of the form
It's fairly easy to spot this mistake in "perf top." If you see, for
example, a bunch of functions with names of the form
@@
-130,7
+130,7
@@
below. Note that the added file "new_multiarch_node.c" should appear in
add_vpp_plugin(myplugin
SOURCES
new_multiarch_node.c
add_vpp_plugin(myplugin
SOURCES
new_multiarch_node.c
- ...
+ ...
MULTIARCH_SOURCES
new_ multiarch_node.c
MULTIARCH_SOURCES
new_ multiarch_node.c