Code Review
/
vpp.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
misc: sprintf be gone
[vpp.git]
/
src
/
plugins
/
dhcp
/
dhcp6_pd_client_cp.c
diff --git
a/src/plugins/dhcp/dhcp6_pd_client_cp.c
b/src/plugins/dhcp/dhcp6_pd_client_cp.c
index
1c0b286
..
077b4a3
100644
(file)
--- a/
src/plugins/dhcp/dhcp6_pd_client_cp.c
+++ b/
src/plugins/dhcp/dhcp6_pd_client_cp.c
@@
-1176,8
+1176,8
@@
ip6_pd_clients_show_command_function (vlib_main_t * vm,
client_state_t *cs;
f64 current_time = vlib_time_now (vm);
const u8 *prefix_group;
client_state_t *cs;
f64 current_time = vlib_time_now (vm);
const u8 *prefix_group;
-
char buf1[256]
;
-
char buf2[256]
;
+
u8 *buf1 = 0
;
+
u8 *buf2 = 0
;
const char *rebinding;
u32 i;
const char *rebinding;
u32 i;
@@
-1186,18
+1186,20
@@
ip6_pd_clients_show_command_function (vlib_main_t * vm,
cs = &rm->client_state_by_sw_if_index[i];
if (cs->enabled)
{
cs = &rm->client_state_by_sw_if_index[i];
if (cs->enabled)
{
+ vec_reset_length (buf1);
+ vec_reset_length (buf2);
if (cs->T1_due_time != DBL_MAX && cs->T1_due_time > current_time)
{
if (cs->T1_due_time != DBL_MAX && cs->T1_due_time > current_time)
{
-
sprintf
(buf1, "%u remaining",
- (u32) round (cs->T1_due_time - current_time));
+
buf1 = format
(buf1, "%u remaining",
+
(u32) round (cs->T1_due_time - current_time));
}
else
}
else
-
sprintf
(buf1, "timeout");
+
buf1 = format
(buf1, "timeout");
if (cs->T2_due_time != DBL_MAX && cs->T2_due_time > current_time)
if (cs->T2_due_time != DBL_MAX && cs->T2_due_time > current_time)
-
sprintf
(buf2, "%u remaining",
- (u32) round (cs->T2_due_time - current_time));
+
buf2 = format
(buf2, "%u remaining",
+
(u32) round (cs->T2_due_time - current_time));
else
else
-
sprintf
(buf2, "timeout");
+
buf2 = format
(buf2, "timeout");
if (cs->rebinding)
rebinding = ", REBINDING";
else
if (cs->rebinding)
rebinding = ", REBINDING";
else
@@
-1206,8
+1208,8
@@
ip6_pd_clients_show_command_function (vlib_main_t * vm,
pm->prefix_group_name_by_index[cs->prefix_group_index];
if (cs->T1)
vlib_cli_output (vm,
pm->prefix_group_name_by_index[cs->prefix_group_index];
if (cs->T1)
vlib_cli_output (vm,
- "sw_if_index: %u, prefix group: %s, T1: %u (%
s
), "
- "T2: %u (%
s
), server index: %d%s", i,
+ "sw_if_index: %u, prefix group: %s, T1: %u (%
v
), "
+ "T2: %u (%
v
), server index: %d%s", i,
prefix_group, cs->T1, buf1, cs->T2, buf2,
cs->server_index, rebinding);
else
prefix_group, cs->T1, buf1, cs->T2, buf2,
cs->server_index, rebinding);
else
@@
-1216,6
+1218,9
@@
ip6_pd_clients_show_command_function (vlib_main_t * vm,
}
}
}
}
+ vec_free (buf1);
+ vec_free (buf2);
+
return error;
}
return error;
}