Code Review
/
vpp.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
quic: Check quicly version tag at compile time
[vpp.git]
/
src
/
plugins
/
quic
/
quic.c
diff --git
a/src/plugins/quic/quic.c
b/src/plugins/quic/quic.c
index
03e46c6
..
3991656
100644
(file)
--- a/
src/plugins/quic/quic.c
+++ b/
src/plugins/quic/quic.c
@@
-784,7
+784,7
@@
quic_on_stream_destroy (quicly_stream_t * stream, int err)
clib_mem_free (stream->data);
}
clib_mem_free (stream->data);
}
-static
int
+static
void
quic_on_stop_sending (quicly_stream_t * stream, int err)
{
#if QUIC_DEBUG >= 2
quic_on_stop_sending (quicly_stream_t * stream, int err)
{
#if QUIC_DEBUG >= 2
@@
-797,10
+797,9
@@
quic_on_stop_sending (quicly_stream_t * stream, int err)
session_handle (stream_session), quic_format_err, err);
#endif
/* TODO : handle STOP_SENDING */
session_handle (stream_session), quic_format_err, err);
#endif
/* TODO : handle STOP_SENDING */
- return 0;
}
}
-static
int
+static
void
quic_on_receive_reset (quicly_stream_t * stream, int err)
{
quic_stream_data_t *stream_data = (quic_stream_data_t *) stream->data;
quic_on_receive_reset (quicly_stream_t * stream, int err)
{
quic_stream_data_t *stream_data = (quic_stream_data_t *) stream->data;
@@
-813,10
+812,9
@@
quic_on_receive_reset (quicly_stream_t * stream, int err)
session_handle (stream_session), quic_format_err, err);
#endif
session_transport_closing_notify (&sctx->connection);
session_handle (stream_session), quic_format_err, err);
#endif
session_transport_closing_notify (&sctx->connection);
- return 0;
}
}
-static
int
+static
void
quic_on_receive (quicly_stream_t * stream, size_t off, const void *src,
size_t len)
{
quic_on_receive (quicly_stream_t * stream, size_t off, const void *src,
size_t len)
{
@@
-846,7
+844,7
@@
quic_on_receive (quicly_stream_t * stream, size_t off, const void *src,
stream_session->thread_index, f,
max_enq, len, stream_data->app_rx_data_len, off,
off - stream_data->app_rx_data_len + len);
stream_session->thread_index, f,
max_enq, len, stream_data->app_rx_data_len, off,
off - stream_data->app_rx_data_len + len);
- return
0
;
+ return;
}
if (PREDICT_FALSE ((off - stream_data->app_rx_data_len + len) > max_enq))
{
}
if (PREDICT_FALSE ((off - stream_data->app_rx_data_len + len) > max_enq))
{
@@
-858,7
+856,7
@@
quic_on_receive (quicly_stream_t * stream, size_t off, const void *src,
stream_session->thread_index, f,
max_enq, len, stream_data->app_rx_data_len, off,
off - stream_data->app_rx_data_len + len);
stream_session->thread_index, f,
max_enq, len, stream_data->app_rx_data_len, off,
off - stream_data->app_rx_data_len + len);
- return
1;
+ return
; /* This shouldn't happen */
}
if (off == stream_data->app_rx_data_len)
{
}
if (off == stream_data->app_rx_data_len)
{
@@
-888,7
+886,7
@@
quic_on_receive (quicly_stream_t * stream, size_t off, const void *src,
len, (u8 *) src);
QUIC_ASSERT (rlen == 0);
}
len, (u8 *) src);
QUIC_ASSERT (rlen == 0);
}
- return
0
;
+ return;
}
void
}
void
@@
-912,7
+910,7
@@
quic_fifo_egress_shift (quicly_stream_t * stream, size_t delta)
QUIC_ASSERT (!rv);
}
QUIC_ASSERT (!rv);
}
-int
+void
quic_fifo_egress_emit (quicly_stream_t * stream, size_t off, void *dst,
size_t * len, int *wrote_all)
{
quic_fifo_egress_emit (quicly_stream_t * stream, size_t off, void *dst,
size_t * len, int *wrote_all)
{
@@
-944,8
+942,6
@@
quic_fifo_egress_emit (quicly_stream_t * stream, size_t off, void *dst,
stream_data->app_tx_data_len = off + *len;
svm_fifo_peek (f, off, *len, dst);
stream_data->app_tx_data_len = off + *len;
svm_fifo_peek (f, off, *len, dst);
-
- return 0;
}
static const quicly_stream_callbacks_t quic_stream_callbacks = {
}
static const quicly_stream_callbacks_t quic_stream_callbacks = {