Code Review
/
vpp.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
vmxnet3: coverity woe
[vpp.git]
/
src
/
plugins
/
vmxnet3
/
input.c
diff --git
a/src/plugins/vmxnet3/input.c
b/src/plugins/vmxnet3/input.c
index
cdd3c7b
..
4ff459a
100644
(file)
--- a/
src/plugins/vmxnet3/input.c
+++ b/
src/plugins/vmxnet3/input.c
@@
-90,7
+90,7
@@
vmxnet3_device_input_inline (vlib_main_t * vm, vlib_node_runtime_t * node,
u16 rid;
vlib_buffer_t *prev_b0 = 0, *hb = 0;
u32 next_index = VNET_DEVICE_INPUT_NEXT_ETHERNET_INPUT;
u16 rid;
vlib_buffer_t *prev_b0 = 0, *hb = 0;
u32 next_index = VNET_DEVICE_INPUT_NEXT_ETHERNET_INPUT;
- u8 known_next = 0;
+ u8 known_next = 0
, got_packet = 0
;
vmxnet3_rx_desc *rxd;
clib_error_t *error;
vmxnet3_rx_desc *rxd;
clib_error_t *error;
@@
-173,6
+173,7
@@
vmxnet3_device_input_inline (vlib_main_t * vm, vlib_node_runtime_t * node,
* Both start and end of packet is set. It is a complete packet
*/
prev_b0 = 0;
* Both start and end of packet is set. It is a complete packet
*/
prev_b0 = 0;
+ got_packet = 1;
}
}
else if (rx_comp->index & VMXNET3_RXCI_EOP)
}
}
else if (rx_comp->index & VMXNET3_RXCI_EOP)
@@
-184,7
+185,8
@@
vmxnet3_device_input_inline (vlib_main_t * vm, vlib_node_runtime_t * node,
prev_b0->next_buffer = bi0;
hb->total_length_not_including_first_buffer +=
b0->current_length;
prev_b0->next_buffer = bi0;
hb->total_length_not_including_first_buffer +=
b0->current_length;
- prev_b0 = 0; // Get next packet
+ prev_b0 = 0;
+ got_packet = 1;
}
else
{
}
else
{
@@
-216,7
+218,7
@@
vmxnet3_device_input_inline (vlib_main_t * vm, vlib_node_runtime_t * node,
n_rx_bytes += b0->current_length;
n_rx_bytes += b0->current_length;
- if (
!prev_b0
)
+ if (
got_packet
)
{
ethernet_header_t *e = (ethernet_header_t *) hb->data;
{
ethernet_header_t *e = (ethernet_header_t *) hb->data;
@@
-271,6
+273,7
@@
vmxnet3_device_input_inline (vlib_main_t * vm, vlib_node_runtime_t * node,
next++;
bi++;
hb = 0;
next++;
bi++;
hb = 0;
+ got_packet = 0;
}
}
}
}