Code Review
/
vpp.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
vppapigen: require service definition for singleton messages
[vpp.git]
/
src
/
tools
/
vppapigen
/
vppapigen.py
diff --git
a/src/tools/vppapigen/vppapigen.py
b/src/tools/vppapigen/vppapigen.py
index
57e5e3a
..
e6237a7
100755
(executable)
--- a/
src/tools/vppapigen/vppapigen.py
+++ b/
src/tools/vppapigen/vppapigen.py
@@
-601,10
+601,6
@@
class VPPAPI(object):
continue
if msgs[d].singular is True:
continue
continue
if msgs[d].singular is True:
continue
- #if d.endswith('_counters'):
- # continue
- #if d.endswith('_event'):
- # continue
if d.endswith('_reply'):
if d[:-6] in svcs:
continue
if d.endswith('_reply'):
if d[:-6] in svcs:
continue
@@
-634,9
+630,8
@@
class VPPAPI(object):
if d+'_reply' in msgs:
s['services'].append(Service(d, d+'_reply'))
else:
if d+'_reply' in msgs:
s['services'].append(Service(d, d+'_reply'))
else:
- self.logger.warning('{} missing reply message ({})'
- .format(d, d+'_reply'))
- s['services'].append(Service(d, None))
+ raise ValueError('{} missing reply message ({}) or service definition'
+ .format(d, d+'_reply'))
return s
return s