Code Review
/
vpp.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
vlib: mitigate outdated new cli session events
[vpp.git]
/
src
/
vlib
/
unix
/
cli.c
diff --git
a/src/vlib/unix/cli.c
b/src/vlib/unix/cli.c
index
e6f549b
..
03baf3e
100644
(file)
--- a/
src/vlib/unix/cli.c
+++ b/
src/vlib/unix/cli.c
@@
-1312,6
+1312,10
@@
unix_cli_new_session_process (vlib_main_t * vm, vlib_node_runtime_t * rt,
/* Add an identifier to the new session list */
unix_cli_new_session_t ns;
/* Add an identifier to the new session list */
unix_cli_new_session_t ns;
+ /* Check the connection didn't close already */
+ if (pool_is_free_index (cm->cli_file_pool, event_data[0]))
+ break;
+
ns.cf_index = event_data[0];
ns.deadline = vlib_time_now (vm) + 1.0;
ns.cf_index = event_data[0];
ns.deadline = vlib_time_now (vm) + 1.0;
@@
-2693,7
+2697,7
@@
unix_cli_kill (unix_cli_main_t * cm, uword cli_file_index)
if (ns->cf_index == cli_file_index)
{
if (ns->cf_index == cli_file_index)
{
-
vec_del1 (cm->new_sessions, i)
;
+
ns->cf_index = ~0
;
break;
}
}
break;
}
}