Code Review
/
vpp.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
misc: fix coverity warnings
[vpp.git]
/
src
/
vlib
/
unix
/
cli.c
diff --git
a/src/vlib/unix/cli.c
b/src/vlib/unix/cli.c
index
0a8041e
..
b0ed9d2
100644
(file)
--- a/
src/vlib/unix/cli.c
+++ b/
src/vlib/unix/cli.c
@@
-3089,9
+3089,11
@@
unix_cli_config (vlib_main_t * vm, unformat_input_t * input)
clib_panic ("sigaction");
/* Retrieve the current terminal size */
clib_panic ("sigaction");
/* Retrieve the current terminal size */
- ioctl (STDIN_FILENO, TIOCGWINSZ, &ws);
- cf->width = ws.ws_col;
- cf->height = ws.ws_row;
+ if (ioctl (STDIN_FILENO, TIOCGWINSZ, &ws) == 0)
+ {
+ cf->width = ws.ws_col;
+ cf->height = ws.ws_row;
+ }
if (cf->width == 0 || cf->height == 0)
{
if (cf->width == 0 || cf->height == 0)
{
@@
-3328,7
+3330,7
@@
unix_cli_exec (vlib_main_t * vm,
unformat_free (&sub_input);
done:
unformat_free (&sub_input);
done:
- if (fd > 0)
+ if (fd >
=
0)
close (fd);
vec_free (file_name);
close (fd);
vec_free (file_name);