Code Review
/
vpp.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
SCTP: coverity warnings
[vpp.git]
/
src
/
vnet
/
sctp
/
sctp_input.c
diff --git
a/src/vnet/sctp/sctp_input.c
b/src/vnet/sctp/sctp_input.c
index
7c753a2
..
ff79840
100644
(file)
--- a/
src/vnet/sctp/sctp_input.c
+++ b/
src/vnet/sctp/sctp_input.c
@@
-492,7
+492,6
@@
sctp_handle_init_ack (sctp_header_t * sctp_hdr,
{
sctp_init_ack_chunk_t *init_ack_chunk =
(sctp_init_ack_chunk_t *) (sctp_hdr);
{
sctp_init_ack_chunk_t *init_ack_chunk =
(sctp_init_ack_chunk_t *) (sctp_hdr);
- sctp_state_cookie_param_t state_cookie;
char hostname[FQDN_MAX_LENGTH];
char hostname[FQDN_MAX_LENGTH];
@@
-569,8
+568,9
@@
sctp_handle_init_ack (sctp_header_t * sctp_hdr,
sctp_state_cookie_param_t *state_cookie_param =
(sctp_state_cookie_param_t *) opt_params_hdr;
sctp_state_cookie_param_t *state_cookie_param =
(sctp_state_cookie_param_t *) opt_params_hdr;
- clib_memcpy (&
state_cookie
, state_cookie_param,
+ clib_memcpy (&
(sctp_conn->cookie_param)
, state_cookie_param,
sizeof (sctp_state_cookie_param_t));
sizeof (sctp_state_cookie_param_t));
+
break;
}
case SCTP_HOSTNAME_ADDRESS_TYPE:
break;
}
case SCTP_HOSTNAME_ADDRESS_TYPE:
@@
-596,9
+596,6
@@
sctp_handle_init_ack (sctp_header_t * sctp_hdr,
}
}
}
}
- clib_memcpy (&(sctp_conn->cookie_param), &state_cookie,
- sizeof (sctp_state_cookie_param_t));
-
sctp_prepare_cookie_echo_chunk (sctp_conn, idx, b0, 1);
/* Start the T1_COOKIE timer */
sctp_prepare_cookie_echo_chunk (sctp_conn, idx, b0, 1);
/* Start the T1_COOKIE timer */