Code Review
/
vpp.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Improve exceptions in vpp_transport_socket.py
[vpp.git]
/
src
/
vpp-api
/
python
/
vpp_papi
/
vpp_transport_socket.py
diff --git
a/src/vpp-api/python/vpp_papi/vpp_transport_socket.py
b/src/vpp-api/python/vpp_papi/vpp_transport_socket.py
index
b00d15d
..
caee43f
100644
(file)
--- a/
src/vpp-api/python/vpp_papi/vpp_transport_socket.py
+++ b/
src/vpp-api/python/vpp_papi/vpp_transport_socket.py
@@
-14,6
+14,7
@@
import logging
class VppTransportSocketIOError(IOError):
class VppTransportSocketIOError(IOError):
+ # TODO: Document different values of error number (first numeric argument).
pass
pass
@@
-70,8
+71,8
@@
class VppTransport(object):
def connect(self, name, pfx, msg_handler, rx_qlen):
if self.message_thread is not None:
def connect(self, name, pfx, msg_handler, rx_qlen):
if self.message_thread is not None:
- raise
Runtime
Error(
-
"PAPI socket transport connect: You n
eed to disconnect first.")
+ raise
VppTransportSocketIO
Error(
+
1, "PAPI socket transport connect: N
eed to disconnect first.")
self.message_thread = threading.Thread(target=self.msg_thread_func)
# Create a UDS socket
self.message_thread = threading.Thread(target=self.msg_thread_func)
# Create a UDS socket
@@
-98,6
+99,7
@@
class VppTransport(object):
msg = self._read()
hdr, length = self.parent.header.unpack(msg, 0)
if hdr.msgid != 16:
msg = self._read()
hdr, length = self.parent.header.unpack(msg, 0)
if hdr.msgid != 16:
+ # TODO: Add first numeric argument.
raise VppTransportSocketIOError('Invalid reply message')
r, length = sockclnt_create_reply.unpack(msg)
raise VppTransportSocketIOError('Invalid reply message')
r, length = sockclnt_create_reply.unpack(msg)