libmemif: memif_rx_burst fix
[vpp.git] / extras / libmemif / src / main.c
index d1b59ee..8cc0d66 100644 (file)
@@ -181,7 +181,7 @@ print_bytes (void *data, uint16_t len, uint8_t q)
     }
   printf ("\n\n");
 }
-#endif /* MEMIF_DBG */
+#endif /* MEMIF_DBG_SHM */
 
 int
 memif_syscall_error_handler (int err_code)
@@ -656,9 +656,9 @@ memif_create (memif_conn_handle_t * c, memif_conn_args_t * args,
                }
              DBG ("creating socket file");
              ms = malloc (sizeof (memif_socket_t));
-             ms->filename = malloc (strlen ((char *) conn->args.
-                                            socket_filename) +
-                                    sizeof (char));
+             ms->filename =
+               malloc (strlen ((char *) conn->args.socket_filename) +
+                       sizeof (char));
              memset (ms->filename, 0,
                      strlen ((char *) conn->args.socket_filename) +
                      sizeof (char));
@@ -852,7 +852,11 @@ memif_control_fd_handler (int fd, uint8_t events)
                  if (((memif_connection_t *) e->data_struct)->rx_queues[i].
                      int_fd == fd)
                    {
-                     ((memif_connection_t *) e->data_struct)->on_interrupt ((void *) e->data_struct, ((memif_connection_t *) e->data_struct)->private_ctx, i);
+                     ((memif_connection_t *) e->
+                      data_struct)->on_interrupt ((void *) e->data_struct,
+                                                  ((memif_connection_t *)
+                                                   e->data_struct)->
+                                                  private_ctx, i);
                      return MEMIF_ERR_SUCCESS;
                    }
                }
@@ -1336,7 +1340,7 @@ memif_init_regions_and_queues (memif_connection_t * conn)
 int
 memif_buffer_alloc (memif_conn_handle_t conn, uint16_t qid,
                    memif_buffer_t * bufs, uint16_t count,
-                   uint16_t * count_out)
+                   uint16_t * count_out, uint16_t size)
 {
   memif_connection_t *c = (memif_connection_t *) conn;
   if (c == NULL)
@@ -1351,10 +1355,11 @@ memif_buffer_alloc (memif_conn_handle_t conn, uint16_t qid,
   memif_queue_t *mq = &c->tx_queues[qid];
   memif_ring_t *ring = mq->ring;
   memif_buffer_t *b0, *b1;
+  uint8_t chain_buf0, chain_buf1;
   uint16_t mask = (1 << mq->log2_ring_size) - 1;
   uint16_t s0, s1, ns;
   *count_out = 0;
-  int err = MEMIF_ERR_SUCCESS; /* 0 */
+  int i, err = MEMIF_ERR_SUCCESS;      /* 0 */
 
   if (ring->tail != ring->head)
     {
@@ -1373,40 +1378,90 @@ memif_buffer_alloc (memif_conn_handle_t conn, uint16_t qid,
     {
       while ((count > 2) && (ns > 2))
        {
-         s0 = (ring->head + mq->alloc_bufs + *count_out) & mask;
-         s1 = (ring->head + mq->alloc_bufs + *count_out + 1) & mask;
+         s0 = (ring->head + mq->alloc_bufs) & mask;
+         chain_buf0 = size / ring->desc[s0].buffer_length;
+         if (((size % ring->desc[s0].buffer_length) != 0) || (size == 0))
+           chain_buf0++;
+
+         if (chain_buf0 > ns)
+           break;
+
+         s1 = (ring->head + mq->alloc_bufs + chain_buf0) & mask;
+         chain_buf1 = size / ring->desc[s1].buffer_length;
+         if (((size % ring->desc[s1].buffer_length) != 0) || (size == 0))
+           chain_buf1++;
+
+         if ((chain_buf0 + chain_buf1) > ns)
+           break;
 
          b0 = (bufs + *count_out);
          b1 = (bufs + *count_out + 1);
 
          b0->desc_index = s0;
          b1->desc_index = s1;
-         b0->buffer_len = ring->desc[s0].buffer_length;
-         b1->buffer_len = ring->desc[s1].buffer_length;
+         ring->desc[s0].flags = 0;
+         ring->desc[s1].flags = 0;
+         b0->buffer_len = ring->desc[s0].buffer_length * chain_buf0;
+         b1->buffer_len = ring->desc[s1].buffer_length * chain_buf1;
          /* TODO: support multiple regions -> ring descriptor contains region index */
          b0->data = c->regions->shm + ring->desc[s0].offset;
          b1->data = c->regions->shm + ring->desc[s1].offset;
 
+         for (i = 0; i < (memif_min (chain_buf0, chain_buf1) - 1); i++)
+           {
+             ring->desc[(s0 + i) & mask].flags |= MEMIF_DESC_FLAG_NEXT;
+             ring->desc[(s1 + i) & mask].flags |= MEMIF_DESC_FLAG_NEXT;
+             DBG ("allocating chained buffers");
+           }
+
+         if (chain_buf0 > chain_buf1)
+           {
+             for (; i < (chain_buf0 - 1); i++)
+               ring->desc[(s0 + i) & mask].flags |= MEMIF_DESC_FLAG_NEXT;
+           }
+         else
+           {
+             for (; i < (chain_buf1 - 1); i++)
+               ring->desc[(s1 + i) & mask].flags |= MEMIF_DESC_FLAG_NEXT;
+           }
+
+         mq->alloc_bufs += chain_buf0 + chain_buf1;
+
          DBG ("allocated ring slots %u, %u", s0, s1);
          count -= 2;
-         ns -= 2;
+         ns -= chain_buf0 + chain_buf1;
          *count_out += 2;
        }
-      s0 = (ring->head + mq->alloc_bufs + *count_out) & mask;
+      s0 = (ring->head + mq->alloc_bufs) & mask;
 
       b0 = (bufs + *count_out);
 
+      chain_buf0 = size / ring->desc[s0].buffer_length;
+      if (((size % ring->desc[s0].buffer_length) != 0) || (size == 0))
+       chain_buf0++;
+
+      if (chain_buf0 > ns)
+       break;
+
       b0->desc_index = s0;
-      b0->buffer_len = ring->desc[s0].buffer_length;
+      ring->desc[s0].flags = 0;
+      b0->buffer_len = ring->desc[s0].buffer_length * chain_buf0;
       b0->data = c->regions->shm + ring->desc[s0].offset;
 
+      for (i = 0; i < (chain_buf0 - 1); i++)
+       {
+         ring->desc[(s0 + i) & mask].flags |= MEMIF_DESC_FLAG_NEXT;
+         DBG ("allocating chained buffers");
+       }
+
+      mq->alloc_bufs += chain_buf0;
+
       DBG ("allocated ring slot %u", s0);
       count--;
-      ns--;
+      ns -= chain_buf0;
       *count_out += 1;
     }
 
-  mq->alloc_bufs += *count_out;
   DBG ("allocated: %u/%u bufs. Total %u allocated bufs", *count_out, count,
        mq->alloc_bufs);
 
@@ -1439,6 +1494,7 @@ memif_buffer_free (memif_conn_handle_t conn, uint16_t qid,
   memif_ring_t *ring = mq->ring;
   uint16_t tail = ring->tail;
   uint16_t mask = (1 << mq->log2_ring_size) - 1;
+  uint8_t chain_buf0, chain_buf1;
   memif_buffer_t *b0, *b1;
   *count_out = 0;
 
@@ -1451,25 +1507,38 @@ memif_buffer_free (memif_conn_handle_t conn, uint16_t qid,
        {
          b0 = (bufs + *count_out);
          b1 = (bufs + *count_out + 1);
-         tail = (b0->desc_index + 1) & mask;
-         tail = (b1->desc_index + 1) & mask;
+         chain_buf0 =
+           b0->buffer_len / ring->desc[b0->desc_index].buffer_length;
+         if ((b0->buffer_len % ring->desc[b0->desc_index].buffer_length) !=
+             0)
+           chain_buf0++;
+         chain_buf1 =
+           b1->buffer_len / ring->desc[b1->desc_index].buffer_length;
+         if ((b1->buffer_len % ring->desc[b1->desc_index].buffer_length) !=
+             0)
+           chain_buf1++;
+         tail = (b1->desc_index + chain_buf1) & mask;
          b0->data = NULL;
          b1->data = NULL;
 
          count -= 2;
          *count_out += 2;
-         mq->alloc_bufs -= 2;
+         mq->alloc_bufs -= chain_buf0 + chain_buf1;
        }
       b0 = (bufs + *count_out);
-      tail = (b0->desc_index + 1) & mask;
+      chain_buf0 = b0->buffer_len / ring->desc[b0->desc_index].buffer_length;
+      if ((b0->buffer_len % ring->desc[b0->desc_index].buffer_length) != 0)
+       chain_buf0++;
+      tail = (b0->desc_index + chain_buf0) & mask;
       b0->data = NULL;
 
       count--;
       *count_out += 1;
-      mq->alloc_bufs--;
+      mq->alloc_bufs -= chain_buf0;
     }
   MEMIF_MEORY_BARRIER ();
   ring->tail = tail;
+  DBG ("tail: %u", ring->tail);
 
   return MEMIF_ERR_SUCCESS;    /* 0 */
 }
@@ -1492,55 +1561,198 @@ memif_tx_burst (memif_conn_handle_t conn, uint16_t qid,
   memif_ring_t *ring = mq->ring;
   uint16_t head = ring->head;
   uint16_t mask = (1 << mq->log2_ring_size) - 1;
+  uint8_t chain_buf0, chain_buf1;
   *tx = 0;
+  uint16_t curr_buf = 0;
   memif_buffer_t *b0, *b1;
+  int i;
 
   while (count)
     {
       while (count > 2)
        {
-         b0 = (bufs + *tx);
-         b1 = (bufs + *tx + 1);
-         ring->desc[b0->desc_index].length = b0->data_len;
-         ring->desc[b1->desc_index].length = b1->data_len;
+         b0 = (bufs + curr_buf);
+         b1 = (bufs + curr_buf + 1);
+         chain_buf0 =
+           b0->buffer_len / ring->desc[b0->desc_index].buffer_length;
+         if ((b0->buffer_len % ring->desc[b0->desc_index].buffer_length) !=
+             0)
+           chain_buf0++;
+
+         chain_buf1 =
+           b1->buffer_len / ring->desc[b1->desc_index].buffer_length;
+         if ((b1->buffer_len % ring->desc[b1->desc_index].buffer_length) !=
+             0)
+           chain_buf1++;
+
+         for (i = 0; i < memif_min (chain_buf0, chain_buf1); i++)
+           {
+             /* b0 */
+             if (b0->data_len >
+                 ring->desc[(b0->desc_index + i) & mask].buffer_length)
+               {
+                 b0->data_len -=
+                   ring->desc[(b0->desc_index + i) & mask].length =
+                   ring->desc[(b0->desc_index + i) & mask].buffer_length;
+               }
+             else
+               {
+                 ring->desc[(b0->desc_index + i) & mask].length =
+                   b0->data_len;
+                 b0->data_len = 0;
+               }
+             /* b1 */
+             if (b1->data_len >
+                 ring->desc[(b1->desc_index + i) & mask].buffer_length)
+               {
+                 b1->data_len -=
+                   ring->desc[(b1->desc_index + i) & mask].length =
+                   ring->desc[(b1->desc_index + i) & mask].buffer_length;
+               }
+             else
+               {
+                 ring->desc[(b1->desc_index + i) & mask].length =
+                   b1->data_len;
+                 b1->data_len = 0;
+               }
+#ifdef MEMIF_DBG_SHM
+             print_bytes (b0->data +
+                          ring->desc[(b0->desc_index +
+                                      i) & mask].buffer_length *
+                          (chain_buf0 - 1),
+                          ring->desc[(b0->desc_index +
+                                      i) & mask].buffer_length, DBG_TX_BUF);
+             print_bytes (b1->data +
+                          ring->desc[(b1->desc_index +
+                                      i) & mask].buffer_length *
+                          (chain_buf1 - 1),
+                          ring->desc[(b1->desc_index +
+                                      i) & mask].buffer_length, DBG_TX_BUF);
+#endif /* MEMIF_DBG_SHM */
+           }
 
+         if (chain_buf0 > chain_buf1)
+           {
+             for (; i < chain_buf0; i++)
+               {
+                 if (b0->data_len >
+                     ring->desc[(b0->desc_index + i) & mask].buffer_length)
+                   {
+                     b0->data_len -=
+                       ring->desc[(b0->desc_index + i) & mask].length =
+                       ring->desc[(b0->desc_index + i) & mask].buffer_length;
+                   }
+                 else
+                   {
+                     ring->desc[(b0->desc_index + i) & mask].length =
+                       b0->data_len;
+                     b0->data_len = 0;
+                   }
+#ifdef MEMIF_DBG_SHM
+                 print_bytes (b0->data +
+                              ring->desc[(b0->desc_index +
+                                          i) & mask].buffer_length *
+                              (chain_buf0 - 1),
+                              ring->desc[(b0->desc_index +
+                                          i) & mask].buffer_length,
+                              DBG_TX_BUF);
+#endif /* MEMIF_DBG_SHM */
+               }
+           }
+         else
+           {
+             for (; i < chain_buf1; i++)
+               {
+                 if (b1->data_len >
+                     ring->desc[(b1->desc_index + i) & mask].buffer_length)
+                   {
+                     b1->data_len -=
+                       ring->desc[(b1->desc_index + i) & mask].length =
+                       ring->desc[(b1->desc_index + i) & mask].buffer_length;
+                   }
+                 else
+                   {
+                     ring->desc[(b1->desc_index + i) & mask].length =
+                       b1->data_len;
+                     b1->data_len = 0;
+                   }
 #ifdef MEMIF_DBG_SHM
-         print_bytes (b0->data, b0->data_len, DBG_TX_BUF);
-         print_bytes (b1->data, b1->data_len, DBG_TX_BUF);
-#endif
+                 print_bytes (b1->data +
+                              ring->desc[(b1->desc_index +
+                                          i) & mask].buffer_length *
+                              (chain_buf1 - 1),
+                              ring->desc[(b1->desc_index +
+                                          i) & mask].buffer_length,
+                              DBG_TX_BUF);
+#endif /* MEMIF_DBG_SHM */
+               }
+           }
 
-         head = (b0->desc_index + 1) & mask;
-         head = (b1->desc_index + 1) & mask;
+         head = (b1->desc_index + chain_buf1) & mask;
 
          b0->data = NULL;
-         b0->data_len = 0;
+#ifdef MEMIF_DBG
+         if (b0->data_len != 0)
+           DBG ("invalid b0 data length!");
+#endif /* MEMIF_DBG */
          b1->data = NULL;
-         b1->data_len = 0;
+#ifdef MEMIF_DBG
+         if (b1->data_len != 0)
+           DBG ("invalid b1 data length!");
+#endif /* MEMIF_DBG */
 
          count -= 2;
-         *tx += 2;
+         *tx += chain_buf0 + chain_buf1;
+         curr_buf += 2;
        }
 
-      b0 = (bufs + *tx);
-      ring->desc[b0->desc_index].length = b0->data_len;
+      b0 = (bufs + curr_buf);
+      chain_buf0 = b0->buffer_len / ring->desc[b0->desc_index].buffer_length;
+      if ((b0->buffer_len % ring->desc[b0->desc_index].buffer_length) != 0)
+       chain_buf0++;
 
+      for (i = 0; i < chain_buf0; i++)
+       {
+         if (b0->data_len >
+             ring->desc[(b0->desc_index + i) & mask].buffer_length)
+           {
+             b0->data_len -= ring->desc[(b0->desc_index + i) & mask].length =
+               ring->desc[(b0->desc_index + i) & mask].buffer_length;
+           }
+         else
+           {
+             ring->desc[(b0->desc_index + i) & mask].length = b0->data_len;
+             b0->data_len = 0;
+           }
 #ifdef MEMIF_DBG_SHM
-      print_bytes (b0->data, b0->data_len, DBG_TX_BUF);
-#endif
+         print_bytes (b0->data +
+                      ring->desc[(b0->desc_index + i) & mask].buffer_length *
+                      (chain_buf0 - 1),
+                      ring->desc[(b0->desc_index + i) & mask].buffer_length,
+                      DBG_TX_BUF);
+#endif /* MEMIF_DBG_SHM */
+       }
 
-      head = (b0->desc_index + 1) & mask;
+      head = (b0->desc_index + chain_buf0) & mask;
 
       b0->data = NULL;
-      b0->data_len = 0;
+#ifdef MEMIF_DBG
+      if (b0->data_len != 0)
+       DBG ("invalid b0 data length!");
+#endif /* MEMIF_DBG */
 
       count--;
-      *tx += 1;
+      *tx += chain_buf0;
+      curr_buf++;
     }
   MEMIF_MEORY_BARRIER ();
   ring->head = head;
 
   mq->alloc_bufs -= *tx;
 
+  /* TODO: return num of buffers and packets */
+  *tx = curr_buf;
+
   if ((ring->flags & MEMIF_RING_FLAG_MASK_INT) == 0)
     {
       uint64_t a = 1;
@@ -1572,7 +1784,9 @@ memif_rx_burst (memif_conn_handle_t conn, uint16_t qid,
   uint16_t ns;
   uint16_t mask = (1 << mq->log2_ring_size) - 1;
   memif_buffer_t *b0, *b1;
+  uint16_t curr_buf = 0;
   *rx = 0;
+  int i;
 
   uint64_t b;
   ssize_t r = read (mq->int_fd, &b, sizeof (b));
@@ -1589,51 +1803,122 @@ memif_rx_burst (memif_conn_handle_t conn, uint16_t qid,
 
   while (ns && count)
     {
+      DBG ("ns: %u, count: %u", ns, count);
       while ((ns > 2) && (count > 2))
        {
-         b0 = (bufs + *rx);
-         b1 = (bufs + *rx + 1);
+         b0 = (bufs + curr_buf);
+         b1 = (bufs + curr_buf + 1);
 
          b0->desc_index = mq->last_head;
-         b1->desc_index = mq->last_head + 1;
-         b0->data = memif_get_buffer (conn, ring, mq->last_head);
-         b1->data = memif_get_buffer (conn, ring, mq->last_head + 1);
-         b0->data_len = ring->desc[mq->last_head].length;
-         b1->data_len = ring->desc[mq->last_head + 1].length;
-         b0->buffer_len = ring->desc[mq->last_head].buffer_length;
-         b1->buffer_len = ring->desc[mq->last_head + 1].buffer_length;
+         i = 0;
+         b0->data_len = 0;
+         b0->buffer_len = 0;
 
+         b0->data = memif_get_buffer (conn, ring, mq->last_head);
+         b0->data_len += ring->desc[mq->last_head].length;
+         b0->buffer_len += ring->desc[mq->last_head].buffer_length;
 #ifdef MEMIF_DBG_SHM
-         print_bytes (b0->data, b0->data_len, DBG_RX_BUF);
-         print_bytes (b1->data, b1->data_len, DBG_RX_BUF);
-#endif
+         print_bytes (b0->data +
+                      ring->desc[b0->desc_index].buffer_length * i++,
+                      ring->desc[b0->desc_index].buffer_length, DBG_TX_BUF);
+#endif /* MEMIF_DBG_SHM */
+         ns--;
+         *rx += 1;
+         while (ring->desc[mq->last_head].flags & MEMIF_DESC_FLAG_NEXT)
+           {
+             ring->desc[mq->last_head].flags &= ~MEMIF_DESC_FLAG_NEXT;
+             mq->last_head = (mq->last_head + 1) & mask;
+             b0->data_len += ring->desc[mq->last_head].length;
+             b0->buffer_len += ring->desc[mq->last_head].buffer_length;
+#ifdef MEMIF_DBG_SHM
+             print_bytes (b0->data +
+                          ring->desc[b0->desc_index].buffer_length * i++,
+                          ring->desc[b0->desc_index].buffer_length,
+                          DBG_TX_BUF);
+#endif /* MEMIF_DBG_SHM */
+             ns--;
+             *rx += 1;
+           }
+         mq->last_head = (mq->last_head + 1) & mask;
 
-         mq->last_head = (mq->last_head + 2) & mask;
+         b1->desc_index = mq->last_head;
+         i = 0;
+         b1->data_len = 0;
+         b1->buffer_len = 0;
+
+         b1->data = memif_get_buffer (conn, ring, mq->last_head);
+         b1->data_len += ring->desc[mq->last_head].length;
+         b1->buffer_len += ring->desc[mq->last_head].buffer_length;
+#ifdef MEMIF_DBG_SHM
+         print_bytes (b1->data +
+                      ring->desc[b1->desc_index].buffer_length * i++,
+                      ring->desc[b1->desc_index].buffer_length, DBG_TX_BUF);
+#endif /* MEMIF_DBG_SHM */
+         ns--;
+         *rx += 1;
+         while (ring->desc[mq->last_head].flags & MEMIF_DESC_FLAG_NEXT)
+           {
+             ring->desc[mq->last_head].flags &= ~MEMIF_DESC_FLAG_NEXT;
+             mq->last_head = (mq->last_head + 1) & mask;
+             b1->data_len += ring->desc[mq->last_head].length;
+             b1->buffer_len += ring->desc[mq->last_head].buffer_length;
+#ifdef MEMIF_DBG_SHM
+             print_bytes (b1->data +
+                          ring->desc[b1->desc_index].buffer_length * i++,
+                          ring->desc[b1->desc_index].buffer_length,
+                          DBG_TX_BUF);
+#endif /* MEMIF_DBG_SHM */
+             ns--;
+             *rx += 1;
+           }
+         mq->last_head = (mq->last_head + 1) & mask;
 
-         ns -= 2;
          count -= 2;
-         *rx += 2;
+         curr_buf += 2;
        }
-      b0 = (bufs + *rx);
+      b0 = (bufs + curr_buf);
 
       b0->desc_index = mq->last_head;
-      b0->data = memif_get_buffer (conn, ring, mq->last_head);
-      b0->data_len = ring->desc[mq->last_head].length;
-      b0->buffer_len = ring->desc[mq->last_head].buffer_length;
+      i = 0;
+      b0->data_len = 0;
+      b0->buffer_len = 0;
 
+      b0->data = memif_get_buffer (conn, ring, mq->last_head);
+      b0->data_len += ring->desc[mq->last_head].length;
+      b0->buffer_len += ring->desc[mq->last_head].buffer_length;
 #ifdef MEMIF_DBG_SHM
-      print_bytes (b0->data, b0->data_len, DBG_RX_BUF);
-#endif
+      print_bytes (b0->data +
+                  ring->desc[b0->desc_index].buffer_length * i++,
+                  ring->desc[b0->desc_index].buffer_length, DBG_TX_BUF);
+#endif /* MEMIF_DBG_SHM */
+      ns--;
+      *rx += 1;
 
+      while (ring->desc[mq->last_head].flags & MEMIF_DESC_FLAG_NEXT)
+       {
+         ring->desc[mq->last_head].flags &= ~MEMIF_DESC_FLAG_NEXT;
+         mq->last_head = (mq->last_head + 1) & mask;
+         b0->data_len += ring->desc[mq->last_head].length;
+         b0->buffer_len += ring->desc[mq->last_head].buffer_length;
+#ifdef MEMIF_DBG_SHM
+         print_bytes (b0->data +
+                      ring->desc[b0->desc_index].buffer_length * i++,
+                      ring->desc[b0->desc_index].buffer_length, DBG_TX_BUF);
+#endif /* MEMIF_DBG_SHM */
+         ns--;
+         *rx += 1;
+       }
       mq->last_head = (mq->last_head + 1) & mask;
 
-      ns--;
       count--;
-      *rx += 1;
+      curr_buf++;
     }
 
   mq->alloc_bufs += *rx;
 
+  /* TODO: return num of buffers and packets */
+  *rx = curr_buf;
+
   if (ns)
     {
       DBG ("not enough buffers!");