Add VLIB_NODE_FN() macro to simplify multiversioning of node functions
[vpp.git] / src / plugins / dpdk / buffer.c
index a44428a..3324c04 100644 (file)
  * Allocate/free network buffers.
  */
 
+#include <unistd.h>
+#include <linux/vfio.h>
+#include <sys/ioctl.h>
+
 #include <rte_config.h>
 
 #include <rte_common.h>
 #include <rte_version.h>
 
 #include <vlib/vlib.h>
+#include <vlib/unix/unix.h>
+#include <vlib/pci/pci.h>
+#include <vlib/linux/vfio.h>
 #include <vnet/vnet.h>
 #include <dpdk/device/dpdk.h>
 #include <dpdk/device/dpdk_priv.h>
 
-
 STATIC_ASSERT (VLIB_BUFFER_PRE_DATA_SIZE == RTE_PKTMBUF_HEADROOM,
               "VLIB_BUFFER_PRE_DATA_SIZE must be equal to RTE_PKTMBUF_HEADROOM");
 
+typedef struct
+{
+  CLIB_CACHE_LINE_ALIGN_MARK (cacheline0);
+  struct rte_mbuf ***mbuf_pending_free_list;
+
+  /* cached last pool */
+  struct rte_mempool *last_pool;
+  u8 last_buffer_pool_index;
+} dpdk_buffer_per_thread_data;
+
+typedef struct
+{
+  int vfio_container_fd;
+  dpdk_buffer_per_thread_data *ptd;
+} dpdk_buffer_main_t;
+
+dpdk_buffer_main_t dpdk_buffer_main;
+
 static_always_inline void
-dpdk_rte_pktmbuf_free (vlib_main_t * vm, vlib_buffer_t * b)
+dpdk_rte_pktmbuf_free (vlib_main_t * vm, u32 thread_index, vlib_buffer_t * b)
 {
   vlib_buffer_t *hb = b;
+  dpdk_buffer_main_t *dbm = &dpdk_buffer_main;
+  dpdk_buffer_per_thread_data *d = vec_elt_at_index (dbm->ptd, thread_index);
   struct rte_mbuf *mb;
   u32 next, flags;
   mb = rte_mbuf_from_vlib_buffer (hb);
@@ -98,7 +124,20 @@ next:
       b->n_add_refs = 0;
     }
 
-  rte_pktmbuf_free_seg (mb);
+  mb = rte_pktmbuf_prefree_seg (mb);
+  if (mb)
+    {
+      if (mb->pool != d->last_pool)
+       {
+         d->last_pool = mb->pool;
+         dpdk_mempool_private_t *privp = rte_mempool_get_priv (d->last_pool);
+         d->last_buffer_pool_index = privp->buffer_pool_index;
+         vec_validate_aligned (d->mbuf_pending_free_list,
+                               d->last_buffer_pool_index,
+                               CLIB_CACHE_LINE_BYTES);
+       }
+      vec_add1 (d->mbuf_pending_free_list[d->last_buffer_pool_index], mb);
+    }
 
   if (flags & VLIB_BUFFER_NEXT_PRESENT)
     {
@@ -107,63 +146,57 @@ next:
     }
 }
 
+#ifndef CLIB_MARCH_VARIANT
 static void
 del_free_list (vlib_main_t * vm, vlib_buffer_free_list_t * f)
 {
   u32 i;
   vlib_buffer_t *b;
+  u32 thread_index = vlib_get_thread_index ();
 
   for (i = 0; i < vec_len (f->buffers); i++)
     {
       b = vlib_get_buffer (vm, f->buffers[i]);
-      dpdk_rte_pktmbuf_free (vm, b);
+      dpdk_rte_pktmbuf_free (vm, thread_index, b);
     }
 
   vec_free (f->name);
   vec_free (f->buffers);
+  /* Poison it. */
+  memset (f, 0xab, sizeof (f[0]));
 }
 
 /* Add buffer free list. */
 static void
-dpdk_buffer_delete_free_list (vlib_main_t * vm, u32 free_list_index)
+dpdk_buffer_delete_free_list (vlib_main_t * vm,
+                             vlib_buffer_free_list_index_t free_list_index)
 {
-  vlib_buffer_main_t *bm = vm->buffer_main;
   vlib_buffer_free_list_t *f;
-  u32 merge_index;
   int i;
 
   ASSERT (vlib_get_thread_index () == 0);
 
   f = vlib_buffer_get_free_list (vm, free_list_index);
 
-  merge_index = vlib_buffer_get_free_list_with_size (vm, f->n_data_bytes);
-  if (merge_index != ~0 && merge_index != free_list_index)
-    {
-      vlib_buffer_merge_free_lists (pool_elt_at_index
-                                   (bm->buffer_free_list_pool, merge_index),
-                                   f);
-    }
-
   del_free_list (vm, f);
 
-  /* Poison it. */
-  memset (f, 0xab, sizeof (f[0]));
-
-  pool_put (bm->buffer_free_list_pool, f);
+  pool_put (vm->buffer_free_list_pool, f);
 
   for (i = 1; i < vec_len (vlib_mains); i++)
     {
-      bm = vlib_mains[i]->buffer_main;
-      f = vlib_buffer_get_free_list (vlib_mains[i], free_list_index);;
-      memset (f, 0xab, sizeof (f[0]));
-      pool_put (bm->buffer_free_list_pool, f);
+      vlib_main_t *wvm = vlib_mains[i];
+      f = vlib_buffer_get_free_list (vlib_mains[i], free_list_index);
+      del_free_list (wvm, f);
+      pool_put (wvm->buffer_free_list_pool, f);
     }
 }
+#endif
 
 /* Make sure free list has at least given number of free buffers. */
-static uword
-fill_free_list (vlib_main_t * vm,
-               vlib_buffer_free_list_t * fl, uword min_free_buffers)
+uword
+CLIB_MULTIARCH_FN (dpdk_buffer_fill_free_list) (vlib_main_t * vm,
+                                               vlib_buffer_free_list_t * fl,
+                                               uword min_free_buffers)
 {
   dpdk_main_t *dm = &dpdk_main;
   vlib_buffer_t *b0, *b1, *b2, *b3;
@@ -171,7 +204,9 @@ fill_free_list (vlib_main_t * vm,
   u32 bi0, bi1, bi2, bi3;
   unsigned socket_id = rte_socket_id ();
   struct rte_mempool *rmp = dm->pktmbuf_pools[socket_id];
+  dpdk_mempool_private_t *privp = rte_mempool_get_priv (rmp);
   struct rte_mbuf *mb0, *mb1, *mb2, *mb3;
+  vlib_buffer_t bt;
 
   /* Too early? */
   if (PREDICT_FALSE (rmp == 0))
@@ -186,16 +221,22 @@ fill_free_list (vlib_main_t * vm,
   n = round_pow2 (n, CLIB_CACHE_LINE_BYTES / sizeof (u32));
 
   /* Always allocate new buffers in reasonably large sized chunks. */
-  n = clib_max (n, fl->min_n_buffers_each_physmem_alloc);
+  n = clib_max (n, fl->min_n_buffers_each_alloc);
 
   vec_validate_aligned (vm->mbuf_alloc_list, n - 1, CLIB_CACHE_LINE_BYTES);
 
   if (rte_mempool_get_bulk (rmp, vm->mbuf_alloc_list, n) < 0)
     return 0;
 
+  memset (&bt, 0, sizeof (vlib_buffer_t));
+  vlib_buffer_init_for_free_list (&bt, fl);
+  bt.buffer_pool_index = privp->buffer_pool_index;
+
   _vec_len (vm->mbuf_alloc_list) = n;
 
   i = 0;
+  int f = vec_len (fl->buffers);
+  vec_resize_aligned (fl->buffers, n, CLIB_CACHE_LINE_BYTES);
 
   while (i < (n - 7))
     {
@@ -223,15 +264,12 @@ fill_free_list (vlib_main_t * vm,
       bi2 = vlib_get_buffer_index (vm, b2);
       bi3 = vlib_get_buffer_index (vm, b3);
 
-      vec_add1_aligned (fl->buffers, bi0, CLIB_CACHE_LINE_BYTES);
-      vec_add1_aligned (fl->buffers, bi1, CLIB_CACHE_LINE_BYTES);
-      vec_add1_aligned (fl->buffers, bi2, CLIB_CACHE_LINE_BYTES);
-      vec_add1_aligned (fl->buffers, bi3, CLIB_CACHE_LINE_BYTES);
+      fl->buffers[f++] = bi0;
+      fl->buffers[f++] = bi1;
+      fl->buffers[f++] = bi2;
+      fl->buffers[f++] = bi3;
 
-      vlib_buffer_init_for_free_list (b0, fl);
-      vlib_buffer_init_for_free_list (b1, fl);
-      vlib_buffer_init_for_free_list (b2, fl);
-      vlib_buffer_init_for_free_list (b3, fl);
+      clib_memcpy64_x4 (b0, b1, b2, b3, &bt);
 
       if (fl->buffer_init_function)
        {
@@ -250,9 +288,8 @@ fill_free_list (vlib_main_t * vm,
       b0 = vlib_buffer_from_rte_mbuf (mb0);
       bi0 = vlib_get_buffer_index (vm, b0);
 
-      vec_add1_aligned (fl->buffers, bi0, CLIB_CACHE_LINE_BYTES);
-
-      vlib_buffer_init_for_free_list (b0, fl);
+      fl->buffers[f++] = bi0;
+      clib_memcpy (b0, &bt, sizeof (vlib_buffer_t));
 
       if (fl->buffer_init_function)
        fl->buffer_init_function (vm, fl, &bi0, 1);
@@ -264,66 +301,60 @@ fill_free_list (vlib_main_t * vm,
   return n;
 }
 
-static u32
-alloc_from_free_list (vlib_main_t * vm,
-                     vlib_buffer_free_list_t * free_list,
-                     u32 * alloc_buffers, u32 n_alloc_buffers)
+static_always_inline void
+dpdk_prefetch_buffer_by_index (vlib_main_t * vm, u32 bi)
 {
-  u32 *dst, *src;
-  uword len, n_filled;
-
-  dst = alloc_buffers;
-
-  n_filled = fill_free_list (vm, free_list, n_alloc_buffers);
-  if (n_filled == 0)
-    return 0;
-
-  len = vec_len (free_list->buffers);
-  ASSERT (len >= n_alloc_buffers);
-
-  src = free_list->buffers + len - n_alloc_buffers;
-  clib_memcpy (dst, src, n_alloc_buffers * sizeof (u32));
-
-  _vec_len (free_list->buffers) -= n_alloc_buffers;
-
-  return n_alloc_buffers;
+  vlib_buffer_t *b;
+  struct rte_mbuf *mb;
+  b = vlib_get_buffer (vm, bi);
+  mb = rte_mbuf_from_vlib_buffer (b);
+  CLIB_PREFETCH (mb, 2 * CLIB_CACHE_LINE_BYTES, STORE);
+  CLIB_PREFETCH (b, CLIB_CACHE_LINE_BYTES, LOAD);
 }
 
-/* Allocate a given number of buffers into given array.
-   Returns number actually allocated which will be either zero or
-   number requested. */
-u32
-dpdk_buffer_alloc (vlib_main_t * vm, u32 * buffers, u32 n_buffers)
+static_always_inline void
+recycle_or_free (vlib_main_t * vm, vlib_buffer_main_t * bm, u32 bi,
+                vlib_buffer_t * b)
 {
-  vlib_buffer_main_t *bm = vm->buffer_main;
+  vlib_buffer_free_list_t *fl;
+  u32 thread_index = vlib_get_thread_index ();
+  vlib_buffer_free_list_index_t fi;
+  fl = vlib_buffer_get_buffer_free_list (vm, b, &fi);
 
-  return alloc_from_free_list
-    (vm,
-     pool_elt_at_index (bm->buffer_free_list_pool,
-                       VLIB_BUFFER_DEFAULT_FREE_LIST_INDEX),
-     buffers, n_buffers);
-}
+  /* The only current use of this callback: multicast recycle */
+  if (PREDICT_FALSE (fl->buffers_added_to_freelist_function != 0))
+    {
+      int j;
 
+      vlib_buffer_add_to_free_list (vm, fl, bi,
+                                   (b->flags & VLIB_BUFFER_RECYCLE) == 0);
 
-u32
-dpdk_buffer_alloc_from_free_list (vlib_main_t * vm,
-                                 u32 * buffers,
-                                 u32 n_buffers, u32 free_list_index)
-{
-  vlib_buffer_main_t *bm = vm->buffer_main;
-  vlib_buffer_free_list_t *f;
-  f = pool_elt_at_index (bm->buffer_free_list_pool, free_list_index);
-  return alloc_from_free_list (vm, f, buffers, n_buffers);
+      for (j = 0; j < vec_len (vm->buffer_announce_list); j++)
+       {
+         if (fl == vm->buffer_announce_list[j])
+           goto already_announced;
+       }
+      vec_add1 (vm->buffer_announce_list, fl);
+    already_announced:
+      ;
+    }
+  else
+    {
+      if (PREDICT_TRUE ((b->flags & VLIB_BUFFER_RECYCLE) == 0))
+       dpdk_rte_pktmbuf_free (vm, thread_index, b);
+    }
 }
 
 static_always_inline void
 vlib_buffer_free_inline (vlib_main_t * vm,
                         u32 * buffers, u32 n_buffers, u32 follow_buffer_next)
 {
-  vlib_buffer_main_t *bm = vm->buffer_main;
-  vlib_buffer_free_list_t *fl;
-  u32 fi;
-  int i;
+  vlib_buffer_main_t *bm = &buffer_main;
+  dpdk_buffer_main_t *dbm = &dpdk_buffer_main;
+  vlib_buffer_t *b0, *b1, *b2, *b3;
+  u32 thread_index = vlib_get_thread_index ();
+  dpdk_buffer_per_thread_data *d = vec_elt_at_index (dbm->ptd, thread_index);
+  int i = 0;
   u32 (*cb) (vlib_main_t * vm, u32 * buffers, u32 n_buffers,
             u32 follow_buffer_next);
 
@@ -335,69 +366,83 @@ vlib_buffer_free_inline (vlib_main_t * vm,
   if (!n_buffers)
     return;
 
-  for (i = 0; i < n_buffers; i++)
+  while (i + 7 < n_buffers)
     {
-      vlib_buffer_t *b;
-
-      b = vlib_get_buffer (vm, buffers[i]);
-      VLIB_BUFFER_TRACE_TRAJECTORY_INIT (b);
-      fl = vlib_buffer_get_buffer_free_list (vm, b, &fi);
+      dpdk_prefetch_buffer_by_index (vm, buffers[i + 4]);
+      dpdk_prefetch_buffer_by_index (vm, buffers[i + 5]);
+      dpdk_prefetch_buffer_by_index (vm, buffers[i + 6]);
+      dpdk_prefetch_buffer_by_index (vm, buffers[i + 7]);
+
+      b0 = vlib_get_buffer (vm, buffers[i]);
+      b1 = vlib_get_buffer (vm, buffers[i + 1]);
+      b2 = vlib_get_buffer (vm, buffers[i + 2]);
+      b3 = vlib_get_buffer (vm, buffers[i + 3]);
+
+      VLIB_BUFFER_TRACE_TRAJECTORY_INIT (b0);
+      VLIB_BUFFER_TRACE_TRAJECTORY_INIT (b1);
+      VLIB_BUFFER_TRACE_TRAJECTORY_INIT (b2);
+      VLIB_BUFFER_TRACE_TRAJECTORY_INIT (b3);
+
+      recycle_or_free (vm, bm, buffers[i], b0);
+      recycle_or_free (vm, bm, buffers[i + 1], b1);
+      recycle_or_free (vm, bm, buffers[i + 2], b2);
+      recycle_or_free (vm, bm, buffers[i + 3], b3);
 
-      /* The only current use of this callback: multicast recycle */
-      if (PREDICT_FALSE (fl->buffers_added_to_freelist_function != 0))
-       {
-         int j;
-
-         vlib_buffer_add_to_free_list
-           (vm, fl, buffers[i], (b->flags & VLIB_BUFFER_RECYCLE) == 0);
-
-         for (j = 0; j < vec_len (bm->announce_list); j++)
-           {
-             if (fl == bm->announce_list[j])
-               goto already_announced;
-           }
-         vec_add1 (bm->announce_list, fl);
-       already_announced:
-         ;
-       }
-      else
-       {
-         if (PREDICT_TRUE ((b->flags & VLIB_BUFFER_RECYCLE) == 0))
-           dpdk_rte_pktmbuf_free (vm, b);
-       }
+      i += 4;
     }
-  if (vec_len (bm->announce_list))
+  while (i < n_buffers)
+    {
+      b0 = vlib_get_buffer (vm, buffers[i]);
+      VLIB_BUFFER_TRACE_TRAJECTORY_INIT (b0);
+      recycle_or_free (vm, bm, buffers[i], b0);
+      i++;
+    }
+  if (vec_len (vm->buffer_announce_list))
     {
       vlib_buffer_free_list_t *fl;
-      for (i = 0; i < vec_len (bm->announce_list); i++)
+      for (i = 0; i < vec_len (vm->buffer_announce_list); i++)
        {
-         fl = bm->announce_list[i];
+         fl = vm->buffer_announce_list[i];
          fl->buffers_added_to_freelist_function (vm, fl);
        }
-      _vec_len (bm->announce_list) = 0;
+      _vec_len (vm->buffer_announce_list) = 0;
     }
+
+  vec_foreach_index (i, d->mbuf_pending_free_list)
+  {
+    int len = vec_len (d->mbuf_pending_free_list[i]);
+    if (len)
+      {
+       rte_mempool_put_bulk (d->mbuf_pending_free_list[i][len - 1]->pool,
+                             (void *) d->mbuf_pending_free_list[i], len);
+       vec_reset_length (d->mbuf_pending_free_list[i]);
+      }
+  }
 }
 
-static void
-dpdk_buffer_free (vlib_main_t * vm, u32 * buffers, u32 n_buffers)
+void
+CLIB_MULTIARCH_FN (dpdk_buffer_free) (vlib_main_t * vm, u32 * buffers,
+                                     u32 n_buffers)
 {
   vlib_buffer_free_inline (vm, buffers, n_buffers,     /* follow_buffer_next */
                           1);
 }
 
-static void
-dpdk_buffer_free_no_next (vlib_main_t * vm, u32 * buffers, u32 n_buffers)
+void
+CLIB_MULTIARCH_FN (dpdk_buffer_free_no_next) (vlib_main_t * vm, u32 * buffers,
+                                             u32 n_buffers)
 {
   vlib_buffer_free_inline (vm, buffers, n_buffers,     /* follow_buffer_next */
                           0);
 }
 
+#ifndef CLIB_MARCH_VARIANT
 static void
 dpdk_packet_template_init (vlib_main_t * vm,
                           void *vt,
                           void *packet_data,
                           uword n_packet_data_bytes,
-                          uword min_n_buffers_each_physmem_alloc, u8 * name)
+                          uword min_n_buffers_each_alloc, u8 * name)
 {
   vlib_packet_template_t *t = (vlib_packet_template_t *) vt;
 
@@ -409,12 +454,114 @@ dpdk_packet_template_init (vlib_main_t * vm,
   vlib_worker_thread_barrier_release (vm);
 }
 
-typedef struct
+static clib_error_t *
+scan_vfio_fd (void *arg, u8 * path_name, u8 * file_name)
 {
-  /* must be first */
-  struct rte_pktmbuf_pool_private mbp_priv;
-  vlib_physmem_region_index_t region_index;
-} dpdk_mempool_private_t;
+  dpdk_buffer_main_t *dbm = &dpdk_buffer_main;
+  linux_vfio_main_t *lvm = &vfio_main;
+  const char fn[] = "/dev/vfio/vfio";
+  char buff[sizeof (fn)] = { 0 };
+  int fd;
+  u8 *path = format (0, "%v%c", path_name, 0);
+
+  if (readlink ((char *) path, buff, sizeof (fn)) + 1 != sizeof (fn))
+    goto done;
+
+  if (strncmp (fn, buff, sizeof (fn)))
+    goto done;
+
+  fd = atoi ((char *) file_name);
+  if (fd != lvm->container_fd)
+    dbm->vfio_container_fd = fd;
+
+done:
+  vec_free (path);
+  return 0;
+}
+
+clib_error_t *
+dpdk_pool_create (vlib_main_t * vm, u8 * pool_name, u32 elt_size,
+                 u32 num_elts, u32 pool_priv_size, u16 cache_size, u8 numa,
+                 struct rte_mempool ** _mp,
+                 vlib_physmem_region_index_t * pri)
+{
+  dpdk_buffer_main_t *dbm = &dpdk_buffer_main;
+  struct rte_mempool *mp;
+  vlib_physmem_region_t *pr;
+  dpdk_mempool_private_t priv;
+  clib_error_t *error = 0;
+  u32 size, obj_size;
+  i32 ret;
+
+  obj_size = rte_mempool_calc_obj_size (elt_size, 0, 0);
+  size = rte_mempool_xmem_size (num_elts, obj_size, 21, 0);
+
+  error =
+    vlib_physmem_region_alloc (vm, (i8 *) pool_name, size, numa,
+                              VLIB_PHYSMEM_F_HUGETLB | VLIB_PHYSMEM_F_SHARED,
+                              pri);
+  if (error)
+    return error;
+
+  pr = vlib_physmem_get_region (vm, pri[0]);
+
+  mp =
+    rte_mempool_create_empty ((i8 *) pool_name, num_elts, elt_size,
+                             512, pool_priv_size, numa, 0);
+  if (!mp)
+    return clib_error_return (0, "failed to create %s", pool_name);
+
+  rte_mempool_set_ops_byname (mp, RTE_MBUF_DEFAULT_MEMPOOL_OPS, NULL);
+
+  /* Call the mempool priv initializer */
+  priv.mbp_priv.mbuf_data_room_size = VLIB_BUFFER_PRE_DATA_SIZE +
+    VLIB_BUFFER_DATA_SIZE;
+  priv.mbp_priv.mbuf_priv_size = VLIB_BUFFER_HDR_SIZE;
+  rte_pktmbuf_pool_init (mp, &priv);
+
+  ret =
+    rte_mempool_populate_iova_tab (mp, pr->mem, pr->page_table, pr->n_pages,
+                                  pr->log2_page_size, NULL, NULL);
+  if (ret != (i32) mp->size)
+    {
+      rte_mempool_free (mp);
+      return clib_error_return (0, "failed to populate %s", pool_name);
+    }
+
+  _mp[0] = mp;
+
+  /* DPDK currently doesn't provide API to map DMA memory for empty mempool
+     so we are using this hack, will be nice to have at least API to get
+     VFIO container FD */
+  if (dbm->vfio_container_fd == -1)
+    foreach_directory_file ("/proc/self/fd", scan_vfio_fd, 0, 0);
+
+  if (dbm->vfio_container_fd != -1)
+    {
+      struct vfio_iommu_type1_dma_map dm = { 0 };
+      int i, rv = 0;
+      dm.argsz = sizeof (struct vfio_iommu_type1_dma_map);
+      dm.flags = VFIO_DMA_MAP_FLAG_READ | VFIO_DMA_MAP_FLAG_WRITE;
+
+      /* *INDENT-OFF* */
+      vec_foreach_index (i, pr->page_table)
+       {
+         dm.vaddr = pointer_to_uword (pr->mem) + (i << pr->log2_page_size);
+         dm.size = 1 << pr->log2_page_size;
+         if (rte_eal_iova_mode() == RTE_IOVA_PA)
+                 dm.iova = pr->page_table[i];
+         else
+                 dm.iova = dm.vaddr;
+         if ((rv = ioctl (dbm->vfio_container_fd, VFIO_IOMMU_MAP_DMA, &dm)))
+           break;
+       }
+      /* *INDENT-ON* */
+      if (rv != 0 && errno != EINVAL)
+       clib_unix_warning ("ioctl(VFIO_IOMMU_MAP_DMA) pool '%s'", pool_name);
+    }
+
+  return 0;
+}
 
 clib_error_t *
 dpdk_buffer_pool_create (vlib_main_t * vm, unsigned num_mbufs,
@@ -422,13 +569,10 @@ dpdk_buffer_pool_create (vlib_main_t * vm, unsigned num_mbufs,
 {
   dpdk_main_t *dm = &dpdk_main;
   struct rte_mempool *rmp;
-  dpdk_mempool_private_t priv;
-  vlib_physmem_region_t *pr;
   vlib_physmem_region_index_t pri;
+  clib_error_t *error = 0;
   u8 *pool_name;
-  unsigned elt_size;
-  u32 size, obj_size;
-  i32 i, ret;
+  u32 elt_size, i;
 
   vec_validate_aligned (dm->pktmbuf_pools, socket_id, CLIB_CACHE_LINE_BYTES);
 
@@ -442,62 +586,27 @@ dpdk_buffer_pool_create (vlib_main_t * vm, unsigned num_mbufs,
     VLIB_BUFFER_HDR_SIZE /* priv size */  +
     VLIB_BUFFER_PRE_DATA_SIZE + VLIB_BUFFER_DATA_SIZE; /*data room size */
 
-  obj_size = rte_mempool_calc_obj_size (elt_size, 0, 0);
-  size = rte_mempool_xmem_size (num_mbufs, obj_size, 21);
-
-  clib_error_t *error = 0;
   error =
-    vlib_physmem_region_alloc (vm, (char *) pool_name, size, socket_id,
-                              VLIB_PHYSMEM_F_HAVE_BUFFERS, &pri);
-  if (error)
-    clib_error_report (error);
-
-  pr = vlib_physmem_get_region (vm, pri);
+    dpdk_pool_create (vm, pool_name, elt_size, num_mbufs,
+                     sizeof (dpdk_mempool_private_t), 512, socket_id,
+                     &rmp, &pri);
 
-  priv.mbp_priv.mbuf_data_room_size = VLIB_BUFFER_PRE_DATA_SIZE +
-    VLIB_BUFFER_DATA_SIZE;
-  priv.mbp_priv.mbuf_priv_size = VLIB_BUFFER_HDR_SIZE;
+  vec_free (pool_name);
 
-#if 0
-  /* Check that pg_shift parameter is valid. */
-  if (pg_shift > MEMPOOL_PG_SHIFT_MAX)
-    {
-      rte_errno = EINVAL;
-      return NULL;
-    }
-#endif
-  rmp = rte_mempool_create_empty ((char *) pool_name,  /* pool name */
-                                 num_mbufs,    /* number of mbufs */
-                                 elt_size, 512,        /* cache size */
-                                 sizeof (dpdk_mempool_private_t),      /* private data size */
-                                 socket_id, 0);        /* flags */
-  if (rmp)
+  if (!error)
     {
-      rte_mempool_set_ops_byname (rmp, RTE_MBUF_DEFAULT_MEMPOOL_OPS, NULL);
+      /* call the object initializers */
+      rte_mempool_obj_iter (rmp, rte_pktmbuf_init, 0);
 
-      /* call the mempool priv initializer */
-      rte_pktmbuf_pool_init (rmp, &priv);
+      dpdk_mempool_private_t *privp = rte_mempool_get_priv (rmp);
+      privp->buffer_pool_index = vlib_buffer_pool_create (vm, pri, 0);
 
-      ret = rte_mempool_populate_phys_tab (rmp, pr->mem, pr->page_table,
-                                          pr->n_pages, pr->log2_page_size,
-                                          NULL, NULL);
-      if (ret == (i32) rmp->size)
-       {
-         /* call the object initializers */
-         rte_mempool_obj_iter (rmp, rte_pktmbuf_init, 0);
-
-         dpdk_mempool_private_t *privp = rte_mempool_get_priv (rmp);
-         privp->region_index = pri;
-
-         dm->pktmbuf_pools[socket_id] = rmp;
+      dm->pktmbuf_pools[socket_id] = rmp;
 
-         return 0;
-       }
-
-      rte_mempool_free (rmp);
+      return 0;
     }
 
-  vec_free (pool_name);
+  clib_error_report (error);
 
   /* no usable pool for this socket, try to use pool from another one */
   for (i = 0; i < vec_len (dm->pktmbuf_pools); i++)
@@ -602,10 +711,25 @@ dpdk_buffer_poison_trajectory_all (void)
 }
 #endif
 
+static clib_error_t *
+dpdk_buffer_init (vlib_main_t * vm)
+{
+  dpdk_buffer_main_t *dbm = &dpdk_buffer_main;
+  vlib_thread_main_t *tm = vlib_get_thread_main ();
+
+  vec_validate_aligned (dbm->ptd, tm->n_vlib_mains - 1,
+                       CLIB_CACHE_LINE_BYTES);
+
+  dbm->vfio_container_fd = -1;
+
+  return 0;
+}
+
+VLIB_INIT_FUNCTION (dpdk_buffer_init);
+
 /* *INDENT-OFF* */
 VLIB_BUFFER_REGISTER_CALLBACKS (dpdk, static) = {
-  .vlib_buffer_alloc_cb = &dpdk_buffer_alloc,
-  .vlib_buffer_alloc_from_free_list_cb = &dpdk_buffer_alloc_from_free_list,
+  .vlib_buffer_fill_free_list_cb = &dpdk_buffer_fill_free_list,
   .vlib_buffer_free_cb = &dpdk_buffer_free,
   .vlib_buffer_free_no_next_cb = &dpdk_buffer_free_no_next,
   .vlib_packet_template_init_cb = &dpdk_packet_template_init,
@@ -613,6 +737,34 @@ VLIB_BUFFER_REGISTER_CALLBACKS (dpdk, static) = {
 };
 /* *INDENT-ON* */
 
+#if __x86_64__
+vlib_buffer_fill_free_list_cb_t __clib_weak dpdk_buffer_fill_free_list_avx512;
+vlib_buffer_fill_free_list_cb_t __clib_weak dpdk_buffer_fill_free_list_avx2;
+vlib_buffer_free_cb_t __clib_weak dpdk_buffer_free_avx512;
+vlib_buffer_free_cb_t __clib_weak dpdk_buffer_free_avx2;
+vlib_buffer_free_no_next_cb_t __clib_weak dpdk_buffer_free_no_next_avx512;
+vlib_buffer_free_no_next_cb_t __clib_weak dpdk_buffer_free_no_next_avx2;
+
+static void __clib_constructor
+dpdk_input_multiarch_select (void)
+{
+  vlib_buffer_callbacks_t *cb = &__dpdk_buffer_callbacks;
+  if (dpdk_buffer_fill_free_list_avx512 && clib_cpu_supports_avx512f ())
+    {
+      cb->vlib_buffer_fill_free_list_cb = dpdk_buffer_fill_free_list_avx512;
+      cb->vlib_buffer_free_cb = dpdk_buffer_free_avx512;
+      cb->vlib_buffer_free_no_next_cb = dpdk_buffer_free_no_next_avx512;
+    }
+  else if (dpdk_buffer_fill_free_list_avx2 && clib_cpu_supports_avx2 ())
+    {
+      cb->vlib_buffer_fill_free_list_cb = dpdk_buffer_fill_free_list_avx2;
+      cb->vlib_buffer_free_cb = dpdk_buffer_free_avx2;
+      cb->vlib_buffer_free_no_next_cb = dpdk_buffer_free_no_next_avx2;
+    }
+}
+#endif
+#endif
+
 /** @endcond */
 /*
  * fd.io coding-style-patch-verification: ON