dpdk: no need to copy default tx conf
[vpp.git] / src / plugins / dpdk / device / common.c
index 18d4555..f77e377 100644 (file)
 #include <vnet/vnet.h>
 #include <vppinfra/vec.h>
 #include <vppinfra/format.h>
+#include <vppinfra/file.h>
+#include <vlib/unix/unix.h>
 #include <assert.h>
 
 #include <vnet/ip/ip.h>
 #include <vnet/ethernet/ethernet.h>
 #include <vnet/ethernet/arp_packet.h>
+#include <vnet/interface/rx_queue_funcs.h>
 #include <dpdk/buffer.h>
 #include <dpdk/device/dpdk.h>
 #include <dpdk/device/dpdk_priv.h>
@@ -38,9 +41,9 @@ dpdk_device_error (dpdk_device_t * xd, char *str, int rv)
 void
 dpdk_device_setup (dpdk_device_t * xd)
 {
-  dpdk_main_t *dm = &dpdk_main;
   vlib_main_t *vm = vlib_get_main ();
   vnet_main_t *vnm = vnet_get_main ();
+  vlib_thread_main_t *tm = vlib_get_thread_main ();
   vnet_sw_interface_t *sw = vnet_get_sw_interface (vnm, xd->sw_if_index);
   vnet_hw_interface_t *hi = vnet_get_hw_interface (vnm, xd->hw_if_index);
   struct rte_eth_dev_info dev_info;
@@ -55,7 +58,7 @@ dpdk_device_setup (dpdk_device_t * xd)
 
   if (xd->flags & DPDK_DEVICE_FLAG_ADMIN_UP)
     {
-      vnet_hw_interface_set_flags (dm->vnet_main, xd->hw_if_index, 0);
+      vnet_hw_interface_set_flags (vnm, xd->hw_if_index, 0);
       dpdk_device_stop (xd);
     }
 
@@ -86,8 +89,8 @@ dpdk_device_setup (dpdk_device_t * xd)
       xd->port_conf.rxmode.offloads ^= bitmap;
     }
 
-  rv = rte_eth_dev_configure (xd->port_id, xd->rx_q_used,
-                             xd->tx_q_used, &xd->port_conf);
+  rv = rte_eth_dev_configure (xd->port_id, xd->conf.n_rx_queues,
+                             xd->conf.n_tx_queues, &xd->port_conf);
 
   if (rv < 0)
     {
@@ -95,42 +98,41 @@ dpdk_device_setup (dpdk_device_t * xd)
       goto error;
     }
 
-  /* Set up one TX-queue per worker thread */
-  for (j = 0; j < xd->tx_q_used; j++)
+  vec_validate_aligned (xd->tx_queues, xd->conf.n_tx_queues - 1,
+                       CLIB_CACHE_LINE_BYTES);
+  for (j = 0; j < xd->conf.n_tx_queues; j++)
     {
-      rv =
-       rte_eth_tx_queue_setup (xd->port_id, j, xd->nb_tx_desc,
-                               xd->cpu_socket, &xd->tx_conf);
+      rv = rte_eth_tx_queue_setup (xd->port_id, j, xd->conf.n_tx_desc,
+                                  xd->cpu_socket, 0);
 
       /* retry with any other CPU socket */
       if (rv < 0)
-       rv =
-         rte_eth_tx_queue_setup (xd->port_id, j,
-                                 xd->nb_tx_desc, SOCKET_ID_ANY,
-                                 &xd->tx_conf);
+       rv = rte_eth_tx_queue_setup (xd->port_id, j, xd->conf.n_tx_desc,
+                                    SOCKET_ID_ANY, 0);
       if (rv < 0)
        dpdk_device_error (xd, "rte_eth_tx_queue_setup", rv);
+
+      if (xd->conf.n_tx_queues < tm->n_vlib_mains)
+       clib_spinlock_init (&vec_elt (xd->tx_queues, j).lock);
     }
 
-  vec_validate_aligned (xd->rx_queues, xd->rx_q_used - 1,
+  vec_validate_aligned (xd->rx_queues, xd->conf.n_rx_queues - 1,
                        CLIB_CACHE_LINE_BYTES);
-  for (j = 0; j < xd->rx_q_used; j++)
+
+  for (j = 0; j < xd->conf.n_rx_queues; j++)
     {
       dpdk_rx_queue_t *rxq = vec_elt_at_index (xd->rx_queues, j);
-      uword tidx = vnet_get_device_input_thread_index (dm->vnet_main,
-                                                      xd->hw_if_index, j);
-      unsigned lcore = vlib_worker_threads[tidx].cpu_id;
-      u16 socket_id = rte_lcore_to_socket_id (lcore);
-      u8 bpidx = vlib_buffer_pool_get_default_for_numa (vm, socket_id);
+      u8 bpidx = vlib_buffer_pool_get_default_for_numa (
+       vm, vnet_hw_if_get_rx_queue_numa_node (vnm, rxq->queue_index));
       vlib_buffer_pool_t *bp = vlib_get_buffer_pool (vm, bpidx);
       struct rte_mempool *mp = dpdk_mempool_by_buffer_pool_index[bpidx];
 
-      rv = rte_eth_rx_queue_setup (xd->port_id, j, xd->nb_rx_desc,
+      rv = rte_eth_rx_queue_setup (xd->port_id, j, xd->conf.n_rx_desc,
                                   xd->cpu_socket, 0, mp);
 
       /* retry with any other CPU socket */
       if (rv < 0)
-       rv = rte_eth_rx_queue_setup (xd->port_id, j, xd->nb_rx_desc,
+       rv = rte_eth_rx_queue_setup (xd->port_id, j, xd->conf.n_rx_desc,
                                     SOCKET_ID_ANY, 0, mp);
 
       rxq->buffer_pool_index = bp->index;
@@ -143,6 +145,14 @@ dpdk_device_setup (dpdk_device_t * xd)
     goto error;
 
   rte_eth_dev_set_mtu (xd->port_id, hi->max_packet_bytes);
+  xd->buffer_flags =
+    (VLIB_BUFFER_TOTAL_LENGTH_VALID | VLIB_BUFFER_EXT_HDR_VALID);
+
+  if ((xd->port_conf.rxmode.offloads &
+       (DEV_RX_OFFLOAD_TCP_CKSUM | DEV_RX_OFFLOAD_UDP_CKSUM)) ==
+      (DEV_RX_OFFLOAD_TCP_CKSUM | DEV_RX_OFFLOAD_UDP_CKSUM))
+    xd->buffer_flags |=
+      (VNET_BUFFER_F_L4_CHECKSUM_COMPUTED | VNET_BUFFER_F_L4_CHECKSUM_CORRECT);
 
   if (xd->flags & DPDK_DEVICE_FLAG_ADMIN_UP)
     dpdk_device_start (xd);
@@ -157,6 +167,87 @@ error:
   sw->flags |= VNET_SW_INTERFACE_FLAG_ERROR;
 }
 
+static clib_error_t *
+dpdk_rx_read_ready (clib_file_t *uf)
+{
+  vnet_main_t *vnm = vnet_get_main ();
+  dpdk_main_t *dm = &dpdk_main;
+  u32 qidx = uf->private_data;
+  vnet_hw_if_rx_queue_t *rxq = vnet_hw_if_get_rx_queue (vnm, qidx);
+  dpdk_device_t *xd = vec_elt_at_index (dm->devices, rxq->dev_instance);
+
+  u64 b;
+  CLIB_UNUSED (ssize_t size) = read (uf->file_descriptor, &b, sizeof (b));
+  if (rxq->mode != VNET_HW_IF_RX_MODE_POLLING)
+    {
+      vnet_hw_if_rx_queue_set_int_pending (vnm, uf->private_data);
+      rte_eth_dev_rx_intr_enable (xd->port_id, rxq->queue_id);
+    }
+
+  return 0;
+}
+
+static void
+dpdk_setup_interrupts (dpdk_device_t *xd)
+{
+  vnet_main_t *vnm = vnet_get_main ();
+  vnet_hw_interface_t *hi = vnet_get_hw_interface (vnm, xd->hw_if_index);
+  if (!hi)
+    return;
+
+  if (!xd->port_conf.intr_conf.rxq)
+    return;
+
+  /* Probe for interrupt support */
+  if (rte_eth_dev_rx_intr_enable (xd->port_id, 0))
+    {
+      dpdk_log_info ("probe for interrupt mode for device %U. Failed.\n",
+                    format_dpdk_device_name, xd->port_id);
+    }
+  else
+    {
+      xd->flags |= DPDK_DEVICE_FLAG_INT_SUPPORTED;
+      if (!(xd->flags & DPDK_DEVICE_FLAG_INT_UNMASKABLE))
+       rte_eth_dev_rx_intr_disable (xd->port_id, 0);
+      dpdk_log_info ("Probe for interrupt mode for device %U. Success.\n",
+                    format_dpdk_device_name, xd->port_id);
+    }
+
+  if (xd->flags & DPDK_DEVICE_FLAG_INT_SUPPORTED)
+    {
+      hi->caps |= VNET_HW_IF_CAP_INT_MODE;
+      for (int q = 0; q < xd->conf.n_rx_queues; q++)
+       {
+         dpdk_rx_queue_t *rxq = vec_elt_at_index (xd->rx_queues, q);
+         clib_file_t f = { 0 };
+         rxq->efd = rte_eth_dev_rx_intr_ctl_q_get_fd (xd->port_id, q);
+         if (rxq->efd < 0)
+           {
+             xd->flags &= ~DPDK_DEVICE_FLAG_INT_SUPPORTED;
+             hi->caps &= ~VNET_HW_IF_CAP_INT_MODE;
+             break;
+           }
+         f.read_function = dpdk_rx_read_ready;
+         f.flags = UNIX_FILE_EVENT_EDGE_TRIGGERED;
+         f.file_descriptor = rxq->efd;
+         f.private_data = rxq->queue_index;
+         f.description =
+           format (0, "%U queue %u", format_dpdk_device_name, xd->port_id, q);
+         rxq->clib_file_index = clib_file_add (&file_main, &f);
+         vnet_hw_if_set_rx_queue_file_index (vnm, rxq->queue_index,
+                                             rxq->clib_file_index);
+         if (xd->flags & DPDK_DEVICE_FLAG_INT_UNMASKABLE)
+           {
+             clib_file_main_t *fm = &file_main;
+             clib_file_t *f =
+               pool_elt_at_index (fm->file_pool, rxq->clib_file_index);
+             fm->file_update (f, UNIX_FILE_UPDATE_DELETE);
+           }
+       }
+    }
+  vnet_hw_if_update_runtime_data (vnm, xd->hw_if_index);
+}
+
 void
 dpdk_device_start (dpdk_device_t * xd)
 {
@@ -173,6 +264,8 @@ dpdk_device_start (dpdk_device_t * xd)
       return;
     }
 
+  dpdk_setup_interrupts (xd);
+
   if (xd->default_mac_address)
     rv = rte_eth_dev_default_mac_addr_set (xd->port_id,
                                           (void *) xd->default_mac_address);
@@ -255,6 +348,19 @@ dpdk_get_pci_device (const struct rte_eth_dev_info *info)
     return NULL;
 }
 
+/* If this device is VMBUS return pointer to info, otherwise NULL */
+struct rte_vmbus_device *
+dpdk_get_vmbus_device (const struct rte_eth_dev_info *info)
+{
+  const struct rte_bus *bus;
+
+  bus = rte_bus_find_by_device (info->device);
+  if (bus && !strcmp (bus->name, "vmbus"))
+    return container_of (info->device, struct rte_vmbus_device, device);
+  else
+    return NULL;
+}
+
 /*
  * fd.io coding-style-patch-verification: ON
  *