dpdk: allow configure individual VMBUS devices
[vpp.git] / src / plugins / dpdk / device / init.c
old mode 100755 (executable)
new mode 100644 (file)
index e009ef3..f3d228c
 #include <vppinfra/error.h>
 #include <vppinfra/format.h>
 #include <vppinfra/bitmap.h>
+#include <vppinfra/linux/sysfs.h>
+#include <vlib/unix/unix.h>
+#include <vlib/log.h>
 
 #include <vnet/ethernet/ethernet.h>
+#include <dpdk/buffer.h>
 #include <dpdk/device/dpdk.h>
-#include <vlib/unix/physmem.h>
+#include <dpdk/cryptodev/cryptodev.h>
 #include <vlib/pci/pci.h>
+#include <vlib/vmbus/vmbus.h>
+
+#include <rte_ring.h>
 
 #include <stdio.h>
 #include <stdlib.h>
 #include <sys/mount.h>
 #include <string.h>
 #include <fcntl.h>
+#include <dirent.h>
 
 #include <dpdk/device/dpdk_priv.h>
 
-dpdk_main_t dpdk_main;
-
-#include <vlibapi/api.h>
-#include <vlibmemory/api.h>
-
-/* define message IDs */
-#include <dpdk/api/dpdk_msg_enum.h>
-
-#define vl_typedefs            /* define message structures */
-#include <dpdk/api/dpdk_all_api_h.h>
-#undef vl_typedefs
-
-#define vl_endianfun           /* define message structures */
-#include <dpdk/api/dpdk_all_api_h.h>
-#undef vl_endianfun
-
-#define vl_print(handle, ...) vlib_cli_output (handle, __VA_ARGS__)
-
-/* Get the API version number. */
-#define vl_api_version(n,v) static u32 api_version=(v);
-#include <dpdk/api/dpdk_all_api_h.h>
-#undef vl_api_version
-
-/* Macro to finish up custom dump fns */
-#define FINISH                                  \
-    vec_add1 (s, 0);                            \
-    vl_print (handle, (char *)s);               \
-    vec_free (s);                               \
-    return handle;
-
-#include <vlibapi/api_helper_macros.h>
-
-static void
-  vl_api_sw_interface_set_dpdk_hqos_pipe_t_handler
-  (vl_api_sw_interface_set_dpdk_hqos_pipe_t * mp)
-{
-  vl_api_sw_interface_set_dpdk_hqos_pipe_reply_t *rmp;
-  int rv = 0;
-
-  dpdk_main_t *dm = &dpdk_main;
-  dpdk_device_t *xd;
-
-  u32 sw_if_index = ntohl (mp->sw_if_index);
-  u32 subport = ntohl (mp->subport);
-  u32 pipe = ntohl (mp->pipe);
-  u32 profile = ntohl (mp->profile);
-  vnet_hw_interface_t *hw;
-
-  VALIDATE_SW_IF_INDEX (mp);
-
-  /* hw_if & dpdk device */
-  hw = vnet_get_sup_hw_interface (dm->vnet_main, sw_if_index);
-
-  xd = vec_elt_at_index (dm->devices, hw->dev_instance);
-
-  rv = rte_sched_pipe_config (xd->hqos_ht->hqos, subport, pipe, profile);
+#define ETHER_MAX_LEN   1518  /**< Maximum frame len, including CRC. */
 
-  BAD_SW_IF_INDEX_LABEL;
-
-  REPLY_MACRO (VL_API_SW_INTERFACE_SET_DPDK_HQOS_PIPE_REPLY);
-}
-
-static void *vl_api_sw_interface_set_dpdk_hqos_pipe_t_print
-  (vl_api_sw_interface_set_dpdk_hqos_pipe_t * mp, void *handle)
-{
-  u8 *s;
-
-  s = format (0, "SCRIPT: sw_interface_set_dpdk_hqos_pipe ");
-
-  s = format (s, "sw_if_index %u ", ntohl (mp->sw_if_index));
+dpdk_main_t dpdk_main;
+dpdk_config_main_t dpdk_config_main;
 
-  s = format (s, "subport %u  pipe %u  profile %u ",
-             ntohl (mp->subport), ntohl (mp->pipe), ntohl (mp->profile));
+#define LINK_STATE_ELOGS       0
 
-  FINISH;
-}
+/* Port configuration, mildly modified Intel app values */
 
-static void
-  vl_api_sw_interface_set_dpdk_hqos_subport_t_handler
-  (vl_api_sw_interface_set_dpdk_hqos_subport_t * mp)
+static dpdk_port_type_t
+port_type_from_speed_capa (struct rte_eth_dev_info *dev_info)
 {
-  vl_api_sw_interface_set_dpdk_hqos_subport_reply_t *rmp;
-  int rv = 0;
-
-  dpdk_main_t *dm = &dpdk_main;
-  dpdk_device_t *xd;
-  struct rte_sched_subport_params p;
-
-  u32 sw_if_index = ntohl (mp->sw_if_index);
-  u32 subport = ntohl (mp->subport);
-  p.tb_rate = ntohl (mp->tb_rate);
-  p.tb_size = ntohl (mp->tb_size);
-  p.tc_rate[0] = ntohl (mp->tc_rate[0]);
-  p.tc_rate[1] = ntohl (mp->tc_rate[1]);
-  p.tc_rate[2] = ntohl (mp->tc_rate[2]);
-  p.tc_rate[3] = ntohl (mp->tc_rate[3]);
-  p.tc_period = ntohl (mp->tc_period);
-
-  vnet_hw_interface_t *hw;
-
-  VALIDATE_SW_IF_INDEX (mp);
-
-  /* hw_if & dpdk device */
-  hw = vnet_get_sup_hw_interface (dm->vnet_main, sw_if_index);
-
-  xd = vec_elt_at_index (dm->devices, hw->dev_instance);
-
-  rv = rte_sched_subport_config (xd->hqos_ht->hqos, subport, &p);
-
-  BAD_SW_IF_INDEX_LABEL;
 
-  REPLY_MACRO (VL_API_SW_INTERFACE_SET_DPDK_HQOS_SUBPORT_REPLY);
+  if (dev_info->speed_capa & ETH_LINK_SPEED_100G)
+    return VNET_DPDK_PORT_TYPE_ETH_100G;
+  else if (dev_info->speed_capa & ETH_LINK_SPEED_56G)
+    return VNET_DPDK_PORT_TYPE_ETH_56G;
+  else if (dev_info->speed_capa & ETH_LINK_SPEED_50G)
+    return VNET_DPDK_PORT_TYPE_ETH_50G;
+  else if (dev_info->speed_capa & ETH_LINK_SPEED_40G)
+    return VNET_DPDK_PORT_TYPE_ETH_40G;
+  else if (dev_info->speed_capa & ETH_LINK_SPEED_25G)
+    return VNET_DPDK_PORT_TYPE_ETH_25G;
+  else if (dev_info->speed_capa & ETH_LINK_SPEED_20G)
+    return VNET_DPDK_PORT_TYPE_ETH_20G;
+  else if (dev_info->speed_capa & ETH_LINK_SPEED_10G)
+    return VNET_DPDK_PORT_TYPE_ETH_10G;
+  else if (dev_info->speed_capa & ETH_LINK_SPEED_5G)
+    return VNET_DPDK_PORT_TYPE_ETH_5G;
+  else if (dev_info->speed_capa & ETH_LINK_SPEED_2_5G)
+    return VNET_DPDK_PORT_TYPE_ETH_2_5G;
+  else if (dev_info->speed_capa & ETH_LINK_SPEED_1G)
+    return VNET_DPDK_PORT_TYPE_ETH_1G;
+
+  return VNET_DPDK_PORT_TYPE_UNKNOWN;
 }
 
-static void *vl_api_sw_interface_set_dpdk_hqos_subport_t_print
-  (vl_api_sw_interface_set_dpdk_hqos_subport_t * mp, void *handle)
+static dpdk_port_type_t
+port_type_from_link_speed (u32 link_speed)
 {
-  u8 *s;
-
-  s = format (0, "SCRIPT: sw_interface_set_dpdk_hqos_subport ");
-
-  s = format (s, "sw_if_index %u ", ntohl (mp->sw_if_index));
-
-  s =
-    format (s,
-           "subport %u  rate %u  bkt_size %u  tc0 %u tc1 %u tc2 %u tc3 %u period %u",
-           ntohl (mp->subport), ntohl (mp->tb_rate), ntohl (mp->tb_size),
-           ntohl (mp->tc_rate[0]), ntohl (mp->tc_rate[1]),
-           ntohl (mp->tc_rate[2]), ntohl (mp->tc_rate[3]),
-           ntohl (mp->tc_period));
-
-  FINISH;
+  switch (link_speed)
+    {
+    case ETH_SPEED_NUM_1G:
+      return VNET_DPDK_PORT_TYPE_ETH_1G;
+    case ETH_SPEED_NUM_2_5G:
+      return VNET_DPDK_PORT_TYPE_ETH_2_5G;
+    case ETH_SPEED_NUM_5G:
+      return VNET_DPDK_PORT_TYPE_ETH_5G;
+    case ETH_SPEED_NUM_10G:
+      return VNET_DPDK_PORT_TYPE_ETH_10G;
+    case ETH_SPEED_NUM_20G:
+      return VNET_DPDK_PORT_TYPE_ETH_20G;
+    case ETH_SPEED_NUM_25G:
+      return VNET_DPDK_PORT_TYPE_ETH_25G;
+    case ETH_SPEED_NUM_40G:
+      return VNET_DPDK_PORT_TYPE_ETH_40G;
+    case ETH_SPEED_NUM_50G:
+      return VNET_DPDK_PORT_TYPE_ETH_50G;
+    case ETH_SPEED_NUM_56G:
+      return VNET_DPDK_PORT_TYPE_ETH_56G;
+    case ETH_SPEED_NUM_100G:
+      return VNET_DPDK_PORT_TYPE_ETH_100G;
+    default:
+      return VNET_DPDK_PORT_TYPE_UNKNOWN;
+    }
 }
 
-static void
-  vl_api_sw_interface_set_dpdk_hqos_tctbl_t_handler
-  (vl_api_sw_interface_set_dpdk_hqos_tctbl_t * mp)
+static u32
+dpdk_flag_change (vnet_main_t * vnm, vnet_hw_interface_t * hi, u32 flags)
 {
-  vl_api_sw_interface_set_dpdk_hqos_tctbl_reply_t *rmp;
-  int rv = 0;
-
   dpdk_main_t *dm = &dpdk_main;
-  vlib_thread_main_t *tm = vlib_get_thread_main ();
-  dpdk_device_t *xd;
-
-  u32 sw_if_index = ntohl (mp->sw_if_index);
-  u32 entry = ntohl (mp->entry);
-  u32 tc = ntohl (mp->tc);
-  u32 queue = ntohl (mp->queue);
-  u32 val, i;
-
-  vnet_hw_interface_t *hw;
-
-  VALIDATE_SW_IF_INDEX (mp);
-
-  /* hw_if & dpdk device */
-  hw = vnet_get_sup_hw_interface (dm->vnet_main, sw_if_index);
-
-  xd = vec_elt_at_index (dm->devices, hw->dev_instance);
+  dpdk_device_t *xd = vec_elt_at_index (dm->devices, hi->dev_instance);
+  u32 old = (xd->flags & DPDK_DEVICE_FLAG_PROMISC) != 0;
 
-  if (tc >= RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE)
-    {
-      clib_warning ("invalid traffic class !!");
-      rv = VNET_API_ERROR_INVALID_VALUE;
-      goto done;
-    }
-  if (queue >= RTE_SCHED_QUEUES_PER_TRAFFIC_CLASS)
+  switch (flags)
     {
-      clib_warning ("invalid queue !!");
-      rv = VNET_API_ERROR_INVALID_VALUE;
-      goto done;
+    case ETHERNET_INTERFACE_FLAG_DEFAULT_L3:
+      /* set to L3/non-promisc mode */
+      xd->flags &= ~DPDK_DEVICE_FLAG_PROMISC;
+      break;
+    case ETHERNET_INTERFACE_FLAG_ACCEPT_ALL:
+      xd->flags |= DPDK_DEVICE_FLAG_PROMISC;
+      break;
+    case ETHERNET_INTERFACE_FLAG_MTU:
+      xd->port_conf.rxmode.max_rx_pkt_len = hi->max_packet_bytes;
+      dpdk_device_setup (xd);
+      return 0;
+    default:
+      return ~0;
     }
 
-  /* Detect the set of worker threads */
-  uword *p = hash_get_mem (tm->thread_registrations_by_name, "workers");
-
-  if (p == 0)
+  if (xd->flags & DPDK_DEVICE_FLAG_ADMIN_UP)
     {
-      clib_warning ("worker thread registration AWOL !!");
-      rv = VNET_API_ERROR_INVALID_VALUE_2;
-      goto done;
+      if (xd->flags & DPDK_DEVICE_FLAG_PROMISC)
+       rte_eth_promiscuous_enable (xd->port_id);
+      else
+       rte_eth_promiscuous_disable (xd->port_id);
     }
 
-  vlib_thread_registration_t *tr = (vlib_thread_registration_t *) p[0];
-  int worker_thread_first = tr->first_index;
-  int worker_thread_count = tr->count;
-
-  val = tc * RTE_SCHED_QUEUES_PER_TRAFFIC_CLASS + queue;
-  for (i = 0; i < worker_thread_count; i++)
-    xd->hqos_wt[worker_thread_first + i].hqos_tc_table[entry] = val;
-
-  BAD_SW_IF_INDEX_LABEL;
-done:
-
-  REPLY_MACRO (VL_API_SW_INTERFACE_SET_DPDK_HQOS_TCTBL_REPLY);
-}
-
-static void *vl_api_sw_interface_set_dpdk_hqos_tctbl_t_print
-  (vl_api_sw_interface_set_dpdk_hqos_tctbl_t * mp, void *handle)
-{
-  u8 *s;
-
-  s = format (0, "SCRIPT: sw_interface_set_dpdk_hqos_tctbl ");
-
-  s = format (s, "sw_if_index %u ", ntohl (mp->sw_if_index));
-
-  s = format (s, "entry %u  tc %u  queue %u",
-             ntohl (mp->entry), ntohl (mp->tc), ntohl (mp->queue));
-
-  FINISH;
-}
-
-#define foreach_dpdk_plugin_api_msg                                       \
-_(SW_INTERFACE_SET_DPDK_HQOS_PIPE, sw_interface_set_dpdk_hqos_pipe)       \
-_(SW_INTERFACE_SET_DPDK_HQOS_SUBPORT, sw_interface_set_dpdk_hqos_subport) \
-_(SW_INTERFACE_SET_DPDK_HQOS_TCTBL, sw_interface_set_dpdk_hqos_tctbl)
-
-/* Set up the API message handling tables */
-static clib_error_t *
-dpdk_plugin_api_hookup (vlib_main_t * vm)
-{
-  dpdk_main_t *dm __attribute__ ((unused)) = &dpdk_main;
-#define _(N,n)                                                  \
-    vl_msg_api_set_handlers((VL_API_##N + dm->msg_id_base),     \
-                           #n,          \
-                           vl_api_##n##_t_handler,              \
-                           vl_noop_handler,                     \
-                           vl_api_##n##_t_endian,               \
-                           vl_api_##n##_t_print,                \
-                           sizeof(vl_api_##n##_t), 1);
-  foreach_dpdk_plugin_api_msg;
-#undef _
-  return 0;
+  return old;
 }
 
-#define vl_msg_name_crc_list
-#include <dpdk/api/dpdk_all_api_h.h>
-#undef vl_msg_name_crc_list
-
-static void
-setup_message_id_table (dpdk_main_t * dm, api_main_t * am)
+static int
+dpdk_port_crc_strip_enabled (dpdk_device_t * xd)
 {
-#define _(id,n,crc) \
-  vl_msg_api_add_msg_name_crc (am, #n "_" #crc, id + dm->msg_id_base);
-  foreach_vl_msg_name_crc_dpdk;
-#undef _
+  return !(xd->port_conf.rxmode.offloads & DEV_RX_OFFLOAD_KEEP_CRC);
 }
 
-//  TODO
-/*
-static void plugin_custom_dump_configure (dpdk_main_t * dm)
-{
-#define _(n,f) dm->api_main->msg_print_handlers \
-  [VL_API_##n + dm->msg_id_base]                \
-    = (void *) vl_api_##f##_t_print;
-  foreach_dpdk_plugin_api_msg;
-#undef _
-}
+/* The function check_l3cache helps check if Level 3 cache exists or not on current CPUs
+  return value 1: exist.
+  return value 0: not exist.
 */
-/* force linker to link functions used by vlib and declared weak */
-void *vlib_weakly_linked_functions[] = {
-  &rte_pktmbuf_init,
-  &rte_pktmbuf_pool_init,
-};
-
-#define LINK_STATE_ELOGS       0
-
-#define DEFAULT_HUGE_DIR "/run/vpp/hugepages"
-#define VPP_RUN_DIR "/run/vpp"
-
-/* Port configuration, mildly modified Intel app values */
-
-static struct rte_eth_conf port_conf_template = {
-  .rxmode = {
-            .split_hdr_size = 0,
-            .header_split = 0,         /**< Header Split disabled */
-            .hw_ip_checksum = 0,       /**< IP checksum offload disabled */
-            .hw_vlan_filter = 0,       /**< VLAN filtering disabled */
-            .hw_strip_crc = 0,         /**< CRC stripped by hardware */
-            },
-  .txmode = {
-            .mq_mode = ETH_MQ_TX_NONE,
-            },
-};
-
-clib_error_t *
-dpdk_port_setup (dpdk_main_t * dm, dpdk_device_t * xd)
+static int
+check_l3cache ()
 {
-  int rv;
-  int j;
 
-  ASSERT (os_get_cpu_number () == 0);
-
-  if (xd->flags & DPDK_DEVICE_FLAG_ADMIN_UP)
-    {
-      vnet_hw_interface_set_flags (dm->vnet_main, xd->vlib_hw_if_index, 0);
-      rte_eth_dev_stop (xd->device_index);
-    }
-
-  rv = rte_eth_dev_configure (xd->device_index, xd->rx_q_used,
-                             xd->tx_q_used, &xd->port_conf);
-
-  if (rv < 0)
-    return clib_error_return (0, "rte_eth_dev_configure[%d]: err %d",
-                             xd->device_index, rv);
-
-  /* Set up one TX-queue per worker thread */
-  for (j = 0; j < xd->tx_q_used; j++)
-    {
-      rv = rte_eth_tx_queue_setup (xd->device_index, j, xd->nb_tx_desc,
-                                  xd->cpu_socket, &xd->tx_conf);
-
-      /* retry with any other CPU socket */
-      if (rv < 0)
-       rv = rte_eth_tx_queue_setup (xd->device_index, j, xd->nb_tx_desc,
-                                    SOCKET_ID_ANY, &xd->tx_conf);
-      if (rv < 0)
-       break;
-    }
+  struct dirent *dp;
+  clib_error_t *err;
+  const char *sys_cache_dir = "/sys/devices/system/cpu/cpu0/cache";
+  DIR *dir_cache = opendir (sys_cache_dir);
 
-  if (rv < 0)
-    return clib_error_return (0, "rte_eth_tx_queue_setup[%d]: err %d",
-                             xd->device_index, rv);
+  if (dir_cache == NULL)
+    return -1;
 
-  for (j = 0; j < xd->rx_q_used; j++)
+  while ((dp = readdir (dir_cache)) != NULL)
     {
-
-      rv = rte_eth_rx_queue_setup (xd->device_index, j, xd->nb_rx_desc,
-                                  xd->cpu_socket, 0,
-                                  dm->
-                                  pktmbuf_pools[xd->cpu_socket_id_by_queue
-                                                [j]]);
-
-      /* retry with any other CPU socket */
-      if (rv < 0)
-       rv = rte_eth_rx_queue_setup (xd->device_index, j, xd->nb_rx_desc,
-                                    SOCKET_ID_ANY, 0,
-                                    dm->
-                                    pktmbuf_pools[xd->cpu_socket_id_by_queue
-                                                  [j]]);
-      if (rv < 0)
-       return clib_error_return (0, "rte_eth_rx_queue_setup[%d]: err %d",
-                                 xd->device_index, rv);
-    }
-
-  if (xd->flags & DPDK_DEVICE_FLAG_ADMIN_UP)
-    {
-      int rv;
-      rv = rte_eth_dev_start (xd->device_index);
-      if (!rv && xd->default_mac_address)
-       rv = rte_eth_dev_default_mac_addr_set (xd->device_index,
-                                              (struct ether_addr *)
-                                              xd->default_mac_address);
-      if (rv < 0)
-       clib_warning ("rte_eth_dev_start %d returned %d",
-                     xd->device_index, rv);
-    }
-  return 0;
-}
-
-static u32
-dpdk_flag_change (vnet_main_t * vnm, vnet_hw_interface_t * hi, u32 flags)
-{
-  dpdk_main_t *dm = &dpdk_main;
-  dpdk_device_t *xd = vec_elt_at_index (dm->devices, hi->dev_instance);
-  u32 old = 0;
-
-  if (ETHERNET_INTERFACE_FLAG_CONFIG_PROMISC (flags))
-    {
-      old = (xd->flags & DPDK_DEVICE_FLAG_PROMISC) != 0;
-
-      if (flags & ETHERNET_INTERFACE_FLAG_ACCEPT_ALL)
-       xd->flags |= DPDK_DEVICE_FLAG_PROMISC;
-      else
-       xd->flags &= ~DPDK_DEVICE_FLAG_PROMISC;
-
-      if (xd->flags & DPDK_DEVICE_FLAG_ADMIN_UP)
-       {
-         if (xd->flags & DPDK_DEVICE_FLAG_PROMISC)
-           rte_eth_promiscuous_enable (xd->device_index);
-         else
-           rte_eth_promiscuous_disable (xd->device_index);
-       }
-    }
-  else if (ETHERNET_INTERFACE_FLAG_CONFIG_MTU (flags))
-    {
-      /*
-       * DAW-FIXME: The Cisco VIC firmware does not provide an api for a
-       *            driver to dynamically change the mtu.  If/when the
-       *            VIC firmware gets fixed, then this should be removed.
-       */
-      if (xd->pmd == VNET_DPDK_PMD_ENIC)
-       {
-         struct rte_eth_dev_info dev_info;
-
-         /*
-          * Restore mtu to what has been set by CIMC in the firmware cfg.
-          */
-         rte_eth_dev_info_get (xd->device_index, &dev_info);
-         hi->max_packet_bytes = dev_info.max_rx_pktlen;
-
-         vlib_cli_output (vlib_get_main (),
-                          "Cisco VIC mtu can only be changed "
-                          "using CIMC then rebooting the server!");
-       }
-      else
+      if (dp->d_type == DT_DIR)
        {
-         int rv;
-
-         xd->port_conf.rxmode.max_rx_pkt_len = hi->max_packet_bytes;
+         u8 *p = NULL;
+         int level_cache = -1;
 
-         if (xd->flags & DPDK_DEVICE_FLAG_ADMIN_UP)
-           rte_eth_dev_stop (xd->device_index);
+         p = format (p, "%s/%s/%s%c", sys_cache_dir, dp->d_name, "level", 0);
+         if ((err = clib_sysfs_read ((char *) p, "%d", &level_cache)))
+           clib_error_free (err);
 
-         rv = rte_eth_dev_configure
-           (xd->device_index, xd->rx_q_used, xd->tx_q_used, &xd->port_conf);
-
-         if (rv < 0)
-           vlib_cli_output (vlib_get_main (),
-                            "rte_eth_dev_configure[%d]: err %d",
-                            xd->device_index, rv);
-
-         rte_eth_dev_set_mtu (xd->device_index, hi->max_packet_bytes);
-
-         if (xd->flags & DPDK_DEVICE_FLAG_ADMIN_UP)
+         if (level_cache == 3)
            {
-             int rv = rte_eth_dev_start (xd->device_index);
-             if (!rv && xd->default_mac_address)
-               rv = rte_eth_dev_default_mac_addr_set (xd->device_index,
-                                                      (struct ether_addr *)
-                                                      xd->default_mac_address);
-             if (rv < 0)
-               clib_warning ("rte_eth_dev_start %d returned %d",
-                             xd->device_index, rv);
+             closedir (dir_cache);
+             return 1;
            }
        }
     }
-  return old;
-}
 
-void
-dpdk_device_lock_init (dpdk_device_t * xd)
-{
-  int q;
-  vec_validate (xd->lockp, xd->tx_q_used - 1);
-  for (q = 0; q < xd->tx_q_used; q++)
-    {
-      xd->lockp[q] = clib_mem_alloc_aligned (CLIB_CACHE_LINE_BYTES,
-                                            CLIB_CACHE_LINE_BYTES);
-      memset ((void *) xd->lockp[q], 0, CLIB_CACHE_LINE_BYTES);
-    }
+  if (dir_cache != NULL)
+    closedir (dir_cache);
+
+  return 0;
 }
 
-void
-dpdk_device_lock_free (dpdk_device_t * xd)
+static void
+dpdk_enable_l4_csum_offload (dpdk_device_t * xd)
 {
-  int q;
-
-  for (q = 0; q < vec_len (xd->lockp); q++)
-    clib_mem_free ((void *) xd->lockp[q]);
-  vec_free (xd->lockp);
-  xd->lockp = 0;
+  xd->port_conf.txmode.offloads |= DEV_TX_OFFLOAD_TCP_CKSUM;
+  xd->port_conf.txmode.offloads |= DEV_TX_OFFLOAD_UDP_CKSUM;
+  xd->flags |= DPDK_DEVICE_FLAG_TX_OFFLOAD |
+    DPDK_DEVICE_FLAG_INTEL_PHDR_CKSUM;
 }
 
 static clib_error_t *
 dpdk_lib_init (dpdk_main_t * dm)
 {
   u32 nports;
-  u32 nb_desc = 0;
+  u32 mtu, max_rx_frame;
   int i;
   clib_error_t *error;
   vlib_main_t *vm = vlib_get_main ();
   vlib_thread_main_t *tm = vlib_get_thread_main ();
+  vnet_device_main_t *vdm = &vnet_device_main;
   vnet_sw_interface_t *sw;
   vnet_hw_interface_t *hi;
   dpdk_device_t *xd;
   vlib_pci_addr_t last_pci_addr;
   u32 last_pci_addr_port = 0;
-  vlib_thread_registration_t *tr, *tr_hqos;
-  uword *p, *p_hqos;
-
-  u32 next_cpu = 0, next_hqos_cpu = 0;
-  u8 af_packet_port_id = 0;
+  u8 af_packet_instance_num = 0;
   last_pci_addr.as_u32 = ~0;
 
-  dm->input_cpu_first_index = 0;
-  dm->input_cpu_count = 1;
-
-  /* find out which cpus will be used for input */
-  p = hash_get_mem (tm->thread_registrations_by_name, "workers");
-  tr = p ? (vlib_thread_registration_t *) p[0] : 0;
+  nports = rte_eth_dev_count_avail ();
 
-  if (tr && tr->count > 0)
+  if (nports < 1)
     {
-      dm->input_cpu_first_index = tr->first_index;
-      dm->input_cpu_count = tr->count;
+      dpdk_log_notice ("DPDK drivers found no Ethernet devices...");
     }
 
-  vec_validate_aligned (dm->devices_by_cpu, tm->n_vlib_mains - 1,
-                       CLIB_CACHE_LINE_BYTES);
-
-  dm->hqos_cpu_first_index = 0;
-  dm->hqos_cpu_count = 0;
-
-  /* find out which cpus will be used for I/O TX */
-  p_hqos = hash_get_mem (tm->thread_registrations_by_name, "hqos-threads");
-  tr_hqos = p_hqos ? (vlib_thread_registration_t *) p_hqos[0] : 0;
+  if (CLIB_DEBUG > 0)
+    dpdk_log_notice ("DPDK drivers found %d ports...", nports);
 
-  if (tr_hqos && tr_hqos->count > 0)
-    {
-      dm->hqos_cpu_first_index = tr_hqos->first_index;
-      dm->hqos_cpu_count = tr_hqos->count;
-    }
+  if (dm->conf->enable_tcp_udp_checksum)
+    dm->buffer_flags_template &= ~(VNET_BUFFER_F_L4_CHECKSUM_CORRECT
+                                  | VNET_BUFFER_F_L4_CHECKSUM_COMPUTED);
 
-  vec_validate_aligned (dm->devices_by_hqos_cpu, tm->n_vlib_mains - 1,
+  /* vlib_buffer_t template */
+  vec_validate_aligned (dm->per_thread_data, tm->n_vlib_mains - 1,
                        CLIB_CACHE_LINE_BYTES);
-
-  nports = rte_eth_dev_count ();
-  if (nports < 1)
+  for (i = 0; i < tm->n_vlib_mains; i++)
     {
-      clib_warning ("DPDK drivers found no ports...");
+      dpdk_per_thread_data_t *ptd = vec_elt_at_index (dm->per_thread_data, i);
+      clib_memset (&ptd->buffer_template, 0, sizeof (vlib_buffer_t));
+      ptd->buffer_template.flags = dm->buffer_flags_template;
+      vnet_buffer (&ptd->buffer_template)->sw_if_index[VLIB_TX] = (u32) ~ 0;
     }
 
-  if (CLIB_DEBUG > 0)
-    clib_warning ("DPDK drivers found %d ports...", nports);
-
-  /*
-   * All buffers are all allocated from the same rte_mempool.
-   * Thus they all have the same number of data bytes.
-   */
-  dm->vlib_buffer_free_list_index =
-    vlib_buffer_get_or_create_free_list (vm,
-                                        VLIB_BUFFER_DEFAULT_FREE_LIST_BYTES,
-                                        "dpdk rx");
-
-  if (dm->conf->enable_tcp_udp_checksum)
-    dm->buffer_flags_template &= ~(IP_BUFFER_L4_CHECKSUM_CORRECT
-                                  | IP_BUFFER_L4_CHECKSUM_COMPUTED);
-
-  for (i = 0; i < nports; i++)
+  /* *INDENT-OFF* */
+  RTE_ETH_FOREACH_DEV(i)
     {
       u8 addr[6];
-      u8 vlan_strip = 0;
-      int j;
+      int vlan_off;
       struct rte_eth_dev_info dev_info;
-      clib_error_t *rv;
-      struct rte_eth_link l;
+      struct rte_pci_device *pci_dev;
+      struct rte_vmbus_device *vmbus_dev;
+      dpdk_portid_t next_port_id;
       dpdk_device_config_t *devconf = 0;
       vlib_pci_addr_t pci_addr;
+      vlib_vmbus_addr_t vmbus_addr;
       uword *p = 0;
 
+      if (!rte_eth_dev_is_valid_port(i))
+       continue;
+
       rte_eth_dev_info_get (i, &dev_info);
-      if (dev_info.pci_dev)    /* bonded interface has no pci info */
+
+      if (dev_info.device == 0)
        {
-         pci_addr.domain = dev_info.pci_dev->addr.domain;
-         pci_addr.bus = dev_info.pci_dev->addr.bus;
-         pci_addr.slot = dev_info.pci_dev->addr.devid;
-         pci_addr.function = dev_info.pci_dev->addr.function;
-         p =
-           hash_get (dm->conf->device_config_index_by_pci_addr,
-                     pci_addr.as_u32);
+         dpdk_log_notice ("DPDK bug: missing device info. Skipping %s device",
+                       dev_info.driver_name);
+         continue;
+       }
+
+      pci_dev = dpdk_get_pci_device (&dev_info);
+
+      if (pci_dev)
+       {
+         pci_addr.domain = pci_dev->addr.domain;
+         pci_addr.bus = pci_dev->addr.bus;
+         pci_addr.slot = pci_dev->addr.devid;
+         pci_addr.function = pci_dev->addr.function;
+         p = hash_get (dm->conf->device_config_index_by_pci_addr,
+                       pci_addr.as_u32);
+       }
+
+      vmbus_dev = dpdk_get_vmbus_device (&dev_info);
+
+      if (vmbus_dev)
+       {
+         unformat_input_t input_vmbus;
+
+         unformat_init_vector (&input_vmbus, (u8 *) dev_info.device->name);
+         if (unformat (&input_vmbus, "%U", unformat_vlib_vmbus_addr,
+                       &vmbus_addr))
+           {
+             p = hash_get (dm->conf->device_config_index_by_vmbus_addr,
+                           vmbus_addr.as_u32[0]);
+           }
        }
 
       if (p)
-       devconf = pool_elt_at_index (dm->conf->dev_confs, p[0]);
+       {
+         devconf = pool_elt_at_index (dm->conf->dev_confs, p[0]);
+         /* If device is blacklisted, we should skip it */
+         if (devconf->is_blacklisted)
+           {
+             continue;
+           }
+       }
       else
        devconf = &dm->conf->default_devconf;
 
@@ -606,14 +312,28 @@ dpdk_lib_init (dpdk_main_t * dm)
       xd->nb_rx_desc = DPDK_NB_RX_DESC_DEFAULT;
       xd->nb_tx_desc = DPDK_NB_TX_DESC_DEFAULT;
       xd->cpu_socket = (i8) rte_eth_dev_socket_id (i);
+      if (p)
+       {
+         xd->name = devconf->name;
+       }
 
+      /* Handle representor devices that share the same PCI ID */
+      if (dev_info.switch_info.domain_id != RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID)
+        {
+          if (dev_info.switch_info.port_id != (uint16_t)-1)
+            xd->interface_name_suffix = format (0, "%d", dev_info.switch_info.port_id);
+        }
       /* Handle interface naming for devices with multiple ports sharing same PCI ID */
-      if (dev_info.pci_dev)
+      else if (pci_dev &&
+         ((next_port_id = rte_eth_find_next (i + 1)) != RTE_MAX_ETHPORTS))
        {
          struct rte_eth_dev_info di = { 0 };
-         rte_eth_dev_info_get (i + 1, &di);
-         if (di.pci_dev && pci_addr.as_u32 != last_pci_addr.as_u32 &&
-             memcmp (&dev_info.pci_dev->addr, &di.pci_dev->addr,
+         struct rte_pci_device *next_pci_dev;
+         rte_eth_dev_info_get (next_port_id, &di);
+         next_pci_dev = di.device ? RTE_DEV_TO_PCI (di.device) : 0;
+         if (next_pci_dev &&
+             pci_addr.as_u32 != last_pci_addr.as_u32 &&
+             memcmp (&pci_dev->addr, &next_pci_dev->addr,
                      sizeof (struct rte_pci_addr)) == 0)
            {
              xd->interface_name_suffix = format (0, "0");
@@ -635,32 +355,41 @@ dpdk_lib_init (dpdk_main_t * dm)
 
       clib_memcpy (&xd->tx_conf, &dev_info.default_txconf,
                   sizeof (struct rte_eth_txconf));
+
+      if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_IPV4_CKSUM)
+       {
+         xd->port_conf.rxmode.offloads |= DEV_RX_OFFLOAD_IPV4_CKSUM;
+         xd->flags |= DPDK_DEVICE_FLAG_RX_IP4_CKSUM;
+       }
+
+      if (dm->conf->enable_tcp_udp_checksum)
+       {
+         if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_UDP_CKSUM)
+           xd->port_conf.rxmode.offloads |= DEV_RX_OFFLOAD_UDP_CKSUM;
+         if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_TCP_CKSUM)
+           xd->port_conf.rxmode.offloads |= DEV_RX_OFFLOAD_TCP_CKSUM;
+       }
+
       if (dm->conf->no_multi_seg)
        {
-         xd->tx_conf.txq_flags |= ETH_TXQ_FLAGS_NOMULTSEGS;
-         port_conf_template.rxmode.jumbo_frame = 0;
+         xd->port_conf.txmode.offloads &= ~DEV_TX_OFFLOAD_MULTI_SEGS;
+         xd->port_conf.rxmode.offloads &= ~DEV_RX_OFFLOAD_JUMBO_FRAME;
+         xd->port_conf.rxmode.offloads &= ~DEV_RX_OFFLOAD_SCATTER;
        }
       else
        {
-         xd->tx_conf.txq_flags &= ~ETH_TXQ_FLAGS_NOMULTSEGS;
-         port_conf_template.rxmode.jumbo_frame = 1;
+         xd->port_conf.txmode.offloads |= DEV_TX_OFFLOAD_MULTI_SEGS;
+         xd->port_conf.rxmode.offloads |= DEV_RX_OFFLOAD_JUMBO_FRAME;
+         xd->port_conf.rxmode.offloads |= DEV_RX_OFFLOAD_SCATTER;
          xd->flags |= DPDK_DEVICE_FLAG_MAYBE_MULTISEG;
        }
 
-      clib_memcpy (&xd->port_conf, &port_conf_template,
-                  sizeof (struct rte_eth_conf));
-
       xd->tx_q_used = clib_min (dev_info.max_tx_queues, tm->n_vlib_mains);
 
       if (devconf->num_tx_queues > 0
          && devconf->num_tx_queues < xd->tx_q_used)
        xd->tx_q_used = clib_min (xd->tx_q_used, devconf->num_tx_queues);
 
-      if (devconf->num_rx_queues > 1 && dm->use_rss == 0)
-       {
-         dm->use_rss = 1;
-       }
-
       if (devconf->num_rx_queues > 1
          && dev_info.max_rx_queues >= devconf->num_rx_queues)
        {
@@ -670,7 +399,17 @@ dpdk_lib_init (dpdk_main_t * dm)
            xd->port_conf.rx_adv_conf.rss_conf.rss_hf =
              ETH_RSS_IP | ETH_RSS_UDP | ETH_RSS_TCP;
          else
-           xd->port_conf.rx_adv_conf.rss_conf.rss_hf = devconf->rss_fn;
+           {
+             u64 unsupported_bits;
+             xd->port_conf.rx_adv_conf.rss_conf.rss_hf = devconf->rss_fn;
+             unsupported_bits = xd->port_conf.rx_adv_conf.rss_conf.rss_hf;
+             unsupported_bits &= ~dev_info.flow_type_rss_offloads;
+             if (unsupported_bits)
+               dpdk_log_warn ("Unsupported RSS hash functions: %U",
+                              format_dpdk_rss_hf_name, unsupported_bits);
+           }
+         xd->port_conf.rx_adv_conf.rss_conf.rss_hf &=
+           dev_info.flow_type_rss_offloads;
        }
       else
        xd->rx_q_used = 1;
@@ -678,8 +417,8 @@ dpdk_lib_init (dpdk_main_t * dm)
       xd->flags |= DPDK_DEVICE_FLAG_PMD;
 
       /* workaround for drivers not setting driver_name */
-      if ((!dev_info.driver_name) && (dev_info.pci_dev))
-       dev_info.driver_name = dev_info.pci_dev->driver->driver.name;
+      if ((!dev_info.driver_name) && (pci_dev))
+       dev_info.driver_name = pci_dev->driver->driver.name;
 
       ASSERT (dev_info.driver_name);
 
@@ -703,130 +442,104 @@ dpdk_lib_init (dpdk_main_t * dm)
 
          switch (xd->pmd)
            {
-             /* 1G adapters */
+             /* Drivers with valid speed_capa set */
            case VNET_DPDK_PMD_E1000EM:
            case VNET_DPDK_PMD_IGB:
-           case VNET_DPDK_PMD_IGBVF:
-             xd->port_type = VNET_DPDK_PORT_TYPE_ETH_1G;
-             break;
-
-             /* 10G adapters */
            case VNET_DPDK_PMD_IXGBE:
-           case VNET_DPDK_PMD_IXGBEVF:
-           case VNET_DPDK_PMD_THUNDERX:
-             xd->port_type = VNET_DPDK_PORT_TYPE_ETH_10G;
+           case VNET_DPDK_PMD_I40E:
+           case VNET_DPDK_PMD_ICE:
+             xd->port_type = port_type_from_speed_capa (&dev_info);
+             xd->supported_flow_actions = VNET_FLOW_ACTION_MARK |
+               VNET_FLOW_ACTION_REDIRECT_TO_NODE |
+               VNET_FLOW_ACTION_REDIRECT_TO_QUEUE |
+               VNET_FLOW_ACTION_BUFFER_ADVANCE |
+               VNET_FLOW_ACTION_COUNT | VNET_FLOW_ACTION_DROP |
+               VNET_FLOW_ACTION_RSS;
+
+             if (dm->conf->no_tx_checksum_offload == 0)
+               {
+                 xd->port_conf.txmode.offloads |= DEV_TX_OFFLOAD_TCP_CKSUM;
+                 xd->port_conf.txmode.offloads |= DEV_TX_OFFLOAD_UDP_CKSUM;
+                 xd->flags |=
+                   DPDK_DEVICE_FLAG_TX_OFFLOAD |
+                   DPDK_DEVICE_FLAG_INTEL_PHDR_CKSUM;
+               }
+
+
              break;
-           case VNET_DPDK_PMD_DPAA2:
-             xd->port_type = VNET_DPDK_PORT_TYPE_ETH_10G;
+           case VNET_DPDK_PMD_CXGBE:
+           case VNET_DPDK_PMD_MLX4:
+           case VNET_DPDK_PMD_MLX5:
+           case VNET_DPDK_PMD_QEDE:
+           case VNET_DPDK_PMD_BNXT:
+             xd->port_type = port_type_from_speed_capa (&dev_info);
              break;
 
-             /* Cisco VIC */
-           case VNET_DPDK_PMD_ENIC:
-             rte_eth_link_get_nowait (i, &l);
-             xd->flags |= DPDK_DEVICE_FLAG_PMD_SUPPORTS_PTYPE;
-             if (l.link_speed == 40000)
-               xd->port_type = VNET_DPDK_PORT_TYPE_ETH_40G;
-             else
-               xd->port_type = VNET_DPDK_PORT_TYPE_ETH_10G;
+             /* SR-IOV VFs */
+           case VNET_DPDK_PMD_IGBVF:
+           case VNET_DPDK_PMD_IXGBEVF:
+           case VNET_DPDK_PMD_I40EVF:
+             xd->port_type = VNET_DPDK_PORT_TYPE_ETH_VF;
+             if (dm->conf->no_tx_checksum_offload == 0)
+               {
+                 xd->port_conf.txmode.offloads |= DEV_TX_OFFLOAD_TCP_CKSUM;
+                 xd->port_conf.txmode.offloads |= DEV_TX_OFFLOAD_UDP_CKSUM;
+                 xd->flags |=
+                   DPDK_DEVICE_FLAG_TX_OFFLOAD |
+                   DPDK_DEVICE_FLAG_INTEL_PHDR_CKSUM;
+               }
              break;
 
-             /* Intel Fortville */
-           case VNET_DPDK_PMD_I40E:
-           case VNET_DPDK_PMD_I40EVF:
-             xd->flags |= DPDK_DEVICE_FLAG_PMD_SUPPORTS_PTYPE;
-             xd->port_type = VNET_DPDK_PORT_TYPE_ETH_40G;
+             /* iAVF */
+           case VNET_DPDK_PMD_IAVF:
+        xd->port_type = VNET_DPDK_PORT_TYPE_ETH_VF;
+             xd->supported_flow_actions = VNET_FLOW_ACTION_MARK |
+               VNET_FLOW_ACTION_REDIRECT_TO_NODE |
+               VNET_FLOW_ACTION_REDIRECT_TO_QUEUE |
+               VNET_FLOW_ACTION_BUFFER_ADVANCE |
+               VNET_FLOW_ACTION_COUNT | VNET_FLOW_ACTION_DROP;
 
-             switch (dev_info.pci_dev->id.device_id)
+             if (dm->conf->no_tx_checksum_offload == 0)
                {
-               case I40E_DEV_ID_10G_BASE_T:
-               case I40E_DEV_ID_SFP_XL710:
-                 xd->port_type = VNET_DPDK_PORT_TYPE_ETH_10G;
-                 break;
-               case I40E_DEV_ID_QSFP_A:
-               case I40E_DEV_ID_QSFP_B:
-               case I40E_DEV_ID_QSFP_C:
-                 xd->port_type = VNET_DPDK_PORT_TYPE_ETH_40G;
-                 break;
-               case I40E_DEV_ID_VF:
-                 rte_eth_link_get_nowait (i, &l);
-                 xd->port_type = l.link_speed == 10000 ?
-                   VNET_DPDK_PORT_TYPE_ETH_10G : VNET_DPDK_PORT_TYPE_ETH_40G;
-                 break;
-               default:
-                 xd->port_type = VNET_DPDK_PORT_TYPE_UNKNOWN;
+                  xd->port_conf.txmode.offloads |= DEV_TX_OFFLOAD_TCP_CKSUM;
+                  xd->port_conf.txmode.offloads |= DEV_TX_OFFLOAD_UDP_CKSUM;
+                 xd->flags |=
+                   DPDK_DEVICE_FLAG_TX_OFFLOAD |
+                   DPDK_DEVICE_FLAG_INTEL_PHDR_CKSUM;
                }
-             break;
+              break;
 
-           case VNET_DPDK_PMD_CXGBE:
-             switch (dev_info.pci_dev->id.device_id)
+           case VNET_DPDK_PMD_THUNDERX:
+             xd->port_type = VNET_DPDK_PORT_TYPE_ETH_VF;
+
+             if (dm->conf->no_tx_checksum_offload == 0)
                {
-               case 0x540d:    /* T580-CR */
-               case 0x5410:    /* T580-LP-cr */
-                 xd->port_type = VNET_DPDK_PORT_TYPE_ETH_40G;
-                 break;
-               case 0x5403:    /* T540-CR */
-                 xd->port_type = VNET_DPDK_PORT_TYPE_ETH_10G;
-                 break;
-               default:
-                 xd->port_type = VNET_DPDK_PORT_TYPE_UNKNOWN;
+                 xd->port_conf.txmode.offloads |= DEV_TX_OFFLOAD_TCP_CKSUM;
+                 xd->port_conf.txmode.offloads |= DEV_TX_OFFLOAD_UDP_CKSUM;
+                 xd->flags |= DPDK_DEVICE_FLAG_TX_OFFLOAD;
                }
              break;
 
-           case VNET_DPDK_PMD_MLX5:
-             {
-               char *pn_100g[] = { "MCX415A-CCAT", "MCX416A-CCAT", 0 };
-               char *pn_40g[] = { "MCX413A-BCAT", "MCX414A-BCAT",
-                 "MCX415A-BCAT", "MCX416A-BCAT", "MCX4131A-BCAT", 0
-               };
-               char *pn_10g[] = { "MCX4111A-XCAT", "MCX4121A-XCAT", 0 };
-
-               vlib_pci_device_t *pd = vlib_get_pci_device (&pci_addr);
-               u8 *pn = 0;
-               char **c;
-               int found = 0;
-               pn = format (0, "%U%c",
-                            format_vlib_pci_vpd, pd->vpd_r, "PN", 0);
-
-               if (!pn)
-                 break;
+           case VNET_DPDK_PMD_ENA:
+             xd->port_type = VNET_DPDK_PORT_TYPE_ETH_VF;
+             xd->port_conf.rxmode.offloads &= ~DEV_RX_OFFLOAD_SCATTER;
+             break;
 
-               c = pn_100g;
-               while (!found && c[0])
-                 {
-                   if (strncmp ((char *) pn, c[0], strlen (c[0])) == 0)
-                     {
-                       xd->port_type = VNET_DPDK_PORT_TYPE_ETH_100G;
-                       break;
-                     }
-                   c++;
-                 }
-
-               c = pn_40g;
-               while (!found && c[0])
-                 {
-                   if (strncmp ((char *) pn, c[0], strlen (c[0])) == 0)
-                     {
-                       xd->port_type = VNET_DPDK_PORT_TYPE_ETH_40G;
-                       break;
-                     }
-                   c++;
-                 }
-
-               c = pn_10g;
-               while (!found && c[0])
-                 {
-                   if (strncmp ((char *) pn, c[0], strlen (c[0])) == 0)
-                     {
-                       xd->port_type = VNET_DPDK_PORT_TYPE_ETH_10G;
-                       break;
-                     }
-                   c++;
-                 }
-
-               vec_free (pn);
-             }
+           case VNET_DPDK_PMD_DPAA2:
+             xd->port_type = VNET_DPDK_PORT_TYPE_ETH_10G;
+             break;
 
+             /* Cisco VIC */
+           case VNET_DPDK_PMD_ENIC:
+                {
+                  struct rte_eth_link l;
+                  rte_eth_link_get_nowait (i, &l);
+                  xd->port_type = port_type_from_link_speed (l.link_speed);
+                  if (dm->conf->enable_tcp_udp_checksum)
+                    dpdk_enable_l4_csum_offload (xd);
+                }
              break;
+
              /* Intel Red Rock Canyon */
            case VNET_DPDK_PMD_FM10K:
              xd->port_type = VNET_DPDK_PORT_TYPE_ETH_SWITCH;
@@ -834,6 +547,7 @@ dpdk_lib_init (dpdk_main_t * dm)
 
              /* virtio */
            case VNET_DPDK_PMD_VIRTIO:
+             xd->port_conf.rxmode.mq_mode = ETH_MQ_RX_NONE;
              xd->port_type = VNET_DPDK_PORT_TYPE_ETH_1G;
              xd->nb_rx_desc = DPDK_NB_RX_DESC_VIRTIO;
              xd->nb_tx_desc = DPDK_NB_TX_DESC_VIRTIO;
@@ -842,17 +556,37 @@ dpdk_lib_init (dpdk_main_t * dm)
              /* vmxnet3 */
            case VNET_DPDK_PMD_VMXNET3:
              xd->port_type = VNET_DPDK_PORT_TYPE_ETH_1G;
-             xd->tx_conf.txq_flags |= ETH_TXQ_FLAGS_NOMULTSEGS;
+             xd->port_conf.txmode.offloads |= DEV_TX_OFFLOAD_MULTI_SEGS;
              break;
 
            case VNET_DPDK_PMD_AF_PACKET:
              xd->port_type = VNET_DPDK_PORT_TYPE_AF_PACKET;
-             xd->af_packet_port_id = af_packet_port_id++;
+             xd->af_packet_instance_num = af_packet_instance_num++;
              break;
 
-           case VNET_DPDK_PMD_BOND:
-             xd->flags |= DPDK_DEVICE_FLAG_PMD_SUPPORTS_PTYPE;
-             xd->port_type = VNET_DPDK_PORT_TYPE_ETH_BOND;
+           case VNET_DPDK_PMD_VIRTIO_USER:
+             xd->port_type = VNET_DPDK_PORT_TYPE_VIRTIO_USER;
+             break;
+
+           case VNET_DPDK_PMD_VHOST_ETHER:
+             xd->port_type = VNET_DPDK_PORT_TYPE_VHOST_ETHER;
+             break;
+
+           case VNET_DPDK_PMD_LIOVF_ETHER:
+             xd->port_type = VNET_DPDK_PORT_TYPE_ETH_VF;
+             break;
+
+           case VNET_DPDK_PMD_FAILSAFE:
+             xd->port_type = VNET_DPDK_PORT_TYPE_FAILSAFE;
+             xd->port_conf.intr_conf.lsc = 1;
+             break;
+
+           case VNET_DPDK_PMD_NETVSC:
+                {
+                  struct rte_eth_link l;
+                  rte_eth_link_get_nowait (i, &l);
+                 xd->port_type = VNET_DPDK_PORT_TYPE_ETH_VF;
+                }
              break;
 
            default:
@@ -861,15 +595,63 @@ dpdk_lib_init (dpdk_main_t * dm)
 
          if (devconf->num_rx_desc)
            xd->nb_rx_desc = devconf->num_rx_desc;
+          else {
+
+            /* If num_rx_desc is not specified by VPP user, the current CPU is working
+            with 2M page and has no L3 cache, default num_rx_desc is changed to 512
+            from original 1024 to help reduce TLB misses.
+            */
+            if ((clib_mem_get_default_hugepage_size () == 2 << 20)
+              && check_l3cache() == 0)
+              xd->nb_rx_desc = 512;
+          }
 
          if (devconf->num_tx_desc)
            xd->nb_tx_desc = devconf->num_tx_desc;
+          else {
+
+            /* If num_tx_desc is not specified by VPP user, the current CPU is working
+            with 2M page and has no L3 cache, default num_tx_desc is changed to 512
+            from original 1024 to help reduce TLB misses.
+            */
+            if ((clib_mem_get_default_hugepage_size () == 2 << 20)
+              && check_l3cache() == 0)
+              xd->nb_tx_desc = 512;
+         }
+       }
+
+      if (xd->pmd == VNET_DPDK_PMD_AF_PACKET)
+       {
+         f64 now = vlib_time_now (vm);
+         u32 rnd;
+         rnd = (u32) (now * 1e6);
+         rnd = random_u32 (&rnd);
+         clib_memcpy (addr + 2, &rnd, sizeof (rnd));
+         addr[0] = 2;
+         addr[1] = 0xfe;
        }
+      else
+       rte_eth_macaddr_get (i, (void *) addr);
+
+      xd->port_id = i;
+      xd->device_index = xd - dm->devices;
+      xd->per_interface_next_index = ~0;
+
+      /* assign interface to input thread */
+      int q;
+
+      error = ethernet_register_interface
+       (dm->vnet_main, dpdk_device_class.index, xd->device_index,
+        /* ethernet address */ addr,
+        &xd->hw_if_index, dpdk_flag_change);
+      if (error)
+       return error;
 
       /*
        * Ensure default mtu is not > the mtu read from the hardware.
        * Otherwise rte_eth_dev_configure() will fail and the port will
        * not be available.
+       * Calculate max_frame_size and mtu supported by NIC
        */
       if (ETHERNET_MAX_PACKET_BYTES > dev_info.max_rx_pktlen)
        {
@@ -877,216 +659,203 @@ dpdk_lib_init (dpdk_main_t * dm)
           * This device does not support the platforms's max frame
           * size. Use it's advertised mru instead.
           */
-         xd->port_conf.rxmode.max_rx_pkt_len = dev_info.max_rx_pktlen;
+         max_rx_frame = dev_info.max_rx_pktlen;
+         mtu = dev_info.max_rx_pktlen - sizeof (ethernet_header_t);
        }
       else
        {
-         xd->port_conf.rxmode.max_rx_pkt_len = ETHERNET_MAX_PACKET_BYTES;
-
-         /*
-          * Some platforms do not account for Ethernet FCS (4 bytes) in
-          * MTU calculations. To interop with them increase mru but only
-          * if the device's settings can support it.
+         /* VPP treats MTU and max_rx_pktlen both equal to
+          * ETHERNET_MAX_PACKET_BYTES, if dev_info.max_rx_pktlen >=
+          * ETHERNET_MAX_PACKET_BYTES + sizeof(ethernet_header_t)
           */
-         if ((dev_info.max_rx_pktlen >= (ETHERNET_MAX_PACKET_BYTES + 4)) &&
-             xd->port_conf.rxmode.hw_strip_crc)
+         if (dev_info.max_rx_pktlen >= (ETHERNET_MAX_PACKET_BYTES +
+                                        sizeof (ethernet_header_t)))
            {
+             mtu = ETHERNET_MAX_PACKET_BYTES;
+             max_rx_frame = ETHERNET_MAX_PACKET_BYTES;
+
              /*
-              * Allow additional 4 bytes (for Ethernet FCS). These bytes are
-              * stripped by h/w and so will not consume any buffer memory.
+              * Some platforms do not account for Ethernet FCS (4 bytes) in
+              * MTU calculations. To interop with them increase mru but only
+              * if the device's settings can support it.
               */
-             xd->port_conf.rxmode.max_rx_pkt_len += 4;
+             if (dpdk_port_crc_strip_enabled (xd) &&
+                 (dev_info.max_rx_pktlen >= (ETHERNET_MAX_PACKET_BYTES +
+                                             sizeof (ethernet_header_t) +
+                                             4)))
+               {
+                 max_rx_frame += 4;
+               }
+           }
+         else
+           {
+             max_rx_frame = ETHERNET_MAX_PACKET_BYTES;
+             mtu = ETHERNET_MAX_PACKET_BYTES - sizeof (ethernet_header_t);
+
+             if (dpdk_port_crc_strip_enabled (xd) &&
+                 (dev_info.max_rx_pktlen >= (ETHERNET_MAX_PACKET_BYTES + 4)))
+               {
+                 max_rx_frame += 4;
+               }
            }
        }
 
-      if (xd->pmd == VNET_DPDK_PMD_AF_PACKET)
+      if (xd->pmd == VNET_DPDK_PMD_FAILSAFE)
        {
-         f64 now = vlib_time_now (vm);
-         u32 rnd;
-         rnd = (u32) (now * 1e6);
-         rnd = random_u32 (&rnd);
-         clib_memcpy (addr + 2, &rnd, sizeof (rnd));
-         addr[0] = 2;
-         addr[1] = 0xfe;
-       }
-      else
-       rte_eth_macaddr_get (i, (struct ether_addr *) addr);
+         /* failsafe device numerables are reported with active device only,
+          * need to query the mtu for current device setup to overwrite
+          * reported value.
+          */
+         uint16_t dev_mtu;
+         if (!rte_eth_dev_get_mtu (i, &dev_mtu))
+           {
+             mtu = dev_mtu;
+             max_rx_frame = mtu + sizeof (ethernet_header_t);
 
-      if (xd->tx_q_used < tm->n_vlib_mains)
-       dpdk_device_lock_init (xd);
+             if (dpdk_port_crc_strip_enabled (xd))
+               {
+                 max_rx_frame += 4;
+               }
+           }
+       }
 
-      xd->device_index = xd - dm->devices;
-      ASSERT (i == xd->device_index);
-      xd->per_interface_next_index = ~0;
+      /*Set port rxmode config */
+      xd->port_conf.rxmode.max_rx_pkt_len = max_rx_frame;
 
-      /* assign interface to input thread */
-      dpdk_device_and_queue_t *dq;
-      int q;
+      sw = vnet_get_hw_sw_interface (dm->vnet_main, xd->hw_if_index);
+      xd->sw_if_index = sw->sw_if_index;
+      vnet_hw_interface_set_input_node (dm->vnet_main, xd->hw_if_index,
+                                       dpdk_input_node.index);
 
       if (devconf->workers)
        {
          int i;
          q = 0;
-         /* *INDENT-OFF* */
-         clib_bitmap_foreach (i, devconf->workers, ({
-           int cpu = dm->input_cpu_first_index + i;
-           unsigned lcore = vlib_worker_threads[cpu].lcore_id;
-           vec_validate(xd->cpu_socket_id_by_queue, q);
-           xd->cpu_socket_id_by_queue[q] = rte_lcore_to_socket_id(lcore);
-           vec_add2(dm->devices_by_cpu[cpu], dq, 1);
-           dq->device = xd->device_index;
-           dq->queue_id = q++;
-         }));
-         /* *INDENT-ON* */
+         clib_bitmap_foreach (i, devconf->workers)  {
+           vnet_hw_interface_assign_rx_thread (dm->vnet_main, xd->hw_if_index, q++,
+                                            vdm->first_worker_thread_index + i);
+         }
        }
       else
        for (q = 0; q < xd->rx_q_used; q++)
          {
-           int cpu = dm->input_cpu_first_index + next_cpu;
-           unsigned lcore = vlib_worker_threads[cpu].lcore_id;
-
-           /*
-            * numa node for worker thread handling this queue
-            * needed for taking buffers from the right mempool
-            */
-           vec_validate (xd->cpu_socket_id_by_queue, q);
-           xd->cpu_socket_id_by_queue[q] = rte_lcore_to_socket_id (lcore);
-
-           /*
-            * construct vector of (device,queue) pairs for each worker thread
-            */
-           vec_add2 (dm->devices_by_cpu[cpu], dq, 1);
-           dq->device = xd->device_index;
-           dq->queue_id = q;
-
-           next_cpu++;
-           if (next_cpu == dm->input_cpu_count)
-             next_cpu = 0;
+           vnet_hw_interface_assign_rx_thread (dm->vnet_main, xd->hw_if_index, q,      /* any */
+                                               ~1);
          }
 
+      /*Get vnet hardware interface */
+      hi = vnet_get_hw_interface (dm->vnet_main, xd->hw_if_index);
 
-      if (devconf->hqos_enabled)
-       {
-         xd->flags |= DPDK_DEVICE_FLAG_HQOS;
-
-         if (devconf->hqos.hqos_thread_valid)
-           {
-             int cpu = dm->hqos_cpu_first_index + devconf->hqos.hqos_thread;
-
-             if (devconf->hqos.hqos_thread >= dm->hqos_cpu_count)
-               return clib_error_return (0, "invalid HQoS thread index");
-
-             vec_add2 (dm->devices_by_hqos_cpu[cpu], dq, 1);
-             dq->device = xd->device_index;
-             dq->queue_id = 0;
-           }
-         else
-           {
-             int cpu = dm->hqos_cpu_first_index + next_hqos_cpu;
-
-             if (dm->hqos_cpu_count == 0)
-               return clib_error_return (0, "no HQoS threads available");
-
-             vec_add2 (dm->devices_by_hqos_cpu[cpu], dq, 1);
-             dq->device = xd->device_index;
-             dq->queue_id = 0;
-
-             next_hqos_cpu++;
-             if (next_hqos_cpu == dm->hqos_cpu_count)
-               next_hqos_cpu = 0;
-
-             devconf->hqos.hqos_thread_valid = 1;
-             devconf->hqos.hqos_thread = cpu;
-           }
-       }
-
-      vec_validate_aligned (xd->tx_vectors, tm->n_vlib_mains,
-                           CLIB_CACHE_LINE_BYTES);
-      for (j = 0; j < tm->n_vlib_mains; j++)
+      /*Override default max_packet_bytes and max_supported_bytes set in
+       * ethernet_register_interface() above*/
+      if (hi)
        {
-         vec_validate_ha (xd->tx_vectors[j], xd->nb_tx_desc,
-                          sizeof (tx_ring_hdr_t), CLIB_CACHE_LINE_BYTES);
-         vec_reset_length (xd->tx_vectors[j]);
+         hi->max_packet_bytes = mtu;
+         hi->max_supported_packet_bytes = max_rx_frame;
+         hi->numa_node = xd->cpu_socket;
+
+         /* Indicate ability to support L3 DMAC filtering and
+          * initialize interface to L3 non-promisc mode */
+         hi->flags |= VNET_HW_INTERFACE_FLAG_SUPPORTS_MAC_FILTER;
+         ethernet_set_flags (dm->vnet_main, xd->hw_if_index,
+                            ETHERNET_INTERFACE_FLAG_DEFAULT_L3);
        }
 
-      vec_validate_aligned (xd->rx_vectors, xd->rx_q_used,
-                           CLIB_CACHE_LINE_BYTES);
-      for (j = 0; j < xd->rx_q_used; j++)
-       {
-         vec_validate_aligned (xd->rx_vectors[j], VLIB_FRAME_SIZE - 1,
-                               CLIB_CACHE_LINE_BYTES);
-         vec_reset_length (xd->rx_vectors[j]);
-       }
+      if (dm->conf->no_tx_checksum_offload == 0)
+       if (xd->flags & DPDK_DEVICE_FLAG_TX_OFFLOAD && hi != NULL)
+         hi->flags |= VNET_HW_INTERFACE_FLAG_SUPPORTS_TX_L4_CKSUM_OFFLOAD;
 
-      vec_validate_aligned (xd->d_trace_buffers, tm->n_vlib_mains,
-                           CLIB_CACHE_LINE_BYTES);
-
-      rv = dpdk_port_setup (dm, xd);
-
-      if (rv)
-       return rv;
-
-      if (devconf->hqos_enabled)
+      if (devconf->tso == DPDK_DEVICE_TSO_ON && hi != NULL)
        {
-         rv = dpdk_port_setup_hqos (xd, &devconf->hqos);
-         if (rv)
-           return rv;
+         /*tcp_udp checksum must be enabled*/
+         if ((dm->conf->enable_tcp_udp_checksum) &&
+             (hi->flags & VNET_HW_INTERFACE_FLAG_SUPPORTS_TX_L4_CKSUM_OFFLOAD))
+           {
+               hi->flags |= VNET_HW_INTERFACE_FLAG_SUPPORTS_GSO;
+               xd->port_conf.txmode.offloads |= DEV_TX_OFFLOAD_TCP_TSO |
+                 DEV_TX_OFFLOAD_UDP_TSO;
+           }
+         else
+           clib_warning ("%s: TCP/UDP checksum offload must be enabled",
+             hi->name);
        }
 
-      /* count the number of descriptors used for this device */
-      nb_desc += xd->nb_rx_desc + xd->nb_tx_desc * xd->tx_q_used;
+      dpdk_device_setup (xd);
 
-      error = ethernet_register_interface
-       (dm->vnet_main, dpdk_device_class.index, xd->device_index,
-        /* ethernet address */ addr,
-        &xd->vlib_hw_if_index, dpdk_flag_change);
-      if (error)
-       return error;
+      /* rss queues should be configured after dpdk_device_setup() */
+      if ((hi != NULL) && (devconf->rss_queues != NULL))
+        {
+          if (vnet_hw_interface_set_rss_queues
+              (vnet_get_main (), hi, devconf->rss_queues))
+          {
+            clib_warning ("%s: Failed to set rss queues", hi->name);
+          }
+        }
 
-      sw = vnet_get_hw_sw_interface (dm->vnet_main, xd->vlib_hw_if_index);
-      xd->vlib_sw_if_index = sw->sw_if_index;
-      hi = vnet_get_hw_interface (dm->vnet_main, xd->vlib_hw_if_index);
+      if (vec_len (xd->errors))
+        dpdk_log_err ("setup failed for device %U. Errors:\n  %U",
+                      format_dpdk_device_name, i,
+                      format_dpdk_device_errors, xd);
 
       /*
-       * DAW-FIXME: The Cisco VIC firmware does not provide an api for a
-       *            driver to dynamically change the mtu.  If/when the
-       *            VIC firmware gets fixed, then this should be removed.
+       * A note on Cisco VIC (PMD_ENIC) and VLAN:
+       *
+       * With Cisco VIC vNIC, every ingress packet is tagged. On a
+       * trunk vNIC (C series "standalone" server), packets on no VLAN
+       * are tagged with vlan 0. On an access vNIC (standalone or B
+       * series "blade" server), packets on the default/native VLAN
+       * are tagged with that vNIC's VLAN. VPP expects these packets
+       * to be untagged, and previously enabled VLAN strip on VIC by
+       * default. But it also broke vlan sub-interfaces.
+       *
+       * The VIC adapter has "untag default vlan" ingress VLAN rewrite
+       * mode, which removes tags from these packets. VPP now includes
+       * a local patch for the enic driver to use this untag mode, so
+       * enabling vlan stripping is no longer needed. In future, the
+       * driver + dpdk will have an API to set the mode after
+       * rte_eal_init. Then, this note and local patch will be
+       * removed.
        */
-      if (xd->pmd == VNET_DPDK_PMD_ENIC)
-       {
-         /*
-          * Initialize mtu to what has been set by CIMC in the firmware cfg.
-          */
-         hi->max_packet_bytes = dev_info.max_rx_pktlen;
-         if (devconf->vlan_strip_offload != DPDK_DEVICE_VLAN_STRIP_OFF)
-           vlan_strip = 1;     /* remove vlan tag from VIC port by default */
-         else
-           clib_warning ("VLAN strip disabled for interface\n");
-       }
-      else if (devconf->vlan_strip_offload == DPDK_DEVICE_VLAN_STRIP_ON)
-       vlan_strip = 1;
-
-      if (vlan_strip)
-       {
-         int vlan_off;
-         vlan_off = rte_eth_dev_get_vlan_offload (xd->device_index);
-         vlan_off |= ETH_VLAN_STRIP_OFFLOAD;
-         xd->port_conf.rxmode.hw_vlan_strip = vlan_off;
-         if (rte_eth_dev_set_vlan_offload (xd->device_index, vlan_off) == 0)
-           clib_warning ("VLAN strip enabled for interface\n");
-         else
-           clib_warning ("VLAN strip cannot be supported by interface\n");
-       }
 
-      hi->max_l3_packet_bytes[VLIB_RX] = hi->max_l3_packet_bytes[VLIB_TX] =
-       xd->port_conf.rxmode.max_rx_pkt_len - sizeof (ethernet_header_t);
+      /*
+       * VLAN stripping: default to VLAN strip disabled, unless specified
+       * otherwise in the startup config.
+       */
 
-      rte_eth_dev_set_mtu (xd->device_index, hi->max_packet_bytes);
-    }
+        vlan_off = rte_eth_dev_get_vlan_offload (xd->port_id);
+        if (devconf->vlan_strip_offload == DPDK_DEVICE_VLAN_STRIP_ON)
+          {
+            vlan_off |= ETH_VLAN_STRIP_OFFLOAD;
+            if (rte_eth_dev_set_vlan_offload (xd->port_id, vlan_off) >= 0)
+              dpdk_log_info ("VLAN strip enabled for interface\n");
+            else
+              dpdk_log_warn ("VLAN strip cannot be supported by interface\n");
+            xd->port_conf.rxmode.offloads |= DEV_RX_OFFLOAD_VLAN_STRIP;
+          }
+        else
+          {
+            if (vlan_off & ETH_VLAN_STRIP_OFFLOAD)
+              {
+               vlan_off &= ~ETH_VLAN_STRIP_OFFLOAD;
+               if (rte_eth_dev_set_vlan_offload (xd->port_id, vlan_off) >= 0)
+                 dpdk_log_warn ("set VLAN offload failed\n");
+              }
+            xd->port_conf.rxmode.offloads &= ~DEV_RX_OFFLOAD_VLAN_STRIP;
+          }
+
+        if (hi)
+          hi->max_packet_bytes = xd->port_conf.rxmode.max_rx_pkt_len
+            - sizeof (ethernet_header_t);
+        else
+          dpdk_log_warn ("hi NULL");
+
+        if (dm->conf->no_multi_seg)
+          mtu = mtu > ETHER_MAX_LEN ? ETHER_MAX_LEN : mtu;
+
+        rte_eth_dev_set_mtu (xd->port_id, mtu);
+}
 
-  if (nb_desc > dm->conf->num_mbufs)
-    clib_warning ("%d mbufs allocated but total rx/tx ring size is %d\n",
-                 dm->conf->num_mbufs, nb_desc);
+  /* *INDENT-ON* */
 
   return 0;
 }
@@ -1094,105 +863,318 @@ dpdk_lib_init (dpdk_main_t * dm)
 static void
 dpdk_bind_devices_to_uio (dpdk_config_main_t * conf)
 {
-  vlib_pci_main_t *pm = &pci_main;
+  vlib_main_t *vm = vlib_get_main ();
   clib_error_t *error;
-  vlib_pci_device_t *d;
   u8 *pci_addr = 0;
   int num_whitelisted = vec_len (conf->dev_confs);
+  vlib_pci_device_info_t *d = 0;
+  vlib_pci_addr_t *addr = 0, *addrs;
+  int i;
 
+  addrs = vlib_pci_get_all_dev_addrs ();
   /* *INDENT-OFF* */
-  pool_foreach (d, pm->pci_devs, ({
+  vec_foreach (addr, addrs)
+    {
     dpdk_device_config_t * devconf = 0;
     vec_reset_length (pci_addr);
-    pci_addr = format (pci_addr, "%U%c", format_vlib_pci_addr, &d->bus_address, 0);
+    pci_addr = format (pci_addr, "%U%c", format_vlib_pci_addr, addr, 0);
+    if (d)
+    {
+      vlib_pci_free_device_info (d);
+      d = 0;
+      }
+    d = vlib_pci_get_device_info (vm, addr, &error);
+    if (error)
+    {
+      vlib_log_warn (dpdk_main.log_default, "%U", format_clib_error, error);
+      clib_error_free (error);
+      continue;
+    }
 
     if (d->device_class != PCI_CLASS_NETWORK_ETHERNET && d->device_class != PCI_CLASS_PROCESSOR_CO)
       continue;
 
     if (num_whitelisted)
       {
-       uword * p = hash_get (conf->device_config_index_by_pci_addr, d->bus_address.as_u32);
+       uword * p = hash_get (conf->device_config_index_by_pci_addr, addr->as_u32);
 
        if (!p)
-         continue;
+          {
+         skipped_pci:
+           continue;
+         }
 
        devconf = pool_elt_at_index (conf->dev_confs, p[0]);
       }
 
+    /* Enforce Device blacklist by vendor and device */
+    for (i = 0; i < vec_len (conf->blacklist_by_pci_vendor_and_device); i++)
+      {
+        u16 vendor, device;
+        vendor = (u16)(conf->blacklist_by_pci_vendor_and_device[i] >> 16);
+        device = (u16)(conf->blacklist_by_pci_vendor_and_device[i] & 0xFFFF);
+        if (d->vendor_id == vendor && d->device_id == device)
+          {
+            /*
+             * Expected case: device isn't whitelisted,
+             * so blacklist it...
+             */
+            if (devconf == 0)
+              {
+                /* Device is blacklisted */
+                pool_get (conf->dev_confs, devconf);
+                hash_set (conf->device_config_index_by_pci_addr, addr->as_u32,
+                          devconf - conf->dev_confs);
+                devconf->pci_addr.as_u32 = addr->as_u32;
+               devconf->dev_addr_type = VNET_DEV_ADDR_PCI;
+               devconf->is_blacklisted = 1;
+               goto skipped_pci;
+             }
+           else /* explicitly whitelisted, ignore the device blacklist  */
+             break;
+         }
+      }
+
     /* virtio */
-    if (d->vendor_id == 0x1af4 && d->device_id == 0x1000)
+    if (d->vendor_id == 0x1af4 &&
+            (d->device_id == VIRTIO_PCI_LEGACY_DEVICEID_NET ||
+             d->device_id == VIRTIO_PCI_MODERN_DEVICEID_NET))
       ;
     /* vmxnet3 */
     else if (d->vendor_id == 0x15ad && d->device_id == 0x07b0)
+      {
+       /*
+        * For vmxnet3 PCI, unless it is explicitly specified in the whitelist,
+        * the default is to put it in the blacklist.
+        */
+       if (devconf == 0)
+         {
+           pool_get (conf->dev_confs, devconf);
+           hash_set (conf->device_config_index_by_pci_addr, addr->as_u32,
+                     devconf - conf->dev_confs);
+           devconf->pci_addr.as_u32 = addr->as_u32;
+           devconf->is_blacklisted = 1;
+         }
+      }
+    /* all Intel network devices */
+    else if (d->vendor_id == 0x8086 && d->device_class == PCI_CLASS_NETWORK_ETHERNET)
       ;
-    /* all Intel devices */
-    else if (d->vendor_id == 0x8086)
+    /* all Intel QAT devices VFs */
+    else if (d->vendor_id == 0x8086 && d->device_class == PCI_CLASS_PROCESSOR_CO &&
+        (d->device_id == 0x0443 || d->device_id == 0x18a1 || d->device_id == 0x19e3 ||
+        d->device_id == 0x37c9 || d->device_id == 0x6f55))
       ;
     /* Cisco VIC */
-    else if (d->vendor_id == 0x1137 && d->device_id == 0x0043)
+    else if (d->vendor_id == 0x1137 &&
+        (d->device_id == 0x0043 || d->device_id == 0x0071))
       ;
     /* Chelsio T4/T5 */
     else if (d->vendor_id == 0x1425 && (d->device_id & 0xe000) == 0x4000)
       ;
+    /* Amazon Elastic Network Adapter */
+    else if (d->vendor_id == 0x1d0f && d->device_id >= 0xec20 && d->device_id <= 0xec21)
+      ;
+    /* Cavium Network Adapter */
+    else if (d->vendor_id == 0x177d && d->device_id == 0x9712)
+      ;
+    /* Cavium FastlinQ QL41000 Series */
+    else if (d->vendor_id == 0x1077 && d->device_id >= 0x8070 && d->device_id <= 0x8090)
+      ;
+    /* Mellanox CX3, CX3VF */
+    else if (d->vendor_id == 0x15b3 && d->device_id >= 0x1003 && d->device_id <= 0x1004)
+      {
+        continue;
+      }
+    /* Mellanox CX4, CX4VF, CX4LX, CX4LXVF, CX5, CX5VF, CX5EX, CX5EXVF */
+    else if (d->vendor_id == 0x15b3 && d->device_id >= 0x1013 && d->device_id <= 0x101a)
+      {
+        continue;
+      }
+    /* Mellanox CX6, CX6VF, CX6DX, CX6DXVF */
+    else if (d->vendor_id == 0x15b3 && d->device_id >= 0x101b && d->device_id <= 0x101e)
+      {
+        continue;
+      }
+    /* Broadcom NetXtreme S, and E series only */
+    else if (d->vendor_id == 0x14e4 &&
+       ((d->device_id >= 0x16c0 &&
+               d->device_id != 0x16c6 && d->device_id != 0x16c7 &&
+               d->device_id != 0x16dd && d->device_id != 0x16f7 &&
+               d->device_id != 0x16fd && d->device_id != 0x16fe &&
+               d->device_id != 0x170d && d->device_id != 0x170c &&
+               d->device_id != 0x170e && d->device_id != 0x1712 &&
+               d->device_id != 0x1713) ||
+       (d->device_id == 0x1604 || d->device_id == 0x1605 ||
+        d->device_id == 0x1614 || d->device_id == 0x1606 ||
+        d->device_id == 0x1609 || d->device_id == 0x1614)))
+      ;
     else
       {
-        clib_warning ("Unsupported Ethernet PCI device 0x%04x:0x%04x found "
+        dpdk_log_warn ("Unsupported PCI device 0x%04x:0x%04x found "
                      "at PCI address %s\n", (u16) d->vendor_id, (u16) d->device_id,
                      pci_addr);
         continue;
       }
 
-    error = vlib_pci_bind_to_uio (d, (char *) conf->uio_driver_name);
+    error = vlib_pci_bind_to_uio (vm, addr, (char *) conf->uio_driver_name);
+
+    if (error)
+      {
+       if (devconf == 0)
+         {
+           pool_get (conf->dev_confs, devconf);
+           hash_set (conf->device_config_index_by_pci_addr, addr->as_u32,
+                     devconf - conf->dev_confs);
+           devconf->pci_addr.as_u32 = addr->as_u32;
+         }
+       devconf->dev_addr_type = VNET_DEV_ADDR_PCI;
+       devconf->is_blacklisted = 1;
+       clib_error_report (error);
+      }
+  }
+  /* *INDENT-ON* */
+  vec_free (pci_addr);
+  vlib_pci_free_device_info (d);
+}
+
+static void
+dpdk_bind_vmbus_devices_to_uio (dpdk_config_main_t * conf)
+{
+  clib_error_t *error;
+  vlib_vmbus_addr_t *addrs, *addr = 0;
+  int num_whitelisted = vec_len (conf->dev_confs);
+  int i;
+
+  addrs = vlib_vmbus_get_all_dev_addrs ();
+
+  /* *INDENT-OFF* */
+  vec_foreach (addr, addrs)
+    {
+      dpdk_device_config_t *devconf = 0;
+      if (num_whitelisted)
+       {
+         uword *p = hash_get (conf->device_config_index_by_vmbus_addr,
+                              addr->as_u32[0]);
+         if (!p)
+           {
+             /* No devices blacklisted, but have whitelisted. blacklist all
+              * non-whitelisted */
+             pool_get (conf->dev_confs, devconf);
+             hash_set (conf->device_config_index_by_vmbus_addr,
+                       addr->as_u32[0], devconf - conf->dev_confs);
+             devconf->vmbus_addr = *addr;
+             devconf->dev_addr_type = VNET_DEV_ADDR_VMBUS;
+             devconf->is_blacklisted = 1;
+           skipped_vmbus:
+             continue;
+           }
+
+         devconf = pool_elt_at_index (conf->dev_confs, p[0]);
+       }
 
-    if (error)
-      {
-       if (devconf == 0)
-         {
-           pool_get (conf->dev_confs, devconf);
-           hash_set (conf->device_config_index_by_pci_addr, d->bus_address.as_u32,
-                     devconf - conf->dev_confs);
-           devconf->pci_addr.as_u32 = d->bus_address.as_u32;
-         }
-       devconf->is_blacklisted = 1;
-       clib_error_report (error);
-      }
-  }));
+      /* Enforce Device blacklist by vmbus_addr */
+      for (i = 0; i < vec_len (conf->blacklist_by_vmbus_addr); i++)
+       {
+         u32 vmbus_as_u32 = conf->blacklist_by_vmbus_addr[i];
+         if (vmbus_as_u32 == addr->as_u32[0])
+           {
+             if (devconf == 0)
+               {
+                 /* Device not whitelisted */
+                 pool_get (conf->dev_confs, devconf);
+                 hash_set (conf->device_config_index_by_vmbus_addr,
+                           addr->as_u32[0], devconf - conf->dev_confs);
+                 devconf->vmbus_addr = *addr;
+                 devconf->dev_addr_type = VNET_DEV_ADDR_VMBUS;
+                 devconf->is_blacklisted = 1;
+                 goto skipped_vmbus;
+               }
+             else
+               {
+                 break;
+               }
+           }
+       }
+
+      error = vlib_vmbus_bind_to_uio (addr);
+      if (error)
+       {
+         if (devconf == 0)
+           {
+             pool_get (conf->dev_confs, devconf);
+             hash_set (conf->device_config_index_by_vmbus_addr,
+                       addr->as_u32[0], devconf - conf->dev_confs);
+             devconf->vmbus_addr = *addr;
+           }
+         devconf->dev_addr_type = VNET_DEV_ADDR_VMBUS;
+         devconf->is_blacklisted = 1;
+         clib_error_report (error);
+       }
+    }
   /* *INDENT-ON* */
-  vec_free (pci_addr);
 }
 
 static clib_error_t *
-dpdk_device_config (dpdk_config_main_t * conf, vlib_pci_addr_t pci_addr,
-                   unformat_input_t * input, u8 is_default)
+dpdk_device_config (dpdk_config_main_t *conf, void *addr,
+                   dpdk_device_addr_type_t addr_type, unformat_input_t *input,
+                   u8 is_default)
 {
   clib_error_t *error = 0;
   uword *p;
-  dpdk_device_config_t *devconf;
+  dpdk_device_config_t *devconf = 0;
   unformat_input_t sub_input;
 
   if (is_default)
     {
       devconf = &conf->default_devconf;
     }
-  else
+  else if (addr_type == VNET_DEV_ADDR_PCI)
     {
-      p = hash_get (conf->device_config_index_by_pci_addr, pci_addr.as_u32);
+      p = hash_get (conf->device_config_index_by_pci_addr,
+                   ((vlib_pci_addr_t *) (addr))->as_u32);
 
       if (!p)
        {
          pool_get (conf->dev_confs, devconf);
-         hash_set (conf->device_config_index_by_pci_addr, pci_addr.as_u32,
+         hash_set (conf->device_config_index_by_pci_addr,
+                   ((vlib_pci_addr_t *) (addr))->as_u32,
                    devconf - conf->dev_confs);
        }
       else
        return clib_error_return (0,
                                  "duplicate configuration for PCI address %U",
-                                 format_vlib_pci_addr, &pci_addr);
+                                 format_vlib_pci_addr, addr);
+    }
+  else if (addr_type == VNET_DEV_ADDR_VMBUS)
+    {
+      p = hash_get (conf->device_config_index_by_vmbus_addr,
+                   ((vlib_vmbus_addr_t *) (addr))->as_u32[0]);
+
+      if (!p)
+       {
+         pool_get (conf->dev_confs, devconf);
+         hash_set (conf->device_config_index_by_vmbus_addr,
+                   ((vlib_vmbus_addr_t *) (addr))->as_u32[0],
+                   devconf - conf->dev_confs);
+       }
+      else
+       return clib_error_return (
+         0, "duplicate configuration for VMBUS address %U",
+         format_vlib_vmbus_addr, addr);
     }
 
-  devconf->pci_addr.as_u32 = pci_addr.as_u32;
-  devconf->hqos_enabled = 0;
-  dpdk_device_config_hqos_default (&devconf->hqos);
+  if (addr_type == VNET_DEV_ADDR_PCI)
+    {
+      devconf->pci_addr.as_u32 = ((vlib_pci_addr_t *) (addr))->as_u32;
+      devconf->tso = DPDK_DEVICE_TSO_DEFAULT;
+      devconf->dev_addr_type = VNET_DEV_ADDR_PCI;
+    }
+  else if (addr_type == VNET_DEV_ADDR_VMBUS)
+    {
+      devconf->vmbus_addr = *((vlib_vmbus_addr_t *) (addr));
+      devconf->tso = DPDK_DEVICE_TSO_DEFAULT;
+      devconf->dev_addr_type = VNET_DEV_ADDR_VMBUS;
+    }
 
   if (!input)
     return 0;
@@ -1208,6 +1190,8 @@ dpdk_device_config (dpdk_config_main_t * conf, vlib_pci_addr_t pci_addr,
        ;
       else if (unformat (input, "num-tx-desc %u", &devconf->num_tx_desc))
        ;
+      else if (unformat (input, "name %s", &devconf->name))
+       ;
       else if (unformat (input, "workers %U", unformat_bitmap_list,
                         &devconf->workers))
        ;
@@ -1223,19 +1207,19 @@ dpdk_device_config (dpdk_config_main_t * conf, vlib_pci_addr_t pci_addr,
        devconf->vlan_strip_offload = DPDK_DEVICE_VLAN_STRIP_OFF;
       else if (unformat (input, "vlan-strip-offload on"))
        devconf->vlan_strip_offload = DPDK_DEVICE_VLAN_STRIP_ON;
-      else
-       if (unformat
-           (input, "hqos %U", unformat_vlib_cli_sub_input, &sub_input))
+      else if (unformat (input, "tso on"))
        {
-         devconf->hqos_enabled = 1;
-         error = unformat_hqos (&sub_input, &devconf->hqos);
-         if (error)
-           break;
+         devconf->tso = DPDK_DEVICE_TSO_ON;
        }
-      else if (unformat (input, "hqos"))
+      else if (unformat (input, "tso off"))
        {
-         devconf->hqos_enabled = 1;
+         devconf->tso = DPDK_DEVICE_TSO_OFF;
        }
+      else if (unformat (input, "devargs %s", &devconf->devargs))
+       ;
+      else if (unformat (input, "rss-queues %U",
+                        unformat_bitmap_list, &devconf->rss_queues))
+       ;
       else
        {
          error = clib_error_return (0, "unknown input `%U'",
@@ -1252,65 +1236,101 @@ dpdk_device_config (dpdk_config_main_t * conf, vlib_pci_addr_t pci_addr,
   else if (devconf->workers &&
           clib_bitmap_count_set_bits (devconf->workers) !=
           devconf->num_rx_queues)
-    error =
-      clib_error_return (0,
-                        "%U: number of worker threadds must be "
-                        "equal to number of rx queues", format_vlib_pci_addr,
-                        &pci_addr);
+    error = clib_error_return (0,
+                              "%U: number of worker threads must be "
+                              "equal to number of rx queues",
+                              format_vlib_pci_addr, addr);
 
   return error;
 }
 
+static clib_error_t *
+dpdk_log_read_ready (clib_file_t * uf)
+{
+  unformat_input_t input;
+  u8 *line, *s = 0;
+  int n, n_try;
+
+  n = n_try = 4096;
+  while (n == n_try)
+    {
+      uword len = vec_len (s);
+      vec_resize (s, len + n_try);
+
+      n = read (uf->file_descriptor, s + len, n_try);
+      if (n < 0 && errno != EAGAIN)
+       return clib_error_return_unix (0, "read");
+      _vec_len (s) = len + (n < 0 ? 0 : n);
+    }
+
+  unformat_init_vector (&input, s);
+
+  while (unformat_user (&input, unformat_line, &line))
+    {
+      dpdk_log_notice ("%v", line);
+      vec_free (line);
+    }
+
+  unformat_free (&input);
+  return 0;
+}
+
 static clib_error_t *
 dpdk_config (vlib_main_t * vm, unformat_input_t * input)
 {
   clib_error_t *error = 0;
-  dpdk_main_t *dm = &dpdk_main;
   dpdk_config_main_t *conf = &dpdk_config_main;
   vlib_thread_main_t *tm = vlib_get_thread_main ();
   dpdk_device_config_t *devconf;
-  vlib_pci_addr_t pci_addr;
+  vlib_pci_addr_t pci_addr = { 0 };
+  vlib_vmbus_addr_t vmbus_addr = { 0 };
   unformat_input_t sub_input;
+  uword default_hugepage_sz, x;
   u8 *s, *tmp = 0;
-  u8 *rte_cmd = 0, *ethname = 0;
-  u32 log_level;
   int ret, i;
   int num_whitelisted = 0;
+  int eal_no_hugetlb = 0;
   u8 no_pci = 0;
-  u8 no_huge = 0;
-  u8 huge_dir = 0;
+  u8 no_vmbus = 0;
   u8 file_prefix = 0;
   u8 *socket_mem = 0;
+  u8 *huge_dir_path = 0;
+  u32 vendor, device, domain, bus, func;
+
+  huge_dir_path =
+    format (0, "%s/hugepages%c", vlib_unix_get_runtime_dir (), 0);
 
   conf->device_config_index_by_pci_addr = hash_create (0, sizeof (uword));
+  conf->device_config_index_by_vmbus_addr = hash_create (0, sizeof (uword));
 
   while (unformat_check_input (input) != UNFORMAT_END_OF_INPUT)
     {
       /* Prime the pump */
       if (unformat (input, "no-hugetlb"))
        {
-         vec_add1 (conf->eal_init_args, (u8 *) "no-huge");
-         no_huge = 1;
+         vec_add1 (conf->eal_init_args, (u8 *) "--no-huge");
+         eal_no_hugetlb = 1;
        }
+      else if (unformat (input, "telemetry"))
+       conf->enable_telemetry = 1;
 
       else if (unformat (input, "enable-tcp-udp-checksum"))
        conf->enable_tcp_udp_checksum = 1;
 
+      else if (unformat (input, "no-tx-checksum-offload"))
+       conf->no_tx_checksum_offload = 1;
+
       else if (unformat (input, "decimal-interface-names"))
        conf->interface_name_format_decimal = 1;
 
       else if (unformat (input, "no-multi-seg"))
        conf->no_multi_seg = 1;
 
-      else if (unformat (input, "enable-cryptodev"))
-       conf->cryptodev = 1;
-
       else if (unformat (input, "dev default %U", unformat_vlib_cli_sub_input,
                         &sub_input))
        {
          error =
-           dpdk_device_config (conf, (vlib_pci_addr_t) (u32) ~ 1, &sub_input,
-                               1);
+           dpdk_device_config (conf, 0, VNET_DEV_ADDR_ANY, &sub_input, 1);
 
          if (error)
            return error;
@@ -1320,7 +1340,8 @@ dpdk_config (vlib_main_t * vm, unformat_input_t * input)
            (input, "dev %U %U", unformat_vlib_pci_addr, &pci_addr,
             unformat_vlib_cli_sub_input, &sub_input))
        {
-         error = dpdk_device_config (conf, pci_addr, &sub_input, 0);
+         error = dpdk_device_config (conf, &pci_addr, VNET_DEV_ADDR_PCI,
+                                     &sub_input, 0);
 
          if (error)
            return error;
@@ -1329,16 +1350,40 @@ dpdk_config (vlib_main_t * vm, unformat_input_t * input)
        }
       else if (unformat (input, "dev %U", unformat_vlib_pci_addr, &pci_addr))
        {
-         error = dpdk_device_config (conf, pci_addr, 0, 0);
+         error =
+           dpdk_device_config (conf, &pci_addr, VNET_DEV_ADDR_PCI, 0, 0);
 
          if (error)
            return error;
 
          num_whitelisted++;
        }
-      else if (unformat (input, "num-mbufs %d", &conf->num_mbufs))
-       ;
-      else if (unformat (input, "kni %d", &conf->num_kni))
+      else if (unformat (input, "dev %U %U", unformat_vlib_vmbus_addr,
+                        &vmbus_addr, unformat_vlib_cli_sub_input, &sub_input))
+       {
+         error = dpdk_device_config (conf, &vmbus_addr, VNET_DEV_ADDR_VMBUS,
+                                     &sub_input, 0);
+
+         if (error)
+           return error;
+
+         num_whitelisted++;
+       }
+      else if (unformat (input, "dev %U", unformat_vlib_vmbus_addr,
+                        &vmbus_addr))
+       {
+         error =
+           dpdk_device_config (conf, &vmbus_addr, VNET_DEV_ADDR_VMBUS, 0, 0);
+
+         if (error)
+           return error;
+
+         num_whitelisted++;
+       }
+      else if (unformat (input, "num-mem-channels %d", &conf->nchannels))
+       conf->nchannels_set_manually = 0;
+      else if (unformat (input, "num-crypto-mbufs %d",
+                        &conf->num_crypto_mbufs))
        ;
       else if (unformat (input, "uio-driver %s", &conf->uio_driver_name))
        ;
@@ -1350,8 +1395,38 @@ dpdk_config (vlib_main_t * vm, unformat_input_t * input)
          tmp = format (0, "--no-pci%c", 0);
          vec_add1 (conf->eal_init_args, tmp);
        }
-      else if (unformat (input, "poll-sleep %d", &dm->poll_sleep))
-       ;
+      else if (unformat (input, "blacklist %U", unformat_vlib_vmbus_addr,
+                        &vmbus_addr))
+       {
+         vec_add1 (conf->blacklist_by_vmbus_addr, vmbus_addr.as_u32[0]);
+       }
+      else
+       if (unformat
+           (input, "blacklist %x:%x:%x.%x", &domain, &bus, &device, &func))
+       {
+         tmp = format (0, "-b%c", 0);
+         vec_add1 (conf->eal_init_args, tmp);
+         tmp =
+           format (0, "%04x:%02x:%02x.%x%c", domain, bus, device, func, 0);
+         vec_add1 (conf->eal_init_args, tmp);
+       }
+      else if (unformat (input, "blacklist %x:%x", &vendor, &device))
+       {
+         u32 blacklist_entry;
+         if (vendor > 0xFFFF)
+           return clib_error_return (0, "blacklist PCI vendor out of range");
+         if (device > 0xFFFF)
+           return clib_error_return (0, "blacklist PCI device out of range");
+         blacklist_entry = (vendor << 16) | (device & 0xffff);
+         vec_add1 (conf->blacklist_by_pci_vendor_and_device,
+                   blacklist_entry);
+       }
+      else if (unformat (input, "no-vmbus"))
+       {
+         no_vmbus = 1;
+         tmp = format (0, "--no-vmbus%c", 0);
+         vec_add1 (conf->eal_init_args, tmp);
+       }
 
 #define _(a)                                    \
       else if (unformat(input, #a))             \
@@ -1364,9 +1439,7 @@ dpdk_config (vlib_main_t * vm, unformat_input_t * input)
 #define _(a)                                          \
        else if (unformat(input, #a " %s", &s))       \
          {                                           \
-            if (!strncmp(#a, "huge-dir", 8))          \
-              huge_dir = 1;                           \
-            else if (!strncmp(#a, "file-prefix", 11)) \
+            if (!strncmp(#a, "file-prefix", 11)) \
               file_prefix = 1;                        \
            tmp = format (0, "--%s%c", #a, 0);        \
            vec_add1 (conf->eal_init_args, tmp);      \
@@ -1413,149 +1486,44 @@ dpdk_config (vlib_main_t * vm, unformat_input_t * input)
     }
 
   if (!conf->uio_driver_name)
-    conf->uio_driver_name = format (0, "uio_pci_generic%c", 0);
+    conf->uio_driver_name = format (0, "auto%c", 0);
 
-  /*
-   * Use 1G huge pages if available.
-   */
-  if (!no_huge && !huge_dir)
+  if (eal_no_hugetlb == 0)
     {
-      u32 x, *mem_by_socket = 0;
-      uword c = 0;
-      u8 use_1g = 1;
-      u8 use_2m = 1;
-      u8 less_than_1g = 1;
-      int rv;
-
-      umount (DEFAULT_HUGE_DIR);
-
-      /* Process "socket-mem" parameter value */
-      if (vec_len (socket_mem))
-       {
-         unformat_input_t in;
-         unformat_init_vector (&in, socket_mem);
-         while (unformat_check_input (&in) != UNFORMAT_END_OF_INPUT)
-           {
-             if (unformat (&in, "%u,", &x))
-               ;
-             else if (unformat (&in, "%u", &x))
-               ;
-             else if (unformat (&in, ","))
-               x = 0;
-             else
-               break;
+      vec_add1 (conf->eal_init_args, (u8 *) "--in-memory");
 
-             vec_add1 (mem_by_socket, x);
-
-             if (x > 1023)
-               less_than_1g = 0;
-           }
-         /* Note: unformat_free vec_frees(in.buffer), aka socket_mem... */
-         unformat_free (&in);
-         socket_mem = 0;
-       }
-      else
-       {
-         /* *INDENT-OFF* */
-         clib_bitmap_foreach (c, tm->cpu_socket_bitmap, (
-           {
-             vec_validate(mem_by_socket, c);
-             mem_by_socket[c] = 256; /* default per-socket mem */
-           }
-         ));
-         /* *INDENT-ON* */
-       }
+      default_hugepage_sz = clib_mem_get_default_hugepage_size ();
 
-      /* check if available enough 1GB pages for each socket */
       /* *INDENT-OFF* */
-      clib_bitmap_foreach (c, tm->cpu_socket_bitmap, (
-        {
-         int pages_avail, page_size, mem;
-
-         vec_validate(mem_by_socket, c);
-         mem = mem_by_socket[c];
-
-         page_size = 1024;
-         pages_avail = vlib_sysfs_get_free_hugepages(c, page_size * 1024);
-
-         if (pages_avail < 0 || page_size * pages_avail < mem)
-           use_1g = 0;
-
-         page_size = 2;
-         pages_avail = vlib_sysfs_get_free_hugepages(c, page_size * 1024);
-
-         if (pages_avail < 0 || page_size * pages_avail < mem)
-           use_2m = 0;
-      }));
-      /* *INDENT-ON* */
-
-      if (mem_by_socket == 0)
-       {
-         error = clib_error_return (0, "mem_by_socket NULL");
-         goto done;
-       }
-      _vec_len (mem_by_socket) = c + 1;
-
-      /* regenerate socket_mem string */
-      vec_foreach_index (x, mem_by_socket)
-       socket_mem = format (socket_mem, "%s%u",
-                            socket_mem ? "," : "", mem_by_socket[x]);
-      socket_mem = format (socket_mem, "%c", 0);
-
-      vec_free (mem_by_socket);
-
-      rv = mkdir (VPP_RUN_DIR, 0755);
-      if (rv && errno != EEXIST)
-       {
-         error = clib_error_return (0, "mkdir '%s' failed errno %d",
-                                    VPP_RUN_DIR, errno);
-         goto done;
-       }
-
-      rv = mkdir (DEFAULT_HUGE_DIR, 0755);
-      if (rv && errno != EEXIST)
-       {
-         error = clib_error_return (0, "mkdir '%s' failed errno %d",
-                                    DEFAULT_HUGE_DIR, errno);
-         goto done;
-       }
-
-      if (use_1g && !(less_than_1g && use_2m))
-       {
-         rv =
-           mount ("none", DEFAULT_HUGE_DIR, "hugetlbfs", 0, "pagesize=1G");
-       }
-      else if (use_2m)
+      clib_bitmap_foreach (x, tm->cpu_socket_bitmap)
        {
-         rv = mount ("none", DEFAULT_HUGE_DIR, "hugetlbfs", 0, NULL);
-       }
-      else
-       {
-         return clib_error_return (0, "not enough free huge pages");
-       }
+         clib_error_t *e;
+         uword n_pages;
+         /* preallocate at least 16MB of hugepages per socket,
+           if more is needed it is up to consumer to preallocate more */
+         n_pages = round_pow2 ((uword) 16 << 20, default_hugepage_sz);
+         n_pages /= default_hugepage_sz;
+
+         if ((e = clib_sysfs_prealloc_hugepages(x, 0, n_pages)))
+           clib_error_report (e);
+        }
+      /* *INDENT-ON* */
+    }
 
-      if (rv)
-       {
-         error = clib_error_return (0, "mount failed %d", errno);
-         goto done;
-       }
+  /* on/off dpdk's telemetry thread */
+  if (conf->enable_telemetry == 0)
+    {
+      vec_add1 (conf->eal_init_args, (u8 *) "--no-telemetry");
+    }
 
-      tmp = format (0, "--huge-dir%c", 0);
+  if (!file_prefix)
+    {
+      tmp = format (0, "--file-prefix%c", 0);
       vec_add1 (conf->eal_init_args, tmp);
-      tmp = format (0, "%s%c", DEFAULT_HUGE_DIR, 0);
+      tmp = format (0, "vpp%c", 0);
       vec_add1 (conf->eal_init_args, tmp);
-      if (!file_prefix)
-       {
-         tmp = format (0, "--file-prefix%c", 0);
-         vec_add1 (conf->eal_init_args, tmp);
-         tmp = format (0, "vpp%c", 0);
-         vec_add1 (conf->eal_init_args, tmp);
-       }
     }
 
-  vec_free (rte_cmd);
-  vec_free (ethname);
-
   if (error)
     return error;
 
@@ -1587,53 +1555,76 @@ dpdk_config (vlib_main_t * vm, unformat_input_t * input)
       vec_insert (conf->eal_init_args, 2, 3);
       conf->eal_init_args[3] = (u8 *) "-n";
       tmp = format (0, "%d", conf->nchannels);
+      vec_terminate_c_string (tmp);
       conf->eal_init_args[4] = tmp;
     }
 
   if (no_pci == 0 && geteuid () == 0)
     dpdk_bind_devices_to_uio (conf);
 
+  if (no_vmbus == 0 && geteuid () == 0)
+    dpdk_bind_vmbus_devices_to_uio (conf);
+
 #define _(x) \
     if (devconf->x == 0 && conf->default_devconf.x > 0) \
       devconf->x = conf->default_devconf.x ;
 
   /* *INDENT-OFF* */
-  pool_foreach (devconf, conf->dev_confs, ({
+  pool_foreach (devconf, conf->dev_confs)  {
 
     /* default per-device config items */
     foreach_dpdk_device_config_item
 
-    /* add DPDK EAL whitelist/blacklist entry */
-    if (num_whitelisted > 0 && devconf->is_blacklisted == 0)
-      {
-       tmp = format (0, "-w%c", 0);
-       vec_add1 (conf->eal_init_args, tmp);
-       tmp = format (0, "%U%c", format_vlib_pci_addr, &devconf->pci_addr, 0);
-       vec_add1 (conf->eal_init_args, tmp);
-      }
-    else if (num_whitelisted == 0 && devconf->is_blacklisted != 0)
-      {
-       tmp = format (0, "-b%c", 0);
-       vec_add1 (conf->eal_init_args, tmp);
-       tmp = format (0, "%U%c", format_vlib_pci_addr, &devconf->pci_addr, 0);
-       vec_add1 (conf->eal_init_args, tmp);
-      }
-  }));
+      /* copy vlan_strip config from default device */
+      _ (vlan_strip_offload)
+
+      /* copy tso config from default device */
+      _ (tso)
+
+      /* copy tso config from default device */
+      _ (devargs)
+
+      /* copy rss_queues config from default device */
+      _ (rss_queues)
+
+      /* add DPDK EAL whitelist/blacklist entry */
+      if (num_whitelisted > 0 && devconf->is_blacklisted == 0 &&
+         devconf->dev_addr_type == VNET_DEV_ADDR_PCI)
+    {
+         tmp = format (0, "-a%c", 0);
+         vec_add1 (conf->eal_init_args, tmp);
+         if (devconf->devargs)
+         {
+           tmp = format (0, "%U,%s", format_vlib_pci_addr, &devconf->pci_addr, devconf->devargs, 0);
+         }
+         else
+         {
+           tmp = format (0, "%U%c", format_vlib_pci_addr, &devconf->pci_addr, 0);
+         }
+         vec_add1 (conf->eal_init_args, tmp);
+    }
+    else if (num_whitelisted == 0 && devconf->is_blacklisted != 0 &&
+            devconf->dev_addr_type == VNET_DEV_ADDR_PCI)
+    {
+         tmp = format (0, "-b%c", 0);
+         vec_add1 (conf->eal_init_args, tmp);
+         tmp = format (0, "%U%c", format_vlib_pci_addr, &devconf->pci_addr, 0);
+         vec_add1 (conf->eal_init_args, tmp);
+    }
+  }
   /* *INDENT-ON* */
 
 #undef _
 
   /* set master-lcore */
-  tmp = format (0, "--master-lcore%c", 0);
+  tmp = format (0, "--main-lcore%c", 0);
   vec_add1 (conf->eal_init_args, tmp);
   tmp = format (0, "%u%c", tm->main_lcore, 0);
   vec_add1 (conf->eal_init_args, tmp);
 
-  /* set socket-mem */
-  tmp = format (0, "--socket-mem%c", 0);
-  vec_add1 (conf->eal_init_args, tmp);
-  tmp = format (0, "%s%c", socket_mem, 0);
-  vec_add1 (conf->eal_init_args, tmp);
+
+  if (socket_mem)
+    clib_warning ("socket-mem argument is deprecated");
 
   /* NULL terminate the "argv" vector, in case of stupidity */
   vec_add1 (conf->eal_init_args, 0);
@@ -1641,9 +1632,27 @@ dpdk_config (vlib_main_t * vm, unformat_input_t * input)
 
   /* Set up DPDK eal and packet mbuf pool early. */
 
-  log_level = (CLIB_DEBUG > 0) ? RTE_LOG_DEBUG : RTE_LOG_NOTICE;
-
-  rte_set_log_level (log_level);
+  int log_fds[2] = { 0 };
+  if (pipe (log_fds) == 0)
+    {
+      if (fcntl (log_fds[1], F_SETFL, O_NONBLOCK) == 0)
+       {
+         FILE *f = fdopen (log_fds[1], "a");
+         if (f && rte_openlog_stream (f) == 0)
+           {
+             clib_file_t t = { 0 };
+             t.read_function = dpdk_log_read_ready;
+             t.file_descriptor = log_fds[0];
+             t.description = format (0, "DPDK logging pipe");
+             clib_file_add (&file_main, &t);
+           }
+       }
+      else
+       {
+         close (log_fds[0]);
+         close (log_fds[1]);
+       }
+    }
 
   vm = vlib_get_main ();
 
@@ -1652,33 +1661,24 @@ dpdk_config (vlib_main_t * vm, unformat_input_t * input)
     conf->eal_init_args_str = format (conf->eal_init_args_str, "%s ",
                                      conf->eal_init_args[i]);
 
-  ret =
-    rte_eal_init (vec_len (conf->eal_init_args),
-                 (char **) conf->eal_init_args);
+  vec_terminate_c_string (conf->eal_init_args_str);
+
+  dpdk_log_notice ("EAL init args: %s", conf->eal_init_args_str);
+  ret = rte_eal_init (vec_len (conf->eal_init_args),
+                     (char **) conf->eal_init_args);
 
   /* lazy umount hugepages */
-  umount2 (DEFAULT_HUGE_DIR, MNT_DETACH);
+  umount2 ((char *) huge_dir_path, MNT_DETACH);
+  rmdir ((char *) huge_dir_path);
+  vec_free (huge_dir_path);
 
   if (ret < 0)
     return clib_error_return (0, "rte_eal_init returned %d", ret);
 
-  /* Dump the physical memory layout prior to creating the mbuf_pool */
-  fprintf (stdout, "DPDK physical memory layout:\n");
-  rte_dump_physmem_layout (stdout);
-
   /* main thread 1st */
-  error = vlib_buffer_pool_create (vm, conf->num_mbufs, rte_socket_id ());
-  if (error)
+  if ((error = dpdk_buffer_pools_create (vm)))
     return error;
 
-  for (i = 0; i < RTE_MAX_LCORE; i++)
-    {
-      error = vlib_buffer_pool_create (vm, conf->num_mbufs,
-                                      rte_lcore_to_socket_id (i));
-      if (error)
-       return error;
-    }
-
 done:
   return error;
 }
@@ -1698,8 +1698,8 @@ dpdk_update_link_state (dpdk_device_t * xd, f64 now)
     return;
 
   xd->time_last_link_update = now ? now : xd->time_last_link_update;
-  memset (&xd->link, 0, sizeof (xd->link));
-  rte_eth_link_get_nowait (xd->device_index, &xd->link);
+  clib_memset (&xd->link, 0, sizeof (xd->link));
+  rte_eth_link_get_nowait (xd->port_id, &xd->link);
 
   if (LINK_STATE_ELOGS)
     {
@@ -1718,22 +1718,14 @@ dpdk_update_link_state (dpdk_device_t * xd, f64 now)
        u8 new_link_state;
       } *ed;
       ed = ELOG_DATA (&vm->elog_main, e);
-      ed->sw_if_index = xd->vlib_sw_if_index;
+      ed->sw_if_index = xd->sw_if_index;
       ed->admin_up = (xd->flags & DPDK_DEVICE_FLAG_ADMIN_UP) != 0;
       ed->old_link_state = (u8)
-       vnet_hw_interface_is_link_up (vnm, xd->vlib_hw_if_index);
+       vnet_hw_interface_is_link_up (vnm, xd->hw_if_index);
       ed->new_link_state = (u8) xd->link.link_status;
     }
 
-  if ((xd->flags & DPDK_DEVICE_FLAG_ADMIN_UP) &&
-      ((xd->link.link_status != 0) ^
-       vnet_hw_interface_is_link_up (vnm, xd->vlib_hw_if_index)))
-    {
-      hw_flags_chg = 1;
-      hw_flags |= (xd->link.link_status ? VNET_HW_INTERFACE_FLAG_LINK_UP : 0);
-    }
-
-  if (hw_flags_chg || (xd->link.link_duplex != prev_link.link_duplex))
+  if ((xd->link.link_duplex != prev_link.link_duplex))
     {
       hw_flags_chg = 1;
       switch (xd->link.link_duplex)
@@ -1748,33 +1740,18 @@ dpdk_update_link_state (dpdk_device_t * xd, f64 now)
          break;
        }
     }
-  if (hw_flags_chg || (xd->link.link_speed != prev_link.link_speed))
+  if (xd->link.link_speed != prev_link.link_speed)
+    vnet_hw_interface_set_link_speed (vnm, xd->hw_if_index,
+                                     xd->link.link_speed * 1000);
+
+  if (xd->link.link_status != prev_link.link_status)
     {
       hw_flags_chg = 1;
-      switch (xd->link.link_speed)
-       {
-       case ETH_SPEED_NUM_10M:
-         hw_flags |= VNET_HW_INTERFACE_FLAG_SPEED_10M;
-         break;
-       case ETH_SPEED_NUM_100M:
-         hw_flags |= VNET_HW_INTERFACE_FLAG_SPEED_100M;
-         break;
-       case ETH_SPEED_NUM_1G:
-         hw_flags |= VNET_HW_INTERFACE_FLAG_SPEED_1G;
-         break;
-       case ETH_SPEED_NUM_10G:
-         hw_flags |= VNET_HW_INTERFACE_FLAG_SPEED_10G;
-         break;
-       case ETH_SPEED_NUM_40G:
-         hw_flags |= VNET_HW_INTERFACE_FLAG_SPEED_40G;
-         break;
-       case 0:
-         break;
-       default:
-         clib_warning ("unknown link speed %d", xd->link.link_speed);
-         break;
-       }
+
+      if (xd->link.link_status)
+       hw_flags |= VNET_HW_INTERFACE_FLAG_LINK_UP;
     }
+
   if (hw_flags_chg)
     {
       if (LINK_STATE_ELOGS)
@@ -1793,10 +1770,10 @@ dpdk_update_link_state (dpdk_device_t * xd, f64 now)
            u32 flags;
          } *ed;
          ed = ELOG_DATA (&vm->elog_main, e);
-         ed->sw_if_index = xd->vlib_sw_if_index;
+         ed->sw_if_index = xd->sw_if_index;
          ed->flags = hw_flags;
        }
-      vnet_hw_interface_set_flags (vnm, xd->vlib_hw_if_index, hw_flags);
+      vnet_hw_interface_set_flags (vnm, xd->hw_if_index, hw_flags);
     }
 }
 
@@ -1804,35 +1781,22 @@ static uword
 dpdk_process (vlib_main_t * vm, vlib_node_runtime_t * rt, vlib_frame_t * f)
 {
   clib_error_t *error;
-  vnet_main_t *vnm = vnet_get_main ();
   dpdk_main_t *dm = &dpdk_main;
-  ethernet_main_t *em = &ethernet_main;
   dpdk_device_t *xd;
   vlib_thread_main_t *tm = vlib_get_thread_main ();
-  int i;
 
   error = dpdk_lib_init (dm);
 
-  /*
-   * Turn on the input node if we found some devices to drive
-   * and we're not running worker threads or i/o threads
-   */
+  if (error)
+    clib_error_report (error);
 
-  if (error == 0 && vec_len (dm->devices) > 0)
+  error = dpdk_cryptodev_init (vm);
+  if (error)
     {
-      if (tm->n_vlib_mains == 1)
-       vlib_node_set_state (vm, dpdk_input_node.index,
-                            VLIB_NODE_STATE_POLLING);
-      else
-       for (i = 0; i < tm->n_vlib_mains; i++)
-         if (vec_len (dm->devices_by_cpu[i]) > 0)
-           vlib_node_set_state (vlib_mains[i], dpdk_input_node.index,
-                                VLIB_NODE_STATE_POLLING);
+      vlib_log_warn (dpdk_main.log_cryptodev, "%U", format_clib_error, error);
+      clib_error_free (error);
     }
 
-  if (error)
-    clib_error_report (error);
-
   tm->worker_thread_release = 1;
 
   f64 now = vlib_time_now (vm);
@@ -1841,99 +1805,6 @@ dpdk_process (vlib_main_t * vm, vlib_node_runtime_t * rt, vlib_frame_t * f)
     dpdk_update_link_state (xd, now);
   }
 
-  {
-    /*
-     * Extra set up for bond interfaces:
-     *  1. Setup MACs for bond interfaces and their slave links which was set
-     *     in dpdk_port_setup() but needs to be done again here to take effect.
-     *  2. Set up info for bond interface related CLI support.
-     */
-    int nports = rte_eth_dev_count ();
-    if (nports > 0)
-      {
-       for (i = 0; i < nports; i++)
-         {
-           struct rte_eth_dev_info dev_info;
-           rte_eth_dev_info_get (i, &dev_info);
-           if (!dev_info.driver_name)
-             dev_info.driver_name = dev_info.pci_dev->driver->driver.name;
-
-           ASSERT (dev_info.driver_name);
-           if (strncmp (dev_info.driver_name, "rte_bond_pmd", 12) == 0)
-             {
-               u8 addr[6];
-               u8 slink[16];
-               int nlink = rte_eth_bond_slaves_get (i, slink, 16);
-               if (nlink > 0)
-                 {
-                   vnet_hw_interface_t *bhi;
-                   ethernet_interface_t *bei;
-                   int rv;
-
-                   /* Get MAC of 1st slave link */
-                   rte_eth_macaddr_get (slink[0],
-                                        (struct ether_addr *) addr);
-                   /* Set MAC of bounded interface to that of 1st slave link */
-                   rv =
-                     rte_eth_bond_mac_address_set (i,
-                                                   (struct ether_addr *)
-                                                   addr);
-                   if (rv < 0)
-                     clib_warning ("Failed to set MAC address");
-
-                   /* Populate MAC of bonded interface in VPP hw tables */
-                   bhi =
-                     vnet_get_hw_interface (vnm,
-                                            dm->devices[i].vlib_hw_if_index);
-                   bei =
-                     pool_elt_at_index (em->interfaces, bhi->hw_instance);
-                   clib_memcpy (bhi->hw_address, addr, 6);
-                   clib_memcpy (bei->address, addr, 6);
-                   /* Init l3 packet size allowed on bonded interface */
-                   bhi->max_packet_bytes = ETHERNET_MAX_PACKET_BYTES;
-                   bhi->max_l3_packet_bytes[VLIB_RX] =
-                     bhi->max_l3_packet_bytes[VLIB_TX] =
-                     ETHERNET_MAX_PACKET_BYTES - sizeof (ethernet_header_t);
-                   while (nlink >= 1)
-                     {         /* for all slave links */
-                       int slave = slink[--nlink];
-                       dpdk_device_t *sdev = &dm->devices[slave];
-                       vnet_hw_interface_t *shi;
-                       vnet_sw_interface_t *ssi;
-                       /* Add MAC to all slave links except the first one */
-                       if (nlink)
-                         rte_eth_dev_mac_addr_add (slave,
-                                                   (struct ether_addr *)
-                                                   addr, 0);
-                       /* Set slaves bitmap for bonded interface */
-                       bhi->bond_info =
-                         clib_bitmap_set (bhi->bond_info,
-                                          sdev->vlib_hw_if_index, 1);
-                       /* Set slave link flags on slave interface */
-                       shi =
-                         vnet_get_hw_interface (vnm, sdev->vlib_hw_if_index);
-                       ssi =
-                         vnet_get_sw_interface (vnm, sdev->vlib_sw_if_index);
-                       shi->bond_info = VNET_HW_INTERFACE_BOND_INFO_SLAVE;
-                       ssi->flags |= VNET_SW_INTERFACE_FLAG_BOND_SLAVE;
-
-                       /* Set l3 packet size allowed as the lowest of slave */
-                       if (bhi->max_l3_packet_bytes[VLIB_RX] >
-                           shi->max_l3_packet_bytes[VLIB_RX])
-                         bhi->max_l3_packet_bytes[VLIB_RX] =
-                           bhi->max_l3_packet_bytes[VLIB_TX] =
-                           shi->max_l3_packet_bytes[VLIB_RX];
-
-                       /* Set max packet size allowed as the lowest of slave */
-                       if (bhi->max_packet_bytes > shi->max_packet_bytes)
-                         bhi->max_packet_bytes = shi->max_packet_bytes;
-                     }
-                 }
-             }
-         }
-      }
-  }
-
   while (1)
     {
       /*
@@ -1971,35 +1842,11 @@ VLIB_REGISTER_NODE (dpdk_process_node,static) = {
 };
 /* *INDENT-ON* */
 
-int
-dpdk_set_stat_poll_interval (f64 interval)
-{
-  if (interval < DPDK_MIN_STATS_POLL_INTERVAL)
-    return (VNET_API_ERROR_INVALID_VALUE);
-
-  dpdk_main.stat_poll_interval = interval;
-
-  return 0;
-}
-
-int
-dpdk_set_link_state_poll_interval (f64 interval)
-{
-  if (interval < DPDK_MIN_LINK_POLL_INTERVAL)
-    return (VNET_API_ERROR_INVALID_VALUE);
-
-  dpdk_main.link_state_poll_interval = interval;
-
-  return 0;
-}
-
-clib_error_t *
+static clib_error_t *
 dpdk_init (vlib_main_t * vm)
 {
   dpdk_main_t *dm = &dpdk_main;
-  vlib_node_t *ei;
   clib_error_t *error = 0;
-  vlib_thread_main_t *tm = vlib_get_thread_main ();
 
   /* verify that structs are cacheline aligned */
   STATIC_ASSERT (offsetof (dpdk_device_t, cacheline0) == 0,
@@ -2009,62 +1856,36 @@ dpdk_init (vlib_main_t * vm)
                 "Data in cache line 0 is bigger than cache line size");
   STATIC_ASSERT (offsetof (frame_queue_trace_t, cacheline0) == 0,
                 "Cache line marker must be 1st element in frame_queue_trace_t");
+  STATIC_ASSERT (RTE_CACHE_LINE_SIZE == 1 << CLIB_LOG2_CACHE_LINE_BYTES,
+                "DPDK RTE CACHE LINE SIZE does not match with 1<<CLIB_LOG2_CACHE_LINE_BYTES");
 
-  u8 *name;
-  name = format (0, "dpdk_%08x%c", api_version, 0);
-
-  /* Ask for a correctly-sized block of API message decode slots */
-  dm->msg_id_base = vl_msg_api_get_msg_ids
-    ((char *) name, VL_MSG_FIRST_AVAILABLE);
-  vec_free (name);
+  dpdk_cli_reference ();
 
   dm->vlib_main = vm;
   dm->vnet_main = vnet_get_main ();
   dm->conf = &dpdk_config_main;
 
-  error = dpdk_plugin_api_hookup (vm);
-
-  /* Add our API messages to the global name_crc hash table */
-  setup_message_id_table (dm, &api_main);
-
-//  TODO
-//  plugin_custom_dump_configure (dm);
-
-  ei = vlib_get_node_by_name (vm, (u8 *) "ethernet-input");
-  if (ei == 0)
-    return clib_error_return (0, "ethernet-input node AWOL");
-
-  dm->ethernet_input_node_index = ei->index;
-
   dm->conf->nchannels = 4;
-  dm->conf->num_mbufs = dm->conf->num_mbufs ? dm->conf->num_mbufs : NB_MBUF;
   vec_add1 (dm->conf->eal_init_args, (u8 *) "vnet");
 
-  dm->dpdk_device_by_kni_port_id = hash_create (0, sizeof (uword));
-  dm->vu_sw_if_index_by_listener_fd = hash_create (0, sizeof (uword));
-  dm->vu_sw_if_index_by_sock_fd = hash_create (0, sizeof (uword));
-
-  /* $$$ use n_thread_stacks since it's known-good at this point */
-  vec_validate (dm->recycle, tm->n_thread_stacks - 1);
-
   /* Default vlib_buffer_t flags, DISABLES tcp/udp checksumming... */
-  dm->buffer_flags_template =
-    (VLIB_BUFFER_TOTAL_LENGTH_VALID | VLIB_BUFFER_EXT_HDR_VALID
-     | IP_BUFFER_L4_CHECKSUM_COMPUTED | IP_BUFFER_L4_CHECKSUM_CORRECT);
+  dm->buffer_flags_template = (VLIB_BUFFER_TOTAL_LENGTH_VALID |
+                              VLIB_BUFFER_EXT_HDR_VALID |
+                              VNET_BUFFER_F_L4_CHECKSUM_COMPUTED |
+                              VNET_BUFFER_F_L4_CHECKSUM_CORRECT);
 
   dm->stat_poll_interval = DPDK_STATS_POLL_INTERVAL;
   dm->link_state_poll_interval = DPDK_LINK_POLL_INTERVAL;
 
-  /* init CLI */
-  if ((error = vlib_call_init_function (vm, dpdk_cli_init)))
-    return error;
+  dm->log_default = vlib_log_register_class ("dpdk", 0);
+  dm->log_cryptodev = vlib_log_register_class ("dpdk", "cryptodev");
+  dm->log_ipsec = vlib_log_register_class ("dpdk", "ipsec");
 
   return error;
 }
 
 VLIB_INIT_FUNCTION (dpdk_init);
 
-
 /*
  * fd.io coding-style-patch-verification: ON
  *