GBP: L3 out fixes
[vpp.git] / src / plugins / gbp / gbp_vxlan.c
index c7be90f..286345e 100644 (file)
@@ -18,7 +18,6 @@
 #include <plugins/gbp/gbp_learn.h>
 #include <plugins/gbp/gbp_bridge_domain.h>
 #include <plugins/gbp/gbp_route_domain.h>
-#include <plugins/gbp/gbp_sclass.h>
 
 #include <vnet/vxlan-gbp/vxlan_gbp.h>
 #include <vlibmemory/api.h>
@@ -79,7 +78,7 @@ static char *gbp_vxlan_tunnel_layer_strings[] = {
 
 
 
-always_inline gbp_vxlan_tunnel_t *
+gbp_vxlan_tunnel_t *
 gbp_vxlan_tunnel_get (index_t gti)
 {
   return (pool_elt_at_index (gbp_vxlan_tunnel_pool, gti));
@@ -169,9 +168,8 @@ gdb_vxlan_dep_add (gbp_vxlan_tunnel_t * gt,
          vxr->vxr_itf = gbp_itf_add_and_lock (vxr->vxr_sw_if_index,
                                               gt->gt_bd_index);
 
-         ofeat = (L2OUTPUT_FEAT_GBP_POLICY_MAC |
-                  L2OUTPUT_FEAT_GBP_ID_2_SCLASS);
-         ifeat = L2INPUT_FEAT_GBP_SCLASS_2_ID;
+         ofeat = L2OUTPUT_FEAT_GBP_POLICY_MAC;
+         ifeat = L2INPUT_FEAT_NONE;
 
          if (!(gbd->gb_flags & GBP_BD_FLAG_DO_NOT_LEARN))
            ifeat |= L2INPUT_FEAT_GBP_LEARN;
@@ -193,7 +191,6 @@ gdb_vxlan_dep_add (gbp_vxlan_tunnel_t * gt,
                           grd->grd_table_id[fproto], 1);
 
          gbp_learn_enable (vxr->vxr_sw_if_index, GBP_LEARN_MODE_L3);
-         gbp_sclass_enable_ip (vxr->vxr_sw_if_index);
        }
     }
 
@@ -283,7 +280,6 @@ gdb_vxlan_dep_del (index_t vxri)
 
       FOR_EACH_FIB_IP_PROTOCOL (fproto)
        ip_table_bind (fproto, vxr->vxr_sw_if_index, 0, 0);
-      gbp_sclass_disable_ip (vxr->vxr_sw_if_index);
       gbp_learn_disable (vxr->vxr_sw_if_index, GBP_LEARN_MODE_L3);
     }
 
@@ -325,194 +321,6 @@ vxlan_gbp_tunnel_lock (u32 sw_if_index)
   vxr->vxr_locks++;
 }
 
-#define foreach_gbp_vxlan_input_next         \
-  _(DROP, "error-drop")                      \
-  _(L2_INPUT, "l2-input")                    \
-  _(IP4_INPUT, "ip4-input")                  \
-  _(IP6_INPUT, "ip6-input")
-
-typedef enum
-{
-#define _(s,n) GBP_VXLAN_INPUT_NEXT_##s,
-  foreach_gbp_vxlan_input_next
-#undef _
-    GBP_VXLAN_INPUT_N_NEXT,
-} gbp_vxlan_input_next_t;
-
-#define foreach_gbp_vxlan_error              \
-  _(DECAPPED, "decapped")                    \
-  _(LEARNED, "learned")
-
-typedef enum
-{
-#define _(s,n) GBP_VXLAN_ERROR_##s,
-  foreach_gbp_vxlan_error
-#undef _
-    GBP_VXLAN_N_ERROR,
-} gbp_vxlan_input_error_t;
-
-static char *gbp_vxlan_error_strings[] = {
-#define _(n,s) s,
-  foreach_gbp_vxlan_error
-#undef _
-};
-
-typedef struct gbp_vxlan_trace_t_
-{
-  u8 dropped;
-  u32 vni;
-  u32 sw_if_index;
-  u16 sclass;
-  u8 flags;
-} gbp_vxlan_trace_t;
-
-
-static uword
-gbp_vxlan_decap (vlib_main_t * vm,
-                vlib_node_runtime_t * node,
-                vlib_frame_t * from_frame, u8 is_ip4)
-{
-  u32 n_left_to_next, n_left_from, next_index, *to_next, *from;
-
-  next_index = 0;
-  from = vlib_frame_vector_args (from_frame);
-  n_left_from = from_frame->n_vectors;
-
-  while (n_left_from > 0)
-    {
-
-      vlib_get_next_frame (vm, node, next_index, to_next, n_left_to_next);
-
-      while (n_left_from > 0 && n_left_to_next > 0)
-       {
-         vxlan_gbp_header_t *vxlan_gbp0;
-         gbp_vxlan_input_next_t next0;
-         gbp_vxlan_tunnel_t *gt0;
-         vlib_buffer_t *b0;
-         u32 bi0, vni0;
-         uword *p;
-
-         bi0 = to_next[0] = from[0];
-         from += 1;
-         to_next += 1;
-         n_left_from -= 1;
-         n_left_to_next -= 1;
-         next0 = GBP_VXLAN_INPUT_NEXT_DROP;
-
-         b0 = vlib_get_buffer (vm, bi0);
-         vxlan_gbp0 =
-           vlib_buffer_get_current (b0) - sizeof (vxlan_gbp_header_t);
-
-         vni0 = vxlan_gbp_get_vni (vxlan_gbp0);
-         p = hash_get (gv_db, vni0);
-
-         if (PREDICT_FALSE (NULL == p))
-           {
-             gt0 = NULL;
-             next0 = GBP_VXLAN_INPUT_NEXT_DROP;
-           }
-         else
-           {
-             gt0 = gbp_vxlan_tunnel_get (p[0]);
-
-             vnet_buffer (b0)->sw_if_index[VLIB_RX] = gt0->gt_sw_if_index;
-
-             if (GBP_VXLAN_TUN_L2 == gt0->gt_layer)
-               /*
-                * An L2 layer tunnel goes into the BD
-                */
-               next0 = GBP_VXLAN_INPUT_NEXT_L2_INPUT;
-             else
-               {
-                 /*
-                  * An L3 layer tunnel needs to strip the L2 header
-                  * an inject into the RD
-                  */
-                 ethernet_header_t *e0;
-                 u16 type0;
-
-                 e0 = vlib_buffer_get_current (b0);
-                 type0 = clib_net_to_host_u16 (e0->type);
-                 switch (type0)
-                   {
-                   case ETHERNET_TYPE_IP4:
-                     next0 = GBP_VXLAN_INPUT_NEXT_IP4_INPUT;
-                     break;
-                   case ETHERNET_TYPE_IP6:
-                     next0 = GBP_VXLAN_INPUT_NEXT_IP6_INPUT;
-                     break;
-                   default:
-                     goto trace;
-                   }
-                 vlib_buffer_advance (b0, sizeof (*e0));
-               }
-           }
-
-       trace:
-         if (PREDICT_FALSE (b0->flags & VLIB_BUFFER_IS_TRACED))
-           {
-             gbp_vxlan_trace_t *tr;
-
-             tr = vlib_add_trace (vm, node, b0, sizeof (*tr));
-             tr->dropped = (next0 == GBP_VXLAN_INPUT_NEXT_DROP);
-             tr->vni = vni0;
-             tr->sw_if_index = (gt0 ? gt0->gt_sw_if_index : ~0);
-             tr->flags = vxlan_gbp_get_gpflags (vxlan_gbp0);
-             tr->sclass = vxlan_gbp_get_sclass (vxlan_gbp0);
-           }
-
-         vlib_validate_buffer_enqueue_x1 (vm, node, next_index,
-                                          to_next, n_left_to_next,
-                                          bi0, next0);
-       }
-
-      vlib_put_next_frame (vm, node, next_index, n_left_to_next);
-    }
-
-  return from_frame->n_vectors;
-}
-
-static u8 *
-format_gbp_vxlan_rx_trace (u8 * s, va_list * args)
-{
-  CLIB_UNUSED (vlib_main_t * vm) = va_arg (*args, vlib_main_t *);
-  CLIB_UNUSED (vlib_node_t * node) = va_arg (*args, vlib_node_t *);
-  gbp_vxlan_trace_t *t = va_arg (*args, gbp_vxlan_trace_t *);
-
-  s = format (s, "vni:%d dropped:%d rx:%d sclass:%d flags:%U",
-             t->vni, t->dropped, t->sw_if_index,
-             t->sclass, format_vxlan_gbp_header_gpflags, t->flags);
-
-  return (s);
-}
-
-static uword
-gbp_vxlan4_decap (vlib_main_t * vm,
-                 vlib_node_runtime_t * node, vlib_frame_t * from_frame)
-{
-  return gbp_vxlan_decap (vm, node, from_frame, 1);
-}
-
-/* *INDENT-OFF* */
-VLIB_REGISTER_NODE (gbp_vxlan4_input_node) =
-{
-  .function = gbp_vxlan4_decap,
-  .name = "gbp-vxlan4",
-  .vector_size = sizeof (u32),
-  .n_errors = GBP_VXLAN_N_ERROR,
-  .error_strings = gbp_vxlan_error_strings,
-  .n_next_nodes = GBP_VXLAN_INPUT_N_NEXT,
-  .format_trace = format_gbp_vxlan_rx_trace,
-  .next_nodes = {
-#define _(s,n) [GBP_VXLAN_INPUT_NEXT_##s] = n,
-    foreach_gbp_vxlan_input_next
-#undef _
-  },
-};
-VLIB_NODE_FUNCTION_MULTIARCH (gbp_vxlan4_input_node, gbp_vxlan4_decap)
-
-/* *INDENT-ON* */
-
 void
 gbp_vxlan_walk (gbp_vxlan_cb_t cb, void *ctx)
 {
@@ -653,7 +461,8 @@ VNET_HW_INTERFACE_CLASS (gbp_vxlan_hw_interface_class) = {
 
 int
 gbp_vxlan_tunnel_add (u32 vni, gbp_vxlan_tunnel_layer_t layer,
-                     u32 bd_rd_id, u32 * sw_if_indexp)
+                     u32 bd_rd_id,
+                     const ip4_address_t * src, u32 * sw_if_indexp)
 {
   gbp_vxlan_tunnel_t *gt;
   index_t gti;
@@ -700,6 +509,7 @@ gbp_vxlan_tunnel_add (u32 vni, gbp_vxlan_tunnel_layer_t layer,
       gt->gt_vni = vni;
       gt->gt_layer = layer;
       gt->gt_bd_rd_id = bd_rd_id;
+      gt->gt_src.ip4.as_u32 = src->as_u32;
       gt->gt_hw_if_index = vnet_register_interface (vnm,
                                                    gbp_vxlan_device_class.index,
                                                    gti,
@@ -722,12 +532,11 @@ gbp_vxlan_tunnel_add (u32 vni, gbp_vxlan_tunnel_layer_t layer,
 
          gt->gt_gbd = gbi;
          gt->gt_bd_index = gb->gb_bd_index;
-         gb->gb_vni_sw_if_index = gt->gt_sw_if_index;
+         gb->gb_vni = gti;
          /* set it up as a GBP interface */
          gt->gt_itf = gbp_itf_add_and_lock (gt->gt_sw_if_index,
                                             gt->gt_bd_index);
          gbp_learn_enable (gt->gt_sw_if_index, GBP_LEARN_MODE_L2);
-         gbp_sclass_enable_l2 (gt->gt_sw_if_index);
        }
       else
        {
@@ -740,7 +549,6 @@ gbp_vxlan_tunnel_add (u32 vni, gbp_vxlan_tunnel_layer_t layer,
          grd->grd_vni_sw_if_index = gt->gt_sw_if_index;
 
          gbp_learn_enable (gt->gt_sw_if_index, GBP_LEARN_MODE_L3);
-         gbp_sclass_enable_ip (gt->gt_sw_if_index);
 
          ip4_sw_interface_enable_disable (gt->gt_sw_if_index, 1);
          ip6_sw_interface_enable_disable (gt->gt_sw_if_index, 1);
@@ -759,7 +567,8 @@ gbp_vxlan_tunnel_add (u32 vni, gbp_vxlan_tunnel_layer_t layer,
        */
       hash_set (gv_db, vni, gti);
 
-      vec_validate (gbp_vxlan_tunnel_db, gt->gt_sw_if_index);
+      vec_validate_init_empty (gbp_vxlan_tunnel_db,
+                              gt->gt_sw_if_index, INDEX_INVALID);
       gbp_vxlan_tunnel_db[gt->gt_sw_if_index] = gti;
 
       if (sw_if_indexp)
@@ -805,7 +614,6 @@ gbp_vxlan_tunnel_del (u32 vni)
       if (GBP_VXLAN_TUN_L2 == gt->gt_layer)
        {
          gbp_learn_disable (gt->gt_sw_if_index, GBP_LEARN_MODE_L2);
-         gbp_sclass_disable_l2 (gt->gt_sw_if_index);
          gbp_itf_unlock (gt->gt_itf);
          gbp_bridge_domain_unlock (gt->gt_gbd);
        }
@@ -820,7 +628,6 @@ gbp_vxlan_tunnel_del (u32 vni)
          ip6_sw_interface_enable_disable (gt->gt_sw_if_index, 0);
 
          gbp_learn_disable (gt->gt_sw_if_index, GBP_LEARN_MODE_L3);
-         gbp_sclass_disable_ip (gt->gt_sw_if_index);
          gbp_route_domain_unlock (gt->gt_grd);
        }
 
@@ -866,6 +673,7 @@ static clib_error_t *
 gbp_vxlan_init (vlib_main_t * vm)
 {
   u32 slot4;
+  vlib_node_t *node = vlib_get_node_by_name (vm, (u8 *) "gbp-vxlan4");
 
   /*
    * insert ourselves into the VXLAN-GBP arc to collect the no-tunnel
@@ -873,7 +681,7 @@ gbp_vxlan_init (vlib_main_t * vm)
    */
   slot4 = vlib_node_add_next_with_slot (vm,
                                        vxlan4_gbp_input_node.index,
-                                       gbp_vxlan4_input_node.index,
+                                       node->index,
                                        VXLAN_GBP_INPUT_NEXT_NO_TUNNEL);
   ASSERT (slot4 == VXLAN_GBP_INPUT_NEXT_NO_TUNNEL);