svm: refactor fifo
[vpp.git] / src / plugins / hs_apps / proxy.c
index c4ddd67..d0e3bc4 100644 (file)
 #include <vnet/session/application.h>
 #include <vnet/session/application_interface.h>
 #include <hs_apps/proxy.h>
+#include <vnet/tcp/tcp.h>
 
 proxy_main_t proxy_main;
 
+#define TCP_MSS 1460
+
 typedef struct
 {
   char uri[128];
@@ -69,13 +72,12 @@ delete_proxy_session (session_t * s, int is_active_open)
   uword *p;
   u64 handle;
 
+  clib_spinlock_lock_if_init (&pm->sessions_lock);
+
   handle = session_handle (s);
 
-  clib_spinlock_lock_if_init (&pm->sessions_lock);
   if (is_active_open)
     {
-      active_open_session = s;
-
       p = hash_get (pm->proxy_session_by_active_open_handle, handle);
       if (p == 0)
        {
@@ -85,17 +87,14 @@ delete_proxy_session (session_t * s, int is_active_open)
        }
       else if (!pool_is_free_index (pm->sessions, p[0]))
        {
+         active_open_session = s;
          ps = pool_elt_at_index (pm->sessions, p[0]);
          if (ps->vpp_server_handle != ~0)
            server_session = session_get_from_handle (ps->vpp_server_handle);
-         else
-           server_session = 0;
        }
     }
   else
     {
-      server_session = s;
-
       p = hash_get (pm->proxy_session_by_server_handle, handle);
       if (p == 0)
        {
@@ -105,12 +104,11 @@ delete_proxy_session (session_t * s, int is_active_open)
        }
       else if (!pool_is_free_index (pm->sessions, p[0]))
        {
+         server_session = s;
          ps = pool_elt_at_index (pm->sessions, p[0]);
          if (ps->vpp_active_open_handle != ~0)
            active_open_session = session_get_from_handle
              (ps->vpp_active_open_handle);
-         else
-           active_open_session = 0;
        }
     }
 
@@ -121,8 +119,6 @@ delete_proxy_session (session_t * s, int is_active_open)
       pool_put (pm->sessions, ps);
     }
 
-  clib_spinlock_unlock_if_init (&pm->sessions_lock);
-
   if (active_open_session)
     {
       a->handle = session_handle (active_open_session);
@@ -140,6 +136,8 @@ delete_proxy_session (session_t * s, int is_active_open)
                  session_handle (server_session));
       vnet_disconnect_session (a);
     }
+
+  clib_spinlock_unlock_if_init (&pm->sessions_lock);
 }
 
 static int
@@ -194,7 +192,7 @@ proxy_rx_callback (session_t * s)
   proxy_session_t *ps;
   int proxy_index;
   uword *p;
-  svm_fifo_t *active_open_tx_fifo;
+  svm_fifo_t *ao_tx_fifo;
 
   ASSERT (s->thread_index == thread_index);
 
@@ -204,20 +202,23 @@ proxy_rx_callback (session_t * s)
   if (PREDICT_TRUE (p != 0))
     {
       clib_spinlock_unlock_if_init (&pm->sessions_lock);
-      active_open_tx_fifo = s->rx_fifo;
+      ao_tx_fifo = s->rx_fifo;
 
       /*
        * Send event for active open tx fifo
        */
-      if (svm_fifo_set_event (active_open_tx_fifo))
+      if (svm_fifo_set_event (ao_tx_fifo))
        {
-         u32 ao_thread_index = active_open_tx_fifo->master_thread_index;
-         u32 ao_session_index = active_open_tx_fifo->master_session_index;
+         u32 ao_thread_index = ao_tx_fifo->master_thread_index;
+         u32 ao_session_index = ao_tx_fifo->master_session_index;
          if (session_send_io_evt_to_thread_custom (&ao_session_index,
                                                    ao_thread_index,
                                                    SESSION_IO_EVT_TX))
            clib_warning ("failed to enqueue tx evt");
        }
+
+      if (svm_fifo_max_enqueue (ao_tx_fifo) <= TCP_MSS)
+       svm_fifo_add_want_deq_ntf (ao_tx_fifo, SVM_FIFO_WANT_DEQ_NOTIF);
     }
   else
     {
@@ -232,6 +233,7 @@ proxy_rx_callback (session_t * s)
       if (PREDICT_FALSE (max_dequeue == 0))
        return 0;
 
+      max_dequeue = clib_min (pm->rcv_buffer_size, max_dequeue);
       actual_transfer = svm_fifo_peek (rx_fifo, 0 /* relative_offset */ ,
                                       max_dequeue, pm->rx_buf[thread_index]);
 
@@ -239,7 +241,6 @@ proxy_rx_callback (session_t * s)
 
       clib_memset (a, 0, sizeof (*a));
 
-      clib_spinlock_lock_if_init (&pm->sessions_lock);
       pool_get (pm->sessions, ps);
       clib_memset (ps, 0, sizeof (*ps));
       ps->server_rx_fifo = rx_fifo;
@@ -262,12 +263,56 @@ proxy_rx_callback (session_t * s)
   return 0;
 }
 
+static int
+proxy_tx_callback (session_t * proxy_s)
+{
+  proxy_main_t *pm = &proxy_main;
+  transport_connection_t *tc;
+  session_handle_t handle;
+  proxy_session_t *ps;
+  session_t *ao_s;
+  u32 min_free;
+  uword *p;
+
+  min_free = clib_min (svm_fifo_size (proxy_s->tx_fifo) >> 3, 128 << 10);
+  if (svm_fifo_max_enqueue (proxy_s->tx_fifo) < min_free)
+    {
+      svm_fifo_add_want_deq_ntf (proxy_s->tx_fifo, SVM_FIFO_WANT_DEQ_NOTIF);
+      return 0;
+    }
+
+  clib_spinlock_lock_if_init (&pm->sessions_lock);
+
+  handle = session_handle (proxy_s);
+  p = hash_get (pm->proxy_session_by_server_handle, handle);
+  if (!p)
+    return 0;
+
+  if (pool_is_free_index (pm->sessions, p[0]))
+    return 0;
+
+  ps = pool_elt_at_index (pm->sessions, p[0]);
+  if (ps->vpp_active_open_handle == ~0)
+    return 0;
+
+  ao_s = session_get_from_handle (ps->vpp_active_open_handle);
+
+  /* Force ack on active open side to update rcv wnd */
+  tc = session_get_transport (ao_s);
+  tcp_send_ack ((tcp_connection_t *) tc);
+
+  clib_spinlock_unlock_if_init (&pm->sessions_lock);
+
+  return 0;
+}
+
 static session_cb_vft_t proxy_session_cb_vft = {
   .session_accept_callback = proxy_accept_callback,
   .session_disconnect_callback = proxy_disconnect_callback,
   .session_connected_callback = proxy_connected_callback,
   .add_segment_callback = proxy_add_segment_callback,
   .builtin_app_rx_callback = proxy_rx_callback,
+  .builtin_app_tx_callback = proxy_tx_callback,
   .session_reset_callback = proxy_reset_callback
 };
 
@@ -311,6 +356,9 @@ active_open_connected_callback (u32 app_index, u32 opaque,
   s->tx_fifo->refcnt++;
   s->rx_fifo->refcnt++;
 
+  svm_fifo_init_ooo_lookup (s->tx_fifo, 1 /* deq ooo */ );
+  svm_fifo_init_ooo_lookup (s->rx_fifo, 0 /* enq ooo */ );
+
   hash_set (pm->proxy_session_by_active_open_handle,
            ps->vpp_active_open_handle, opaque);
 
@@ -363,6 +411,52 @@ active_open_rx_callback (session_t * s)
                                                   SESSION_IO_EVT_TX);
     }
 
+  if (svm_fifo_max_enqueue (proxy_tx_fifo) <= TCP_MSS)
+    svm_fifo_add_want_deq_ntf (proxy_tx_fifo, SVM_FIFO_WANT_DEQ_NOTIF);
+
+  return 0;
+}
+
+static int
+active_open_tx_callback (session_t * ao_s)
+{
+  proxy_main_t *pm = &proxy_main;
+  transport_connection_t *tc;
+  session_handle_t handle;
+  proxy_session_t *ps;
+  session_t *proxy_s;
+  u32 min_free;
+  uword *p;
+
+  min_free = clib_min (svm_fifo_size (ao_s->tx_fifo) >> 3, 128 << 10);
+  if (svm_fifo_max_enqueue (ao_s->tx_fifo) < min_free)
+    {
+      svm_fifo_add_want_deq_ntf (ao_s->tx_fifo, SVM_FIFO_WANT_DEQ_NOTIF);
+      return 0;
+    }
+
+  clib_spinlock_lock_if_init (&pm->sessions_lock);
+
+  handle = session_handle (ao_s);
+  p = hash_get (pm->proxy_session_by_active_open_handle, handle);
+  if (!p)
+    return 0;
+
+  if (pool_is_free_index (pm->sessions, p[0]))
+    return 0;
+
+  ps = pool_elt_at_index (pm->sessions, p[0]);
+  if (ps->vpp_server_handle == ~0)
+    return 0;
+
+  proxy_s = session_get_from_handle (ps->vpp_server_handle);
+
+  /* Force ack on proxy side to update rcv wnd */
+  tc = session_get_transport (proxy_s);
+  tcp_send_ack ((tcp_connection_t *) tc);
+
+  clib_spinlock_unlock_if_init (&pm->sessions_lock);
+
   return 0;
 }
 
@@ -372,26 +466,11 @@ static session_cb_vft_t active_open_clients = {
   .session_connected_callback = active_open_connected_callback,
   .session_accept_callback = active_open_create_callback,
   .session_disconnect_callback = active_open_disconnect_callback,
-  .builtin_app_rx_callback = active_open_rx_callback
+  .builtin_app_rx_callback = active_open_rx_callback,
+  .builtin_app_tx_callback = active_open_tx_callback,
 };
 /* *INDENT-ON* */
 
-
-static void
-create_api_loopbacks (vlib_main_t * vm)
-{
-  proxy_main_t *pm = &proxy_main;
-  api_main_t *am = vlibapi_get_main ();
-  vl_shmem_hdr_t *shmem_hdr;
-
-  shmem_hdr = am->shmem_hdr;
-  pm->vl_input_queue = shmem_hdr->vl_input_queue;
-  pm->server_client_index =
-    vl_api_memclnt_create_internal ("proxy_server", pm->vl_input_queue);
-  pm->active_open_client_index =
-    vl_api_memclnt_create_internal ("proxy_active_open", pm->vl_input_queue);
-}
-
 static int
 proxy_server_attach ()
 {
@@ -405,6 +484,7 @@ proxy_server_attach ()
 
   if (pm->private_segment_size)
     segment_size = pm->private_segment_size;
+  a->name = format (0, "proxy-server");
   a->api_client_index = pm->server_client_index;
   a->session_cb_vft = &proxy_session_cb_vft;
   a->options = options;
@@ -424,6 +504,7 @@ proxy_server_attach ()
     }
   pm->server_app_index = a->app_index;
 
+  vec_free (a->name);
   return 0;
 }
 
@@ -439,6 +520,7 @@ active_open_attach (void)
 
   a->api_client_index = pm->active_open_client_index;
   a->session_cb_vft = &active_open_clients;
+  a->name = format (0, "proxy-active-open");
 
   options[APP_OPTIONS_ACCEPT_COOKIE] = 0x12345678;
   options[APP_OPTIONS_SEGMENT_SIZE] = 512 << 20;
@@ -458,6 +540,8 @@ active_open_attach (void)
 
   pm->active_open_app_index = a->app_index;
 
+  vec_free (a->name);
+
   return 0;
 }
 
@@ -480,9 +564,6 @@ proxy_server_create (vlib_main_t * vm)
   u32 num_threads;
   int i;
 
-  if (pm->server_client_index == (u32) ~ 0)
-    create_api_loopbacks (vm);
-
   num_threads = 1 /* main thread */  + vtm->n_threads;
   vec_validate (proxy_main.server_event_queue, num_threads - 1);
   vec_validate (proxy_main.active_open_event_queue, num_threads - 1);
@@ -535,6 +616,7 @@ proxy_server_create_command_fn (vlib_main_t * vm, unformat_input_t * input,
   pm->private_segment_count = 0;
   pm->private_segment_size = 0;
   pm->server_uri = 0;
+  pm->client_uri = 0;
 
   while (unformat_check_input (input) != UNFORMAT_END_OF_INPUT)
     {
@@ -556,9 +638,9 @@ proxy_server_create_command_fn (vlib_main_t * vm, unformat_input_t * input,
          pm->private_segment_size = tmp;
        }
       else if (unformat (input, "server-uri %s", &pm->server_uri))
-       ;
+       vec_add1 (pm->server_uri, 0);
       else if (unformat (input, "client-uri %s", &pm->client_uri))
-       pm->client_uri = format (0, "%s%c", pm->client_uri, 0);
+       vec_add1 (pm->client_uri, 0);
       else
        return clib_error_return (0, "unknown input `%U'",
                                  format_unformat_error, input);