misc: fix coverity warnings

[vpp.git] / src / plugins / igmp / igmp_proxy.c

diff --git a/src/plugins/igmp/igmp_proxy.c b/src/plugins/igmp/igmp_proxy.c
index 4a439d6..dc2b4c1 100644 (file)
--- a/src/plugins/igmp/igmp_proxy.c
+++ b/src/plugins/igmp/igmp_proxy.c
@@ -49,13 +49,13 @@ igmp_proxy_device_mfib_path_add_del (igmp_group_t * group, u8 add)
       .frp_sw_if_index = config->sw_if_index,
       .frp_fib_index = 0,
       .frp_weight = 1,
+      .frp_mitf_flags = MFIB_ITF_FLAG_FORWARD,
     };
   /* *INDENT-ON* */
 
   if (add)
     mfib_table_entry_path_update (mfib_index, &mpfx_group_addr,
-                                 MFIB_SOURCE_IGMP, &via_itf_path,
-                                 MFIB_ITF_FLAG_FORWARD);
+                                 MFIB_SOURCE_IGMP, &via_itf_path);
   else
     mfib_table_entry_path_remove (mfib_index, &mpfx_group_addr,
                                  MFIB_SOURCE_IGMP, &via_itf_path);
@@ -106,7 +106,7 @@ igmp_proxy_device_add_del (u32 vrf_id, u32 sw_if_index, u8 add)
       pool_get (im->proxy_devices, proxy_device);
       im->igmp_proxy_device_by_vrf_id[vrf_id] =
        proxy_device - im->proxy_devices;
-      memset (proxy_device, 0, sizeof (igmp_proxy_device_t));
+      clib_memset (proxy_device, 0, sizeof (igmp_proxy_device_t));
       proxy_device->vrf_id = vrf_id;
       proxy_device->upstream_if = sw_if_index;
       config->proxy_device_id = vrf_id;
@@ -326,7 +326,7 @@ igmp_proxy_device_merge_group (igmp_proxy_device_t * proxy_device,
   igmp_src_t *src;
 
   proxy_config = igmp_config_lookup (proxy_device->upstream_if);
-  ASSERT (proxy_config);
+  ALWAYS_ASSERT (proxy_config);
 
   proxy_group = igmp_group_lookup (proxy_config, group->key);
   if (!proxy_group)