ikev2: fix false positive NAT detection
[vpp.git] / src / plugins / ikev2 / ikev2.c
index fc4a87d..96b8e7d 100644 (file)
@@ -28,8 +28,9 @@
 #include <plugins/ikev2/ikev2.h>
 #include <plugins/ikev2/ikev2_priv.h>
 #include <openssl/sha.h>
+#include <vnet/ipsec/ipsec_punt.h>
 
-#define IKEV2_LIVENESS_RETRIES 2
+#define IKEV2_LIVENESS_RETRIES 3
 #define IKEV2_LIVENESS_PERIOD_CHECK 30
 
 ikev2_main_t ikev2_main;
@@ -69,7 +70,8 @@ _(IKE_SA_INIT_RETRANSMIT, "IKE_SA_INIT retransmit ") \
 _(IKE_SA_INIT_IGNORE, "IKE_SA_INIT ignore (IKE SA already auth)") \
 _(IKE_REQ_RETRANSMIT, "IKE request retransmit") \
 _(IKE_REQ_IGNORE, "IKE request ignore (old msgid)") \
-_(NOT_IKEV2, "Non IKEv2 packets received")
+_(NOT_IKEV2, "Non IKEv2 packets received") \
+_(BAD_LENGTH, "Bad packet length")
 
 typedef enum
 {
@@ -92,6 +94,22 @@ typedef enum
   IKEV2_N_NEXT,
 } ikev2_next_t;
 
+typedef u32 ikev2_non_esp_marker;
+
+static_always_inline u16
+ikev2_get_port (ikev2_sa_t * sa)
+{
+  return sa->natt ? IKEV2_PORT_NATT : IKEV2_PORT;
+}
+
+static_always_inline int
+ikev2_insert_non_esp_marker (ike_header_t * ike, int len)
+{
+  memmove ((u8 *) ike + sizeof (ikev2_non_esp_marker), ike, len);
+  clib_memset (ike, 0, sizeof (ikev2_non_esp_marker));
+  return len + sizeof (ikev2_non_esp_marker);
+}
+
 static ikev2_sa_transform_t *
 ikev2_find_transform_data (ikev2_sa_transform_t * t)
 {
@@ -132,9 +150,8 @@ ikev2_select_proposal (ikev2_sa_proposal_t * proposals,
   if (prot_id == IKEV2_PROTOCOL_IKE)
     {
       mandatory_bitmap = (1 << IKEV2_TRANSFORM_TYPE_ENCR) |
-       (1 << IKEV2_TRANSFORM_TYPE_PRF) |
-       (1 << IKEV2_TRANSFORM_TYPE_INTEG) | (1 << IKEV2_TRANSFORM_TYPE_DH);
-      optional_bitmap = mandatory_bitmap;
+       (1 << IKEV2_TRANSFORM_TYPE_PRF) | (1 << IKEV2_TRANSFORM_TYPE_DH);
+      optional_bitmap = mandatory_bitmap | (1 << IKEV2_TRANSFORM_TYPE_INTEG);
     }
   else if (prot_id == IKEV2_PROTOCOL_ESP)
     {
@@ -279,9 +296,12 @@ static void
 ikev2_sa_free_all_vec (ikev2_sa_t * sa)
 {
   vec_free (sa->i_nonce);
-  vec_free (sa->i_dh_data);
+  vec_free (sa->r_nonce);
+
   vec_free (sa->dh_shared_key);
   vec_free (sa->dh_private_key);
+  vec_free (sa->i_dh_data);
+  vec_free (sa->r_dh_data);
 
   ikev2_sa_free_proposal_vector (&sa->r_proposals);
   ikev2_sa_free_proposal_vector (&sa->i_proposals);
@@ -295,14 +315,24 @@ ikev2_sa_free_all_vec (ikev2_sa_t * sa)
   vec_free (sa->sk_pr);
 
   vec_free (sa->i_id.data);
-  vec_free (sa->i_auth.data);
   vec_free (sa->r_id.data);
+
+  vec_free (sa->i_auth.data);
+  if (sa->i_auth.key)
+    EVP_PKEY_free (sa->i_auth.key);
   vec_free (sa->r_auth.data);
   if (sa->r_auth.key)
     EVP_PKEY_free (sa->r_auth.key);
 
   vec_free (sa->del);
 
+  vec_free (sa->rekey);
+
+  vec_free (sa->last_sa_init_req_packet_data);
+  vec_free (sa->last_sa_init_res_packet_data);
+
+  vec_free (sa->last_res_packet_data);
+
   ikev2_sa_free_all_child_sa (&sa->childs);
 }
 
@@ -380,8 +410,6 @@ ikev2_complete_sa_data (ikev2_sa_t * sa, ikev2_sa_t * sai)
   ikev2_sa_transform_t *t = 0, *t2;
   ikev2_main_t *km = &ikev2_main;
 
-  sai->init_response_received = 1;
-
   /*move some data to the new SA */
 #define _(A) ({void* __tmp__ = (A); (A) = 0; __tmp__;})
   sa->i_nonce = _(sai->i_nonce);
@@ -391,11 +419,12 @@ ikev2_complete_sa_data (ikev2_sa_t * sa, ikev2_sa_t * sai)
   sa->raddr.as_u32 = sai->raddr.as_u32;
   sa->is_initiator = sai->is_initiator;
   sa->i_id.type = sai->i_id.type;
+  sa->r_id.type = sai->r_id.type;
   sa->profile_index = sai->profile_index;
-  sa->is_profile_index_set = sai->is_profile_index_set;
   sa->tun_itf = sai->tun_itf;
   sa->is_tun_itf_set = sai->is_tun_itf_set;
   sa->i_id.data = _(sai->i_id.data);
+  sa->r_id.data = _(sai->r_id.data);
   sa->i_auth.method = sai->i_auth.method;
   sa->i_auth.hex = sai->i_auth.hex;
   sa->i_auth.data = _(sai->i_auth.data);
@@ -403,7 +432,9 @@ ikev2_complete_sa_data (ikev2_sa_t * sa, ikev2_sa_t * sai)
   sa->last_sa_init_req_packet_data = _(sai->last_sa_init_req_packet_data);
   sa->childs = _(sai->childs);
   sa->udp_encap = sai->udp_encap;
+  sa->ipsec_over_udp_port = sai->ipsec_over_udp_port;
   sa->dst_port = sai->dst_port;
+  sa->sw_if_index = sai->sw_if_index;
 #undef _
 
 
@@ -441,7 +472,7 @@ ikev2_calc_keys (ikev2_sa_t * sa)
   /* calculate SKEYSEED = prf(Ni | Nr, g^ir) */
   u8 *skeyseed = 0;
   u8 *s = 0;
-  u16 integ_key_len = 0;
+  u16 integ_key_len = 0, salt_len = 0;
   ikev2_sa_transform_t *tr_encr, *tr_prf, *tr_integ;
   tr_encr =
     ikev2_sa_get_td_for_type (sa->r_proposals, IKEV2_TRANSFORM_TYPE_ENCR);
@@ -452,6 +483,8 @@ ikev2_calc_keys (ikev2_sa_t * sa)
 
   if (tr_integ)
     integ_key_len = tr_integ->key_len;
+  else
+    salt_len = sizeof (u32);
 
   vec_append (s, sa->i_nonce);
   vec_append (s, sa->r_nonce);
@@ -469,7 +502,8 @@ ikev2_calc_keys (ikev2_sa_t * sa)
   int len = tr_prf->key_trunc +        /* SK_d */
     integ_key_len * 2 +                /* SK_ai, SK_ar */
     tr_encr->key_len * 2 +     /* SK_ei, SK_er */
-    tr_prf->key_len * 2;       /* SK_pi, SK_pr */
+    tr_prf->key_len * 2 +      /* SK_pi, SK_pr */
+    salt_len * 2;
 
   keymat = ikev2_calc_prfplus (tr_prf, skeyseed, s, len);
   vec_free (skeyseed);
@@ -496,14 +530,14 @@ ikev2_calc_keys (ikev2_sa_t * sa)
     }
 
   /* SK_ei */
-  sa->sk_ei = vec_new (u8, tr_encr->key_len);
-  clib_memcpy_fast (sa->sk_ei, keymat + pos, tr_encr->key_len);
-  pos += tr_encr->key_len;
+  sa->sk_ei = vec_new (u8, tr_encr->key_len + salt_len);
+  clib_memcpy_fast (sa->sk_ei, keymat + pos, tr_encr->key_len + salt_len);
+  pos += tr_encr->key_len + salt_len;
 
   /* SK_er */
-  sa->sk_er = vec_new (u8, tr_encr->key_len);
-  clib_memcpy_fast (sa->sk_er, keymat + pos, tr_encr->key_len);
-  pos += tr_encr->key_len;
+  sa->sk_er = vec_new (u8, tr_encr->key_len + salt_len);
+  clib_memcpy_fast (sa->sk_er, keymat + pos, tr_encr->key_len + salt_len);
+  pos += tr_encr->key_len + salt_len;
 
   /* SK_pi */
   sa->sk_pi = vec_new (u8, tr_prf->key_len);
@@ -516,6 +550,7 @@ ikev2_calc_keys (ikev2_sa_t * sa)
   pos += tr_prf->key_len;
 
   vec_free (keymat);
+  sa->keys_generated = 1;
 }
 
 static void
@@ -589,12 +624,26 @@ ikev2_calc_child_keys (ikev2_sa_t * sa, ikev2_child_sa_t * child)
   vec_free (keymat);
 }
 
+static_always_inline u8 *
+ikev2_compute_nat_sha1 (u64 ispi, u64 rspi, u32 ip, u16 port)
+{
+  /* ispi, rspi, ip, port */
+  u8 buf[8 + 8 + 4 + 2];
+  u8 *res = vec_new (u8, 20);
+
+  clib_memcpy_fast (&buf[0], &ispi, sizeof (ispi));
+  clib_memcpy_fast (&buf[8], &rspi, sizeof (rspi));
+  clib_memcpy_fast (&buf[8 + 8], &ip, sizeof (ip));
+  clib_memcpy_fast (&buf[8 + 8 + 4], &port, sizeof (port));
+  SHA1 (buf, sizeof (buf), res);
+  return res;
+}
+
 static void
 ikev2_process_sa_init_req (vlib_main_t * vm, ikev2_sa_t * sa,
-                          ike_header_t * ike)
+                          ike_header_t * ike, udp_header_t * udp, u32 len)
 {
   int p = 0;
-  u32 len = clib_net_to_host_u32 (ike->length);
   u8 payload = ike->nextpayload;
 
   ikev2_elog_exchange ("ispi %lx rspi %lx IKE_INIT request received "
@@ -605,7 +654,7 @@ ikev2_process_sa_init_req (vlib_main_t * vm, ikev2_sa_t * sa,
   sa->ispi = clib_net_to_host_u64 (ike->ispi);
 
   /* store whole IKE payload - needed for PSK auth */
-  vec_free (sa->last_sa_init_req_packet_data);
+  vec_reset_length (sa->last_sa_init_req_packet_data);
   vec_add (sa->last_sa_init_req_packet_data, ike, len);
 
   while (p < len && payload != IKEV2_PAYLOAD_NONE)
@@ -636,6 +685,33 @@ ikev2_process_sa_init_req (vlib_main_t * vm, ikev2_sa_t * sa,
       else if (payload == IKEV2_PAYLOAD_NOTIFY)
        {
          ikev2_notify_t *n = ikev2_parse_notify_payload (ikep);
+         if (n->msg_type == IKEV2_NOTIFY_MSG_NAT_DETECTION_SOURCE_IP)
+           {
+             u8 *src_sha = ikev2_compute_nat_sha1 (ike->ispi, 0,
+                                                   sa->iaddr.as_u32,
+                                                   udp->src_port);
+             if (clib_memcmp (src_sha, n->data, vec_len (src_sha)))
+               {
+                 sa->natt = 1;
+                 ikev2_elog_uint (IKEV2_LOG_DEBUG, "ispi %lx initiator"
+                                  " behind NAT", sa->ispi);
+               }
+             vec_free (src_sha);
+           }
+         else if (n->msg_type ==
+                  IKEV2_NOTIFY_MSG_NAT_DETECTION_DESTINATION_IP)
+           {
+             u8 *dst_sha = ikev2_compute_nat_sha1 (ike->ispi, 0,
+                                                   sa->raddr.as_u32,
+                                                   udp->dst_port);
+             if (clib_memcmp (dst_sha, n->data, vec_len (dst_sha)))
+               {
+                 sa->natt = 1;
+                 ikev2_elog_uint (IKEV2_LOG_DEBUG, "ispi %lx responder"
+                                  " (self) behind NAT", sa->ispi);
+               }
+             vec_free (dst_sha);
+           }
          vec_free (n);
        }
       else if (payload == IKEV2_PAYLOAD_VENDOR)
@@ -663,10 +739,9 @@ ikev2_process_sa_init_req (vlib_main_t * vm, ikev2_sa_t * sa,
 
 static void
 ikev2_process_sa_init_resp (vlib_main_t * vm, ikev2_sa_t * sa,
-                           ike_header_t * ike)
+                           ike_header_t * ike, udp_header_t * udp, u32 len)
 {
   int p = 0;
-  u32 len = clib_net_to_host_u32 (ike->length);
   u8 payload = ike->nextpayload;
 
   sa->ispi = clib_net_to_host_u64 (ike->ispi);
@@ -677,7 +752,7 @@ ikev2_process_sa_init_resp (vlib_main_t * vm, ikev2_sa_t * sa,
                       sa->raddr.as_u32);
 
   /* store whole IKE payload - needed for PSK auth */
-  vec_free (sa->last_sa_init_res_packet_data);
+  vec_reset_length (sa->last_sa_init_res_packet_data);
   vec_add (sa->last_sa_init_res_packet_data, ike, len);
 
   while (p < len && payload != IKEV2_PAYLOAD_NONE)
@@ -714,6 +789,34 @@ ikev2_process_sa_init_resp (vlib_main_t * vm, ikev2_sa_t * sa,
       else if (payload == IKEV2_PAYLOAD_NOTIFY)
        {
          ikev2_notify_t *n = ikev2_parse_notify_payload (ikep);
+         if (n->msg_type == IKEV2_NOTIFY_MSG_NAT_DETECTION_SOURCE_IP)
+           {
+             u8 *src_sha = ikev2_compute_nat_sha1 (ike->ispi,
+                                                   ike->rspi,
+                                                   sa->raddr.as_u32,
+                                                   udp->src_port);
+             if (clib_memcmp (src_sha, n->data, vec_len (src_sha)))
+               {
+                 ikev2_elog_uint (IKEV2_LOG_DEBUG, "ispi %lx responder"
+                                  " behind NAT, unsupported", sa->ispi);
+               }
+             vec_free (src_sha);
+           }
+         else if (n->msg_type ==
+                  IKEV2_NOTIFY_MSG_NAT_DETECTION_DESTINATION_IP)
+           {
+             u8 *dst_sha = ikev2_compute_nat_sha1 (ike->ispi,
+                                                   ike->rspi,
+                                                   sa->iaddr.as_u32,
+                                                   udp->dst_port);
+             if (clib_memcmp (dst_sha, n->data, vec_len (dst_sha)))
+               {
+                 sa->natt = 1;
+                 ikev2_elog_uint (IKEV2_LOG_DEBUG, "ispi %lx initiator"
+                                  " (self) behind NAT", sa->ispi);
+               }
+             vec_free (dst_sha);
+           }
          vec_free (n);
        }
       else if (payload == IKEV2_PAYLOAD_VENDOR)
@@ -738,17 +841,25 @@ ikev2_process_sa_init_resp (vlib_main_t * vm, ikev2_sa_t * sa,
 }
 
 static u8 *
-ikev2_decrypt_sk_payload (ikev2_sa_t * sa, ike_header_t * ike, u8 * payload)
+ikev2_decrypt_sk_payload (ikev2_sa_t * sa, ike_header_t * ike, u8 * payload,
+                         u32 len)
 {
+  ikev2_main_per_thread_data_t *ptd = ikev2_get_per_thread_data ();
   int p = 0;
-  u8 last_payload = 0;
+  u8 last_payload = 0, *plaintext = 0;
   u8 *hmac = 0;
-  u32 len = clib_net_to_host_u32 (ike->length);
   ike_payload_header_t *ikep = 0;
   u32 plen = 0;
   ikev2_sa_transform_t *tr_integ;
+  ikev2_sa_transform_t *tr_encr;
   tr_integ =
     ikev2_sa_get_td_for_type (sa->r_proposals, IKEV2_TRANSFORM_TYPE_INTEG);
+  tr_encr =
+    ikev2_sa_get_td_for_type (sa->r_proposals, IKEV2_TRANSFORM_TYPE_ENCR);
+  int is_aead = tr_encr->encr_type == IKEV2_TRANSFORM_ENCR_TYPE_AES_GCM_16;
+
+  if ((!sa->sk_ar || !sa->sk_ai) && !is_aead)
+    return 0;
 
   while (p < len &&
         *payload != IKEV2_PAYLOAD_NONE && last_payload != IKEV2_PAYLOAD_SK)
@@ -784,21 +895,60 @@ ikev2_decrypt_sk_payload (ikev2_sa_t * sa, ike_header_t * ike, u8 * payload)
       return 0;
     }
 
-  hmac =
-    ikev2_calc_integr (tr_integ, sa->is_initiator ? sa->sk_ar : sa->sk_ai,
-                      (u8 *) ike, len - tr_integ->key_trunc);
+  if (is_aead)
+    {
+      if (plen < sizeof (*ikep) + IKEV2_GCM_ICV_SIZE)
+       return 0;
 
-  plen = plen - sizeof (*ikep) - tr_integ->key_trunc;
+      plen -= sizeof (*ikep) + IKEV2_GCM_ICV_SIZE;
+      u8 *aad = (u8 *) ike;
+      u32 aad_len = ikep->payload - aad;
+      u8 *tag = ikep->payload + plen;
 
-  if (memcmp (hmac, &ikep->payload[plen], tr_integ->key_trunc))
+      plaintext = ikev2_decrypt_aead_data (ptd, sa, tr_encr, ikep->payload,
+                                          plen, aad, aad_len, tag);
+    }
+  else
     {
-      ikev2_elog_error ("message integrity check failed");
+      if (len < tr_integ->key_trunc)
+       return 0;
+
+      hmac =
+       ikev2_calc_integr (tr_integ, sa->is_initiator ? sa->sk_ar : sa->sk_ai,
+                          (u8 *) ike, len - tr_integ->key_trunc);
+
+      if (plen < sizeof (*ikep) + tr_integ->key_trunc)
+       return 0;
+
+      plen = plen - sizeof (*ikep) - tr_integ->key_trunc;
+
+      if (memcmp (hmac, &ikep->payload[plen], tr_integ->key_trunc))
+       {
+         ikev2_elog_error ("message integrity check failed");
+         vec_free (hmac);
+         return 0;
+       }
       vec_free (hmac);
-      return 0;
+
+      plaintext = ikev2_decrypt_data (ptd, sa, tr_encr, ikep->payload, plen);
     }
-  vec_free (hmac);
 
-  return ikev2_decrypt_data (sa, ikep->payload, plen);
+  return plaintext;
+}
+
+static_always_inline int
+ikev2_is_id_equal (ikev2_id_t * i1, ikev2_id_t * i2)
+{
+  if (i1->type != i2->type)
+    return 0;
+
+  if (vec_len (i1->data) != vec_len (i2->data))
+    return 0;
+
+  if (memcmp (i1->data, i2->data, vec_len (i1->data)))
+    return 0;
+
+  return 1;
 }
 
 static void
@@ -816,9 +966,8 @@ ikev2_initial_contact_cleanup (ikev2_sa_t * sa)
   /* find old IKE SAs with the same authenticated identity */
   /* *INDENT-OFF* */
   pool_foreach (tmp, km->per_thread_data[thread_index].sas, ({
-        if (tmp->i_id.type != sa->i_id.type ||
-            vec_len(tmp->i_id.data) != vec_len(sa->i_id.data) ||
-            memcmp(sa->i_id.data, tmp->i_id.data, vec_len(sa->i_id.data)))
+        if (!ikev2_is_id_equal (&tmp->i_id, &sa->i_id)
+            || !ikev2_is_id_equal(&tmp->r_id, &sa->r_id))
           continue;
 
         if (sa->rspi != tmp->rspi)
@@ -841,7 +990,8 @@ ikev2_initial_contact_cleanup (ikev2_sa_t * sa)
 }
 
 static void
-ikev2_process_auth_req (vlib_main_t * vm, ikev2_sa_t * sa, ike_header_t * ike)
+ikev2_process_auth_req (vlib_main_t * vm, ikev2_sa_t * sa, ike_header_t * ike,
+                       u32 len)
 {
   ikev2_child_sa_t *first_child_sa;
   int p = 0;
@@ -858,7 +1008,7 @@ ikev2_process_auth_req (vlib_main_t * vm, ikev2_sa_t * sa, ike_header_t * ike)
 
   ikev2_calc_keys (sa);
 
-  plaintext = ikev2_decrypt_sk_payload (sa, ike, &payload);
+  plaintext = ikev2_decrypt_sk_payload (sa, ike, &payload, len);
 
   if (!plaintext)
     {
@@ -981,7 +1131,7 @@ cleanup_and_exit:
 
 static void
 ikev2_process_informational_req (vlib_main_t * vm, ikev2_sa_t * sa,
-                                ike_header_t * ike)
+                                ike_header_t * ike, u32 len)
 {
   int p = 0;
   u8 payload = ike->nextpayload;
@@ -994,7 +1144,7 @@ ikev2_process_informational_req (vlib_main_t * vm, ikev2_sa_t * sa,
                       "from %d.%d.%d.%d", clib_host_to_net_u64 (ike->ispi),
                       clib_host_to_net_u64 (ike->rspi), sa->iaddr.as_u32);
 
-  plaintext = ikev2_decrypt_sk_payload (sa, ike, &payload);
+  plaintext = ikev2_decrypt_sk_payload (sa, ike, &payload, len);
 
   if (!plaintext)
     goto cleanup_and_exit;
@@ -1045,7 +1195,7 @@ cleanup_and_exit:
 
 static void
 ikev2_process_create_child_sa_req (vlib_main_t * vm, ikev2_sa_t * sa,
-                                  ike_header_t * ike)
+                                  ike_header_t * ike, u32 len)
 {
   int p = 0;
   u8 payload = ike->nextpayload;
@@ -1065,7 +1215,7 @@ ikev2_process_create_child_sa_req (vlib_main_t * vm, ikev2_sa_t * sa,
                       "from %d.%d.%d.%d", clib_host_to_net_u64 (ike->ispi),
                       clib_host_to_net_u64 (ike->rspi), sa->raddr.as_u32);
 
-  plaintext = ikev2_decrypt_sk_payload (sa, ike, &payload);
+  plaintext = ikev2_decrypt_sk_payload (sa, ike, &payload, len);
 
   if (!plaintext)
     goto cleanup_and_exit;
@@ -1119,7 +1269,7 @@ ikev2_process_create_child_sa_req (vlib_main_t * vm, ikev2_sa_t * sa,
          if (ikep->flags & IKEV2_PAYLOAD_FLAG_CRITICAL)
            {
              sa->unsupported_cp = payload;
-             return;
+             goto cleanup_and_exit;
            }
        }
 
@@ -1239,7 +1389,7 @@ ikev2_sa_match_ts (ikev2_sa_t * sa)
   ikev2_main_t *km = &ikev2_main;
   ikev2_profile_t *p;
   ikev2_ts_t *ts, *p_tsi, *p_tsr, *tsi = 0, *tsr = 0;
-  ikev2_id_t *id;
+  ikev2_id_t *id_rem, *id_loc;
 
   /* *INDENT-OFF* */
   pool_foreach (p, km->profiles, ({
@@ -1248,21 +1398,24 @@ ikev2_sa_match_ts (ikev2_sa_t * sa)
       {
         p_tsi = &p->loc_ts;
         p_tsr = &p->rem_ts;
-        id = &sa->r_id;
+        id_rem = &sa->r_id;
+        id_loc = &sa->i_id;
       }
     else
       {
         p_tsi = &p->rem_ts;
         p_tsr = &p->loc_ts;
-        id = &sa->i_id;
+        id_rem = &sa->i_id;
+        id_loc = &sa->r_id;
       }
 
     /* check id */
-    if (p->rem_id.type != id->type ||
-        vec_len(p->rem_id.data) != vec_len(id->data) ||
-        memcmp(p->rem_id.data, id->data, vec_len(p->rem_id.data)))
+    if (!ikev2_is_id_equal (&p->rem_id, id_rem)
+          || !ikev2_is_id_equal (&p->loc_id, id_loc))
       continue;
 
+    sa->profile_index = p - km->profiles;
+
     vec_foreach(ts, sa->childs[0].tsi)
       {
         if (ikev2_ts_cmp(p_tsi, ts))
@@ -1325,17 +1478,19 @@ ikev2_sa_auth (ikev2_sa_t * sa)
   key_pad = format (0, "%s", IKEV2_KEY_PAD);
   authmsg = ikev2_sa_generate_authmsg (sa, sa->is_initiator);
 
-  ikev2_id_t *sa_id;
+  ikev2_id_t *id_rem, *id_loc;
   ikev2_auth_t *sa_auth;
 
   if (sa->is_initiator)
     {
-      sa_id = &sa->r_id;
+      id_rem = &sa->r_id;
+      id_loc = &sa->i_id;
       sa_auth = &sa->r_auth;
     }
   else
     {
-      sa_id = &sa->i_id;
+      id_rem = &sa->i_id;
+      id_loc = &sa->r_id;
       sa_auth = &sa->i_auth;
     }
 
@@ -1343,9 +1498,8 @@ ikev2_sa_auth (ikev2_sa_t * sa)
   pool_foreach (p, km->profiles, ({
 
     /* check id */
-    if (p->rem_id.type != sa_id->type ||
-        vec_len(p->rem_id.data) != vec_len(sa_id->data) ||
-        memcmp(p->rem_id.data, sa_id->data, vec_len(p->rem_id.data)))
+    if (!ikev2_is_id_equal (&p->rem_id, id_rem)
+          || !ikev2_is_id_equal (&p->loc_id, id_loc))
       continue;
 
     if (sa_auth->method == IKEV2_AUTH_METHOD_SHARED_KEY_MIC)
@@ -1387,7 +1541,7 @@ ikev2_sa_auth (ikev2_sa_t * sa)
   if (sel_p)
     {
       sa->udp_encap = sel_p->udp_encap;
-      sa->dst_port = sel_p->dst_port;
+      sa->ipsec_over_udp_port = sel_p->ipsec_over_udp_port;
     }
   vec_free (authmsg);
 
@@ -1398,6 +1552,8 @@ ikev2_sa_auth (ikev2_sa_t * sa)
          vec_free (sa->r_id.data);
          sa->r_id.data = vec_dup (sel_p->loc_id.data);
          sa->r_id.type = sel_p->loc_id.type;
+         sa->i_id.data = vec_dup (sel_p->rem_id.data);
+         sa->i_id.type = sel_p->rem_id.type;
 
          /* generate our auth data */
          authmsg = ikev2_sa_generate_authmsg (sa, 1);
@@ -1441,7 +1597,7 @@ static void
 ikev2_sa_auth_init (ikev2_sa_t * sa)
 {
   ikev2_main_t *km = &ikev2_main;
-  u8 *authmsg, *key_pad, *psk = 0, *auth = 0;
+  u8 *authmsg, *key_pad, *psk = 0;
   ikev2_sa_transform_t *tr_prf;
 
   tr_prf =
@@ -1461,8 +1617,6 @@ ikev2_sa_auth_init (ikev2_sa_t * sa)
   key_pad = format (0, "%s", IKEV2_KEY_PAD);
   authmsg = ikev2_sa_generate_authmsg (sa, 0);
   psk = ikev2_calc_prf (tr_prf, sa->i_auth.data, key_pad);
-  auth = ikev2_calc_prf (tr_prf, psk, authmsg);
-
 
   if (sa->i_auth.method == IKEV2_AUTH_METHOD_SHARED_KEY_MIC)
     {
@@ -1477,7 +1631,6 @@ ikev2_sa_auth_init (ikev2_sa_t * sa)
 
   vec_free (psk);
   vec_free (key_pad);
-  vec_free (auth);
   vec_free (authmsg);
 }
 
@@ -1510,6 +1663,8 @@ typedef struct
   ipsec_key_t loc_ckey, rem_ckey, loc_ikey, rem_ikey;
   u8 is_rekey;
   u32 old_remote_sa_id;
+  u16 ipsec_over_udp_port;
+  u16 src_port;
   u16 dst_port;
 } ikev2_add_ipsec_tunnel_args_t;
 
@@ -1568,19 +1723,20 @@ ikev2_add_tunnel_from_main (ikev2_add_ipsec_tunnel_args_t * a)
                               IPSEC_PROTOCOL_ESP, a->encr_type,
                               &a->loc_ckey, a->integ_type, &a->loc_ikey,
                               a->flags, 0, a->salt_local, &a->local_ip,
-                              &a->remote_ip, NULL, a->dst_port);
+                              &a->remote_ip, NULL, a->src_port, a->dst_port);
   rv |= ipsec_sa_add_and_lock (a->remote_sa_id, a->remote_spi,
                               IPSEC_PROTOCOL_ESP, a->encr_type, &a->rem_ckey,
                               a->integ_type, &a->rem_ikey,
                               (a->flags | IPSEC_SA_FLAG_IS_INBOUND), 0,
                               a->salt_remote, &a->remote_ip,
-                              &a->local_ip, NULL, a->dst_port);
+                              &a->local_ip, NULL, a->ipsec_over_udp_port,
+                              a->ipsec_over_udp_port);
 
   rv |= ipsec_tun_protect_update (sw_if_index, NULL, a->local_sa_id, sas_in);
 }
 
 static int
-ikev2_create_tunnel_interface (vnet_main_t * vnm,
+ikev2_create_tunnel_interface (vlib_main_t * vm,
                               u32 thread_index,
                               ikev2_sa_t * sa,
                               ikev2_child_sa_t * child, u32 sa_index,
@@ -1607,7 +1763,7 @@ ikev2_create_tunnel_interface (vnet_main_t * vnm,
     {
       ip46_address_set_ip4 (&a.local_ip, &sa->iaddr);
       ip46_address_set_ip4 (&a.remote_ip, &sa->raddr);
-      proposals = child->i_proposals;
+      proposals = child->r_proposals;
       a.local_spi = child->r_proposals[0].spi;
       a.remote_spi = child->i_proposals[0].spi;
     }
@@ -1615,7 +1771,7 @@ ikev2_create_tunnel_interface (vnet_main_t * vnm,
     {
       ip46_address_set_ip4 (&a.local_ip, &sa->raddr);
       ip46_address_set_ip4 (&a.remote_ip, &sa->iaddr);
-      proposals = child->r_proposals;
+      proposals = child->i_proposals;
       a.local_spi = child->i_proposals[0].spi;
       a.remote_spi = child->r_proposals[0].spi;
     }
@@ -1626,6 +1782,8 @@ ikev2_create_tunnel_interface (vnet_main_t * vnm,
       a.flags |= IPSEC_SA_FLAG_IS_TUNNEL;
       a.flags |= IPSEC_SA_FLAG_UDP_ENCAP;
     }
+  if (sa->natt)
+    a.flags |= IPSEC_SA_FLAG_UDP_ENCAP;
   a.is_rekey = is_rekey;
 
   tr = ikev2_sa_get_td_for_type (proposals, IKEV2_TRANSFORM_TYPE_ESN);
@@ -1737,6 +1895,7 @@ ikev2_create_tunnel_interface (vnet_main_t * vnm,
          a.salt_remote = child->salt_er;
          a.salt_local = child->salt_ei;
        }
+      a.dst_port = a.src_port = sa->ipsec_over_udp_port;
     }
   else
     {
@@ -1749,15 +1908,16 @@ ikev2_create_tunnel_interface (vnet_main_t * vnm,
          a.salt_remote = child->salt_ei;
          a.salt_local = child->salt_er;
        }
+      a.dst_port = sa->natt ? sa->dst_port : sa->ipsec_over_udp_port;
+      a.src_port = sa->ipsec_over_udp_port;
     }
 
-  if (sa->is_profile_index_set)
+  if (sa->is_initiator && sa->profile_index != ~0)
     p = pool_elt_at_index (km->profiles, sa->profile_index);
 
   if (p && p->lifetime)
     {
-      child->time_to_expiration =
-       vlib_time_now (vnm->vlib_main) + p->lifetime;
+      child->time_to_expiration = vlib_time_now (vm) + p->lifetime;
       if (p->lifetime_jitter)
        {
          // This is not much better than rand(3), which Coverity warns
@@ -1765,7 +1925,7 @@ ikev2_create_tunnel_interface (vnet_main_t * vnm,
          // however fast. If this perturbance to the expiration time
          // needs to use a better RNG then we may need to use something
          // like /dev/urandom which has significant overhead.
-         u32 rnd = (u32) (vlib_time_now (vnm->vlib_main) * 1e6);
+         u32 rnd = (u32) (vlib_time_now (vm) * 1e6);
          rnd = random_u32 (&rnd);
 
          child->time_to_expiration += 1 + (rnd % p->lifetime_jitter);
@@ -1810,7 +1970,7 @@ ikev2_create_tunnel_interface (vnet_main_t * vnm,
   child->remote_sa_id = a.remote_sa_id = remote_sa_id;
 
   a.sw_if_index = (sa->is_tun_itf_set ? sa->tun_itf : ~0);
-  a.dst_port = sa->dst_port;
+  a.ipsec_over_udp_port = sa->ipsec_over_udp_port;
 
   vl_api_rpc_call_main_thread (ikev2_add_tunnel_from_main,
                               (u8 *) & a, sizeof (a));
@@ -1909,7 +2069,8 @@ ikev2_delete_tunnel_interface (vnet_main_t * vnm, ikev2_sa_t * sa,
 }
 
 static u32
-ikev2_generate_message (ikev2_sa_t * sa, ike_header_t * ike, void *user)
+ikev2_generate_message (ikev2_sa_t * sa, ike_header_t * ike, void *user,
+                       udp_header_t * udp)
 {
   v8 *integ = 0;
   ike_payload_header_t *ph;
@@ -1963,10 +2124,30 @@ ikev2_generate_message (ikev2_sa_t * sa, ike_header_t * ike, void *user)
        }
       else
        {
+         ASSERT (udp);
+
          ike->rspi = clib_host_to_net_u64 (sa->rspi);
          ikev2_payload_add_sa (chain, sa->r_proposals);
          ikev2_payload_add_ke (chain, sa->dh_group, sa->r_dh_data);
          ikev2_payload_add_nonce (chain, sa->r_nonce);
+
+         u8 *nat_detection_sha1 =
+           ikev2_compute_nat_sha1 (clib_host_to_net_u64 (sa->ispi),
+                                   clib_host_to_net_u64 (sa->rspi),
+                                   sa->raddr.as_u32,
+                                   udp->dst_port);
+         ikev2_payload_add_notify (chain,
+                                   IKEV2_NOTIFY_MSG_NAT_DETECTION_SOURCE_IP,
+                                   nat_detection_sha1);
+         vec_free (nat_detection_sha1);
+         nat_detection_sha1 =
+           ikev2_compute_nat_sha1 (clib_host_to_net_u64 (sa->ispi),
+                                   clib_host_to_net_u64 (sa->rspi),
+                                   sa->iaddr.as_u32, udp->src_port);
+         ikev2_payload_add_notify (chain,
+                                   IKEV2_NOTIFY_MSG_NAT_DETECTION_DESTINATION_IP,
+                                   nat_detection_sha1);
+         vec_free (nat_detection_sha1);
        }
     }
   else if (ike->exchange == IKEV2_EXCHANGE_IKE_AUTH)
@@ -1974,6 +2155,7 @@ ikev2_generate_message (ikev2_sa_t * sa, ike_header_t * ike, void *user)
       if (sa->state == IKEV2_STATE_AUTHENTICATED)
        {
          ikev2_payload_add_id (chain, &sa->r_id, IKEV2_PAYLOAD_IDR);
+         ikev2_payload_add_id (chain, &sa->i_id, IKEV2_PAYLOAD_IDI);
          ikev2_payload_add_auth (chain, &sa->r_auth);
          ikev2_payload_add_sa (chain, sa->childs[0].r_proposals);
          ikev2_payload_add_ts (chain, sa->childs[0].tsi, IKEV2_PAYLOAD_TSI);
@@ -2015,6 +2197,7 @@ ikev2_generate_message (ikev2_sa_t * sa, ike_header_t * ike, void *user)
       else if (sa->state == IKEV2_STATE_SA_INIT)
        {
          ikev2_payload_add_id (chain, &sa->i_id, IKEV2_PAYLOAD_IDI);
+         ikev2_payload_add_id (chain, &sa->r_id, IKEV2_PAYLOAD_IDR);
          ikev2_payload_add_auth (chain, &sa->i_auth);
          ikev2_payload_add_sa (chain, sa->childs[0].i_proposals);
          ikev2_payload_add_ts (chain, sa->childs[0].tsi, IKEV2_PAYLOAD_TSI);
@@ -2095,7 +2278,7 @@ ikev2_generate_message (ikev2_sa_t * sa, ike_header_t * ike, void *user)
        }
       else
        {
-         if (sa->rekey)
+         if (vec_len (sa->rekey) > 0)
            {
              ikev2_payload_add_sa (chain, sa->rekey[0].r_proposal);
              ikev2_payload_add_nonce (chain, sa->r_nonce);
@@ -2148,12 +2331,12 @@ ikev2_generate_message (ikev2_sa_t * sa, ike_header_t * ike, void *user)
       clib_memcpy_fast (ike->payload, chain->data, vec_len (chain->data));
 
       /* store whole IKE payload - needed for PSK auth */
-      vec_free (sa->last_sa_init_res_packet_data);
+      vec_reset_length (sa->last_sa_init_res_packet_data);
       vec_add (sa->last_sa_init_res_packet_data, ike, tlen);
     }
   else
     {
-
+      ikev2_main_per_thread_data_t *ptd = ikev2_get_per_thread_data ();
       ikev2_payload_chain_add_padding (chain, tr_encr->block_size);
 
       /* SK payload */
@@ -2161,27 +2344,43 @@ ikev2_generate_message (ikev2_sa_t * sa, ike_header_t * ike, void *user)
       ph = (ike_payload_header_t *) & ike->payload[0];
       ph->nextpayload = chain->first_payload_type;
       ph->flags = 0;
-      int enc_len = ikev2_encrypt_data (sa, chain->data, ph->payload);
-      plen += enc_len;
-
-      /* add space for hmac */
-      plen += tr_integ->key_trunc;
+      int is_aead =
+       tr_encr->encr_type == IKEV2_TRANSFORM_ENCR_TYPE_AES_GCM_16;
+      int iv_len = is_aead ? IKEV2_GCM_IV_SIZE : tr_encr->block_size;
+      plen += vec_len (chain->data) + iv_len;
+
+      /* add space for hmac/tag */
+      if (tr_integ)
+       plen += tr_integ->key_trunc;
+      else
+       plen += IKEV2_GCM_ICV_SIZE;
       tlen += plen;
 
       /* payload and total length */
       ph->length = clib_host_to_net_u16 (plen);
       ike->length = clib_host_to_net_u32 (tlen);
 
-      /* calc integrity data for whole packet except hash itself */
-      integ =
-       ikev2_calc_integr (tr_integ, sa->is_initiator ? sa->sk_ai : sa->sk_ar,
-                          (u8 *) ike, tlen - tr_integ->key_trunc);
-
-      clib_memcpy_fast (ike->payload + tlen - tr_integ->key_trunc -
-                       sizeof (*ike), integ, tr_integ->key_trunc);
+      if (is_aead)
+       {
+         ikev2_encrypt_aead_data (ptd, sa, tr_encr, chain->data,
+                                  ph->payload, (u8 *) ike,
+                                  sizeof (*ike) + sizeof (*ph),
+                                  ph->payload + plen - sizeof (*ph) -
+                                  IKEV2_GCM_ICV_SIZE);
+       }
+      else
+       {
+         ikev2_encrypt_data (ptd, sa, tr_encr, chain->data, ph->payload);
+         integ =
+           ikev2_calc_integr (tr_integ,
+                              sa->is_initiator ? sa->sk_ai : sa->sk_ar,
+                              (u8 *) ike, tlen - tr_integ->key_trunc);
+         clib_memcpy_fast (ike->payload + tlen - tr_integ->key_trunc -
+                           sizeof (*ike), integ, tr_integ->key_trunc);
+       }
 
       /* store whole IKE payload - needed for retransmit */
-      vec_free (sa->last_res_packet_data);
+      vec_reset_length (sa->last_res_packet_data);
       vec_add (sa->last_res_packet_data, ike, tlen);
     }
 
@@ -2191,9 +2390,9 @@ done:
   return tlen;
 }
 
-static int
+static u32
 ikev2_retransmit_sa_init (ike_header_t * ike,
-                         ip4_address_t iaddr, ip4_address_t raddr)
+                         ip4_address_t iaddr, ip4_address_t raddr, u32 rlen)
 {
   ikev2_main_t *km = &ikev2_main;
   ikev2_sa_t *sa;
@@ -2206,10 +2405,9 @@ ikev2_retransmit_sa_init (ike_header_t * ike,
         sa->raddr.as_u32 == raddr.as_u32)
       {
         int p = 0;
-        u32 len = clib_net_to_host_u32(ike->length);
         u8 payload = ike->nextpayload;
 
-        while (p < len && payload!= IKEV2_PAYLOAD_NONE) {
+        while (p < rlen && payload!= IKEV2_PAYLOAD_NONE) {
           ike_payload_header_t * ikep = (ike_payload_header_t *) &ike->payload[p];
           u32 plen = clib_net_to_host_u16(ikep->length);
 
@@ -2223,8 +2421,8 @@ ikev2_retransmit_sa_init (ike_header_t * ike,
                   /* req is retransmit */
                   if (sa->state == IKEV2_STATE_SA_INIT)
                     {
-                      ike_header_t * tmp;
-                      tmp = (ike_header_t*)sa->last_sa_init_res_packet_data;
+                      ike_header_t * tmp = (ike_header_t*)sa->last_sa_init_res_packet_data;
+                      u32 slen = clib_net_to_host_u32(tmp->length);
                       ike->ispi = tmp->ispi;
                       ike->rspi = tmp->rspi;
                       ike->nextpayload = tmp->nextpayload;
@@ -2233,14 +2431,13 @@ ikev2_retransmit_sa_init (ike_header_t * ike,
                       ike->flags = tmp->flags;
                       ike->msgid = tmp->msgid;
                       ike->length = tmp->length;
-                      clib_memcpy_fast(ike->payload, tmp->payload,
-                             clib_net_to_host_u32(tmp->length) - sizeof(*ike));
+                      clib_memcpy_fast(ike->payload, tmp->payload, slen - sizeof(*ike));
                       ikev2_elog_uint_peers (IKEV2_LOG_DEBUG,
                                              "ispi %lx IKE_SA_INIT retransmit "
                                              "from %d.%d.%d.%d to %d.%d.%d.%d",
                                              ike->ispi,
                                              raddr.as_u32, iaddr.as_u32);
-                      return 1;
+                      return slen;
                     }
                   /* else ignore req */
                   else
@@ -2250,7 +2447,7 @@ ikev2_retransmit_sa_init (ike_header_t * ike,
                                              "from %d.%d.%d.%d to %d.%d.%d.%d",
                                              ike->ispi,
                                              raddr.as_u32, iaddr.as_u32);
-                      return -1;
+                      return ~0;
                     }
                 }
             }
@@ -2265,8 +2462,8 @@ ikev2_retransmit_sa_init (ike_header_t * ike,
   return 0;
 }
 
-static int
-ikev2_retransmit_resp (ikev2_sa_t * sa, ike_header_t * ike)
+static u32
+ikev2_retransmit_resp (ikev2_sa_t * sa, ike_header_t * ike, u32 rlen)
 {
   u32 msg_id = clib_net_to_host_u32 (ike->msgid);
 
@@ -2276,11 +2473,12 @@ ikev2_retransmit_resp (ikev2_sa_t * sa, ike_header_t * ike)
       sa->last_msg_id = msg_id;
       return 0;
     }
+
   /* retransmitted req */
-  else if (msg_id == sa->last_msg_id)
+  if (msg_id == sa->last_msg_id)
     {
-      ike_header_t *tmp;
-      tmp = (ike_header_t *) sa->last_res_packet_data;
+      ike_header_t *tmp = (ike_header_t *) sa->last_res_packet_data;
+      u32 slen = clib_net_to_host_u32 (tmp->length);
       ike->ispi = tmp->ispi;
       ike->rspi = tmp->rspi;
       ike->nextpayload = tmp->nextpayload;
@@ -2289,27 +2487,45 @@ ikev2_retransmit_resp (ikev2_sa_t * sa, ike_header_t * ike)
       ike->flags = tmp->flags;
       ike->msgid = tmp->msgid;
       ike->length = tmp->length;
-      clib_memcpy_fast (ike->payload, tmp->payload,
-                       clib_net_to_host_u32 (tmp->length) - sizeof (*ike));
+      clib_memcpy_fast (ike->payload, tmp->payload, slen - sizeof (*ike));
       ikev2_elog_uint_peers (IKEV2_LOG_DEBUG, "IKE retransmit msgid %d",
                             msg_id, sa->raddr.as_u32, sa->iaddr.as_u32);
-      return 1;
+      return slen;
     }
+
   /* old req ignore */
-  else
+  ikev2_elog_uint_peers (IKEV2_LOG_DEBUG, "IKE req ignore msgid %d",
+                        msg_id, sa->raddr.as_u32, sa->iaddr.as_u32);
+  return ~0;
+}
+
+static void
+ikev2_init_sa (vlib_main_t * vm, ikev2_sa_t * sa)
+{
+  ikev2_main_t *km = &ikev2_main;
+  sa->liveness_period_check = vlib_time_now (vm) + km->liveness_period;
+  sa->profile_index = ~0;
+}
+
+static void
+ikev2_del_sa_init_from_main (u64 * ispi)
+{
+  ikev2_main_t *km = &ikev2_main;
+  uword *p = hash_get (km->sa_by_ispi, *ispi);
+  if (p)
     {
-      ikev2_elog_uint_peers (IKEV2_LOG_DEBUG, "IKE req ignore msgid %d",
-                            msg_id, sa->raddr.as_u32, sa->iaddr.as_u32);
+      ikev2_sa_t *sai = pool_elt_at_index (km->sais, p[0]);
+      hash_unset (km->sa_by_ispi, sai->ispi);
+      ikev2_sa_free_all_vec (sai);
+      pool_put (km->sais, sai);
     }
-  return -1;
 }
 
 static void
-ikev2_init_sa (ikev2_sa_t * sa)
+ikev2_del_sa_init (u64 ispi)
 {
-  ikev2_main_t *km = &ikev2_main;
-  sa->liveness_period_check =
-    vlib_time_now (km->vlib_main) + IKEV2_LIVENESS_PERIOD_CHECK;
+  vl_api_rpc_call_main_thread (ikev2_del_sa_init_from_main, (u8 *) & ispi,
+                              sizeof (ispi));
 }
 
 static uword
@@ -2342,8 +2558,8 @@ ikev2_node_fn (vlib_main_t * vm,
          ike_header_t *ike0;
          ikev2_sa_t *sa0 = 0;
          ikev2_sa_t sa;        /* temporary store for SA */
-         int len = 0;
-         int r;
+         u32 rlen, slen = 0;
+         int is_req = 0, has_non_esp_marker = 0;
 
          /* speculatively enqueue b0 to the current next frame */
          bi0 = from[0];
@@ -2354,11 +2570,43 @@ ikev2_node_fn (vlib_main_t * vm,
          n_left_to_next -= 1;
 
          b0 = vlib_get_buffer (vm, bi0);
-         ike0 = vlib_buffer_get_current (b0);
-         vlib_buffer_advance (b0, -sizeof (*udp0));
-         udp0 = vlib_buffer_get_current (b0);
-         vlib_buffer_advance (b0, -sizeof (*ip40));
-         ip40 = vlib_buffer_get_current (b0);
+
+         if (b0->punt_reason == ipsec_punt_reason[IPSEC_PUNT_IP4_SPI_UDP_0])
+           {
+             u8 *ptr = vlib_buffer_get_current (b0);
+             ip40 = (ip4_header_t *) ptr;
+             ptr += sizeof (*ip40);
+             udp0 = (udp_header_t *) ptr;
+             ptr += sizeof (*udp0);
+             ike0 = (ike_header_t *) ptr;
+           }
+         else
+           {
+             ike0 = vlib_buffer_get_current (b0);
+             vlib_buffer_advance (b0, -sizeof (*udp0));
+             udp0 = vlib_buffer_get_current (b0);
+             vlib_buffer_advance (b0, -sizeof (*ip40));
+             ip40 = vlib_buffer_get_current (b0);
+           }
+
+         rlen = b0->current_length - sizeof (*ip40) - sizeof (*udp0);
+
+         /* check for non-esp marker */
+         if (*((u32 *) ike0) == 0)
+           {
+             ike0 =
+               (ike_header_t *) ((u8 *) ike0 +
+                                 sizeof (ikev2_non_esp_marker));
+             rlen -= sizeof (ikev2_non_esp_marker);
+             has_non_esp_marker = 1;
+           }
+
+         if (clib_net_to_host_u32 (ike0->length) != rlen)
+           {
+             vlib_node_increment_counter (vm, ikev2_node.index,
+                                          IKEV2_ERROR_BAD_LENGTH, 1);
+             goto dispatch0;
+           }
 
          if (ike0->version != IKE_VERSION_2)
            {
@@ -2378,26 +2626,24 @@ ikev2_node_fn (vlib_main_t * vm,
                    {
                      sa0->raddr.as_u32 = ip40->dst_address.as_u32;
                      sa0->iaddr.as_u32 = ip40->src_address.as_u32;
+                     sa0->dst_port = clib_net_to_host_u16 (udp0->src_port);
 
-                     r = ikev2_retransmit_sa_init (ike0, sa0->iaddr,
-                                                   sa0->raddr);
-                     if (r == 1)
+                     slen =
+                       ikev2_retransmit_sa_init (ike0, sa0->iaddr,
+                                                 sa0->raddr, rlen);
+                     if (slen)
                        {
                          vlib_node_increment_counter (vm, ikev2_node.index,
+                                                      ~0 ==
+                                                      slen ?
+                                                      IKEV2_ERROR_IKE_SA_INIT_IGNORE
+                                                      :
                                                       IKEV2_ERROR_IKE_SA_INIT_RETRANSMIT,
                                                       1);
-                         len = clib_net_to_host_u32 (ike0->length);
-                         goto dispatch0;
-                       }
-                     else if (r == -1)
-                       {
-                         vlib_node_increment_counter (vm, ikev2_node.index,
-                                                      IKEV2_ERROR_IKE_SA_INIT_IGNORE,
-                                                      1);
                          goto dispatch0;
                        }
 
-                     ikev2_process_sa_init_req (vm, sa0, ike0);
+                     ikev2_process_sa_init_req (vm, sa0, ike0, udp0, rlen);
 
                      if (sa0->state == IKEV2_STATE_SA_INIT)
                        {
@@ -2411,7 +2657,7 @@ ikev2_node_fn (vlib_main_t * vm,
                      if (sa0->state == IKEV2_STATE_SA_INIT
                          || sa0->state == IKEV2_STATE_NOTIFY_AND_DELETE)
                        {
-                         len = ikev2_generate_message (sa0, ike0, 0);
+                         slen = ikev2_generate_message (sa0, ike0, 0, udp0);
                        }
 
                      if (sa0->state == IKEV2_STATE_SA_INIT)
@@ -2420,7 +2666,7 @@ ikev2_node_fn (vlib_main_t * vm,
                          pool_get (km->per_thread_data[thread_index].sas,
                                    sa0);
                          clib_memcpy_fast (sa0, &sa, sizeof (*sa0));
-                         ikev2_init_sa (sa0);
+                         ikev2_init_sa (vm, sa0);
                          hash_set (km->
                                    per_thread_data[thread_index].sa_by_rspi,
                                    sa0->rspi,
@@ -2435,28 +2681,33 @@ ikev2_node_fn (vlib_main_t * vm,
                }
              else              //received sa_init without initiator flag
                {
-                 ikev2_process_sa_init_resp (vm, sa0, ike0);
+                 sa0->raddr.as_u32 = ip40->src_address.as_u32;
+                 sa0->iaddr.as_u32 = ip40->dst_address.as_u32;
+                 ikev2_process_sa_init_resp (vm, sa0, ike0, udp0, rlen);
 
                  if (sa0->state == IKEV2_STATE_SA_INIT)
                    {
+                     is_req = 1;
                      ike0->exchange = IKEV2_EXCHANGE_IKE_AUTH;
-                     uword *p = hash_get (km->sa_by_ispi, ike0->ispi);
+                     uword *p = hash_get (km->sa_by_ispi, sa0->ispi);
                      if (p)
                        {
                          ikev2_sa_t *sai =
                            pool_elt_at_index (km->sais, p[0]);
 
-                         if (sai->init_response_received)
-                           {
-                             /* we've already processed sa-init response */
-                             sa0->state = IKEV2_STATE_UNKNOWN;
-                           }
-                         else
+                         if (clib_atomic_bool_cmp_and_swap
+                             (&sai->init_response_received, 0, 1))
                            {
                              ikev2_complete_sa_data (sa0, sai);
                              ikev2_calc_keys (sa0);
                              ikev2_sa_auth_init (sa0);
-                             len = ikev2_generate_message (sa0, ike0, 0);
+                             slen =
+                               ikev2_generate_message (sa0, ike0, 0, udp0);
+                           }
+                         else
+                           {
+                             /* we've already processed sa-init response */
+                             sa0->state = IKEV2_STATE_UNKNOWN;
                            }
                        }
                    }
@@ -2487,51 +2738,39 @@ ikev2_node_fn (vlib_main_t * vm,
                    pool_elt_at_index (km->per_thread_data[thread_index].sas,
                                       p[0]);
 
-                 r = ikev2_retransmit_resp (sa0, ike0);
-                 if (r == 1)
+                 slen = ikev2_retransmit_resp (sa0, ike0, rlen);
+                 if (slen)
                    {
                      vlib_node_increment_counter (vm, ikev2_node.index,
+                                                  ~0 ==
+                                                  slen ?
+                                                  IKEV2_ERROR_IKE_REQ_IGNORE
+                                                  :
                                                   IKEV2_ERROR_IKE_REQ_RETRANSMIT,
                                                   1);
-                     len = clib_net_to_host_u32 (ike0->length);
-                     goto dispatch0;
-                   }
-                 else if (r == -1)
-                   {
-                     vlib_node_increment_counter (vm, ikev2_node.index,
-                                                  IKEV2_ERROR_IKE_REQ_IGNORE,
-                                                  1);
                      goto dispatch0;
                    }
 
-                 ikev2_process_auth_req (vm, sa0, ike0);
+                 sa0->dst_port = clib_net_to_host_u16 (udp0->src_port);
+                 ikev2_process_auth_req (vm, sa0, ike0, rlen);
                  ikev2_sa_auth (sa0);
                  if (sa0->state == IKEV2_STATE_AUTHENTICATED)
                    {
                      ikev2_initial_contact_cleanup (sa0);
                      ikev2_sa_match_ts (sa0);
                      if (sa0->state != IKEV2_STATE_TS_UNACCEPTABLE)
-                       ikev2_create_tunnel_interface (km->vnet_main,
-                                                      thread_index, sa0,
+                       ikev2_create_tunnel_interface (vm, thread_index, sa0,
                                                       &sa0->childs[0],
                                                       p[0], 0, 0);
                    }
 
                  if (sa0->is_initiator)
                    {
-                     uword *p = hash_get (km->sa_by_ispi, ike0->ispi);
-                     if (p)
-                       {
-                         ikev2_sa_t *sai =
-                           pool_elt_at_index (km->sais, p[0]);
-                         hash_unset (km->sa_by_ispi, sai->ispi);
-                         ikev2_sa_free_all_vec (sai);
-                         pool_put (km->sais, sai);
-                       }
+                     ikev2_del_sa_init (sa0->ispi);
                    }
                  else
                    {
-                     len = ikev2_generate_message (sa0, ike0, 0);
+                     slen = ikev2_generate_message (sa0, ike0, 0, udp0);
                    }
                }
            }
@@ -2546,24 +2785,20 @@ ikev2_node_fn (vlib_main_t * vm,
                    pool_elt_at_index (km->per_thread_data[thread_index].sas,
                                       p[0]);
 
-                 r = ikev2_retransmit_resp (sa0, ike0);
-                 if (r == 1)
+                 slen = ikev2_retransmit_resp (sa0, ike0, rlen);
+                 if (slen)
                    {
                      vlib_node_increment_counter (vm, ikev2_node.index,
+                                                  ~0 ==
+                                                  slen ?
+                                                  IKEV2_ERROR_IKE_REQ_IGNORE
+                                                  :
                                                   IKEV2_ERROR_IKE_REQ_RETRANSMIT,
                                                   1);
-                     len = clib_net_to_host_u32 (ike0->length);
-                     goto dispatch0;
-                   }
-                 else if (r == -1)
-                   {
-                     vlib_node_increment_counter (vm, ikev2_node.index,
-                                                  IKEV2_ERROR_IKE_REQ_IGNORE,
-                                                  1);
                      goto dispatch0;
                    }
 
-                 ikev2_process_informational_req (vm, sa0, ike0);
+                 ikev2_process_informational_req (vm, sa0, ike0, rlen);
                  if (sa0->del)
                    {
                      if (sa0->del[0].protocol_id != IKEV2_PROTOCOL_IKE)
@@ -2598,7 +2833,7 @@ ikev2_node_fn (vlib_main_t * vm,
                  if (!(ike0->flags & IKEV2_HDR_FLAG_RESPONSE))
                    {
                      ike0->flags |= IKEV2_HDR_FLAG_RESPONSE;
-                     len = ikev2_generate_message (sa0, ike0, 0);
+                     slen = ikev2_generate_message (sa0, ike0, 0, udp0);
                    }
                }
            }
@@ -2613,49 +2848,45 @@ ikev2_node_fn (vlib_main_t * vm,
                    pool_elt_at_index (km->per_thread_data[thread_index].sas,
                                       p[0]);
 
-                 r = ikev2_retransmit_resp (sa0, ike0);
-                 if (r == 1)
+                 slen = ikev2_retransmit_resp (sa0, ike0, rlen);
+                 if (slen)
                    {
                      vlib_node_increment_counter (vm, ikev2_node.index,
+                                                  ~0 ==
+                                                  slen ?
+                                                  IKEV2_ERROR_IKE_REQ_IGNORE
+                                                  :
                                                   IKEV2_ERROR_IKE_REQ_RETRANSMIT,
                                                   1);
-                     len = clib_net_to_host_u32 (ike0->length);
-                     goto dispatch0;
-                   }
-                 else if (r == -1)
-                   {
-                     vlib_node_increment_counter (vm, ikev2_node.index,
-                                                  IKEV2_ERROR_IKE_REQ_IGNORE,
-                                                  1);
                      goto dispatch0;
                    }
 
-                 ikev2_process_create_child_sa_req (vm, sa0, ike0);
+                 ikev2_process_create_child_sa_req (vm, sa0, ike0, rlen);
                  if (sa0->rekey)
                    {
                      if (sa0->rekey[0].protocol_id != IKEV2_PROTOCOL_IKE)
                        {
                          if (sa0->childs)
-                           vec_free (sa0->childs);
+                           ikev2_sa_free_all_child_sa (&sa0->childs);
                          ikev2_child_sa_t *child;
                          vec_add2 (sa0->childs, child, 1);
+                         clib_memset (child, 0, sizeof (*child));
                          child->r_proposals = sa0->rekey[0].r_proposal;
                          child->i_proposals = sa0->rekey[0].i_proposal;
                          child->tsi = sa0->rekey[0].tsi;
                          child->tsr = sa0->rekey[0].tsr;
-                         ikev2_create_tunnel_interface (km->vnet_main,
-                                                        thread_index, sa0,
-                                                        child, p[0],
+                         ikev2_create_tunnel_interface (vm, thread_index,
+                                                        sa0, child, p[0],
                                                         child - sa0->childs,
                                                         1);
                        }
                      if (sa0->is_initiator)
                        {
-                         vec_del1 (sa0->rekey, 0);
+                         vec_free (sa0->rekey);
                        }
                      else
                        {
-                         len = ikev2_generate_message (sa0, ike0, 0);
+                         slen = ikev2_generate_message (sa0, ike0, 0, udp0);
                        }
                    }
                }
@@ -2671,7 +2902,7 @@ ikev2_node_fn (vlib_main_t * vm,
 
        dispatch0:
          /* if we are sending packet back, rewrite headers */
-         if (len)
+         if (slen && ~0 != slen)
            {
              next0 = IKEV2_NEXT_IP4_LOOKUP;
              if (sa0->is_initiator)
@@ -2684,11 +2915,34 @@ ikev2_node_fn (vlib_main_t * vm,
                  ip40->dst_address.as_u32 = sa0->iaddr.as_u32;
                  ip40->src_address.as_u32 = sa0->raddr.as_u32;
                }
+
+             if (is_req)
+               {
+                 udp0->dst_port = udp0->src_port =
+                   clib_net_to_host_u16 (ikev2_get_port (sa0));
+
+                 if (udp0->dst_port == clib_net_to_host_u16 (IKEV2_PORT_NATT)
+                     && sa0->natt)
+                   {
+                     if (!has_non_esp_marker)
+                       slen = ikev2_insert_non_esp_marker (ike0, slen);
+                   }
+               }
+             else
+               {
+                 if (has_non_esp_marker)
+                   slen += sizeof (ikev2_non_esp_marker);
+
+                 u16 tp = udp0->dst_port;
+                 udp0->dst_port = udp0->src_port;
+                 udp0->src_port = tp;
+               }
+
              udp0->length =
-               clib_host_to_net_u16 (len + sizeof (udp_header_t));
+               clib_host_to_net_u16 (slen + sizeof (udp_header_t));
              udp0->checksum = 0;
              b0->current_length =
-               len + sizeof (ip4_header_t) + sizeof (udp_header_t);
+               slen + sizeof (ip4_header_t) + sizeof (udp_header_t);
              ip40->length = clib_host_to_net_u16 (b0->current_length);
              ip40->checksum = ip4_header_checksum (ip40);
            }
@@ -2783,7 +3037,7 @@ ikev2_set_initiator_proposals (vlib_main_t * vm, ikev2_sa_t * sa,
       return r;
     }
 
-  if (is_ike || IKEV2_TRANSFORM_ENCR_TYPE_AES_GCM_16 != ts->crypto_alg)
+  if (IKEV2_TRANSFORM_INTEG_TYPE_NONE != ts->integ_alg)
     {
       /* Integrity */
       error = 1;
@@ -2828,7 +3082,7 @@ ikev2_set_initiator_proposals (vlib_main_t * vm, ikev2_sa_t * sa,
     }
 
   /* DH */
-  if (is_ike || ts->dh_type != IKEV2_TRANSFORM_DH_TYPE_NONE)
+  if (is_ike)
     {
       error = 1;
       vec_foreach (td, km->supported_transforms)
@@ -2860,7 +3114,6 @@ ikev2_set_initiator_proposals (vlib_main_t * vm, ikev2_sa_t * sa,
          {
            vec_add1 (proposal->transforms, *td);
            error = 0;
-           break;
          }
       }
       if (error)
@@ -2890,7 +3143,7 @@ ikev2_profile_index_by_name (u8 * name)
 
 static void
 ikev2_send_ike (vlib_main_t * vm, ip4_address_t * src, ip4_address_t * dst,
-               u32 bi0, u32 len)
+               u32 bi0, u32 len, u16 src_port, u16 dst_port, u32 sw_if_index)
 {
   ip4_header_t *ip40;
   udp_header_t *udp0;
@@ -2913,14 +3166,16 @@ ikev2_send_ike (vlib_main_t * vm, ip4_address_t * src, ip4_address_t * dst,
   ip40->protocol = IP_PROTOCOL_UDP;
   ip40->dst_address.as_u32 = dst->as_u32;
   ip40->src_address.as_u32 = src->as_u32;
-  udp0->dst_port = clib_host_to_net_u16 (500);
-  udp0->src_port = clib_host_to_net_u16 (500);
+  udp0->dst_port = clib_host_to_net_u16 (dst_port);
+  udp0->src_port = clib_host_to_net_u16 (src_port);
   udp0->length = clib_host_to_net_u16 (len + sizeof (udp_header_t));
   udp0->checksum = 0;
   b0->current_length = len + sizeof (ip4_header_t) + sizeof (udp_header_t);
   ip40->length = clib_host_to_net_u16 (b0->current_length);
   ip40->checksum = ip4_header_checksum (ip40);
 
+  vnet_buffer (b0)->sw_if_index[VLIB_RX] = sw_if_index;
+  vnet_buffer (b0)->sw_if_index[VLIB_TX] = ~0;
 
   /* send the request */
   f = vlib_get_frame_to_node (vm, ip4_lookup_node.index);
@@ -2950,6 +3205,8 @@ ikev2_set_local_key (vlib_main_t * vm, u8 * file)
 {
   ikev2_main_t *km = &ikev2_main;
 
+  if (km->pkey)
+    EVP_PKEY_free (km->pkey);
   km->pkey = ikev2_load_key_file (file);
   if (km->pkey == NULL)
     return clib_error_return (0, "load key '%s' failed", file);
@@ -2981,7 +3238,7 @@ ikev2_register_udp_port (ikev2_profile_t * p, u16 port)
                             ipsec4_tun_input_node.index, 1);
       hash_set (km->udp_ports, port, 1);
     }
-  p->dst_port = port;
+  p->ipsec_over_udp_port = port;
   return 0;
 }
 
@@ -2991,10 +3248,10 @@ ikev2_unregister_udp_port (ikev2_profile_t * p)
   ikev2_main_t *km = &ikev2_main;
   uword *v;
 
-  if (p->dst_port == IPSEC_UDP_PORT_NONE)
+  if (p->ipsec_over_udp_port == IPSEC_UDP_PORT_NONE)
     return;
 
-  v = hash_get (km->udp_ports, p->dst_port);
+  v = hash_get (km->udp_ports, p->ipsec_over_udp_port);
   if (!v)
     return;
 
@@ -3002,11 +3259,113 @@ ikev2_unregister_udp_port (ikev2_profile_t * p)
 
   if (v[0] == 0)
     {
-      udp_unregister_dst_port (km->vlib_main, p->dst_port, 1);
-      hash_unset (km->udp_ports, p->dst_port);
+      udp_unregister_dst_port (km->vlib_main, p->ipsec_over_udp_port, 1);
+      hash_unset (km->udp_ports, p->ipsec_over_udp_port);
+    }
+
+  p->ipsec_over_udp_port = IPSEC_UDP_PORT_NONE;
+}
+
+static void
+ikev2_initiate_delete_ike_sa_internal (vlib_main_t * vm,
+                                      ikev2_main_per_thread_data_t * tkm,
+                                      ikev2_sa_t * sa)
+{
+  ikev2_main_t *km = &ikev2_main;
+  ip4_address_t *src, *dst;
+
+  /* Create the Initiator notification for IKE SA removal */
+  ike_header_t *ike0;
+  u32 bi0 = 0;
+  int len;
+
+  bi0 = ikev2_get_new_ike_header_buff (vm, &ike0);
+  if (!bi0)
+    {
+      ikev2_log_error ("buffer alloc failure");
+      return;
+    }
+
+  ike0->exchange = IKEV2_EXCHANGE_INFORMATIONAL;
+  ike0->ispi = clib_host_to_net_u64 (sa->ispi);
+  ike0->rspi = clib_host_to_net_u64 (sa->rspi);
+  vec_resize (sa->del, 1);
+  sa->del->protocol_id = IKEV2_PROTOCOL_IKE;
+  sa->del->spi = sa->ispi;
+  ike0->msgid = clib_host_to_net_u32 (sa->last_init_msg_id + 1);
+  sa->last_init_msg_id = clib_net_to_host_u32 (ike0->msgid);
+  len = ikev2_generate_message (sa, ike0, 0, 0);
+
+  if (sa->is_initiator)
+    {
+      src = &sa->iaddr;
+      dst = &sa->raddr;
+    }
+  else
+    {
+      dst = &sa->iaddr;
+      src = &sa->raddr;
     }
 
-  p->dst_port = IPSEC_UDP_PORT_NONE;
+  ikev2_send_ike (vm, src, dst, bi0, len,
+                 ikev2_get_port (sa), sa->dst_port, 0);
+
+  /* delete local SA */
+  ikev2_child_sa_t *c;
+  vec_foreach (c, sa->childs)
+    ikev2_delete_tunnel_interface (km->vnet_main, sa, c);
+
+  u64 rspi = sa->rspi;
+  ikev2_sa_free_all_vec (sa);
+  uword *p = hash_get (tkm->sa_by_rspi, rspi);
+  if (p)
+    {
+      hash_unset (tkm->sa_by_rspi, rspi);
+      pool_put (tkm->sas, sa);
+    }
+}
+
+static void
+ikev2_cleanup_profile_sessions (ikev2_main_t * km, ikev2_profile_t * p)
+{
+  ikev2_main_per_thread_data_t *tkm;
+  ikev2_sa_t *sa;
+  u32 pi = p - km->profiles;
+  u32 *sai;
+  u32 *del_sai = 0;
+
+  vec_foreach (tkm, km->per_thread_data)
+  {
+    /* *INDENT-OFF* */
+    pool_foreach (sa, tkm->sas, ({
+      if (sa->profile_index != ~0 && pi == sa->profile_index)
+        vec_add1 (del_sai, sa - tkm->sas);
+    }));
+    /* *INDENT-ON* */
+
+    vec_foreach (sai, del_sai)
+    {
+      sa = pool_elt_at_index (tkm->sas, sai[0]);
+      ikev2_initiate_delete_ike_sa_internal (km->vlib_main, tkm, sa);
+    }
+
+    vec_reset_length (del_sai);
+  }
+
+  vec_free (del_sai);
+}
+
+static void
+ikev2_profile_free (ikev2_profile_t * p)
+{
+  vec_free (p->name);
+
+  vec_free (p->auth.data);
+  if (p->auth.key)
+    EVP_PKEY_free (p->auth.key);
+
+  vec_free (p->loc_id.data);
+  vec_free (p->rem_id.data);
 }
 
 clib_error_t *
@@ -3023,7 +3382,7 @@ ikev2_add_del_profile (vlib_main_t * vm, u8 * name, int is_add)
       pool_get (km->profiles, p);
       clib_memset (p, 0, sizeof (*p));
       p->name = vec_dup (name);
-      p->dst_port = IPSEC_UDP_PORT_NONE;
+      p->ipsec_over_udp_port = IPSEC_UDP_PORT_NONE;
       p->responder.sw_if_index = ~0;
       p->tun_itf = ~0;
       uword index = p - km->profiles;
@@ -3036,8 +3395,9 @@ ikev2_add_del_profile (vlib_main_t * vm, u8 * name, int is_add)
        return clib_error_return (0, "policy %v does not exists", name);
 
       ikev2_unregister_udp_port (p);
+      ikev2_cleanup_profile_sessions (km, p);
 
-      vec_free (p->name);
+      ikev2_profile_free (p);
       pool_put (km->profiles, p);
       mhash_unset (&km->profile_index_by_name, name, 0);
     }
@@ -3058,7 +3418,11 @@ ikev2_set_profile_auth (vlib_main_t * vm, u8 * name, u8 auth_method,
       r = clib_error_return (0, "unknown profile %v", name);
       return r;
     }
+
+  if (p->auth.key)
+    EVP_PKEY_free (p->auth.key);
   vec_free (p->auth.data);
+
   p->auth.method = auth_method;
   p->auth.data = vec_dup (auth_data);
   p->auth.hex = data_hex_format;
@@ -3066,11 +3430,9 @@ ikev2_set_profile_auth (vlib_main_t * vm, u8 * name, u8 auth_method,
   if (auth_method == IKEV2_AUTH_METHOD_RSA_SIG)
     {
       vec_add1 (p->auth.data, 0);
-      if (p->auth.key)
-       EVP_PKEY_free (p->auth.key);
-      p->auth.key = ikev2_load_cert_file (auth_data);
+      p->auth.key = ikev2_load_cert_file (p->auth.data);
       if (p->auth.key == NULL)
-       return clib_error_return (0, "load cert '%s' failed", auth_data);
+       return clib_error_return (0, "load cert '%s' failed", p->auth.data);
     }
 
   return 0;
@@ -3204,7 +3566,6 @@ clib_error_t *
 ikev2_set_profile_esp_transforms (vlib_main_t * vm, u8 * name,
                                  ikev2_transform_encr_type_t crypto_alg,
                                  ikev2_transform_integ_type_t integ_alg,
-                                 ikev2_transform_dh_type_t dh_type,
                                  u32 crypto_key_size)
 {
   ikev2_profile_t *p;
@@ -3220,7 +3581,6 @@ ikev2_set_profile_esp_transforms (vlib_main_t * vm, u8 * name,
 
   p->esp_ts.crypto_alg = crypto_alg;
   p->esp_ts.integ_alg = integ_alg;
-  p->esp_ts.dh_type = dh_type;
   p->esp_ts.crypto_key_size = crypto_key_size;
   return 0;
 }
@@ -3259,7 +3619,7 @@ ikev2_set_profile_ipsec_udp_port (vlib_main_t * vm, u8 * name, u16 port,
 
   if (is_set)
     {
-      if (p->dst_port != IPSEC_UDP_PORT_NONE)
+      if (p->ipsec_over_udp_port != IPSEC_UDP_PORT_NONE)
        return VNET_API_ERROR_VALUE_EXIST;
 
       rv = ikev2_register_udp_port (p, port);
@@ -3270,7 +3630,7 @@ ikev2_set_profile_ipsec_udp_port (vlib_main_t * vm, u8 * name, u16 port,
       if (!v)
        return VNET_API_ERROR_IKE_NO_PORT;
 
-      if (p->dst_port == IPSEC_UDP_PORT_NONE)
+      if (p->ipsec_over_udp_port == IPSEC_UDP_PORT_NONE)
        return VNET_API_ERROR_INVALID_VALUE;
 
       ikev2_unregister_udp_port (p);
@@ -3356,6 +3716,12 @@ ikev2_initiate_sa_init (vlib_main_t * vm, u8 * name)
     ip4_address_t *if_ip = ip_interface_address_get_address (lm, if_add);
 
     bi0 = ikev2_get_new_ike_header_buff (vm, &ike0);
+    if (!bi0)
+      {
+       char *errmsg = "buffer alloc failure";
+       ikev2_log_error (errmsg);
+       return clib_error_return (0, errmsg);
+      }
 
     /* Prepare the SA and the IKE payload */
     ikev2_sa_t sa;
@@ -3374,14 +3740,14 @@ ikev2_initiate_sa_init (vlib_main_t * vm, u8 * name)
     ikev2_sa_free_proposal_vector (&proposals);
 
     sa.is_initiator = 1;
-    sa.profile_index = km->profiles - p;
-    sa.is_profile_index_set = 1;
+    sa.profile_index = p - km->profiles;
     sa.state = IKEV2_STATE_SA_INIT;
     sa.tun_itf = p->tun_itf;
     sa.udp_encap = p->udp_encap;
-    sa.dst_port = p->dst_port;
+    sa.ipsec_over_udp_port = p->ipsec_over_udp_port;
     sa.is_tun_itf_set = 1;
     sa.initial_contact = 1;
+    sa.dst_port = IKEV2_PORT;
     ikev2_generate_sa_init_data (&sa);
     ikev2_payload_add_ke (chain, sa.dh_group, sa.i_dh_data);
     ikev2_payload_add_nonce (chain, sa.i_nonce);
@@ -3395,29 +3761,21 @@ ikev2_initiate_sa_init (vlib_main_t * vm, u8 * name)
     RAND_bytes ((u8 *) & sa.childs[0].i_proposals[0].spi,
                sizeof (sa.childs[0].i_proposals[0].spi));
 
-
-
     /* Add NAT detection notification messages (mandatory) */
-    u8 nat_detection_source[8 + 8 + 4 + 2];
-    u8 *nat_detection_sha1 = vec_new (u8, 20);
-
-    u64 tmpspi = clib_host_to_net_u64 (sa.ispi);
-    clib_memcpy_fast (&nat_detection_source[0], &tmpspi, sizeof (tmpspi));
-    tmpspi = clib_host_to_net_u64 (sa.rspi);
-    clib_memcpy_fast (&nat_detection_source[8], &tmpspi, sizeof (tmpspi));
-    u16 tmpport = clib_host_to_net_u16 (500);
-    clib_memcpy_fast (&nat_detection_source[8 + 8 + 4], &tmpport,
-                     sizeof (tmpport));
-    u32 tmpip = clib_host_to_net_u32 (if_ip->as_u32);
-    clib_memcpy_fast (&nat_detection_source[8 + 8], &tmpip, sizeof (tmpip));
-    SHA1 (nat_detection_source, sizeof (nat_detection_source),
-         nat_detection_sha1);
+    u8 *nat_detection_sha1 =
+      ikev2_compute_nat_sha1 (clib_host_to_net_u64 (sa.ispi),
+                             clib_host_to_net_u64 (sa.rspi),
+                             if_ip->as_u32,
+                             clib_host_to_net_u16 (IKEV2_PORT));
+
     ikev2_payload_add_notify (chain, IKEV2_NOTIFY_MSG_NAT_DETECTION_SOURCE_IP,
                              nat_detection_sha1);
-    tmpip = clib_host_to_net_u32 (p->responder.ip4.as_u32);
-    clib_memcpy_fast (&nat_detection_source[8 + 8], &tmpip, sizeof (tmpip));
-    SHA1 (nat_detection_source, sizeof (nat_detection_source),
-         nat_detection_sha1);
+    vec_free (nat_detection_sha1);
+    nat_detection_sha1 =
+      ikev2_compute_nat_sha1 (clib_host_to_net_u64 (sa.ispi),
+                             clib_host_to_net_u64 (sa.rspi),
+                             p->responder.ip4.as_u32,
+                             clib_host_to_net_u16 (sa.dst_port));
     ikev2_payload_add_notify (chain,
                              IKEV2_NOTIFY_MSG_NAT_DETECTION_DESTINATION_IP,
                              nat_detection_sha1);
@@ -3442,12 +3800,12 @@ ikev2_initiate_sa_init (vlib_main_t * vm, u8 * name)
     ike0->version = IKE_VERSION_2;
     ike0->flags = IKEV2_HDR_FLAG_INITIATOR;
     ike0->exchange = IKEV2_EXCHANGE_SA_INIT;
-    ike0->ispi = sa.ispi;
+    ike0->ispi = clib_host_to_net_u64 (sa.ispi);
     ike0->rspi = 0;
     ike0->msgid = 0;
 
     /* store whole IKE payload - needed for PSK auth */
-    vec_free (sa.last_sa_init_req_packet_data);
+    vec_reset_length (sa.last_sa_init_req_packet_data);
     vec_add (sa.last_sa_init_req_packet_data, ike0, len);
 
     /* add data to the SA then add it to the pool */
@@ -3455,9 +3813,12 @@ ikev2_initiate_sa_init (vlib_main_t * vm, u8 * name)
     sa.raddr.as_u32 = p->responder.ip4.as_u32;
     sa.i_id.type = p->loc_id.type;
     sa.i_id.data = vec_dup (p->loc_id.data);
+    sa.r_id.type = p->rem_id.type;
+    sa.r_id.data = vec_dup (p->rem_id.data);
     sa.i_auth.method = p->auth.method;
     sa.i_auth.hex = p->auth.hex;
     sa.i_auth.data = vec_dup (p->auth.data);
+    sa.sw_if_index = p->responder.sw_if_index;
     vec_add (sa.childs[0].tsi, &p->loc_ts, 1);
     vec_add (sa.childs[0].tsr, &p->rem_ts, 1);
 
@@ -3469,7 +3830,8 @@ ikev2_initiate_sa_init (vlib_main_t * vm, u8 * name)
     clib_memcpy_fast (sa0, &sa, sizeof (*sa0));
     hash_set (km->sa_by_ispi, sa0->ispi, sa0 - km->sais);
 
-    ikev2_send_ike (vm, if_ip, &p->responder.ip4, bi0, len);
+    ikev2_send_ike (vm, if_ip, &p->responder.ip4, bi0, len,
+                   IKEV2_PORT, sa.dst_port, sa.sw_if_index);
 
     ikev2_elog_exchange ("ispi %lx rspi %lx IKEV2_EXCHANGE_SA_INIT sent to "
                         "%d.%d.%d.%d", clib_host_to_net_u64 (sa0->ispi), 0,
@@ -3490,7 +3852,11 @@ ikev2_delete_child_sa_internal (vlib_main_t * vm, ikev2_sa_t * sa,
   int len;
 
   bi0 = ikev2_get_new_ike_header_buff (vm, &ike0);
-
+  if (!bi0)
+    {
+      ikev2_log_error ("buffer alloc failure");
+      return;
+    }
 
   ike0->exchange = IKEV2_EXCHANGE_INFORMATIONAL;
   ike0->ispi = clib_host_to_net_u64 (sa->ispi);
@@ -3500,9 +3866,11 @@ ikev2_delete_child_sa_internal (vlib_main_t * vm, ikev2_sa_t * sa,
   sa->del->spi = csa->i_proposals->spi;
   ike0->msgid = clib_host_to_net_u32 (sa->last_init_msg_id + 1);
   sa->last_init_msg_id = clib_net_to_host_u32 (ike0->msgid);
-  len = ikev2_generate_message (sa, ike0, 0);
-
-  ikev2_send_ike (vm, &sa->iaddr, &sa->raddr, bi0, len);
+  len = ikev2_generate_message (sa, ike0, 0, 0);
+  if (sa->natt)
+    len = ikev2_insert_non_esp_marker (ike0, len);
+  ikev2_send_ike (vm, &sa->iaddr, &sa->raddr, bi0, len,
+                 ikev2_get_port (sa), sa->dst_port, sa->sw_if_index);
 
   /* delete local child SA */
   ikev2_delete_tunnel_interface (km->vnet_main, sa, csa);
@@ -3582,46 +3950,7 @@ ikev2_initiate_delete_ike_sa (vlib_main_t * vm, u64 ispi)
       return r;
     }
 
-
-  /* Create the Initiator notification for IKE SA removal */
-  {
-    ike_header_t *ike0;
-    u32 bi0 = 0;
-    int len;
-
-    bi0 = ikev2_get_new_ike_header_buff (vm, &ike0);
-
-
-    ike0->exchange = IKEV2_EXCHANGE_INFORMATIONAL;
-    ike0->ispi = clib_host_to_net_u64 (fsa->ispi);
-    ike0->rspi = clib_host_to_net_u64 (fsa->rspi);
-    vec_resize (fsa->del, 1);
-    fsa->del->protocol_id = IKEV2_PROTOCOL_IKE;
-    fsa->del->spi = ispi;
-    ike0->msgid = clib_host_to_net_u32 (fsa->last_init_msg_id + 1);
-    fsa->last_init_msg_id = clib_net_to_host_u32 (ike0->msgid);
-    len = ikev2_generate_message (fsa, ike0, 0);
-
-    ikev2_send_ike (vm, &fsa->iaddr, &fsa->raddr, bi0, len);
-  }
-
-
-  /* delete local SA */
-  ikev2_child_sa_t *c;
-  vec_foreach (c, fsa->childs)
-  {
-    ikev2_delete_tunnel_interface (km->vnet_main, fsa, c);
-    ikev2_sa_del_child_sa (fsa, c);
-  }
-  ikev2_sa_free_all_vec (fsa);
-  uword *p = hash_get (ftkm->sa_by_rspi, fsa->rspi);
-  if (p)
-    {
-      hash_unset (ftkm->sa_by_rspi, fsa->rspi);
-      pool_put (ftkm->sas, fsa);
-    }
-
-
+  ikev2_initiate_delete_ike_sa_internal (vm, ftkm, fsa);
   return 0;
 }
 
@@ -3634,9 +3963,12 @@ ikev2_rekey_child_sa_internal (vlib_main_t * vm, ikev2_sa_t * sa,
   u32 bi0 = 0;
   int len;
 
-
   bi0 = ikev2_get_new_ike_header_buff (vm, &ike0);
-
+  if (!bi0)
+    {
+      ikev2_log_error ("buffer alloc failure");
+      return;
+    }
 
   ike0->version = IKE_VERSION_2;
   ike0->flags = IKEV2_HDR_FLAG_INITIATOR;
@@ -3654,8 +3986,11 @@ ikev2_rekey_child_sa_internal (vlib_main_t * vm, ikev2_sa_t * sa,
   RAND_bytes ((u8 *) & proposals[0].spi, sizeof (proposals[0].spi));
   rekey->spi = proposals[0].spi;
   rekey->ispi = csa->i_proposals->spi;
-  len = ikev2_generate_message (sa, ike0, proposals);
-  ikev2_send_ike (vm, &sa->iaddr, &sa->raddr, bi0, len);
+  len = ikev2_generate_message (sa, ike0, proposals, 0);
+  if (sa->natt)
+    len = ikev2_insert_non_esp_marker (ike0, len);
+  ikev2_send_ike (vm, &sa->iaddr, &sa->raddr, bi0, len,
+                 ikev2_get_port (sa), ikev2_get_port (sa), sa->sw_if_index);
   vec_free (proposals);
 }
 
@@ -3710,24 +4045,42 @@ ikev2_init (vlib_main_t * vm)
   km->vnet_main = vnet_get_main ();
   km->vlib_main = vm;
 
+  km->liveness_period = IKEV2_LIVENESS_PERIOD_CHECK;
+  km->liveness_max_retries = IKEV2_LIVENESS_RETRIES;
   ikev2_crypto_init (km);
 
   mhash_init_vec_string (&km->profile_index_by_name, sizeof (uword));
 
   vec_validate_aligned (km->per_thread_data, tm->n_vlib_mains - 1,
                        CLIB_CACHE_LINE_BYTES);
-  for (thread_id = 0; thread_id < tm->n_vlib_mains - 1; thread_id++)
+  for (thread_id = 0; thread_id < tm->n_vlib_mains; thread_id++)
     {
-      km->per_thread_data[thread_id].sa_by_rspi =
-       hash_create (0, sizeof (uword));
+      ikev2_main_per_thread_data_t *ptd =
+       vec_elt_at_index (km->per_thread_data, thread_id);
+
+      ptd->sa_by_rspi = hash_create (0, sizeof (uword));
+
+#if OPENSSL_VERSION_NUMBER >= 0x10100000L
+      ptd->evp_ctx = EVP_CIPHER_CTX_new ();
+      ptd->hmac_ctx = HMAC_CTX_new ();
+#else
+      EVP_CIPHER_CTX_init (&ptd->_evp_ctx);
+      ptd->evp_ctx = &ptd->_evp_ctx;
+      HMAC_CTX_init (&(ptd->_hmac_ctx));
+      ptd->hmac_ctx = &ptd->_hmac_ctx;
+#endif
     }
 
   km->sa_by_ispi = hash_create (0, sizeof (uword));
   km->sw_if_indices = hash_create (0, 0);
   km->udp_ports = hash_create (0, sizeof (uword));
 
-  udp_register_dst_port (vm, 500, ikev2_node.index, 1);
+  udp_register_dst_port (vm, IKEV2_PORT, ikev2_node.index, 1);
+  udp_register_dst_port (vm, IKEV2_PORT_NATT, ikev2_node.index, 1);
 
+  vlib_punt_hdl_t punt_hdl = vlib_punt_client_register ("ikev2");
+  vlib_punt_register (punt_hdl, ipsec_punt_reason[IPSEC_PUNT_IP4_SPI_UDP_0],
+                     "ikev2");
   ikev2_cli_reference ();
 
   km->log_level = IKEV2_LOG_ERROR;
@@ -3738,7 +4091,7 @@ ikev2_init (vlib_main_t * vm)
 /* *INDENT-OFF* */
 VLIB_INIT_FUNCTION (ikev2_init) =
 {
-  .runs_after = VLIB_INITS("ipsec_init"),
+  .runs_after = VLIB_INITS("ipsec_init", "ipsec_punt_init"),
 };
 /* *INDENT-ON* */
 
@@ -3752,7 +4105,7 @@ ikev2_mngr_process_child_sa (ikev2_sa_t * sa, ikev2_child_sa_t * csa,
   f64 now = vlib_time_now (vm);
   u8 res = 0;
 
-  if (sa->is_profile_index_set)
+  if (sa->profile_index != ~0)
     p = pool_elt_at_index (km->profiles, sa->profile_index);
 
   if (sa->is_initiator && p && csa->time_to_expiration
@@ -3784,6 +4137,7 @@ ikev2_mngr_process_child_sa (ikev2_sa_t * sa, ikev2_child_sa_t * csa,
          csa->time_to_expiration = 0;
          ikev2_delete_child_sa_internal (vm, sa, csa);
          res |= 1;
+         return res;
        }
     }
 
@@ -3825,8 +4179,10 @@ ikev2_mngr_process_child_sa (ikev2_sa_t * sa, ikev2_child_sa_t * csa,
 
       u32 *sas_in = NULL;
       vec_add1 (sas_in, csa->remote_sa_id);
+      vlib_worker_thread_barrier_sync (vm);
       ipsec_tun_protect_update (sw_if_index, NULL, csa->local_sa_id, sas_in);
       ipsec_sa_unlock_id (ikev2_flip_alternate_sa_bit (csa->remote_sa_id));
+      vlib_worker_thread_barrier_release (vm);
     }
 
   return res;
@@ -3847,6 +4203,19 @@ ikev2_set_log_level (ikev2_log_level_t log_level)
   return 0;
 }
 
+clib_error_t *
+ikev2_set_liveness_params (u32 period, u32 max_retries)
+{
+  ikev2_main_t *km = &ikev2_main;
+
+  if (period == 0 || max_retries == 0)
+    return clib_error_return (0, "invalid args");
+
+  km->liveness_period = period;
+  km->liveness_max_retries = max_retries;
+  return 0;
+}
+
 static void
 ikev2_mngr_process_ipsec_sa (ipsec_sa_t * ipsec_sa)
 {
@@ -3879,7 +4248,7 @@ ikev2_mngr_process_ipsec_sa (ipsec_sa_t * ipsec_sa)
   vlib_get_combined_counter (&ipsec_sa_counters,
                             ipsec_sa->stat_index, &counts);
 
-  if (fsa && fsa->is_profile_index_set)
+  if (fsa && fsa->profile_index != ~0 && fsa->is_initiator)
     p = pool_elt_at_index (km->profiles, fsa->profile_index);
 
   if (fchild && p && p->lifetime_maxdata)
@@ -3914,7 +4283,8 @@ ikev2_process_pending_sa_init (ikev2_main_t * km)
         sa->last_sa_init_req_packet_data,
         vec_len (sa->last_sa_init_req_packet_data));
     ikev2_send_ike (km->vlib_main, &sa->iaddr, &sa->raddr, bi0,
-        vec_len (sa->last_sa_init_req_packet_data));
+        vec_len (sa->last_sa_init_req_packet_data),
+        ikev2_get_port (sa), IKEV2_PORT, sa->sw_if_index);
   }));
   /* *INDENT-ON* */
 }
@@ -3928,16 +4298,24 @@ ikev2_send_informational_request (ikev2_sa_t * sa)
   ip4_address_t *src, *dst;
   ike_header_t *ike0;
   u32 bi0 = 0;
+  u16 dp;
   int len;
 
   bi0 = ikev2_get_new_ike_header_buff (km->vlib_main, &ike0);
+  if (!bi0)
+    {
+      ikev2_log_error ("buffer alloc failure");
+      return;
+    }
 
   ike0->exchange = IKEV2_EXCHANGE_INFORMATIONAL;
   ike0->ispi = clib_host_to_net_u64 (sa->ispi);
   ike0->rspi = clib_host_to_net_u64 (sa->rspi);
   ike0->msgid = clib_host_to_net_u32 (sa->last_init_msg_id + 1);
   sa->last_init_msg_id = clib_net_to_host_u32 (ike0->msgid);
-  len = ikev2_generate_message (sa, ike0, 0);
+  len = ikev2_generate_message (sa, ike0, 0, 0);
+  if (sa->natt)
+    len = ikev2_insert_non_esp_marker (ike0, len);
 
   if (sa->is_initiator)
     {
@@ -3946,12 +4324,13 @@ ikev2_send_informational_request (ikev2_sa_t * sa)
     }
   else
     {
-
       dst = &sa->iaddr;
       src = &sa->raddr;
     }
 
-  ikev2_send_ike (km->vlib_main, src, dst, bi0, len);
+  dp = sa->dst_port ? sa->dst_port : ikev2_get_port (sa);
+  ikev2_send_ike (km->vlib_main, src, dst, bi0, len, ikev2_get_port (sa), dp,
+                 sa->sw_if_index);
 }
 
 static_always_inline int
@@ -3960,10 +4339,10 @@ ikev2_mngr_process_responder_sas (ikev2_sa_t * sa)
   ikev2_main_t *km = &ikev2_main;
   vlib_main_t *vm = km->vlib_main;
 
-  if (!sa->sk_ai || !sa->sk_ar)
+  if (!sa->keys_generated)
     return 0;
 
-  if (sa->liveness_retries > IKEV2_LIVENESS_RETRIES)
+  if (sa->liveness_retries >= km->liveness_max_retries)
     return 1;
 
   f64 now = vlib_time_now (vm);
@@ -3971,7 +4350,7 @@ ikev2_mngr_process_responder_sas (ikev2_sa_t * sa)
   if (sa->liveness_period_check < now)
     {
       sa->liveness_retries++;
-      sa->liveness_period_check = now + IKEV2_LIVENESS_PERIOD_CHECK;
+      sa->liveness_period_check = now + km->liveness_period;
       ikev2_send_informational_request (sa);
     }
   return 0;
@@ -4025,20 +4404,26 @@ ikev2_mngr_process_fn (vlib_main_t * vm, vlib_node_runtime_t * rt,
        vec_foreach (sai, to_be_deleted)
        {
          sa = pool_elt_at_index (tkm->sas, sai[0]);
-         if (sa->is_initiator && sa->is_profile_index_set)
+         u8 reinitiate = (sa->is_initiator && sa->profile_index != ~0);
+         vec_foreach (c, sa->childs)
+         {
+           ikev2_delete_tunnel_interface (km->vnet_main, sa, c);
+           ikev2_sa_del_child_sa (sa, c);
+         }
+         ikev2_sa_free_all_vec (sa);
+         hash_unset (tkm->sa_by_rspi, sa->rspi);
+         pool_put (tkm->sas, sa);
+
+         if (reinitiate)
            {
              p = pool_elt_at_index (km->profiles, sa->profile_index);
              if (p)
                {
                  ikev2_initiate_sa_init (vm, p->name);
-                 continue;
                }
            }
-         vec_foreach (c, sa->childs)
-           ikev2_delete_tunnel_interface (km->vnet_main, sa, c);
-         hash_unset (tkm->sa_by_rspi, sa->rspi);
-         pool_put (tkm->sas, sa);
        }
+       vec_free (to_be_deleted);
       }
 
       /* process ipsec sas */