nat: nat44-ed i2o & o2i trace fix
[vpp.git] / src / plugins / nat / nat44-ed / nat44_ed_in2out.c
index 59355e4..fe5fbac 100644 (file)
@@ -69,12 +69,13 @@ format_nat_in2out_ed_trace (u8 * s, va_list * args)
     t->is_slow_path ? "NAT44_IN2OUT_ED_SLOW_PATH" :
     "NAT44_IN2OUT_ED_FAST_PATH";
 
-  s = format (s, "%s: sw_if_index %d, next index %d, session %d", tag,
-             t->sw_if_index, t->next_index, t->session_index);
+  s = format (s, "%s: sw_if_index %d, next index %d", tag, t->sw_if_index,
+             t->next_index);
   if (~0 != t->session_index)
     {
-      s = format (s, ", translation result '%U' via %s",
-                 format_nat_ed_translation_error, t->translation_error,
+      s = format (s, ", session %d, translation result '%U' via %s",
+                 t->session_index, format_nat_ed_translation_error,
+                 t->translation_error,
                  t->translation_via_i2of ? "i2of" : "o2if");
       s = format (s, "\n  i2of %U", format_nat_6t_flow, &t->i2of);
       s = format (s, "\n  o2if %U", format_nat_6t_flow, &t->o2if);
@@ -331,10 +332,11 @@ nat44_ed_external_sm_lookup (snat_main_t *sm, ip4_address_t match_addr,
 }
 
 static u32
-slow_path_ed (snat_main_t *sm, vlib_buffer_t *b, ip4_address_t l_addr,
-             ip4_address_t r_addr, u16 l_port, u16 r_port, u8 proto,
-             u32 rx_fib_index, snat_session_t **sessionp,
-             vlib_node_runtime_t *node, u32 next, u32 thread_index, f64 now)
+slow_path_ed (vlib_main_t *vm, snat_main_t *sm, vlib_buffer_t *b,
+             ip4_address_t l_addr, ip4_address_t r_addr, u16 l_port,
+             u16 r_port, u8 proto, u32 rx_fib_index,
+             snat_session_t **sessionp, vlib_node_runtime_t *node, u32 next,
+             u32 thread_index, f64 now)
 {
   snat_main_per_thread_data_t *tsm = &sm->per_thread_data[thread_index];
   ip4_address_t outside_addr;
@@ -392,9 +394,9 @@ slow_path_ed (snat_main_t *sm, vlib_buffer_t *b, ip4_address_t l_addr,
   u32 sm_fib_index;
   /* First try to match static mapping by local address and port */
   int is_sm;
-  if (snat_static_mapping_match (sm, l_addr, l_port, rx_fib_index, nat_proto,
-                                &sm_addr, &sm_port, &sm_fib_index, 0, 0, 0,
-                                &lb, 0, &is_identity_nat, 0))
+  if (snat_static_mapping_match (vm, sm, l_addr, l_port, rx_fib_index,
+                                nat_proto, &sm_addr, &sm_port, &sm_fib_index,
+                                0, 0, 0, &lb, 0, &is_identity_nat, 0))
     {
       is_sm = 0;
     }
@@ -504,6 +506,7 @@ slow_path_ed (snat_main_t *sm, vlib_buffer_t *b, ip4_address_t l_addr,
                        rx_fib_index, proto);
   nat_6t_flow_saddr_rewrite_set (&s->i2o, outside_addr.as_u32);
   nat_6t_flow_daddr_rewrite_set (&s->i2o, daddr.as_u32);
+
   if (NAT_PROTOCOL_ICMP == nat_proto)
     {
       nat_6t_flow_icmp_id_rewrite_set (&s->i2o, outside_port);
@@ -554,15 +557,16 @@ error:
 }
 
 static_always_inline int
-nat44_ed_not_translate (snat_main_t * sm, vlib_node_runtime_t * node,
-                       u32 sw_if_index, ip4_header_t * ip, u32 proto,
+nat44_ed_not_translate (vlib_main_t *vm, snat_main_t *sm,
+                       vlib_node_runtime_t *node, u32 sw_if_index,
+                       vlib_buffer_t *b, ip4_header_t *ip, u32 proto,
                        u32 rx_fib_index, u32 thread_index)
 {
-  udp_header_t *udp = ip4_next_header (ip);
   clib_bihash_kv_16_8_t kv, value;
 
-  init_ed_k (&kv, ip->dst_address, udp->dst_port, ip->src_address,
-            udp->src_port, sm->outside_fib_index, ip->protocol);
+  init_ed_k (&kv, ip->dst_address, vnet_buffer (b)->ip.reass.l4_dst_port,
+            ip->src_address, vnet_buffer (b)->ip.reass.l4_src_port,
+            sm->outside_fib_index, ip->protocol);
 
   /* NAT packet aimed at external address if has active sessions */
   if (clib_bihash_search_16_8 (&sm->flow_hash, &kv, &value))
@@ -571,10 +575,10 @@ nat44_ed_not_translate (snat_main_t * sm, vlib_node_runtime_t * node,
       ip4_address_t placeholder_addr;
       u16 placeholder_port;
       u32 placeholder_fib_index;
-      if (!snat_static_mapping_match
-         (sm, ip->dst_address, udp->dst_port, sm->outside_fib_index, proto,
-          &placeholder_addr, &placeholder_port, &placeholder_fib_index, 1, 0,
-          0, 0, 0, 0, 0))
+      if (!snat_static_mapping_match (
+           vm, sm, ip->dst_address, vnet_buffer (b)->ip.reass.l4_dst_port,
+           sm->outside_fib_index, proto, &placeholder_addr, &placeholder_port,
+           &placeholder_fib_index, 1, 0, 0, 0, 0, 0, 0))
        return 0;
     }
   else
@@ -652,10 +656,11 @@ nat_not_translate_output_feature_fwd (snat_main_t * sm, ip4_header_t * ip,
 }
 
 static_always_inline int
-nat44_ed_not_translate_output_feature (snat_main_t * sm, ip4_header_t * ip,
-                                      u16 src_port, u16 dst_port,
-                                      u32 thread_index, u32 rx_sw_if_index,
-                                      u32 tx_sw_if_index, f64 now)
+nat44_ed_not_translate_output_feature (snat_main_t *sm, vlib_buffer_t *b,
+                                      ip4_header_t *ip, u16 src_port,
+                                      u16 dst_port, u32 thread_index,
+                                      u32 rx_sw_if_index, u32 tx_sw_if_index,
+                                      f64 now, int is_multi_worker)
 {
   clib_bihash_kv_16_8_t kv, value;
   snat_main_per_thread_data_t *tsm = &sm->per_thread_data[thread_index];
@@ -683,6 +688,26 @@ nat44_ed_not_translate_output_feature (snat_main_t * sm, ip4_header_t * ip,
     }
 
   /* dst NAT check */
+  if (is_multi_worker &&
+      PREDICT_TRUE (!pool_is_free_index (
+       tsm->sessions, vnet_buffer2 (b)->nat.cached_dst_nat_session_index)))
+    {
+      nat_6t_t lookup;
+      lookup.fib_index = rx_fib_index;
+      lookup.proto = ip->protocol;
+      lookup.daddr.as_u32 = ip->src_address.as_u32;
+      lookup.dport = src_port;
+      lookup.saddr.as_u32 = ip->dst_address.as_u32;
+      lookup.sport = dst_port;
+      s = pool_elt_at_index (
+       tsm->sessions, vnet_buffer2 (b)->nat.cached_dst_nat_session_index);
+      if (PREDICT_TRUE (nat_6t_t_eq (&s->i2o.match, &lookup)))
+       {
+         goto skip_dst_nat_lookup;
+       }
+      s = NULL;
+    }
+
   init_ed_k (&kv, ip->dst_address, dst_port, ip->src_address, src_port,
             rx_fib_index, ip->protocol);
   if (!clib_bihash_search_16_8 (&sm->flow_hash, &kv, &value))
@@ -692,6 +717,7 @@ nat44_ed_not_translate_output_feature (snat_main_t * sm, ip4_header_t * ip,
        pool_elt_at_index (tsm->sessions,
                           ed_value_get_session_index (&value));
 
+    skip_dst_nat_lookup:
       if (is_fwd_bypass_session (s))
        return 0;
 
@@ -712,7 +738,8 @@ icmp_in2out_ed_slow_path (snat_main_t *sm, vlib_buffer_t *b, ip4_header_t *ip,
                          icmp46_header_t *icmp, u32 sw_if_index,
                          u32 rx_fib_index, vlib_node_runtime_t *node,
                          u32 next, f64 now, u32 thread_index,
-                         nat_protocol_t nat_proto, snat_session_t **s_p)
+                         nat_protocol_t nat_proto, snat_session_t **s_p,
+                         int is_multi_worker)
 {
   vlib_main_t *vm = vlib_get_main ();
   u16 checksum;
@@ -734,16 +761,16 @@ icmp_in2out_ed_slow_path (snat_main_t *sm, vlib_buffer_t *b, ip4_header_t *ip,
   if (vnet_buffer (b)->sw_if_index[VLIB_TX] != ~0)
     {
       if (PREDICT_FALSE (nat44_ed_not_translate_output_feature (
-           sm, ip, lookup_sport, lookup_dport, thread_index, sw_if_index,
-           vnet_buffer (b)->sw_if_index[VLIB_TX], now)))
+           sm, b, ip, lookup_sport, lookup_dport, thread_index, sw_if_index,
+           vnet_buffer (b)->sw_if_index[VLIB_TX], now, is_multi_worker)))
        {
          return next;
        }
     }
   else
     {
-      if (PREDICT_FALSE (nat44_ed_not_translate (sm, node, sw_if_index, ip,
-                                                NAT_PROTOCOL_ICMP,
+      if (PREDICT_FALSE (nat44_ed_not_translate (vm, sm, node, sw_if_index, b,
+                                                ip, NAT_PROTOCOL_ICMP,
                                                 rx_fib_index, thread_index)))
        {
          return next;
@@ -757,9 +784,9 @@ icmp_in2out_ed_slow_path (snat_main_t *sm, vlib_buffer_t *b, ip4_header_t *ip,
       return NAT_NEXT_DROP;
     }
 
-  next = slow_path_ed (sm, b, ip->src_address, ip->dst_address, lookup_sport,
-                      lookup_dport, ip->protocol, rx_fib_index, &s, node,
-                      next, thread_index, vlib_time_now (vm));
+  next = slow_path_ed (vm, sm, b, ip->src_address, ip->dst_address,
+                      lookup_sport, lookup_dport, ip->protocol, rx_fib_index,
+                      &s, node, next, thread_index, vlib_time_now (vm));
 
   if (NAT_NEXT_DROP == next)
     goto out;
@@ -1234,10 +1261,11 @@ nat44_ed_in2out_fast_path_node_fn_inline (vlib_main_t *vm,
 }
 
 static inline uword
-nat44_ed_in2out_slow_path_node_fn_inline (vlib_main_t * vm,
-                                         vlib_node_runtime_t * node,
-                                         vlib_frame_t * frame,
-                                         int is_output_feature)
+nat44_ed_in2out_slow_path_node_fn_inline (vlib_main_t *vm,
+                                         vlib_node_runtime_t *node,
+                                         vlib_frame_t *frame,
+                                         int is_output_feature,
+                                         int is_multi_worker)
 {
   u32 n_left_from, *from;
   snat_main_t *sm = &snat_main;
@@ -1313,9 +1341,9 @@ nat44_ed_in2out_slow_path_node_fn_inline (vlib_main_t * vm,
 
       if (PREDICT_FALSE (proto0 == NAT_PROTOCOL_ICMP))
        {
-         next[0] = icmp_in2out_ed_slow_path (sm, b0, ip0, icmp0, sw_if_index0,
-                                             rx_fib_index0, node, next[0],
-                                             now, thread_index, proto0, &s0);
+         next[0] = icmp_in2out_ed_slow_path (
+           sm, b0, ip0, icmp0, sw_if_index0, rx_fib_index0, node, next[0],
+           now, thread_index, proto0, &s0, is_multi_worker);
          if (NAT_NEXT_DROP != next[0] && s0 &&
              NAT_ED_TRNSL_ERR_SUCCESS !=
                (translation_error = nat_6t_flow_buf_translate (
@@ -1352,12 +1380,11 @@ nat44_ed_in2out_slow_path_node_fn_inline (vlib_main_t * vm,
        {
          if (is_output_feature)
            {
-             if (PREDICT_FALSE
-                 (nat44_ed_not_translate_output_feature
-                  (sm, ip0, vnet_buffer (b0)->ip.reass.l4_src_port,
+             if (PREDICT_FALSE (nat44_ed_not_translate_output_feature (
+                   sm, b0, ip0, vnet_buffer (b0)->ip.reass.l4_src_port,
                    vnet_buffer (b0)->ip.reass.l4_dst_port, thread_index,
-                   sw_if_index0, vnet_buffer (b0)->sw_if_index[VLIB_TX],
-                   now)))
+                   sw_if_index0, vnet_buffer (b0)->sw_if_index[VLIB_TX], now,
+                   is_multi_worker)))
                goto trace0;
 
              /*
@@ -1373,19 +1400,17 @@ nat44_ed_in2out_slow_path_node_fn_inline (vlib_main_t * vm,
            }
          else
            {
-             if (PREDICT_FALSE
-                 (nat44_ed_not_translate
-                  (sm, node, sw_if_index0, ip0, proto0, rx_fib_index0,
+             if (PREDICT_FALSE (nat44_ed_not_translate (
+                   vm, sm, node, sw_if_index0, b0, ip0, proto0, rx_fib_index0,
                    thread_index)))
                goto trace0;
            }
 
-         next[0] =
-           slow_path_ed (sm, b0, ip0->src_address, ip0->dst_address,
-                         vnet_buffer (b0)->ip.reass.l4_src_port,
-                         vnet_buffer (b0)->ip.reass.l4_dst_port,
-                         ip0->protocol, rx_fib_index0, &s0, node, next[0],
-                         thread_index, now);
+         next[0] = slow_path_ed (
+           vm, sm, b0, ip0->src_address, ip0->dst_address,
+           vnet_buffer (b0)->ip.reass.l4_src_port,
+           vnet_buffer (b0)->ip.reass.l4_dst_port, ip0->protocol,
+           rx_fib_index0, &s0, node, next[0], thread_index, now);
 
          if (PREDICT_FALSE (next[0] == NAT_NEXT_DROP))
            goto trace0;
@@ -1523,7 +1548,14 @@ VLIB_NODE_FN (nat44_ed_in2out_slowpath_node) (vlib_main_t * vm,
                                              vlib_node_runtime_t *
                                              node, vlib_frame_t * frame)
 {
-  return nat44_ed_in2out_slow_path_node_fn_inline (vm, node, frame, 0);
+  if (snat_main.num_workers > 1)
+    {
+      return nat44_ed_in2out_slow_path_node_fn_inline (vm, node, frame, 0, 1);
+    }
+  else
+    {
+      return nat44_ed_in2out_slow_path_node_fn_inline (vm, node, frame, 0, 0);
+    }
 }
 
 VLIB_REGISTER_NODE (nat44_ed_in2out_slowpath_node) = {
@@ -1542,7 +1574,14 @@ VLIB_NODE_FN (nat44_ed_in2out_output_slowpath_node) (vlib_main_t * vm,
                                                     * node,
                                                     vlib_frame_t * frame)
 {
-  return nat44_ed_in2out_slow_path_node_fn_inline (vm, node, frame, 1);
+  if (snat_main.num_workers > 1)
+    {
+      return nat44_ed_in2out_slow_path_node_fn_inline (vm, node, frame, 1, 1);
+    }
+  else
+    {
+      return nat44_ed_in2out_slow_path_node_fn_inline (vm, node, frame, 1, 0);
+    }
 }
 
 VLIB_REGISTER_NODE (nat44_ed_in2out_output_slowpath_node) = {