if (src[i] != dst[i])
return -1;
- /* Size fail */
- err = memcpy_s (dst + 1, sizeof (dst) - 1, src, sizeof (src));
+ /*
+ * Size test: sizeof (src) > sizeof (dst)
+ * Skip this test when __builtin_constant_p (sizeof (src)) is true.
+ * This is because memcpy_s_inline skips all the errors checking when the
+ * the above buildin function returns true which may cause overrun problem
+ * for dst buffer if this test is executed.
+ */
+ if (__builtin_constant_p (sizeof (src)) == 0)
+ {
+ err = memcpy_s (dst + 1, sizeof (dst) - 1, src, sizeof (src));
- if (err == EOK)
- return -1;
+ if (err == EOK)
+ return -1;
+ }
/* overlap fail */
err = memcpy_s (dst, sizeof (dst), dst + 1, sizeof (dst) - 1);
v_indicator = strncmp (s1, "Every moment is a fresh beginning", s1len);
if (v_indicator != 0)
return -1;
- if (v_indicator != indicator)
- return -1;
/* s1 > s2, 0 is expected since comparison is no more than n character */
indicator = clib_strncmp (s1, "Every moment is a fresh begin",
sizeof ("Every moment is a fresh begin") - 1);
if (v_indicator != 0)
return -1;
- if (v_indicator != indicator)
- return -1;
/* s1 < s2, < 0 is expected */
indicator = clib_strncmp (s1, "Every moment is fresh beginning",
v_indicator = strncmp (s1, "Every moment is a fresh beginning", s1len + 1);
if (v_indicator != 0)
return -1;
- if (v_indicator != indicator)
- return -1;
/* unterminated s1 */
s1[s1len] = 0x1;
+ CLIB_MEM_UNPOISON (s1, CLIB_STRING_MACRO_MAX);
indicator = clib_strncmp (s1, "Every moment is a fresh beginning",
sizeof ("every moment is a fresh beginning") - 1);
if (indicator != 0)
return -1;
/* verify it against strcpy */
- strcpy (dst, src);
+ strcpy (dst, src); //NOSONAR
/* This better not fail but check anyhow */
if (strcmp_s (dst, clib_strnlen (dst, sizeof (dst)), src, &indicator) !=
return -1;
/* Verify it against strncpy */
+#if __GNUC__ < 8
+ /* GCC 8 debian flunks this one at compile time */
strncpy (dst, src, strlen (src));
/* This better not fail but check anyhow */
return -1;
if (indicator != 0)
return -1;
+#endif
/* limited copy -- strlen src > n, copy up to n */
err = clib_strncpy (dst, "The price of greatness is responsibility.", 10);
if (indicator != 0)
return -1;
/* Verify it against strncpy */
+#if __GNUC__ < 8
+ /* GCC 8 debian flunks this one at compile time */
strncpy (dst, src, strlen (src));
if (strcmp_s (dst, clib_strnlen (dst, sizeof (dst)), src, &indicator) !=
EOK)
return -1;
if (indicator != 0)
return -1;
+#endif
/* zero length copy */
clib_strncpy (old_dst, dst, clib_strnlen (dst, sizeof (dst)));
if (indicator != 0)
return -1;
/* verify it against strncat */
+#if __GNUC__ < 8
+ /* GCC 8 debian flunks this one at compile time */
strcpy_s (dst, sizeof (dst), s1);
strncat (dst, s2, 13);
if (strcmp_s (dst, s1size - 1, "Two things are infinite: the universe ",
return -1;
if (indicator != 0)
return -1;
+#endif
/* negative stuff */
err = strncat_s (0, 0, 0, 1);
if (indicator != 0)
return -1;
/* verify it against strncat */
+#if __GNUC__ < 8
+ /* GCC 8 debian flunks this one at compile time */
strcpy_s (dst, sizeof (dst), s1);
strncat (dst, s2, 13);
if (strcmp_s (dst, s1size - 1, "Two things are infinite: the universe ",
return -1;
if (indicator != 0)
return -1;
+#endif
/* negative stuff */
err = clib_strncat (0, 0, 1);
/* unterminated s1 and s2 */
memset_s (s1, ARRAY_LEN (s1), 0xfe, ARRAY_LEN (s1));
+ CLIB_MEM_UNPOISON (s1, CLIB_STRING_MACRO_MAX);
sub = clib_strstr (s1, s1);
if (sub == 0)
return -1;
return 0;
}
+static int
+test_clib_count_equal (vlib_main_t * vm, unformat_input_t * input)
+{
+ u64 s64[15];
+ u32 s32[31];
+ u16 s16[63];
+ u8 s8[127];
+ uword count;
+
+ vlib_cli_output (vm, "Test clib_count_equal_u64...");
+ memset (s64, 0, sizeof (s64));
+ count = clib_count_equal_u64 (s64, 0);
+ if (0 != count)
+ return -1;
+ count = clib_count_equal_u64 (s64, 1);
+ if (1 != count)
+ return -1;
+ count = clib_count_equal_u64 (s64, 3);
+ if (3 != count)
+ return -1;
+ count = clib_count_equal_u64 (s64, 15);
+ if (15 != count)
+ return -1;
+ s64[10] = 0xcafe;
+ count = clib_count_equal_u64 (s64, 13);
+ if (10 != count)
+ return -1;
+ s64[10] = 0;
+
+ vlib_cli_output (vm, "Test clib_count_equal_u32...");
+ memset (s32, 0, sizeof (s32));
+ count = clib_count_equal_u32 (s32, 0);
+ if (0 != count)
+ return -1;
+ count = clib_count_equal_u32 (s32, 1);
+ if (1 != count)
+ return -1;
+ count = clib_count_equal_u32 (s32, 3);
+ if (3 != count)
+ return -1;
+ count = clib_count_equal_u32 (s32, 31);
+ if (31 != count)
+ return -1;
+ s32[10] = 0xcafe;
+ count = clib_count_equal_u32 (s32, 13);
+ if (10 != count)
+ return -1;
+ s32[10] = 0;
+
+ vlib_cli_output (vm, "Test clib_count_equal_u16...");
+ memset (s16, 0, sizeof (s16));
+ count = clib_count_equal_u16 (s16, 0);
+ if (0 != count)
+ return -1;
+ count = clib_count_equal_u16 (s16, 1);
+ if (1 != count)
+ return -1;
+ count = clib_count_equal_u16 (s16, 3);
+ if (3 != count)
+ return -1;
+ count = clib_count_equal_u16 (s16, 63);
+ if (63 != count)
+ return -1;
+ s16[10] = 0xcafe;
+ count = clib_count_equal_u16 (s16, 13);
+ if (10 != count)
+ return -1;
+ s16[10] = 0;
+
+ vlib_cli_output (vm, "Test clib_count_equal_u8...");
+ memset (s8, 0, sizeof (s8));
+ count = clib_count_equal_u8 (s8, 0);
+ if (0 != count)
+ return -1;
+ count = clib_count_equal_u8 (s8, 1);
+ if (1 != count)
+ return -1;
+ count = clib_count_equal_u8 (s8, 3);
+ if (3 != count)
+ return -1;
+ count = clib_count_equal_u8 (s8, 127);
+ if (127 != count)
+ return -1;
+ s8[10] = 0xfe;
+ count = clib_count_equal_u8 (s8, 13);
+ if (10 != count)
+ return -1;
+ s8[10] = 0;
+
+ return 0;
+}
+
+
#define foreach_string_test \
_ (0, MEMCPY_S, "memcpy_s", memcpy_s) \
_ (1, CLIB_MEMCPY, "clib_memcpy", clib_memcpy) \
_ (20, STRNLEN_S, "strnlen_s", strnlen_s) \
_ (21, CLIB_STRNLEN, "clib_strnlen", clib_strnlen) \
_ (22, STRSTR_S, "strstr_s", strstr_s) \
- _ (23, CLIB_STRSTR, "clib_strstr", clib_strstr)
+ _ (23, CLIB_STRSTR, "clib_strstr", clib_strstr) \
+ _ (24, CLIB_COUNT_EQUAL, "clib_count_equal", clib_count_equal)
typedef enum
{
#define _(v,f,s,p) STRING_TEST_##f = v,
foreach_string_test
#undef _
+#define STRING_TEST_FIRST STRING_TEST_MEMCPY_S
+#define STRING_TEST_LAST STRING_TEST_CLIB_COUNT_EQUAL
} string_test_t;
static uword
if (specific_test == ~0)
{
- for (specific_test = STRING_TEST_MEMCPY_S;
- specific_test <= STRING_TEST_CLIB_STRSTR; specific_test++)
+ for (specific_test = STRING_TEST_FIRST;
+ specific_test <= STRING_TEST_LAST; specific_test++)
{
ok = (string_func[specific_test]).test (vm, input);
res += ok;
"strncmp_s | clib_strncmp | strcpy_s | clib_strcpy | strncpy_s | "
"clib_strncpy | strcat_s | clib_strcat | strncat_s | clib_strncat | "
"strtok_s | clib_strtok | strnlen_s | clib_strnlen | strstr_s | "
- "clib_strstr]",
+ "clib_strstr | clib_count_equal ]",
.function = string_test_command_fn,
};
/* *INDENT-ON* */