VCL: Fix session peer and local addresses
[vpp.git] / src / vcl / vppcom.c
index c0b09e8..62d754b 100644 (file)
@@ -190,19 +190,6 @@ typedef struct vppcom_cfg_t_
   u8 *vpp_api_filename;
 } vppcom_cfg_t;
 
-/* VPPCOM Event typedefs */
-typedef enum vcl_event_id_
-{
-  VCL_EVENT_INVALID_EVENT,
-  VCL_EVENT_CONNECT_REQ_ACCEPTED,
-  VCL_EVENT_N_EVENTS
-} vcl_event_id_t;
-
-typedef struct vce_event_connect_request_
-{
-  u32 accepted_session_index;
-} vce_event_connect_request_t;
-
 typedef struct vppcom_main_t_
 {
   u8 init;
@@ -247,6 +234,9 @@ typedef struct vppcom_main_t_
   /* Event thread */
   vce_event_thread_t event_thread;
 
+  /* IO thread */
+  vppcom_session_io_thread_t session_io_thread;
+
   /* VPP Event-logger */
   elog_main_t elog_main;
   elog_track_t elog_track;
@@ -266,7 +256,7 @@ static vppcom_main_t _vppcom_main = {
 
 static vppcom_main_t *vcm = &_vppcom_main;
 
-#define VCL_LOCK_AND_GET_SESSION(I, S)                          \
+#define VCL_SESSION_LOCK_AND_GET(I, S)                          \
 do {                                                            \
   clib_spinlock_lock (&vcm->sessions_lockp);                    \
   rv = vppcom_session_at_index (I, S);                          \
@@ -279,6 +269,23 @@ do {                                                            \
     }                                                           \
 } while (0)
 
+#define VCL_SESSION_LOCK() clib_spinlock_lock (&(vcm->sessions_lockp))
+#define VCL_SESSION_UNLOCK() clib_spinlock_unlock (&(vcm->sessions_lockp))
+
+#define VCL_IO_SESSIONS_LOCK() \
+  clib_spinlock_lock (&(vcm->session_io_thread.io_sessions_lockp))
+#define VCL_IO_SESSIONS_UNLOCK() \
+  clib_spinlock_unlock (&(vcm->session_io_thread.io_sessions_lockp))
+
+#define VCL_ACCEPT_FIFO_LOCK() clib_spinlock_lock (&(vcm->session_fifo_lockp))
+#define VCL_ACCEPT_FIFO_UNLOCK() \
+  clib_spinlock_unlock (&(vcm->session_fifo_lockp))
+
+#define VCL_EVENTS_LOCK() \
+  clib_spinlock_lock (&(vcm->event_thread.events_lockp))
+#define VCL_EVENTS_UNLOCK() \
+  clib_spinlock_unlock (&(vcm->event_thread.events_lockp))
+
 static const char *
 vppcom_app_state_str (app_state_t state)
 {
@@ -357,6 +364,7 @@ vppcom_session_state_str (session_state_t state)
 /*
  * VPPCOM Utility Functions
  */
+
 static inline int
 vppcom_session_at_index (u32 session_index, session_t * volatile *sess)
 {
@@ -436,58 +444,18 @@ write_elog (void)
 
 }
 
-/*
- * VPPCOM Event Functions
- */
-
-/**
- *  * @brief vce_connect_request_handler_fn
- * - used for listener sessions
- * - when a vl_api_accept_session_t_handler() generates an event
- *   this callback is alerted and sets fields that consumers such as
- *   vppcom_session_accept() expect to see, ie. accepted_client_index
- *
- * @param arg - void* to be cast to vce_event_handler_reg_t*
- */
-void
-vce_connect_request_handler_fn (void *arg)
-{
-  vce_event_handler_reg_t *reg = (vce_event_handler_reg_t *) arg;
-
-  pthread_mutex_lock (&reg->handler_lock);
-  pthread_cond_signal (&reg->handler_cond);
-  pthread_mutex_unlock (&reg->handler_lock);
-}
-
-/**
- * @brief vce_poll_wait_connect_request_handler_fn
- * - used by vppcom_epoll_xxxx() for listener sessions
- * - when a vl_api_accept_session_t_handler() generates an event
- *   this callback is alerted and sets the fields that vppcom_epoll_wait()
- *   expects to see.
- *
- * @param arg - void* to be cast to vce_event_handler_reg_t*
- */
-void
-vce_poll_wait_connect_request_handler_fn (void *arg)
+static inline void
+vppcom_send_accept_session_reply (u64 handle, u32 context, int retval)
 {
-  vce_event_handler_reg_t *reg = (vce_event_handler_reg_t *) arg;
-  vce_event_t *ev;
-  /* Retrieve the VCL_EVENT_CONNECT_REQ_ACCEPTED event */
-  ev = vce_get_event_from_index (&vcm->event_thread, reg->ev_idx);
-  vce_event_connect_request_t *ecr = (vce_event_connect_request_t *) ev->data;
-
-  /* Add the accepted_session_index to the FIFO */
-  clib_spinlock_lock (&vcm->session_fifo_lockp);
-  clib_fifo_add1 (vcm->client_session_index_fifo,
-                 ecr->accepted_session_index);
-  clib_spinlock_unlock (&vcm->session_fifo_lockp);
+  vl_api_accept_session_reply_t *rmp;
 
-  /* Recycling the event. */
-  clib_spinlock_lock (&(vcm->event_thread.events_lockp));
-  vcm->event_thread.recycle_event = 1;
-  clib_fifo_add1 (vcm->event_thread.event_index_fifo, reg->ev_idx);
-  clib_spinlock_unlock (&(vcm->event_thread.events_lockp));
+  rmp = vl_msg_api_alloc (sizeof (*rmp));
+  memset (rmp, 0, sizeof (*rmp));
+  rmp->_vl_msg_id = ntohs (VL_API_ACCEPT_SESSION_REPLY);
+  rmp->retval = htonl (retval);
+  rmp->context = context;
+  rmp->handle = handle;
+  vl_msg_api_send_shmem (vcm->vl_input_queue, (u8 *) & rmp);
 }
 
 static int
@@ -626,25 +594,25 @@ vppcom_wait_for_session_state_change (u32 session_index,
 
   do
     {
-      clib_spinlock_lock (&vcm->sessions_lockp);
+      VCL_SESSION_LOCK ();
       rv = vppcom_session_at_index (session_index, &session);
       if (PREDICT_FALSE (rv))
        {
-         clib_spinlock_unlock (&vcm->sessions_lockp);
+         VCL_SESSION_UNLOCK ();
          return rv;
        }
       if (session->state & state)
        {
-         clib_spinlock_unlock (&vcm->sessions_lockp);
+         VCL_SESSION_UNLOCK ();
          return VPPCOM_OK;
        }
       if (session->state & STATE_FAILED)
        {
-         clib_spinlock_unlock (&vcm->sessions_lockp);
+         VCL_SESSION_UNLOCK ();
          return VPPCOM_ECONNREFUSED;
        }
 
-      clib_spinlock_unlock (&vcm->sessions_lockp);
+      VCL_SESSION_UNLOCK ();
     }
   while (clib_time_now (&vcm->clib_time) < timeout);
 
@@ -745,8 +713,8 @@ vppcom_app_send_attach (void)
     (vcm->cfg.app_scope_global ? APP_OPTIONS_FLAGS_USE_GLOBAL_SCOPE : 0) |
     (app_is_proxy ? APP_OPTIONS_FLAGS_IS_PROXY : 0);
   bmp->options[APP_OPTIONS_PROXY_TRANSPORT] =
-    (vcm->cfg.app_proxy_transport_tcp ? 1 << TRANSPORT_PROTO_TCP : 0) |
-    (vcm->cfg.app_proxy_transport_udp ? 1 << TRANSPORT_PROTO_UDP : 0);
+    (u64) ((vcm->cfg.app_proxy_transport_tcp ? 1 << TRANSPORT_PROTO_TCP : 0) |
+          (vcm->cfg.app_proxy_transport_udp ? 1 << TRANSPORT_PROTO_UDP : 0));
   bmp->options[APP_OPTIONS_SEGMENT_SIZE] = vcm->cfg.segment_size;
   bmp->options[APP_OPTIONS_ADD_SEGMENT_SIZE] = vcm->cfg.add_segment_size;
   bmp->options[APP_OPTIONS_RX_FIFO_SIZE] = vcm->cfg.rx_fifo_size;
@@ -907,7 +875,7 @@ vl_api_disconnect_session_t_handler (vl_api_disconnect_session_t * mp)
       session_t *session = 0;
       u32 session_index = p[0];
 
-      VCL_LOCK_AND_GET_SESSION (session_index, &session);
+      VCL_SESSION_LOCK_AND_GET (session_index, &session);
       session->state = STATE_CLOSE_ON_EMPTY;
 
       if (VPPCOM_DEBUG > 1)
@@ -915,7 +883,7 @@ vl_api_disconnect_session_t_handler (vl_api_disconnect_session_t * mp)
                      "setting state to 0x%x (%s)",
                      getpid (), mp->handle, session_index, session->state,
                      vppcom_session_state_str (session->state));
-      clib_spinlock_unlock (&vcm->sessions_lockp);
+      VCL_SESSION_UNLOCK ();
       return;
 
     done:
@@ -941,7 +909,7 @@ vl_api_reset_session_t_handler (vl_api_reset_session_t * mp)
   if (p)
     {
       int rval;
-      clib_spinlock_lock (&vcm->sessions_lockp);
+      VCL_SESSION_LOCK ();
       rval = vppcom_session_at_index (p[0], &session);
       if (PREDICT_FALSE (rval))
        {
@@ -964,7 +932,7 @@ vl_api_reset_session_t_handler (vl_api_reset_session_t * mp)
                          mp->handle, p[0], session->state,
                          vppcom_session_state_str (session->state));
        }
-      clib_spinlock_unlock (&vcm->sessions_lockp);
+      VCL_SESSION_UNLOCK ();
     }
   else
     {
@@ -991,7 +959,7 @@ vl_api_connect_session_reply_t_handler (vl_api_connect_session_reply_t * mp)
   int rv = VPPCOM_OK;
 
   session_index = mp->context;
-  VCL_LOCK_AND_GET_SESSION (session_index, &session);
+  VCL_SESSION_LOCK_AND_GET (session_index, &session);
 done:
   if (mp->retval)
     {
@@ -1019,6 +987,16 @@ done:
   /*
    * Setup session
    */
+  if (vcm->session_io_thread.io_sessions_lockp)
+    {
+      // Add this connection to the active io sessions list
+      VCL_IO_SESSIONS_LOCK ();
+      u32 *active_session_index;
+      pool_get (vcm->session_io_thread.active_session_indexes,
+               active_session_index);
+      *active_session_index = session_index;
+      VCL_IO_SESSIONS_UNLOCK ();
+    }
   session->vpp_event_queue = uword_to_pointer (mp->vpp_event_queue_address,
                                               svm_queue_t *);
 
@@ -1048,7 +1026,7 @@ done:
                  session->rx_fifo->refcnt,
                  session->tx_fifo, session->tx_fifo->refcnt);
 done_unlock:
-  clib_spinlock_unlock (&vcm->sessions_lockp);
+  VCL_SESSION_UNLOCK ();
 }
 
 static void
@@ -1116,7 +1094,7 @@ vl_api_bind_sock_reply_t_handler (vl_api_bind_sock_reply_t * mp)
   u32 session_index = mp->context;
   int rv;
 
-  VCL_LOCK_AND_GET_SESSION (session_index, &session);
+  VCL_SESSION_LOCK_AND_GET (session_index, &session);
 done:
   if (mp->retval)
     {
@@ -1141,8 +1119,8 @@ done:
 
   session->vpp_handle = mp->handle;
   session->lcl_addr.is_ip4 = mp->lcl_is_ip4;
-  clib_memcpy (&session->lcl_addr.ip46, mp->lcl_ip,
-              sizeof (session->peer_addr.ip46));
+  session->lcl_addr.ip46 = to_ip46 (mp->lcl_is_ip4 ? IP46_TYPE_IP4 :
+                                   IP46_TYPE_IP6, mp->lcl_ip);
   session->lcl_port = mp->lcl_port;
   vppcom_session_table_add_listener (mp->handle, session_index);
   session->state = STATE_LISTEN;
@@ -1151,7 +1129,7 @@ done:
     clib_warning ("VCL<%d>: vpp handle 0x%llx, sid %u: bind succeeded!",
                  getpid (), mp->handle, mp->context);
 done_unlock:
-  clib_spinlock_unlock (&vcm->sessions_lockp);
+  VCL_SESSION_UNLOCK ();
 }
 
 static void
@@ -1250,20 +1228,6 @@ format_ip46_address (u8 * s, va_list * args)
     format (s, "%U", format_ip6_address, &ip46->ip6);
 }
 
-static inline void
-vppcom_send_accept_session_reply (u64 handle, u32 context, int retval)
-{
-  vl_api_accept_session_reply_t *rmp;
-
-  rmp = vl_msg_api_alloc (sizeof (*rmp));
-  memset (rmp, 0, sizeof (*rmp));
-  rmp->_vl_msg_id = ntohs (VL_API_ACCEPT_SESSION_REPLY);
-  rmp->retval = htonl (retval);
-  rmp->context = context;
-  rmp->handle = handle;
-  vl_msg_api_send_shmem (vcm->vl_input_queue, (u8 *) & rmp);
-}
-
 static void
 vl_api_accept_session_t_handler (vl_api_accept_session_t * mp)
 {
@@ -1276,18 +1240,18 @@ vl_api_accept_session_t_handler (vl_api_accept_session_t * mp)
   u32 ev_idx;
   uword elts = 0;
 
-  clib_spinlock_lock (&vcm->sessions_lockp);
+  VCL_SESSION_LOCK ();
 
-  clib_spinlock_lock (&vcm->session_fifo_lockp);
+  VCL_ACCEPT_FIFO_LOCK ();
   elts = clib_fifo_free_elts (vcm->client_session_index_fifo);
-  clib_spinlock_unlock (&vcm->session_fifo_lockp);
+  VCL_ACCEPT_FIFO_UNLOCK ();
 
   if (!elts)
     {
       clib_warning ("VCL<%d>: client session queue is full!", getpid ());
       vppcom_send_accept_session_reply (mp->handle, mp->context,
                                        VNET_API_ERROR_QUEUE_FULL);
-      clib_spinlock_unlock (&vcm->sessions_lockp);
+      VCL_SESSION_UNLOCK ();
       return;
     }
 
@@ -1299,7 +1263,7 @@ vl_api_accept_session_t_handler (vl_api_accept_session_t * mp)
                    getpid (), mp->listener_handle);
       vppcom_send_accept_session_reply (mp->handle, mp->context,
                                        VNET_API_ERROR_INVALID_ARGUMENT);
-      clib_spinlock_unlock (&vcm->sessions_lockp);
+      VCL_SESSION_UNLOCK ();
       return;
     }
 
@@ -1309,7 +1273,7 @@ vl_api_accept_session_t_handler (vl_api_accept_session_t * mp)
   /* Allocate local session and set it up */
   pool_get (vcm->sessions, session);
   memset (session, 0, sizeof (*session));
-  session_index = session - vcm->sessions;
+  session_index = (u32) (session - vcm->sessions);
 
   rx_fifo = uword_to_pointer (mp->server_rx_fifo, svm_fifo_t *);
   rx_fifo->client_session_index = session_index;
@@ -1325,8 +1289,8 @@ vl_api_accept_session_t_handler (vl_api_accept_session_t * mp)
   session->state = STATE_ACCEPT;
   session->peer_port = mp->port;
   session->peer_addr.is_ip4 = mp->is_ip4;
-  clib_memcpy (&session->peer_addr.ip46, mp->ip,
-              sizeof (session->peer_addr.ip46));
+  session->peer_addr.ip46 = to_ip46 (mp->is_ip4 ? IP46_TYPE_IP4 :
+                                    IP46_TYPE_IP6, mp->ip);
 
   /* Add it to lookup table */
   hash_set (vcm->session_index_by_vpp_handles, mp->handle, session_index);
@@ -1335,29 +1299,27 @@ vl_api_accept_session_t_handler (vl_api_accept_session_t * mp)
 
   /* Create an event for handlers */
 
-  clib_spinlock_lock (&vcm->event_thread.events_lockp);
+  VCL_EVENTS_LOCK ();
 
   pool_get (vcm->event_thread.vce_events, ev);
-  ev->data = clib_mem_alloc (sizeof (vce_event_connect_request_t));
-  ev->refcnt = 0;
   ev_idx = (u32) (ev - vcm->event_thread.vce_events);
-  ecr = ev->data;
+  ecr = vce_get_event_data (ev, sizeof (*ecr));
   ev->evk.eid = VCL_EVENT_CONNECT_REQ_ACCEPTED;
   listen_session = vppcom_session_table_lookup_listener (mp->listener_handle);
   ev->evk.session_index = (u32) (listen_session - vcm->sessions);
   ecr->accepted_session_index = session_index;
 
-  clib_spinlock_unlock (&vcm->event_thread.events_lockp);
+  VCL_EVENTS_UNLOCK ();
 
   rv = vce_generate_event (&vcm->event_thread, ev_idx);
-
   ASSERT (rv == 0);
 
   if (VPPCOM_DEBUG > 1)
     clib_warning ("VCL<%d>: vpp handle 0x%llx, sid %u: client accept "
                  "request from %s address %U port %d queue %p!", getpid (),
                  mp->handle, session_index, mp->is_ip4 ? "IPv4" : "IPv6",
-                 format_ip46_address, &mp->ip, mp->is_ip4,
+                 format_ip46_address, &mp->ip,
+                 mp->is_ip4 ? IP46_TYPE_IP4 : IP46_TYPE_IP6,
                  clib_net_to_host_u16 (mp->port), session->vpp_event_queue);
 
   if (VPPCOM_DEBUG > 0)
@@ -1399,10 +1361,13 @@ vl_api_accept_session_t_handler (vl_api_accept_session_t * mp)
        }
     }
 
-  clib_spinlock_unlock (&vcm->sessions_lockp);
+  VCL_SESSION_UNLOCK ();
 
 }
 
+/* VPP combines bind and listen as one operation. VCL manages the separation
+ * of bind and listen locally via vppcom_session_bind() and
+ * vppcom_session_listen() */
 static void
 vppcom_send_bind_sock (session_t * session, u32 session_index)
 {
@@ -1445,7 +1410,7 @@ vppcom_session_unbind (u32 session_index)
   u64 vpp_handle;
   elog_track_t session_elog_track;
 
-  VCL_LOCK_AND_GET_SESSION (session_index, &session);
+  VCL_SESSION_LOCK_AND_GET (session_index, &session);
 
   vpp_handle = session->vpp_handle;
   vppcom_session_table_del_listener (vpp_handle);
@@ -1453,7 +1418,7 @@ vppcom_session_unbind (u32 session_index)
   session->state = STATE_DISCONNECT;
   session_elog_track = session->elog_track;
 
-  clib_spinlock_unlock (&vcm->sessions_lockp);
+  VCL_SESSION_UNLOCK ();
 
   if (VPPCOM_DEBUG > 1)
     clib_warning ("VCL<%d>: vpp handle 0x%llx, sid %u: "
@@ -1495,11 +1460,11 @@ vppcom_session_disconnect (u32 session_index)
   u64 vpp_handle;
   session_state_t state;
 
-  VCL_LOCK_AND_GET_SESSION (session_index, &session);
+  VCL_SESSION_LOCK_AND_GET (session_index, &session);
 
   vpp_handle = session->vpp_handle;
   state = session->state;
-  clib_spinlock_unlock (&vcm->sessions_lockp);
+  VCL_SESSION_UNLOCK ();
 
   if (VPPCOM_DEBUG > 1)
     {
@@ -2143,6 +2108,7 @@ vppcom_app_create (char *app_name)
                          vcm->cfg.listen_queue_size);
       vppcom_cfg_read (conf_fname);
 
+
       env_var_str = getenv (VPPCOM_ENV_API_PREFIX);
       if (env_var_str)
        {
@@ -2259,7 +2225,6 @@ vppcom_app_create (char *app_name)
 
       rv = vce_start_event_thread (&(vcm->event_thread), 20);
 
-
       if (VPPCOM_DEBUG > 0)
        clib_warning ("VCL<%d>: sending session enable", getpid ());
 
@@ -2295,6 +2260,7 @@ void
 vppcom_app_destroy (void)
 {
   int rv;
+  f64 orig_app_timeout;
 
   if (vcm->my_client_index == ~0)
     return;
@@ -2322,7 +2288,10 @@ vppcom_app_destroy (void)
     }
 
   vppcom_app_detach ();
+  orig_app_timeout = vcm->cfg.app_timeout;
+  vcm->cfg.app_timeout = 2.0;
   rv = vppcom_wait_for_app_state_change (STATE_APP_ENABLED);
+  vcm->cfg.app_timeout = orig_app_timeout;
   if (PREDICT_FALSE (rv))
     {
       if (VPPCOM_DEBUG > 0)
@@ -2348,7 +2317,7 @@ vppcom_session_create (u8 proto, u8 is_nonblocking)
   session_state_t state;
   elog_track_t session_elog_track;
 
-  clib_spinlock_lock (&vcm->sessions_lockp);
+  VCL_SESSION_LOCK ();
   pool_get (vcm->sessions, session);
   memset (session, 0, sizeof (*session));
   session_index = session - vcm->sessions;
@@ -2372,7 +2341,7 @@ vppcom_session_create (u8 proto, u8 is_nonblocking)
       session_elog_track = session->elog_track;
     }
 
-  clib_spinlock_unlock (&vcm->sessions_lockp);
+  VCL_SESSION_UNLOCK ();
 
   if (VPPCOM_DEBUG > 0)
     clib_warning ("VCL<%d>: sid %u", getpid (), session_index);
@@ -2415,14 +2384,14 @@ vppcom_session_close (uint32_t session_index)
   session_state_t state;
   elog_track_t session_elog_track;
 
-  VCL_LOCK_AND_GET_SESSION (session_index, &session);
+  VCL_SESSION_LOCK_AND_GET (session_index, &session);
   is_vep = session->is_vep;
   is_vep_session = session->is_vep_session;
   next_sid = session->vep.next_sid;
   vep_idx = session->vep.vep_idx;
   state = session->state;
   vpp_handle = session->vpp_handle;
-  clib_spinlock_unlock (&vcm->sessions_lockp);
+  VCL_SESSION_UNLOCK ();
 
   /*
    * Why two if(VPPCOM_DEBUG) checks?
@@ -2460,9 +2429,9 @@ vppcom_session_close (uint32_t session_index)
                          getpid (), vpp_handle, next_sid, vep_idx,
                          rv, vppcom_retval_str (rv));
 
-         VCL_LOCK_AND_GET_SESSION (session_index, &session);
+         VCL_SESSION_LOCK_AND_GET (session_index, &session);
          next_sid = session->vep.next_sid;
-         clib_spinlock_unlock (&vcm->sessions_lockp);
+         VCL_SESSION_UNLOCK ();
        }
     }
   else
@@ -2501,7 +2470,7 @@ vppcom_session_close (uint32_t session_index)
        }
     }
 
-  VCL_LOCK_AND_GET_SESSION (session_index, &session);
+  VCL_SESSION_LOCK_AND_GET (session_index, &session);
   vpp_handle = session->vpp_handle;
   if (vpp_handle != ~0)
     {
@@ -2511,7 +2480,7 @@ vppcom_session_close (uint32_t session_index)
     }
   pool_put_index (vcm->sessions, session_index);
 
-  clib_spinlock_unlock (&vcm->sessions_lockp);
+  VCL_SESSION_UNLOCK ();
 
   if (VPPCOM_DEBUG > 0)
     {
@@ -2555,11 +2524,11 @@ vppcom_session_bind (uint32_t session_index, vppcom_endpt_t * ep)
   if (!ep || !ep->ip)
     return VPPCOM_EINVAL;
 
-  VCL_LOCK_AND_GET_SESSION (session_index, &session);
+  VCL_SESSION_LOCK_AND_GET (session_index, &session);
 
   if (session->is_vep)
     {
-      clib_spinlock_unlock (&vcm->sessions_lockp);
+      VCL_SESSION_UNLOCK ();
       clib_warning ("VCL<%d>: ERROR: sid %u: cannot "
                    "bind to an epoll session!", getpid (), session_index);
       rv = VPPCOM_EBADFD;
@@ -2567,7 +2536,8 @@ vppcom_session_bind (uint32_t session_index, vppcom_endpt_t * ep)
     }
 
   session->lcl_addr.is_ip4 = ep->is_ip4;
-  session->lcl_addr.ip46 = to_ip46 (!ep->is_ip4, ep->ip);
+  session->lcl_addr.ip46 = to_ip46 (ep->is_ip4 ? IP46_TYPE_IP4 :
+                                   IP46_TYPE_IP6, ep->ip);
   session->lcl_port = ep->port;
 
   if (VPPCOM_DEBUG > 0)
@@ -2575,7 +2545,7 @@ vppcom_session_bind (uint32_t session_index, vppcom_endpt_t * ep)
                  "port %u, proto %s", getpid (), session_index,
                  session->lcl_addr.is_ip4 ? "IPv4" : "IPv6",
                  format_ip46_address, &session->lcl_addr.ip46,
-                 session->lcl_addr.is_ip4,
+                 session->lcl_addr.is_ip4 ? IP46_TYPE_IP4 : IP46_TYPE_IP6,
                  clib_net_to_host_u16 (session->lcl_port),
                  session->proto ? "UDP" : "TCP");
 
@@ -2609,7 +2579,7 @@ vppcom_session_bind (uint32_t session_index, vppcom_endpt_t * ep)
        }
     }
 
-  clib_spinlock_unlock (&vcm->sessions_lockp);
+  VCL_SESSION_UNLOCK ();
 done:
   return rv;
 }
@@ -2624,11 +2594,11 @@ vppcom_session_listen (uint32_t listen_session_index, uint32_t q_len)
   if (q_len == 0 || q_len == ~0)
     q_len = vcm->cfg.listen_queue_size;
 
-  VCL_LOCK_AND_GET_SESSION (listen_session_index, &listen_session);
+  VCL_SESSION_LOCK_AND_GET (listen_session_index, &listen_session);
 
   if (listen_session->is_vep)
     {
-      clib_spinlock_unlock (&vcm->sessions_lockp);
+      VCL_SESSION_UNLOCK ();
       clib_warning ("VCL<%d>: ERROR: sid %u: cannot listen on an "
                    "epoll session!", getpid (), listen_session_index);
       rv = VPPCOM_EBADFD;
@@ -2638,7 +2608,7 @@ vppcom_session_listen (uint32_t listen_session_index, uint32_t q_len)
   listen_vpp_handle = listen_session->vpp_handle;
   if (listen_session->state & STATE_LISTEN)
     {
-      clib_spinlock_unlock (&vcm->sessions_lockp);
+      VCL_SESSION_UNLOCK ();
       if (VPPCOM_DEBUG > 0)
        clib_warning ("VCL<%d>: vpp handle 0x%llx, sid %u: "
                      "already in listen state!",
@@ -2649,33 +2619,33 @@ vppcom_session_listen (uint32_t listen_session_index, uint32_t q_len)
 
   if (VPPCOM_DEBUG > 0)
     clib_warning ("VCL<%d>: vpp handle 0x%llx, "
-                 "sid %u: sending bind request...",
+                 "sid %u: sending VPP bind+listen request...",
                  getpid (), listen_vpp_handle, listen_session_index);
 
   vppcom_send_bind_sock (listen_session, listen_session_index);
-  clib_spinlock_unlock (&vcm->sessions_lockp);
+  VCL_SESSION_UNLOCK ();
   retval =
     vppcom_wait_for_session_state_change (listen_session_index, STATE_LISTEN,
                                          vcm->cfg.session_timeout);
 
-  VCL_LOCK_AND_GET_SESSION (listen_session_index, &listen_session);
+  VCL_SESSION_LOCK_AND_GET (listen_session_index, &listen_session);
   if (PREDICT_FALSE (retval))
     {
       if (VPPCOM_DEBUG > 0)
-       clib_warning ("VCL<%d>: vpp handle 0x%llx, sid %u: bind failed! "
-                     "returning %d (%s)", getpid (),
-                     listen_session->vpp_handle, listen_session_index,
-                     retval, vppcom_retval_str (retval));
-      clib_spinlock_unlock (&vcm->sessions_lockp);
+       clib_warning
+         ("VCL<%d>: vpp handle 0x%llx, sid %u: bind+listen failed! "
+          "returning %d (%s)", getpid (), listen_session->vpp_handle,
+          listen_session_index, retval, vppcom_retval_str (retval));
+      VCL_SESSION_UNLOCK ();
       rv = retval;
       goto done;
     }
 
-  clib_spinlock_lock (&vcm->session_fifo_lockp);
+  VCL_ACCEPT_FIFO_LOCK ();
   clib_fifo_validate (vcm->client_session_index_fifo, q_len);
-  clib_spinlock_unlock (&vcm->session_fifo_lockp);
+  VCL_ACCEPT_FIFO_UNLOCK ();
 
-  clib_spinlock_unlock (&vcm->sessions_lockp);
+  VCL_SESSION_UNLOCK ();
 
 done:
   return rv;
@@ -2723,13 +2693,13 @@ vppcom_session_accept (uint32_t listen_session_index, vppcom_endpt_t * ep,
   int millisecond_timeout = 1;
   int hours_timeout = 20 * 60 * 60;
 
-  VCL_LOCK_AND_GET_SESSION (listen_session_index, &listen_session);
+  VCL_SESSION_LOCK_AND_GET (listen_session_index, &listen_session);
   listen_vpp_handle = listen_session->vpp_handle;      // For debugging
 
   rv = validate_args_session_accept_ (listen_session);
   if (rv)
     {
-      clib_spinlock_unlock (&vcm->sessions_lockp);
+      VCL_SESSION_UNLOCK ();
       goto done;
     }
 
@@ -2745,36 +2715,36 @@ vppcom_session_accept (uint32_t listen_session_index, vppcom_endpt_t * ep,
                                         VCL_SESS_ATTR_NONBLOCK)))
     ts.tv_sec += hours_timeout;
 
-  clib_spinlock_unlock (&vcm->sessions_lockp);
+  VCL_SESSION_UNLOCK ();
 
   /* Register handler for connect_request event on listen_session_index */
   vce_event_key_t evk;
   evk.session_index = listen_session_index;
   evk.eid = VCL_EVENT_CONNECT_REQ_ACCEPTED;
   reg = vce_register_handler (&vcm->event_thread, &evk,
-                             vce_connect_request_handler_fn);
-
+                             vce_connect_request_handler_fn, 0);
+  VCL_EVENTS_LOCK ();
   ev = vce_get_event_from_index (&vcm->event_thread, reg->ev_idx);
-
   pthread_mutex_lock (&reg->handler_lock);
   while (!ev)
     {
-      rv =
-       pthread_cond_timedwait (&reg->handler_cond, &reg->handler_lock, &ts);
+      VCL_EVENTS_UNLOCK ();
+      rv = pthread_cond_timedwait (&reg->handler_cond,
+                                  &reg->handler_lock, &ts);
       if (rv == ETIMEDOUT)
        {
          rv = VPPCOM_EAGAIN;
          goto cleanup;
        }
+      VCL_EVENTS_LOCK ();
       ev = vce_get_event_from_index (&vcm->event_thread, reg->ev_idx);
     }
-  result = (vce_event_connect_request_t *) ev->data;
+  result = vce_get_event_data (ev, sizeof (*result));
   client_session_index = result->accepted_session_index;
-
-
+  VCL_EVENTS_UNLOCK ();
 
   /* Remove from the FIFO used to service epoll */
-  clib_spinlock_lock (&vcm->session_fifo_lockp);
+  VCL_ACCEPT_FIFO_LOCK ();
   if (clib_fifo_elts (vcm->client_session_index_fifo))
     {
       u32 tmp_client_session_index;
@@ -2785,9 +2755,9 @@ vppcom_session_accept (uint32_t listen_session_index, vppcom_endpt_t * ep,
        clib_fifo_add1 (vcm->client_session_index_fifo,
                        tmp_client_session_index);
     }
-  clib_spinlock_unlock (&vcm->session_fifo_lockp);
+  VCL_ACCEPT_FIFO_UNLOCK ();
 
-  clib_spinlock_lock (&vcm->sessions_lockp);
+  VCL_SESSION_LOCK ();
 
   rv = vppcom_session_at_index (client_session_index, &client_session);
   if (PREDICT_FALSE (rv))
@@ -2797,7 +2767,7 @@ vppcom_session_accept (uint32_t listen_session_index, vppcom_endpt_t * ep,
                    "lookup failed! returning %d (%s)", getpid (),
                    listen_vpp_handle, listen_session_index,
                    client_session_index, rv, vppcom_retval_str (rv));
-      goto done;
+      goto cleanup;
     }
 
   if (flags & O_NONBLOCK)
@@ -2831,13 +2801,20 @@ vppcom_session_accept (uint32_t listen_session_index, vppcom_endpt_t * ep,
 
   if (VPPCOM_DEBUG > 0)
     clib_warning ("VCL<%d>: vpp handle 0x%llx, sid %u: accepted vpp handle "
-                 "0x%llx, sid %u connection to local %s address "
-                 "%U port %u", getpid (), listen_vpp_handle,
+                 "0x%llx, sid %u connection from peer %s address %U port %u "
+                 "to local %s address %U port %u",
+                 getpid (), listen_vpp_handle,
                  listen_session_index, client_session->vpp_handle,
                  client_session_index,
+                 client_session->peer_addr.is_ip4 ? "IPv4" : "IPv6",
+                 format_ip46_address, &client_session->peer_addr.ip46,
+                 client_session->peer_addr.is_ip4 ?
+                 IP46_TYPE_IP4 : IP46_TYPE_IP6,
+                 clib_net_to_host_u16 (client_session->peer_port),
                  client_session->lcl_addr.is_ip4 ? "IPv4" : "IPv6",
                  format_ip46_address, &client_session->lcl_addr.ip46,
-                 client_session->lcl_addr.is_ip4,
+                 client_session->lcl_addr.is_ip4 ?
+                 IP46_TYPE_IP4 : IP46_TYPE_IP6,
                  clib_net_to_host_u16 (client_session->lcl_port));
 
   if (VPPCOM_DEBUG > 0)
@@ -2892,11 +2869,20 @@ vppcom_session_accept (uint32_t listen_session_index, vppcom_endpt_t * ep,
        }
     }
 
-  clib_spinlock_unlock (&vcm->sessions_lockp);
+  VCL_SESSION_UNLOCK ();
 
   rv = (int) client_session_index;
-  vce_clear_event (&vcm->event_thread, ev);
-
+  vce_clear_event (&vcm->event_thread, reg->ev_idx);
+  if (vcm->session_io_thread.io_sessions_lockp)
+    {
+      /* Throw this new accepted session index into the rx poll thread pool */
+      VCL_IO_SESSIONS_LOCK ();
+      u32 *active_session_index;
+      pool_get (vcm->session_io_thread.active_session_indexes,
+               active_session_index);
+      *active_session_index = client_session_index;
+      VCL_IO_SESSIONS_UNLOCK ();
+    }
 cleanup:
   vce_unregister_handler (&vcm->event_thread, reg);
   pthread_mutex_unlock (&reg->handler_lock);
@@ -2912,11 +2898,11 @@ vppcom_session_connect (uint32_t session_index, vppcom_endpt_t * server_ep)
   u64 vpp_handle = 0;
   int rv, retval = VPPCOM_OK;
 
-  VCL_LOCK_AND_GET_SESSION (session_index, &session);
+  VCL_SESSION_LOCK_AND_GET (session_index, &session);
 
   if (PREDICT_FALSE (session->is_vep))
     {
-      clib_spinlock_unlock (&vcm->sessions_lockp);
+      VCL_SESSION_UNLOCK ();
       clib_warning ("VCL<%d>: ERROR: sid %u: cannot "
                    "connect on an epoll session!", getpid (), session_index);
       rv = VPPCOM_EBADFD;
@@ -2931,17 +2917,23 @@ vppcom_session_connect (uint32_t session_index, vppcom_endpt_t * server_ep)
                      getpid (), session->vpp_handle, session_index,
                      session->peer_addr.is_ip4 ? "IPv4" : "IPv6",
                      format_ip46_address,
-                     &session->peer_addr.ip46, session->peer_addr.is_ip4,
+                     &session->peer_addr.ip46, session->peer_addr.is_ip4 ?
+                     IP46_TYPE_IP4 : IP46_TYPE_IP6,
                      clib_net_to_host_u16 (session->peer_port),
                      session->proto ? "UDP" : "TCP", session->state,
                      vppcom_session_state_str (session->state));
 
-      clib_spinlock_unlock (&vcm->sessions_lockp);
+      VCL_SESSION_UNLOCK ();
       goto done;
     }
 
   session->peer_addr.is_ip4 = server_ep->is_ip4;
-  session->peer_addr.ip46 = to_ip46 (!server_ep->is_ip4, server_ep->ip);
+  if (session->peer_addr.is_ip4)
+    clib_memcpy (&session->peer_addr.ip46.ip4, server_ep->ip,
+                sizeof (ip4_address_t));
+  else
+    clib_memcpy (&session->peer_addr.ip46.ip6, server_ep->ip,
+                sizeof (ip6_address_t));
   session->peer_port = server_ep->port;
 
   if (VPPCOM_DEBUG > 0)
@@ -2950,20 +2942,21 @@ vppcom_session_connect (uint32_t session_index, vppcom_endpt_t * server_ep)
                  getpid (), session->vpp_handle, session_index,
                  session->peer_addr.is_ip4 ? "IPv4" : "IPv6",
                  format_ip46_address,
-                 &session->peer_addr.ip46, session->peer_addr.is_ip4,
+                 &session->peer_addr.ip46, session->peer_addr.is_ip4 ?
+                 IP46_TYPE_IP4 : IP46_TYPE_IP6,
                  clib_net_to_host_u16 (session->peer_port),
                  session->proto ? "UDP" : "TCP");
 
   vppcom_send_connect_sock (session, session_index);
-  clib_spinlock_unlock (&vcm->sessions_lockp);
+  VCL_SESSION_UNLOCK ();
 
   retval =
     vppcom_wait_for_session_state_change (session_index, STATE_CONNECT,
                                          vcm->cfg.session_timeout);
 
-  VCL_LOCK_AND_GET_SESSION (session_index, &session);
+  VCL_SESSION_LOCK_AND_GET (session_index, &session);
   vpp_handle = session->vpp_handle;
-  clib_spinlock_unlock (&vcm->sessions_lockp);
+  VCL_SESSION_UNLOCK ();
 
 done:
   if (PREDICT_FALSE (retval))
@@ -3005,7 +2998,7 @@ vppcom_session_read_internal (uint32_t session_index, void *buf, int n,
 
   ASSERT (buf);
 
-  VCL_LOCK_AND_GET_SESSION (session_index, &session);
+  VCL_SESSION_LOCK_AND_GET (session_index, &session);
 
   is_nonblocking = VCL_SESS_ATTR_TEST (session->attr, VCL_SESS_ATTR_NONBLOCK);
   rx_fifo = session->rx_fifo;
@@ -3014,7 +3007,7 @@ vppcom_session_read_internal (uint32_t session_index, void *buf, int n,
 
   if (PREDICT_FALSE (session->is_vep))
     {
-      clib_spinlock_unlock (&vcm->sessions_lockp);
+      VCL_SESSION_UNLOCK ();
       clib_warning ("VCL<%d>: ERROR: sid %u: cannot "
                    "read from an epoll session!", getpid (), session_index);
       rv = VPPCOM_EBADFD;
@@ -3023,7 +3016,7 @@ vppcom_session_read_internal (uint32_t session_index, void *buf, int n,
 
   if (PREDICT_FALSE (!(state & (SERVER_STATE_OPEN | CLIENT_STATE_OPEN))))
     {
-      clib_spinlock_unlock (&vcm->sessions_lockp);
+      VCL_SESSION_UNLOCK ();
       rv = ((state & STATE_DISCONNECT) ? VPPCOM_ECONNRESET : VPPCOM_ENOTCONN);
 
       if (VPPCOM_DEBUG > 0)
@@ -3035,7 +3028,7 @@ vppcom_session_read_internal (uint32_t session_index, void *buf, int n,
       goto done;
     }
 
-  clib_spinlock_unlock (&vcm->sessions_lockp);
+  VCL_SESSION_UNLOCK ();
 
   do
     {
@@ -3048,7 +3041,7 @@ vppcom_session_read_internal (uint32_t session_index, void *buf, int n,
 
   if (n_read <= 0)
     {
-      VCL_LOCK_AND_GET_SESSION (session_index, &session);
+      VCL_SESSION_LOCK_AND_GET (session_index, &session);
 
       poll_et = (((EPOLLET | EPOLLIN) & session->vep.ev.events) ==
                 (EPOLLET | EPOLLIN));
@@ -3076,7 +3069,7 @@ vppcom_session_read_internal (uint32_t session_index, void *buf, int n,
       else
        rv = VPPCOM_EAGAIN;
 
-      clib_spinlock_unlock (&vcm->sessions_lockp);
+      VCL_SESSION_UNLOCK ();
     }
   else
     rv = n_read;
@@ -3128,9 +3121,9 @@ vppcom_session_read_ready (session_t * session, u32 session_index)
 
   if (session->state & STATE_LISTEN)
     {
-      clib_spinlock_lock (&vcm->session_fifo_lockp);
+      VCL_ACCEPT_FIFO_LOCK ();
       ready = clib_fifo_elts (vcm->client_session_index_fifo);
-      clib_spinlock_unlock (&vcm->session_fifo_lockp);
+      VCL_ACCEPT_FIFO_UNLOCK ();
     }
   else
     {
@@ -3209,7 +3202,7 @@ vppcom_session_write (uint32_t session_index, void *buf, size_t n)
 
   ASSERT (buf);
 
-  VCL_LOCK_AND_GET_SESSION (session_index, &session);
+  VCL_SESSION_LOCK_AND_GET (session_index, &session);
 
   tx_fifo = session->tx_fifo;
   is_nonblocking = VCL_SESS_ATTR_TEST (session->attr, VCL_SESS_ATTR_NONBLOCK);
@@ -3218,7 +3211,7 @@ vppcom_session_write (uint32_t session_index, void *buf, size_t n)
 
   if (PREDICT_FALSE (session->is_vep))
     {
-      clib_spinlock_unlock (&vcm->sessions_lockp);
+      VCL_SESSION_UNLOCK ();
       clib_warning ("VCL<%d>: ERROR: vpp handle 0x%llx, sid %u: "
                    "cannot write to an epoll session!",
                    getpid (), vpp_handle, session_index);
@@ -3233,7 +3226,7 @@ vppcom_session_write (uint32_t session_index, void *buf, size_t n)
        ((session->state & STATE_DISCONNECT) ? VPPCOM_ECONNRESET :
         VPPCOM_ENOTCONN);
 
-      clib_spinlock_unlock (&vcm->sessions_lockp);
+      VCL_SESSION_UNLOCK ();
       if (VPPCOM_DEBUG > 1)
        clib_warning ("VCL<%d>: vpp handle 0x%llx, sid %u: "
                      "session is not open! state 0x%x (%s)",
@@ -3242,7 +3235,7 @@ vppcom_session_write (uint32_t session_index, void *buf, size_t n)
       goto done;
     }
 
-  clib_spinlock_unlock (&vcm->sessions_lockp);
+  VCL_SESSION_UNLOCK ();
 
   do
     {
@@ -3250,18 +3243,23 @@ vppcom_session_write (uint32_t session_index, void *buf, size_t n)
     }
   while (!is_nonblocking && (n_write <= 0));
 
-  /* If event wasn't set, add one */
+  /* If event wasn't set, add one
+   *
+   * To reduce context switching, can check if an
+   * event is already there for this event_key, but for now
+   * this will suffice. */
+
   if ((n_write > 0) && svm_fifo_set_event (tx_fifo))
     {
       /* Fabricate TX event, send to vpp */
       evt.fifo = tx_fifo;
       evt.event_type = FIFO_EVENT_APP_TX;
 
-      VCL_LOCK_AND_GET_SESSION (session_index, &session);
+      VCL_SESSION_LOCK_AND_GET (session_index, &session);
       q = session->vpp_event_queue;
       ASSERT (q);
       svm_queue_add (q, (u8 *) & evt, 0 /* do wait for mutex */ );
-      clib_spinlock_unlock (&vcm->sessions_lockp);
+      VCL_SESSION_UNLOCK ();
       if (VPPCOM_DEBUG > 1)
        clib_warning ("VCL<%d>: vpp handle 0x%llx, sid %u: "
                      "added FIFO_EVENT_APP_TX to "
@@ -3271,7 +3269,7 @@ vppcom_session_write (uint32_t session_index, void *buf, size_t n)
 
   if (n_write <= 0)
     {
-      VCL_LOCK_AND_GET_SESSION (session_index, &session);
+      VCL_SESSION_LOCK_AND_GET (session_index, &session);
 
       poll_et = (((EPOLLET | EPOLLOUT) & session->vep.ev.events) ==
                 (EPOLLET | EPOLLOUT));
@@ -3300,7 +3298,7 @@ vppcom_session_write (uint32_t session_index, void *buf, size_t n)
       else
        rv = VPPCOM_EAGAIN;
 
-      clib_spinlock_unlock (&vcm->sessions_lockp);
+      VCL_SESSION_UNLOCK ();
     }
   else
     rv = n_write;
@@ -3450,11 +3448,11 @@ vppcom_select (unsigned long n_bits, unsigned long *read_map,
             {
               clib_bitmap_foreach (session_index, vcm->rd_bitmap,
                 ({
-                  clib_spinlock_lock (&vcm->sessions_lockp);
+                  VCL_SESSION_LOCK();
                   rv = vppcom_session_at_index (session_index, &session);
                   if (rv < 0)
                     {
-                      clib_spinlock_unlock (&vcm->sessions_lockp);
+                      VCL_SESSION_UNLOCK();
                       if (VPPCOM_DEBUG > 1)
                         clib_warning ("VCL<%d>: session %d specified in "
                                       "read_map is closed.", getpid (),
@@ -3477,7 +3475,8 @@ vppcom_select (unsigned long n_bits, unsigned long *read_map,
                       reg = vce_get_event_handler (&vcm->event_thread, &evk);
                       if (!reg)
                         reg = vce_register_handler (&vcm->event_thread, &evk,
-                                    vce_poll_wait_connect_request_handler_fn);
+                                    vce_poll_wait_connect_request_handler_fn,
+                                                   0 /* No callback args */);
                       rv = vppcom_session_read_ready (session, session_index);
                       if (rv > 0)
                         {
@@ -3486,7 +3485,7 @@ vppcom_select (unsigned long n_bits, unsigned long *read_map,
                     }
                   else
                     rv = vppcom_session_read_ready (session, session_index);
-                  clib_spinlock_unlock (&vcm->sessions_lockp);
+                  VCL_SESSION_UNLOCK();
                   if (except_map && vcm->ex_bitmap &&
                       clib_bitmap_get (vcm->ex_bitmap, session_index) &&
                       (rv < 0))
@@ -3506,11 +3505,11 @@ vppcom_select (unsigned long n_bits, unsigned long *read_map,
             {
               clib_bitmap_foreach (session_index, vcm->wr_bitmap,
                 ({
-                  clib_spinlock_lock (&vcm->sessions_lockp);
+                  VCL_SESSION_LOCK();
                   rv = vppcom_session_at_index (session_index, &session);
                   if (rv < 0)
                     {
-                      clib_spinlock_unlock (&vcm->sessions_lockp);
+                      VCL_SESSION_UNLOCK();
                       if (VPPCOM_DEBUG > 0)
                         clib_warning ("VCL<%d>: session %d specified in "
                                       "write_map is closed.", getpid (),
@@ -3520,7 +3519,7 @@ vppcom_select (unsigned long n_bits, unsigned long *read_map,
                     }
 
                   rv = vppcom_session_write_ready (session, session_index);
-                  clib_spinlock_unlock (&vcm->sessions_lockp);
+                  VCL_SESSION_UNLOCK();
                   if (write_map && (rv > 0))
                     {
                       clib_bitmap_set_no_check (write_map, session_index, 1);
@@ -3533,11 +3532,11 @@ vppcom_select (unsigned long n_bits, unsigned long *read_map,
             {
               clib_bitmap_foreach (session_index, vcm->ex_bitmap,
                 ({
-                  clib_spinlock_lock (&vcm->sessions_lockp);
+                  VCL_SESSION_LOCK();
                   rv = vppcom_session_at_index (session_index, &session);
                   if (rv < 0)
                     {
-                      clib_spinlock_unlock (&vcm->sessions_lockp);
+                      VCL_SESSION_UNLOCK();
                       if (VPPCOM_DEBUG > 1)
                         clib_warning ("VCL<%d>: session %d specified in "
                                       "except_map is closed.", getpid (),
@@ -3547,7 +3546,7 @@ vppcom_select (unsigned long n_bits, unsigned long *read_map,
                     }
 
                   rv = vppcom_session_read_ready (session, session_index);
-                  clib_spinlock_unlock (&vcm->sessions_lockp);
+                  VCL_SESSION_UNLOCK();
                   if (rv < 0)
                     {
                       clib_bitmap_set_no_check (except_map, session_index, 1);
@@ -3654,7 +3653,7 @@ vppcom_epoll_create (void)
   u32 vep_idx;
   elog_track_t vep_elog_track;
 
-  clib_spinlock_lock (&vcm->sessions_lockp);
+  VCL_SESSION_LOCK ();
   pool_get (vcm->sessions, vep_session);
   memset (vep_session, 0, sizeof (*vep_session));
   vep_idx = vep_session - vcm->sessions;
@@ -3676,7 +3675,7 @@ vppcom_epoll_create (void)
       vep_elog_track = vep_session->elog_track;
     }
 
-  clib_spinlock_unlock (&vcm->sessions_lockp);
+  VCL_SESSION_UNLOCK ();
 
   if (VPPCOM_DEBUG > 0)
     clib_warning ("VCL<%d>: Created vep_idx %u / sid %u!",
@@ -3720,7 +3719,7 @@ vppcom_epoll_ctl (uint32_t vep_idx, int op, uint32_t session_index,
       return VPPCOM_EINVAL;
     }
 
-  clib_spinlock_lock (&vcm->sessions_lockp);
+  VCL_SESSION_LOCK ();
   rv = vppcom_session_at_index (vep_idx, &vep_session);
   if (PREDICT_FALSE (rv))
     {
@@ -3796,7 +3795,8 @@ vppcom_epoll_ctl (uint32_t vep_idx, int op, uint32_t session_index,
          evk.eid = VCL_EVENT_CONNECT_REQ_ACCEPTED;
          vep_session->poll_reg =
            vce_register_handler (&vcm->event_thread, &evk,
-                                 vce_poll_wait_connect_request_handler_fn);
+                                 vce_poll_wait_connect_request_handler_fn,
+                                 0 /* No callback args */ );
        }
       if (VPPCOM_DEBUG > 1)
        clib_warning ("VCL<%d>: EPOLL_CTL_ADD: vep_idx %u, "
@@ -3954,7 +3954,7 @@ vppcom_epoll_ctl (uint32_t vep_idx, int op, uint32_t session_index,
   vep_verify_epoll_chain (vep_idx);
 
 done:
-  clib_spinlock_unlock (&vcm->sessions_lockp);
+  VCL_SESSION_UNLOCK ();
   return rv;
 }
 
@@ -3979,12 +3979,12 @@ vppcom_epoll_wait (uint32_t vep_idx, struct epoll_event *events,
     }
   memset (events, 0, sizeof (*events) * maxevents);
 
-  VCL_LOCK_AND_GET_SESSION (vep_idx, &vep_session);
+  VCL_SESSION_LOCK_AND_GET (vep_idx, &vep_session);
   vep_next_sid = vep_session->vep.next_sid;
   is_vep = vep_session->is_vep;
   wait_cont_idx = vep_session->wait_cont_idx;
   vep_elog_track = vep_session->elog_track;
-  clib_spinlock_unlock (&vcm->sessions_lockp);
+  VCL_SESSION_UNLOCK ();
 
   if (PREDICT_FALSE (!is_vep))
     {
@@ -4034,7 +4034,7 @@ vppcom_epoll_wait (uint32_t vep_idx, struct epoll_event *events,
          int ready;
          u64 session_ev_data;
 
-         VCL_LOCK_AND_GET_SESSION (sid, &session);
+         VCL_SESSION_LOCK_AND_GET (sid, &session);
          next_sid = session->vep.next_sid;
          session_events = session->vep.ev.events;
          et_mask = session->vep.et_mask;
@@ -4048,7 +4048,7 @@ vppcom_epoll_wait (uint32_t vep_idx, struct epoll_event *events,
              session_elog_track = session->elog_track;
            }
 
-         clib_spinlock_unlock (&vcm->sessions_lockp);
+         VCL_SESSION_UNLOCK ();
 
          if (PREDICT_FALSE (is_vep))
            {
@@ -4117,9 +4117,9 @@ vppcom_epoll_wait (uint32_t vep_idx, struct epoll_event *events,
 
          if (EPOLLIN & session_events)
            {
-             VCL_LOCK_AND_GET_SESSION (sid, &session);
+             VCL_SESSION_LOCK_AND_GET (sid, &session);
              ready = vppcom_session_read_ready (session, sid);
-             clib_spinlock_unlock (&vcm->sessions_lockp);
+             VCL_SESSION_UNLOCK ();
              if ((ready > 0) && (EPOLLIN & et_mask))
                {
                  add_event = 1;
@@ -4146,9 +4146,9 @@ vppcom_epoll_wait (uint32_t vep_idx, struct epoll_event *events,
 
          if (EPOLLOUT & session_events)
            {
-             VCL_LOCK_AND_GET_SESSION (sid, &session);
+             VCL_SESSION_LOCK_AND_GET (sid, &session);
              ready = vppcom_session_write_ready (session, sid);
-             clib_spinlock_unlock (&vcm->sessions_lockp);
+             VCL_SESSION_UNLOCK ();
              if ((ready > 0) && (EPOLLOUT & et_mask))
                {
                  add_event = 1;
@@ -4178,16 +4178,16 @@ vppcom_epoll_wait (uint32_t vep_idx, struct epoll_event *events,
              events[num_ev].data.u64 = session_ev_data;
              if (EPOLLONESHOT & session_events)
                {
-                 VCL_LOCK_AND_GET_SESSION (sid, &session);
+                 VCL_SESSION_LOCK_AND_GET (sid, &session);
                  session->vep.ev.events = 0;
-                 clib_spinlock_unlock (&vcm->sessions_lockp);
+                 VCL_SESSION_UNLOCK ();
                }
              num_ev++;
              if (num_ev == maxevents)
                {
-                 VCL_LOCK_AND_GET_SESSION (vep_idx, &vep_session);
+                 VCL_SESSION_LOCK_AND_GET (vep_idx, &vep_session);
                  vep_session->wait_cont_idx = next_sid;
-                 clib_spinlock_unlock (&vcm->sessions_lockp);
+                 VCL_SESSION_UNLOCK ();
                  goto done;
                }
            }
@@ -4206,9 +4206,9 @@ vppcom_epoll_wait (uint32_t vep_idx, struct epoll_event *events,
 
   if (wait_cont_idx != ~0)
     {
-      VCL_LOCK_AND_GET_SESSION (vep_idx, &vep_session);
+      VCL_SESSION_LOCK_AND_GET (vep_idx, &vep_session);
       vep_session->wait_cont_idx = ~0;
-      clib_spinlock_unlock (&vcm->sessions_lockp);
+      VCL_SESSION_UNLOCK ();
     }
 done:
   return (rv != VPPCOM_OK) ? rv : num_ev;
@@ -4223,7 +4223,7 @@ vppcom_session_attr (uint32_t session_index, uint32_t op,
   u32 *flags = buffer;
   vppcom_endpt_t *ep = buffer;
 
-  VCL_LOCK_AND_GET_SESSION (session_index, &session);
+  VCL_SESSION_LOCK_AND_GET (session_index, &session);
 
   ASSERT (session);
 
@@ -4374,7 +4374,8 @@ vppcom_session_attr (uint32_t session_index, uint32_t op,
            clib_warning ("VCL<%d>: VPPCOM_ATTR_GET_PEER_ADDR: sid %u, "
                          "is_ip4 = %u, addr = %U, port %u", getpid (),
                          session_index, ep->is_ip4, format_ip46_address,
-                         &session->peer_addr.ip46, ep->is_ip4,
+                         &session->peer_addr.ip46,
+                         ep->is_ip4 ? IP46_TYPE_IP4 : IP46_TYPE_IP6,
                          clib_net_to_host_u16 (ep->port));
          if (VPPCOM_DEBUG > 0)
            {
@@ -4440,7 +4441,8 @@ vppcom_session_attr (uint32_t session_index, uint32_t op,
            clib_warning ("VCL<%d>: VPPCOM_ATTR_GET_LCL_ADDR: sid %u, "
                          "is_ip4 = %u, addr = %U port %d", getpid (),
                          session_index, ep->is_ip4, format_ip46_address,
-                         &session->lcl_addr.ip46, ep->is_ip4,
+                         &session->lcl_addr.ip46,
+                         ep->is_ip4 ? IP46_TYPE_IP4 : IP46_TYPE_IP6,
                          clib_net_to_host_u16 (ep->port));
          if (VPPCOM_DEBUG > 0)
            {
@@ -5459,7 +5461,7 @@ vppcom_session_attr (uint32_t session_index, uint32_t op,
     }
 
 done:
-  clib_spinlock_unlock (&vcm->sessions_lockp);
+  VCL_SESSION_UNLOCK ();
   return rv;
 }
 
@@ -5472,11 +5474,11 @@ vppcom_session_recvfrom (uint32_t session_index, void *buffer,
 
   if (ep)
     {
-      clib_spinlock_lock (&vcm->sessions_lockp);
+      VCL_SESSION_LOCK ();
       rv = vppcom_session_at_index (session_index, &session);
       if (PREDICT_FALSE (rv))
        {
-         clib_spinlock_unlock (&vcm->sessions_lockp);
+         VCL_SESSION_UNLOCK ();
          if (VPPCOM_DEBUG > 0)
            clib_warning ("VCL<%d>: invalid session, "
                          "sid (%u) has been closed!",
@@ -5499,7 +5501,7 @@ vppcom_session_recvfrom (uint32_t session_index, void *buffer,
              /* *INDENT-ON* */
            }
          rv = VPPCOM_EBADFD;
-         clib_spinlock_unlock (&vcm->sessions_lockp);
+         VCL_SESSION_UNLOCK ();
          goto done;
        }
       ep->is_ip4 = session->peer_addr.is_ip4;
@@ -5510,7 +5512,7 @@ vppcom_session_recvfrom (uint32_t session_index, void *buffer,
       else
        clib_memcpy (ep->ip, &session->peer_addr.ip46.ip6,
                     sizeof (ip6_address_t));
-      clib_spinlock_unlock (&vcm->sessions_lockp);
+      VCL_SESSION_UNLOCK ();
     }
 
   if (flags == 0)
@@ -5574,17 +5576,17 @@ vppcom_poll (vcl_poll_t * vp, uint32_t n_sids, double wait_for_time)
        {
          ASSERT (vp[i].revents);
 
-         VCL_LOCK_AND_GET_SESSION (vp[i].sid, &session);
-         clib_spinlock_unlock (&vcm->sessions_lockp);
+         VCL_SESSION_LOCK_AND_GET (vp[i].sid, &session);
+         VCL_SESSION_UNLOCK ();
 
          if (*vp[i].revents)
            *vp[i].revents = 0;
 
          if (POLLIN & vp[i].events)
            {
-             VCL_LOCK_AND_GET_SESSION (vp[i].sid, &session);
+             VCL_SESSION_LOCK_AND_GET (vp[i].sid, &session);
              rv = vppcom_session_read_ready (session, vp[i].sid);
-             clib_spinlock_unlock (&vcm->sessions_lockp);
+             VCL_SESSION_UNLOCK ();
              if (rv > 0)
                {
                  *vp[i].revents |= POLLIN;
@@ -5608,9 +5610,9 @@ vppcom_poll (vcl_poll_t * vp, uint32_t n_sids, double wait_for_time)
 
          if (POLLOUT & vp[i].events)
            {
-             VCL_LOCK_AND_GET_SESSION (vp[i].sid, &session);
+             VCL_SESSION_LOCK_AND_GET (vp[i].sid, &session);
              rv = vppcom_session_write_ready (session, vp[i].sid);
-             clib_spinlock_unlock (&vcm->sessions_lockp);
+             VCL_SESSION_UNLOCK ();
              if (rv > 0)
                {
                  *vp[i].revents |= POLLOUT;
@@ -5632,7 +5634,7 @@ vppcom_poll (vcl_poll_t * vp, uint32_t n_sids, double wait_for_time)
                }
            }
 
-         if (0)                // Note "done:" label used by VCL_LOCK_AND_GET_SESSION()
+         if (0)                // Note "done:" label used by VCL_SESSION_LOCK_AND_GET()
            {
            done:
              *vp[i].revents = POLLNVAL;
@@ -5657,6 +5659,270 @@ vppcom_poll (vcl_poll_t * vp, uint32_t n_sids, double wait_for_time)
   return num_ev;
 }
 
+/*
+ * VPPCOM Event Functions
+ */
+
+void *
+vppcom_session_io_thread_fn (void *arg)
+{
+  vppcom_session_io_thread_t *evt = (vppcom_session_io_thread_t *) arg;
+  u32 *session_indexes = 0, *session_index;
+  int i, rv;
+  u32 bytes = 0;
+  session_t *session;
+
+  while (1)
+    {
+      vec_reset_length (session_indexes);
+      VCE_IO_SESSIONS_LOCK ();
+      pool_foreach (session_index, evt->active_session_indexes, (
+                                                                 {
+                                                                 vec_add1
+                                                                 (session_indexes,
+                                                                  *session_index);
+                                                                 }
+                   ));
+      VCE_IO_SESSIONS_UNLOCK ();
+      if (session_indexes)
+       {
+         for (i = 0; i < vec_len (session_indexes); ++i)
+           {
+             VCL_SESSION_LOCK_AND_GET (session_indexes[i], &session);
+             bytes = svm_fifo_max_dequeue (session->rx_fifo);
+             VCL_SESSION_UNLOCK ();
+
+             if (bytes)
+               {
+                 vppcom_ioevent_t *eio;
+                 vce_event_t *ev;
+                 u32 ev_idx;
+
+                 VCL_EVENTS_LOCK ();
+
+                 pool_get (vcm->event_thread.vce_events, ev);
+                 ev_idx = (u32) (ev - vcm->event_thread.vce_events);
+                 eio = vce_get_event_data (ev, sizeof (*eio));
+                 ev->evk.eid = VCL_EVENT_IOEVENT_RX_FIFO;
+                 ev->evk.session_index = session_indexes[i];
+                 eio->bytes = bytes;
+                 eio->session_index = session_indexes[i];
+
+                 VCL_EVENTS_UNLOCK ();
+
+                 rv = vce_generate_event (&vcm->event_thread, ev_idx);
+               }
+           }
+       }
+      struct timespec ts;
+      ts.tv_sec = 0;
+      ts.tv_nsec = 1000000;    /* 1 millisecond */
+      nanosleep (&ts, NULL);
+    }
+done:
+  VCL_SESSION_UNLOCK ();
+  return NULL;
+}
+
+int
+vppcom_start_io_event_thread (vppcom_session_io_thread_t * evt,
+                             u8 max_sessions)
+{
+  pthread_cond_init (&(evt->vce_io_cond), NULL);
+  pthread_mutex_init (&(evt->vce_io_lock), NULL);
+
+  clib_spinlock_init (&(evt->io_sessions_lockp));
+
+  return pthread_create (&(evt->thread), NULL /* attr */ ,
+                        vppcom_session_io_thread_fn, evt);
+}
+
+void
+vce_registered_ioevent_handler_fn (void *arg)
+{
+  vce_event_handler_reg_t *reg = (vce_event_handler_reg_t *) arg;
+  vppcom_ioevent_t *eio;
+  vce_event_t *ev;
+  u32 ioevt_ndx = (u64) (reg->handler_fn_args);
+  vppcom_session_ioevent_t *ioevent, ioevent_;
+
+  VCL_EVENTS_LOCK ();
+  ev = vce_get_event_from_index (&vcm->event_thread, reg->ev_idx);
+  eio = vce_get_event_data (ev, sizeof (*eio));
+  VCL_EVENTS_UNLOCK ();
+
+  VCL_IO_SESSIONS_LOCK ();
+  ioevent = pool_elt_at_index (vcm->session_io_thread.ioevents, ioevt_ndx);
+  ioevent_ = *ioevent;
+  VCL_IO_SESSIONS_UNLOCK ();
+  (ioevent_.user_cb) (eio, ioevent_.user_cb_data);
+  vce_clear_event (&vcm->event_thread, reg->ev_idx);
+  return;
+
+  /*TODO - Unregister check in close for this listener */
+
+}
+
+void
+vce_registered_listener_connect_handler_fn (void *arg)
+{
+  vce_event_handler_reg_t *reg = (vce_event_handler_reg_t *) arg;
+  vce_event_connect_request_t *ecr;
+  vce_event_t *ev;
+  vppcom_endpt_t ep;
+
+  session_t *new_session;
+  int rv;
+
+  vppcom_session_listener_t *session_listener =
+    (vppcom_session_listener_t *) reg->handler_fn_args;
+
+  VCL_EVENTS_LOCK ();
+  ev = vce_get_event_from_index (&vcm->event_thread, reg->ev_idx);
+  ecr = vce_get_event_data (ev, sizeof (*ecr));
+  VCL_EVENTS_UNLOCK ();
+  VCL_SESSION_LOCK_AND_GET (ecr->accepted_session_index, &new_session);
+
+  ep.is_ip4 = new_session->peer_addr.is_ip4;
+  ep.port = new_session->peer_port;
+  if (new_session->peer_addr.is_ip4)
+    clib_memcpy (&ep.ip, &new_session->peer_addr.ip46.ip4,
+                sizeof (ip4_address_t));
+  else
+    clib_memcpy (&ep.ip, &new_session->peer_addr.ip46.ip6,
+                sizeof (ip6_address_t));
+
+  vppcom_send_accept_session_reply (new_session->vpp_handle,
+                                   new_session->client_context,
+                                   0 /* retval OK */ );
+  VCL_SESSION_UNLOCK ();
+
+  (session_listener->user_cb) (ecr->accepted_session_index, &ep,
+                              session_listener->user_cb_data);
+
+  if (vcm->session_io_thread.io_sessions_lockp)
+    {
+      /* Throw this new accepted session index into the rx poll thread pool */
+      VCL_IO_SESSIONS_LOCK ();
+      u32 *active_session_index;
+      pool_get (vcm->session_io_thread.active_session_indexes,
+               active_session_index);
+      *active_session_index = ecr->accepted_session_index;
+      VCL_IO_SESSIONS_UNLOCK ();
+    }
+
+  /*TODO - Unregister check in close for this listener */
+  return;
+
+done:
+  ASSERT (0);                  // If we can't get a lock or accepted session fails, lets blow up.
+}
+
+/**
+ * @brief vce_poll_wait_connect_request_handler_fn
+ * - used by vppcom_epoll_xxxx() for listener sessions
+ * - when a vl_api_accept_session_t_handler() generates an event
+ *   this callback is alerted and sets the fields that vppcom_epoll_wait()
+ *   expects to see.
+ *
+ * @param arg - void* to be cast to vce_event_handler_reg_t*
+ */
+void
+vce_poll_wait_connect_request_handler_fn (void *arg)
+{
+  vce_event_handler_reg_t *reg = (vce_event_handler_reg_t *) arg;
+  vce_event_t *ev;
+  /* Retrieve the VCL_EVENT_CONNECT_REQ_ACCEPTED event */
+  ev = vce_get_event_from_index (&vcm->event_thread, reg->ev_idx);
+  vce_event_connect_request_t *ecr = vce_get_event_data (ev, sizeof (*ecr));
+
+  /* Add the accepted_session_index to the FIFO */
+  VCL_ACCEPT_FIFO_LOCK ();
+  clib_fifo_add1 (vcm->client_session_index_fifo,
+                 ecr->accepted_session_index);
+  VCL_ACCEPT_FIFO_UNLOCK ();
+
+  /* Recycling the event. */
+  VCL_EVENTS_LOCK ();
+  ev->recycle = 1;
+  clib_fifo_add1 (vcm->event_thread.event_index_fifo, reg->ev_idx);
+  VCL_EVENTS_UNLOCK ();
+}
+
+int
+vppcom_session_register_ioevent_cb (uint32_t session_index,
+                                   vppcom_session_ioevent_cb cb,
+                                   uint8_t rx, void *ptr)
+{
+  int rv = VPPCOM_OK;
+  vce_event_key_t evk;
+  vppcom_session_ioevent_t *ioevent;
+
+  if (!vcm->session_io_thread.io_sessions_lockp)
+    rv = vppcom_start_io_event_thread (&vcm->session_io_thread, 100    /* DAW_TODO: ??? hard-coded value */
+      );
+
+  if (rv == VPPCOM_OK)
+    {
+      void *io_evt_ndx;
+
+      /* Register handler for ioevent on session_index */
+      VCL_IO_SESSIONS_LOCK ();
+      pool_get (vcm->session_io_thread.ioevents, ioevent);
+      io_evt_ndx = (void *) (ioevent - vcm->session_io_thread.ioevents);
+      ioevent->user_cb = cb;
+      ioevent->user_cb_data = ptr;
+      VCL_IO_SESSIONS_UNLOCK ();
+
+      evk.session_index = session_index;
+      evk.eid = rx ? VCL_EVENT_IOEVENT_RX_FIFO : VCL_EVENT_IOEVENT_TX_FIFO;
+
+      (void) vce_register_handler (&vcm->event_thread, &evk,
+                                  vce_registered_ioevent_handler_fn,
+                                  io_evt_ndx);
+    }
+  return rv;
+}
+
+int
+vppcom_session_register_listener (uint32_t session_index,
+                                 vppcom_session_listener_cb cb,
+                                 vppcom_session_listener_errcb
+                                 errcb, uint8_t flags, int q_len, void *ptr)
+{
+  int rv = VPPCOM_OK;
+  vce_event_key_t evk;
+  vppcom_session_listener_t *listener_args;
+
+  if (!vcm->session_io_thread.io_sessions_lockp)
+    rv = vppcom_start_io_event_thread (&vcm->session_io_thread, 100    /* DAW_TODO: ??? hard-coded value */
+      );
+  if (rv)
+    {
+      goto done;
+    }
+  rv = vppcom_session_listen (session_index, q_len);
+  if (rv)
+    {
+      goto done;
+    }
+
+  /* Register handler for connect_request event on listen_session_index */
+  listener_args = clib_mem_alloc (sizeof (vppcom_session_listener_t)); // DAW_TODO: Use a pool instead of thrashing the memory allocator!
+  listener_args->user_cb = cb;
+  listener_args->user_cb_data = ptr;
+  listener_args->user_errcb = errcb;
+
+  evk.session_index = session_index;
+  evk.eid = VCL_EVENT_CONNECT_REQ_ACCEPTED;
+  (void) vce_register_handler (&vcm->event_thread, &evk,
+                              vce_registered_listener_connect_handler_fn,
+                              listener_args);
+
+done:
+  return rv;
+}
+
 /*
  * fd.io coding-style-patch-verification: ON
  *