u32 tx_fifo_size;
u32 event_queue_size;
u32 listen_queue_size;
- u8 session_scope_local;
- u8 session_scope_global;
+ u8 app_proxy_transport_tcp;
+ u8 app_proxy_transport_udp;
+ u8 app_scope_local;
+ u8 app_scope_global;
u8 *namespace_id;
u64 namespace_secret;
f64 app_timeout;
vppcom_main_t *vcm = &vppcom_main;
vl_api_application_attach_t *bmp;
u8 nsid_len = vec_len (vcm->cfg.namespace_id);
+ u8 app_is_proxy = (vcm->cfg.app_proxy_transport_tcp ||
+ vcm->cfg.app_proxy_transport_udp);
bmp = vl_msg_api_alloc (sizeof (*bmp));
memset (bmp, 0, sizeof (*bmp));
bmp->context = htonl (0xfeedface);
bmp->options[APP_OPTIONS_FLAGS] =
APP_OPTIONS_FLAGS_ACCEPT_REDIRECT | APP_OPTIONS_FLAGS_ADD_SEGMENT |
- (vcm->cfg.session_scope_local ? APP_OPTIONS_FLAGS_USE_LOCAL_SCOPE : 0) |
- (vcm->cfg.session_scope_global ? APP_OPTIONS_FLAGS_USE_GLOBAL_SCOPE : 0);
+ (vcm->cfg.app_scope_local ? APP_OPTIONS_FLAGS_USE_LOCAL_SCOPE : 0) |
+ (vcm->cfg.app_scope_global ? APP_OPTIONS_FLAGS_USE_GLOBAL_SCOPE : 0) |
+ (app_is_proxy ? APP_OPTIONS_FLAGS_IS_PROXY : 0);
+ bmp->options[APP_OPTIONS_PROXY_TRANSPORT] =
+ (vcm->cfg.app_proxy_transport_tcp ? 1 << TRANSPORT_PROTO_TCP : 0) |
+ (vcm->cfg.app_proxy_transport_udp ? 1 << TRANSPORT_PROTO_UDP : 0);
bmp->options[SESSION_OPTIONS_SEGMENT_SIZE] = vcm->cfg.segment_size;
bmp->options[SESSION_OPTIONS_ADD_SEGMENT_SIZE] = vcm->cfg.add_segment_size;
bmp->options[SESSION_OPTIONS_RX_FIFO_SIZE] = vcm->cfg.rx_fifo_size;
vl_msg_api_send_shmem (vcm->vl_input_queue, (u8 *) & cmp);
}
-static int
-vppcom_send_disconnect (u32 session_index)
+static inline void
+vppcom_send_disconnect (session_t * session)
{
vppcom_main_t *vcm = &vppcom_main;
vl_api_disconnect_session_t *dmp;
- session_t *session = 0;
- int rv;
-
- clib_spinlock_lock (&vcm->sessions_lockp);
- rv = vppcom_session_at_index (session_index, &session);
- if (PREDICT_FALSE (rv))
- {
- clib_spinlock_unlock (&vcm->sessions_lockp);
- if (VPPCOM_DEBUG > 1)
- clib_warning ("[%d] invalid session, sid (%u) has been closed!",
- vcm->my_pid, session_index);
- return rv;
- }
+ /* Assumes caller as acquired the spinlock: vcm->sessions_lockp */
dmp = vl_msg_api_alloc (sizeof (*dmp));
memset (dmp, 0, sizeof (*dmp));
dmp->_vl_msg_id = ntohs (VL_API_DISCONNECT_SESSION);
dmp->client_index = vcm->my_client_index;
dmp->handle = session->vpp_session_handle;
- clib_spinlock_unlock (&vcm->sessions_lockp);
vl_msg_api_send_shmem (vcm->vl_input_queue, (u8 *) & dmp);
- return VPPCOM_OK;
}
static void
return VPPCOM_OK;
}
-static int
+static inline int
vppcom_session_disconnect (u32 session_index)
{
vppcom_main_t *vcm = &vppcom_main;
int rv;
+ session_t *session;
- rv = vppcom_send_disconnect (session_index);
- if (PREDICT_FALSE (rv))
- return rv;
-
- rv = vppcom_wait_for_session_state_change (session_index, STATE_DISCONNECT,
- vcm->cfg.session_timeout);
+ clib_spinlock_lock (&vcm->sessions_lockp);
+ rv = vppcom_session_at_index (session_index, &session);
if (PREDICT_FALSE (rv))
{
- if (VPPCOM_DEBUG > 0)
- clib_warning ("[%d] client disconnect timed out, rv = %s (%d)",
- vcm->my_pid, vppcom_retval_str (rv), rv);
+ clib_spinlock_unlock (&vcm->sessions_lockp);
+ if (VPPCOM_DEBUG > 1)
+ clib_warning ("[%d] invalid session, sid (%u) has been closed!",
+ vcm->my_pid, session_index);
return rv;
}
+
+ if (!session->is_cut_thru)
+ {
+ vppcom_send_disconnect (session);
+ clib_spinlock_unlock (&vcm->sessions_lockp);
+
+ rv = vppcom_wait_for_session_state_change (session_index,
+ STATE_DISCONNECT, 1.0);
+ if ((VPPCOM_DEBUG > 0) && (rv < 0))
+ clib_warning ("[%d] disconnect (session %d) failed, rv = %s (%d)",
+ vcm->my_pid, session_index, vppcom_retval_str (rv), rv);
+ }
+ else
+ clib_spinlock_unlock (&vcm->sessions_lockp);
+
return VPPCOM_OK;
}
clib_warning ("[%d] configured accept_timeout %f",
vcm->my_pid, vcl_cfg->accept_timeout);
}
- else if (unformat (line_input, "session-scope-local"))
+ else if (unformat (line_input, "app-proxy-transport-tcp"))
{
- vcl_cfg->session_scope_local = 1;
+ vcl_cfg->app_proxy_transport_tcp = 1;
if (VPPCOM_DEBUG > 0)
- clib_warning ("[%d] configured session_scope_local (%d)",
- vcm->my_pid, vcl_cfg->session_scope_local);
+ clib_warning ("[%d] configured app_proxy_transport_tcp (%d)",
+ vcm->my_pid, vcl_cfg->app_proxy_transport_tcp);
}
- else if (unformat (line_input, "session-scope-global"))
+ else if (unformat (line_input, "app-proxy-transport-udp"))
{
- vcl_cfg->session_scope_global = 1;
+ vcl_cfg->app_proxy_transport_udp = 1;
if (VPPCOM_DEBUG > 0)
- clib_warning ("[%d] configured session_scope_global (%d)",
- vcm->my_pid, vcl_cfg->session_scope_global);
+ clib_warning ("[%d] configured app_proxy_transport_udp (%d)",
+ vcm->my_pid, vcl_cfg->app_proxy_transport_udp);
}
- else if (unformat (line_input, "namespace-secret 0x%lx",
- &vcl_cfg->namespace_secret))
+ else if (unformat (line_input, "app-scope-local"))
{
+ vcl_cfg->app_scope_local = 1;
if (VPPCOM_DEBUG > 0)
- clib_warning
- ("[%d] configured namespace_secret 0x%lx (%lu)",
- vcm->my_pid, vcl_cfg->namespace_secret,
- vcl_cfg->namespace_secret);
+ clib_warning ("[%d] configured app_scope_local (%d)",
+ vcm->my_pid, vcl_cfg->app_scope_local);
+ }
+ else if (unformat (line_input, "app-scope-global"))
+ {
+ vcl_cfg->app_scope_global = 1;
+ if (VPPCOM_DEBUG > 0)
+ clib_warning ("[%d] configured app_scope_global (%d)",
+ vcm->my_pid, vcl_cfg->app_scope_global);
}
else if (unformat (line_input, "namespace-secret %lu",
&vcl_cfg->namespace_secret))
vcm->cfg.namespace_secret);
}
}
- if (getenv (VPPCOM_ENV_SESSION_SCOPE_LOCAL))
+ if (getenv (VPPCOM_ENV_APP_PROXY_TRANSPORT_TCP))
+ {
+ vcm->cfg.app_proxy_transport_tcp = 1;
+ if (VPPCOM_DEBUG > 0)
+ clib_warning ("[%d] configured app_proxy_transport_tcp (%u) from "
+ VPPCOM_ENV_APP_PROXY_TRANSPORT_TCP "!", vcm->my_pid,
+ vcm->cfg.app_proxy_transport_tcp);
+ }
+ if (getenv (VPPCOM_ENV_APP_PROXY_TRANSPORT_UDP))
+ {
+ vcm->cfg.app_proxy_transport_udp = 1;
+ if (VPPCOM_DEBUG > 0)
+ clib_warning ("[%d] configured app_proxy_transport_udp (%u) from "
+ VPPCOM_ENV_APP_PROXY_TRANSPORT_UDP "!", vcm->my_pid,
+ vcm->cfg.app_proxy_transport_udp);
+ }
+ if (getenv (VPPCOM_ENV_APP_SCOPE_LOCAL))
{
- vcm->cfg.session_scope_local = 1;
+ vcm->cfg.app_scope_local = 1;
if (VPPCOM_DEBUG > 0)
- clib_warning ("[%d] configured session_scope_local (%u) from "
- VPPCOM_ENV_SESSION_SCOPE_LOCAL "!", vcm->my_pid,
- vcm->cfg.session_scope_local);
+ clib_warning ("[%d] configured app_scope_local (%u) from "
+ VPPCOM_ENV_APP_SCOPE_LOCAL "!", vcm->my_pid,
+ vcm->cfg.app_scope_local);
}
- if (getenv (VPPCOM_ENV_SESSION_SCOPE_GLOBAL))
+ if (getenv (VPPCOM_ENV_APP_SCOPE_GLOBAL))
{
- vcm->cfg.session_scope_global = 1;
+ vcm->cfg.app_scope_global = 1;
if (VPPCOM_DEBUG > 0)
- clib_warning ("[%d] configured session_scope_global (%u) from "
- VPPCOM_ENV_SESSION_SCOPE_GLOBAL "!", vcm->my_pid,
- vcm->cfg.session_scope_global);
+ clib_warning ("[%d] configured app_scope_global (%u) from "
+ VPPCOM_ENV_APP_SCOPE_GLOBAL "!", vcm->my_pid,
+ vcm->cfg.app_scope_global);
}
vcm->bind_session_index = ~0;
clib_warning ("[%d] vppcom_app_attach() failed!", vcm->my_pid);
return rv;
}
- }
- if (VPPCOM_DEBUG > 0)
- clib_warning ("[%d] app_name '%s', my_client_index %d (0x%x)",
- vcm->my_pid, app_name, vcm->my_client_index,
- vcm->my_client_index);
+ if (VPPCOM_DEBUG > 0)
+ clib_warning ("[%d] app_name '%s', my_client_index %d (0x%x)",
+ vcm->my_pid, app_name, vcm->my_client_index,
+ vcm->my_client_index);
+ }
return VPPCOM_OK;
}
vppcom_main_t *vcm = &vppcom_main;
session_t *session = 0;
int rv;
+ u8 is_server;
+ u8 is_listen;
+ u8 is_cut_thru;
+ u8 is_vep;
+ u8 is_vep_session;
+ u32 next_sid;
+ u32 vep_idx;
+ session_state_t state;
clib_spinlock_lock (&vcm->sessions_lockp);
rv = vppcom_session_at_index (session_index, &session);
clib_spinlock_unlock (&vcm->sessions_lockp);
goto done;
}
+ is_server = session->is_server;
+ is_listen = session->is_listen;
+ is_cut_thru = session->is_cut_thru;
+ is_vep = session->is_vep;
+ is_vep_session = session->is_vep_session;
+ next_sid = session->vep.next_sid;
+ vep_idx = session->vep.vep_idx;
+ state = session->state;
clib_spinlock_unlock (&vcm->sessions_lockp);
if (VPPCOM_DEBUG > 0)
clib_warning ("[%d] sid %d", vcm->my_pid, session_index);
- if (session->is_vep)
+ if (is_vep)
{
- u32 next_sid;
- for (next_sid = session->vep.next_sid; next_sid != ~0;
- next_sid = session->vep.next_sid)
+ while (next_sid != ~0)
{
rv = vppcom_epoll_ctl (session_index, EPOLL_CTL_DEL, next_sid, 0);
if ((VPPCOM_DEBUG > 0) && (rv < 0))
clib_warning ("[%d] EPOLL_CTL_DEL vep_idx %u, sid %u failed, "
- "rv = %s (%d)", session_index, next_sid,
- vcm->my_pid, session_index,
+ "rv = %s (%d)", vcm->my_pid, vep_idx, next_sid,
vppcom_retval_str (rv), rv);
clib_spinlock_lock (&vcm->sessions_lockp);
clib_spinlock_unlock (&vcm->sessions_lockp);
goto done;
}
+ next_sid = session->vep.next_sid;
clib_spinlock_unlock (&vcm->sessions_lockp);
}
}
else
{
- if (session->is_vep_session)
+ if (is_vep_session)
{
- u32 vep_idx = session->vep.vep_idx;
rv = vppcom_epoll_ctl (vep_idx, EPOLL_CTL_DEL, session_index, 0);
if ((VPPCOM_DEBUG > 0) && (rv < 0))
clib_warning ("[%d] EPOLL_CTL_DEL vep_idx %u, sid %u failed, "
- "rv = %s (%d)", vep_idx, session_index,
- vcm->my_pid, session_index,
+ "rv = %s (%d)", vcm->my_pid, vep_idx, session_index,
vppcom_retval_str (rv), rv);
-
- clib_spinlock_lock (&vcm->sessions_lockp);
- rv = vppcom_session_at_index (session_index, &session);
- if (PREDICT_FALSE (rv))
- {
- if (VPPCOM_DEBUG > 0)
- clib_warning
- ("[%d] invalid session, sid (%u) has been closed!",
- vcm->my_pid, session_index);
- clib_spinlock_unlock (&vcm->sessions_lockp);
- goto done;
- }
- clib_spinlock_unlock (&vcm->sessions_lockp);
}
- if (session->is_cut_thru && session->is_server &&
- (session->state == STATE_ACCEPT))
+ if (is_cut_thru && is_server && (state == STATE_ACCEPT))
{
rv = vppcom_session_unbind_cut_thru (session);
if ((VPPCOM_DEBUG > 0) && (rv < 0))
vcm->my_pid, session_index,
vppcom_retval_str (rv), rv);
}
- else if (session->is_server && session->is_listen)
+ else if (is_server && is_listen)
{
rv = vppcom_session_unbind (session_index);
if ((VPPCOM_DEBUG > 0) && (rv < 0))
vcm->my_pid, session_index,
vppcom_retval_str (rv), rv);
}
- else if (session->state == STATE_CONNECT)
- {
- rv = vppcom_session_disconnect (session_index);
- if ((VPPCOM_DEBUG > 0) && (rv < 0))
- clib_warning ("[%d] disconnect (session %d) failed, rv = %s (%d)",
- vcm->my_pid, session_index,
- vppcom_retval_str (rv), rv);
- }
+ else if (state == STATE_CONNECT)
+ if (vppcom_session_disconnect (session_index))
+ goto done;
}
+ clib_spinlock_lock (&vcm->sessions_lockp);
pool_put_index (vcm->sessions, session_index);
+ clib_spinlock_unlock (&vcm->sessions_lockp);
done:
return rv;
}
static inline void
vep_verify_epoll_chain (u32 vep_idx)
{
+ vppcom_main_t *vcm = &vppcom_main;
session_t *session;
vppcom_epoll_t *vep;
int rv;
rv = vppcom_session_at_index (vep_idx, &session);
if (PREDICT_FALSE (rv))
{
- clib_warning ("ERROR: Invalid vep_idx (%u)!", vep_idx);
+ clib_warning ("[%d] ERROR: Invalid vep_idx (%u)!", vcm->my_pid,
+ vep_idx);
goto done;
}
if (PREDICT_FALSE (!session->is_vep))
{
- clib_warning ("ERROR: vep_idx (%u) is not a vep!", vep_idx);
+ clib_warning ("[%d] ERROR: vep_idx (%u) is not a vep!", vcm->my_pid,
+ vep_idx);
goto done;
}
if (VPPCOM_DEBUG > 1)
- clib_warning ("vep_idx (%u): Dumping epoll chain\n"
+ clib_warning ("[%d] vep_idx (%u): Dumping epoll chain\n"
"{\n"
" is_vep = %u\n"
" is_vep_session = %u\n"
" wait_cont_idx = 0x%x (%u)\n"
- "}\n",
+ "}\n", vcm->my_pid,
vep_idx, session->is_vep, session->is_vep_session,
session->wait_cont_idx, session->wait_cont_idx);
do
rv = vppcom_session_at_index (sid, &session);
if (PREDICT_FALSE (rv))
{
- clib_warning ("ERROR: Invalid sid (%u)!", sid);
+ clib_warning ("[%d] ERROR: Invalid sid (%u)!",
+ vcm->my_pid, sid);
goto done;
}
if (PREDICT_FALSE (session->is_vep))
- clib_warning ("ERROR: sid (%u) is a vep!", vep_idx);
+ clib_warning ("[%d] ERROR: sid (%u) is a vep!",
+ vcm->my_pid, vep_idx);
else if (PREDICT_FALSE (!session->is_vep_session))
{
- clib_warning ("ERROR: session (%u) is not a vep session!", sid);
+ clib_warning ("[%d] ERROR: session (%u) is not a vep session!",
+ vcm->my_pid, sid);
goto done;
}
if (PREDICT_FALSE (session->vep.vep_idx != vep_idx))
- clib_warning ("ERROR: session (%u) vep_idx (%u) != "
- "vep_idx (%u)!",
+ clib_warning ("[%d] ERROR: session (%u) vep_idx (%u) != "
+ "vep_idx (%u)!", vcm->my_pid,
sid, session->vep.vep_idx, vep_idx);
}
}
done:
if (VPPCOM_DEBUG > 1)
- clib_warning ("vep_idx (%u): Dump complete!", vep_idx);
+ clib_warning ("[%d] vep_idx (%u): Dump complete!", vcm->my_pid, vep_idx);
}
int
clib_spinlock_unlock (&vcm->sessions_lockp);
if (VPPCOM_DEBUG > 0)
- clib_warning ("Created vep_idx %u!", vep_idx);
+ clib_warning ("[%d] Created vep_idx %u!", vcm->my_pid, vep_idx);
return (vep_idx);
}
if (vep_idx == session_index)
{
if (VPPCOM_DEBUG > 0)
- clib_warning ("ERROR: vep_idx == session_index (%u)!", vep_idx);
+ clib_warning ("[%d] ERROR: vep_idx == session_index (%u)!",
+ vcm->my_pid, vep_idx);
return VPPCOM_EINVAL;
}
if (PREDICT_FALSE (rv))
{
if (VPPCOM_DEBUG > 0)
- clib_warning ("ERROR: Invalid vep_idx (%u)!", vep_idx);
+ clib_warning ("[%d] ERROR: Invalid vep_idx (%u)!", vep_idx);
goto done;
}
if (PREDICT_FALSE (!vep_session->is_vep))
{
if (VPPCOM_DEBUG > 0)
- clib_warning ("ERROR: vep_idx (%u) is not a vep!", vep_idx);
+ clib_warning ("[%d] ERROR: vep_idx (%u) is not a vep!",
+ vcm->my_pid, vep_idx);
rv = VPPCOM_EINVAL;
goto done;
}
if (PREDICT_FALSE (rv))
{
if (VPPCOM_DEBUG > 0)
- clib_warning ("ERROR: Invalid session_index (%u)!", session_index);
+ clib_warning ("[%d] ERROR: Invalid session_index (%u)!",
+ vcm->my_pid, session_index);
goto done;
}
if (PREDICT_FALSE (session->is_vep))
case EPOLL_CTL_ADD:
if (PREDICT_FALSE (!event))
{
- clib_warning ("NULL pointer to epoll_event structure!");
+ clib_warning ("[%d] ERROR: EPOLL_CTL_ADD: NULL pointer to "
+ "epoll_event structure!", vcm->my_pid);
rv = VPPCOM_EINVAL;
goto done;
}
if (PREDICT_FALSE (rv))
{
if (VPPCOM_DEBUG > 0)
- clib_warning ("EPOLL_CTL_ADD: Invalid vep.next_sid (%u) on"
- " vep_idx (%u)!", vep_session->vep.next_sid,
+ clib_warning ("[%d] ERROR: EPOLL_CTL_ADD: Invalid "
+ "vep.next_sid (%u) on vep_idx (%u)!",
+ vcm->my_pid, vep_session->vep.next_sid,
vep_idx);
goto done;
}
session->is_vep_session = 1;
vep_session->vep.next_sid = session_index;
if (VPPCOM_DEBUG > 1)
- clib_warning ("EPOLL_CTL_ADD: vep_idx %u, sid %u, events 0x%x,"
- " data 0x%llx!", vep_idx, session_index,
+ clib_warning ("[%d] EPOLL_CTL_ADD: vep_idx %u, sid %u, events 0x%x,"
+ " data 0x%llx!", vcm->my_pid, vep_idx, session_index,
event->events, event->data.u64);
break;
case EPOLL_CTL_MOD:
if (PREDICT_FALSE (!event))
{
- clib_warning ("NULL pointer to epoll_event structure!");
+ clib_warning ("[%d] ERROR: EPOLL_CTL_MOD: NULL pointer to "
+ "epoll_event structure!", vcm->my_pid);
rv = VPPCOM_EINVAL;
goto done;
}
if (VPPCOM_DEBUG > 0)
{
if (!session->is_vep_session)
- clib_warning ("EPOLL_CTL_MOD: session (%u) is not "
- "a vep session!", session_index);
+ clib_warning ("[%d] ERROR: EPOLL_CTL_MOD: session (%u) "
+ "is not a vep session!",
+ vcm->my_pid, session_index);
else
- clib_warning ("EPOLL_CTL_MOD: session (%u) vep_idx (%u) != "
- "vep_idx (%u)!", session_index,
+ clib_warning ("[%d] ERROR: EPOLL_CTL_MOD: session (%u) "
+ "vep_idx (%u) != vep_idx (%u)!",
+ vcm->my_pid, session_index,
session->vep.vep_idx, vep_idx);
}
rv = VPPCOM_EINVAL;
session->vep.et_mask = VEP_DEFAULT_ET_MASK;
session->vep.ev = *event;
if (VPPCOM_DEBUG > 1)
- clib_warning ("EPOLL_CTL_MOD: vep_idx %u, sid %u, events 0x%x,"
- " data 0x%llx!", vep_idx, session_index,
+ clib_warning ("[%d] EPOLL_CTL_MOD: vep_idx %u, sid %u, events 0x%x,"
+ " data 0x%llx!", vcm->my_pid, vep_idx, session_index,
event->events, event->data.u64);
break;
if (VPPCOM_DEBUG > 0)
{
if (!session->is_vep_session)
- clib_warning ("EPOLL_CTL_DEL: session (%u) is not "
- "a vep session!", session_index);
+ clib_warning ("[%d] ERROR: EPOLL_CTL_DEL: session (%u) "
+ "is not a vep session!",
+ vcm->my_pid, session_index);
else
- clib_warning ("EPOLL_CTL_DEL: session (%u) vep_idx (%u) != "
- "vep_idx (%u)!", session_index,
+ clib_warning ("[%d] ERROR: EPOLL_CTL_DEL: session (%u) "
+ "vep_idx (%u) != vep_idx (%u)!",
+ vcm->my_pid, session_index,
session->vep.vep_idx, vep_idx);
}
rv = VPPCOM_EINVAL;
if (PREDICT_FALSE (rv))
{
if (VPPCOM_DEBUG > 0)
- clib_warning ("EPOLL_CTL_DEL: Invalid vep.prev_sid (%u) on"
- " sid (%u)!", session->vep.prev_sid,
+ clib_warning ("[%d] ERROR: EPOLL_CTL_DEL: Invalid "
+ "vep.prev_sid (%u) on sid (%u)!",
+ vcm->my_pid, session->vep.prev_sid,
session_index);
goto done;
}
if (PREDICT_FALSE (rv))
{
if (VPPCOM_DEBUG > 0)
- clib_warning ("EPOLL_CTL_DEL: Invalid vep.next_sid (%u) on"
- " sid (%u)!", session->vep.next_sid,
+ clib_warning ("[%d] ERROR: EPOLL_CTL_DEL: Invalid "
+ "vep.next_sid (%u) on sid (%u)!",
+ vcm->my_pid, session->vep.next_sid,
session_index);
goto done;
}
session->vep.vep_idx = ~0;
session->is_vep_session = 0;
if (VPPCOM_DEBUG > 1)
- clib_warning ("EPOLL_CTL_DEL: vep_idx %u, sid %u!", vep_idx,
- session_index);
+ clib_warning ("[%d] EPOLL_CTL_DEL: vep_idx %u, sid %u!",
+ vcm->my_pid, vep_idx, session_index);
break;
default:
- clib_warning ("Invalid operation (%d)!", op);
+ clib_warning ("[%d] ERROR: Invalid operation (%d)!", vcm->my_pid, op);
rv = VPPCOM_EINVAL;
}
clib_spinlock_unlock (&vcm->sessions_lockp); \
\
if (VPPCOM_DEBUG > 0) \
- clib_warning ("ERROR: Invalid ##I (%u)!", I); \
+ clib_warning ("[%s] ERROR: Invalid ##I (%u)!", \
+ vcm->my_pid, I); \
\
goto done; \
} \
if (PREDICT_FALSE (maxevents <= 0))
{
if (VPPCOM_DEBUG > 0)
- clib_warning ("ERROR: Invalid maxevents (%d)!", maxevents);
+ clib_warning ("[%d] ERROR: Invalid maxevents (%d)!",
+ vcm->my_pid, maxevents);
return VPPCOM_EINVAL;
}
if (PREDICT_FALSE (wait_for_time < 0))
{
if (VPPCOM_DEBUG > 0)
- clib_warning ("ERROR: Invalid wait_for_time (%f)!", wait_for_time);
+ clib_warning ("[%d] ERROR: Invalid wait_for_time (%f)!",
+ vcm->my_pid, wait_for_time);
return VPPCOM_EINVAL;
}
memset (events, 0, sizeof (*events) * maxevents);
if (PREDICT_FALSE (!is_vep))
{
if (VPPCOM_DEBUG > 0)
- clib_warning ("ERROR: vep_idx (%u) is not a vep!", vep_idx);
+ clib_warning ("[%d] ERROR: vep_idx (%u) is not a vep!",
+ vcm->my_pid, vep_idx);
rv = VPPCOM_EINVAL;
goto done;
}
if ((VPPCOM_DEBUG > 0) && (PREDICT_FALSE (vep_next_sid == ~0)))
{
- clib_warning ("WARNING: vep_idx (%u) is empty!", vep_idx);
+ clib_warning ("[%d] WARNING: vep_idx (%u) is empty!",
+ vcm->my_pid, vep_idx);
goto done;
}
if (PREDICT_FALSE (is_vep))
{
if (VPPCOM_DEBUG > 0)
- clib_warning ("ERROR: sid (%u) is a vep!", vep_idx);
+ clib_warning ("[%d] ERROR: sid (%u) is a vep!",
+ vcm->my_pid, vep_idx);
rv = VPPCOM_EINVAL;
goto done;
}
if (PREDICT_FALSE (!is_vep_session))
{
if (VPPCOM_DEBUG > 0)
- clib_warning ("EPOLL_CTL_MOD: session (%u) is not "
- "a vep session!", sid);
+ clib_warning ("[%d] ERROR: session (%u) is not "
+ "a vep session!", vcm->my_pid, sid);
rv = VPPCOM_EINVAL;
goto done;
}
if (PREDICT_FALSE (session_vep_idx != vep_idx))
{
- clib_warning ("EPOLL_CTL_MOD: session (%u) "
+ clib_warning ("[%d] ERROR: session (%u) "
"vep_idx (%u) != vep_idx (%u)!",
- sid, session->vep.vep_idx, vep_idx);
+ vcm->my_pid, sid, session->vep.vep_idx, vep_idx);
rv = VPPCOM_EINVAL;
goto done;
}
{
case VPPCOM_ATTR_GET_NREAD:
rv = vppcom_session_read_ready (session, session_index);
- if (VPPCOM_DEBUG > 0)
- clib_warning ("VPPCOM_ATTR_GET_NREAD: nread = %d", rv);
+ if (VPPCOM_DEBUG > 1)
+ clib_warning ("[%d] VPPCOM_ATTR_GET_NREAD: nread = %d",
+ vcm->my_pid, rv);
break;
{
*flags = O_RDWR | ((session->is_nonblocking) ? O_NONBLOCK : 0);
*buflen = sizeof (*flags);
- if (VPPCOM_DEBUG > 0)
- clib_warning ("VPPCOM_ATTR_GET_FLAGS: flags = 0x%08x, "
- "is_nonblocking = %u", *flags,
+ if (VPPCOM_DEBUG > 1)
+ clib_warning ("[%d] VPPCOM_ATTR_GET_FLAGS: flags = 0x%08x, "
+ "is_nonblocking = %u", vcm->my_pid, *flags,
session->is_nonblocking);
}
else
if (buffer && buflen && (*buflen >= sizeof (*flags)))
{
session->is_nonblocking = (*flags & O_NONBLOCK) ? 1 : 0;
- if (VPPCOM_DEBUG > 0)
- clib_warning ("VPPCOM_ATTR_SET_FLAGS: flags = 0x%08x, "
- "is_nonblocking = %u", *flags,
+ if (VPPCOM_DEBUG > 1)
+ clib_warning ("[%d] VPPCOM_ATTR_SET_FLAGS: flags = 0x%08x, "
+ "is_nonblocking = %u", vcm->my_pid, *flags,
session->is_nonblocking);
}
else
clib_memcpy (ep->ip, &session->peer_addr.ip46.ip6,
sizeof (ip6_address_t));
*buflen = sizeof (*ep);
- if (VPPCOM_DEBUG > 0)
- clib_warning ("VPPCOM_ATTR_GET_PEER_ADDR: sid %u is_ip4 = %u, "
- "addr = %U, port %u", session_index,
- ep->is_ip4, format_ip46_address,
+ if (VPPCOM_DEBUG > 1)
+ clib_warning ("[%d] VPPCOM_ATTR_GET_PEER_ADDR: sid %u is_ip4 = "
+ "%u, addr = %U, port %u", vcm->my_pid,
+ session_index, ep->is_ip4, format_ip46_address,
&session->peer_addr.ip46, ep->is_ip4,
clib_net_to_host_u16 (ep->port));
}
clib_memcpy (ep->ip, &session->lcl_addr.ip46.ip6,
sizeof (ip6_address_t));
*buflen = sizeof (*ep);
- if (VPPCOM_DEBUG > 0)
- clib_warning ("VPPCOM_ATTR_GET_LCL_ADDR: sid %u is_ip4 = %u, "
- "addr = %U port %d", session_index,
- ep->is_ip4, format_ip46_address,
+ if (VPPCOM_DEBUG > 1)
+ clib_warning ("[%d] VPPCOM_ATTR_GET_LCL_ADDR: sid %u is_ip4 = "
+ "%u, addr = %U port %d", vcm->my_pid,
+ session_index, ep->is_ip4, format_ip46_address,
&session->lcl_addr.ip46, ep->is_ip4,
clib_net_to_host_u16 (ep->port));
}
if (VPPCOM_DEBUG > 0)
clib_warning ("[%d] invalid session, sid (%u) has been closed!",
vcm->my_pid, session_index);
- rv = VPPCOM_EINVAL;
+ rv = VPPCOM_EBADFD;
+ clib_spinlock_unlock (&vcm->sessions_lockp);
+ goto done;
}
ep->vrf = session->vrf;
ep->is_ip4 = session->peer_addr.is_ip4;
rv = vppcom_session_peek (session_index, buffer, buflen);
else
{
- clib_warning ("Unsupport flags for recvfrom %d", flags);
+ clib_warning ("[%d] Unsupport flags for recvfrom %d",
+ vcm->my_pid, flags);
rv = VPPCOM_EAFNOSUPPORT;
}
+done:
return rv;
}
vppcom_session_sendto (uint32_t session_index, void *buffer,
uint32_t buflen, int flags, vppcom_endpt_t * ep)
{
+ vppcom_main_t *vcm = &vppcom_main;
+
+ if (!buffer)
+ return VPPCOM_EINVAL;
+
if (ep)
- // TBD
- return -1;
- else if (flags == 0)
- return (vppcom_session_write (session_index, buffer, buflen));
- else if (flags)
- // TBD check the flags and do the right thing
- return (vppcom_session_write (session_index, buffer, buflen));
-
- return -1;
+ {
+ // TBD
+ return VPPCOM_EINVAL;
+ }
+
+ if (flags)
+ {
+ // TBD check the flags and do the right thing
+ if (VPPCOM_DEBUG > 2)
+ clib_warning ("[%d] handling flags 0x%u (%d) not implemented yet.",
+ vcm->my_pid, flags, flags);
+ }
+
+ return (vppcom_session_write (session_index, buffer, buflen));
}
/*