#include <x86intrin.h>
#endif
+#include <vlibmemory/api.h>
#include <vppinfra/random.h>
#include <vppinfra/error.h>
#include <vppinfra/hash.h>
#include <vnet/bfd/bfd_debug.h>
#include <vnet/bfd/bfd_protocol.h>
#include <vnet/bfd/bfd_main.h>
+#include <vlib/log.h>
static u64
bfd_calc_echo_checksum (u32 discriminator, u64 expire_time, u32 secret)
{
u64 checksum = 0;
-#if __SSE4_2__
- checksum = _mm_crc32_u64 (0, discriminator);
- checksum = _mm_crc32_u64 (checksum, expire_time);
- checksum = _mm_crc32_u64 (checksum, secret);
+#if defined(clib_crc32c_uses_intrinsics) && !defined (__i386__)
+ checksum = crc32_u64 (0, discriminator);
+ checksum = crc32_u64 (checksum, expire_time);
+ checksum = crc32_u64 (checksum, secret);
#else
checksum = clib_xxhash (discriminator ^ expire_time ^ secret);
#endif
}
static u64
-bfd_usec_to_clocks (const bfd_main_t * bm, u64 us)
+bfd_usec_to_nsec (u64 us)
{
- return bm->cpu_cps * ((f64) us / USEC_PER_SECOND);
+ return us * NSEC_PER_USEC;
}
u32
-bfd_clocks_to_usec (const bfd_main_t * bm, u64 clocks)
+bfd_nsec_to_usec (u64 nsec)
{
- return (clocks / bm->cpu_cps) * USEC_PER_SECOND;
+ return nsec / NSEC_PER_USEC;
}
-static vlib_node_registration_t bfd_process_node;
+always_inline u64
+bfd_time_now_nsec (vlib_main_t * vm, f64 * vm_time)
+{
+ f64 _vm_time = vlib_time_now (vm);
+ if (vm_time)
+ *vm_time = _vm_time;
+ return _vm_time * NSEC_PER_SEC;
+}
-/* set to 0 here, real values filled at startup */
-static u32 bfd_node_index_by_transport[] = {
-#define F(t, n) [BFD_TRANSPORT_##t] = 0,
- foreach_bfd_transport (F)
-#undef F
-};
+static vlib_node_registration_t bfd_process_node;
u8 *
format_bfd_auth_key (u8 * s, va_list * args)
bs->local_diag = BFD_DIAG_CODE_no_diag;
bs->remote_state = BFD_STATE_down;
bs->remote_discr = 0;
+ bs->hop_type = BFD_HOP_TYPE_SINGLE;
bs->config_desired_min_tx_usec = BFD_DEFAULT_DESIRED_MIN_TX_USEC;
- bs->config_desired_min_tx_clocks = bm->default_desired_min_tx_clocks;
- bs->effective_desired_min_tx_clocks = bm->default_desired_min_tx_clocks;
+ bs->config_desired_min_tx_nsec = bm->default_desired_min_tx_nsec;
+ bs->effective_desired_min_tx_nsec = bm->default_desired_min_tx_nsec;
bs->remote_min_rx_usec = 1;
- bs->remote_min_rx_clocks = bfd_usec_to_clocks (bm, bs->remote_min_rx_usec);
+ bs->remote_min_rx_nsec = bfd_usec_to_nsec (bs->remote_min_rx_usec);
bs->remote_min_echo_rx_usec = 0;
- bs->remote_min_echo_rx_clocks = 0;
+ bs->remote_min_echo_rx_nsec = 0;
bs->remote_demand = 0;
bs->auth.remote_seq_number = 0;
bs->auth.remote_seq_number_known = 0;
}
static void
-bfd_set_state (bfd_main_t * bm, bfd_session_t * bs,
+bfd_set_state (vlib_main_t * vm, bfd_main_t * bm, bfd_session_t * bs,
bfd_state_e new_state, int handling_wakeup)
{
if (bs->local_state != new_state)
bfd_state_string (bs->local_state),
bfd_state_string (new_state));
bs->local_state = new_state;
- bfd_on_state_change (bm, bs, clib_cpu_time_now (), handling_wakeup);
+ bfd_on_state_change (bm, bs, bfd_time_now_nsec (vm, NULL),
+ handling_wakeup);
}
}
static void
bfd_recalc_tx_interval (bfd_main_t * bm, bfd_session_t * bs)
{
- bs->transmit_interval_clocks =
- clib_max (bs->effective_desired_min_tx_clocks, bs->remote_min_rx_clocks);
+ bs->transmit_interval_nsec =
+ clib_max (bs->effective_desired_min_tx_nsec, bs->remote_min_rx_nsec);
BFD_DBG ("Recalculated transmit interval " BFD_CLK_FMT,
- BFD_CLK_PRN (bs->transmit_interval_clocks));
+ BFD_CLK_PRN (bs->transmit_interval_nsec));
}
static void
bfd_recalc_echo_tx_interval (bfd_main_t * bm, bfd_session_t * bs)
{
- bs->echo_transmit_interval_clocks =
- clib_max (bs->effective_desired_min_tx_clocks,
- bs->remote_min_echo_rx_clocks);
+ bs->echo_transmit_interval_nsec =
+ clib_max (bs->effective_desired_min_tx_nsec, bs->remote_min_echo_rx_nsec);
BFD_DBG ("Recalculated echo transmit interval " BFD_CLK_FMT,
- BFD_CLK_PRN (bs->echo_transmit_interval_clocks));
+ BFD_CLK_PRN (bs->echo_transmit_interval_nsec));
}
static void
if (bs->local_detect_mult > 1)
{
/* common case - 75-100% of transmit interval */
- bs->tx_timeout_clocks = bs->last_tx_clocks +
+ bs->tx_timeout_nsec = bs->last_tx_nsec +
(1 - .25 * (random_f64 (&bm->random_seed))) *
- bs->transmit_interval_clocks;
- if (bs->tx_timeout_clocks < now)
+ bs->transmit_interval_nsec;
+ if (bs->tx_timeout_nsec < now)
{
/*
* the timeout is in the past, which means that either remote
*/
BFD_DBG ("Missed %lu transmit events (now is %lu, calc "
"tx_timeout is %lu)",
- (now - bs->tx_timeout_clocks) /
- bs->transmit_interval_clocks, now, bs->tx_timeout_clocks);
- bs->tx_timeout_clocks = now;
+ (now - bs->tx_timeout_nsec) /
+ bs->transmit_interval_nsec, now, bs->tx_timeout_nsec);
+ bs->tx_timeout_nsec = now;
}
}
else
{
/* special case - 75-90% of transmit interval */
- bs->tx_timeout_clocks = bs->last_tx_clocks +
+ bs->tx_timeout_nsec = bs->last_tx_nsec +
(.9 - .15 * (random_f64 (&bm->random_seed))) *
- bs->transmit_interval_clocks;
- if (bs->tx_timeout_clocks < now)
+ bs->transmit_interval_nsec;
+ if (bs->tx_timeout_nsec < now)
{
/*
* the timeout is in the past, which means that either remote
*/
BFD_DBG ("Missed %lu transmit events (now is %lu, calc "
"tx_timeout is %lu)",
- (now - bs->tx_timeout_clocks) /
- bs->transmit_interval_clocks, now, bs->tx_timeout_clocks);
- bs->tx_timeout_clocks = now;
+ (now - bs->tx_timeout_nsec) /
+ bs->transmit_interval_nsec, now, bs->tx_timeout_nsec);
+ bs->tx_timeout_nsec = now;
}
}
- if (bs->tx_timeout_clocks)
+ if (bs->tx_timeout_nsec)
{
- BFD_DBG ("Next transmit in %lu clocks/%.02fs@%lu",
- bs->tx_timeout_clocks - now,
- (bs->tx_timeout_clocks - now) / bm->cpu_cps,
- bs->tx_timeout_clocks);
+ BFD_DBG ("Next transmit in %lu nsec/%.02fs@%lu",
+ bs->tx_timeout_nsec - now,
+ (bs->tx_timeout_nsec - now) * SEC_PER_NSEC,
+ bs->tx_timeout_nsec);
}
}
static void
bfd_calc_next_echo_tx (bfd_main_t * bm, bfd_session_t * bs, u64 now)
{
- bs->echo_tx_timeout_clocks =
- bs->echo_last_tx_clocks + bs->echo_transmit_interval_clocks;
- if (bs->echo_tx_timeout_clocks < now)
+ bs->echo_tx_timeout_nsec =
+ bs->echo_last_tx_nsec + bs->echo_transmit_interval_nsec;
+ if (bs->echo_tx_timeout_nsec < now)
{
/* huh, we've missed it already, transmit now */
BFD_DBG ("Missed %lu echo transmit events (now is %lu, calc tx_timeout "
"is %lu)",
- (now - bs->echo_tx_timeout_clocks) /
- bs->echo_transmit_interval_clocks,
- now, bs->echo_tx_timeout_clocks);
- bs->echo_tx_timeout_clocks = now;
- }
- BFD_DBG ("Next echo transmit in %lu clocks/%.02fs@%lu",
- bs->echo_tx_timeout_clocks - now,
- (bs->echo_tx_timeout_clocks - now) / bm->cpu_cps,
- bs->echo_tx_timeout_clocks);
+ (now - bs->echo_tx_timeout_nsec) /
+ bs->echo_transmit_interval_nsec,
+ now, bs->echo_tx_timeout_nsec);
+ bs->echo_tx_timeout_nsec = now;
+ }
+ BFD_DBG ("Next echo transmit in %lu nsec/%.02fs@%lu",
+ bs->echo_tx_timeout_nsec - now,
+ (bs->echo_tx_timeout_nsec - now) * SEC_PER_NSEC,
+ bs->echo_tx_timeout_nsec);
}
static void
{
if (bs->local_state == BFD_STATE_init || bs->local_state == BFD_STATE_up)
{
- bs->detection_time_clocks =
+ bs->detection_time_nsec =
bs->remote_detect_mult *
- clib_max (bs->effective_required_min_rx_clocks,
- bs->remote_desired_min_tx_clocks);
- BFD_DBG ("Recalculated detection time %lu clocks/%.2fs",
- bs->detection_time_clocks,
- bs->detection_time_clocks / bm->cpu_cps);
+ clib_max (bs->effective_required_min_rx_nsec,
+ bs->remote_desired_min_tx_nsec);
+ BFD_DBG ("Recalculated detection time %lu nsec/%.3fs",
+ bs->detection_time_nsec,
+ bs->detection_time_nsec * SEC_PER_NSEC);
}
}
u64 tx_timeout = 0;
if (BFD_STATE_up == bs->local_state)
{
- rx_timeout = bs->last_rx_clocks + bs->detection_time_clocks;
+ rx_timeout = bs->last_rx_nsec + bs->detection_time_nsec;
}
if (BFD_STATE_up != bs->local_state ||
(!bs->remote_demand && bs->remote_min_rx_usec) ||
BFD_POLL_NOT_NEEDED != bs->poll_state)
{
- tx_timeout = bs->tx_timeout_clocks;
+ tx_timeout = bs->tx_timeout_nsec;
}
if (tx_timeout && rx_timeout)
{
{
next = rx_timeout;
}
- if (bs->echo && next > bs->echo_tx_timeout_clocks)
+ if (bs->echo && next > bs->echo_tx_timeout_nsec)
{
- next = bs->echo_tx_timeout_clocks;
+ next = bs->echo_tx_timeout_nsec;
}
BFD_DBG ("bs_idx=%u, tx_timeout=%lu, echo_tx_timeout=%lu, rx_timeout=%lu, "
"next=%s",
- bs->bs_idx, tx_timeout, bs->echo_tx_timeout_clocks, rx_timeout,
+ bs->bs_idx, tx_timeout, bs->echo_tx_timeout_nsec, rx_timeout,
next == tx_timeout
- ? "tx" : (next == bs->echo_tx_timeout_clocks ? "echo tx" : "rx"));
- /* sometimes the wheel expires an event a bit sooner than requested, account
- for that here */
- if (next && (now + bm->wheel_inaccuracy > bs->wheel_time_clocks ||
- next < bs->wheel_time_clocks || !bs->wheel_time_clocks))
- {
- bs->wheel_time_clocks = next;
- BFD_DBG ("timing_wheel_insert(%p, %lu (%ld clocks/%.2fs in the "
- "future), %u);",
- &bm->wheel, bs->wheel_time_clocks,
- (i64) bs->wheel_time_clocks - clib_cpu_time_now (),
- (i64) (bs->wheel_time_clocks - clib_cpu_time_now ()) /
- bm->cpu_cps, bs->bs_idx);
- timing_wheel_insert (&bm->wheel, bs->wheel_time_clocks, bs->bs_idx);
+ ? "tx" : (next == bs->echo_tx_timeout_nsec ? "echo tx" : "rx"));
+ if (next)
+ {
+ int send_signal = 0;
+ bs->event_time_nsec = next;
+ /* add extra tick if it's not even */
+ u32 wheel_time_ticks =
+ (bs->event_time_nsec - now) / bm->nsec_per_tw_tick +
+ ((bs->event_time_nsec - now) % bm->nsec_per_tw_tick != 0);
+ BFD_DBG ("event_time_nsec %lu (%lu nsec/%.3fs in future) -> "
+ "wheel_time_ticks %u", bs->event_time_nsec,
+ bs->event_time_nsec - now,
+ (bs->event_time_nsec - now) * SEC_PER_NSEC, wheel_time_ticks);
+ bfd_lock (bm);
+ if (bs->tw_id)
+ {
+ TW (tw_timer_update) (&bm->wheel, bs->tw_id, wheel_time_ticks);
+ BFD_DBG ("tw_timer_update(%p, %u, %lu);", &bm->wheel, bs->tw_id,
+ wheel_time_ticks);
+ }
+ else
+ {
+ bs->tw_id =
+ TW (tw_timer_start) (&bm->wheel, bs->bs_idx, 0, wheel_time_ticks);
+ BFD_DBG ("tw_timer_start(%p, %u, 0, %lu) == %u;", &bm->wheel,
+ bs->bs_idx, wheel_time_ticks);
+ }
+
if (!handling_wakeup)
{
- vlib_process_signal_event (bm->vlib_main,
- bm->bfd_process_node_index,
- BFD_EVENT_RESCHEDULE, bs->bs_idx);
+
+ /* Send only if it is earlier than current awaited wakeup time */
+ send_signal =
+ (bs->event_time_nsec < bm->bfd_process_next_wakeup_nsec) &&
+ /*
+ * If the wake-up time is within 2x the delay of the event propagation delay,
+ * avoid the expense of sending the event. The 2x multiplier is to workaround the race whereby
+ * simultaneous event + expired timer create one recurring bogus wakeup/suspend instance,
+ * due to double scheduling of the node on the pending list.
+ */
+ (bm->bfd_process_next_wakeup_nsec - bs->event_time_nsec >
+ 2 * bm->bfd_process_wakeup_event_delay_nsec) &&
+ /* Must be no events in flight to send an event */
+ (!bm->bfd_process_wakeup_events_in_flight);
+
+ /* If we do send the signal, note this down along with the start timestamp */
+ if (send_signal)
+ {
+ bm->bfd_process_wakeup_events_in_flight++;
+ bm->bfd_process_wakeup_event_start_nsec = now;
+ }
+ }
+ bfd_unlock (bm);
+
+ /* Use the multithreaded event sending so the workers can send events too */
+ if (send_signal)
+ {
+ vlib_process_signal_event_mt (bm->vlib_main,
+ bm->bfd_process_node_index,
+ BFD_EVENT_RESCHEDULE, ~0);
}
}
}
static void
bfd_set_effective_desired_min_tx (bfd_main_t * bm,
bfd_session_t * bs, u64 now,
- u64 desired_min_tx_clocks)
+ u64 desired_min_tx_nsec)
{
- bs->effective_desired_min_tx_clocks = desired_min_tx_clocks;
+ bs->effective_desired_min_tx_nsec = desired_min_tx_nsec;
BFD_DBG ("Set effective desired min tx to " BFD_CLK_FMT,
- BFD_CLK_PRN (bs->effective_desired_min_tx_clocks));
+ BFD_CLK_PRN (bs->effective_desired_min_tx_nsec));
bfd_recalc_detection_time (bm, bs);
bfd_recalc_tx_interval (bm, bs);
bfd_recalc_echo_tx_interval (bm, bs);
static void
bfd_set_effective_required_min_rx (bfd_main_t * bm,
bfd_session_t * bs,
- u64 required_min_rx_clocks)
+ u64 required_min_rx_nsec)
{
- bs->effective_required_min_rx_clocks = required_min_rx_clocks;
+ bs->effective_required_min_rx_nsec = required_min_rx_nsec;
BFD_DBG ("Set effective required min rx to " BFD_CLK_FMT,
- BFD_CLK_PRN (bs->effective_required_min_rx_clocks));
+ BFD_CLK_PRN (bs->effective_required_min_rx_nsec));
bfd_recalc_detection_time (bm, bs);
}
if (bs->remote_min_rx_usec != remote_required_min_rx_usec)
{
bs->remote_min_rx_usec = remote_required_min_rx_usec;
- bs->remote_min_rx_clocks =
- bfd_usec_to_clocks (bm, remote_required_min_rx_usec);
+ bs->remote_min_rx_nsec = bfd_usec_to_nsec (remote_required_min_rx_usec);
BFD_DBG ("Set remote min rx to " BFD_CLK_FMT,
- BFD_CLK_PRN (bs->remote_min_rx_clocks));
+ BFD_CLK_PRN (bs->remote_min_rx_nsec));
bfd_recalc_detection_time (bm, bs);
bfd_recalc_tx_interval (bm, bs);
}
if (bs->remote_min_echo_rx_usec != remote_required_min_echo_rx_usec)
{
bs->remote_min_echo_rx_usec = remote_required_min_echo_rx_usec;
- bs->remote_min_echo_rx_clocks =
- bfd_usec_to_clocks (bm, bs->remote_min_echo_rx_usec);
+ bs->remote_min_echo_rx_nsec =
+ bfd_usec_to_nsec (bs->remote_min_echo_rx_usec);
BFD_DBG ("Set remote min echo rx to " BFD_CLK_FMT,
- BFD_CLK_PRN (bs->remote_min_echo_rx_clocks));
+ BFD_CLK_PRN (bs->remote_min_echo_rx_nsec));
bfd_recalc_echo_tx_interval (bm, bs);
}
}
+static void
+bfd_notify_listeners (bfd_main_t * bm,
+ bfd_listen_event_e event, const bfd_session_t * bs)
+{
+ bfd_notify_fn_t *fn;
+ vec_foreach (fn, bm->listeners)
+ {
+ (*fn) (event, bs);
+ }
+}
+
void
bfd_session_start (bfd_main_t * bm, bfd_session_t * bs)
{
BFD_DBG ("\nStarting session: %U", format_bfd_session, bs);
- bfd_set_effective_required_min_rx (bm, bs,
- bs->config_required_min_rx_clocks);
+ vlib_log_info (bm->log_class, "start BFD session: %U",
+ format_bfd_session_brief, bs);
+ bfd_set_effective_required_min_rx (bm, bs, bs->config_required_min_rx_nsec);
bfd_recalc_tx_interval (bm, bs);
vlib_process_signal_event (bm->vlib_main, bm->bfd_process_node_index,
BFD_EVENT_NEW_SESSION, bs->bs_idx);
+ bfd_notify_listeners (bm, BFD_LISTEN_EVENT_CREATE, bs);
}
void
-bfd_session_set_flags (bfd_session_t * bs, u8 admin_up_down)
+bfd_session_set_flags (vlib_main_t * vm, bfd_session_t * bs, u8 admin_up_down)
{
bfd_main_t *bm = &bfd_main;
- u64 now = clib_cpu_time_now ();
+ u64 now = bfd_time_now_nsec (vm, NULL);
if (admin_up_down)
{
BFD_DBG ("Session set admin-up, bs-idx=%u", bs->bs_idx);
- bfd_set_state (bm, bs, BFD_STATE_down, 0);
+ vlib_log_info (bm->log_class, "set session admin-up: %U",
+ format_bfd_session_brief, bs);
+ bfd_set_state (vm, bm, bs, BFD_STATE_down, 0);
bfd_set_diag (bs, BFD_DIAG_CODE_no_diag);
bfd_calc_next_tx (bm, bs, now);
bfd_set_timer (bm, bs, now, 0);
else
{
BFD_DBG ("Session set admin-down, bs-idx=%u", bs->bs_idx);
+ vlib_log_info (bm->log_class, "set session admin-down: %U",
+ format_bfd_session_brief, bs);
bfd_set_diag (bs, BFD_DIAG_CODE_admin_down);
- bfd_set_state (bm, bs, BFD_STATE_admin_down, 0);
+ bfd_set_state (vm, bm, bs, BFD_STATE_admin_down, 0);
bfd_calc_next_tx (bm, bs, now);
bfd_set_timer (bm, bs, now, 0);
}
return s;
}
+typedef struct
+{
+ u32 bs_idx;
+} bfd_rpc_event_t;
+
+static void
+bfd_rpc_event_cb (const bfd_rpc_event_t * a)
+{
+ bfd_main_t *bm = &bfd_main;
+ u32 bs_idx = a->bs_idx;
+ u32 valid_bs = 0;
+ bfd_session_t session_data;
+
+ bfd_lock (bm);
+ if (!pool_is_free_index (bm->sessions, bs_idx))
+ {
+ bfd_session_t *bs = pool_elt_at_index (bm->sessions, bs_idx);
+ clib_memcpy (&session_data, bs, sizeof (bfd_session_t));
+ valid_bs = 1;
+ }
+ else
+ {
+ BFD_DBG ("Ignoring event RPC for non-existent session index %u",
+ bs_idx);
+ }
+ bfd_unlock (bm);
+
+ if (valid_bs)
+ bfd_event (bm, &session_data);
+}
+
+static void
+bfd_event_rpc (u32 bs_idx)
+{
+ const u32 data_size = sizeof (bfd_rpc_event_t);
+ u8 data[data_size];
+ bfd_rpc_event_t *event = (bfd_rpc_event_t *) data;
+
+ event->bs_idx = bs_idx;
+ vl_api_rpc_call_main_thread (bfd_rpc_event_cb, data, data_size);
+}
+
+typedef struct
+{
+ u32 bs_idx;
+} bfd_rpc_notify_listeners_t;
+
+static void
+bfd_rpc_notify_listeners_cb (const bfd_rpc_notify_listeners_t * a)
+{
+ bfd_main_t *bm = &bfd_main;
+ u32 bs_idx = a->bs_idx;
+ bfd_lock (bm);
+ if (!pool_is_free_index (bm->sessions, bs_idx))
+ {
+ bfd_session_t *bs = pool_elt_at_index (bm->sessions, bs_idx);
+ bfd_notify_listeners (bm, BFD_LISTEN_EVENT_UPDATE, bs);
+ }
+ else
+ {
+ BFD_DBG ("Ignoring notify RPC for non-existent session index %u",
+ bs_idx);
+ }
+ bfd_unlock (bm);
+}
+
+static void
+bfd_notify_listeners_rpc (u32 bs_idx)
+{
+ const u32 data_size = sizeof (bfd_rpc_notify_listeners_t);
+ u8 data[data_size];
+ bfd_rpc_notify_listeners_t *notify = (bfd_rpc_notify_listeners_t *) data;
+ notify->bs_idx = bs_idx;
+ vl_api_rpc_call_main_thread (bfd_rpc_notify_listeners_cb, data, data_size);
+}
+
static void
bfd_on_state_change (bfd_main_t * bm, bfd_session_t * bs, u64 now,
int handling_wakeup)
{
BFD_DBG ("\nState changed: %U", format_bfd_session, bs);
- bfd_event (bm, bs);
+
+ if (vlib_get_thread_index () == 0)
+ {
+ bfd_event (bm, bs);
+ }
+ else
+ {
+ /* without RPC - a REGRESSION: BFD event are not propagated */
+ bfd_event_rpc (bs->bs_idx);
+ }
+
switch (bs->local_state)
{
case BFD_STATE_admin_down:
bs->echo = 0;
bfd_set_effective_desired_min_tx (bm, bs, now,
clib_max
- (bs->config_desired_min_tx_clocks,
- bm->default_desired_min_tx_clocks));
+ (bs->config_desired_min_tx_nsec,
+ bm->default_desired_min_tx_nsec));
bfd_set_effective_required_min_rx (bm, bs,
- bs->config_required_min_rx_clocks);
+ bs->config_required_min_rx_nsec);
bfd_set_timer (bm, bs, now, handling_wakeup);
break;
case BFD_STATE_down:
bs->echo = 0;
bfd_set_effective_desired_min_tx (bm, bs, now,
clib_max
- (bs->config_desired_min_tx_clocks,
- bm->default_desired_min_tx_clocks));
+ (bs->config_desired_min_tx_nsec,
+ bm->default_desired_min_tx_nsec));
bfd_set_effective_required_min_rx (bm, bs,
- bs->config_required_min_rx_clocks);
+ bs->config_required_min_rx_nsec);
bfd_set_timer (bm, bs, now, handling_wakeup);
break;
case BFD_STATE_init:
bs->echo = 0;
bfd_set_effective_desired_min_tx (bm, bs, now,
- bs->config_desired_min_tx_clocks);
+ bs->config_desired_min_tx_nsec);
bfd_set_timer (bm, bs, now, handling_wakeup);
break;
case BFD_STATE_up:
bfd_set_effective_desired_min_tx (bm, bs, now,
- bs->config_desired_min_tx_clocks);
+ bs->config_desired_min_tx_nsec);
if (BFD_POLL_NOT_NEEDED == bs->poll_state)
{
bfd_set_effective_required_min_rx (bm, bs,
- bs->config_required_min_rx_clocks);
+ bs->config_required_min_rx_nsec);
}
bfd_set_timer (bm, bs, now, handling_wakeup);
break;
}
+ if (vlib_get_thread_index () == 0)
+ {
+ bfd_notify_listeners (bm, BFD_LISTEN_EVENT_UPDATE, bs);
+ }
+ else
+ {
+ /* without RPC - a REGRESSION: state changes are not propagated */
+ bfd_notify_listeners_rpc (bs->bs_idx);
+ }
}
static void
* timeout so that the session wakes up immediately
*/
if (bs->remote_demand && BFD_POLL_NEEDED == bs->poll_state &&
- bs->poll_state_start_or_timeout_clocks < now)
+ bs->poll_state_start_or_timeout_nsec < now)
{
- bs->tx_timeout_clocks = now;
+ bs->tx_timeout_nsec = now;
}
bfd_recalc_detection_time (bm, bs);
bfd_set_timer (bm, bs, now, 0);
}
static void
-bfd_add_transport_layer (vlib_main_t * vm, vlib_buffer_t * b,
- bfd_session_t * bs)
+bfd_add_transport_layer (vlib_main_t * vm, u32 bi, bfd_session_t * bs)
+{
+ switch (bs->transport)
+ {
+ case BFD_TRANSPORT_UDP4:
+ BFD_DBG ("Transport bfd via udp4, bs_idx=%u", bs->bs_idx);
+ bfd_add_udp4_transport (vm, bi, bs, 0 /* is_echo */ );
+ break;
+ case BFD_TRANSPORT_UDP6:
+ BFD_DBG ("Transport bfd via udp6, bs_idx=%u", bs->bs_idx);
+ bfd_add_udp6_transport (vm, bi, bs, 0 /* is_echo */ );
+ break;
+ }
+}
+
+static int
+bfd_transport_control_frame (vlib_main_t * vm, u32 bi, bfd_session_t * bs)
{
switch (bs->transport)
{
case BFD_TRANSPORT_UDP4:
BFD_DBG ("Transport bfd via udp4, bs_idx=%u", bs->bs_idx);
- bfd_add_udp4_transport (vm, b, bs, 0 /* is_echo */ );
+ return bfd_transport_udp4 (vm, bi, bs);
break;
case BFD_TRANSPORT_UDP6:
BFD_DBG ("Transport bfd via udp6, bs_idx=%u", bs->bs_idx);
- bfd_add_udp6_transport (vm, b, bs, 0 /* is_echo */ );
+ return bfd_transport_udp6 (vm, bi, bs);
break;
}
+ return 0;
}
static int
-bfd_echo_add_transport_layer (vlib_main_t * vm, vlib_buffer_t * b,
- bfd_session_t * bs)
+bfd_echo_add_transport_layer (vlib_main_t * vm, u32 bi, bfd_session_t * bs)
{
switch (bs->transport)
{
case BFD_TRANSPORT_UDP4:
BFD_DBG ("Transport bfd echo via udp4, bs_idx=%u", bs->bs_idx);
- return bfd_add_udp4_transport (vm, b, bs, 1 /* is_echo */ );
+ return bfd_add_udp4_transport (vm, bi, bs, 1 /* is_echo */ );
break;
case BFD_TRANSPORT_UDP6:
BFD_DBG ("Transport bfd echo via udp6, bs_idx=%u", bs->bs_idx);
- return bfd_add_udp6_transport (vm, b, bs, 1 /* is_echo */ );
+ return bfd_add_udp6_transport (vm, bi, bs, 1 /* is_echo */ );
break;
}
return 0;
}
-static void
-bfd_create_frame_to_next_node (vlib_main_t * vm, bfd_session_t * bs, u32 bi)
+static int
+bfd_transport_echo (vlib_main_t * vm, u32 bi, bfd_session_t * bs)
{
-
- vlib_frame_t *f =
- vlib_get_frame_to_node (vm, bfd_node_index_by_transport[bs->transport]);
-
- u32 *to_next = vlib_frame_vector_args (f);
- to_next[0] = bi;
- f->n_vectors = 1;
- vlib_put_frame_to_node (vm, bfd_node_index_by_transport[bs->transport], f);
+ switch (bs->transport)
+ {
+ case BFD_TRANSPORT_UDP4:
+ BFD_DBG ("Transport bfd echo via udp4, bs_idx=%u", bs->bs_idx);
+ return bfd_transport_udp4 (vm, bi, bs);
+ break;
+ case BFD_TRANSPORT_UDP6:
+ BFD_DBG ("Transport bfd echo via udp6, bs_idx=%u", bs->bs_idx);
+ return bfd_transport_udp6 (vm, bi, bs);
+ break;
+ }
+ return 0;
}
#if WITH_LIBSSL > 0
b->current_length += sizeof (*auth);
pkt->pkt.head.length += sizeof (*auth);
bfd_pkt_set_auth_present (&pkt->pkt);
- memset (auth, 0, sizeof (*auth));
+ clib_memset (auth, 0, sizeof (*auth));
auth->type_len.type = bs->auth.curr_key->auth_type;
/*
* only meticulous authentication types require incrementing seq number
static void
bfd_add_auth_section (vlib_buffer_t * b, bfd_session_t * bs)
{
+ bfd_main_t *bm = &bfd_main;
if (bs->auth.curr_key)
{
const bfd_auth_type_e auth_type = bs->auth.curr_key->auth_type;
case BFD_AUTH_TYPE_keyed_md5:
/* fallthrough */
case BFD_AUTH_TYPE_meticulous_keyed_md5:
- clib_warning ("Internal error, unexpected BFD auth type '%d'",
- auth_type);
+ vlib_log_crit (bm->log_class,
+ "internal error, unexpected BFD auth type '%d'",
+ auth_type);
break;
#if WITH_LIBSSL > 0
case BFD_AUTH_TYPE_keyed_sha1:
case BFD_AUTH_TYPE_keyed_sha1:
/* fallthrough */
case BFD_AUTH_TYPE_meticulous_keyed_sha1:
- clib_warning ("Internal error, unexpected BFD auth type '%d'",
- auth_type);
+ vlib_log_crit (bm->log_class,
+ "internal error, unexpected BFD auth type '%d'",
+ auth_type);
break;
#endif
}
bfd_pkt_t *pkt = vlib_buffer_get_current (b);
u32 bfd_length = 0;
bfd_length = sizeof (bfd_pkt_t);
- memset (pkt, 0, sizeof (*pkt));
+ clib_memset (pkt, 0, sizeof (*pkt));
bfd_pkt_set_version (pkt, 1);
bfd_pkt_set_diag_code (pkt, bs->local_diag);
bfd_pkt_set_state (pkt, bs->local_state);
pkt->head.detect_mult = bs->local_detect_mult;
- pkt->head.length = clib_host_to_net_u32 (bfd_length);
+ pkt->head.length = bfd_length;
pkt->my_disc = bs->local_discr;
pkt->your_disc = bs->remote_discr;
pkt->des_min_tx = clib_host_to_net_u32 (bs->config_desired_min_tx_usec);
if (bs->echo)
{
pkt->req_min_rx =
- clib_host_to_net_u32 (bfd_clocks_to_usec
- (bm, bs->effective_required_min_rx_clocks));
+ clib_host_to_net_u32 (bfd_nsec_to_usec
+ (bs->effective_required_min_rx_nsec));
}
else
{
static void
bfd_send_echo (vlib_main_t * vm, vlib_node_runtime_t * rt,
- bfd_main_t * bm, bfd_session_t * bs, u64 now,
- int handling_wakeup)
+ bfd_main_t * bm, bfd_session_t * bs, u64 now)
{
if (!bfd_is_echo_possible (bs))
{
bs->echo = 0;
return;
}
- /* sometimes the wheel expires an event a bit sooner than requested, account
- for that here */
- if (now + bm->wheel_inaccuracy >= bs->echo_tx_timeout_clocks)
+ if (now >= bs->echo_tx_timeout_nsec)
{
BFD_DBG ("\nSending echo packet: %U", format_bfd_session, bs);
u32 bi;
if (vlib_buffer_alloc (vm, &bi, 1) != 1)
{
- clib_warning ("buffer allocation failure");
+ vlib_log_crit (bm->log_class, "buffer allocation failure");
return;
}
vlib_buffer_t *b = vlib_get_buffer (vm, bi);
ASSERT (b->current_data == 0);
+ VLIB_BUFFER_TRACE_TRAJECTORY_INIT (b);
bfd_echo_pkt_t *pkt = vlib_buffer_get_current (b);
- memset (pkt, 0, sizeof (*pkt));
+ clib_memset (pkt, 0, sizeof (*pkt));
pkt->discriminator = bs->local_discr;
- pkt->expire_time_clocks =
- now + bs->echo_transmit_interval_clocks * bs->local_detect_mult;
+ pkt->expire_time_nsec =
+ now + bs->echo_transmit_interval_nsec * bs->local_detect_mult;
pkt->checksum =
- bfd_calc_echo_checksum (bs->local_discr, pkt->expire_time_clocks,
+ bfd_calc_echo_checksum (bs->local_discr, pkt->expire_time_nsec,
bs->echo_secret);
b->current_length = sizeof (*pkt);
- if (!bfd_echo_add_transport_layer (vm, b, bs))
+ if (!bfd_echo_add_transport_layer (vm, bi, bs))
+ {
+ BFD_ERR ("cannot send echo packet out, turning echo off");
+ bs->echo = 0;
+ vlib_buffer_free_one (vm, bi);
+ return;
+ }
+ if (!bfd_transport_echo (vm, bi, bs))
{
BFD_ERR ("cannot send echo packet out, turning echo off");
bs->echo = 0;
vlib_buffer_free_one (vm, bi);
return;
}
- bs->echo_last_tx_clocks = now;
+ bs->echo_last_tx_nsec = now;
bfd_calc_next_echo_tx (bm, bs, now);
- bfd_create_frame_to_next_node (vm, bs, bi);
}
else
{
BFD_DBG
("No need to send echo packet now, now is %lu, tx_timeout is %lu",
- now, bs->echo_tx_timeout_clocks);
+ now, bs->echo_tx_timeout_nsec);
}
}
static void
bfd_send_periodic (vlib_main_t * vm, vlib_node_runtime_t * rt,
- bfd_main_t * bm, bfd_session_t * bs, u64 now,
- int handling_wakeup)
+ bfd_main_t * bm, bfd_session_t * bs, u64 now)
{
if (!bs->remote_min_rx_usec && BFD_POLL_NOT_NEEDED == bs->poll_state)
{
BFD_DBG ("Remote demand is set, not sending periodic control frame");
return;
}
- /* sometimes the wheel expires an event a bit sooner than requested, account
- for that here */
- if (now + bm->wheel_inaccuracy >= bs->tx_timeout_clocks)
+ if (now >= bs->tx_timeout_nsec)
{
BFD_DBG ("\nSending periodic control frame: %U", format_bfd_session,
bs);
u32 bi;
if (vlib_buffer_alloc (vm, &bi, 1) != 1)
{
- clib_warning ("buffer allocation failure");
+ vlib_log_crit (bm->log_class, "buffer allocation failure");
return;
}
vlib_buffer_t *b = vlib_get_buffer (vm, bi);
ASSERT (b->current_data == 0);
+ VLIB_BUFFER_TRACE_TRAJECTORY_INIT (b);
bfd_init_control_frame (bm, bs, b);
switch (bs->poll_state)
{
case BFD_POLL_NEEDED:
- if (now < bs->poll_state_start_or_timeout_clocks)
+ if (now < bs->poll_state_start_or_timeout_nsec)
{
- BFD_DBG ("Cannot start a poll sequence yet, need to wait "
- "for " BFD_CLK_FMT,
- BFD_CLK_PRN (bs->poll_state_start_or_timeout_clocks -
+ BFD_DBG ("Cannot start a poll sequence yet, need to wait for "
+ BFD_CLK_FMT,
+ BFD_CLK_PRN (bs->poll_state_start_or_timeout_nsec -
now));
break;
}
- bs->poll_state_start_or_timeout_clocks = now;
+ bs->poll_state_start_or_timeout_nsec = now;
bfd_set_poll_state (bs, BFD_POLL_IN_PROGRESS);
/* fallthrough */
case BFD_POLL_IN_PROGRESS:
break;
}
bfd_add_auth_section (b, bs);
- bfd_add_transport_layer (vm, b, bs);
- bs->last_tx_clocks = now;
+ bfd_add_transport_layer (vm, bi, bs);
+ if (!bfd_transport_control_frame (vm, bi, bs))
+ {
+ vlib_buffer_free_one (vm, bi);
+ }
+ bs->last_tx_nsec = now;
bfd_calc_next_tx (bm, bs, now);
- bfd_create_frame_to_next_node (vm, bs, bi);
}
else
{
BFD_DBG
("No need to send control frame now, now is %lu, tx_timeout is %lu",
- now, bs->tx_timeout_clocks);
+ now, bs->tx_timeout_nsec);
}
}
void
bfd_init_final_control_frame (vlib_main_t * vm, vlib_buffer_t * b,
- bfd_main_t * bm, bfd_session_t * bs)
+ bfd_main_t * bm, bfd_session_t * bs,
+ int is_local)
{
BFD_DBG ("Send final control frame for bs_idx=%lu", bs->bs_idx);
bfd_init_control_frame (bm, bs, b);
bfd_pkt_set_final (vlib_buffer_get_current (b));
bfd_add_auth_section (b, bs);
- bfd_add_transport_layer (vm, b, bs);
- bs->last_tx_clocks = clib_cpu_time_now ();
+ u32 bi = vlib_get_buffer_index (vm, b);
+ bfd_add_transport_layer (vm, bi, bs);
+ bs->last_tx_nsec = bfd_time_now_nsec (vm, NULL);
/*
* RFC allows to include changes in final frame, so if there were any
* pending, we already did that, thus we can clear any pending poll needs
}
static void
-bfd_check_rx_timeout (bfd_main_t * bm, bfd_session_t * bs, u64 now,
- int handling_wakeup)
+bfd_check_rx_timeout (vlib_main_t * vm, bfd_main_t * bm, bfd_session_t * bs,
+ u64 now, int handling_wakeup)
{
- /* sometimes the wheel expires an event a bit sooner than requested, account
- for that here */
- if (bs->last_rx_clocks + bs->detection_time_clocks <=
- now + bm->wheel_inaccuracy)
+ if (bs->last_rx_nsec + bs->detection_time_nsec <= now)
{
BFD_DBG ("Rx timeout, session goes down");
+ /*
+ * RFC 5880 6.8.1. State Variables
+
+ * bfd.RemoteDiscr
+
+ * The remote discriminator for this BFD session. This is the
+ * discriminator chosen by the remote system, and is totally opaque
+ * to the local system. This MUST be initialized to zero. If a
+ * period of a Detection Time passes without the receipt of a valid,
+ * authenticated BFD packet from the remote system, this variable
+ * MUST be set to zero.
+ */
+ bs->remote_discr = 0;
bfd_set_diag (bs, BFD_DIAG_CODE_det_time_exp);
- bfd_set_state (bm, bs, BFD_STATE_down, handling_wakeup);
+ bfd_set_state (vm, bm, bs, BFD_STATE_down, handling_wakeup);
/*
* If the remote system does not receive any
* BFD Control packets for a Detection Time, it SHOULD reset
*/
bfd_set_remote_required_min_rx (bm, bs, now, 1);
}
- else if (bs->echo &&
- bs->echo_last_rx_clocks +
- bs->echo_transmit_interval_clocks * bs->local_detect_mult <=
- now + bm->wheel_inaccuracy)
+ else if (bs->echo
+ && bs->echo_last_rx_nsec +
+ bs->echo_transmit_interval_nsec * bs->local_detect_mult <= now)
{
BFD_DBG ("Echo rx timeout, session goes down");
bfd_set_diag (bs, BFD_DIAG_CODE_echo_failed);
- bfd_set_state (bm, bs, BFD_STATE_down, handling_wakeup);
+ bfd_set_state (vm, bm, bs, BFD_STATE_down, handling_wakeup);
}
}
switch (bs->local_state)
{
case BFD_STATE_admin_down:
- bfd_send_periodic (vm, rt, bm, bs, now, 1);
+ bfd_send_periodic (vm, rt, bm, bs, now);
break;
case BFD_STATE_down:
- bfd_send_periodic (vm, rt, bm, bs, now, 1);
+ bfd_send_periodic (vm, rt, bm, bs, now);
break;
case BFD_STATE_init:
- bfd_check_rx_timeout (bm, bs, now, 1);
- bfd_send_periodic (vm, rt, bm, bs, now, 1);
+ bfd_check_rx_timeout (vm, bm, bs, now, 1);
+ bfd_send_periodic (vm, rt, bm, bs, now);
break;
case BFD_STATE_up:
- bfd_check_rx_timeout (bm, bs, now, 1);
+ bfd_check_rx_timeout (vm, bm, bs, now, 1);
if (BFD_POLL_NOT_NEEDED == bs->poll_state && !bs->echo &&
bfd_is_echo_possible (bs))
{
/* switch on echo function as main detection method now */
BFD_DBG ("Switching on echo function, bs_idx=%u", bs->bs_idx);
bs->echo = 1;
- bs->echo_last_rx_clocks = now;
- bs->echo_tx_timeout_clocks = now;
+ bs->echo_last_rx_nsec = now;
+ bs->echo_tx_timeout_nsec = now;
bfd_set_effective_required_min_rx (bm, bs,
clib_max
- (bm->min_required_min_rx_while_echo_clocks,
- bs->config_required_min_rx_clocks));
+ (bm->min_required_min_rx_while_echo_nsec,
+ bs->config_required_min_rx_nsec));
bfd_set_poll_state (bs, BFD_POLL_NEEDED);
}
- bfd_send_periodic (vm, rt, bm, bs, now, 1);
+ bfd_send_periodic (vm, rt, bm, bs, now);
if (bs->echo)
{
- bfd_send_echo (vm, rt, bm, bs, now, 1);
+ bfd_send_echo (vm, rt, bm, bs, now);
}
break;
}
while (1)
{
- u64 now = clib_cpu_time_now ();
- u64 next_expire = timing_wheel_next_expiring_elt_time (&bm->wheel);
- BFD_DBG ("timing_wheel_next_expiring_elt_time(%p) returns %lu",
- &bm->wheel, next_expire);
- if ((i64) next_expire < 0)
- {
- BFD_DBG ("wait for event without timeout");
- (void) vlib_process_wait_for_event (vm);
- event_type = vlib_process_get_events (vm, &event_data);
- }
- else
+ f64 vm_time;
+ u64 now = bfd_time_now_nsec (vm, &vm_time);
+ BFD_DBG ("wakeup, now is %llunsec, vlib_time_now() is %.9f", now,
+ vm_time);
+ bfd_lock (bm);
+ f64 timeout;
+ if (pool_elts (bm->sessions))
{
- f64 timeout = ((i64) next_expire - (i64) now) / bm->cpu_cps;
- BFD_DBG ("wait for event with timeout %.02f", timeout);
- if (timeout < 0)
+ u32 first_expires_in_ticks =
+ TW (tw_timer_first_expires_in_ticks) (&bm->wheel);
+ if (!first_expires_in_ticks)
{
- BFD_DBG ("negative timeout, already expired, skipping wait");
- event_type = ~0;
+ BFD_DBG
+ ("tw_timer_first_expires_in_ticks(%p) returns 0ticks",
+ &bm->wheel);
+ timeout = bm->wheel.next_run_time - vm_time;
+ BFD_DBG ("wheel.next_run_time is %.9f",
+ bm->wheel.next_run_time);
+ u64 next_expire_nsec = now + timeout * SEC_PER_NSEC;
+ bm->bfd_process_next_wakeup_nsec = next_expire_nsec;
+ bfd_unlock (bm);
}
else
{
- (void) vlib_process_wait_for_event_or_clock (vm, timeout);
- event_type = vlib_process_get_events (vm, &event_data);
+ BFD_DBG ("tw_timer_first_expires_in_ticks(%p) returns %luticks",
+ &bm->wheel, first_expires_in_ticks);
+ u64 next_expire_nsec =
+ now + first_expires_in_ticks * bm->nsec_per_tw_tick;
+ bm->bfd_process_next_wakeup_nsec = next_expire_nsec;
+ bfd_unlock (bm);
+ timeout = (next_expire_nsec - now) * SEC_PER_NSEC;
}
+ BFD_DBG ("vlib_process_wait_for_event_or_clock(vm, %.09f)",
+ timeout);
+ (void) vlib_process_wait_for_event_or_clock (vm, timeout);
}
- now = clib_cpu_time_now ();
+ else
+ {
+ (void) vlib_process_wait_for_event (vm);
+ }
+ event_type = vlib_process_get_events (vm, &event_data);
+ now = bfd_time_now_nsec (vm, &vm_time);
+ uword *session_index;
switch (event_type)
{
case ~0: /* no events => timeout */
/* nothing to do here */
break;
case BFD_EVENT_RESCHEDULE:
+ BFD_DBG ("reschedule event");
+ bfd_lock (bm);
+ bm->bfd_process_wakeup_event_delay_nsec =
+ now - bm->bfd_process_wakeup_event_start_nsec;
+ bm->bfd_process_wakeup_events_in_flight--;
+ bfd_unlock (bm);
/* nothing to do here - reschedule is done automatically after
* each event or timeout */
break;
case BFD_EVENT_NEW_SESSION:
- if (!pool_is_free_index (bm->sessions, *event_data))
- {
- bfd_session_t *bs =
- pool_elt_at_index (bm->sessions, *event_data);
- bfd_send_periodic (vm, rt, bm, bs, now, 1);
- }
- else
- {
- BFD_DBG ("Ignoring event for non-existent session index %u",
- (u32) * event_data);
- }
+ vec_foreach (session_index, event_data)
+ {
+ bfd_lock (bm);
+ if (!pool_is_free_index (bm->sessions, *session_index))
+ {
+ bfd_session_t *bs =
+ pool_elt_at_index (bm->sessions, *session_index);
+ bfd_send_periodic (vm, rt, bm, bs, now);
+ bfd_set_timer (bm, bs, now, 1);
+ }
+ else
+ {
+ BFD_DBG ("Ignoring event for non-existent session index %u",
+ (u32) * session_index);
+ }
+ bfd_unlock (bm);
+ }
break;
case BFD_EVENT_CONFIG_CHANGED:
- if (!pool_is_free_index (bm->sessions, *event_data))
- {
- bfd_session_t *bs =
- pool_elt_at_index (bm->sessions, *event_data);
- bfd_on_config_change (vm, rt, bm, bs, now);
- }
- else
- {
- BFD_DBG ("Ignoring event for non-existent session index %u",
- (u32) * event_data);
- }
+ vec_foreach (session_index, event_data)
+ {
+ bfd_lock (bm);
+ if (!pool_is_free_index (bm->sessions, *session_index))
+ {
+ bfd_session_t *bs =
+ pool_elt_at_index (bm->sessions, *session_index);
+ bfd_on_config_change (vm, rt, bm, bs, now);
+ }
+ else
+ {
+ BFD_DBG ("Ignoring event for non-existent session index %u",
+ (u32) * session_index);
+ }
+ bfd_unlock (bm);
+ }
break;
default:
- clib_warning ("BUG: event type 0x%wx", event_type);
+ vlib_log_err (bm->log_class, "BUG: event type 0x%wx", event_type);
break;
}
- BFD_DBG ("advancing wheel, now is %lu", now);
- BFD_DBG ("timing_wheel_advance (%p, %lu, %p, 0);", &bm->wheel, now,
- expired);
- expired = timing_wheel_advance (&bm->wheel, now, expired, 0);
+ BFD_DBG ("tw_timer_expire_timers_vec(%p, %.04f);", &bm->wheel, vm_time);
+ bfd_lock (bm);
+ expired =
+ TW (tw_timer_expire_timers_vec) (&bm->wheel, vm_time, expired);
BFD_DBG ("Expired %d elements", vec_len (expired));
u32 *p = NULL;
vec_foreach (p, expired)
if (!pool_is_free_index (bm->sessions, bs_idx))
{
bfd_session_t *bs = pool_elt_at_index (bm->sessions, bs_idx);
+ bs->tw_id = 0; /* timer is gone because it expired */
bfd_on_timeout (vm, rt, bm, bs, now);
bfd_set_timer (bm, bs, now, 1);
}
}
+ bfd_unlock (bm);
if (expired)
{
_vec_len (expired) = 0;
VNET_HW_INTERFACE_LINK_UP_DOWN_FUNCTION (bfd_hw_interface_up_down);
+void
+bfd_register_listener (bfd_notify_fn_t fn)
+{
+ bfd_main_t *bm = &bfd_main;
+
+ vec_add1 (bm->listeners, fn);
+}
+
/*
* setup function
*/
static clib_error_t *
bfd_main_init (vlib_main_t * vm)
{
+ vlib_thread_main_t *tm = &vlib_thread_main;
+ u32 n_vlib_mains = tm->n_vlib_mains;
#if BFD_DEBUG
setbuf (stdout, NULL);
#endif
bm->random_seed = random_default_seed ();
bm->vlib_main = vm;
bm->vnet_main = vnet_get_main ();
- memset (&bm->wheel, 0, sizeof (bm->wheel));
- bm->cpu_cps = vm->clib_time.clocks_per_second;
- BFD_DBG ("cps is %.2f", bm->cpu_cps);
- bm->default_desired_min_tx_clocks =
- bfd_usec_to_clocks (bm, BFD_DEFAULT_DESIRED_MIN_TX_USEC);
- bm->min_required_min_rx_while_echo_clocks =
- bfd_usec_to_clocks (bm, BFD_REQUIRED_MIN_RX_USEC_WHILE_ECHO);
- const u64 now = clib_cpu_time_now ();
- timing_wheel_init (&bm->wheel, now, bm->cpu_cps);
- bm->wheel_inaccuracy = 2 << bm->wheel.log2_clocks_per_bin;
-
- vlib_node_t *node = NULL;
-#define F(t, n) \
- node = vlib_get_node_by_name (vm, (u8 *)n); \
- bfd_node_index_by_transport[BFD_TRANSPORT_##t] = node->index; \
- BFD_DBG ("node '%s' has index %u", n, node->index);
- foreach_bfd_transport (F);
-#undef F
+ clib_memset (&bm->wheel, 0, sizeof (bm->wheel));
+ bm->nsec_per_tw_tick = (f64) NSEC_PER_SEC / BFD_TW_TPS;
+ bm->default_desired_min_tx_nsec =
+ bfd_usec_to_nsec (BFD_DEFAULT_DESIRED_MIN_TX_USEC);
+ bm->min_required_min_rx_while_echo_nsec =
+ bfd_usec_to_nsec (BFD_REQUIRED_MIN_RX_USEC_WHILE_ECHO);
+ BFD_DBG ("tw_timer_wheel_init(%p, %p, %.04f, %u)", &bm->wheel, NULL,
+ 1.00 / BFD_TW_TPS, ~0);
+ TW (tw_timer_wheel_init) (&bm->wheel, NULL, 1.00 / BFD_TW_TPS, ~0);
+ bm->log_class = vlib_log_register_class ("bfd", 0);
+ vlib_log_debug (bm->log_class, "initialized");
+ bm->owner_thread_index = ~0;
+ if (n_vlib_mains > 1)
+ clib_spinlock_init (&bm->lock);
return 0;
}
bfd_get_session (bfd_main_t * bm, bfd_transport_e t)
{
bfd_session_t *result;
+
+ bfd_lock (bm);
+
pool_get (bm->sessions, result);
- memset (result, 0, sizeof (*result));
+ clib_memset (result, 0, sizeof (*result));
result->bs_idx = result - bm->sessions;
result->transport = t;
const unsigned limit = 1000;
result->local_discr = random_u32 (&bm->random_seed);
if (counter > limit)
{
- clib_warning ("Couldn't allocate unused session discriminator even "
- "after %u tries!", limit);
+ vlib_log_crit (bm->log_class,
+ "couldn't allocate unused session discriminator even "
+ "after %u tries!", limit);
pool_put (bm->sessions, result);
+ bfd_unlock (bm);
return NULL;
}
++counter;
while (hash_get (bm->session_by_disc, result->local_discr));
bfd_set_defaults (bm, result);
hash_set (bm->session_by_disc, result->local_discr, result->bs_idx);
+ bfd_unlock (bm);
return result;
}
void
bfd_put_session (bfd_main_t * bm, bfd_session_t * bs)
{
+ bfd_lock (bm);
+
+ vlib_log_info (bm->log_class, "delete session: %U",
+ format_bfd_session_brief, bs);
+ bfd_notify_listeners (bm, BFD_LISTEN_EVENT_DELETE, bs);
if (bs->auth.curr_key)
{
--bs->auth.curr_key->use_count;
}
hash_unset (bm->session_by_disc, bs->local_discr);
pool_put (bm->sessions, bs);
+ bfd_unlock (bm);
}
bfd_session_t *
bfd_find_session_by_idx (bfd_main_t * bm, uword bs_idx)
{
+ bfd_lock_check (bm);
if (!pool_is_free_index (bm->sessions, bs_idx))
{
return pool_elt_at_index (bm->sessions, bs_idx);
bfd_session_t *
bfd_find_session_by_disc (bfd_main_t * bm, u32 disc)
{
+ bfd_lock_check (bm);
uword *p = hash_get (bfd_main.session_by_disc, disc);
if (p)
{
}
static int
-bfd_verify_pkt_auth_seq_num (bfd_session_t * bs,
+bfd_verify_pkt_auth_seq_num (vlib_main_t * vm, bfd_session_t * bs,
u32 received_seq_num, int is_meticulous)
{
/*
* This variable MUST be set to zero after no packets have been
* received on this session for at least twice the Detection Time.
*/
- u64 now = clib_cpu_time_now ();
- if (now - bs->last_rx_clocks > bs->detection_time_clocks * 2)
+ u64 now = bfd_time_now_nsec (vm, NULL);
+ if (now - bs->last_rx_nsec > bs->detection_time_nsec * 2)
{
- BFD_DBG ("BFD peer unresponsive for %lu clocks, which is > 2 * "
- "detection_time=%u clocks, resetting remote_seq_number_known "
- "flag",
- now - bs->last_rx_clocks, bs->detection_time_clocks * 2);
+ BFD_DBG ("BFD peer unresponsive for %lu nsec, which is > 2 * "
+ "detection_time=%u nsec, resetting remote_seq_number_known "
+ "flag", now - bs->last_rx_nsec, bs->detection_time_nsec * 2);
bs->auth.remote_seq_number_known = 0;
}
if (bs->auth.remote_seq_number_known)
}
static int
-bfd_verify_pkt_auth_key (const bfd_pkt_t * pkt, u32 pkt_size,
- bfd_session_t * bs, u8 bfd_key_id,
+bfd_verify_pkt_auth_key (vlib_main_t * vm, const bfd_pkt_t * pkt,
+ u32 pkt_size, bfd_session_t * bs, u8 bfd_key_id,
bfd_auth_key_t * auth_key)
{
+ bfd_main_t *bm = &bfd_main;
switch (auth_key->auth_type)
{
case BFD_AUTH_TYPE_reserved:
- clib_warning ("Internal error, unexpected auth_type=%d:%s",
+ vlib_log_err (bm->log_class,
+ "internal error, unexpected auth_type=%d:%s",
auth_key->auth_type,
bfd_auth_type_str (auth_key->auth_type));
return 0;
case BFD_AUTH_TYPE_simple_password:
- clib_warning
- ("Internal error, not implemented, unexpected auth_type=%d:%s",
- auth_key->auth_type, bfd_auth_type_str (auth_key->auth_type));
+ vlib_log_err (bm->log_class,
+ "internal error, not implemented, unexpected auth_type=%d:%s",
+ auth_key->auth_type,
+ bfd_auth_type_str (auth_key->auth_type));
return 0;
case BFD_AUTH_TYPE_keyed_md5:
/* fallthrough */
case BFD_AUTH_TYPE_meticulous_keyed_md5:
- clib_warning
- ("Internal error, not implemented, unexpected auth_type=%d:%s",
+ vlib_log_err
+ (bm->log_class,
+ "internal error, not implemented, unexpected auth_type=%d:%s",
auth_key->auth_type, bfd_auth_type_str (auth_key->auth_type));
return 0;
case BFD_AUTH_TYPE_keyed_sha1:
const u32 seq_num = clib_net_to_host_u32 (((bfd_pkt_with_sha1_auth_t
*) pkt)->
sha1_auth.seq_num);
- return bfd_verify_pkt_auth_seq_num (bs, seq_num,
+ return bfd_verify_pkt_auth_seq_num (vm, bs, seq_num,
bfd_auth_type_is_meticulous
(auth_key->auth_type))
&& bfd_verify_pkt_auth_key_sha1 (pkt, pkt_size, bs, bfd_key_id,
}
while (0);
#else
- clib_warning
- ("Internal error, attempt to use SHA1 without SSL support");
+ vlib_log_err
+ (bm->log_class,
+ "internal error, attempt to use SHA1 without SSL support");
return 0;
#endif
}
* @return 1 if bfd packet is valid
*/
int
-bfd_verify_pkt_auth (const bfd_pkt_t * pkt, u16 pkt_size, bfd_session_t * bs)
+bfd_verify_pkt_auth (vlib_main_t * vm, const bfd_pkt_t * pkt, u16 pkt_size,
+ bfd_session_t * bs)
{
if (bfd_pkt_get_auth_present (pkt))
{
if (bs->auth.is_delayed && bs->auth.next_key)
{
/* yes, switch is scheduled - make sure the auth is valid */
- if (bfd_verify_pkt_auth_key (pkt, pkt_size, bs,
+ if (bfd_verify_pkt_auth_key (vm, pkt, pkt_size, bs,
bs->auth.next_bfd_key_id,
bs->auth.next_key))
{
else
{
/* yes, using authentication, verify the key */
- if (bfd_verify_pkt_auth_key (pkt, pkt_size, bs,
+ if (bfd_verify_pkt_auth_key (vm, pkt, pkt_size, bs,
bs->auth.curr_bfd_key_id,
bs->auth.curr_key))
{
if (bs->auth.is_delayed && bs->auth.next_key)
{
/* delayed switch present, verify if that key works */
- if (bfd_verify_pkt_auth_key (pkt, pkt_size, bs,
+ if (bfd_verify_pkt_auth_key (vm, pkt, pkt_size, bs,
bs->auth.next_bfd_key_id,
bs->auth.next_key))
{
}
void
-bfd_consume_pkt (bfd_main_t * bm, const bfd_pkt_t * pkt, u32 bs_idx)
+bfd_consume_pkt (vlib_main_t * vm, bfd_main_t * bm, const bfd_pkt_t * pkt,
+ u32 bs_idx)
{
+ bfd_lock_check (bm);
+
bfd_session_t *bs = bfd_find_session_by_idx (bm, bs_idx);
if (!bs || (pkt->your_disc && pkt->your_disc != bs->local_discr))
{
bs->remote_state = bfd_pkt_get_state (pkt);
bs->remote_demand = bfd_pkt_get_demand (pkt);
bs->remote_diag = bfd_pkt_get_diag_code (pkt);
- u64 now = clib_cpu_time_now ();
- bs->last_rx_clocks = now;
+ u64 now = bfd_time_now_nsec (vm, NULL);
+ bs->last_rx_nsec = now;
if (bfd_pkt_get_auth_present (pkt))
{
bfd_auth_type_e auth_type =
case BFD_AUTH_TYPE_keyed_md5:
/* fallthrough */
case BFD_AUTH_TYPE_meticulous_keyed_md5:
- clib_warning ("Internal error, unexpected auth_type=%d:%s",
- auth_type, bfd_auth_type_str (auth_type));
+ vlib_log_crit (bm->log_class,
+ "internal error, unexpected auth_type=%d:%s",
+ auth_type, bfd_auth_type_str (auth_type));
break;
case BFD_AUTH_TYPE_keyed_sha1:
/* fallthrough */
while (0);
}
}
- bs->remote_desired_min_tx_clocks =
- bfd_usec_to_clocks (bm, clib_net_to_host_u32 (pkt->des_min_tx));
+ bs->remote_desired_min_tx_nsec =
+ bfd_usec_to_nsec (clib_net_to_host_u32 (pkt->des_min_tx));
bs->remote_detect_mult = pkt->head.detect_mult;
bfd_set_remote_required_min_rx (bm, bs, now,
clib_net_to_host_u32 (pkt->req_min_rx));
{
bfd_set_effective_required_min_rx (bm, bs,
clib_max (bs->echo *
- bm->min_required_min_rx_while_echo_clocks,
- bs->config_required_min_rx_clocks));
+ bm->min_required_min_rx_while_echo_nsec,
+ bs->config_required_min_rx_nsec));
}
}
else if (BFD_POLL_IN_PROGRESS_AND_QUEUED == bs->poll_state)
* time, so calculate that here
*/
BFD_DBG ("Next poll sequence can commence in " BFD_CLK_FMT,
- BFD_CLK_PRN (now -
- bs->poll_state_start_or_timeout_clocks));
- bs->poll_state_start_or_timeout_clocks =
- now + (now - bs->poll_state_start_or_timeout_clocks);
+ BFD_CLK_PRN (now - bs->poll_state_start_or_timeout_nsec));
+ bs->poll_state_start_or_timeout_nsec =
+ now + (now - bs->poll_state_start_or_timeout_nsec);
BFD_DBG
("Poll sequence terminated, but another is needed, bs_idx=%u",
bs->bs_idx);
if (BFD_STATE_admin_down == bs->remote_state)
{
bfd_set_diag (bs, BFD_DIAG_CODE_neighbor_sig_down);
- bfd_set_state (bm, bs, BFD_STATE_down, 0);
+ bfd_set_state (vm, bm, bs, BFD_STATE_down, 0);
}
else if (BFD_STATE_down == bs->local_state)
{
if (BFD_STATE_down == bs->remote_state)
{
- bfd_set_state (bm, bs, BFD_STATE_init, 0);
+ bfd_set_diag (bs, BFD_DIAG_CODE_no_diag);
+ bfd_set_state (vm, bm, bs, BFD_STATE_init, 0);
}
else if (BFD_STATE_init == bs->remote_state)
{
- bfd_set_state (bm, bs, BFD_STATE_up, 0);
+ bfd_set_diag (bs, BFD_DIAG_CODE_no_diag);
+ bfd_set_state (vm, bm, bs, BFD_STATE_up, 0);
}
}
else if (BFD_STATE_init == bs->local_state)
if (BFD_STATE_up == bs->remote_state ||
BFD_STATE_init == bs->remote_state)
{
- bfd_set_state (bm, bs, BFD_STATE_up, 0);
+ bfd_set_diag (bs, BFD_DIAG_CODE_no_diag);
+ bfd_set_state (vm, bm, bs, BFD_STATE_up, 0);
}
}
else /* BFD_STATE_up == bs->local_state */
if (BFD_STATE_down == bs->remote_state)
{
bfd_set_diag (bs, BFD_DIAG_CODE_neighbor_sig_down);
- bfd_set_state (bm, bs, BFD_STATE_down, 0);
+ bfd_set_state (vm, bm, bs, BFD_STATE_down, 0);
}
}
}
int
-bfd_consume_echo_pkt (bfd_main_t * bm, vlib_buffer_t * b)
+bfd_consume_echo_pkt (vlib_main_t * vm, bfd_main_t * bm, vlib_buffer_t * b)
{
bfd_echo_pkt_t *pkt = NULL;
if (b->current_length != sizeof (*pkt))
}
BFD_DBG ("Scanning bfd echo packet, bs_idx=%d", bs->bs_idx);
u64 checksum =
- bfd_calc_echo_checksum (bs->local_discr, pkt->expire_time_clocks,
+ bfd_calc_echo_checksum (bs->local_discr, pkt->expire_time_nsec,
bs->echo_secret);
if (checksum != pkt->checksum)
{
BFD_DBG ("Invalid echo packet, checksum mismatch");
return 1;
}
- u64 now = clib_cpu_time_now ();
- if (pkt->expire_time_clocks < now)
+ u64 now = bfd_time_now_nsec (vm, NULL);
+ if (pkt->expire_time_nsec < now)
{
BFD_DBG ("Stale packet received, expire time %lu < now %lu",
- pkt->expire_time_clocks, now);
+ pkt->expire_time_nsec, now);
}
else
{
- bs->echo_last_rx_clocks = now;
+ bs->echo_last_rx_nsec = now;
}
return 1;
}
format_bfd_session (u8 * s, va_list * args)
{
const bfd_session_t *bs = va_arg (*args, bfd_session_t *);
- uword indent = format_get_indent (s);
+ u32 indent = format_get_indent (s) + vlib_log_get_indent ();
s = format (s, "bs_idx=%u local-state=%s remote-state=%s\n"
"%Ulocal-discriminator=%u remote-discriminator=%u\n"
"%Ulocal-diag=%s echo-active=%s\n"
return s;
}
+u8 *
+format_bfd_session_brief (u8 * s, va_list * args)
+{
+ const bfd_session_t *bs = va_arg (*args, bfd_session_t *);
+ s =
+ format (s, "bs_idx=%u local-state=%s remote-state=%s", bs->bs_idx,
+ bfd_state_string (bs->local_state),
+ bfd_state_string (bs->remote_state));
+ return s;
+}
+
unsigned
bfd_auth_type_supported (bfd_auth_type_e auth_type)
{
hash_get (bm->auth_key_by_conf_key_id, conf_key_id);
if (!key_idx_p)
{
- clib_warning ("Authentication key with config ID %u doesn't exist)",
+ vlib_log_err (bm->log_class,
+ "authentication key with config ID %u doesn't exist)",
conf_key_id);
return VNET_API_ERROR_BFD_ENOENT;
}
}
++key->use_count;
BFD_DBG ("\nSession auth modified: %U", format_bfd_session, bs);
+ vlib_log_info (bm->log_class, "session auth modified: %U",
+ format_bfd_session_brief, bs);
return 0;
}
vnet_api_error_t
bfd_auth_deactivate (bfd_session_t * bs, u8 is_delayed)
{
+ bfd_main_t *bm = &bfd_main;
#if WITH_LIBSSL > 0
if (!is_delayed)
{
bs->auth.next_key = NULL;
}
BFD_DBG ("\nSession auth modified: %U", format_bfd_session, bs);
+ vlib_log_info (bm->log_class, "session auth modified: %U",
+ format_bfd_session_brief, bs);
return 0;
#else
- clib_warning ("SSL missing, cannot deactivate BFD authentication");
+ vlib_log_err (bm->log_class,
+ "SSL missing, cannot deactivate BFD authentication");
return VNET_API_ERROR_BFD_NOTSUPP;
#endif
}
bs->local_detect_mult = detect_mult;
bs->config_desired_min_tx_usec = desired_min_tx_usec;
- bs->config_desired_min_tx_clocks =
- bfd_usec_to_clocks (bm, desired_min_tx_usec);
+ bs->config_desired_min_tx_nsec = bfd_usec_to_nsec (desired_min_tx_usec);
bs->config_required_min_rx_usec = required_min_rx_usec;
- bs->config_required_min_rx_clocks =
- bfd_usec_to_clocks (bm, required_min_rx_usec);
+ bs->config_required_min_rx_nsec =
+ bfd_usec_to_nsec (required_min_rx_usec);
BFD_DBG ("\nChanged session params: %U", format_bfd_session, bs);
+ vlib_log_info (bm->log_class, "changed session params: %U",
+ format_bfd_session_brief, bs);
vlib_process_signal_event (bm->vlib_main, bm->bfd_process_node_index,
BFD_EVENT_CONFIG_CHANGED, bs->bs_idx);
}
bfd_auth_set_key (u32 conf_key_id, u8 auth_type, u8 key_len,
const u8 * key_data)
{
+ bfd_main_t *bm = &bfd_main;
#if WITH_LIBSSL > 0
bfd_auth_key_t *auth_key = NULL;
if (!key_len || key_len > bfd_max_key_len_for_auth_type (auth_type))
{
- clib_warning ("Invalid authentication key length for auth_type=%d:%s "
- "(key_len=%u, must be "
- "non-zero, expected max=%u)",
+ vlib_log_err (bm->log_class,
+ "invalid authentication key length for auth_type=%d:%s "
+ "(key_len=%u, must be non-zero, expected max=%u)",
auth_type, bfd_auth_type_str (auth_type), key_len,
(u32) bfd_max_key_len_for_auth_type (auth_type));
return VNET_API_ERROR_INVALID_VALUE;
}
if (!bfd_auth_type_supported (auth_type))
{
- clib_warning ("Unsupported auth type=%d:%s", auth_type,
+ vlib_log_err (bm->log_class, "unsupported auth type=%d:%s", auth_type,
bfd_auth_type_str (auth_type));
return VNET_API_ERROR_BFD_NOTSUPP;
}
- bfd_main_t *bm = &bfd_main;
uword *key_idx_p = hash_get (bm->auth_key_by_conf_key_id, conf_key_id);
if (key_idx_p)
{
auth_key = pool_elt_at_index (bm->auth_keys, key_idx);
if (auth_key->use_count > 0)
{
- clib_warning ("Authentication key with conf ID %u in use by %u BFD "
- "session(s) - cannot modify",
- conf_key_id, auth_key->use_count);
+ vlib_log_err (bm->log_class,
+ "authentication key with conf ID %u in use by %u BFD "
+ "session(s) - cannot modify", conf_key_id,
+ auth_key->use_count);
return VNET_API_ERROR_BFD_EINUSE;
}
}
auth_key - bm->auth_keys);
}
auth_key->auth_type = auth_type;
- memset (auth_key->key, 0, sizeof (auth_key->key));
+ clib_memset (auth_key->key, 0, sizeof (auth_key->key));
clib_memcpy (auth_key->key, key_data, key_len);
return 0;
#else
- clib_warning ("SSL missing, cannot manipulate authentication keys");
+ vlib_log_err (bm->log_class,
+ "SSL missing, cannot manipulate authentication keys");
return VNET_API_ERROR_BFD_NOTSUPP;
#endif
}
auth_key = pool_elt_at_index (bm->auth_keys, key_idx);
if (auth_key->use_count > 0)
{
- clib_warning ("Authentication key with conf ID %u in use by %u BFD "
- "session(s) - cannot delete",
- conf_key_id, auth_key->use_count);
+ vlib_log_err (bm->log_class,
+ "authentication key with conf ID %u in use by %u BFD "
+ "session(s) - cannot delete", conf_key_id,
+ auth_key->use_count);
return VNET_API_ERROR_BFD_EINUSE;
}
hash_unset (bm->auth_key_by_conf_key_id, conf_key_id);
- memset (auth_key, 0, sizeof (*auth_key));
+ clib_memset (auth_key, 0, sizeof (*auth_key));
pool_put (bm->auth_keys, auth_key);
}
else
{
/* no such key */
- clib_warning ("Authentication key with conf ID %u does not exist",
+ vlib_log_err (bm->log_class,
+ "authentication key with conf ID %u does not exist",
conf_key_id);
return VNET_API_ERROR_BFD_ENOENT;
}
return 0;
#else
- clib_warning ("SSL missing, cannot manipulate authentication keys");
+ vlib_log_err (bm->log_class,
+ "SSL missing, cannot manipulate authentication keys");
return VNET_API_ERROR_BFD_NOTSUPP;
#endif
}
Code Review / vpp.git / blobdiff