hs-test: cache docker build in local filesystem
[vpp.git] / src / vnet / bonding / device.c
index 53123dd..a0b93fc 100644 (file)
 
 #define _GNU_SOURCE
 #include <stdint.h>
-#include <vnet/ethernet/ethernet.h>
-#include <vnet/ip/ip4_packet.h>
-#include <vnet/ip/ip6_packet.h>
-#include <vnet/ip/ip6_hop_by_hop_packet.h>
+#include <vnet/ip-neighbor/ip4_neighbor.h>
+#include <vnet/ip-neighbor/ip6_neighbor.h>
 #include <vnet/bonding/node.h>
-#include <vppinfra/lb_hash_hash.h>
-#include <vnet/ip/ip.h>
-#include <vnet/ethernet/arp_packet.h>
 
-#define foreach_bond_tx_error     \
-  _(NONE, "no error")             \
-  _(IF_DOWN, "interface down")    \
-  _(NO_SLAVE, "no slave")
+#define foreach_bond_tx_error                                                 \
+  _ (NONE, "no error")                                                        \
+  _ (IF_DOWN, "interface down")                                               \
+  _ (BAD_LB_MODE, "bad load balance mode")                                    \
+  _ (NO_MEMBER, "no member")
 
 typedef enum
 {
@@ -64,6 +60,7 @@ format_bond_tx_trace (u8 * s, va_list * args)
   return s;
 }
 
+#ifndef CLIB_MARCH_VARIANT
 u8 *
 format_bond_interface_name (u8 * s, va_list * args)
 {
@@ -71,10 +68,11 @@ format_bond_interface_name (u8 * s, va_list * args)
   bond_main_t *bm = &bond_main;
   bond_if_t *bif = pool_elt_at_index (bm->interfaces, dev_instance);
 
-  s = format (s, "BondEthernet%lu", bif->dev_instance);
+  s = format (s, "BondEthernet%lu", bif->id);
 
   return s;
 }
+#endif
 
 static __clib_unused clib_error_t *
 bond_set_l2_mode_function (vnet_main_t * vnm,
@@ -83,37 +81,36 @@ bond_set_l2_mode_function (vnet_main_t * vnm,
 {
   bond_if_t *bif;
   u32 *sw_if_index;
-  struct vnet_hw_interface_t *sif_hw;
+  struct vnet_hw_interface_t *mif_hw;
 
-  bif = bond_get_master_by_sw_if_index (bif_hw->sw_if_index);
+  bif = bond_get_bond_if_by_sw_if_index (bif_hw->sw_if_index);
   if (!bif)
     return 0;
 
   if ((bif_hw->l2_if_count == 1) && (l2_if_adjust == 1))
     {
       /* Just added first L2 interface on this port */
-      vec_foreach (sw_if_index, bif->slaves)
+      vec_foreach (sw_if_index, bif->members)
       {
-       sif_hw = vnet_get_sup_hw_interface (vnm, *sw_if_index);
-       ethernet_set_flags (vnm, sif_hw->hw_if_index,
+       mif_hw = vnet_get_sup_hw_interface (vnm, *sw_if_index);
+       ethernet_set_flags (vnm, mif_hw->hw_if_index,
                            ETHERNET_INTERFACE_FLAG_ACCEPT_ALL);
-
-       /* ensure all packets go to ethernet-input */
-       ethernet_set_rx_redirect (vnm, sif_hw, 1);
+      }
+    }
+  else if ((bif_hw->l2_if_count == 0) && (l2_if_adjust == -1))
+    {
+      /* Just removed last L2 subinterface on this port */
+      vec_foreach (sw_if_index, bif->members)
+      {
+       mif_hw = vnet_get_sup_hw_interface (vnm, *sw_if_index);
+       ethernet_set_flags (vnm, mif_hw->hw_if_index,
+                           /*ETHERNET_INTERFACE_FLAG_DEFAULT_L3 */ 0);
       }
     }
 
   return 0;
 }
 
-static __clib_unused clib_error_t *
-bond_subif_add_del_function (vnet_main_t * vnm, u32 hw_if_index,
-                            struct vnet_sw_interface_t *st, int is_add)
-{
-  /* Nothing for now */
-  return 0;
-}
-
 static clib_error_t *
 bond_interface_admin_up_down (vnet_main_t * vnm, u32 hw_if_index, u32 flags)
 {
@@ -123,40 +120,84 @@ bond_interface_admin_up_down (vnet_main_t * vnm, u32 hw_if_index, u32 flags)
   bond_if_t *bif = pool_elt_at_index (bm->interfaces, hif->dev_instance);
 
   bif->admin_up = is_up;
-  if (is_up && vec_len (bif->active_slaves))
+  if (is_up)
     vnet_hw_interface_set_flags (vnm, bif->hw_if_index,
                                 VNET_HW_INTERFACE_FLAG_LINK_UP);
   return 0;
 }
 
-static_always_inline u32
-bond_load_balance_broadcast (vlib_main_t * vm, vlib_node_runtime_t * node,
-                            bond_if_t * bif, vlib_buffer_t * b0,
-                            uword slave_count)
+static clib_error_t *
+bond_add_del_mac_address (vnet_hw_interface_t * hi, const u8 * address,
+                         u8 is_add)
 {
   vnet_main_t *vnm = vnet_get_main ();
+  bond_if_t *bif;
+  clib_error_t *error = 0;
+  vnet_hw_interface_t *s_hi;
+  int i;
+
+
+  bif = bond_get_bond_if_by_sw_if_index (hi->sw_if_index);
+  if (!bif)
+    {
+      return clib_error_return (0,
+                               "No bond interface found for sw_if_index %u",
+                               hi->sw_if_index);
+    }
+
+  /* Add/del address on each member hw intf, they control the hardware */
+  vec_foreach_index (i, bif->members)
+  {
+    s_hi = vnet_get_sup_hw_interface (vnm, vec_elt (bif->members, i));
+    error = vnet_hw_interface_add_del_mac_address (vnm, s_hi->hw_if_index,
+                                                  address, is_add);
+
+    if (error)
+      {
+       int j;
+
+       /* undo any that were completed before the failure */
+       for (j = i - 1; j > -1; j--)
+         {
+           s_hi = vnet_get_sup_hw_interface (vnm, vec_elt (bif->members, j));
+           vnet_hw_interface_add_del_mac_address (vnm, s_hi->hw_if_index,
+                                                  address, !(is_add));
+         }
+
+       return error;
+      }
+  }
+
+  return 0;
+}
+
+static_always_inline void
+bond_tx_add_to_queue (bond_per_thread_data_t * ptd, u32 port, u32 bi)
+{
+  u32 idx = ptd->per_port_queue[port].n_buffers++;
+  ptd->per_port_queue[port].buffers[idx] = bi;
+}
+
+static_always_inline u32
+bond_lb_broadcast (vlib_main_t *vm, bond_if_t *bif, vlib_buffer_t *b0,
+                  uword n_members)
+{
+  bond_main_t *bm = &bond_main;
   vlib_buffer_t *c0;
   int port;
-  u32 *to_next = 0;
   u32 sw_if_index;
-  vlib_frame_t *f;
   u16 thread_index = vm->thread_index;
+  bond_per_thread_data_t *ptd = vec_elt_at_index (bm->per_thread_data,
+                                                 thread_index);
 
-  for (port = 1; port < slave_count; port++)
+  for (port = 1; port < n_members; port++)
     {
-      sw_if_index = *vec_elt_at_index (bif->active_slaves, port);
-      if (bif->per_thread_info[thread_index].frame[port] == 0)
-       bif->per_thread_info[thread_index].frame[port] =
-         vnet_get_frame_to_sw_interface (vnm, sw_if_index);
-      f = bif->per_thread_info[thread_index].frame[port];
-      to_next = vlib_frame_vector_args (f);
-      to_next += f->n_vectors;
+      sw_if_index = *vec_elt_at_index (bif->active_members, port);
       c0 = vlib_buffer_copy (vm, b0);
       if (PREDICT_TRUE (c0 != 0))
        {
          vnet_buffer (c0)->sw_if_index[VLIB_TX] = sw_if_index;
-         to_next[0] = vlib_get_buffer_index (vm, c0);
-         f->n_vectors++;
+         bond_tx_add_to_queue (ptd, port, vlib_get_buffer_index (vm, c0));
        }
     }
 
@@ -164,255 +205,279 @@ bond_load_balance_broadcast (vlib_main_t * vm, vlib_node_runtime_t * node,
 }
 
 static_always_inline u32
-bond_load_balance_l2 (vlib_main_t * vm, vlib_node_runtime_t * node,
-                     bond_if_t * bif, vlib_buffer_t * b0, uword slave_count)
+bond_lb_round_robin (bond_if_t *bif, vlib_buffer_t *b0, uword n_members)
 {
-  ethernet_header_t *eth = (ethernet_header_t *) vlib_buffer_get_current (b0);
-  u32 c;
-  u64 *dst = (u64 *) & eth->dst_address[0];
-  u64 a = clib_mem_unaligned (dst, u64);
-  u32 *src = (u32 *) & eth->src_address[2];
-  u32 b = clib_mem_unaligned (src, u32);
-
-  c = lb_hash_hash_2_tuples (a, b);
+  bif->lb_rr_last_index++;
+  if (bif->lb_rr_last_index >= n_members)
+    bif->lb_rr_last_index = 0;
 
-  if (BOND_MODULO_SHORTCUT (slave_count))
-    return (c & (slave_count - 1));
-  else
-    return c % slave_count;
+  return bif->lb_rr_last_index;
 }
 
-static_always_inline u16 *
-bond_locate_ethertype (ethernet_header_t * eth)
+static_always_inline void
+bond_tx_hash (vlib_main_t *vm, bond_per_thread_data_t *ptd, bond_if_t *bif,
+             vlib_buffer_t **b, u32 *h, u32 n_left)
 {
-  u16 *ethertype_p;
-  ethernet_vlan_header_t *vlan;
+  u32 n_left_from = n_left;
+  void **data;
+
+  ASSERT (bif->hash_func != 0);
 
-  if (!ethernet_frame_is_tagged (clib_net_to_host_u16 (eth->type)))
+  vec_validate_aligned (ptd->data, n_left - 1, CLIB_CACHE_LINE_BYTES);
+  data = ptd->data;
+  while (n_left >= 8)
     {
-      ethertype_p = &eth->type;
+      // Prefetch next iteration
+      vlib_prefetch_buffer_header (b[4], LOAD);
+      vlib_prefetch_buffer_header (b[5], LOAD);
+      vlib_prefetch_buffer_header (b[6], LOAD);
+      vlib_prefetch_buffer_header (b[7], LOAD);
+
+      data[0] = vlib_buffer_get_current (b[0]);
+      data[1] = vlib_buffer_get_current (b[1]);
+      data[2] = vlib_buffer_get_current (b[2]);
+      data[3] = vlib_buffer_get_current (b[3]);
+
+      n_left -= 4;
+      b += 4;
+      data += 4;
     }
-  else
+
+  while (n_left > 0)
     {
-      vlan = (void *) (eth + 1);
-      ethertype_p = &vlan->type;
-      if (*ethertype_p == ntohs (ETHERNET_TYPE_VLAN))
-       {
-         vlan++;
-         ethertype_p = &vlan->type;
-       }
+      data[0] = vlib_buffer_get_current (b[0]);
+
+      n_left -= 1;
+      b += 1;
+      data += 1;
     }
-  return ethertype_p;
+
+  bif->hash_func (ptd->data, h, n_left_from);
+  vec_reset_length (ptd->data);
 }
 
-static_always_inline u32
-bond_load_balance_l23 (vlib_main_t * vm, vlib_node_runtime_t * node,
-                      bond_if_t * bif, vlib_buffer_t * b0, uword slave_count)
+static_always_inline void
+bond_tx_no_hash (vlib_main_t *vm, bond_if_t *bif, vlib_buffer_t **b, u32 *h,
+                u32 n_left, uword n_members, u32 lb_alg)
 {
-  ethernet_header_t *eth = (ethernet_header_t *) vlib_buffer_get_current (b0);
-  u8 ip_version;
-  ip4_header_t *ip4;
-  u16 ethertype, *ethertype_p;
-  u32 *mac1, *mac2, *mac3;
+  while (n_left >= 8)
+    {
+      // Prefetch next iteration
+      vlib_prefetch_buffer_header (b[4], LOAD);
+      vlib_prefetch_buffer_header (b[5], LOAD);
+      vlib_prefetch_buffer_header (b[6], LOAD);
+      vlib_prefetch_buffer_header (b[7], LOAD);
+
+      clib_prefetch_load (b[4]->data);
+      clib_prefetch_load (b[5]->data);
+      clib_prefetch_load (b[6]->data);
+      clib_prefetch_load (b[7]->data);
+
+      if (lb_alg == BOND_LB_RR)
+       {
+         h[0] = bond_lb_round_robin (bif, b[0], n_members);
+         h[1] = bond_lb_round_robin (bif, b[1], n_members);
+         h[2] = bond_lb_round_robin (bif, b[2], n_members);
+         h[3] = bond_lb_round_robin (bif, b[3], n_members);
+       }
+      else if (lb_alg == BOND_LB_BC)
+       {
+         h[0] = bond_lb_broadcast (vm, bif, b[0], n_members);
+         h[1] = bond_lb_broadcast (vm, bif, b[1], n_members);
+         h[2] = bond_lb_broadcast (vm, bif, b[2], n_members);
+         h[3] = bond_lb_broadcast (vm, bif, b[3], n_members);
+       }
+      else
+       {
+         ASSERT (0);
+       }
 
-  ethertype_p = bond_locate_ethertype (eth);
-  ethertype = clib_mem_unaligned (ethertype_p, u16);
+      n_left -= 4;
+      b += 4;
+      h += 4;
+    }
+
+  while (n_left > 0)
+    {
+      if (bif->lb == BOND_LB_RR)
+       h[0] = bond_lb_round_robin (bif, b[0], n_members);
+      else if (bif->lb == BOND_LB_BC)
+       h[0] = bond_lb_broadcast (vm, bif, b[0], n_members);
+      else
+       {
+         ASSERT (0);
+       }
 
-  if ((ethertype != htons (ETHERNET_TYPE_IP4)) &&
-      (ethertype != htons (ETHERNET_TYPE_IP6)))
-    return (bond_load_balance_l2 (vm, node, bif, b0, slave_count));
+      n_left -= 1;
+      b += 1;
+      h += 1;
+    }
+}
 
-  ip4 = (ip4_header_t *) (ethertype_p + 1);
-  ip_version = (ip4->ip_version_and_header_length >> 4);
+static_always_inline void
+bond_hash_to_port (u32 * h, u32 n_left, u32 n_members,
+                  int use_modulo_shortcut)
+{
+  u32 mask = n_members - 1;
 
-  if (ip_version == 0x4)
+  while (n_left > 4)
     {
-      u32 a, c;
-
-      mac1 = (u32 *) & eth->dst_address[0];
-      mac2 = (u32 *) & eth->dst_address[4];
-      mac3 = (u32 *) & eth->src_address[2];
-
-      a = clib_mem_unaligned (mac1, u32) ^ clib_mem_unaligned (mac2, u32) ^
-       clib_mem_unaligned (mac3, u32);
-      c =
-       lb_hash_hash_2_tuples (clib_mem_unaligned (&ip4->address_pair, u64),
-                              a);
-      if (BOND_MODULO_SHORTCUT (slave_count))
-       return (c & (slave_count - 1));
+      if (use_modulo_shortcut)
+       {
+         h[0] &= mask;
+         h[1] &= mask;
+         h[2] &= mask;
+         h[3] &= mask;
+       }
       else
-       return c % slave_count;
+       {
+         h[0] %= n_members;
+         h[1] %= n_members;
+         h[2] %= n_members;
+         h[3] %= n_members;
+       }
+      n_left -= 4;
+      h += 4;
     }
-  else if (ip_version == 0x6)
+  while (n_left)
     {
-      u64 a;
-      u32 c;
-      ip6_header_t *ip6 = (ip6_header_t *) (eth + 1);
-
-      mac1 = (u32 *) & eth->dst_address[0];
-      mac2 = (u32 *) & eth->dst_address[4];
-      mac3 = (u32 *) & eth->src_address[2];
-
-      a = clib_mem_unaligned (mac1, u32) ^ clib_mem_unaligned (mac2, u32) ^
-       clib_mem_unaligned (mac3, u32);
-      c =
-       lb_hash_hash (clib_mem_unaligned
-                     (&ip6->src_address.as_uword[0], uword),
-                     clib_mem_unaligned (&ip6->src_address.as_uword[1],
-                                         uword),
-                     clib_mem_unaligned (&ip6->dst_address.as_uword[0],
-                                         uword),
-                     clib_mem_unaligned (&ip6->dst_address.as_uword[1],
-                                         uword), a);
-      if (BOND_MODULO_SHORTCUT (slave_count))
-       return (c & (slave_count - 1));
+      if (use_modulo_shortcut)
+       h[0] &= mask;
       else
-       return c % slave_count;
+       h[0] %= n_members;
+      n_left -= 1;
+      h += 1;
     }
-  return (bond_load_balance_l2 (vm, node, bif, b0, slave_count));
 }
 
-static_always_inline u32
-bond_load_balance_l34 (vlib_main_t * vm, vlib_node_runtime_t * node,
-                      bond_if_t * bif, vlib_buffer_t * b0, uword slave_count)
+static_always_inline void
+bond_update_sw_if_index (bond_per_thread_data_t * ptd, bond_if_t * bif,
+                        u32 * bi, vlib_buffer_t ** b, u32 * data, u32 n_left,
+                        int single_sw_if_index)
 {
-  ethernet_header_t *eth = (ethernet_header_t *) vlib_buffer_get_current (b0);
-  u8 ip_version;
-  uword is_tcp_udp;
-  ip4_header_t *ip4;
-  u16 ethertype, *ethertype_p;
+  u32 sw_if_index = data[0];
+  u32 *h = data;
 
-  ethertype_p = bond_locate_ethertype (eth);
-  ethertype = clib_mem_unaligned (ethertype_p, u16);
-
-  if ((ethertype != htons (ETHERNET_TYPE_IP4)) &&
-      (ethertype != htons (ETHERNET_TYPE_IP6)))
-    return (bond_load_balance_l2 (vm, node, bif, b0, slave_count));
-
-  ip4 = (ip4_header_t *) (ethertype_p + 1);
-  ip_version = (ip4->ip_version_and_header_length >> 4);
-
-  if (ip_version == 0x4)
+  while (n_left >= 8)
     {
-      u32 a, c, t1, t2;
-      tcp_header_t *tcp = (void *) (ip4 + 1);
-
-      is_tcp_udp = (ip4->protocol == IP_PROTOCOL_TCP) ||
-       (ip4->protocol == IP_PROTOCOL_UDP);
-      t1 = is_tcp_udp ? clib_mem_unaligned (&tcp->src, u16) : 0;
-      t2 = is_tcp_udp ? clib_mem_unaligned (&tcp->dst, u16) : 0;
-      a = t1 ^ t2;
-      c =
-       lb_hash_hash_2_tuples (clib_mem_unaligned (&ip4->address_pair, u64),
-                              a);
-      if (BOND_MODULO_SHORTCUT (slave_count))
-       return (c & (slave_count - 1));
+      // Prefetch next iteration
+      vlib_prefetch_buffer_header (b[4], LOAD);
+      vlib_prefetch_buffer_header (b[5], LOAD);
+      vlib_prefetch_buffer_header (b[6], LOAD);
+      vlib_prefetch_buffer_header (b[7], LOAD);
+
+      if (PREDICT_FALSE (single_sw_if_index))
+       {
+         vnet_buffer (b[0])->sw_if_index[VLIB_TX] = sw_if_index;
+         vnet_buffer (b[1])->sw_if_index[VLIB_TX] = sw_if_index;
+         vnet_buffer (b[2])->sw_if_index[VLIB_TX] = sw_if_index;
+         vnet_buffer (b[3])->sw_if_index[VLIB_TX] = sw_if_index;
+
+         bond_tx_add_to_queue (ptd, 0, bi[0]);
+         bond_tx_add_to_queue (ptd, 0, bi[1]);
+         bond_tx_add_to_queue (ptd, 0, bi[2]);
+         bond_tx_add_to_queue (ptd, 0, bi[3]);
+       }
       else
-       return c % slave_count;
+       {
+         vnet_buffer (b[0])->sw_if_index[VLIB_TX] =
+           *vec_elt_at_index (bif->active_members, h[0]);
+         vnet_buffer (b[1])->sw_if_index[VLIB_TX] =
+           *vec_elt_at_index (bif->active_members, h[1]);
+         vnet_buffer (b[2])->sw_if_index[VLIB_TX] =
+           *vec_elt_at_index (bif->active_members, h[2]);
+         vnet_buffer (b[3])->sw_if_index[VLIB_TX] =
+           *vec_elt_at_index (bif->active_members, h[3]);
+
+         bond_tx_add_to_queue (ptd, h[0], bi[0]);
+         bond_tx_add_to_queue (ptd, h[1], bi[1]);
+         bond_tx_add_to_queue (ptd, h[2], bi[2]);
+         bond_tx_add_to_queue (ptd, h[3], bi[3]);
+       }
+
+      bi += 4;
+      h += 4;
+      b += 4;
+      n_left -= 4;
     }
-  else if (ip_version == 0x6)
+  while (n_left)
     {
-      u64 a;
-      u32 c, t1, t2;
-      ip6_header_t *ip6 = (ip6_header_t *) (eth + 1);
-      tcp_header_t *tcp = (void *) (ip6 + 1);
-
-      is_tcp_udp = 0;
-      if (PREDICT_TRUE ((ip6->protocol == IP_PROTOCOL_TCP) ||
-                       (ip6->protocol == IP_PROTOCOL_UDP)))
+      if (PREDICT_FALSE (single_sw_if_index))
        {
-         is_tcp_udp = 1;
-         tcp = (void *) (ip6 + 1);
+         vnet_buffer (b[0])->sw_if_index[VLIB_TX] = sw_if_index;
+         bond_tx_add_to_queue (ptd, 0, bi[0]);
        }
-      else if (ip6->protocol == IP_PROTOCOL_IP6_HOP_BY_HOP_OPTIONS)
+      else
        {
-         ip6_hop_by_hop_header_t *hbh =
-           (ip6_hop_by_hop_header_t *) (ip6 + 1);
-         if ((hbh->protocol == IP_PROTOCOL_TCP)
-             || (hbh->protocol == IP_PROTOCOL_UDP))
-           {
-             is_tcp_udp = 1;
-             tcp = (tcp_header_t *) ((u8 *) hbh + ((hbh->length + 1) << 3));
-           }
+         vnet_buffer (b[0])->sw_if_index[VLIB_TX] =
+           *vec_elt_at_index (bif->active_members, h[0]);
+         bond_tx_add_to_queue (ptd, h[0], bi[0]);
        }
-      t1 = is_tcp_udp ? clib_mem_unaligned (&tcp->src, u16) : 0;
-      t2 = is_tcp_udp ? clib_mem_unaligned (&tcp->dst, u16) : 0;
-      a = t1 ^ t2;
-      c =
-       lb_hash_hash (clib_mem_unaligned
-                     (&ip6->src_address.as_uword[0], uword),
-                     clib_mem_unaligned (&ip6->src_address.as_uword[1],
-                                         uword),
-                     clib_mem_unaligned (&ip6->dst_address.as_uword[0],
-                                         uword),
-                     clib_mem_unaligned (&ip6->dst_address.as_uword[1],
-                                         uword), a);
-      if (BOND_MODULO_SHORTCUT (slave_count))
-       return (c & (slave_count - 1));
-      else
-       return c % slave_count;
-    }
 
-  return (bond_load_balance_l2 (vm, node, bif, b0, slave_count));
+      bi += 1;
+      h += 1;
+      b += 1;
+      n_left -= 1;
+    }
 }
 
-static_always_inline u32
-bond_load_balance_round_robin (vlib_main_t * vm,
-                              vlib_node_runtime_t * node,
-                              bond_if_t * bif, vlib_buffer_t * b0,
-                              uword slave_count)
+static_always_inline void
+bond_tx_trace (vlib_main_t * vm, vlib_node_runtime_t * node, bond_if_t * bif,
+              vlib_buffer_t ** b, u32 n_left, u32 * h)
 {
-  bif->lb_rr_last_index++;
-  if (BOND_MODULO_SHORTCUT (slave_count))
-    bif->lb_rr_last_index &= slave_count - 1;
-  else
-    bif->lb_rr_last_index %= slave_count;
-
-  return bif->lb_rr_last_index;
-}
+  uword n_trace = vlib_get_trace_count (vm, node);
 
-static_always_inline u32
-bond_load_balance_active_backup (vlib_main_t * vm,
-                                vlib_node_runtime_t * node,
-                                bond_if_t * bif, vlib_buffer_t * b0,
-                                uword slave_count)
-{
-  /* First interface is the active, the rest is backup */
-  return 0;
+  while (n_trace > 0 && n_left > 0)
+    {
+      if (PREDICT_TRUE
+         (vlib_trace_buffer (vm, node, 0, b[0], 0 /* follow_chain */ )))
+       {
+         bond_packet_trace_t *t0;
+         ethernet_header_t *eth;
+
+         vlib_set_trace_count (vm, node, --n_trace);
+         t0 = vlib_add_trace (vm, node, b[0], sizeof (*t0));
+         eth = vlib_buffer_get_current (b[0]);
+         t0->ethernet = *eth;
+         t0->sw_if_index = vnet_buffer (b[0])->sw_if_index[VLIB_TX];
+         if (!h)
+           {
+             t0->bond_sw_if_index =
+               *vec_elt_at_index (bif->active_members, 0);
+           }
+         else
+           {
+             t0->bond_sw_if_index =
+               *vec_elt_at_index (bif->active_members, h[0]);
+             h++;
+           }
+       }
+      b++;
+      n_left--;
+    }
 }
 
-static bond_load_balance_func_t bond_load_balance_table[] = {
-#define _(v,f,s, p) { bond_load_balance_##p },
-  foreach_bond_lb_algo
-#undef _
-};
-
-static uword
-bond_tx_fn (vlib_main_t * vm, vlib_node_runtime_t * node,
-           vlib_frame_t * frame)
+VNET_DEVICE_CLASS_TX_FN (bond_dev_class) (vlib_main_t * vm,
+                                         vlib_node_runtime_t * node,
+                                         vlib_frame_t * frame)
 {
   vnet_interface_output_runtime_t *rund = (void *) node->runtime_data;
   bond_main_t *bm = &bond_main;
+  u16 thread_index = vm->thread_index;
   bond_if_t *bif = pool_elt_at_index (bm->interfaces, rund->dev_instance);
-  u32 bi0, bi1, bi2, bi3;
-  vlib_buffer_t *b0, *b1, *b2, *b3;
+  uword n_members;
+  vlib_buffer_t *bufs[VLIB_FRAME_SIZE];
   u32 *from = vlib_frame_vector_args (frame);
-  u32 n_left_from;
-  ethernet_header_t *eth;
-  u32 port;
-  u32 sw_if_index, sw_if_index1, sw_if_index2, sw_if_index3;
-  bond_packet_trace_t *t0;
-  uword n_trace = vlib_get_trace_count (vm, node);
-  u16 thread_index = vm->thread_index;
+  u32 n_left = frame->n_vectors;
+  u32 hashes[VLIB_FRAME_SIZE], *h;
   vnet_main_t *vnm = vnet_get_main ();
-  u32 *to_next;
-  u32 sif_if_index, sif_if_index1, sif_if_index2, sif_if_index3;
-  vlib_frame_t *f;
-  uword slave_count;
+  bond_per_thread_data_t *ptd = vec_elt_at_index (bm->per_thread_data,
+                                                 thread_index);
+  u32 p, sw_if_index;
 
   if (PREDICT_FALSE (bif->admin_up == 0))
     {
-      vlib_buffer_free (vm, vlib_frame_args (frame), frame->n_vectors);
+      vlib_buffer_free (vm, vlib_frame_vector_args (frame), frame->n_vectors);
       vlib_increment_simple_counter (vnet_main.interface_main.sw_if_counters +
                                     VNET_INTERFACE_COUNTER_DROP,
                                     thread_index, bif->sw_if_index,
@@ -422,283 +487,83 @@ bond_tx_fn (vlib_main_t * vm, vlib_node_runtime_t * node,
       return frame->n_vectors;
     }
 
-  clib_spinlock_lock_if_init (&bif->lockp);
-  slave_count = vec_len (bif->active_slaves);
-  if (PREDICT_FALSE (slave_count == 0))
+  n_members = vec_len (bif->active_members);
+  if (PREDICT_FALSE (n_members == 0))
     {
-      bi0 = from[0];
-      b0 = vlib_get_buffer (vm, bi0);
-      vlib_increment_combined_counter
-       (vnet_main.interface_main.combined_sw_if_counters
-        + VNET_INTERFACE_COUNTER_TX, thread_index, bif->sw_if_index,
-        frame->n_vectors, b0->current_length);
-
-      vlib_buffer_free (vm, vlib_frame_args (frame), frame->n_vectors);
+      vlib_buffer_free (vm, vlib_frame_vector_args (frame), frame->n_vectors);
       vlib_increment_simple_counter (vnet_main.interface_main.sw_if_counters +
                                     VNET_INTERFACE_COUNTER_DROP,
                                     thread_index, bif->sw_if_index,
                                     frame->n_vectors);
-      vlib_error_count (vm, node->node_index, BOND_TX_ERROR_NO_SLAVE,
+      vlib_error_count (vm, node->node_index, BOND_TX_ERROR_NO_MEMBER,
                        frame->n_vectors);
-      clib_spinlock_unlock_if_init (&bif->lockp);
       return frame->n_vectors;
     }
 
-  vec_validate_aligned (bif->per_thread_info[thread_index].frame, slave_count,
-                       CLIB_CACHE_LINE_BYTES);
-
-  /* Number of buffers / pkts */
-  n_left_from = frame->n_vectors;
+  vlib_get_buffers (vm, from, bufs, n_left);
 
-  while (n_left_from > 0)
+  /* active-backup mode, ship everything to first sw if index */
+  if ((bif->lb == BOND_LB_AB) || PREDICT_FALSE (n_members == 1))
     {
-      while (n_left_from >= 4)
-       {
-         u32 next0 = 0, next1 = 0, next2 = 0, next3 = 0;
-         u32 port0 = 0, port1 = 0, port2 = 0, port3 = 0;
+      sw_if_index = *vec_elt_at_index (bif->active_members, 0);
 
-         // Prefetch next iteration
-         if (n_left_from >= 8)
-           {
-             vlib_buffer_t *p4, *p5, *p6, *p7;
-
-             p4 = vlib_get_buffer (vm, from[4]);
-             p5 = vlib_get_buffer (vm, from[5]);
-             p6 = vlib_get_buffer (vm, from[6]);
-             p7 = vlib_get_buffer (vm, from[7]);
-
-             vlib_prefetch_buffer_header (p4, LOAD);
-             vlib_prefetch_buffer_header (p5, LOAD);
-             vlib_prefetch_buffer_header (p6, LOAD);
-             vlib_prefetch_buffer_header (p7, LOAD);
-
-             CLIB_PREFETCH (p4->data, CLIB_CACHE_LINE_BYTES, LOAD);
-             CLIB_PREFETCH (p5->data, CLIB_CACHE_LINE_BYTES, LOAD);
-             CLIB_PREFETCH (p6->data, CLIB_CACHE_LINE_BYTES, LOAD);
-             CLIB_PREFETCH (p7->data, CLIB_CACHE_LINE_BYTES, LOAD);
-           }
-
-         bi0 = from[0];
-         bi1 = from[1];
-         bi2 = from[2];
-         bi3 = from[3];
-
-         b0 = vlib_get_buffer (vm, bi0);
-         b1 = vlib_get_buffer (vm, bi1);
-         b2 = vlib_get_buffer (vm, bi2);
-         b3 = vlib_get_buffer (vm, bi3);
+      bond_tx_trace (vm, node, bif, bufs, frame->n_vectors, 0);
+      bond_update_sw_if_index (ptd, bif, from, bufs, &sw_if_index, n_left,
+                              /* single_sw_if_index */ 1);
+      goto done;
+    }
 
-         VLIB_BUFFER_TRACE_TRAJECTORY_INIT (b0);
-         VLIB_BUFFER_TRACE_TRAJECTORY_INIT (b1);
-         VLIB_BUFFER_TRACE_TRAJECTORY_INIT (b2);
-         VLIB_BUFFER_TRACE_TRAJECTORY_INIT (b3);
+  if (bif->lb == BOND_LB_BC)
+    {
+      sw_if_index = *vec_elt_at_index (bif->active_members, 0);
 
-         sw_if_index = vnet_buffer (b0)->sw_if_index[VLIB_TX];
-         sw_if_index1 = vnet_buffer (b1)->sw_if_index[VLIB_TX];
-         sw_if_index2 = vnet_buffer (b2)->sw_if_index[VLIB_TX];
-         sw_if_index3 = vnet_buffer (b3)->sw_if_index[VLIB_TX];
+      bond_tx_no_hash (vm, bif, bufs, hashes, n_left, n_members, BOND_LB_BC);
+      bond_tx_trace (vm, node, bif, bufs, frame->n_vectors, 0);
+      bond_update_sw_if_index (ptd, bif, from, bufs, &sw_if_index, n_left,
+                              /* single_sw_if_index */ 1);
+      goto done;
+    }
 
-         if (PREDICT_TRUE (slave_count != 1))
-           {
-             port0 =
-               (bond_load_balance_table[bif->lb]).load_balance (vm, node,
-                                                                bif, b0,
-                                                                slave_count);
-             port1 =
-               (bond_load_balance_table[bif->lb]).load_balance (vm, node,
-                                                                bif, b1,
-                                                                slave_count);
-             port2 =
-               (bond_load_balance_table[bif->lb]).load_balance (vm, node,
-                                                                bif, b2,
-                                                                slave_count);
-             port3 =
-               (bond_load_balance_table[bif->lb]).load_balance (vm, node,
-                                                                bif, b3,
-                                                                slave_count);
-           }
+  /* if have at least one member on local numa node, only members on local numa
+     node will transmit pkts when bif->local_numa_only is enabled */
+  if (bif->n_numa_members >= 1)
+    n_members = bif->n_numa_members;
 
-         sif_if_index = *vec_elt_at_index (bif->active_slaves, port0);
-         sif_if_index1 = *vec_elt_at_index (bif->active_slaves, port1);
-         sif_if_index2 = *vec_elt_at_index (bif->active_slaves, port2);
-         sif_if_index3 = *vec_elt_at_index (bif->active_slaves, port3);
-
-         vnet_buffer (b0)->sw_if_index[VLIB_TX] = sif_if_index;
-         vnet_buffer (b1)->sw_if_index[VLIB_TX] = sif_if_index1;
-         vnet_buffer (b2)->sw_if_index[VLIB_TX] = sif_if_index2;
-         vnet_buffer (b3)->sw_if_index[VLIB_TX] = sif_if_index3;
-
-         if (PREDICT_FALSE ((bif->per_thread_info[thread_index].frame[port0]
-                             == 0)))
-           bif->per_thread_info[thread_index].frame[port0] =
-             vnet_get_frame_to_sw_interface (vnm, sif_if_index);
-
-         if (PREDICT_FALSE ((bif->per_thread_info[thread_index].frame[port1]
-                             == 0)))
-           bif->per_thread_info[thread_index].frame[port1] =
-             vnet_get_frame_to_sw_interface (vnm, sif_if_index1);
-
-         if (PREDICT_FALSE ((bif->per_thread_info[thread_index].frame[port2]
-                             == 0)))
-           bif->per_thread_info[thread_index].frame[port2] =
-             vnet_get_frame_to_sw_interface (vnm, sif_if_index2);
-
-         if (PREDICT_FALSE ((bif->per_thread_info[thread_index].frame[port3]
-                             == 0)))
-           bif->per_thread_info[thread_index].frame[port3] =
-             vnet_get_frame_to_sw_interface (vnm, sif_if_index3);
-
-         f = bif->per_thread_info[thread_index].frame[port0];
-         to_next = vlib_frame_vector_args (f);
-         to_next += f->n_vectors;
-         to_next[0] = vlib_get_buffer_index (vm, b0);
-         f->n_vectors++;
+  if (bif->lb == BOND_LB_RR)
+    bond_tx_no_hash (vm, bif, bufs, hashes, n_left, n_members, BOND_LB_RR);
+  else
+    bond_tx_hash (vm, ptd, bif, bufs, hashes, n_left);
 
-         f = bif->per_thread_info[thread_index].frame[port1];
-         to_next = vlib_frame_vector_args (f);
-         to_next += f->n_vectors;
-         to_next[0] = vlib_get_buffer_index (vm, b1);
-         f->n_vectors++;
+  /* calculate port out of hash */
+  h = hashes;
+  if (BOND_MODULO_SHORTCUT (n_members))
+    bond_hash_to_port (h, frame->n_vectors, n_members, 1);
+  else
+    bond_hash_to_port (h, frame->n_vectors, n_members, 0);
 
-         f = bif->per_thread_info[thread_index].frame[port2];
-         to_next = vlib_frame_vector_args (f);
-         to_next += f->n_vectors;
-         to_next[0] = vlib_get_buffer_index (vm, b2);
-         f->n_vectors++;
+  bond_tx_trace (vm, node, bif, bufs, frame->n_vectors, h);
 
-         f = bif->per_thread_info[thread_index].frame[port3];
-         to_next = vlib_frame_vector_args (f);
-         to_next += f->n_vectors;
-         to_next[0] = vlib_get_buffer_index (vm, b3);
-         f->n_vectors++;
+  bond_update_sw_if_index (ptd, bif, from, bufs, hashes, frame->n_vectors,
+                          /* single_sw_if_index */ 0);
 
-         if (PREDICT_FALSE (n_trace > 0))
-           {
-             vlib_trace_buffer (vm, node, next0, b0, 0 /* follow_chain */ );
-             vlib_set_trace_count (vm, node, --n_trace);
-             t0 = vlib_add_trace (vm, node, b0, sizeof (*t0));
-             eth = (ethernet_header_t *) vlib_buffer_get_current (b0);
-             t0->ethernet = *eth;
-             t0->sw_if_index = sw_if_index;
-             t0->bond_sw_if_index = vnet_buffer (b0)->sw_if_index[VLIB_TX];
-
-             if (PREDICT_TRUE (n_trace > 0))
-               {
-                 vlib_trace_buffer (vm, node, next1, b1,
-                                    0 /* follow_chain */ );
-                 vlib_set_trace_count (vm, node, --n_trace);
-                 t0 = vlib_add_trace (vm, node, b1, sizeof (*t0));
-                 eth = (ethernet_header_t *) vlib_buffer_get_current (b1);
-                 t0->ethernet = *eth;
-                 t0->sw_if_index = sw_if_index1;
-                 t0->bond_sw_if_index =
-                   vnet_buffer (b1)->sw_if_index[VLIB_TX];
-
-                 if (PREDICT_TRUE (n_trace > 0))
-                   {
-                     vlib_trace_buffer (vm, node, next2, b2,
-                                        0 /* follow_chain */ );
-                     vlib_set_trace_count (vm, node, --n_trace);
-                     t0 = vlib_add_trace (vm, node, b2, sizeof (*t0));
-                     eth =
-                       (ethernet_header_t *) vlib_buffer_get_current (b2);
-                     t0->ethernet = *eth;
-                     t0->sw_if_index = sw_if_index2;
-                     t0->bond_sw_if_index =
-                       vnet_buffer (b2)->sw_if_index[VLIB_TX];
-
-                     if (PREDICT_TRUE (n_trace > 0))
-                       {
-                         vlib_trace_buffer (vm, node, next3, b3,
-                                            0 /* follow_chain */ );
-                         vlib_set_trace_count (vm, node, --n_trace);
-                         t0 = vlib_add_trace (vm, node, b3, sizeof (*t0));
-                         eth =
-                           (ethernet_header_t *)
-                           vlib_buffer_get_current (b3);
-                         t0->ethernet = *eth;
-                         t0->sw_if_index = sw_if_index3;
-                         t0->bond_sw_if_index =
-                           vnet_buffer (b3)->sw_if_index[VLIB_TX];
-                       }
-                   }
-               }
-           }
-         from += 4;
-         n_left_from -= 4;
-       }
+done:
+  for (p = 0; p < n_members; p++)
+    {
+      vlib_frame_t *f;
+      u32 *to_next;
 
-      while (n_left_from > 0)
+      sw_if_index = *vec_elt_at_index (bif->active_members, p);
+      if (PREDICT_TRUE (ptd->per_port_queue[p].n_buffers))
        {
-         u32 next0 = 0;
-         u32 port0 = 0;
-
-         // Prefetch next iteration
-         if (n_left_from > 1)
-           {
-             vlib_buffer_t *p2;
-
-             p2 = vlib_get_buffer (vm, from[1]);
-             vlib_prefetch_buffer_header (p2, LOAD);
-             CLIB_PREFETCH (p2->data, CLIB_CACHE_LINE_BYTES, LOAD);
-           }
-
-         bi0 = from[0];
-         b0 = vlib_get_buffer (vm, bi0);
-
-         VLIB_BUFFER_TRACE_TRAJECTORY_INIT (b0);
-
-         sw_if_index = vnet_buffer (b0)->sw_if_index[VLIB_TX];
-
-         if (PREDICT_TRUE (slave_count != 1))
-           port0 =
-             (bond_load_balance_table[bif->lb]).load_balance (vm, node, bif,
-                                                              b0,
-                                                              slave_count);
-         sif_if_index = *vec_elt_at_index (bif->active_slaves, port0);
-         vnet_buffer (b0)->sw_if_index[VLIB_TX] = sif_if_index;
-         if (PREDICT_FALSE
-             ((bif->per_thread_info[thread_index].frame[port0] == 0)))
-           bif->per_thread_info[thread_index].frame[port0] =
-             vnet_get_frame_to_sw_interface (vnm, sif_if_index);
-         f = bif->per_thread_info[thread_index].frame[port0];
+         f = vnet_get_frame_to_sw_interface (vnm, sw_if_index);
+         f->n_vectors = ptd->per_port_queue[p].n_buffers;
          to_next = vlib_frame_vector_args (f);
-         to_next += f->n_vectors;
-         to_next[0] = vlib_get_buffer_index (vm, b0);
-         f->n_vectors++;
-
-         if (PREDICT_FALSE (n_trace > 0))
-           {
-             vlib_trace_buffer (vm, node, next0, b0, 0 /* follow_chain */ );
-             vlib_set_trace_count (vm, node, --n_trace);
-             t0 = vlib_add_trace (vm, node, b0, sizeof (*t0));
-             eth = (ethernet_header_t *) vlib_buffer_get_current (b0);
-             t0->ethernet = *eth;
-             t0->sw_if_index = sw_if_index;
-             t0->bond_sw_if_index = vnet_buffer (b0)->sw_if_index[VLIB_TX];
-           }
-
-         from += 1;
-         n_left_from -= 1;
+         clib_memcpy_fast (to_next, ptd->per_port_queue[p].buffers,
+                           f->n_vectors * sizeof (u32));
+         vnet_put_frame_to_sw_interface (vnm, sw_if_index, f);
+         ptd->per_port_queue[p].n_buffers = 0;
        }
     }
-
-  for (port = 0; port < slave_count; port++)
-    {
-      f = bif->per_thread_info[thread_index].frame[port];
-      if (f == 0)
-       continue;
-
-      sw_if_index = *vec_elt_at_index (bif->active_slaves, port);
-      vnet_put_frame_to_sw_interface (vnm, sw_if_index, f);
-      bif->per_thread_info[thread_index].frame[port] = 0;
-    }
-
-  vlib_increment_simple_counter (vnet_main.interface_main.sw_if_counters
-                                + VNET_INTERFACE_COUNTER_TX, thread_index,
-                                bif->sw_if_index, frame->n_vectors);
-
-  clib_spinlock_unlock_if_init (&bif->lockp);
   return frame->n_vectors;
 }
 
@@ -708,8 +573,10 @@ bond_active_interface_switch_cb (vnet_main_t * vnm, u32 sw_if_index,
 {
   bond_main_t *bm = &bond_main;
 
-  send_ip4_garp (bm->vlib_main, sw_if_index);
-  send_ip6_na (bm->vlib_main, sw_if_index);
+  ip4_neighbor_advertise (bm->vlib_main, bm->vnet_main, sw_if_index,
+                         vlib_get_thread_index (), NULL);
+  ip6_neighbor_advertise (bm->vlib_main, bm->vnet_main, sw_if_index,
+                         vlib_get_thread_index (), NULL);
 
   return (WALK_CONTINUE);
 }
@@ -731,38 +598,53 @@ bond_process (vlib_main_t * vm, vlib_node_runtime_t * rt, vlib_frame_t * f)
       for (i = 0; i < vec_len (event_data); i++)
        {
          hw_if_index = event_data[i];
-         /* walk hw interface to process all subinterfaces */
-         vnet_hw_interface_walk_sw (vnm, hw_if_index,
-                                    bond_active_interface_switch_cb, 0);
+         if (vnet_get_hw_interface_or_null (vnm, hw_if_index))
+           /* walk hw interface to process all subinterfaces */
+           vnet_hw_interface_walk_sw (vnm, hw_if_index,
+                                      bond_active_interface_switch_cb, 0);
        }
       vec_reset_length (event_data);
     }
   return 0;
 }
 
-/* *INDENT-OFF* */
 VLIB_REGISTER_NODE (bond_process_node) = {
   .function = bond_process,
+  .flags = VLIB_NODE_FLAG_TRACE_SUPPORTED,
   .type = VLIB_NODE_TYPE_PROCESS,
   .name = "bond-process",
 };
-/* *INDENT-ON* */
 
-/* *INDENT-OFF* */
 VNET_DEVICE_CLASS (bond_dev_class) = {
   .name = "bond",
-  .tx_function = bond_tx_fn,
   .tx_function_n_errors = BOND_TX_N_ERROR,
   .tx_function_error_strings = bond_tx_error_strings,
   .format_device_name = format_bond_interface_name,
   .set_l2_mode_function = bond_set_l2_mode_function,
   .admin_up_down_function = bond_interface_admin_up_down,
-  .subif_add_del_function = bond_subif_add_del_function,
   .format_tx_trace = format_bond_tx_trace,
+  .mac_addr_add_del_function = bond_add_del_mac_address,
 };
 
-VLIB_DEVICE_TX_FUNCTION_MULTIARCH (bond_dev_class, bond_tx_fn)
-/* *INDENT-ON* */
+
+static clib_error_t *
+bond_member_interface_add_del (vnet_main_t * vnm, u32 sw_if_index, u32 is_add)
+{
+  bond_main_t *bm = &bond_main;
+  member_if_t *mif;
+  bond_detach_member_args_t args = { 0 };
+
+  if (is_add)
+    return 0;
+  mif = bond_get_member_by_sw_if_index (sw_if_index);
+  if (!mif)
+    return 0;
+  args.member = sw_if_index;
+  bond_detach_member (bm->vlib_main, &args);
+  return args.error;
+}
+
+VNET_SW_INTERFACE_ADD_DEL_FUNCTION (bond_member_interface_add_del);
 
 /*
  * fd.io coding-style-patch-verification: ON