bond: ping fails between l2 BD [VPP-1238]
[vpp.git] / src / vnet / bonding / device.c
index 8f9b3a9..a275240 100644 (file)
@@ -73,6 +73,48 @@ format_bond_interface_name (u8 * s, va_list * args)
   return s;
 }
 
+static __clib_unused clib_error_t *
+bond_set_l2_mode_function (vnet_main_t * vnm,
+                          struct vnet_hw_interface_t *bif_hw,
+                          i32 l2_if_adjust)
+{
+  bond_if_t *bif;
+  u32 *sw_if_index;
+  struct vnet_hw_interface_t *sif_hw;
+
+  bif = bond_get_master_by_sw_if_index (bif_hw->sw_if_index);
+  if (!bif)
+    return 0;
+
+  if ((bif_hw->l2_if_count == 1) && (l2_if_adjust == 1))
+    {
+      /* Just added first L2 interface on this port */
+      vec_foreach (sw_if_index, bif->slaves)
+      {
+       sif_hw = vnet_get_sup_hw_interface (vnm, *sw_if_index);
+       ethernet_set_flags (vnm, sif_hw->hw_if_index,
+                           ETHERNET_INTERFACE_FLAG_ACCEPT_ALL);
+
+       /* ensure all packets go to ethernet-input */
+       ethernet_set_rx_redirect (vnm, sif_hw, 1);
+      }
+    }
+  else if ((bif_hw->l2_if_count == 0) && (l2_if_adjust == -1))
+    {
+      /* Just removed last L2 subinterface on this port */
+      vec_foreach (sw_if_index, bif->slaves)
+      {
+       sif_hw = vnet_get_sup_hw_interface (vnm, *sw_if_index);
+       ethernet_set_flags (vnm, sif_hw->hw_if_index, 0);
+
+       /* Allow ip packets to go directly to ip4-input etc */
+       ethernet_set_rx_redirect (vnm, sif_hw, 0);
+      }
+    }
+
+  return 0;
+}
+
 static __clib_unused clib_error_t *
 bond_subif_add_del_function (vnet_main_t * vnm, u32 hw_if_index,
                             struct vnet_sw_interface_t *st, int is_add)
@@ -98,20 +140,24 @@ bond_interface_admin_up_down (vnet_main_t * vnm, u32 hw_if_index, u32 flags)
 
 static inline u32
 bond_load_balance_broadcast (vlib_main_t * vm, vlib_node_runtime_t * node,
-                            bond_if_t * bif, vlib_buffer_t * b0)
+                            bond_if_t * bif, vlib_buffer_t * b0,
+                            uword slave_count)
 {
   vnet_main_t *vnm = vnet_get_main ();
   vlib_buffer_t *c0;
-  int i;
+  int port;
   u32 *to_next = 0;
   u32 sw_if_index;
   vlib_frame_t *f;
+  u16 thread_index = vlib_get_thread_index ();
 
-
-  for (i = 1; i < vec_len (bif->active_slaves); i++)
+  for (port = 1; port < slave_count; port++)
     {
-      sw_if_index = *vec_elt_at_index (bif->active_slaves, i);
-      f = vnet_get_frame_to_sw_interface (vnm, sw_if_index);
+      sw_if_index = *vec_elt_at_index (bif->active_slaves, port);
+      if (bif->per_thread_info[thread_index].frame[port] == 0)
+       bif->per_thread_info[thread_index].frame[port] =
+         vnet_get_frame_to_sw_interface (vnm, sw_if_index);
+      f = bif->per_thread_info[thread_index].frame[port];
       to_next = vlib_frame_vector_args (f);
       to_next += f->n_vectors;
       c0 = vlib_buffer_copy (vm, b0);
@@ -120,7 +166,6 @@ bond_load_balance_broadcast (vlib_main_t * vm, vlib_node_runtime_t * node,
          vnet_buffer (c0)->sw_if_index[VLIB_TX] = sw_if_index;
          to_next[0] = vlib_get_buffer_index (vm, c0);
          f->n_vectors++;
-         vnet_put_frame_to_sw_interface (vnm, sw_if_index, f);
        }
     }
 
@@ -129,7 +174,7 @@ bond_load_balance_broadcast (vlib_main_t * vm, vlib_node_runtime_t * node,
 
 static inline u32
 bond_load_balance_l2 (vlib_main_t * vm, vlib_node_runtime_t * node,
-                     bond_if_t * bif, vlib_buffer_t * b0)
+                     bond_if_t * bif, vlib_buffer_t * b0, uword slave_count)
 {
   ethernet_header_t *eth = (ethernet_header_t *) vlib_buffer_get_current (b0);
   u32 a = 0, b = 0, c = 0, t1, t2;
@@ -146,7 +191,7 @@ bond_load_balance_l2 (vlib_main_t * vm, vlib_node_runtime_t * node,
   hash_v3_mix32 (a, b, c);
   hash_v3_finalize32 (a, b, c);
 
-  return c % vec_len (bif->active_slaves);
+  return c % slave_count;
 }
 
 static inline u16 *
@@ -174,7 +219,7 @@ bond_locate_ethertype (ethernet_header_t * eth)
 
 static inline u32
 bond_load_balance_l23 (vlib_main_t * vm, vlib_node_runtime_t * node,
-                      bond_if_t * bif, vlib_buffer_t * b0)
+                      bond_if_t * bif, vlib_buffer_t * b0, uword slave_count)
 {
   ethernet_header_t *eth = (ethernet_header_t *) vlib_buffer_get_current (b0);
   u8 ip_version;
@@ -186,7 +231,7 @@ bond_load_balance_l23 (vlib_main_t * vm, vlib_node_runtime_t * node,
 
   if ((ethertype != htons (ETHERNET_TYPE_IP4)) &&
       (ethertype != htons (ETHERNET_TYPE_IP6)))
-    return (bond_load_balance_l2 (vm, node, bif, b0));
+    return (bond_load_balance_l2 (vm, node, bif, b0, slave_count));
 
   ip4 = (ip4_header_t *) (ethertype_p + 1);
   ip_version = (ip4->ip_version_and_header_length >> 4);
@@ -209,7 +254,7 @@ bond_load_balance_l23 (vlib_main_t * vm, vlib_node_runtime_t * node,
       hash_v3_mix32 (a, b, c);
       hash_v3_finalize32 (a, b, c);
 
-      return c % vec_len (bif->active_slaves);
+      return c % slave_count;
     }
   else if (ip_version == 0x6)
     {
@@ -225,14 +270,14 @@ bond_load_balance_l23 (vlib_main_t * vm, vlib_node_runtime_t * node,
       c = (ip6->dst_address.as_u64[0] ^ ip6->dst_address.as_u64[1]);
 
       hash_mix64 (a, b, c);
-      return c % vec_len (bif->active_slaves);
+      return c % slave_count;
     }
-  return (bond_load_balance_l2 (vm, node, bif, b0));
+  return (bond_load_balance_l2 (vm, node, bif, b0, slave_count));
 }
 
 static inline u32
 bond_load_balance_l34 (vlib_main_t * vm, vlib_node_runtime_t * node,
-                      bond_if_t * bif, vlib_buffer_t * b0)
+                      bond_if_t * bif, vlib_buffer_t * b0, uword slave_count)
 {
   ethernet_header_t *eth = (ethernet_header_t *) vlib_buffer_get_current (b0);
   u8 ip_version;
@@ -245,7 +290,7 @@ bond_load_balance_l34 (vlib_main_t * vm, vlib_node_runtime_t * node,
 
   if ((ethertype != htons (ETHERNET_TYPE_IP4)) &&
       (ethertype != htons (ETHERNET_TYPE_IP6)))
-    return (bond_load_balance_l2 (vm, node, bif, b0));
+    return (bond_load_balance_l2 (vm, node, bif, b0, slave_count));
 
   ip4 = (ip4_header_t *) (ethertype_p + 1);
   ip_version = (ip4->ip_version_and_header_length >> 4);
@@ -266,7 +311,7 @@ bond_load_balance_l34 (vlib_main_t * vm, vlib_node_runtime_t * node,
       hash_v3_mix32 (a, b, c);
       hash_v3_finalize32 (a, b, c);
 
-      return c % vec_len (bif->active_slaves);
+      return c % slave_count;
     }
   else if (ip_version == 0x6)
     {
@@ -300,19 +345,20 @@ bond_load_balance_l34 (vlib_main_t * vm, vlib_node_runtime_t * node,
       c = (t2 << 16) | t1;
       hash_mix64 (a, b, c);
 
-      return c % vec_len (bif->active_slaves);
+      return c % slave_count;
     }
 
-  return (bond_load_balance_l2 (vm, node, bif, b0));
+  return (bond_load_balance_l2 (vm, node, bif, b0, slave_count));
 }
 
 static inline u32
 bond_load_balance_round_robin (vlib_main_t * vm,
                               vlib_node_runtime_t * node,
-                              bond_if_t * bif, vlib_buffer_t * b0)
+                              bond_if_t * bif, vlib_buffer_t * b0,
+                              uword slave_count)
 {
   bif->lb_rr_last_index++;
-  bif->lb_rr_last_index %= vec_len (bif->active_slaves);
+  bif->lb_rr_last_index %= slave_count;
 
   return bif->lb_rr_last_index;
 }
@@ -320,7 +366,8 @@ bond_load_balance_round_robin (vlib_main_t * vm,
 static inline u32
 bond_load_balance_active_backup (vlib_main_t * vm,
                                 vlib_node_runtime_t * node,
-                                bond_if_t * bif, vlib_buffer_t * b0)
+                                bond_if_t * bif, vlib_buffer_t * b0,
+                                uword slave_count)
 {
   /* First interface is the active, the rest is backup */
   return 0;
@@ -351,9 +398,10 @@ bond_tx_fn (vlib_main_t * vm, vlib_node_runtime_t * node,
   uword n_trace = vlib_get_trace_count (vm, node);
   u16 thread_index = vlib_get_thread_index ();
   vnet_main_t *vnm = vnet_get_main ();
-  u32 *to_next, *to_next1, *to_next2, *to_next3;
+  u32 *to_next;
   u32 sif_if_index, sif_if_index1, sif_if_index2, sif_if_index3;
-  vlib_frame_t *f, *f1, *f2, *f3;
+  vlib_frame_t *f;
+  uword slave_count;
 
   if (PREDICT_FALSE (bif->admin_up == 0))
     {
@@ -367,7 +415,9 @@ bond_tx_fn (vlib_main_t * vm, vlib_node_runtime_t * node,
       return frame->n_vectors;
     }
 
-  if (PREDICT_FALSE (vec_len (bif->active_slaves) == 0))
+  clib_spinlock_lock_if_init (&bif->lockp);
+  slave_count = vec_len (bif->active_slaves);
+  if (PREDICT_FALSE (slave_count == 0))
     {
       bi0 = from[0];
       b0 = vlib_get_buffer (vm, bi0);
@@ -383,206 +433,245 @@ bond_tx_fn (vlib_main_t * vm, vlib_node_runtime_t * node,
                                     frame->n_vectors);
       vlib_error_count (vm, node->node_index, BOND_TX_ERROR_NO_SLAVE,
                        frame->n_vectors);
+      clib_spinlock_unlock_if_init (&bif->lockp);
       return frame->n_vectors;
     }
 
+  vec_validate_aligned (bif->per_thread_info[thread_index].frame, slave_count,
+                       CLIB_CACHE_LINE_BYTES);
+
   /* Number of buffers / pkts */
   n_left_from = frame->n_vectors;
 
-  while (n_left_from >= 8)
+  while (n_left_from > 0)
     {
-      // Prefetch next iteration
-      {
-       vlib_buffer_t *p4, *p5, *p6, *p7;
-
-       p4 = vlib_get_buffer (vm, from[4]);
-       p5 = vlib_get_buffer (vm, from[5]);
-       p6 = vlib_get_buffer (vm, from[6]);
-       p7 = vlib_get_buffer (vm, from[7]);
-
-       vlib_prefetch_buffer_header (p4, STORE);
-       vlib_prefetch_buffer_header (p5, STORE);
-       vlib_prefetch_buffer_header (p6, STORE);
-       vlib_prefetch_buffer_header (p7, STORE);
-
-       CLIB_PREFETCH (p4->data, CLIB_CACHE_LINE_BYTES, LOAD);
-       CLIB_PREFETCH (p5->data, CLIB_CACHE_LINE_BYTES, LOAD);
-       CLIB_PREFETCH (p6->data, CLIB_CACHE_LINE_BYTES, LOAD);
-       CLIB_PREFETCH (p7->data, CLIB_CACHE_LINE_BYTES, LOAD);
-      }
+      while (n_left_from >= 4)
+       {
+         // Prefetch next iteration
+         if (n_left_from >= 8)
+           {
+             vlib_buffer_t *p4, *p5, *p6, *p7;
+
+             p4 = vlib_get_buffer (vm, from[4]);
+             p5 = vlib_get_buffer (vm, from[5]);
+             p6 = vlib_get_buffer (vm, from[6]);
+             p7 = vlib_get_buffer (vm, from[7]);
+
+             vlib_prefetch_buffer_header (p4, STORE);
+             vlib_prefetch_buffer_header (p5, STORE);
+             vlib_prefetch_buffer_header (p6, STORE);
+             vlib_prefetch_buffer_header (p7, STORE);
+
+             CLIB_PREFETCH (p4->data, CLIB_CACHE_LINE_BYTES, LOAD);
+             CLIB_PREFETCH (p5->data, CLIB_CACHE_LINE_BYTES, LOAD);
+             CLIB_PREFETCH (p6->data, CLIB_CACHE_LINE_BYTES, LOAD);
+             CLIB_PREFETCH (p7->data, CLIB_CACHE_LINE_BYTES, LOAD);
+           }
 
-      bi0 = from[0];
-      bi1 = from[1];
-      bi2 = from[2];
-      bi3 = from[3];
+         bi0 = from[0];
+         bi1 = from[1];
+         bi2 = from[2];
+         bi3 = from[3];
+
+         b0 = vlib_get_buffer (vm, bi0);
+         b1 = vlib_get_buffer (vm, bi1);
+         b2 = vlib_get_buffer (vm, bi2);
+         b3 = vlib_get_buffer (vm, bi3);
+
+         VLIB_BUFFER_TRACE_TRAJECTORY_INIT (b0);
+         VLIB_BUFFER_TRACE_TRAJECTORY_INIT (b1);
+         VLIB_BUFFER_TRACE_TRAJECTORY_INIT (b2);
+         VLIB_BUFFER_TRACE_TRAJECTORY_INIT (b3);
+
+         sw_if_index = vnet_buffer (b0)->sw_if_index[VLIB_TX];
+         sw_if_index1 = vnet_buffer (b1)->sw_if_index[VLIB_TX];
+         sw_if_index2 = vnet_buffer (b2)->sw_if_index[VLIB_TX];
+         sw_if_index3 = vnet_buffer (b3)->sw_if_index[VLIB_TX];
+
+         port =
+           (bond_load_balance_table[bif->lb]).load_balance (vm, node, bif,
+                                                            b0, slave_count);
+         port1 =
+           (bond_load_balance_table[bif->lb]).load_balance (vm, node, bif,
+                                                            b1, slave_count);
+         port2 =
+           (bond_load_balance_table[bif->lb]).load_balance (vm, node, bif,
+                                                            b2, slave_count);
+         port3 =
+           (bond_load_balance_table[bif->lb]).load_balance (vm, node, bif,
+                                                            b3, slave_count);
+
+         sif_if_index = *vec_elt_at_index (bif->active_slaves, port);
+         sif_if_index1 = *vec_elt_at_index (bif->active_slaves, port1);
+         sif_if_index2 = *vec_elt_at_index (bif->active_slaves, port2);
+         sif_if_index3 = *vec_elt_at_index (bif->active_slaves, port3);
+
+         vnet_buffer (b0)->sw_if_index[VLIB_TX] = sif_if_index;
+         vnet_buffer (b1)->sw_if_index[VLIB_TX] = sif_if_index1;
+         vnet_buffer (b2)->sw_if_index[VLIB_TX] = sif_if_index2;
+         vnet_buffer (b3)->sw_if_index[VLIB_TX] = sif_if_index3;
+
+         if (bif->per_thread_info[thread_index].frame[port] == 0)
+           bif->per_thread_info[thread_index].frame[port] =
+             vnet_get_frame_to_sw_interface (vnm, sif_if_index);
+
+         if (bif->per_thread_info[thread_index].frame[port1] == 0)
+           bif->per_thread_info[thread_index].frame[port1] =
+             vnet_get_frame_to_sw_interface (vnm, sif_if_index1);
+
+         if (bif->per_thread_info[thread_index].frame[port2] == 0)
+           bif->per_thread_info[thread_index].frame[port2] =
+             vnet_get_frame_to_sw_interface (vnm, sif_if_index2);
+
+         if (bif->per_thread_info[thread_index].frame[port3] == 0)
+           bif->per_thread_info[thread_index].frame[port3] =
+             vnet_get_frame_to_sw_interface (vnm, sif_if_index3);
+
+         f = bif->per_thread_info[thread_index].frame[port];
+         to_next = vlib_frame_vector_args (f);
+         to_next += f->n_vectors;
+         to_next[0] = vlib_get_buffer_index (vm, b0);
+         f->n_vectors++;
 
-      b0 = vlib_get_buffer (vm, bi0);
-      b1 = vlib_get_buffer (vm, bi1);
-      b2 = vlib_get_buffer (vm, bi2);
-      b3 = vlib_get_buffer (vm, bi3);
-
-      VLIB_BUFFER_TRACE_TRAJECTORY_INIT (b0);
-      VLIB_BUFFER_TRACE_TRAJECTORY_INIT (b1);
-      VLIB_BUFFER_TRACE_TRAJECTORY_INIT (b2);
-      VLIB_BUFFER_TRACE_TRAJECTORY_INIT (b3);
-
-      sw_if_index = vnet_buffer (b0)->sw_if_index[VLIB_TX];
-      sw_if_index1 = vnet_buffer (b1)->sw_if_index[VLIB_TX];
-      sw_if_index2 = vnet_buffer (b2)->sw_if_index[VLIB_TX];
-      sw_if_index3 = vnet_buffer (b3)->sw_if_index[VLIB_TX];
-
-      port =
-       (bond_load_balance_table[bif->lb]).load_balance (vm, node, bif, b0);
-      port1 =
-       (bond_load_balance_table[bif->lb]).load_balance (vm, node, bif, b1);
-      port2 =
-       (bond_load_balance_table[bif->lb]).load_balance (vm, node, bif, b2);
-      port3 =
-       (bond_load_balance_table[bif->lb]).load_balance (vm, node, bif, b3);
-
-      sif_if_index = *vec_elt_at_index (bif->active_slaves, port);
-      sif_if_index1 = *vec_elt_at_index (bif->active_slaves, port1);
-      sif_if_index2 = *vec_elt_at_index (bif->active_slaves, port2);
-      sif_if_index3 = *vec_elt_at_index (bif->active_slaves, port3);
-
-      vnet_buffer (b0)->sw_if_index[VLIB_TX] = sif_if_index;
-      vnet_buffer (b1)->sw_if_index[VLIB_TX] = sif_if_index1;
-      vnet_buffer (b2)->sw_if_index[VLIB_TX] = sif_if_index2;
-      vnet_buffer (b3)->sw_if_index[VLIB_TX] = sif_if_index3;
-
-      f = vnet_get_frame_to_sw_interface (vnm, sif_if_index);
-      f1 = vnet_get_frame_to_sw_interface (vnm, sif_if_index1);
-      f2 = vnet_get_frame_to_sw_interface (vnm, sif_if_index2);
-      f3 = vnet_get_frame_to_sw_interface (vnm, sif_if_index3);
+         f = bif->per_thread_info[thread_index].frame[port1];
+         to_next = vlib_frame_vector_args (f);
+         to_next += f->n_vectors;
+         to_next[0] = vlib_get_buffer_index (vm, b1);
+         f->n_vectors++;
 
-      to_next = vlib_frame_vector_args (f);
-      to_next1 = vlib_frame_vector_args (f1);
-      to_next2 = vlib_frame_vector_args (f2);
-      to_next3 = vlib_frame_vector_args (f3);
+         f = bif->per_thread_info[thread_index].frame[port2];
+         to_next = vlib_frame_vector_args (f);
+         to_next += f->n_vectors;
+         to_next[0] = vlib_get_buffer_index (vm, b2);
+         f->n_vectors++;
 
-      to_next += f->n_vectors;
-      to_next1 += f1->n_vectors;
-      to_next2 += f2->n_vectors;
-      to_next3 += f3->n_vectors;
-
-      to_next[0] = vlib_get_buffer_index (vm, b0);
-      to_next1[0] = vlib_get_buffer_index (vm, b1);
-      to_next2[0] = vlib_get_buffer_index (vm, b2);
-      to_next3[0] = vlib_get_buffer_index (vm, b3);
-
-      f->n_vectors++;
-      f1->n_vectors++;
-      f2->n_vectors++;
-      f3->n_vectors++;
-
-      vnet_put_frame_to_sw_interface (vnm, sif_if_index, f);
-      vnet_put_frame_to_sw_interface (vnm, sif_if_index1, f1);
-      vnet_put_frame_to_sw_interface (vnm, sif_if_index2, f2);
-      vnet_put_frame_to_sw_interface (vnm, sif_if_index3, f3);
-
-      if (PREDICT_FALSE (n_trace > 0))
-       {
-         vlib_trace_buffer (vm, node, next0, b0, 0 /* follow_chain */ );
-         vlib_set_trace_count (vm, node, --n_trace);
-         t0 = vlib_add_trace (vm, node, b0, sizeof (*t0));
-         eth = (ethernet_header_t *) vlib_buffer_get_current (b0);
-         t0->ethernet = *eth;
-         t0->sw_if_index = sw_if_index;
-         t0->bond_sw_if_index = vnet_buffer (b0)->sw_if_index[VLIB_TX];
-
-         if (PREDICT_TRUE (n_trace > 0))
+         f = bif->per_thread_info[thread_index].frame[port3];
+         to_next = vlib_frame_vector_args (f);
+         to_next += f->n_vectors;
+         to_next[0] = vlib_get_buffer_index (vm, b3);
+         f->n_vectors++;
+
+         if (PREDICT_FALSE (n_trace > 0))
            {
-             vlib_trace_buffer (vm, node, next1, b1, 0 /* follow_chain */ );
+             vlib_trace_buffer (vm, node, next0, b0, 0 /* follow_chain */ );
              vlib_set_trace_count (vm, node, --n_trace);
-             t0 = vlib_add_trace (vm, node, b1, sizeof (*t0));
-             eth = (ethernet_header_t *) vlib_buffer_get_current (b1);
+             t0 = vlib_add_trace (vm, node, b0, sizeof (*t0));
+             eth = (ethernet_header_t *) vlib_buffer_get_current (b0);
              t0->ethernet = *eth;
-             t0->sw_if_index = sw_if_index1;
-             t0->bond_sw_if_index = vnet_buffer (b1)->sw_if_index[VLIB_TX];
+             t0->sw_if_index = sw_if_index;
+             t0->bond_sw_if_index = vnet_buffer (b0)->sw_if_index[VLIB_TX];
 
              if (PREDICT_TRUE (n_trace > 0))
                {
-                 vlib_trace_buffer (vm, node, next2, b2,
+                 vlib_trace_buffer (vm, node, next1, b1,
                                     0 /* follow_chain */ );
                  vlib_set_trace_count (vm, node, --n_trace);
-                 t0 = vlib_add_trace (vm, node, b2, sizeof (*t0));
-                 eth = (ethernet_header_t *) vlib_buffer_get_current (b2);
+                 t0 = vlib_add_trace (vm, node, b1, sizeof (*t0));
+                 eth = (ethernet_header_t *) vlib_buffer_get_current (b1);
                  t0->ethernet = *eth;
-                 t0->sw_if_index = sw_if_index2;
+                 t0->sw_if_index = sw_if_index1;
                  t0->bond_sw_if_index =
-                   vnet_buffer (b2)->sw_if_index[VLIB_TX];
+                   vnet_buffer (b1)->sw_if_index[VLIB_TX];
 
                  if (PREDICT_TRUE (n_trace > 0))
                    {
-                     vlib_trace_buffer (vm, node, next3, b3,
+                     vlib_trace_buffer (vm, node, next2, b2,
                                         0 /* follow_chain */ );
                      vlib_set_trace_count (vm, node, --n_trace);
-                     t0 = vlib_add_trace (vm, node, b3, sizeof (*t0));
+                     t0 = vlib_add_trace (vm, node, b2, sizeof (*t0));
                      eth =
-                       (ethernet_header_t *) vlib_buffer_get_current (b3);
+                       (ethernet_header_t *) vlib_buffer_get_current (b2);
                      t0->ethernet = *eth;
-                     t0->sw_if_index = sw_if_index3;
+                     t0->sw_if_index = sw_if_index2;
                      t0->bond_sw_if_index =
-                       vnet_buffer (b3)->sw_if_index[VLIB_TX];
+                       vnet_buffer (b2)->sw_if_index[VLIB_TX];
+
+                     if (PREDICT_TRUE (n_trace > 0))
+                       {
+                         vlib_trace_buffer (vm, node, next3, b3,
+                                            0 /* follow_chain */ );
+                         vlib_set_trace_count (vm, node, --n_trace);
+                         t0 = vlib_add_trace (vm, node, b3, sizeof (*t0));
+                         eth =
+                           (ethernet_header_t *)
+                           vlib_buffer_get_current (b3);
+                         t0->ethernet = *eth;
+                         t0->sw_if_index = sw_if_index3;
+                         t0->bond_sw_if_index =
+                           vnet_buffer (b3)->sw_if_index[VLIB_TX];
+                       }
                    }
                }
            }
+         from += 4;
+         n_left_from -= 4;
        }
 
-      from += 4;
-      n_left_from -= 4;
-    }
-
-  while (n_left_from > 0)
-    {
-      // Prefetch next iteration
-      if (n_left_from > 1)
+      while (n_left_from > 0)
        {
-         vlib_buffer_t *p2;
-
-         p2 = vlib_get_buffer (vm, from[1]);
-         vlib_prefetch_buffer_header (p2, STORE);
-         CLIB_PREFETCH (p2->data, CLIB_CACHE_LINE_BYTES, LOAD);
-       }
-
-      bi0 = from[0];
-      b0 = vlib_get_buffer (vm, bi0);
-
-      VLIB_BUFFER_TRACE_TRAJECTORY_INIT (b0);
+         // Prefetch next iteration
+         if (n_left_from > 1)
+           {
+             vlib_buffer_t *p2;
 
-      sw_if_index = vnet_buffer (b0)->sw_if_index[VLIB_TX];
+             p2 = vlib_get_buffer (vm, from[1]);
+             vlib_prefetch_buffer_header (p2, STORE);
+             CLIB_PREFETCH (p2->data, CLIB_CACHE_LINE_BYTES, LOAD);
+           }
 
-      port =
-       (bond_load_balance_table[bif->lb]).load_balance (vm, node, bif, b0);
-      sif_if_index = *vec_elt_at_index (bif->active_slaves, port);
-      vnet_buffer (b0)->sw_if_index[VLIB_TX] = sif_if_index;
-      f = vnet_get_frame_to_sw_interface (vnm, sif_if_index);
-      to_next = vlib_frame_vector_args (f);
-      to_next += f->n_vectors;
+         bi0 = from[0];
+         b0 = vlib_get_buffer (vm, bi0);
+
+         VLIB_BUFFER_TRACE_TRAJECTORY_INIT (b0);
+
+         sw_if_index = vnet_buffer (b0)->sw_if_index[VLIB_TX];
+
+         port =
+           (bond_load_balance_table[bif->lb]).load_balance (vm, node, bif,
+                                                            b0, slave_count);
+         sif_if_index = *vec_elt_at_index (bif->active_slaves, port);
+         vnet_buffer (b0)->sw_if_index[VLIB_TX] = sif_if_index;
+         if (bif->per_thread_info[thread_index].frame[port] == 0)
+           bif->per_thread_info[thread_index].frame[port] =
+             vnet_get_frame_to_sw_interface (vnm, sif_if_index);
+         f = bif->per_thread_info[thread_index].frame[port];
+         to_next = vlib_frame_vector_args (f);
+         to_next += f->n_vectors;
+         to_next[0] = vlib_get_buffer_index (vm, b0);
+         f->n_vectors++;
 
-      to_next[0] = vlib_get_buffer_index (vm, b0);
-      f->n_vectors++;
-      vnet_put_frame_to_sw_interface (vnm, sif_if_index, f);
+         if (PREDICT_FALSE (n_trace > 0))
+           {
+             vlib_trace_buffer (vm, node, next0, b0, 0 /* follow_chain */ );
+             vlib_set_trace_count (vm, node, --n_trace);
+             t0 = vlib_add_trace (vm, node, b0, sizeof (*t0));
+             eth = (ethernet_header_t *) vlib_buffer_get_current (b0);
+             t0->ethernet = *eth;
+             t0->sw_if_index = sw_if_index;
+             t0->bond_sw_if_index = vnet_buffer (b0)->sw_if_index[VLIB_TX];
+           }
 
-      if (PREDICT_FALSE (n_trace > 0))
-       {
-         vlib_trace_buffer (vm, node, next0, b0, 0 /* follow_chain */ );
-         vlib_set_trace_count (vm, node, --n_trace);
-         t0 = vlib_add_trace (vm, node, b0, sizeof (*t0));
-         eth = (ethernet_header_t *) vlib_buffer_get_current (b0);
-         t0->ethernet = *eth;
-         t0->sw_if_index = sw_if_index;
-         t0->bond_sw_if_index = vnet_buffer (b0)->sw_if_index[VLIB_TX];
+         from += 1;
+         n_left_from -= 1;
        }
+    }
+
+  for (port = 0; port < slave_count; port++)
+    {
+      f = bif->per_thread_info[thread_index].frame[port];
+      if (f == 0)
+       continue;
 
-      from += 1;
-      n_left_from -= 1;
+      sw_if_index = *vec_elt_at_index (bif->active_slaves, port);
+      vnet_put_frame_to_sw_interface (vnm, sw_if_index, f);
+      bif->per_thread_info[thread_index].frame[port] = 0;
     }
 
   vlib_increment_simple_counter (vnet_main.interface_main.sw_if_counters
                                 + VNET_INTERFACE_COUNTER_TX, thread_index,
                                 bif->sw_if_index, frame->n_vectors);
 
+  clib_spinlock_unlock_if_init (&bif->lockp);
   return frame->n_vectors;
 }
 
@@ -593,6 +682,7 @@ VNET_DEVICE_CLASS (bond_dev_class) = {
   .tx_function_n_errors = BOND_TX_N_ERROR,
   .tx_function_error_strings = bond_tx_error_strings,
   .format_device_name = format_bond_interface_name,
+  .set_l2_mode_function = bond_set_l2_mode_function,
   .admin_up_down_function = bond_interface_admin_up_down,
   .subif_add_del_function = bond_subif_add_del_function,
   .format_tx_trace = format_bond_tx_trace,