hs-test: added filenames to test names
[vpp.git] / src / vnet / gso / node.c
index 663f9cc..c1d4459 100644 (file)
 #include <vnet/ip/ip6.h>
 #include <vnet/udp/udp_packet.h>
 
+#define foreach_gso_error                                                     \
+  _ (NO_BUFFERS, "no buffers to segment GSO")                                 \
+  _ (UNHANDLED_TYPE, "unhandled gso type")
+
+static char *gso_error_strings[] = {
+#define _(sym, string) string,
+  foreach_gso_error
+#undef _
+};
+
+typedef enum
+{
+#define _(sym, str) GSO_ERROR_##sym,
+  foreach_gso_error
+#undef _
+    GSO_N_ERROR,
+} gso_error_t;
+
+typedef enum
+{
+  GSO_NEXT_DROP,
+  GSO_N_NEXT,
+} gso_next_t;
+
 typedef struct
 {
   u32 flags;
@@ -42,14 +66,14 @@ format_gso_trace (u8 * s, va_list * args)
 
   if (t->flags & VNET_BUFFER_F_GSO)
     {
-      s = format (s, "gso_sz %d gso_l4_hdr_sz %d %U",
+      s = format (s, "gso_sz %d gso_l4_hdr_sz %d\n%U",
                  t->gso_size, t->gso_l4_hdr_sz, format_generic_header_offset,
                  &t->gho);
     }
   else
     {
       s =
-       format (s, "non-gso buffer %U", format_generic_header_offset,
+       format (s, "non-gso buffer\n%U", format_generic_header_offset,
                &t->gho);
     }
 
@@ -57,74 +81,107 @@ format_gso_trace (u8 * s, va_list * args)
 }
 
 static_always_inline void
-tso_segment_vxlan_tunnel_headers_fixup (vlib_main_t * vm, vlib_buffer_t * b,
-                                       generic_header_offset_t * gho)
+tso_segment_ipip_tunnel_fixup (vlib_main_t *vm,
+                              vnet_interface_per_thread_data_t *ptd,
+                              vlib_buffer_t *sb0)
+{
+  u16 n_tx_bufs = vec_len (ptd->split_buffers);
+  u16 i = 0;
+
+  while (i < n_tx_bufs)
+    {
+      vlib_buffer_t *b0 = vlib_get_buffer (vm, ptd->split_buffers[i]);
+      i16 outer_l3_hdr_offset = vnet_buffer2 (b0)->outer_l3_hdr_offset;
+      i16 l3_hdr_offset = vnet_buffer (b0)->l3_hdr_offset;
+
+      ip4_header_t *ip4 = (ip4_header_t *) (b0->data + outer_l3_hdr_offset);
+      ip6_header_t *ip6 = (ip6_header_t *) (b0->data + outer_l3_hdr_offset);
+
+      if (vnet_buffer (b0)->oflags & VNET_BUFFER_OFFLOAD_F_OUTER_IP_CKSUM)
+       {
+         ip4->length = clib_host_to_net_u16 (
+           b0->current_length - (outer_l3_hdr_offset - b0->current_data));
+         ip4->checksum = ip4_header_checksum (ip4);
+         vnet_buffer_offload_flags_clear (
+           b0, VNET_BUFFER_OFFLOAD_F_OUTER_IP_CKSUM |
+                 VNET_BUFFER_OFFLOAD_F_TNL_IPIP);
+       }
+      else
+       {
+         ip6->payload_length = clib_host_to_net_u16 (
+           b0->current_length - (l3_hdr_offset - b0->current_data));
+         vnet_buffer_offload_flags_clear (b0, VNET_BUFFER_OFFLOAD_F_TNL_IPIP);
+       }
+
+      i++;
+    }
+}
+
+static_always_inline void
+tso_segment_vxlan_tunnel_headers_fixup (vlib_main_t *vm, vlib_buffer_t *b)
 {
-  u8 proto = 0;
   ip4_header_t *ip4 = 0;
   ip6_header_t *ip6 = 0;
   udp_header_t *udp = 0;
+  i16 outer_l3_hdr_offset = vnet_buffer2 (b)->outer_l3_hdr_offset;
+  i16 outer_l4_hdr_offset = vnet_buffer2 (b)->outer_l4_hdr_offset;
 
-  ip4 =
-    (ip4_header_t *) (vlib_buffer_get_current (b) + gho->outer_l3_hdr_offset);
-  ip6 =
-    (ip6_header_t *) (vlib_buffer_get_current (b) + gho->outer_l3_hdr_offset);
-  udp =
-    (udp_header_t *) (vlib_buffer_get_current (b) + gho->outer_l4_hdr_offset);
+  ip4 = (ip4_header_t *) (b->data + outer_l3_hdr_offset);
+  ip6 = (ip6_header_t *) (b->data + outer_l3_hdr_offset);
+  udp = (udp_header_t *) (b->data + outer_l4_hdr_offset);
 
-  if (gho->gho_flags & GHO_F_OUTER_IP4)
+  if (vnet_buffer (b)->oflags & VNET_BUFFER_OFFLOAD_F_OUTER_IP_CKSUM)
     {
-      proto = ip4->protocol;
-      ip4->length =
-       clib_host_to_net_u16 (b->current_length - gho->outer_l3_hdr_offset);
+      ip4->length = clib_host_to_net_u16 (
+       b->current_length - (outer_l3_hdr_offset - b->current_data));
       ip4->checksum = ip4_header_checksum (ip4);
+      if (vnet_buffer (b)->oflags & VNET_BUFFER_OFFLOAD_F_OUTER_UDP_CKSUM)
+       {
+         udp->length = clib_host_to_net_u16 (
+           b->current_length - (outer_l4_hdr_offset - b->current_data));
+         // udp checksum is 0, in udp tunnel
+         udp->checksum = 0;
+       }
+      vnet_buffer_offload_flags_clear (
+       b, VNET_BUFFER_OFFLOAD_F_OUTER_IP_CKSUM |
+            VNET_BUFFER_OFFLOAD_F_OUTER_UDP_CKSUM |
+            VNET_BUFFER_OFFLOAD_F_TNL_VXLAN);
     }
-  else if (gho->gho_flags & GHO_F_OUTER_IP6)
-    {
-      proto = ip6->protocol;
-      ip6->payload_length =
-       clib_host_to_net_u16 (b->current_length - gho->outer_l4_hdr_offset);
-    }
-  if (proto == IP_PROTOCOL_UDP)
+  else
     {
-      int bogus;
-      udp->length =
-       clib_host_to_net_u16 (b->current_length - gho->outer_l4_hdr_offset);
-      udp->checksum = 0;
-      if (gho->gho_flags & GHO_F_OUTER_IP6)
+      ip6->payload_length = clib_host_to_net_u16 (
+       b->current_length - (outer_l4_hdr_offset - b->current_data));
+
+      if (vnet_buffer (b)->oflags & VNET_BUFFER_OFFLOAD_F_OUTER_UDP_CKSUM)
        {
+         int bogus;
+         udp->length = ip6->payload_length;
+         // udp checksum is 0, in udp tunnel
+         udp->checksum = 0;
          udp->checksum =
            ip6_tcp_udp_icmp_compute_checksum (vm, b, ip6, &bogus);
+         vnet_buffer_offload_flags_clear (
+           b, VNET_BUFFER_OFFLOAD_F_OUTER_UDP_CKSUM |
+                VNET_BUFFER_OFFLOAD_F_TNL_VXLAN);
        }
-      else if (gho->gho_flags & GHO_F_OUTER_IP4)
-       {
-         udp->checksum = ip4_tcp_udp_compute_checksum (vm, b, ip4);
-       }
-      b->flags &= ~VNET_BUFFER_F_OFFLOAD_UDP_CKSUM;
     }
 }
 
-static_always_inline u16
-tso_segment_vxlan_tunnel_fixup (vlib_main_t * vm,
-                               vnet_interface_per_thread_data_t * ptd,
-                               vlib_buffer_t * sb0,
-                               generic_header_offset_t * gho)
+static_always_inline void
+tso_segment_vxlan_tunnel_fixup (vlib_main_t *vm,
+                               vnet_interface_per_thread_data_t *ptd,
+                               vlib_buffer_t *sb0)
 {
   u16 n_tx_bufs = vec_len (ptd->split_buffers);
-  u16 i = 0, n_tx_bytes = 0;
+  u16 i = 0;
 
   while (i < n_tx_bufs)
     {
       vlib_buffer_t *b0 = vlib_get_buffer (vm, ptd->split_buffers[i]);
-      vnet_get_outer_header (b0, gho);
-      clib_memcpy_fast (vlib_buffer_get_current (b0),
-                       vlib_buffer_get_current (sb0), gho->outer_hdr_sz);
 
-      tso_segment_vxlan_tunnel_headers_fixup (vm, b0, gho);
-      n_tx_bytes += gho->outer_hdr_sz;
+      tso_segment_vxlan_tunnel_headers_fixup (vm, b0);
       i++;
     }
-  return n_tx_bytes;
 }
 
 static_always_inline u16
@@ -177,14 +234,22 @@ static_always_inline void
 tso_init_buf_from_template_base (vlib_buffer_t * nb0, vlib_buffer_t * b0,
                                 u32 flags, u16 length)
 {
+  /* copying objects from cacheline 0 */
   nb0->current_data = b0->current_data;
-  nb0->total_length_not_including_first_buffer = 0;
+  nb0->current_length = length;
   nb0->flags = VLIB_BUFFER_TOTAL_LENGTH_VALID | flags;
-  nb0->trace_handle = b0->trace_handle;
+  nb0->flow_id = b0->flow_id;
+  nb0->error = b0->error;
+  nb0->current_config_index = b0->current_config_index;
   clib_memcpy_fast (&nb0->opaque, &b0->opaque, sizeof (nb0->opaque));
+
+  /* copying objects from cacheline 1 */
+  nb0->trace_handle = b0->trace_handle;
+  nb0->total_length_not_including_first_buffer = 0;
+
+  /* copying data */
   clib_memcpy_fast (vlib_buffer_get_current (nb0),
                    vlib_buffer_get_current (b0), length);
-  nb0->current_length = length;
 }
 
 static_always_inline void
@@ -209,8 +274,7 @@ tso_init_buf_from_template (vlib_main_t * vm, vlib_buffer_t * nb0,
 
 static_always_inline void
 tso_fixup_segmented_buf (vlib_main_t * vm, vlib_buffer_t * b0, u8 tcp_flags,
-                        int is_ip6, generic_header_offset_t * gho,
-                        u32 do_csums)
+                        int is_l2, int is_ip6, generic_header_offset_t * gho)
 {
   ip4_header_t *ip4 =
     (ip4_header_t *) (vlib_buffer_get_current (b0) + gho->l3_hdr_offset);
@@ -224,34 +288,43 @@ tso_fixup_segmented_buf (vlib_main_t * vm, vlib_buffer_t * b0, u8 tcp_flags,
   if (is_ip6)
     {
       ip6->payload_length =
-       clib_host_to_net_u16 (b0->current_length -
-                             (gho->l4_hdr_offset - gho->l2_hdr_offset));
-      if (do_csums && (b0->flags & VNET_BUFFER_F_OFFLOAD_TCP_CKSUM))
+       clib_host_to_net_u16 (b0->current_length - gho->l4_hdr_offset);
+      if (gho->gho_flags & GHO_F_TCP)
        {
          int bogus = 0;
          tcp->checksum = 0;
          tcp->checksum =
            ip6_tcp_udp_icmp_compute_checksum (vm, b0, ip6, &bogus);
-         b0->flags &= ~VNET_BUFFER_F_OFFLOAD_TCP_CKSUM;
+         vnet_buffer_offload_flags_clear (b0,
+                                          VNET_BUFFER_OFFLOAD_F_TCP_CKSUM);
        }
     }
   else
     {
       ip4->length =
-       clib_host_to_net_u16 (b0->current_length -
-                             (gho->l3_hdr_offset - gho->l2_hdr_offset));
-      if (do_csums)
+       clib_host_to_net_u16 (b0->current_length - gho->l3_hdr_offset);
+      if (gho->gho_flags & GHO_F_IP4)
+       ip4->checksum = ip4_header_checksum (ip4);
+      if (gho->gho_flags & GHO_F_TCP)
        {
-         if (b0->flags & VNET_BUFFER_F_OFFLOAD_IP_CKSUM)
-           ip4->checksum = ip4_header_checksum (ip4);
-         if (b0->flags & VNET_BUFFER_F_OFFLOAD_TCP_CKSUM)
-           {
-             tcp->checksum = 0;
-             tcp->checksum = ip4_tcp_udp_compute_checksum (vm, b0, ip4);
-           }
-         b0->flags &= ~VNET_BUFFER_F_OFFLOAD_TCP_CKSUM;
-         b0->flags &= ~VNET_BUFFER_F_OFFLOAD_IP_CKSUM;
+         tcp->checksum = 0;
+         tcp->checksum = ip4_tcp_udp_compute_checksum (vm, b0, ip4);
        }
+      vnet_buffer_offload_flags_clear (b0, (VNET_BUFFER_OFFLOAD_F_IP_CKSUM |
+                                           VNET_BUFFER_OFFLOAD_F_TCP_CKSUM));
+    }
+
+  if (!is_l2 && ((gho->gho_flags & GHO_F_TUNNEL) == 0))
+    {
+      u32 adj_index0 = vnet_buffer (b0)->ip.adj_index[VLIB_TX];
+
+      ip_adjacency_t *adj0 = adj_get (adj_index0);
+
+      if (adj0->lookup_next_index == IP_LOOKUP_NEXT_MIDCHAIN &&
+         adj0->sub_type.midchain.fixup_func)
+       /* calls e.g. ipip44_fixup */
+       adj0->sub_type.midchain.fixup_func
+         (vm, adj0, b0, adj0->sub_type.midchain.fixup_data);
     }
 }
 
@@ -267,8 +340,8 @@ tso_fixup_segmented_buf (vlib_main_t * vm, vlib_buffer_t * b0, u8 tcp_flags,
 static_always_inline u32
 tso_segment_buffer (vlib_main_t * vm, vnet_interface_per_thread_data_t * ptd,
                    u32 sbi0, vlib_buffer_t * sb0,
-                   generic_header_offset_t * gho, u32 n_bytes_b0, int is_ip6,
-                   u32 do_csums)
+                   generic_header_offset_t * gho, u32 n_bytes_b0, int is_l2,
+                   int is_ip6)
 {
   u32 n_tx_bytes = 0;
   u16 gso_size = vnet_buffer2 (sb0)->gso_size;
@@ -316,8 +389,8 @@ tso_segment_buffer (vlib_main_t * vm, vnet_interface_per_thread_data_t * ptd,
       src_ptr = vlib_buffer_get_current (sb0) + l234_sz + first_data_size;
       src_left = sb0->current_length - l234_sz - first_data_size;
 
-      tso_fixup_segmented_buf (vm, b0, tcp_flags_no_fin_psh, is_ip6, gho,
-                              do_csums);
+      tso_fixup_segmented_buf (vm, b0, tcp_flags_no_fin_psh, is_l2, is_ip6,
+                              gho);
 
       /* grab a second buffer and prepare the loop */
       ASSERT (dbi < vec_len (ptd->split_buffers));
@@ -366,8 +439,8 @@ tso_segment_buffer (vlib_main_t * vm, vnet_interface_per_thread_data_t * ptd,
          if (0 == dst_left && total_src_left)
            {
              n_tx_bytes += cdb0->current_length;
-             tso_fixup_segmented_buf (vm, cdb0, tcp_flags_no_fin_psh, is_ip6,
-                                      gho, do_csums);
+             tso_fixup_segmented_buf (vm, cdb0, tcp_flags_no_fin_psh, is_l2,
+                                      is_ip6, gho);
              ASSERT (dbi < vec_len (ptd->split_buffers));
              cdb0 = vlib_get_buffer (vm, ptd->split_buffers[dbi++]);
              tso_init_buf_from_template (vm, cdb0, b0, l234_sz,
@@ -376,8 +449,7 @@ tso_segment_buffer (vlib_main_t * vm, vnet_interface_per_thread_data_t * ptd,
            }
        }
 
-      tso_fixup_segmented_buf (vm, cdb0, save_tcp_flags, is_ip6, gho,
-                              do_csums);
+      tso_fixup_segmented_buf (vm, cdb0, save_tcp_flags, is_l2, is_ip6, gho);
 
       n_tx_bytes += cdb0->current_length;
     }
@@ -385,6 +457,15 @@ tso_segment_buffer (vlib_main_t * vm, vnet_interface_per_thread_data_t * ptd,
   return n_tx_bytes;
 }
 
+__clib_unused u32
+gso_segment_buffer (vlib_main_t *vm, vnet_interface_per_thread_data_t *ptd,
+                   u32 bi, vlib_buffer_t *b, generic_header_offset_t *gho,
+                   u32 n_bytes_b, u8 is_l2, u8 is_ip6)
+{
+
+  return tso_segment_buffer (vm, ptd, bi, b, gho, n_bytes_b, is_l2, is_ip6);
+}
+
 static_always_inline void
 drop_one_buffer_and_count (vlib_main_t * vm, vnet_main_t * vnm,
                           vlib_node_runtime_t * node, u32 * pbi0,
@@ -400,9 +481,8 @@ drop_one_buffer_and_count (vlib_main_t * vm, vnet_main_t * vnm,
 
   vlib_error_drop_buffers (vm, node, pbi0,
                           /* buffer stride */ 1,
-                          /* n_buffers */ 1,
-                          VNET_INTERFACE_OUTPUT_NEXT_DROP,
-                          node->node_index, drop_error_code);
+                          /* n_buffers */ 1, GSO_NEXT_DROP, node->node_index,
+                          drop_error_code);
 }
 
 static_always_inline uword
@@ -411,7 +491,7 @@ vnet_gso_node_inline (vlib_main_t * vm,
                      vlib_frame_t * frame,
                      vnet_main_t * vnm,
                      vnet_hw_interface_t * hi,
-                     int is_ip6, int do_segmentation)
+                     int is_l2, int is_ip4, int is_ip6, int do_segmentation)
 {
   u32 *to_next;
   u32 next_index = node->cached_next_index;
@@ -464,28 +544,28 @@ vnet_gso_node_inline (vlib_main_t * vm,
            if (PREDICT_FALSE (hi->sw_if_index != swif0))
              {
                hi0 = vnet_get_sup_hw_interface (vnm, swif0);
-               if ((hi0->flags & VNET_HW_INTERFACE_FLAG_SUPPORTS_GSO) == 0 &&
+               if ((hi0->caps & VNET_HW_IF_CAP_TCP_GSO) == 0 &&
                    (b[0]->flags & VNET_BUFFER_F_GSO))
                  break;
              }
            if (PREDICT_FALSE (hi->sw_if_index != swif1))
              {
                hi1 = vnet_get_sup_hw_interface (vnm, swif1);
-               if (!(hi1->flags & VNET_HW_INTERFACE_FLAG_SUPPORTS_GSO) &&
+               if (!(hi1->caps & VNET_HW_IF_CAP_TCP_GSO) &&
                    (b[1]->flags & VNET_BUFFER_F_GSO))
                  break;
              }
            if (PREDICT_FALSE (hi->sw_if_index != swif2))
              {
                hi2 = vnet_get_sup_hw_interface (vnm, swif2);
-               if ((hi2->flags & VNET_HW_INTERFACE_FLAG_SUPPORTS_GSO) == 0 &&
+               if ((hi2->caps & VNET_HW_IF_CAP_TCP_GSO) == 0 &&
                    (b[2]->flags & VNET_BUFFER_F_GSO))
                  break;
              }
            if (PREDICT_FALSE (hi->sw_if_index != swif3))
              {
                hi3 = vnet_get_sup_hw_interface (vnm, swif3);
-               if (!(hi3->flags & VNET_HW_INTERFACE_FLAG_SUPPORTS_GSO) &&
+               if (!(hi3->caps & VNET_HW_IF_CAP_TCP_GSO) &&
                    (b[3]->flags & VNET_BUFFER_F_GSO))
                  break;
              }
@@ -496,7 +576,9 @@ vnet_gso_node_inline (vlib_main_t * vm,
                t0->flags = b[0]->flags & VNET_BUFFER_F_GSO;
                t0->gso_size = vnet_buffer2 (b[0])->gso_size;
                t0->gso_l4_hdr_sz = vnet_buffer2 (b[0])->gso_l4_hdr_sz;
-               vnet_generic_header_offset_parser (b[0], &t0->gho);
+               clib_memset (&t0->gho, 0, sizeof (t0->gho));
+               vnet_generic_header_offset_parser (b[0], &t0->gho, is_l2,
+                                                  is_ip4, is_ip6);
              }
            if (b[1]->flags & VLIB_BUFFER_IS_TRACED)
              {
@@ -504,7 +586,9 @@ vnet_gso_node_inline (vlib_main_t * vm,
                t1->flags = b[1]->flags & VNET_BUFFER_F_GSO;
                t1->gso_size = vnet_buffer2 (b[1])->gso_size;
                t1->gso_l4_hdr_sz = vnet_buffer2 (b[1])->gso_l4_hdr_sz;
-               vnet_generic_header_offset_parser (b[1], &t1->gho);
+               clib_memset (&t1->gho, 0, sizeof (t1->gho));
+               vnet_generic_header_offset_parser (b[1], &t1->gho, is_l2,
+                                                  is_ip4, is_ip6);
              }
            if (b[2]->flags & VLIB_BUFFER_IS_TRACED)
              {
@@ -512,7 +596,9 @@ vnet_gso_node_inline (vlib_main_t * vm,
                t2->flags = b[2]->flags & VNET_BUFFER_F_GSO;
                t2->gso_size = vnet_buffer2 (b[2])->gso_size;
                t2->gso_l4_hdr_sz = vnet_buffer2 (b[2])->gso_l4_hdr_sz;
-               vnet_generic_header_offset_parser (b[2], &t2->gho);
+               clib_memset (&t2->gho, 0, sizeof (t2->gho));
+               vnet_generic_header_offset_parser (b[2], &t2->gho, is_l2,
+                                                  is_ip4, is_ip6);
              }
            if (b[3]->flags & VLIB_BUFFER_IS_TRACED)
              {
@@ -520,7 +606,9 @@ vnet_gso_node_inline (vlib_main_t * vm,
                t3->flags = b[3]->flags & VNET_BUFFER_F_GSO;
                t3->gso_size = vnet_buffer2 (b[3])->gso_size;
                t3->gso_l4_hdr_sz = vnet_buffer2 (b[3])->gso_l4_hdr_sz;
-               vnet_generic_header_offset_parser (b[3], &t3->gho);
+               clib_memset (&t3->gho, 0, sizeof (t3->gho));
+               vnet_generic_header_offset_parser (b[3], &t3->gho, is_l2,
+                                                  is_ip4, is_ip6);
              }
 
            from += 4;
@@ -547,13 +635,12 @@ vnet_gso_node_inline (vlib_main_t * vm,
          vnet_hw_interface_t *hi0;
          u32 next0 = 0;
          u32 do_segmentation0 = 0;
-         u32 do_csums = 0;
 
          swif0 = vnet_buffer (b[0])->sw_if_index[VLIB_TX];
          if (PREDICT_FALSE (hi->sw_if_index != swif0))
            {
              hi0 = vnet_get_sup_hw_interface (vnm, swif0);
-             if ((hi0->flags & VNET_HW_INTERFACE_FLAG_SUPPORTS_GSO) == 0 &&
+             if ((hi0->caps & VNET_HW_IF_CAP_TCP_GSO) == 0 &&
                  (b[0]->flags & VNET_BUFFER_F_GSO))
                do_segmentation0 = 1;
            }
@@ -573,7 +660,9 @@ vnet_gso_node_inline (vlib_main_t * vm,
              t0->flags = b[0]->flags & VNET_BUFFER_F_GSO;
              t0->gso_size = vnet_buffer2 (b[0])->gso_size;
              t0->gso_l4_hdr_sz = vnet_buffer2 (b[0])->gso_l4_hdr_sz;
-             vnet_generic_header_offset_parser (b[0], &t0->gho);
+             clib_memset (&t0->gho, 0, sizeof (t0->gho));
+             vnet_generic_header_offset_parser (b[0], &t0->gho, is_l2,
+                                                is_ip4, is_ip6);
            }
 
          if (do_segmentation0)
@@ -588,54 +677,29 @@ vnet_gso_node_inline (vlib_main_t * vm,
                  to_next -= 1;
                  n_left_to_next += 1;
                  /* undo the counting. */
-                 generic_header_offset_t gho = { 0 };
-                 u32 n_bytes_b0 = vlib_buffer_length_in_chain (vm, b[0]);
                  u32 n_tx_bytes = 0;
 
-                 vnet_generic_header_offset_parser (b[0], &gho);
-
-                 if (PREDICT_FALSE (gho.gho_flags & GHO_F_TUNNEL))
-                   {
-                     if (PREDICT_FALSE
-                         ((gho.gho_flags & GHO_F_VXLAN_TUNNEL) == 0))
-                       {
-                         /* not supported yet */
-                         drop_one_buffer_and_count (vm, vnm, node, from - 1,
-                                                    hi->sw_if_index,
-                                                    VNET_INTERFACE_OUTPUT_ERROR_UNHANDLED_GSO_TYPE);
-                         b += 1;
-                         continue;
-                       }
-
-                     vnet_get_inner_header (b[0], &gho);
-
-                     n_bytes_b0 -= gho.outer_hdr_sz;
-                     /*
-                      * In case of tunnel encapsulated packet, we will
-                      * calculate the checksums for segmented inner packets.
-                      */
-                     do_csums = 1;
-                     is_ip6 = (gho.gho_flags & GHO_F_IP6) != 0;
-                   }
-
                  n_tx_bytes =
-                   tso_segment_buffer (vm, ptd, bi0, b[0], &gho, n_bytes_b0,
-                                       is_ip6, do_csums);
+                   gso_segment_buffer_inline (vm, ptd, b[0], is_l2);
 
                  if (PREDICT_FALSE (n_tx_bytes == 0))
                    {
                      drop_one_buffer_and_count (vm, vnm, node, from - 1,
                                                 hi->sw_if_index,
-                                                VNET_INTERFACE_OUTPUT_ERROR_NO_BUFFERS_FOR_GSO);
+                                                GSO_ERROR_NO_BUFFERS);
                      b += 1;
                      continue;
                    }
 
-                 if (PREDICT_FALSE (gho.gho_flags & GHO_F_VXLAN_TUNNEL))
+                 if (PREDICT_FALSE (vnet_buffer (b[0])->oflags &
+                                    VNET_BUFFER_OFFLOAD_F_TNL_VXLAN))
                    {
-                     vnet_get_outer_header (b[0], &gho);
-                     n_tx_bytes +=
-                       tso_segment_vxlan_tunnel_fixup (vm, ptd, b[0], &gho);
+                     tso_segment_vxlan_tunnel_fixup (vm, ptd, b[0]);
+                   }
+                 else if (PREDICT_FALSE (vnet_buffer (b[0])->oflags &
+                                         VNET_BUFFER_OFFLOAD_F_TNL_IPIP))
+                   {
+                     tso_segment_ipip_tunnel_fixup (vm, ptd, b[0]);
                    }
 
                  u16 n_tx_bufs = vec_len (ptd->split_buffers);
@@ -645,30 +709,7 @@ vnet_gso_node_inline (vlib_main_t * vm,
                    {
                      u32 sbi0;
                      vlib_buffer_t *sb0;
-                     if (n_tx_bufs >= n_left_to_next)
-                       {
-                         while (n_left_to_next > 0)
-                           {
-                             sbi0 = to_next[0] = from_seg[0];
-                             sb0 = vlib_get_buffer (vm, sbi0);
-                             ASSERT (sb0->current_length > 0);
-                             to_next += 1;
-                             from_seg += 1;
-                             n_left_to_next -= 1;
-                             n_tx_bufs -= 1;
-                             vnet_feature_next (&next0, sb0);
-                             vlib_validate_buffer_enqueue_x1 (vm, node,
-                                                              next_index,
-                                                              to_next,
-                                                              n_left_to_next,
-                                                              sbi0, next0);
-                           }
-                         vlib_put_next_frame (vm, node, next_index,
-                                              n_left_to_next);
-                         vlib_get_new_next_frame (vm, node, next_index,
-                                                  to_next, n_left_to_next);
-                       }
-                     while (n_tx_bufs > 0)
+                     while (n_tx_bufs > 0 && n_left_to_next > 0)
                        {
                          sbi0 = to_next[0] = from_seg[0];
                          sb0 = vlib_get_buffer (vm, sbi0);
@@ -677,6 +718,7 @@ vnet_gso_node_inline (vlib_main_t * vm,
                          from_seg += 1;
                          n_left_to_next -= 1;
                          n_tx_bufs -= 1;
+                         next0 = 0;
                          vnet_feature_next (&next0, sb0);
                          vlib_validate_buffer_enqueue_x1 (vm, node,
                                                           next_index,
@@ -684,9 +726,14 @@ vnet_gso_node_inline (vlib_main_t * vm,
                                                           n_left_to_next,
                                                           sbi0, next0);
                        }
+                     vlib_put_next_frame (vm, node, next_index,
+                                          n_left_to_next);
+                     if (n_tx_bufs > 0)
+                       vlib_get_next_frame (vm, node, next_index,
+                                            to_next, n_left_to_next);
                    }
                  /* The buffers were enqueued. Reset the length */
-                 _vec_len (ptd->split_buffers) = 0;
+                 vec_set_len (ptd->split_buffers, 0);
                  /* Free the now segmented buffer */
                  vlib_buffer_free_one (vm, bi0);
                  b += 1;
@@ -707,7 +754,8 @@ vnet_gso_node_inline (vlib_main_t * vm,
 
 static_always_inline uword
 vnet_gso_inline (vlib_main_t * vm,
-                vlib_node_runtime_t * node, vlib_frame_t * frame, int is_ip6)
+                vlib_node_runtime_t * node, vlib_frame_t * frame, int is_l2,
+                int is_ip4, int is_ip6)
 {
   vnet_main_t *vnm = vnet_get_main ();
   vnet_hw_interface_t *hi;
@@ -719,12 +767,14 @@ vnet_gso_inline (vlib_main_t * vm,
       hi = vnet_get_sup_hw_interface (vnm,
                                      vnet_buffer (b)->sw_if_index[VLIB_TX]);
 
-      if (hi->flags & VNET_HW_INTERFACE_FLAG_SUPPORTS_GSO)
+      if (hi->caps & (VNET_HW_IF_CAP_TCP_GSO | VNET_HW_IF_CAP_VXLAN_TNL_GSO))
        return vnet_gso_node_inline (vm, node, frame, vnm, hi,
-                                    is_ip6, /* do_segmentation */ 0);
+                                    is_l2, is_ip4, is_ip6,
+                                    /* do_segmentation */ 0);
       else
        return vnet_gso_node_inline (vm, node, frame, vnm, hi,
-                                    is_ip6, /* do_segmentation */ 1);
+                                    is_l2, is_ip4, is_ip6,
+                                    /* do_segmentation */ 1);
     }
   return 0;
 }
@@ -732,35 +782,42 @@ vnet_gso_inline (vlib_main_t * vm,
 VLIB_NODE_FN (gso_l2_ip4_node) (vlib_main_t * vm, vlib_node_runtime_t * node,
                                vlib_frame_t * frame)
 {
-  return vnet_gso_inline (vm, node, frame, 0 /* ip6 */ );
+  return vnet_gso_inline (vm, node, frame, 1 /* l2 */ , 1 /* ip4 */ ,
+                         0 /* ip6 */ );
 }
 
 VLIB_NODE_FN (gso_l2_ip6_node) (vlib_main_t * vm, vlib_node_runtime_t * node,
                                vlib_frame_t * frame)
 {
-  return vnet_gso_inline (vm, node, frame, 1 /* ip6 */ );
+  return vnet_gso_inline (vm, node, frame, 1 /* l2 */ , 0 /* ip4 */ ,
+                         1 /* ip6 */ );
 }
 
 VLIB_NODE_FN (gso_ip4_node) (vlib_main_t * vm, vlib_node_runtime_t * node,
                             vlib_frame_t * frame)
 {
-  return vnet_gso_inline (vm, node, frame, 0 /* ip6 */ );
+  return vnet_gso_inline (vm, node, frame, 0 /* l2 */ , 1 /* ip4 */ ,
+                         0 /* ip6 */ );
 }
 
 VLIB_NODE_FN (gso_ip6_node) (vlib_main_t * vm, vlib_node_runtime_t * node,
                             vlib_frame_t * frame)
 {
-  return vnet_gso_inline (vm, node, frame, 1 /* ip6 */ );
+  return vnet_gso_inline (vm, node, frame, 0 /* l2 */ , 0 /* ip4 */ ,
+                         1 /* ip6 */ );
 }
 
-/* *INDENT-OFF* */
 
 VLIB_REGISTER_NODE (gso_l2_ip4_node) = {
   .vector_size = sizeof (u32),
   .format_trace = format_gso_trace,
   .type = VLIB_NODE_TYPE_INTERNAL,
-  .n_errors = 0,
-  .n_next_nodes = 0,
+  .n_errors = ARRAY_LEN(gso_error_strings),
+  .error_strings = gso_error_strings,
+  .n_next_nodes = GSO_N_NEXT,
+  .next_nodes = {
+        [GSO_NEXT_DROP] = "error-drop",
+  },
   .name = "gso-l2-ip4",
 };
 
@@ -768,8 +825,12 @@ VLIB_REGISTER_NODE (gso_l2_ip6_node) = {
   .vector_size = sizeof (u32),
   .format_trace = format_gso_trace,
   .type = VLIB_NODE_TYPE_INTERNAL,
-  .n_errors = 0,
-  .n_next_nodes = 0,
+  .n_errors = ARRAY_LEN(gso_error_strings),
+  .error_strings = gso_error_strings,
+  .n_next_nodes = GSO_N_NEXT,
+  .next_nodes = {
+        [GSO_NEXT_DROP] = "error-drop",
+  },
   .name = "gso-l2-ip6",
 };
 
@@ -777,8 +838,12 @@ VLIB_REGISTER_NODE (gso_ip4_node) = {
   .vector_size = sizeof (u32),
   .format_trace = format_gso_trace,
   .type = VLIB_NODE_TYPE_INTERNAL,
-  .n_errors = 0,
-  .n_next_nodes = 0,
+  .n_errors = ARRAY_LEN(gso_error_strings),
+  .error_strings = gso_error_strings,
+  .n_next_nodes = GSO_N_NEXT,
+  .next_nodes = {
+        [GSO_NEXT_DROP] = "error-drop",
+  },
   .name = "gso-ip4",
 };
 
@@ -786,8 +851,12 @@ VLIB_REGISTER_NODE (gso_ip6_node) = {
   .vector_size = sizeof (u32),
   .format_trace = format_gso_trace,
   .type = VLIB_NODE_TYPE_INTERNAL,
-  .n_errors = 0,
-  .n_next_nodes = 0,
+  .n_errors = ARRAY_LEN(gso_error_strings),
+  .error_strings = gso_error_strings,
+  .n_next_nodes = GSO_N_NEXT,
+  .next_nodes = {
+        [GSO_NEXT_DROP] = "error-drop",
+  },
   .name = "gso-ip6",
 };
 
@@ -806,15 +875,13 @@ VNET_FEATURE_INIT (gso_l2_ip6_node, static) = {
 VNET_FEATURE_INIT (gso_ip4_node, static) = {
   .arc_name = "ip4-output",
   .node_name = "gso-ip4",
-  .runs_after = VNET_FEATURES ("ipsec4-output-feature"),
-  .runs_before = VNET_FEATURES ("interface-output"),
+  .runs_before = VNET_FEATURES ("ipsec4-output-feature"),
 };
 
 VNET_FEATURE_INIT (gso_ip6_node, static) = {
   .arc_name = "ip6-output",
   .node_name = "gso-ip6",
-  .runs_after = VNET_FEATURES ("ipsec6-output-feature"),
-  .runs_before = VNET_FEATURES ("interface-output"),
+  .runs_before = VNET_FEATURES ("ipsec6-output-feature"),
 };
 
 /*