IPSEC: API coverity error of unitialised stat_index value
[vpp.git] / src / vnet / interface_output.c
index 03f2cdc..251ff34 100644 (file)
  */
 
 #include <vnet/vnet.h>
+#include <vnet/ip/icmp46_packet.h>
+#include <vnet/ip/ip4.h>
+#include <vnet/ip/ip6.h>
+#include <vnet/udp/udp_packet.h>
 #include <vnet/feature/feature.h>
 
 typedef struct
 {
   u32 sw_if_index;
-  u8 data[128 - sizeof (u32)];
+  u32 flags;
+  u16 gso_size;
+  u8 gso_l4_hdr_sz;
+  u8 data[128 - 3 * sizeof (u32)];
 }
 interface_output_trace_t;
 
@@ -55,7 +62,7 @@ format_vnet_interface_output_trace (u8 * s, va_list * va)
   interface_output_trace_t *t = va_arg (*va, interface_output_trace_t *);
   vnet_main_t *vnm = vnet_get_main ();
   vnet_sw_interface_t *si;
-  uword indent;
+  u32 indent;
 
   if (t->sw_if_index != (u32) ~ 0)
     {
@@ -65,24 +72,30 @@ format_vnet_interface_output_trace (u8 * s, va_list * va)
          (vnm->interface_main.sw_interfaces, t->sw_if_index))
        {
          /* the interface may have been deleted by the time the trace is printed */
-         s = format (s, "sw_if_index: %d\n%U%U",
-                     t->sw_if_index,
-                     format_white_space, indent,
-                     node->format_buffer ? node->
-                     format_buffer : format_hex_bytes, t->data,
-                     sizeof (t->data));
+         s = format (s, "sw_if_index: %d ", t->sw_if_index);
        }
       else
        {
          si = vnet_get_sw_interface (vnm, t->sw_if_index);
-
-         s = format (s, "%U\n%U%U",
-                     format_vnet_sw_interface_name, vnm, si,
-                     format_white_space, indent,
-                     node->format_buffer ? node->
-                     format_buffer : format_hex_bytes, t->data,
-                     sizeof (t->data));
+         s =
+           format (s, "%U ", format_vnet_sw_interface_name, vnm, si,
+                   t->flags);
+       }
+#define _(bit, name, v, x) \
+          if (v && (t->flags & VNET_BUFFER_F_##name)) \
+            s = format (s, "%s ", v);
+      foreach_vnet_buffer_flag
+#undef _
+       if (t->flags & VNET_BUFFER_F_GSO)
+       {
+         s = format (s, "\n%Ugso_sz %d gso_l4_hdr_sz %d",
+                     format_white_space, indent + 2, t->gso_size,
+                     t->gso_l4_hdr_sz);
        }
+      s =
+       format (s, "\n%U%U", format_white_space, indent,
+               node->format_buffer ? node->format_buffer : format_hex_bytes,
+               t->data, sizeof (t->data));
     }
   return s;
 }
@@ -95,7 +108,7 @@ vnet_interface_output_trace (vlib_main_t * vm,
   u32 n_left, *from;
 
   n_left = n_buffers;
-  from = vlib_frame_args (frame);
+  from = vlib_frame_vector_args (frame);
 
   while (n_left >= 4)
     {
@@ -117,15 +130,21 @@ vnet_interface_output_trace (vlib_main_t * vm,
        {
          t0 = vlib_add_trace (vm, node, b0, sizeof (t0[0]));
          t0->sw_if_index = vnet_buffer (b0)->sw_if_index[VLIB_TX];
-         clib_memcpy (t0->data, vlib_buffer_get_current (b0),
-                      sizeof (t0->data));
+         t0->flags = b0->flags;
+         t0->gso_size = vnet_buffer2 (b0)->gso_size;
+         t0->gso_l4_hdr_sz = vnet_buffer2 (b0)->gso_l4_hdr_sz;
+         clib_memcpy_fast (t0->data, vlib_buffer_get_current (b0),
+                           sizeof (t0->data));
        }
       if (b1->flags & VLIB_BUFFER_IS_TRACED)
        {
          t1 = vlib_add_trace (vm, node, b1, sizeof (t1[0]));
          t1->sw_if_index = vnet_buffer (b1)->sw_if_index[VLIB_TX];
-         clib_memcpy (t1->data, vlib_buffer_get_current (b1),
-                      sizeof (t1->data));
+         t1->flags = b1->flags;
+         t1->gso_size = vnet_buffer2 (b1)->gso_size;
+         t1->gso_l4_hdr_sz = vnet_buffer2 (b1)->gso_l4_hdr_sz;
+         clib_memcpy_fast (t1->data, vlib_buffer_get_current (b1),
+                           sizeof (t1->data));
        }
       from += 2;
       n_left -= 2;
@@ -145,301 +164,329 @@ vnet_interface_output_trace (vlib_main_t * vm,
        {
          t0 = vlib_add_trace (vm, node, b0, sizeof (t0[0]));
          t0->sw_if_index = vnet_buffer (b0)->sw_if_index[VLIB_TX];
-         clib_memcpy (t0->data, vlib_buffer_get_current (b0),
-                      sizeof (t0->data));
+         t0->flags = b0->flags;
+         t0->gso_size = vnet_buffer2 (b0)->gso_size;
+         t0->gso_l4_hdr_sz = vnet_buffer2 (b0)->gso_l4_hdr_sz;
+         clib_memcpy_fast (t0->data, vlib_buffer_get_current (b0),
+                           sizeof (t0->data));
        }
       from += 1;
       n_left -= 1;
     }
 }
 
-static never_inline u32
-slow_path (vlib_main_t * vm,
-          u32 bi,
-          vlib_buffer_t * b,
-          u32 n_left_to_tx, u32 * to_tx, u32 * n_slow_bytes_result)
+static_always_inline void
+calc_checksums (vlib_main_t * vm, vlib_buffer_t * b)
 {
-  /* We've already enqueued a single buffer. */
-  u32 n_buffers = 0;
-  u32 n_slow_bytes = 0;
+  ip4_header_t *ip4;
+  ip6_header_t *ip6;
+  tcp_header_t *th;
+  udp_header_t *uh;
 
-  while (n_left_to_tx > 0)
-    {
-      to_tx[0] = bi;
-      to_tx += 1;
-      n_left_to_tx -= 1;
-      n_buffers += 1;
-      n_slow_bytes += vlib_buffer_length_in_chain (vm, b);
-
-      /* Be grumpy about zero length buffers for benefit of
-         driver tx function. */
-      ASSERT (b->current_length > 0);
+  int is_ip4 = (b->flags & VNET_BUFFER_F_IS_IP4) != 0;
+  int is_ip6 = (b->flags & VNET_BUFFER_F_IS_IP6) != 0;
 
-      if (!(b->flags & VLIB_BUFFER_NEXT_PRESENT))
-       break;
+  ASSERT (!(is_ip4 && is_ip6));
 
-      bi = b->next_buffer;
-      b = vlib_get_buffer (vm, bi);
-    }
-
-  /* Ran out of space in next frame trying to enqueue buffers? */
-  if (b->flags & VLIB_BUFFER_NEXT_PRESENT)
-    return 0;
-
-  *n_slow_bytes_result = n_slow_bytes;
-  return n_buffers;
-}
+  ip4 = (ip4_header_t *) (b->data + vnet_buffer (b)->l3_hdr_offset);
+  ip6 = (ip6_header_t *) (b->data + vnet_buffer (b)->l3_hdr_offset);
+  th = (tcp_header_t *) (b->data + vnet_buffer (b)->l4_hdr_offset);
+  uh = (udp_header_t *) (b->data + vnet_buffer (b)->l4_hdr_offset);
 
-/*
- * Increment TX stats. Roll up consecutive increments to the same sw_if_index
- * into one increment.
- */
-static_always_inline void
-incr_output_stats (vnet_main_t * vnm,
-                  u32 cpu_index,
-                  u32 length,
-                  u32 sw_if_index,
-                  u32 * last_sw_if_index, u32 * n_packets, u32 * n_bytes)
-{
-  vnet_interface_main_t *im;
-
-  if (PREDICT_TRUE (sw_if_index == *last_sw_if_index))
+  if (is_ip4)
     {
-      *n_packets += 1;
-      *n_bytes += length;
+      ip4 = (ip4_header_t *) (b->data + vnet_buffer (b)->l3_hdr_offset);
+      if (b->flags & VNET_BUFFER_F_OFFLOAD_IP_CKSUM)
+       ip4->checksum = ip4_header_checksum (ip4);
+      if (b->flags & VNET_BUFFER_F_OFFLOAD_TCP_CKSUM)
+       {
+         th->checksum = 0;
+         th->checksum = ip4_tcp_udp_compute_checksum (vm, b, ip4);
+       }
+      if (b->flags & VNET_BUFFER_F_OFFLOAD_UDP_CKSUM)
+       uh->checksum = ip4_tcp_udp_compute_checksum (vm, b, ip4);
     }
-  else
+  if (is_ip6)
     {
-      if (PREDICT_TRUE (*last_sw_if_index != ~0))
+      int bogus;
+      if (b->flags & VNET_BUFFER_F_OFFLOAD_TCP_CKSUM)
        {
-         im = &vnm->interface_main;
-
-         vlib_increment_combined_counter (im->combined_sw_if_counters
-                                          + VNET_INTERFACE_COUNTER_TX,
-                                          cpu_index,
-                                          *last_sw_if_index,
-                                          *n_packets, *n_bytes);
+         th->checksum = 0;
+         th->checksum =
+           ip6_tcp_udp_icmp_compute_checksum (vm, b, ip6, &bogus);
+       }
+      if (b->flags & VNET_BUFFER_F_OFFLOAD_UDP_CKSUM)
+       {
+         uh->checksum = 0;
+         uh->checksum =
+           ip6_tcp_udp_icmp_compute_checksum (vm, b, ip6, &bogus);
        }
-      *last_sw_if_index = sw_if_index;
-      *n_packets = 1;
-      *n_bytes = length;
     }
-}
 
+  b->flags &= ~VNET_BUFFER_F_OFFLOAD_TCP_CKSUM;
+  b->flags &= ~VNET_BUFFER_F_OFFLOAD_UDP_CKSUM;
+  b->flags &= ~VNET_BUFFER_F_OFFLOAD_IP_CKSUM;
+}
 
-/* Interface output functions. */
-uword
-vnet_interface_output_node_flatten (vlib_main_t * vm,
-                                   vlib_node_runtime_t * node,
-                                   vlib_frame_t * frame)
+static_always_inline u16
+tso_alloc_tx_bufs (vlib_main_t * vm,
+                  vnet_interface_per_thread_data_t * ptd,
+                  vlib_buffer_t * b0, u16 l4_hdr_sz)
 {
-  vnet_main_t *vnm = vnet_get_main ();
-  vnet_interface_output_runtime_t *rt = (void *) node->runtime_data;
-  vnet_sw_interface_t *si;
-  vnet_hw_interface_t *hi;
-  u32 n_left_to_tx, *from, *from_end, *to_tx;
-  u32 n_bytes, n_buffers, n_packets;
-  u32 last_sw_if_index;
-  u32 cpu_index = vm->cpu_index;
+  u32 n_bytes_b0 = vlib_buffer_length_in_chain (vm, b0);
+  u16 gso_size = vnet_buffer2 (b0)->gso_size;
+  u16 l234_sz = vnet_buffer (b0)->l4_hdr_offset + l4_hdr_sz;
+  /* rounded-up division */
+  u16 n_bufs = (n_bytes_b0 - l234_sz + (gso_size - 1)) / gso_size;
+  u16 n_alloc;
+
+  ASSERT (n_bufs > 0);
+  vec_validate (ptd->split_buffers, n_bufs - 1);
+
+  n_alloc = vlib_buffer_alloc (vm, ptd->split_buffers, n_bufs);
+  if (n_alloc < n_bufs)
+    {
+      vlib_buffer_free (vm, ptd->split_buffers, n_alloc);
+      return 0;
+    }
+  return 1;
+}
 
-  n_buffers = frame->n_vectors;
+static_always_inline void
+tso_init_buf_from_template_base (vlib_buffer_t * nb0, vlib_buffer_t * b0,
+                                u32 flags, u16 length)
+{
+  nb0->current_data = 0;
+  nb0->total_length_not_including_first_buffer = 0;
+  nb0->flags = VLIB_BUFFER_TOTAL_LENGTH_VALID | flags;
+  clib_memcpy_fast (&nb0->opaque, &b0->opaque, sizeof (nb0->opaque));
+  clib_memcpy_fast (nb0->data, b0->data, length);
+  nb0->current_length = length;
+}
 
-  if (node->flags & VLIB_NODE_FLAG_TRACE)
-    vnet_interface_output_trace (vm, node, frame, n_buffers);
+static_always_inline void
+tso_init_buf_from_template (vlib_main_t * vm, vlib_buffer_t * nb0,
+                           vlib_buffer_t * b0, u16 template_data_sz,
+                           u16 gso_size, u8 ** p_dst_ptr, u16 * p_dst_left,
+                           u32 next_tcp_seq, u32 flags)
+{
+  tso_init_buf_from_template_base (nb0, b0, flags, template_data_sz);
 
-  from = vlib_frame_args (frame);
+  *p_dst_left =
+    clib_min (gso_size,
+             vlib_buffer_get_default_data_size (vm) - template_data_sz);
+  *p_dst_ptr = nb0->data + template_data_sz;
 
-  if (rt->is_deleted)
-    return vlib_error_drop_buffers (vm, node, from,
-                                   /* buffer stride */ 1,
-                                   n_buffers,
-                                   VNET_INTERFACE_OUTPUT_NEXT_DROP,
-                                   node->node_index,
-                                   VNET_INTERFACE_OUTPUT_ERROR_INTERFACE_DELETED);
+  tcp_header_t *tcp =
+    (tcp_header_t *) (nb0->data + vnet_buffer (nb0)->l4_hdr_offset);
+  tcp->seq_number = clib_host_to_net_u32 (next_tcp_seq);
+}
 
-  si = vnet_get_sw_interface (vnm, rt->sw_if_index);
-  hi = vnet_get_sup_hw_interface (vnm, rt->sw_if_index);
-  if (!(si->flags & VNET_SW_INTERFACE_FLAG_ADMIN_UP) ||
-      !(hi->flags & VNET_HW_INTERFACE_FLAG_LINK_UP))
-    {
-      vlib_simple_counter_main_t *cm;
+static_always_inline void
+tso_fixup_segmented_buf (vlib_buffer_t * b0, u8 tcp_flags, int is_ip6)
+{
+  u16 l3_hdr_offset = vnet_buffer (b0)->l3_hdr_offset;
+  u16 l4_hdr_offset = vnet_buffer (b0)->l4_hdr_offset;
+  ip4_header_t *ip4 = (ip4_header_t *) (b0->data + l3_hdr_offset);
+  ip6_header_t *ip6 = (ip6_header_t *) (b0->data + l3_hdr_offset);
+  tcp_header_t *tcp = (tcp_header_t *) (b0->data + l4_hdr_offset);
+
+  tcp->flags = tcp_flags;
+
+  if (is_ip6)
+    ip6->payload_length =
+      clib_host_to_net_u16 (b0->current_length -
+                           vnet_buffer (b0)->l4_hdr_offset);
+  else
+    ip4->length =
+      clib_host_to_net_u16 (b0->current_length -
+                           vnet_buffer (b0)->l3_hdr_offset);
+}
 
-      cm = vec_elt_at_index (vnm->interface_main.sw_if_counters,
-                            VNET_INTERFACE_COUNTER_TX_ERROR);
-      vlib_increment_simple_counter (cm, cpu_index,
-                                    rt->sw_if_index, n_buffers);
-      return vlib_error_drop_buffers (vm, node, from,
-                                     /* buffer stride */ 1,
-                                     n_buffers,
-                                     VNET_INTERFACE_OUTPUT_NEXT_DROP,
-                                     node->node_index,
-                                     VNET_INTERFACE_OUTPUT_ERROR_INTERFACE_DOWN);
-    }
+/**
+ * Allocate the necessary number of ptd->split_buffers,
+ * and segment the possibly chained buffer(s) from b0 into
+ * there.
+ *
+ * Return the cumulative number of bytes sent or zero
+ * if allocation failed.
+ */
 
-  from_end = from + n_buffers;
+static_always_inline u32
+tso_segment_buffer (vlib_main_t * vm, vnet_interface_per_thread_data_t * ptd,
+                   int do_tx_offloads, u32 sbi0, vlib_buffer_t * sb0,
+                   u32 n_bytes_b0)
+{
+  u32 n_tx_bytes = 0;
+  int is_ip4 = sb0->flags & VNET_BUFFER_F_IS_IP4;
+  int is_ip6 = sb0->flags & VNET_BUFFER_F_IS_IP6;
+  ASSERT (is_ip4 || is_ip6);
+  ASSERT (sb0->flags & VNET_BUFFER_F_L2_HDR_OFFSET_VALID);
+  ASSERT (sb0->flags & VNET_BUFFER_F_L3_HDR_OFFSET_VALID);
+  ASSERT (sb0->flags & VNET_BUFFER_F_L4_HDR_OFFSET_VALID);
+  u16 gso_size = vnet_buffer2 (sb0)->gso_size;
+
+  int l4_hdr_sz = vnet_buffer2 (sb0)->gso_l4_hdr_sz;
+  u8 save_tcp_flags = 0;
+  u8 tcp_flags_no_fin_psh = 0;
+  u32 next_tcp_seq = 0;
+
+  tcp_header_t *tcp =
+    (tcp_header_t *) (sb0->data + vnet_buffer (sb0)->l4_hdr_offset);
+  next_tcp_seq = clib_net_to_host_u32 (tcp->seq_number);
+  /* store original flags for last packet and reset FIN and PSH */
+  save_tcp_flags = tcp->flags;
+  tcp_flags_no_fin_psh = tcp->flags & ~(TCP_FLAG_FIN | TCP_FLAG_PSH);
+  tcp->checksum = 0;
+
+  u32 default_bflags =
+    sb0->flags & ~(VNET_BUFFER_F_GSO | VLIB_BUFFER_NEXT_PRESENT);
+  u16 l234_sz = vnet_buffer (sb0)->l4_hdr_offset + l4_hdr_sz;
+  int first_data_size = clib_min (gso_size, sb0->current_length - l234_sz);
+  next_tcp_seq += first_data_size;
+
+  if (PREDICT_FALSE (!tso_alloc_tx_bufs (vm, ptd, sb0, l4_hdr_sz)))
+    return 0;
 
-  /* Total byte count of all buffers. */
-  n_bytes = 0;
-  n_packets = 0;
-  last_sw_if_index = ~0;
+  vlib_buffer_t *b0 = vlib_get_buffer (vm, ptd->split_buffers[0]);
+  tso_init_buf_from_template_base (b0, sb0, default_bflags,
+                                  l4_hdr_sz + first_data_size);
 
-  while (from < from_end)
+  u32 total_src_left = n_bytes_b0 - l234_sz - first_data_size;
+  if (total_src_left)
     {
-      /* Get new next frame since previous incomplete frame may have less
-         than VNET_FRAME_SIZE vectors in it. */
-      vlib_get_new_next_frame (vm, node, VNET_INTERFACE_OUTPUT_NEXT_TX,
-                              to_tx, n_left_to_tx);
-
-      while (from + 4 <= from_end && n_left_to_tx >= 2)
+      /* Need to copy more segments */
+      u8 *src_ptr, *dst_ptr;
+      u16 src_left, dst_left;
+      /* current source buffer */
+      vlib_buffer_t *csb0 = sb0;
+      u32 csbi0 = sbi0;
+      /* current dest buffer */
+      vlib_buffer_t *cdb0;
+      u16 dbi = 1;             /* the buffer [0] is b0 */
+
+      src_ptr = sb0->data + l234_sz + first_data_size;
+      src_left = sb0->current_length - l234_sz - first_data_size;
+      b0->current_length = l234_sz + first_data_size;
+
+      tso_fixup_segmented_buf (b0, tcp_flags_no_fin_psh, is_ip6);
+      if (do_tx_offloads)
+       calc_checksums (vm, b0);
+
+      /* grab a second buffer and prepare the loop */
+      ASSERT (dbi < vec_len (ptd->split_buffers));
+      cdb0 = vlib_get_buffer (vm, ptd->split_buffers[dbi++]);
+      tso_init_buf_from_template (vm, cdb0, b0, l234_sz, gso_size, &dst_ptr,
+                                 &dst_left, next_tcp_seq, default_bflags);
+
+      /* an arbitrary large number to catch the runaway loops */
+      int nloops = 2000;
+      while (total_src_left)
        {
-         u32 bi0, bi1;
-         vlib_buffer_t *b0, *b1;
-
-         /* Prefetch next iteration. */
-         vlib_prefetch_buffer_with_index (vm, from[2], LOAD);
-         vlib_prefetch_buffer_with_index (vm, from[3], LOAD);
+         ASSERT (nloops-- > 0);
+         u16 bytes_to_copy = clib_min (src_left, dst_left);
 
-         bi0 = from[0];
-         bi1 = from[1];
-         to_tx[0] = bi0;
-         to_tx[1] = bi1;
-         from += 2;
-         to_tx += 2;
-         n_left_to_tx -= 2;
+         clib_memcpy_fast (dst_ptr, src_ptr, bytes_to_copy);
 
-         b0 = vlib_get_buffer (vm, bi0);
-         b1 = vlib_get_buffer (vm, bi1);
+         src_left -= bytes_to_copy;
+         src_ptr += bytes_to_copy;
+         total_src_left -= bytes_to_copy;
+         dst_left -= bytes_to_copy;
+         dst_ptr += bytes_to_copy;
+         next_tcp_seq += bytes_to_copy;
+         cdb0->current_length += bytes_to_copy;
 
-         /* Be grumpy about zero length buffers for benefit of
-            driver tx function. */
-         ASSERT (b0->current_length > 0);
-         ASSERT (b1->current_length > 0);
-
-         if (PREDICT_FALSE
-             ((b0->flags | b1->flags) & VLIB_BUFFER_NEXT_PRESENT))
+         if (0 == src_left)
            {
-             u32 n_buffers, n_slow_bytes, i;
-
-             /* Undo. */
-             from -= 2;
-             to_tx -= 2;
-             n_left_to_tx += 2;
+             int has_next = (csb0->flags & VLIB_BUFFER_NEXT_PRESENT);
+             u32 next_bi = csb0->next_buffer;
 
-             /* Do slow path two times. */
-             for (i = 0; i < 2; i++)
+             /* init src to the next buffer in chain */
+             if (has_next)
+               {
+                 csbi0 = next_bi;
+                 csb0 = vlib_get_buffer (vm, csbi0);
+                 src_left = csb0->current_length;
+                 src_ptr = csb0->data;
+               }
+             else
                {
-                 u32 bi = i ? bi1 : bi0;
-                 vlib_buffer_t *b = i ? b1 : b0;
-
-                 n_buffers = slow_path (vm, bi, b,
-                                        n_left_to_tx, to_tx, &n_slow_bytes);
-
-                 /* Not enough room for single packet? */
-                 if (n_buffers == 0)
-                   goto put;
-
-                 from += 1;
-                 to_tx += n_buffers;
-                 n_left_to_tx -= n_buffers;
-                 incr_output_stats (vnm, cpu_index, n_slow_bytes,
-                                    vnet_buffer (b)->sw_if_index[VLIB_TX],
-                                    &last_sw_if_index, &n_packets, &n_bytes);
+                 ASSERT (total_src_left == 0);
+                 break;
                }
            }
-         else
+         if (0 == dst_left && total_src_left)
            {
-             incr_output_stats (vnm, cpu_index,
-                                vlib_buffer_length_in_chain (vm, b0),
-                                vnet_buffer (b0)->sw_if_index[VLIB_TX],
-                                &last_sw_if_index, &n_packets, &n_bytes);
-             incr_output_stats (vnm, cpu_index,
-                                vlib_buffer_length_in_chain (vm, b0),
-                                vnet_buffer (b1)->sw_if_index[VLIB_TX],
-                                &last_sw_if_index, &n_packets, &n_bytes);
+             if (do_tx_offloads)
+               calc_checksums (vm, cdb0);
+             n_tx_bytes += cdb0->current_length;
+             ASSERT (dbi < vec_len (ptd->split_buffers));
+             cdb0 = vlib_get_buffer (vm, ptd->split_buffers[dbi++]);
+             tso_init_buf_from_template (vm, cdb0, b0, l234_sz,
+                                         gso_size, &dst_ptr, &dst_left,
+                                         next_tcp_seq, default_bflags);
            }
        }
 
-      while (from + 1 <= from_end && n_left_to_tx >= 1)
-       {
-         u32 bi0;
-         vlib_buffer_t *b0;
-
-         bi0 = from[0];
-         to_tx[0] = bi0;
-         from += 1;
-         to_tx += 1;
-         n_left_to_tx -= 1;
-
-         b0 = vlib_get_buffer (vm, bi0);
-
-         /* Be grumpy about zero length buffers for benefit of
-            driver tx function. */
-         ASSERT (b0->current_length > 0);
-
-         if (PREDICT_FALSE (b0->flags & VLIB_BUFFER_NEXT_PRESENT))
-           {
-             u32 n_buffers, n_slow_bytes;
-
-             /* Undo. */
-             from -= 1;
-             to_tx -= 1;
-             n_left_to_tx += 1;
-
-             n_buffers = slow_path (vm, bi0, b0,
-                                    n_left_to_tx, to_tx, &n_slow_bytes);
+      tso_fixup_segmented_buf (cdb0, save_tcp_flags, is_ip6);
+      if (do_tx_offloads)
+       calc_checksums (vm, cdb0);
 
-             /* Not enough room for single packet? */
-             if (n_buffers == 0)
-               goto put;
-
-             from += 1;
-             to_tx += n_buffers;
-             n_left_to_tx -= n_buffers;
-           }
-         incr_output_stats (vnm, cpu_index,
-                            vlib_buffer_length_in_chain (vm, b0),
-                            vnet_buffer (b0)->sw_if_index[VLIB_TX],
-                            &last_sw_if_index, &n_packets, &n_bytes);
-       }
-
-    put:
-      vlib_put_next_frame (vm, node, VNET_INTERFACE_OUTPUT_NEXT_TX,
-                          n_left_to_tx);
+      n_tx_bytes += cdb0->current_length;
     }
+  n_tx_bytes += b0->current_length;
+  return n_tx_bytes;
+}
 
-  /* Final update of interface stats. */
-  incr_output_stats (vnm, cpu_index, 0, ~0,    /* ~0 will flush stats */
-                    &last_sw_if_index, &n_packets, &n_bytes);
+static_always_inline void
+drop_one_buffer_and_count (vlib_main_t * vm, vnet_main_t * vnm,
+                          vlib_node_runtime_t * node, u32 * pbi0,
+                          u32 drop_error_code)
+{
+  u32 thread_index = vm->thread_index;
+  vnet_interface_output_runtime_t *rt = (void *) node->runtime_data;
 
-  return n_buffers;
+  vlib_simple_counter_main_t *cm;
+  cm =
+    vec_elt_at_index (vnm->interface_main.sw_if_counters,
+                     VNET_INTERFACE_COUNTER_TX_ERROR);
+  vlib_increment_simple_counter (cm, thread_index, rt->sw_if_index, 1);
+
+  vlib_error_drop_buffers (vm, node, pbi0,
+                          /* buffer stride */ 1,
+                          /* n_buffers */ 1,
+                          VNET_INTERFACE_OUTPUT_NEXT_DROP,
+                          node->node_index, drop_error_code);
 }
 
-VLIB_NODE_FUNCTION_MULTIARCH_CLONE (vnet_interface_output_node_flatten);
-CLIB_MULTIARCH_SELECT_FN (vnet_interface_output_node_flatten);
-
-uword
-vnet_interface_output_node (vlib_main_t * vm,
-                           vlib_node_runtime_t * node, vlib_frame_t * frame)
+static_always_inline uword
+vnet_interface_output_node_inline_gso (vlib_main_t * vm,
+                                      vlib_node_runtime_t * node,
+                                      vlib_frame_t * frame,
+                                      vnet_main_t * vnm,
+                                      vnet_hw_interface_t * hi,
+                                      int do_tx_offloads,
+                                      int do_segmentation)
 {
-  vnet_main_t *vnm = vnet_get_main ();
   vnet_interface_output_runtime_t *rt = (void *) node->runtime_data;
   vnet_sw_interface_t *si;
-  vnet_hw_interface_t *hi;
   u32 n_left_to_tx, *from, *from_end, *to_tx;
   u32 n_bytes, n_buffers, n_packets;
   u32 n_bytes_b0, n_bytes_b1, n_bytes_b2, n_bytes_b3;
-  u32 cpu_index = vm->cpu_index;
+  u32 thread_index = vm->thread_index;
   vnet_interface_main_t *im = &vnm->interface_main;
   u32 next_index = VNET_INTERFACE_OUTPUT_NEXT_TX;
   u32 current_config_index = ~0;
   u8 arc = im->output_feature_arc_index;
+  vnet_interface_per_thread_data_t *ptd =
+    vec_elt_at_index (im->per_thread_data, thread_index);
 
   n_buffers = frame->n_vectors;
 
   if (node->flags & VLIB_NODE_FLAG_TRACE)
     vnet_interface_output_trace (vm, node, frame, n_buffers);
 
-  from = vlib_frame_args (frame);
+  from = vlib_frame_vector_args (frame);
 
   if (rt->is_deleted)
     return vlib_error_drop_buffers (vm, node, from,
@@ -451,14 +498,15 @@ vnet_interface_output_node (vlib_main_t * vm,
 
   si = vnet_get_sw_interface (vnm, rt->sw_if_index);
   hi = vnet_get_sup_hw_interface (vnm, rt->sw_if_index);
-  if (!(si->flags & VNET_SW_INTERFACE_FLAG_ADMIN_UP) ||
+  if (!(si->flags & (VNET_SW_INTERFACE_FLAG_ADMIN_UP |
+                    VNET_SW_INTERFACE_FLAG_BOND_SLAVE)) ||
       !(hi->flags & VNET_HW_INTERFACE_FLAG_LINK_UP))
     {
       vlib_simple_counter_main_t *cm;
 
       cm = vec_elt_at_index (vnm->interface_main.sw_if_counters,
                             VNET_INTERFACE_COUNTER_TX_ERROR);
-      vlib_increment_simple_counter (cm, cpu_index,
+      vlib_increment_simple_counter (cm, thread_index,
                                     rt->sw_if_index, n_buffers);
 
       return vlib_error_drop_buffers (vm, node, from,
@@ -497,6 +545,7 @@ vnet_interface_output_node (vlib_main_t * vm,
          u32 bi0, bi1, bi2, bi3;
          vlib_buffer_t *b0, *b1, *b2, *b3;
          u32 tx_swif0, tx_swif1, tx_swif2, tx_swif3;
+         u32 or_flags;
 
          /* Prefetch next iteration. */
          vlib_prefetch_buffer_with_index (vm, from[4], LOAD);
@@ -512,15 +561,30 @@ vnet_interface_output_node (vlib_main_t * vm,
          to_tx[1] = bi1;
          to_tx[2] = bi2;
          to_tx[3] = bi3;
-         from += 4;
-         to_tx += 4;
-         n_left_to_tx -= 4;
+         if (!do_segmentation)
+           {
+             from += 4;
+             to_tx += 4;
+             n_left_to_tx -= 4;
+           }
 
          b0 = vlib_get_buffer (vm, bi0);
          b1 = vlib_get_buffer (vm, bi1);
          b2 = vlib_get_buffer (vm, bi2);
          b3 = vlib_get_buffer (vm, bi3);
 
+         if (do_segmentation)
+           {
+             or_flags = b0->flags | b1->flags | b2->flags | b3->flags;
+
+             /* go to single loop if we need TSO segmentation */
+             if (PREDICT_FALSE (or_flags & VNET_BUFFER_F_GSO))
+               break;
+             from += 4;
+             to_tx += 4;
+             n_left_to_tx -= 4;
+           }
+
          /* Be grumpy about zero length buffers for benefit of
             driver tx function. */
          ASSERT (b0->current_length > 0);
@@ -543,10 +607,10 @@ vnet_interface_output_node (vlib_main_t * vm,
 
          if (PREDICT_FALSE (current_config_index != ~0))
            {
-             b0->feature_arc_index = arc;
-             b1->feature_arc_index = arc;
-             b2->feature_arc_index = arc;
-             b3->feature_arc_index = arc;
+             vnet_buffer (b0)->feature_arc_index = arc;
+             vnet_buffer (b1)->feature_arc_index = arc;
+             vnet_buffer (b2)->feature_arc_index = arc;
+             vnet_buffer (b3)->feature_arc_index = arc;
              b0->current_config_index = current_config_index;
              b1->current_config_index = current_config_index;
              b2->current_config_index = current_config_index;
@@ -558,7 +622,7 @@ vnet_interface_output_node (vlib_main_t * vm,
            {
              vlib_increment_combined_counter (im->combined_sw_if_counters +
                                               VNET_INTERFACE_COUNTER_TX,
-                                              cpu_index, tx_swif0, 1,
+                                              thread_index, tx_swif0, 1,
                                               n_bytes_b0);
            }
 
@@ -567,7 +631,7 @@ vnet_interface_output_node (vlib_main_t * vm,
 
              vlib_increment_combined_counter (im->combined_sw_if_counters +
                                               VNET_INTERFACE_COUNTER_TX,
-                                              cpu_index, tx_swif1, 1,
+                                              thread_index, tx_swif1, 1,
                                               n_bytes_b1);
            }
 
@@ -576,7 +640,7 @@ vnet_interface_output_node (vlib_main_t * vm,
 
              vlib_increment_combined_counter (im->combined_sw_if_counters +
                                               VNET_INTERFACE_COUNTER_TX,
-                                              cpu_index, tx_swif2, 1,
+                                              thread_index, tx_swif2, 1,
                                               n_bytes_b2);
            }
          if (PREDICT_FALSE (tx_swif3 != rt->sw_if_index))
@@ -584,9 +648,26 @@ vnet_interface_output_node (vlib_main_t * vm,
 
              vlib_increment_combined_counter (im->combined_sw_if_counters +
                                               VNET_INTERFACE_COUNTER_TX,
-                                              cpu_index, tx_swif3, 1,
+                                              thread_index, tx_swif3, 1,
                                               n_bytes_b3);
            }
+
+         if (!do_segmentation)
+           or_flags = b0->flags | b1->flags | b2->flags | b3->flags;
+
+         if (do_tx_offloads)
+           {
+             if (or_flags &
+                 (VNET_BUFFER_F_OFFLOAD_TCP_CKSUM |
+                  VNET_BUFFER_F_OFFLOAD_UDP_CKSUM |
+                  VNET_BUFFER_F_OFFLOAD_IP_CKSUM))
+               {
+                 calc_checksums (vm, b0);
+                 calc_checksums (vm, b1);
+                 calc_checksums (vm, b2);
+                 calc_checksums (vm, b3);
+               }
+           }
        }
 
       while (from + 1 <= from_end && n_left_to_tx >= 1)
@@ -614,18 +695,100 @@ vnet_interface_output_node (vlib_main_t * vm,
 
          if (PREDICT_FALSE (current_config_index != ~0))
            {
-             b0->feature_arc_index = arc;
+             vnet_buffer (b0)->feature_arc_index = arc;
              b0->current_config_index = current_config_index;
            }
 
+         if (do_segmentation)
+           {
+             if (PREDICT_FALSE (b0->flags & VNET_BUFFER_F_GSO))
+               {
+                 /*
+                  * Undo the enqueue of the b0 - it is not going anywhere,
+                  * and will be freed either after it's segmented or
+                  * when dropped, if there is no buffers to segment into.
+                  */
+                 to_tx -= 1;
+                 n_left_to_tx += 1;
+                 /* undo the counting. */
+                 n_bytes -= n_bytes_b0;
+                 n_packets -= 1;
+
+                 u32 n_tx_bytes = 0;
+
+                 n_tx_bytes =
+                   tso_segment_buffer (vm, ptd, do_tx_offloads, bi0, b0,
+                                       n_bytes_b0);
+
+                 if (PREDICT_FALSE (n_tx_bytes == 0))
+                   {
+                     drop_one_buffer_and_count (vm, vnm, node, from - 1,
+                                                VNET_INTERFACE_OUTPUT_ERROR_NO_BUFFERS_FOR_GSO);
+                     continue;
+                   }
+
+                 u16 n_tx_bufs = vec_len (ptd->split_buffers);
+                 u32 *from_tx_seg = ptd->split_buffers;
+
+                 while (n_tx_bufs > 0)
+                   {
+                     if (n_tx_bufs >= n_left_to_tx)
+                       {
+                         while (n_left_to_tx > 0)
+                           {
+                             to_tx[0] = from_tx_seg[0];
+                             to_tx += 1;
+                             from_tx_seg += 1;
+                             n_left_to_tx -= 1;
+                             n_tx_bufs -= 1;
+                             n_packets += 1;
+                           }
+                         vlib_put_next_frame (vm, node, next_index,
+                                              n_left_to_tx);
+                         vlib_get_new_next_frame (vm, node, next_index,
+                                                  to_tx, n_left_to_tx);
+                       }
+                     else
+                       {
+                         while (n_tx_bufs > 0)
+                           {
+                             to_tx[0] = from_tx_seg[0];
+                             to_tx += 1;
+                             from_tx_seg += 1;
+                             n_left_to_tx -= 1;
+                             n_tx_bufs -= 1;
+                             n_packets += 1;
+                           }
+                       }
+                   }
+                 n_bytes += n_tx_bytes;
+                 if (PREDICT_FALSE (tx_swif0 != rt->sw_if_index))
+                   {
+
+                     vlib_increment_combined_counter
+                       (im->combined_sw_if_counters +
+                        VNET_INTERFACE_COUNTER_TX, thread_index, tx_swif0,
+                        _vec_len (ptd->split_buffers), n_tx_bytes);
+                   }
+                 /* The buffers were enqueued. Reset the length */
+                 _vec_len (ptd->split_buffers) = 0;
+                 /* Free the now segmented buffer */
+                 vlib_buffer_free_one (vm, bi0);
+                 continue;
+               }
+           }
+
          if (PREDICT_FALSE (tx_swif0 != rt->sw_if_index))
            {
 
              vlib_increment_combined_counter (im->combined_sw_if_counters +
                                               VNET_INTERFACE_COUNTER_TX,
-                                              cpu_index, tx_swif0, 1,
+                                              thread_index, tx_swif0, 1,
                                               n_bytes_b0);
            }
+
+         if (do_tx_offloads)
+           calc_checksums (vm, b0);
        }
 
       vlib_put_next_frame (vm, node, next_index, n_left_to_tx);
@@ -634,13 +797,54 @@ vnet_interface_output_node (vlib_main_t * vm,
   /* Update main interface stats. */
   vlib_increment_combined_counter (im->combined_sw_if_counters
                                   + VNET_INTERFACE_COUNTER_TX,
-                                  cpu_index,
+                                  thread_index,
                                   rt->sw_if_index, n_packets, n_bytes);
   return n_buffers;
 }
 
-VLIB_NODE_FUNCTION_MULTIARCH_CLONE (vnet_interface_output_node);
-CLIB_MULTIARCH_SELECT_FN (vnet_interface_output_node);
+static_always_inline uword
+vnet_interface_output_node_inline (vlib_main_t * vm,
+                                  vlib_node_runtime_t * node,
+                                  vlib_frame_t * frame, vnet_main_t * vnm,
+                                  vnet_hw_interface_t * hi,
+                                  int do_tx_offloads)
+{
+  /*
+   * The 3-headed "if" is here because we want to err on the side
+   * of not impacting the non-GSO performance - so for the more
+   * common case of no GSO interfaces we want to prevent the
+   * segmentation codepath from being there altogether.
+   */
+  if (PREDICT_TRUE (vnm->interface_main.gso_interface_count == 0))
+    return vnet_interface_output_node_inline_gso (vm, node, frame, vnm, hi,
+                                                 do_tx_offloads,
+                                                 /* do_segmentation */ 0);
+  else if (hi->flags & VNET_HW_INTERFACE_FLAG_SUPPORTS_GSO)
+    return vnet_interface_output_node_inline_gso (vm, node, frame, vnm, hi,
+                                                 do_tx_offloads,
+                                                 /* do_segmentation */ 0);
+  else
+    return vnet_interface_output_node_inline_gso (vm, node, frame, vnm, hi,
+                                                 do_tx_offloads,
+                                                 /* do_segmentation */ 1);
+}
+
+uword
+vnet_interface_output_node (vlib_main_t * vm, vlib_node_runtime_t * node,
+                           vlib_frame_t * frame)
+{
+  vnet_main_t *vnm = vnet_get_main ();
+  vnet_hw_interface_t *hi;
+  vnet_interface_output_runtime_t *rt = (void *) node->runtime_data;
+  hi = vnet_get_sup_hw_interface (vnm, rt->sw_if_index);
+
+  if (hi->flags & VNET_HW_INTERFACE_FLAG_SUPPORTS_TX_L4_CKSUM_OFFLOAD)
+    return vnet_interface_output_node_inline (vm, node, frame, vnm, hi,
+                                             /* do_tx_offloads */ 0);
+  else
+    return vnet_interface_output_node_inline (vm, node, frame, vnm, hi,
+                                             /* do_tx_offloads */ 1);
+}
 
 /* Use buffer's sw_if_index[VNET_TX] to choose output interface. */
 static uword
@@ -654,7 +858,7 @@ vnet_per_buffer_interface_output (vlib_main_t * vm,
 
   n_left_from = frame->n_vectors;
 
-  from = vlib_frame_args (frame);
+  from = vlib_frame_vector_args (frame);
   next_index = node->cached_next_index;
 
   while (n_left_from > 0)
@@ -692,8 +896,8 @@ vnet_per_buffer_interface_output (vlib_main_t * vm,
                                       vnet_buffer (b1)->sw_if_index
                                       [VLIB_TX]);
 
-         next0 = hi0->hw_if_index;
-         next1 = hi1->hw_if_index;
+         next0 = hi0->output_node_next_index;
+         next1 = hi1->output_node_next_index;
 
          vlib_validate_buffer_enqueue_x2 (vm, node, next_index, to_next,
                                           n_left_to_next, bi0, bi1, next0,
@@ -720,7 +924,7 @@ vnet_per_buffer_interface_output (vlib_main_t * vm,
                                       vnet_buffer (b0)->sw_if_index
                                       [VLIB_TX]);
 
-         next0 = hi0->hw_if_index;
+         next0 = hi0->output_node_next_index;
 
          vlib_validate_buffer_enqueue_x1 (vm, node, next_index, to_next,
                                           n_left_to_next, bi0, next0);
@@ -848,7 +1052,7 @@ static u8 *
 validate_error_frame (vlib_main_t * vm,
                      vlib_node_runtime_t * node, vlib_frame_t * f)
 {
-  u32 *buffers = vlib_frame_args (f);
+  u32 *buffers = vlib_frame_vector_args (f);
   vlib_buffer_t *b;
   u8 *msg = 0;
   uword i;
@@ -893,12 +1097,12 @@ process_drop_punt (vlib_main_t * vm,
   u32 current_sw_if_index, n_errors_current_sw_if_index;
   u64 current_counter;
   vlib_simple_counter_main_t *cm;
-  u32 cpu_index = vm->cpu_index;
+  u32 thread_index = vm->thread_index;
 
   static vlib_error_t memory[VNET_ERROR_N_DISPOSITION];
   static char memory_init[VNET_ERROR_N_DISPOSITION];
 
-  buffers = vlib_frame_args (frame);
+  buffers = vlib_frame_vector_args (frame);
   first_buffer = buffers;
 
   {
@@ -965,19 +1169,19 @@ process_drop_punt (vlib_main_t * vm,
          current_counter -= 2;
          n_errors_current_sw_if_index -= 2;
 
-         vlib_increment_simple_counter (cm, cpu_index, sw_if_index0, 1);
-         vlib_increment_simple_counter (cm, cpu_index, sw_if_index1, 1);
+         vlib_increment_simple_counter (cm, thread_index, sw_if_index0, 1);
+         vlib_increment_simple_counter (cm, thread_index, sw_if_index1, 1);
 
          /* Increment super-interface drop/punt counters for
             sub-interfaces. */
          sw_if0 = vnet_get_sw_interface (vnm, sw_if_index0);
          vlib_increment_simple_counter
-           (cm, cpu_index, sw_if0->sup_sw_if_index,
+           (cm, thread_index, sw_if0->sup_sw_if_index,
             sw_if0->sup_sw_if_index != sw_if_index0);
 
          sw_if1 = vnet_get_sw_interface (vnm, sw_if_index1);
          vlib_increment_simple_counter
-           (cm, cpu_index, sw_if1->sup_sw_if_index,
+           (cm, thread_index, sw_if1->sup_sw_if_index,
             sw_if1->sup_sw_if_index != sw_if_index1);
 
          em->counters[current_counter_index] = current_counter;
@@ -1013,11 +1217,12 @@ process_drop_punt (vlib_main_t * vm,
       sw_if_index0 = vnet_buffer (b0)->sw_if_index[VLIB_RX];
 
       /* Increment drop/punt counters. */
-      vlib_increment_simple_counter (cm, cpu_index, sw_if_index0, 1);
+      vlib_increment_simple_counter (cm, thread_index, sw_if_index0, 1);
 
       /* Increment super-interface drop/punt counters for sub-interfaces. */
       sw_if0 = vnet_get_sw_interface (vnm, sw_if_index0);
-      vlib_increment_simple_counter (cm, cpu_index, sw_if0->sup_sw_if_index,
+      vlib_increment_simple_counter (cm, thread_index,
+                                    sw_if0->sup_sw_if_index,
                                     sw_if0->sup_sw_if_index != sw_if_index0);
 
       if (PREDICT_FALSE (e0 != current_error))
@@ -1041,12 +1246,12 @@ process_drop_punt (vlib_main_t * vm,
     {
       vnet_sw_interface_t *si;
 
-      vlib_increment_simple_counter (cm, cpu_index, current_sw_if_index,
+      vlib_increment_simple_counter (cm, thread_index, current_sw_if_index,
                                     n_errors_current_sw_if_index);
 
       si = vnet_get_sw_interface (vnm, current_sw_if_index);
       if (si->sup_sw_if_index != current_sw_if_index)
-       vlib_increment_simple_counter (cm, cpu_index, si->sup_sw_if_index,
+       vlib_increment_simple_counter (cm, thread_index, si->sup_sw_if_index,
                                       n_errors_current_sw_if_index);
     }
 
@@ -1194,6 +1399,37 @@ VLIB_REGISTER_NODE (vnet_per_buffer_interface_output_node,static) = {
 };
 /* *INDENT-ON* */
 
+/* Convenience node to drop a vector of buffers with a "misc error". */
+static uword
+misc_drop_buffers (vlib_main_t * vm,
+                  vlib_node_runtime_t * node, vlib_frame_t * frame)
+{
+  return vlib_error_drop_buffers (vm, node, vlib_frame_vector_args (frame),
+                                 /* buffer stride */ 1,
+                                 frame->n_vectors,
+                                 /* next */ 0,
+                                 node->node_index,
+                                 /* error */ 0);
+}
+
+static char *misc_drop_buffers_error_strings[] = {
+  [0] = "misc. errors",
+};
+
+/* *INDENT-OFF* */
+VLIB_REGISTER_NODE (misc_drop_buffers_node,static) = {
+  .function = misc_drop_buffers,
+  .name = "misc-drop-buffers",
+  .vector_size = sizeof (u32),
+  .n_errors = 1,
+  .n_next_nodes = 1,
+  .next_nodes = {
+      "error-drop",
+  },
+  .error_strings = misc_drop_buffers_error_strings,
+};
+/* *INDENT-ON* */
+
 VLIB_NODE_FUNCTION_MULTIARCH (vnet_per_buffer_interface_output_node,
                              vnet_per_buffer_interface_output);
 
@@ -1258,6 +1494,7 @@ VNET_FEATURE_ARC_INIT (interface_output, static) =
 {
   .arc_name  = "interface-output",
   .start_nodes = VNET_FEATURES (0),
+  .last_in_arc = "interface-tx",
   .arc_index_ptr = &vnet_main.interface_main.output_feature_arc_index,
 };
 
@@ -1267,6 +1504,12 @@ VNET_FEATURE_INIT (span_tx, static) = {
   .runs_before = VNET_FEATURES ("interface-tx"),
 };
 
+VNET_FEATURE_INIT (ipsec_if_tx, static) = {
+  .arc_name = "interface-output",
+  .node_name = "ipsec-if-output",
+  .runs_before = VNET_FEATURES ("interface-tx"),
+};
+
 VNET_FEATURE_INIT (interface_tx, static) = {
   .arc_name = "interface-output",
   .node_name = "interface-tx",
@@ -1282,12 +1525,13 @@ vnet_per_buffer_interface_output_hw_interface_add_del (vnet_main_t * vnm,
   vnet_hw_interface_t *hi = vnet_get_hw_interface (vnm, hw_if_index);
   u32 next_index;
 
-  next_index = vlib_node_add_next_with_slot
-    (vnm->vlib_main, vnet_per_buffer_interface_output_node.index,
-     hi->output_node_index,
-     /* next_index */ hw_if_index);
+  if (hi->output_node_index == 0)
+    return 0;
 
-  ASSERT (next_index == hw_if_index);
+  next_index = vlib_node_add_next
+    (vnm->vlib_main, vnet_per_buffer_interface_output_node.index,
+     hi->output_node_index);
+  hi->output_node_next_index = next_index;
 
   return 0;
 }
@@ -1295,6 +1539,18 @@ vnet_per_buffer_interface_output_hw_interface_add_del (vnet_main_t * vnm,
 VNET_HW_INTERFACE_ADD_DEL_FUNCTION
   (vnet_per_buffer_interface_output_hw_interface_add_del);
 
+void
+vnet_set_interface_output_node (vnet_main_t * vnm,
+                               u32 hw_if_index, u32 node_index)
+{
+  ASSERT (node_index);
+  vnet_hw_interface_t *hi = vnet_get_hw_interface (vnm, hw_if_index);
+  u32 next_index = vlib_node_add_next
+    (vnm->vlib_main, vnet_per_buffer_interface_output_node.index, node_index);
+  hi->output_node_next_index = next_index;
+  hi->output_node_index = node_index;
+}
+
 static clib_error_t *
 pcap_drop_trace_command_fn (vlib_main_t * vm,
                            unformat_input_t * input,
@@ -1316,7 +1572,7 @@ pcap_drop_trace_command_fn (vlib_main_t * vm,
              if (im->pcap_filename == 0)
                im->pcap_filename = format (0, "/tmp/drop.pcap%c", 0);
 
-             memset (&im->pcap_main, 0, sizeof (im->pcap_main));
+             clib_memset (&im->pcap_main, 0, sizeof (im->pcap_main));
              im->pcap_main.file_name = (char *) im->pcap_filename;
              im->pcap_main.n_packets_to_capture = 100;
              if (im->pcap_pkts_to_capture)
@@ -1391,8 +1647,8 @@ pcap_drop_trace_command_fn (vlib_main_t * vm,
 
          if (im->pcap_filename)
            vec_free (im->pcap_filename);
-         vec_add1 (filename, 0);
          im->pcap_filename = chroot_filename;
+         im->pcap_main.file_name = (char *) im->pcap_filename;
          matched = 1;
        }
       else if (unformat (input, "status"))