interface: Fix the tso segmentation
[vpp.git] / src / vnet / interface_output.c
index b09f799..28f44c3 100644 (file)
 typedef struct
 {
   u32 sw_if_index;
-  u8 data[128 - sizeof (u32)];
+  u32 flags;
+  u16 gso_size;
+  u8 gso_l4_hdr_sz;
+  u8 data[128 - 3 * sizeof (u32)];
 }
 interface_output_trace_t;
 
+#ifndef CLIB_MARCH_VARIANT
 u8 *
 format_vnet_interface_output_trace (u8 * s, va_list * va)
 {
@@ -69,24 +73,30 @@ format_vnet_interface_output_trace (u8 * s, va_list * va)
          (vnm->interface_main.sw_interfaces, t->sw_if_index))
        {
          /* the interface may have been deleted by the time the trace is printed */
-         s = format (s, "sw_if_index: %d\n%U%U",
-                     t->sw_if_index,
-                     format_white_space, indent,
-                     node->format_buffer ? node->
-                     format_buffer : format_hex_bytes, t->data,
-                     sizeof (t->data));
+         s = format (s, "sw_if_index: %d ", t->sw_if_index);
        }
       else
        {
          si = vnet_get_sw_interface (vnm, t->sw_if_index);
-
-         s = format (s, "%U\n%U%U",
-                     format_vnet_sw_interface_name, vnm, si,
-                     format_white_space, indent,
-                     node->format_buffer ? node->
-                     format_buffer : format_hex_bytes, t->data,
-                     sizeof (t->data));
+         s =
+           format (s, "%U ", format_vnet_sw_interface_name, vnm, si,
+                   t->flags);
+       }
+#define _(bit, name, v, x) \
+          if (v && (t->flags & VNET_BUFFER_F_##name)) \
+            s = format (s, "%s ", v);
+      foreach_vnet_buffer_flag
+#undef _
+       if (t->flags & VNET_BUFFER_F_GSO)
+       {
+         s = format (s, "\n%Ugso_sz %d gso_l4_hdr_sz %d",
+                     format_white_space, indent + 2, t->gso_size,
+                     t->gso_l4_hdr_sz);
        }
+      s =
+       format (s, "\n%U%U", format_white_space, indent,
+               node->format_buffer ? node->format_buffer : format_hex_bytes,
+               t->data, sizeof (t->data));
     }
   return s;
 }
@@ -121,6 +131,9 @@ vnet_interface_output_trace (vlib_main_t * vm,
        {
          t0 = vlib_add_trace (vm, node, b0, sizeof (t0[0]));
          t0->sw_if_index = vnet_buffer (b0)->sw_if_index[VLIB_TX];
+         t0->flags = b0->flags;
+         t0->gso_size = vnet_buffer2 (b0)->gso_size;
+         t0->gso_l4_hdr_sz = vnet_buffer2 (b0)->gso_l4_hdr_sz;
          clib_memcpy_fast (t0->data, vlib_buffer_get_current (b0),
                            sizeof (t0->data));
        }
@@ -128,6 +141,9 @@ vnet_interface_output_trace (vlib_main_t * vm,
        {
          t1 = vlib_add_trace (vm, node, b1, sizeof (t1[0]));
          t1->sw_if_index = vnet_buffer (b1)->sw_if_index[VLIB_TX];
+         t1->flags = b1->flags;
+         t1->gso_size = vnet_buffer2 (b1)->gso_size;
+         t1->gso_l4_hdr_sz = vnet_buffer2 (b1)->gso_l4_hdr_sz;
          clib_memcpy_fast (t1->data, vlib_buffer_get_current (b1),
                            sizeof (t1->data));
        }
@@ -149,6 +165,9 @@ vnet_interface_output_trace (vlib_main_t * vm,
        {
          t0 = vlib_add_trace (vm, node, b0, sizeof (t0[0]));
          t0->sw_if_index = vnet_buffer (b0)->sw_if_index[VLIB_TX];
+         t0->flags = b0->flags;
+         t0->gso_size = vnet_buffer2 (b0)->gso_size;
+         t0->gso_l4_hdr_sz = vnet_buffer2 (b0)->gso_l4_hdr_sz;
          clib_memcpy_fast (t0->data, vlib_buffer_get_current (b0),
                            sizeof (t0->data));
        }
@@ -160,8 +179,6 @@ vnet_interface_output_trace (vlib_main_t * vm,
 static_always_inline void
 calc_checksums (vlib_main_t * vm, vlib_buffer_t * b)
 {
-  ip4_header_t *ip4;
-  ip6_header_t *ip6;
   tcp_header_t *th;
   udp_header_t *uh;
 
@@ -170,28 +187,42 @@ calc_checksums (vlib_main_t * vm, vlib_buffer_t * b)
 
   ASSERT (!(is_ip4 && is_ip6));
 
-  ip4 = (ip4_header_t *) (b->data + vnet_buffer (b)->l3_hdr_offset);
-  ip6 = (ip6_header_t *) (b->data + vnet_buffer (b)->l3_hdr_offset);
   th = (tcp_header_t *) (b->data + vnet_buffer (b)->l4_hdr_offset);
   uh = (udp_header_t *) (b->data + vnet_buffer (b)->l4_hdr_offset);
 
   if (is_ip4)
     {
+      ip4_header_t *ip4;
+
       ip4 = (ip4_header_t *) (b->data + vnet_buffer (b)->l3_hdr_offset);
       if (b->flags & VNET_BUFFER_F_OFFLOAD_IP_CKSUM)
        ip4->checksum = ip4_header_checksum (ip4);
       if (b->flags & VNET_BUFFER_F_OFFLOAD_TCP_CKSUM)
-       th->checksum = ip4_tcp_udp_compute_checksum (vm, b, ip4);
-      if (b->flags & VNET_BUFFER_F_OFFLOAD_UDP_CKSUM)
+       {
+         th->checksum = 0;
+         th->checksum = ip4_tcp_udp_compute_checksum (vm, b, ip4);
+       }
+      else if (b->flags & VNET_BUFFER_F_OFFLOAD_UDP_CKSUM)
        uh->checksum = ip4_tcp_udp_compute_checksum (vm, b, ip4);
     }
-  if (is_ip6)
+  else if (is_ip6)
     {
       int bogus;
+      ip6_header_t *ip6;
+
+      ip6 = (ip6_header_t *) (b->data + vnet_buffer (b)->l3_hdr_offset);
       if (b->flags & VNET_BUFFER_F_OFFLOAD_TCP_CKSUM)
-       th->checksum = ip6_tcp_udp_icmp_compute_checksum (vm, b, ip6, &bogus);
-      if (b->flags & VNET_BUFFER_F_OFFLOAD_UDP_CKSUM)
-       uh->checksum = ip6_tcp_udp_icmp_compute_checksum (vm, b, ip6, &bogus);
+       {
+         th->checksum = 0;
+         th->checksum =
+           ip6_tcp_udp_icmp_compute_checksum (vm, b, ip6, &bogus);
+       }
+      else if (b->flags & VNET_BUFFER_F_OFFLOAD_UDP_CKSUM)
+       {
+         uh->checksum = 0;
+         uh->checksum =
+           ip6_tcp_udp_icmp_compute_checksum (vm, b, ip6, &bogus);
+       }
     }
 
   b->flags &= ~VNET_BUFFER_F_OFFLOAD_TCP_CKSUM;
@@ -199,12 +230,246 @@ calc_checksums (vlib_main_t * vm, vlib_buffer_t * b)
   b->flags &= ~VNET_BUFFER_F_OFFLOAD_IP_CKSUM;
 }
 
+static_always_inline u16
+tso_alloc_tx_bufs (vlib_main_t * vm,
+                  vnet_interface_per_thread_data_t * ptd,
+                  vlib_buffer_t * b0, u16 l4_hdr_sz)
+{
+  u32 n_bytes_b0 = vlib_buffer_length_in_chain (vm, b0);
+  u16 gso_size = vnet_buffer2 (b0)->gso_size;
+  u16 l234_sz = vnet_buffer (b0)->l4_hdr_offset + l4_hdr_sz;
+  /* rounded-up division */
+  u16 n_bufs = (n_bytes_b0 - l234_sz + (gso_size - 1)) / gso_size;
+  u16 n_alloc;
+
+  ASSERT (n_bufs > 0);
+  vec_validate (ptd->split_buffers, n_bufs - 1);
+
+  n_alloc = vlib_buffer_alloc (vm, ptd->split_buffers, n_bufs);
+  if (n_alloc < n_bufs)
+    {
+      vlib_buffer_free (vm, ptd->split_buffers, n_alloc);
+      return 0;
+    }
+  return 1;
+}
+
+static_always_inline void
+tso_init_buf_from_template_base (vlib_buffer_t * nb0, vlib_buffer_t * b0,
+                                u32 flags, u16 length)
+{
+  nb0->current_data = 0;
+  nb0->total_length_not_including_first_buffer = 0;
+  nb0->flags = VLIB_BUFFER_TOTAL_LENGTH_VALID | flags;
+  clib_memcpy_fast (&nb0->opaque, &b0->opaque, sizeof (nb0->opaque));
+  clib_memcpy_fast (nb0->data, b0->data, length);
+  nb0->current_length = length;
+}
+
+static_always_inline void
+tso_init_buf_from_template (vlib_main_t * vm, vlib_buffer_t * nb0,
+                           vlib_buffer_t * b0, u16 template_data_sz,
+                           u16 gso_size, u8 ** p_dst_ptr, u16 * p_dst_left,
+                           u32 next_tcp_seq, u32 flags)
+{
+  tso_init_buf_from_template_base (nb0, b0, flags, template_data_sz);
+
+  *p_dst_left =
+    clib_min (gso_size,
+             vlib_buffer_get_default_data_size (vm) - template_data_sz);
+  *p_dst_ptr = nb0->data + template_data_sz;
+
+  tcp_header_t *tcp =
+    (tcp_header_t *) (nb0->data + vnet_buffer (nb0)->l4_hdr_offset);
+  tcp->seq_number = clib_host_to_net_u32 (next_tcp_seq);
+}
+
+static_always_inline void
+tso_fixup_segmented_buf (vlib_buffer_t * b0, u8 tcp_flags, int is_ip6)
+{
+  u16 l3_hdr_offset = vnet_buffer (b0)->l3_hdr_offset;
+  u16 l4_hdr_offset = vnet_buffer (b0)->l4_hdr_offset;
+  ip4_header_t *ip4 = (ip4_header_t *) (b0->data + l3_hdr_offset);
+  ip6_header_t *ip6 = (ip6_header_t *) (b0->data + l3_hdr_offset);
+  tcp_header_t *tcp = (tcp_header_t *) (b0->data + l4_hdr_offset);
+
+  tcp->flags = tcp_flags;
+
+  if (is_ip6)
+    ip6->payload_length =
+      clib_host_to_net_u16 (b0->current_length -
+                           vnet_buffer (b0)->l4_hdr_offset);
+  else
+    ip4->length =
+      clib_host_to_net_u16 (b0->current_length -
+                           vnet_buffer (b0)->l3_hdr_offset);
+}
+
+/**
+ * Allocate the necessary number of ptd->split_buffers,
+ * and segment the possibly chained buffer(s) from b0 into
+ * there.
+ *
+ * Return the cumulative number of bytes sent or zero
+ * if allocation failed.
+ */
+
+static_always_inline u32
+tso_segment_buffer (vlib_main_t * vm, vnet_interface_per_thread_data_t * ptd,
+                   int do_tx_offloads, u32 sbi0, vlib_buffer_t * sb0,
+                   u32 n_bytes_b0)
+{
+  u32 n_tx_bytes = 0;
+  int is_ip4 = sb0->flags & VNET_BUFFER_F_IS_IP4;
+  int is_ip6 = sb0->flags & VNET_BUFFER_F_IS_IP6;
+  ASSERT (is_ip4 || is_ip6);
+  ASSERT (sb0->flags & VNET_BUFFER_F_L2_HDR_OFFSET_VALID);
+  ASSERT (sb0->flags & VNET_BUFFER_F_L3_HDR_OFFSET_VALID);
+  ASSERT (sb0->flags & VNET_BUFFER_F_L4_HDR_OFFSET_VALID);
+  u16 gso_size = vnet_buffer2 (sb0)->gso_size;
+
+  int l4_hdr_sz = vnet_buffer2 (sb0)->gso_l4_hdr_sz;
+  u8 save_tcp_flags = 0;
+  u8 tcp_flags_no_fin_psh = 0;
+  u32 next_tcp_seq = 0;
+
+  tcp_header_t *tcp =
+    (tcp_header_t *) (sb0->data + vnet_buffer (sb0)->l4_hdr_offset);
+  next_tcp_seq = clib_net_to_host_u32 (tcp->seq_number);
+  /* store original flags for last packet and reset FIN and PSH */
+  save_tcp_flags = tcp->flags;
+  tcp_flags_no_fin_psh = tcp->flags & ~(TCP_FLAG_FIN | TCP_FLAG_PSH);
+  tcp->checksum = 0;
+
+  u32 default_bflags =
+    sb0->flags & ~(VNET_BUFFER_F_GSO | VLIB_BUFFER_NEXT_PRESENT);
+  u16 l234_sz = vnet_buffer (sb0)->l4_hdr_offset + l4_hdr_sz;
+  int first_data_size = clib_min (gso_size, sb0->current_length - l234_sz);
+  next_tcp_seq += first_data_size;
+
+  if (PREDICT_FALSE (!tso_alloc_tx_bufs (vm, ptd, sb0, l4_hdr_sz)))
+    return 0;
+
+  vlib_buffer_t *b0 = vlib_get_buffer (vm, ptd->split_buffers[0]);
+  tso_init_buf_from_template_base (b0, sb0, default_bflags,
+                                  l4_hdr_sz + first_data_size);
+
+  u32 total_src_left = n_bytes_b0 - l234_sz - first_data_size;
+  if (total_src_left)
+    {
+      /* Need to copy more segments */
+      u8 *src_ptr, *dst_ptr;
+      u16 src_left, dst_left;
+      /* current source buffer */
+      vlib_buffer_t *csb0 = sb0;
+      u32 csbi0 = sbi0;
+      /* current dest buffer */
+      vlib_buffer_t *cdb0;
+      u16 dbi = 1;             /* the buffer [0] is b0 */
+
+      src_ptr = sb0->data + l234_sz + first_data_size;
+      src_left = sb0->current_length - l234_sz - first_data_size;
+      b0->current_length = l234_sz + first_data_size;
+
+      tso_fixup_segmented_buf (b0, tcp_flags_no_fin_psh, is_ip6);
+      if (do_tx_offloads)
+       calc_checksums (vm, b0);
+
+      /* grab a second buffer and prepare the loop */
+      ASSERT (dbi < vec_len (ptd->split_buffers));
+      cdb0 = vlib_get_buffer (vm, ptd->split_buffers[dbi++]);
+      tso_init_buf_from_template (vm, cdb0, b0, l234_sz, gso_size, &dst_ptr,
+                                 &dst_left, next_tcp_seq, default_bflags);
+
+      /* an arbitrary large number to catch the runaway loops */
+      int nloops = 2000;
+      while (total_src_left)
+       {
+         if (nloops-- <= 0)
+           clib_panic ("infinite loop detected");
+         u16 bytes_to_copy = clib_min (src_left, dst_left);
+
+         clib_memcpy_fast (dst_ptr, src_ptr, bytes_to_copy);
+
+         src_left -= bytes_to_copy;
+         src_ptr += bytes_to_copy;
+         total_src_left -= bytes_to_copy;
+         dst_left -= bytes_to_copy;
+         dst_ptr += bytes_to_copy;
+         next_tcp_seq += bytes_to_copy;
+         cdb0->current_length += bytes_to_copy;
+
+         if (0 == src_left)
+           {
+             int has_next = (csb0->flags & VLIB_BUFFER_NEXT_PRESENT);
+             u32 next_bi = csb0->next_buffer;
+
+             /* init src to the next buffer in chain */
+             if (has_next)
+               {
+                 csbi0 = next_bi;
+                 csb0 = vlib_get_buffer (vm, csbi0);
+                 src_left = csb0->current_length;
+                 src_ptr = csb0->data;
+               }
+             else
+               {
+                 ASSERT (total_src_left == 0);
+                 break;
+               }
+           }
+         if (0 == dst_left && total_src_left)
+           {
+             if (do_tx_offloads)
+               calc_checksums (vm, cdb0);
+             n_tx_bytes += cdb0->current_length;
+             ASSERT (dbi < vec_len (ptd->split_buffers));
+             cdb0 = vlib_get_buffer (vm, ptd->split_buffers[dbi++]);
+             tso_init_buf_from_template (vm, cdb0, b0, l234_sz,
+                                         gso_size, &dst_ptr, &dst_left,
+                                         next_tcp_seq, default_bflags);
+           }
+       }
+
+      tso_fixup_segmented_buf (cdb0, save_tcp_flags, is_ip6);
+      if (do_tx_offloads)
+       calc_checksums (vm, cdb0);
+
+      n_tx_bytes += cdb0->current_length;
+    }
+  n_tx_bytes += b0->current_length;
+  return n_tx_bytes;
+}
+
+static_always_inline void
+drop_one_buffer_and_count (vlib_main_t * vm, vnet_main_t * vnm,
+                          vlib_node_runtime_t * node, u32 * pbi0,
+                          u32 drop_error_code)
+{
+  u32 thread_index = vm->thread_index;
+  vnet_interface_output_runtime_t *rt = (void *) node->runtime_data;
+
+  vlib_simple_counter_main_t *cm;
+  cm =
+    vec_elt_at_index (vnm->interface_main.sw_if_counters,
+                     VNET_INTERFACE_COUNTER_TX_ERROR);
+  vlib_increment_simple_counter (cm, thread_index, rt->sw_if_index, 1);
+
+  vlib_error_drop_buffers (vm, node, pbi0,
+                          /* buffer stride */ 1,
+                          /* n_buffers */ 1,
+                          VNET_INTERFACE_OUTPUT_NEXT_DROP,
+                          node->node_index, drop_error_code);
+}
+
 static_always_inline uword
-vnet_interface_output_node_inline (vlib_main_t * vm,
-                                  vlib_node_runtime_t * node,
-                                  vlib_frame_t * frame, vnet_main_t * vnm,
-                                  vnet_hw_interface_t * hi,
-                                  int do_tx_offloads)
+vnet_interface_output_node_inline_gso (vlib_main_t * vm,
+                                      vlib_node_runtime_t * node,
+                                      vlib_frame_t * frame,
+                                      vnet_main_t * vnm,
+                                      vnet_hw_interface_t * hi,
+                                      int do_tx_offloads,
+                                      int do_segmentation)
 {
   vnet_interface_output_runtime_t *rt = (void *) node->runtime_data;
   vnet_sw_interface_t *si;
@@ -216,6 +481,9 @@ vnet_interface_output_node_inline (vlib_main_t * vm,
   u32 next_index = VNET_INTERFACE_OUTPUT_NEXT_TX;
   u32 current_config_index = ~0;
   u8 arc = im->output_feature_arc_index;
+  vnet_interface_per_thread_data_t *ptd =
+    vec_elt_at_index (im->per_thread_data, thread_index);
+  vlib_buffer_t *bufs[VLIB_FRAME_SIZE], **b = bufs;
 
   n_buffers = frame->n_vectors;
 
@@ -223,6 +491,7 @@ vnet_interface_output_node_inline (vlib_main_t * vm,
     vnet_interface_output_trace (vm, node, frame, n_buffers);
 
   from = vlib_frame_vector_args (frame);
+  vlib_get_buffers (vm, from, b, n_buffers);
 
   if (rt->is_deleted)
     return vlib_error_drop_buffers (vm, node, from,
@@ -279,15 +548,14 @@ vnet_interface_output_node_inline (vlib_main_t * vm,
       while (from + 8 <= from_end && n_left_to_tx >= 4)
        {
          u32 bi0, bi1, bi2, bi3;
-         vlib_buffer_t *b0, *b1, *b2, *b3;
          u32 tx_swif0, tx_swif1, tx_swif2, tx_swif3;
          u32 or_flags;
 
          /* Prefetch next iteration. */
-         vlib_prefetch_buffer_with_index (vm, from[4], LOAD);
-         vlib_prefetch_buffer_with_index (vm, from[5], LOAD);
-         vlib_prefetch_buffer_with_index (vm, from[6], LOAD);
-         vlib_prefetch_buffer_with_index (vm, from[7], LOAD);
+         vlib_prefetch_buffer_header (b[4], LOAD);
+         vlib_prefetch_buffer_header (b[5], LOAD);
+         vlib_prefetch_buffer_header (b[6], LOAD);
+         vlib_prefetch_buffer_header (b[7], LOAD);
 
          bi0 = from[0];
          bi1 = from[1];
@@ -297,30 +565,34 @@ vnet_interface_output_node_inline (vlib_main_t * vm,
          to_tx[1] = bi1;
          to_tx[2] = bi2;
          to_tx[3] = bi3;
+
+         or_flags = b[0]->flags | b[1]->flags | b[2]->flags | b[3]->flags;
+
+         if (do_segmentation)
+           {
+             /* go to single loop if we need TSO segmentation */
+             if (PREDICT_FALSE (or_flags & VNET_BUFFER_F_GSO))
+               break;
+           }
          from += 4;
          to_tx += 4;
          n_left_to_tx -= 4;
 
-         b0 = vlib_get_buffer (vm, bi0);
-         b1 = vlib_get_buffer (vm, bi1);
-         b2 = vlib_get_buffer (vm, bi2);
-         b3 = vlib_get_buffer (vm, bi3);
-
          /* Be grumpy about zero length buffers for benefit of
             driver tx function. */
-         ASSERT (b0->current_length > 0);
-         ASSERT (b1->current_length > 0);
-         ASSERT (b2->current_length > 0);
-         ASSERT (b3->current_length > 0);
-
-         n_bytes_b0 = vlib_buffer_length_in_chain (vm, b0);
-         n_bytes_b1 = vlib_buffer_length_in_chain (vm, b1);
-         n_bytes_b2 = vlib_buffer_length_in_chain (vm, b2);
-         n_bytes_b3 = vlib_buffer_length_in_chain (vm, b3);
-         tx_swif0 = vnet_buffer (b0)->sw_if_index[VLIB_TX];
-         tx_swif1 = vnet_buffer (b1)->sw_if_index[VLIB_TX];
-         tx_swif2 = vnet_buffer (b2)->sw_if_index[VLIB_TX];
-         tx_swif3 = vnet_buffer (b3)->sw_if_index[VLIB_TX];
+         ASSERT (b[0]->current_length > 0);
+         ASSERT (b[1]->current_length > 0);
+         ASSERT (b[2]->current_length > 0);
+         ASSERT (b[3]->current_length > 0);
+
+         n_bytes_b0 = vlib_buffer_length_in_chain (vm, b[0]);
+         n_bytes_b1 = vlib_buffer_length_in_chain (vm, b[1]);
+         n_bytes_b2 = vlib_buffer_length_in_chain (vm, b[2]);
+         n_bytes_b3 = vlib_buffer_length_in_chain (vm, b[3]);
+         tx_swif0 = vnet_buffer (b[0])->sw_if_index[VLIB_TX];
+         tx_swif1 = vnet_buffer (b[1])->sw_if_index[VLIB_TX];
+         tx_swif2 = vnet_buffer (b[2])->sw_if_index[VLIB_TX];
+         tx_swif3 = vnet_buffer (b[3])->sw_if_index[VLIB_TX];
 
          n_bytes += n_bytes_b0 + n_bytes_b1;
          n_bytes += n_bytes_b2 + n_bytes_b3;
@@ -328,14 +600,14 @@ vnet_interface_output_node_inline (vlib_main_t * vm,
 
          if (PREDICT_FALSE (current_config_index != ~0))
            {
-             vnet_buffer (b0)->feature_arc_index = arc;
-             vnet_buffer (b1)->feature_arc_index = arc;
-             vnet_buffer (b2)->feature_arc_index = arc;
-             vnet_buffer (b3)->feature_arc_index = arc;
-             b0->current_config_index = current_config_index;
-             b1->current_config_index = current_config_index;
-             b2->current_config_index = current_config_index;
-             b3->current_config_index = current_config_index;
+             vnet_buffer (b[0])->feature_arc_index = arc;
+             vnet_buffer (b[1])->feature_arc_index = arc;
+             vnet_buffer (b[2])->feature_arc_index = arc;
+             vnet_buffer (b[3])->feature_arc_index = arc;
+             b[0]->current_config_index = current_config_index;
+             b[1]->current_config_index = current_config_index;
+             b[2]->current_config_index = current_config_index;
+             b[3]->current_config_index = current_config_index;
            }
 
          /* update vlan subif tx counts, if required */
@@ -373,8 +645,6 @@ vnet_interface_output_node_inline (vlib_main_t * vm,
                                               n_bytes_b3);
            }
 
-         or_flags = b0->flags | b1->flags | b2->flags | b3->flags;
-
          if (do_tx_offloads)
            {
              if (or_flags &
@@ -382,18 +652,19 @@ vnet_interface_output_node_inline (vlib_main_t * vm,
                   VNET_BUFFER_F_OFFLOAD_UDP_CKSUM |
                   VNET_BUFFER_F_OFFLOAD_IP_CKSUM))
                {
-                 calc_checksums (vm, b0);
-                 calc_checksums (vm, b1);
-                 calc_checksums (vm, b2);
-                 calc_checksums (vm, b3);
+                 calc_checksums (vm, b[0]);
+                 calc_checksums (vm, b[1]);
+                 calc_checksums (vm, b[2]);
+                 calc_checksums (vm, b[3]);
                }
            }
+         b += 4;
+
        }
 
       while (from + 1 <= from_end && n_left_to_tx >= 1)
        {
          u32 bi0;
-         vlib_buffer_t *b0;
          u32 tx_swif0;
 
          bi0 = from[0];
@@ -402,21 +673,97 @@ vnet_interface_output_node_inline (vlib_main_t * vm,
          to_tx += 1;
          n_left_to_tx -= 1;
 
-         b0 = vlib_get_buffer (vm, bi0);
-
          /* Be grumpy about zero length buffers for benefit of
             driver tx function. */
-         ASSERT (b0->current_length > 0);
+         ASSERT (b[0]->current_length > 0);
 
-         n_bytes_b0 = vlib_buffer_length_in_chain (vm, b0);
-         tx_swif0 = vnet_buffer (b0)->sw_if_index[VLIB_TX];
+         n_bytes_b0 = vlib_buffer_length_in_chain (vm, b[0]);
+         tx_swif0 = vnet_buffer (b[0])->sw_if_index[VLIB_TX];
          n_bytes += n_bytes_b0;
          n_packets += 1;
 
          if (PREDICT_FALSE (current_config_index != ~0))
            {
-             vnet_buffer (b0)->feature_arc_index = arc;
-             b0->current_config_index = current_config_index;
+             vnet_buffer (b[0])->feature_arc_index = arc;
+             b[0]->current_config_index = current_config_index;
+           }
+
+         if (do_segmentation)
+           {
+             if (PREDICT_FALSE (b[0]->flags & VNET_BUFFER_F_GSO))
+               {
+                 /*
+                  * Undo the enqueue of the b0 - it is not going anywhere,
+                  * and will be freed either after it's segmented or
+                  * when dropped, if there is no buffers to segment into.
+                  */
+                 to_tx -= 1;
+                 n_left_to_tx += 1;
+                 /* undo the counting. */
+                 n_bytes -= n_bytes_b0;
+                 n_packets -= 1;
+
+                 u32 n_tx_bytes = 0;
+
+                 n_tx_bytes =
+                   tso_segment_buffer (vm, ptd, do_tx_offloads, bi0, b[0],
+                                       n_bytes_b0);
+
+                 if (PREDICT_FALSE (n_tx_bytes == 0))
+                   {
+                     drop_one_buffer_and_count (vm, vnm, node, from - 1,
+                                                VNET_INTERFACE_OUTPUT_ERROR_NO_BUFFERS_FOR_GSO);
+                     b += 1;
+                     continue;
+                   }
+
+                 u16 n_tx_bufs = vec_len (ptd->split_buffers);
+                 u32 *from_tx_seg = ptd->split_buffers;
+
+                 while (n_tx_bufs > 0)
+                   {
+                     if (n_tx_bufs >= n_left_to_tx)
+                       {
+                         while (n_left_to_tx > 0)
+                           {
+                             to_tx[0] = from_tx_seg[0];
+                             to_tx += 1;
+                             from_tx_seg += 1;
+                             n_left_to_tx -= 1;
+                             n_tx_bufs -= 1;
+                             n_packets += 1;
+                           }
+                         vlib_put_next_frame (vm, node, next_index,
+                                              n_left_to_tx);
+                         vlib_get_new_next_frame (vm, node, next_index,
+                                                  to_tx, n_left_to_tx);
+                       }
+                     while (n_tx_bufs > 0)
+                       {
+                         to_tx[0] = from_tx_seg[0];
+                         to_tx += 1;
+                         from_tx_seg += 1;
+                         n_left_to_tx -= 1;
+                         n_tx_bufs -= 1;
+                         n_packets += 1;
+                       }
+                   }
+                 n_bytes += n_tx_bytes;
+                 if (PREDICT_FALSE (tx_swif0 != rt->sw_if_index))
+                   {
+
+                     vlib_increment_combined_counter
+                       (im->combined_sw_if_counters +
+                        VNET_INTERFACE_COUNTER_TX, thread_index, tx_swif0,
+                        _vec_len (ptd->split_buffers), n_tx_bytes);
+                   }
+                 /* The buffers were enqueued. Reset the length */
+                 _vec_len (ptd->split_buffers) = 0;
+                 /* Free the now segmented buffer */
+                 vlib_buffer_free_one (vm, bi0);
+                 b += 1;
+                 continue;
+               }
            }
 
          if (PREDICT_FALSE (tx_swif0 != rt->sw_if_index))
@@ -429,7 +776,9 @@ vnet_interface_output_node_inline (vlib_main_t * vm,
            }
 
          if (do_tx_offloads)
-           calc_checksums (vm, b0);
+           calc_checksums (vm, b[0]);
+
+         b += 1;
        }
 
       vlib_put_next_frame (vm, node, next_index, n_left_to_tx);
@@ -442,8 +791,74 @@ vnet_interface_output_node_inline (vlib_main_t * vm,
                                   rt->sw_if_index, n_packets, n_bytes);
   return n_buffers;
 }
+#endif /* CLIB_MARCH_VARIANT */
 
-static uword
+static_always_inline void vnet_interface_pcap_tx_trace
+  (vlib_main_t * vm, vlib_node_runtime_t * node, vlib_frame_t * frame,
+   int sw_if_index_from_buffer)
+{
+  u32 n_left_from, *from;
+  u32 sw_if_index;
+
+  if (PREDICT_TRUE (vm->pcap[VLIB_TX].pcap_enable == 0))
+    return;
+
+  if (sw_if_index_from_buffer == 0)
+    {
+      vnet_interface_output_runtime_t *rt = (void *) node->runtime_data;
+      sw_if_index = rt->sw_if_index;
+    }
+  else
+    sw_if_index = ~0;
+
+  n_left_from = frame->n_vectors;
+  from = vlib_frame_vector_args (frame);
+
+  while (n_left_from > 0)
+    {
+      u32 bi0 = from[0];
+      vlib_buffer_t *b0 = vlib_get_buffer (vm, bi0);
+
+      if (sw_if_index_from_buffer)
+       sw_if_index = vnet_buffer (b0)->sw_if_index[VLIB_TX];
+
+      if (vm->pcap[VLIB_TX].pcap_sw_if_index == 0 ||
+         vm->pcap[VLIB_TX].pcap_sw_if_index == sw_if_index)
+       pcap_add_buffer (&vm->pcap[VLIB_TX].pcap_main, vm, bi0, 512);
+      from++;
+      n_left_from--;
+    }
+}
+
+#ifndef CLIB_MARCH_VARIANT
+static_always_inline uword
+vnet_interface_output_node_inline (vlib_main_t * vm,
+                                  vlib_node_runtime_t * node,
+                                  vlib_frame_t * frame, vnet_main_t * vnm,
+                                  vnet_hw_interface_t * hi,
+                                  int do_tx_offloads)
+{
+  /*
+   * The 3-headed "if" is here because we want to err on the side
+   * of not impacting the non-GSO performance - so for the more
+   * common case of no GSO interfaces we want to prevent the
+   * segmentation codepath from being there altogether.
+   */
+  if (PREDICT_TRUE (vnm->interface_main.gso_interface_count == 0))
+    return vnet_interface_output_node_inline_gso (vm, node, frame, vnm, hi,
+                                                 do_tx_offloads,
+                                                 /* do_segmentation */ 0);
+  else if (hi->flags & VNET_HW_INTERFACE_FLAG_SUPPORTS_GSO)
+    return vnet_interface_output_node_inline_gso (vm, node, frame, vnm, hi,
+                                                 do_tx_offloads,
+                                                 /* do_segmentation */ 0);
+  else
+    return vnet_interface_output_node_inline_gso (vm, node, frame, vnm, hi,
+                                                 do_tx_offloads,
+                                                 /* do_segmentation */ 1);
+}
+
+uword
 vnet_interface_output_node (vlib_main_t * vm, vlib_node_runtime_t * node,
                            vlib_frame_t * frame)
 {
@@ -452,6 +867,9 @@ vnet_interface_output_node (vlib_main_t * vm, vlib_node_runtime_t * node,
   vnet_interface_output_runtime_t *rt = (void *) node->runtime_data;
   hi = vnet_get_sup_hw_interface (vnm, rt->sw_if_index);
 
+  vnet_interface_pcap_tx_trace (vm, node, frame,
+                               0 /* sw_if_index_from_buffer */ );
+
   if (hi->flags & VNET_HW_INTERFACE_FLAG_SUPPORTS_TX_L4_CKSUM_OFFLOAD)
     return vnet_interface_output_node_inline (vm, node, frame, vnm, hi,
                                              /* do_tx_offloads */ 0);
@@ -459,20 +877,21 @@ vnet_interface_output_node (vlib_main_t * vm, vlib_node_runtime_t * node,
     return vnet_interface_output_node_inline (vm, node, frame, vnm, hi,
                                              /* do_tx_offloads */ 1);
 }
-
-VLIB_NODE_FUNCTION_MULTIARCH_CLONE (vnet_interface_output_node);
-CLIB_MULTIARCH_SELECT_FN (vnet_interface_output_node);
+#endif /* CLIB_MARCH_VARIANT */
 
 /* Use buffer's sw_if_index[VNET_TX] to choose output interface. */
-static uword
-vnet_per_buffer_interface_output (vlib_main_t * vm,
-                                 vlib_node_runtime_t * node,
-                                 vlib_frame_t * frame)
+VLIB_NODE_FN (vnet_per_buffer_interface_output_node) (vlib_main_t * vm,
+                                                     vlib_node_runtime_t *
+                                                     node,
+                                                     vlib_frame_t * frame)
 {
   vnet_main_t *vnm = vnet_get_main ();
   u32 n_left_to_next, *from, *to_next;
   u32 n_left_from, next_index;
 
+  vnet_interface_pcap_tx_trace (vm, node, frame,
+                               1 /* sw_if_index_from_buffer */ );
+
   n_left_from = frame->n_vectors;
 
   from = vlib_frame_vector_args (frame);
@@ -553,43 +972,28 @@ vnet_per_buffer_interface_output (vlib_main_t * vm,
   return frame->n_vectors;
 }
 
-always_inline u32
-counter_index (vlib_main_t * vm, vlib_error_t e)
+typedef struct vnet_error_trace_t_
 {
-  vlib_node_t *n;
-  u32 ci, ni;
-
-  ni = vlib_error_get_node (e);
-  n = vlib_get_node (vm, ni);
-
-  ci = vlib_error_get_code (e);
-  ASSERT (ci < n->n_errors);
-
-  ci += n->error_heap_index;
+  u32 sw_if_index;
+} vnet_error_trace_t;
 
-  return ci;
-}
 
 static u8 *
 format_vnet_error_trace (u8 * s, va_list * va)
 {
-  vlib_main_t *vm = va_arg (*va, vlib_main_t *);
+  CLIB_UNUSED (vlib_main_t * vm) = va_arg (*va, vlib_main_t *);
   CLIB_UNUSED (vlib_node_t * node) = va_arg (*va, vlib_node_t *);
-  vlib_error_t *e = va_arg (*va, vlib_error_t *);
-  vlib_node_t *error_node;
-  vlib_error_main_t *em = &vm->error_main;
-  u32 i;
+  vnet_error_trace_t *t = va_arg (*va, vnet_error_trace_t *);
 
-  error_node = vlib_get_node (vm, vlib_error_get_node (e[0]));
-  i = counter_index (vm, e[0]);
-  s = format (s, "%v: %s", error_node->name, em->error_strings_heap[i]);
+  s = format (s, "rx:%U", format_vnet_sw_if_index_name,
+             vnet_get_main (), t->sw_if_index);
 
   return s;
 }
 
 static void
-trace_errors_with_buffers (vlib_main_t * vm,
-                          vlib_node_runtime_t * node, vlib_frame_t * frame)
+interface_trace_buffers (vlib_main_t * vm,
+                        vlib_node_runtime_t * node, vlib_frame_t * frame)
 {
   u32 n_left, *buffers;
 
@@ -600,7 +1004,7 @@ trace_errors_with_buffers (vlib_main_t * vm,
     {
       u32 bi0, bi1;
       vlib_buffer_t *b0, *b1;
-      vlib_error_t *t0, *t1;
+      vnet_error_trace_t *t0, *t1;
 
       /* Prefetch next iteration. */
       vlib_prefetch_buffer_with_index (vm, buffers[2], LOAD);
@@ -615,12 +1019,12 @@ trace_errors_with_buffers (vlib_main_t * vm,
       if (b0->flags & VLIB_BUFFER_IS_TRACED)
        {
          t0 = vlib_add_trace (vm, node, b0, sizeof (t0[0]));
-         t0[0] = b0->error;
+         t0->sw_if_index = vnet_buffer (b0)->sw_if_index[VLIB_RX];
        }
       if (b1->flags & VLIB_BUFFER_IS_TRACED)
        {
          t1 = vlib_add_trace (vm, node, b1, sizeof (t1[0]));
-         t1[0] = b1->error;
+         t1->sw_if_index = vnet_buffer (b1)->sw_if_index[VLIB_RX];
        }
       buffers += 2;
       n_left -= 2;
@@ -630,7 +1034,7 @@ trace_errors_with_buffers (vlib_main_t * vm,
     {
       u32 bi0;
       vlib_buffer_t *b0;
-      vlib_error_t *t0;
+      vnet_error_trace_t *t0;
 
       bi0 = buffers[0];
 
@@ -639,52 +1043,13 @@ trace_errors_with_buffers (vlib_main_t * vm,
       if (b0->flags & VLIB_BUFFER_IS_TRACED)
        {
          t0 = vlib_add_trace (vm, node, b0, sizeof (t0[0]));
-         t0[0] = b0->error;
+         t0->sw_if_index = vnet_buffer (b0)->sw_if_index[VLIB_RX];
        }
       buffers += 1;
       n_left -= 1;
     }
 }
 
-static u8 *
-validate_error (vlib_main_t * vm, vlib_error_t * e, u32 index)
-{
-  uword node_index = vlib_error_get_node (e[0]);
-  uword code = vlib_error_get_code (e[0]);
-  vlib_node_t *n;
-
-  if (node_index >= vec_len (vm->node_main.nodes))
-    return format (0, "[%d], node index out of range 0x%x, error 0x%x",
-                  index, node_index, e[0]);
-
-  n = vlib_get_node (vm, node_index);
-  if (code >= n->n_errors)
-    return format (0, "[%d], code %d out of range for node %v",
-                  index, code, n->name);
-
-  return 0;
-}
-
-static u8 *
-validate_error_frame (vlib_main_t * vm,
-                     vlib_node_runtime_t * node, vlib_frame_t * f)
-{
-  u32 *buffers = vlib_frame_vector_args (f);
-  vlib_buffer_t *b;
-  u8 *msg = 0;
-  uword i;
-
-  for (i = 0; i < f->n_vectors; i++)
-    {
-      b = vlib_get_buffer (vm, buffers[i]);
-      msg = validate_error (vm, &b->error, i);
-      if (msg)
-       return msg;
-    }
-
-  return msg;
-}
-
 typedef enum
 {
   VNET_ERROR_DISPOSITION_DROP,
@@ -692,206 +1057,94 @@ typedef enum
   VNET_ERROR_N_DISPOSITION,
 } vnet_error_disposition_t;
 
-always_inline void
-do_packet (vlib_main_t * vm, vlib_error_t a)
-{
-  vlib_error_main_t *em = &vm->error_main;
-  u32 i = counter_index (vm, a);
-  em->counters[i] += 1;
-  vlib_error_elog_count (vm, i, 1);
-}
-
 static_always_inline uword
-process_drop_punt (vlib_main_t * vm,
-                  vlib_node_runtime_t * node,
-                  vlib_frame_t * frame, vnet_error_disposition_t disposition)
+interface_drop_punt (vlib_main_t * vm,
+                    vlib_node_runtime_t * node,
+                    vlib_frame_t * frame,
+                    vnet_error_disposition_t disposition)
 {
-  vnet_main_t *vnm = vnet_get_main ();
-  vlib_error_main_t *em = &vm->error_main;
-  u32 *buffers, *first_buffer;
-  vlib_error_t current_error;
-  u32 current_counter_index, n_errors_left;
-  u32 current_sw_if_index, n_errors_current_sw_if_index;
-  u64 current_counter;
+  u32 *from, n_left, thread_index, *sw_if_index;
+  vlib_buffer_t *bufs[VLIB_FRAME_SIZE], **b;
+  u32 sw_if_indices[VLIB_FRAME_SIZE];
   vlib_simple_counter_main_t *cm;
-  u32 thread_index = vm->thread_index;
-
-  static vlib_error_t memory[VNET_ERROR_N_DISPOSITION];
-  static char memory_init[VNET_ERROR_N_DISPOSITION];
-
-  buffers = vlib_frame_vector_args (frame);
-  first_buffer = buffers;
-
-  {
-    vlib_buffer_t *b = vlib_get_buffer (vm, first_buffer[0]);
+  u16 nexts[VLIB_FRAME_SIZE];
+  vnet_main_t *vnm;
 
-    if (!memory_init[disposition])
-      {
-       memory_init[disposition] = 1;
-       memory[disposition] = b->error;
-      }
-
-    current_sw_if_index = vnet_buffer (b)->sw_if_index[VLIB_RX];
-    n_errors_current_sw_if_index = 0;
-  }
+  vnm = vnet_get_main ();
+  thread_index = vm->thread_index;
+  from = vlib_frame_vector_args (frame);
+  n_left = frame->n_vectors;
+  b = bufs;
+  sw_if_index = sw_if_indices;
 
-  current_error = memory[disposition];
-  current_counter_index = counter_index (vm, memory[disposition]);
-  current_counter = em->counters[current_counter_index];
+  vlib_get_buffers (vm, from, bufs, n_left);
 
   if (node->flags & VLIB_NODE_FLAG_TRACE)
-    trace_errors_with_buffers (vm, node, frame);
+    interface_trace_buffers (vm, node, frame);
+
+  /* All going to drop regardless, this is just a counting exercise */
+  clib_memset (nexts, 0, sizeof (nexts));
 
-  n_errors_left = frame->n_vectors;
   cm = vec_elt_at_index (vnm->interface_main.sw_if_counters,
                         (disposition == VNET_ERROR_DISPOSITION_PUNT
                          ? VNET_INTERFACE_COUNTER_PUNT
                          : VNET_INTERFACE_COUNTER_DROP));
 
-  while (n_errors_left >= 2)
+  /* collect the array of interfaces first ... */
+  while (n_left >= 4)
     {
-      vlib_buffer_t *b0, *b1;
-      vnet_sw_interface_t *sw_if0, *sw_if1;
-      vlib_error_t e0, e1;
-      u32 bi0, bi1;
-      u32 sw_if_index0, sw_if_index1;
-
-      bi0 = buffers[0];
-      bi1 = buffers[1];
-
-      buffers += 2;
-      n_errors_left -= 2;
-
-      b0 = vlib_get_buffer (vm, bi0);
-      b1 = vlib_get_buffer (vm, bi1);
-
-      e0 = b0->error;
-      e1 = b1->error;
-
-      sw_if_index0 = vnet_buffer (b0)->sw_if_index[VLIB_RX];
-      sw_if_index1 = vnet_buffer (b1)->sw_if_index[VLIB_RX];
-
-      /* Speculate that sw_if_index == sw_if_index[01]. */
-      n_errors_current_sw_if_index += 2;
-
-      /* Speculatively assume all 2 (node, code) pairs are equal
-         to current (node, code). */
-      current_counter += 2;
-
-      if (PREDICT_FALSE (e0 != current_error
-                        || e1 != current_error
-                        || sw_if_index0 != current_sw_if_index
-                        || sw_if_index1 != current_sw_if_index))
+      if (n_left >= 12)
        {
-         current_counter -= 2;
-         n_errors_current_sw_if_index -= 2;
-
-         vlib_increment_simple_counter (cm, thread_index, sw_if_index0, 1);
-         vlib_increment_simple_counter (cm, thread_index, sw_if_index1, 1);
-
-         /* Increment super-interface drop/punt counters for
-            sub-interfaces. */
-         sw_if0 = vnet_get_sw_interface (vnm, sw_if_index0);
-         vlib_increment_simple_counter
-           (cm, thread_index, sw_if0->sup_sw_if_index,
-            sw_if0->sup_sw_if_index != sw_if_index0);
-
-         sw_if1 = vnet_get_sw_interface (vnm, sw_if_index1);
-         vlib_increment_simple_counter
-           (cm, thread_index, sw_if1->sup_sw_if_index,
-            sw_if1->sup_sw_if_index != sw_if_index1);
-
-         em->counters[current_counter_index] = current_counter;
-         do_packet (vm, e0);
-         do_packet (vm, e1);
-
-         /* For 2 repeated errors, change current error. */
-         if (e0 == e1 && e1 != current_error)
-           {
-             current_error = e0;
-             current_counter_index = counter_index (vm, e0);
-           }
-         current_counter = em->counters[current_counter_index];
+         /* Prefetch 8 ahead - there's not much going on in each iteration */
+         vlib_prefetch_buffer_header (b[4], LOAD);
+         vlib_prefetch_buffer_header (b[5], LOAD);
+         vlib_prefetch_buffer_header (b[6], LOAD);
+         vlib_prefetch_buffer_header (b[7], LOAD);
        }
+      sw_if_index[0] = vnet_buffer (b[0])->sw_if_index[VLIB_RX];
+      sw_if_index[1] = vnet_buffer (b[1])->sw_if_index[VLIB_RX];
+      sw_if_index[2] = vnet_buffer (b[2])->sw_if_index[VLIB_RX];
+      sw_if_index[3] = vnet_buffer (b[3])->sw_if_index[VLIB_RX];
+
+      sw_if_index += 4;
+      n_left -= 4;
+      b += 4;
     }
-
-  while (n_errors_left >= 1)
+  while (n_left)
     {
-      vlib_buffer_t *b0;
-      vnet_sw_interface_t *sw_if0;
-      vlib_error_t e0;
-      u32 bi0, sw_if_index0;
-
-      bi0 = buffers[0];
+      sw_if_index[0] = vnet_buffer (b[0])->sw_if_index[VLIB_RX];
 
-      buffers += 1;
-      n_errors_left -= 1;
-      current_counter += 1;
-
-      b0 = vlib_get_buffer (vm, bi0);
-      e0 = b0->error;
-
-      sw_if_index0 = vnet_buffer (b0)->sw_if_index[VLIB_RX];
-
-      /* Increment drop/punt counters. */
-      vlib_increment_simple_counter (cm, thread_index, sw_if_index0, 1);
-
-      /* Increment super-interface drop/punt counters for sub-interfaces. */
-      sw_if0 = vnet_get_sw_interface (vnm, sw_if_index0);
-      vlib_increment_simple_counter (cm, thread_index,
-                                    sw_if0->sup_sw_if_index,
-                                    sw_if0->sup_sw_if_index != sw_if_index0);
-
-      if (PREDICT_FALSE (e0 != current_error))
-       {
-         current_counter -= 1;
-
-         vlib_error_elog_count (vm, current_counter_index,
-                                (current_counter
-                                 - em->counters[current_counter_index]));
-
-         em->counters[current_counter_index] = current_counter;
-
-         do_packet (vm, e0);
-         current_error = e0;
-         current_counter_index = counter_index (vm, e0);
-         current_counter = em->counters[current_counter_index];
-       }
+      sw_if_index += 1;
+      n_left -= 1;
+      b += 1;
     }
 
-  if (n_errors_current_sw_if_index > 0)
-    {
-      vnet_sw_interface_t *si;
-
-      vlib_increment_simple_counter (cm, thread_index, current_sw_if_index,
-                                    n_errors_current_sw_if_index);
+  /* ... then count against them in blocks */
+  n_left = frame->n_vectors;
 
-      si = vnet_get_sw_interface (vnm, current_sw_if_index);
-      if (si->sup_sw_if_index != current_sw_if_index)
-       vlib_increment_simple_counter (cm, thread_index, si->sup_sw_if_index,
-                                      n_errors_current_sw_if_index);
-    }
+  while (n_left)
+    {
+      vnet_sw_interface_t *sw_if0;
+      u16 off, count;
 
-  vlib_error_elog_count (vm, current_counter_index,
-                        (current_counter
-                         - em->counters[current_counter_index]));
+      off = frame->n_vectors - n_left;
 
-  /* Return cached counter. */
-  em->counters[current_counter_index] = current_counter;
+      sw_if_index = sw_if_indices + off;
 
-  /* Save memory for next iteration. */
-  memory[disposition] = current_error;
+      count = clib_count_equal_u32 (sw_if_index, n_left);
+      n_left -= count;
 
-  if (disposition == VNET_ERROR_DISPOSITION_DROP || !vm->os_punt_frame)
-    {
-      vlib_buffer_free (vm, first_buffer, frame->n_vectors);
+      vlib_increment_simple_counter (cm, thread_index, sw_if_index[0], count);
 
-      /* If there is no punt function, free the frame as well. */
-      if (disposition == VNET_ERROR_DISPOSITION_PUNT && !vm->os_punt_frame)
-       vlib_frame_free (vm, node, frame);
+      /* Increment super-interface drop/punt counters for
+         sub-interfaces. */
+      sw_if0 = vnet_get_sw_interface (vnm, sw_if_index[0]);
+      if (sw_if0->sup_sw_if_index != sw_if_index[0])
+       vlib_increment_simple_counter
+         (cm, thread_index, sw_if0->sup_sw_if_index, count);
     }
-  else
-    vm->os_punt_frame (vm, node, frame);
+
+  vlib_buffer_enqueue_to_next (vm, node, from, nexts, frame->n_vectors);
 
   return frame->n_vectors;
 }
@@ -948,6 +1201,7 @@ pcap_drop_trace (vlib_main_t * vm,
     }
 }
 
+#ifndef CLIB_MARCH_VARIANT
 void
 vnet_pcap_drop_trace_filter_add_del (u32 error_index, int is_add)
 {
@@ -961,64 +1215,58 @@ vnet_pcap_drop_trace_filter_add_del (u32 error_index, int is_add)
   else
     hash_unset (im->pcap_drop_filter_hash, error_index);
 }
+#endif /* CLIB_MARCH_VARIANT */
 
-static uword
-process_drop (vlib_main_t * vm,
-             vlib_node_runtime_t * node, vlib_frame_t * frame)
+VLIB_NODE_FN (interface_drop) (vlib_main_t * vm,
+                              vlib_node_runtime_t * node,
+                              vlib_frame_t * frame)
 {
   vnet_interface_main_t *im = &vnet_get_main ()->interface_main;
 
   if (PREDICT_FALSE (im->drop_pcap_enable))
     pcap_drop_trace (vm, im, frame);
 
-  return process_drop_punt (vm, node, frame, VNET_ERROR_DISPOSITION_DROP);
+  return interface_drop_punt (vm, node, frame, VNET_ERROR_DISPOSITION_DROP);
 }
 
-static uword
-process_punt (vlib_main_t * vm,
-             vlib_node_runtime_t * node, vlib_frame_t * frame)
+VLIB_NODE_FN (interface_punt) (vlib_main_t * vm,
+                              vlib_node_runtime_t * node,
+                              vlib_frame_t * frame)
 {
-  return process_drop_punt (vm, node, frame, VNET_ERROR_DISPOSITION_PUNT);
+  return interface_drop_punt (vm, node, frame, VNET_ERROR_DISPOSITION_PUNT);
 }
 
 /* *INDENT-OFF* */
-VLIB_REGISTER_NODE (drop_buffers,static) = {
-  .function = process_drop,
+VLIB_REGISTER_NODE (interface_drop) = {
   .name = "error-drop",
-  .flags = VLIB_NODE_FLAG_IS_DROP,
   .vector_size = sizeof (u32),
   .format_trace = format_vnet_error_trace,
-  .validate_frame = validate_error_frame,
+  .n_next_nodes = 1,
+  .next_nodes = {
+    [0] = "drop",
+  },
 };
 /* *INDENT-ON* */
 
-VLIB_NODE_FUNCTION_MULTIARCH (drop_buffers, process_drop);
-
 /* *INDENT-OFF* */
-VLIB_REGISTER_NODE (punt_buffers,static) = {
-  .function = process_punt,
-  .flags = (VLIB_NODE_FLAG_FRAME_NO_FREE_AFTER_DISPATCH
-           | VLIB_NODE_FLAG_IS_PUNT),
+VLIB_REGISTER_NODE (interface_punt) = {
   .name = "error-punt",
   .vector_size = sizeof (u32),
   .format_trace = format_vnet_error_trace,
-  .validate_frame = validate_error_frame,
+  .n_next_nodes = 1,
+  .next_nodes = {
+    [0] = "punt",
+  },
 };
 /* *INDENT-ON* */
 
-VLIB_NODE_FUNCTION_MULTIARCH (punt_buffers, process_punt);
-
 /* *INDENT-OFF* */
-VLIB_REGISTER_NODE (vnet_per_buffer_interface_output_node,static) = {
-  .function = vnet_per_buffer_interface_output,
+VLIB_REGISTER_NODE (vnet_per_buffer_interface_output_node) = {
   .name = "interface-output",
   .vector_size = sizeof (u32),
 };
 /* *INDENT-ON* */
 
-VLIB_NODE_FUNCTION_MULTIARCH (vnet_per_buffer_interface_output_node,
-                             vnet_per_buffer_interface_output);
-
 static uword
 interface_tx_node_fn (vlib_main_t * vm, vlib_node_runtime_t * node,
                      vlib_frame_t * from_frame)
@@ -1080,6 +1328,7 @@ VNET_FEATURE_ARC_INIT (interface_output, static) =
 {
   .arc_name  = "interface-output",
   .start_nodes = VNET_FEATURES (0),
+  .last_in_arc = "interface-tx",
   .arc_index_ptr = &vnet_main.interface_main.output_feature_arc_index,
 };
 
@@ -1102,6 +1351,7 @@ VNET_FEATURE_INIT (interface_tx, static) = {
 };
 /* *INDENT-ON* */
 
+#ifndef CLIB_MARCH_VARIANT
 clib_error_t *
 vnet_per_buffer_interface_output_hw_interface_add_del (vnet_main_t * vnm,
                                                       u32 hw_if_index,
@@ -1135,6 +1385,7 @@ vnet_set_interface_output_node (vnet_main_t * vnm,
   hi->output_node_next_index = next_index;
   hi->output_node_index = node_index;
 }
+#endif /* CLIB_MARCH_VARIANT */
 
 static clib_error_t *
 pcap_drop_trace_command_fn (vlib_main_t * vm,