ip: fix coverity warning
[vpp.git] / src / vnet / ip / ip6_input.c
index 2030608..943f659 100644 (file)
@@ -37,7 +37,7 @@
  *  WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
  */
 
-#include <vnet/ip/ip.h>
+#include <vnet/ip/ip6_input.h>
 #include <vnet/ethernet/ethernet.h>
 #include <vnet/ppp/ppp.h>
 #include <vnet/hdlc/hdlc.h>
@@ -60,19 +60,10 @@ format_ip6_input_trace (u8 * s, va_list * va)
   return s;
 }
 
-typedef enum
-{
-  IP6_INPUT_NEXT_DROP,
-  IP6_INPUT_NEXT_LOOKUP,
-  IP6_INPUT_NEXT_LOOKUP_MULTICAST,
-  IP6_INPUT_NEXT_ICMP_ERROR,
-  IP6_INPUT_N_NEXT,
-} ip6_input_next_t;
-
 /* Validate IP v6 packets and pass them either to forwarding code
    or drop exception packets. */
-static uword
-ip6_input (vlib_main_t * vm, vlib_node_runtime_t * node, vlib_frame_t * frame)
+VLIB_NODE_FN (ip6_input_node) (vlib_main_t * vm, vlib_node_runtime_t * node,
+                              vlib_frame_t * frame)
 {
   vnet_main_t *vnm = vnet_get_main ();
   ip6_main_t *im = &ip6_main;
@@ -82,7 +73,7 @@ ip6_input (vlib_main_t * vm, vlib_node_runtime_t * node, vlib_frame_t * frame)
   vlib_node_runtime_t *error_node =
     vlib_node_get_runtime (vm, ip6_input_node.index);
   vlib_simple_counter_main_t *cm;
-  u32 cpu_index = os_get_cpu_number ();
+  u32 thread_index = vm->thread_index;
 
   from = vlib_frame_vector_args (frame);
   n_left_from = frame->n_vectors;
@@ -108,7 +99,7 @@ ip6_input (vlib_main_t * vm, vlib_node_runtime_t * node, vlib_frame_t * frame)
          ip6_header_t *ip0, *ip1;
          u32 pi0, sw_if_index0, next0 = 0;
          u32 pi1, sw_if_index1, next1 = 0;
-         u8 error0, error1, arc0, arc1;
+         u8 arc0, arc1;
 
          /* Prefetch next iteration. */
          {
@@ -171,67 +162,10 @@ ip6_input (vlib_main_t * vm, vlib_node_runtime_t * node, vlib_frame_t * frame)
          vnet_feature_arc_start (arc0, sw_if_index0, &next0, p0);
          vnet_feature_arc_start (arc1, sw_if_index1, &next1, p1);
 
-         vlib_increment_simple_counter (cm, cpu_index, sw_if_index0, 1);
-         vlib_increment_simple_counter (cm, cpu_index, sw_if_index1, 1);
-
-         error0 = error1 = IP6_ERROR_NONE;
-
-         /* Version != 6?  Drop it. */
-         error0 =
-           (clib_net_to_host_u32
-            (ip0->ip_version_traffic_class_and_flow_label) >> 28) !=
-           6 ? IP6_ERROR_VERSION : error0;
-         error1 =
-           (clib_net_to_host_u32
-            (ip1->ip_version_traffic_class_and_flow_label) >> 28) !=
-           6 ? IP6_ERROR_VERSION : error1;
-
-         /* hop limit < 1? Drop it.  for link-local broadcast packets,
-          * like dhcpv6 packets from client has hop-limit 1, which should not
-          * be dropped.
-          */
-         error0 = ip0->hop_limit < 1 ? IP6_ERROR_TIME_EXPIRED : error0;
-         error1 = ip1->hop_limit < 1 ? IP6_ERROR_TIME_EXPIRED : error1;
-
-         /* L2 length must be at least minimal IP header. */
-         error0 =
-           p0->current_length <
-           sizeof (ip0[0]) ? IP6_ERROR_TOO_SHORT : error0;
-         error1 =
-           p1->current_length <
-           sizeof (ip1[0]) ? IP6_ERROR_TOO_SHORT : error1;
-
-         if (PREDICT_FALSE (error0 != IP6_ERROR_NONE))
-           {
-             if (error0 == IP6_ERROR_TIME_EXPIRED)
-               {
-                 icmp6_error_set_vnet_buffer (p0, ICMP6_time_exceeded,
-                                              ICMP6_time_exceeded_ttl_exceeded_in_transit,
-                                              0);
-                 next0 = IP6_INPUT_NEXT_ICMP_ERROR;
-               }
-             else
-               {
-                 next0 = IP6_INPUT_NEXT_DROP;
-               }
-           }
-         if (PREDICT_FALSE (error1 != IP6_ERROR_NONE))
-           {
-             if (error1 == IP6_ERROR_TIME_EXPIRED)
-               {
-                 icmp6_error_set_vnet_buffer (p1, ICMP6_time_exceeded,
-                                              ICMP6_time_exceeded_ttl_exceeded_in_transit,
-                                              0);
-                 next1 = IP6_INPUT_NEXT_ICMP_ERROR;
-               }
-             else
-               {
-                 next1 = IP6_INPUT_NEXT_DROP;
-               }
-           }
-
-         p0->error = error_node->errors[error0];
-         p1->error = error_node->errors[error1];
+         vlib_increment_simple_counter (cm, thread_index, sw_if_index0, 1);
+         vlib_increment_simple_counter (cm, thread_index, sw_if_index1, 1);
+         ip6_input_check_x2 (vm, error_node,
+                             p0, p1, ip0, ip1, &next0, &next1);
 
          vlib_validate_buffer_enqueue_x2 (vm, node, next_index,
                                           to_next, n_left_to_next,
@@ -243,7 +177,7 @@ ip6_input (vlib_main_t * vm, vlib_node_runtime_t * node, vlib_frame_t * frame)
          vlib_buffer_t *p0;
          ip6_header_t *ip0;
          u32 pi0, sw_if_index0, next0 = 0;
-         u8 error0, arc0;
+         u8 arc0;
 
          pi0 = from[0];
          to_next[0] = pi0;
@@ -270,41 +204,8 @@ ip6_input (vlib_main_t * vm, vlib_node_runtime_t * node, vlib_frame_t * frame)
          vnet_buffer (p0)->ip.adj_index[VLIB_RX] = ~0;
          vnet_feature_arc_start (arc0, sw_if_index0, &next0, p0);
 
-         vlib_increment_simple_counter (cm, cpu_index, sw_if_index0, 1);
-         error0 = IP6_ERROR_NONE;
-
-         /* Version != 6?  Drop it. */
-         error0 =
-           (clib_net_to_host_u32
-            (ip0->ip_version_traffic_class_and_flow_label) >> 28) !=
-           6 ? IP6_ERROR_VERSION : error0;
-
-         /* hop limit < 1? Drop it. for link-local broadcast packets,
-          * like dhcpv6 packets from client has hop-limit 1, which should not
-          * be dropped.
-          */
-         error0 = ip0->hop_limit < 1 ? IP6_ERROR_TIME_EXPIRED : error0;
-
-         /* L2 length must be at least minimal IP header. */
-         error0 =
-           p0->current_length <
-           sizeof (ip0[0]) ? IP6_ERROR_TOO_SHORT : error0;
-
-         if (PREDICT_FALSE (error0 != IP6_ERROR_NONE))
-           {
-             if (error0 == IP6_ERROR_TIME_EXPIRED)
-               {
-                 icmp6_error_set_vnet_buffer (p0, ICMP6_time_exceeded,
-                                              ICMP6_time_exceeded_ttl_exceeded_in_transit,
-                                              0);
-                 next0 = IP6_INPUT_NEXT_ICMP_ERROR;
-               }
-             else
-               {
-                 next0 = IP6_INPUT_NEXT_DROP;
-               }
-           }
-         p0->error = error_node->errors[error0];
+         vlib_increment_simple_counter (cm, thread_index, sw_if_index0, 1);
+         ip6_input_check_x1 (vm, error_node, p0, ip0, &next0);
 
          vlib_validate_buffer_enqueue_x1 (vm, node, next_index,
                                           to_next, n_left_to_next,
@@ -317,15 +218,16 @@ ip6_input (vlib_main_t * vm, vlib_node_runtime_t * node, vlib_frame_t * frame)
   return frame->n_vectors;
 }
 
-static char *ip6_error_strings[] = {
+#ifndef CLIB_MARCH_VARIANT
+char *ip6_error_strings[] = {
 #define _(sym,string) string,
   foreach_ip6_error
 #undef _
 };
+#endif /* CLIB_MARCH_VARIANT */
 
 /* *INDENT-OFF* */
 VLIB_REGISTER_NODE (ip6_input_node) = {
-  .function = ip6_input,
   .name = "ip6-input",
   .vector_size = sizeof (u32),
 
@@ -345,8 +247,27 @@ VLIB_REGISTER_NODE (ip6_input_node) = {
 };
 /* *INDENT-ON* */
 
-VLIB_NODE_FUNCTION_MULTIARCH (ip6_input_node, ip6_input)
-     static clib_error_t *ip6_init (vlib_main_t * vm)
+static u8 *
+format_ipv6_fragmentation (u8 * s, va_list * args)
+{
+  ip6_frag_hdr_t *h = va_arg (*args, ip6_frag_hdr_t *);
+  u32 max_header_bytes = va_arg (*args, u32);
+  u32 header_bytes;
+
+  header_bytes = sizeof (h[0]);
+  if (max_header_bytes != 0 && header_bytes > max_header_bytes)
+    return format (s, "ipv6 frag header truncated");
+
+  s =
+    format (s,
+           "fragmentation header: next_hdr: %u, rsv: %u, frag_offset_and_more: %u, id: %u",
+           h->next_hdr, h->rsv, h->fragment_offset_and_more,
+           clib_net_to_host_u32 (h->identification));
+  return s;
+}
+
+static clib_error_t *
+ip6_init (vlib_main_t * vm)
 {
   ethernet_register_input_type (vm, ETHERNET_TYPE_IP6, ip6_input_node.index);
   ppp_register_input_protocol (vm, PPP_PROTOCOL_ip6, ip6_input_node.index);
@@ -364,11 +285,33 @@ VLIB_NODE_FUNCTION_MULTIARCH (ip6_input_node, ip6_input)
   /* Default hop limit for packets we generate. */
   ip6_main.host_config.ttl = 64;
 
+
+  uword *u = hash_get (ip_main.protocol_info_by_name, "IPV6_FRAGMENTATION");
+  if (u)
+    {
+      ip_protocol_info_t *info =
+       vec_elt_at_index (ip_main.protocol_infos, *u);
+      ASSERT (NULL == info->format_header);
+      info->format_header = format_ipv6_fragmentation;
+    }
   return /* no error */ 0;
 }
 
 VLIB_INIT_FUNCTION (ip6_init);
 
+static clib_error_t *
+ip6_main_loop_enter (vlib_main_t * vm)
+{
+  ip6_main_t *im = &ip6_main;
+  vlib_thread_main_t *tm = &vlib_thread_main;
+
+  throttle_init (&im->nd_throttle, tm->n_vlib_mains, 1e-3);
+
+  return 0;
+}
+
+VLIB_MAIN_LOOP_ENTER_FUNCTION (ip6_main_loop_enter);
+
 /*
  * fd.io coding-style-patch-verification: ON
  *