ip: fix buffer leaks in reassembly
[vpp.git] / src / vnet / ip / reass / ip4_full_reass.c
index 69d418e..b0840b1 100644 (file)
@@ -177,17 +177,19 @@ typedef struct
   // convenience
   vlib_main_t *vlib_main;
 
-  // node index of ip4-drop node
-  u32 ip4_drop_idx;
   u32 ip4_full_reass_expire_node_idx;
 
   /** Worker handoff */
   u32 fq_index;
+  u32 fq_local_index;
   u32 fq_feature_index;
   u32 fq_custom_index;
 
   // reference count for enabling/disabling feature - per interface
   u32 *feature_use_refcount_per_intf;
+
+  // whether local fragmented packets are reassembled or not
+  int is_local_reass_enabled;
 } ip4_full_reass_main_t;
 
 extern ip4_full_reass_main_t ip4_full_reass_main;
@@ -219,6 +221,7 @@ typedef enum
   RANGE_OVERLAP,
   FINALIZE,
   HANDOFF,
+  PASSTHROUGH,
 } ip4_full_reass_trace_operation_e;
 
 typedef struct
@@ -329,13 +332,15 @@ format_ip4_full_reass_trace (u8 * s, va_list * args)
        format (s, "handoff from thread #%u to thread #%u", t->thread_id,
                t->thread_id_to);
       break;
+    case PASSTHROUGH:
+      s = format (s, "passthrough - not a fragment");
+      break;
     }
   return s;
 }
 
 static void
 ip4_full_reass_add_trace (vlib_main_t * vm, vlib_node_runtime_t * node,
-                         ip4_full_reass_main_t * rm,
                          ip4_full_reass_t * reass, u32 bi,
                          ip4_full_reass_trace_operation_e action,
                          u32 size_diff, u32 thread_id_to)
@@ -413,8 +418,8 @@ ip4_full_reass_free (ip4_full_reass_main_t * rm,
 }
 
 always_inline void
-ip4_full_reass_drop_all (vlib_main_t * vm, vlib_node_runtime_t * node,
-                        ip4_full_reass_main_t * rm, ip4_full_reass_t * reass)
+ip4_full_reass_drop_all (vlib_main_t *vm, vlib_node_runtime_t *node,
+                        ip4_full_reass_t *reass, u32 offending_bi)
 {
   u32 range_bi = reass->first_bi;
   vlib_buffer_t *range_b;
@@ -428,6 +433,10 @@ ip4_full_reass_drop_all (vlib_main_t * vm, vlib_node_runtime_t * node,
       while (~0 != bi)
        {
          vec_add1 (to_free, bi);
+         if (offending_bi == bi)
+           {
+             offending_bi = ~0;
+           }
          vlib_buffer_t *b = vlib_get_buffer (vm, bi);
          if (b->flags & VLIB_BUFFER_NEXT_PRESENT)
            {
@@ -441,6 +450,10 @@ ip4_full_reass_drop_all (vlib_main_t * vm, vlib_node_runtime_t * node,
        }
       range_bi = range_vnb->ip.reass.next_range_bi;
     }
+  if (~0 != offending_bi)
+    {
+      vec_add1 (to_free, offending_bi);
+    }
   /* send to next_error_index */
   if (~0 != reass->error_next_index)
     {
@@ -511,7 +524,7 @@ again:
 
       if (now > reass->last_heard + rm->timeout)
        {
-         ip4_full_reass_drop_all (vm, node, rm, reass);
+         ip4_full_reass_drop_all (vm, node, reass, ~0);
          ip4_full_reass_free (rm, rt, reass);
          reass = NULL;
        }
@@ -717,8 +730,8 @@ ip4_full_reass_finalize (vlib_main_t * vm, vlib_node_runtime_t * node,
   first_b->flags &= ~VLIB_BUFFER_EXT_HDR_VALID;
   if (PREDICT_FALSE (first_b->flags & VLIB_BUFFER_IS_TRACED))
     {
-      ip4_full_reass_add_trace (vm, node, rm, reass, reass->first_bi,
-                               FINALIZE, 0, ~0);
+      ip4_full_reass_add_trace (vm, node, reass, reass->first_bi, FINALIZE, 0,
+                               ~0);
 #if 0
       // following code does a hexdump of packet fragments to stdout ...
       do
@@ -764,8 +777,6 @@ ip4_full_reass_finalize (vlib_main_t * vm, vlib_node_runtime_t * node,
 
 always_inline ip4_full_reass_rc_t
 ip4_full_reass_insert_range_in_chain (vlib_main_t * vm,
-                                     ip4_full_reass_main_t * rm,
-                                     ip4_full_reass_per_thread_t * rt,
                                      ip4_full_reass_t * reass,
                                      u32 prev_range_bi, u32 new_next_bi)
 {
@@ -799,7 +810,6 @@ ip4_full_reass_insert_range_in_chain (vlib_main_t * vm,
 always_inline ip4_full_reass_rc_t
 ip4_full_reass_remove_range_from_chain (vlib_main_t * vm,
                                        vlib_node_runtime_t * node,
-                                       ip4_full_reass_main_t * rm,
                                        ip4_full_reass_t * reass,
                                        u32 prev_range_bi, u32 discard_bi)
 {
@@ -831,8 +841,8 @@ ip4_full_reass_remove_range_from_chain (vlib_main_t * vm,
       u32 to_be_freed_bi = discard_bi;
       if (PREDICT_FALSE (discard_b->flags & VLIB_BUFFER_IS_TRACED))
        {
-         ip4_full_reass_add_trace (vm, node, rm, reass, discard_bi,
-                                   RANGE_DISCARD, 0, ~0);
+         ip4_full_reass_add_trace (vm, node, reass, discard_bi, RANGE_DISCARD,
+                                   0, ~0);
        }
       if (discard_b->flags & VLIB_BUFFER_NEXT_PRESENT)
        {
@@ -890,16 +900,14 @@ ip4_full_reass_update (vlib_main_t * vm, vlib_node_runtime_t * node,
     {
       // starting a new reassembly
       rc =
-       ip4_full_reass_insert_range_in_chain (vm, rm, rt, reass,
-                                             prev_range_bi, *bi0);
+       ip4_full_reass_insert_range_in_chain (vm, reass, prev_range_bi, *bi0);
       if (IP4_REASS_RC_OK != rc)
        {
          return rc;
        }
       if (PREDICT_FALSE (fb->flags & VLIB_BUFFER_IS_TRACED))
        {
-         ip4_full_reass_add_trace (vm, node, rm, reass, *bi0, RANGE_NEW, 0,
-                                   ~0);
+         ip4_full_reass_add_trace (vm, node, reass, *bi0, RANGE_NEW, 0, ~0);
        }
       *bi0 = ~0;
       reass->min_fragment_length = clib_net_to_host_u16 (fip->length);
@@ -922,9 +930,8 @@ ip4_full_reass_update (vlib_main_t * vm, vlib_node_runtime_t * node,
              ~0 == candidate_range_bi)
            {
              // special case - this fragment falls beyond all known ranges
-             rc =
-               ip4_full_reass_insert_range_in_chain (vm, rm, rt, reass,
-                                                     prev_range_bi, *bi0);
+             rc = ip4_full_reass_insert_range_in_chain (vm, reass,
+                                                        prev_range_bi, *bi0);
              if (IP4_REASS_RC_OK != rc)
                {
                  return rc;
@@ -937,9 +944,8 @@ ip4_full_reass_update (vlib_main_t * vm, vlib_node_runtime_t * node,
       if (fragment_last < candidate_vnb->ip.reass.range_first)
        {
          // this fragment ends before candidate range without any overlap
-         rc =
-           ip4_full_reass_insert_range_in_chain (vm, rm, rt, reass,
-                                                 prev_range_bi, *bi0);
+         rc = ip4_full_reass_insert_range_in_chain (vm, reass, prev_range_bi,
+                                                    *bi0);
          if (IP4_REASS_RC_OK != rc)
            {
              return rc;
@@ -954,7 +960,7 @@ ip4_full_reass_update (vlib_main_t * vm, vlib_node_runtime_t * node,
              // this fragment is a (sub)part of existing range, ignore it
              if (PREDICT_FALSE (fb->flags & VLIB_BUFFER_IS_TRACED))
                {
-                 ip4_full_reass_add_trace (vm, node, rm, reass, *bi0,
+                 ip4_full_reass_add_trace (vm, node, reass, *bi0,
                                            RANGE_OVERLAP, 0, ~0);
                }
              break;
@@ -974,14 +980,12 @@ ip4_full_reass_update (vlib_main_t * vm, vlib_node_runtime_t * node,
                  reass->data_len -= overlap;
                  if (PREDICT_FALSE (fb->flags & VLIB_BUFFER_IS_TRACED))
                    {
-                     ip4_full_reass_add_trace (vm, node, rm, reass,
+                     ip4_full_reass_add_trace (vm, node, reass,
                                                candidate_range_bi,
                                                RANGE_SHRINK, 0, ~0);
                    }
-                 rc =
-                   ip4_full_reass_insert_range_in_chain (vm, rm, rt, reass,
-                                                         prev_range_bi,
-                                                         *bi0);
+                 rc = ip4_full_reass_insert_range_in_chain (
+                   vm, reass, prev_range_bi, *bi0);
                  if (IP4_REASS_RC_OK != rc)
                    {
                      return rc;
@@ -1010,11 +1014,8 @@ ip4_full_reass_update (vlib_main_t * vm, vlib_node_runtime_t * node,
                  else
                    {
                      // special case - last range discarded
-                     rc =
-                       ip4_full_reass_insert_range_in_chain (vm, rm, rt,
-                                                             reass,
-                                                             candidate_range_bi,
-                                                             *bi0);
+                     rc = ip4_full_reass_insert_range_in_chain (
+                       vm, reass, candidate_range_bi, *bi0);
                      if (IP4_REASS_RC_OK != rc)
                        {
                          return rc;
@@ -1035,10 +1036,8 @@ ip4_full_reass_update (vlib_main_t * vm, vlib_node_runtime_t * node,
            {
              u32 next_range_bi = candidate_vnb->ip.reass.next_range_bi;
              // discard candidate range, probe next range
-             rc =
-               ip4_full_reass_remove_range_from_chain (vm, node, rm, reass,
-                                                       prev_range_bi,
-                                                       candidate_range_bi);
+             rc = ip4_full_reass_remove_range_from_chain (
+               vm, node, reass, prev_range_bi, candidate_range_bi);
              if (IP4_REASS_RC_OK != rc)
                {
                  return rc;
@@ -1051,10 +1050,8 @@ ip4_full_reass_update (vlib_main_t * vm, vlib_node_runtime_t * node,
              else
                {
                  // special case - last range discarded
-                 rc =
-                   ip4_full_reass_insert_range_in_chain (vm, rm, rt, reass,
-                                                         prev_range_bi,
-                                                         *bi0);
+                 rc = ip4_full_reass_insert_range_in_chain (
+                   vm, reass, prev_range_bi, *bi0);
                  if (IP4_REASS_RC_OK != rc)
                    {
                      return rc;
@@ -1070,8 +1067,7 @@ ip4_full_reass_update (vlib_main_t * vm, vlib_node_runtime_t * node,
     {
       if (PREDICT_FALSE (fb->flags & VLIB_BUFFER_IS_TRACED))
        {
-         ip4_full_reass_add_trace (vm, node, rm, reass, *bi0, RANGE_NEW, 0,
-                                   ~0);
+         ip4_full_reass_add_trace (vm, node, reass, *bi0, RANGE_NEW, 0, ~0);
        }
     }
   if (~0 != reass->last_packet_octet &&
@@ -1108,8 +1104,9 @@ ip4_full_reass_update (vlib_main_t * vm, vlib_node_runtime_t * node,
 }
 
 always_inline uword
-ip4_full_reass_inline (vlib_main_t * vm, vlib_node_runtime_t * node,
-                      vlib_frame_t * frame, ip4_full_reass_node_type_t type)
+ip4_full_reass_inline (vlib_main_t *vm, vlib_node_runtime_t *node,
+                      vlib_frame_t *frame, ip4_full_reass_node_type_t type,
+                      bool is_local)
 {
   u32 *from = vlib_frame_vector_args (frame);
   u32 n_left_from, n_left_to_next, *to_next, next_index;
@@ -1145,8 +1142,17 @@ ip4_full_reass_inline (vlib_main_t * vm, vlib_node_runtime_t * node,
                {
                  next0 = vnet_buffer (b0)->ip.reass.next_index;
                }
+             ip4_full_reass_add_trace (vm, node, NULL, bi0, PASSTHROUGH, 0,
+                                       ~0);
+             goto packet_enqueue;
+           }
+
+         if (is_local && !rm->is_local_reass_enabled)
+           {
+             next0 = IP4_FULL_REASS_NEXT_DROP;
              goto packet_enqueue;
            }
+
          const u32 fragment_first = ip4_get_fragment_offset_bytes (ip0);
          const u32 fragment_length =
            clib_net_to_host_u16 (ip0->length) - ip4_header_bytes (ip0);
@@ -1190,6 +1196,7 @@ ip4_full_reass_inline (vlib_main_t * vm, vlib_node_runtime_t * node,
          else if (reass)
            {
              u32 handoff_thread_idx;
+             u32 counter = ~0;
              switch (ip4_full_reass_update
                      (vm, node, rm, rt, reass, &bi0, &next0,
                       &error0, CUSTOM == type, &handoff_thread_idx))
@@ -1204,29 +1211,23 @@ ip4_full_reass_inline (vlib_main_t * vm, vlib_node_runtime_t * node,
                    handoff_thread_idx;
                  break;
                case IP4_REASS_RC_TOO_MANY_FRAGMENTS:
-                 vlib_node_increment_counter (vm, node->node_index,
-                                              IP4_ERROR_REASS_FRAGMENT_CHAIN_TOO_LONG,
-                                              1);
-                 ip4_full_reass_drop_all (vm, node, rm, reass);
-                 ip4_full_reass_free (rm, rt, reass);
-                 goto next_packet;
+                 counter = IP4_ERROR_REASS_FRAGMENT_CHAIN_TOO_LONG;
                  break;
                case IP4_REASS_RC_NO_BUF:
-                 vlib_node_increment_counter (vm, node->node_index,
-                                              IP4_ERROR_REASS_NO_BUF, 1);
-                 ip4_full_reass_drop_all (vm, node, rm, reass);
-                 ip4_full_reass_free (rm, rt, reass);
-                 goto next_packet;
+                 counter = IP4_ERROR_REASS_NO_BUF;
                  break;
                case IP4_REASS_RC_INTERNAL_ERROR:
-                 /* drop everything and start with a clean slate */
-                 vlib_node_increment_counter (vm, node->node_index,
-                                              IP4_ERROR_REASS_INTERNAL_ERROR,
+                 counter = IP4_ERROR_REASS_INTERNAL_ERROR;
+                 break;
+               }
+
+             if (~0 != counter)
+               {
+                 vlib_node_increment_counter (vm, node->node_index, counter,
                                               1);
-                 ip4_full_reass_drop_all (vm, node, rm, reass);
+                 ip4_full_reass_drop_all (vm, node, reass, bi0);
                  ip4_full_reass_free (rm, rt, reass);
                  goto next_packet;
-                 break;
                }
            }
          else
@@ -1255,10 +1256,9 @@ ip4_full_reass_inline (vlib_main_t * vm, vlib_node_runtime_t * node,
                {
                  if (PREDICT_FALSE (b0->flags & VLIB_BUFFER_IS_TRACED))
                    {
-                     ip4_full_reass_add_trace (vm, node, rm, NULL, bi0,
-                                               HANDOFF, 0,
-                                               vnet_buffer (b0)->ip.
-                                               reass.owner_thread_index);
+                     ip4_full_reass_add_trace (
+                       vm, node, NULL, bi0, HANDOFF, 0,
+                       vnet_buffer (b0)->ip.reass.owner_thread_index);
                    }
                }
              else if (FEATURE == type && IP4_ERROR_NONE == error0)
@@ -1293,10 +1293,9 @@ VLIB_NODE_FN (ip4_full_reass_node) (vlib_main_t * vm,
                                    vlib_node_runtime_t * node,
                                    vlib_frame_t * frame)
 {
-  return ip4_full_reass_inline (vm, node, frame, NORMAL);
+  return ip4_full_reass_inline (vm, node, frame, NORMAL, false /* is_local */);
 }
 
-/* *INDENT-OFF* */
 VLIB_REGISTER_NODE (ip4_full_reass_node) = {
     .name = "ip4-full-reassembly",
     .vector_size = sizeof (u32),
@@ -1312,16 +1311,37 @@ VLIB_REGISTER_NODE (ip4_full_reass_node) = {
 
         },
 };
-/* *INDENT-ON* */
+
+VLIB_NODE_FN (ip4_local_full_reass_node)
+(vlib_main_t *vm, vlib_node_runtime_t *node, vlib_frame_t *frame)
+{
+  return ip4_full_reass_inline (vm, node, frame, NORMAL, true /* is_local */);
+}
+
+VLIB_REGISTER_NODE (ip4_local_full_reass_node) = {
+    .name = "ip4-local-full-reassembly",
+    .vector_size = sizeof (u32),
+    .format_trace = format_ip4_full_reass_trace,
+    .n_errors = ARRAY_LEN (ip4_full_reass_error_strings),
+    .error_strings = ip4_full_reass_error_strings,
+    .n_next_nodes = IP4_FULL_REASS_N_NEXT,
+    .next_nodes =
+        {
+                [IP4_FULL_REASS_NEXT_INPUT] = "ip4-input",
+                [IP4_FULL_REASS_NEXT_DROP] = "ip4-drop",
+                [IP4_FULL_REASS_NEXT_HANDOFF] = "ip4-local-full-reassembly-handoff",
+
+        },
+};
 
 VLIB_NODE_FN (ip4_full_reass_node_feature) (vlib_main_t * vm,
                                            vlib_node_runtime_t * node,
                                            vlib_frame_t * frame)
 {
-  return ip4_full_reass_inline (vm, node, frame, FEATURE);
+  return ip4_full_reass_inline (vm, node, frame, FEATURE,
+                               false /* is_local */);
 }
 
-/* *INDENT-OFF* */
 VLIB_REGISTER_NODE (ip4_full_reass_node_feature) = {
     .name = "ip4-full-reassembly-feature",
     .vector_size = sizeof (u32),
@@ -1336,9 +1356,7 @@ VLIB_REGISTER_NODE (ip4_full_reass_node_feature) = {
                 [IP4_FULL_REASS_NEXT_HANDOFF] = "ip4-full-reass-feature-hoff",
         },
 };
-/* *INDENT-ON* */
 
-/* *INDENT-OFF* */
 VNET_FEATURE_INIT (ip4_full_reass_feature, static) = {
     .arc_name = "ip4-unicast",
     .node_name = "ip4-full-reassembly-feature",
@@ -1346,16 +1364,14 @@ VNET_FEATURE_INIT (ip4_full_reass_feature, static) = {
                                   "ipsec4-input-feature"),
     .runs_after = 0,
 };
-/* *INDENT-ON* */
 
 VLIB_NODE_FN (ip4_full_reass_node_custom) (vlib_main_t * vm,
                                           vlib_node_runtime_t * node,
                                           vlib_frame_t * frame)
 {
-  return ip4_full_reass_inline (vm, node, frame, CUSTOM);
+  return ip4_full_reass_inline (vm, node, frame, CUSTOM, false /* is_local */);
 }
 
-/* *INDENT-OFF* */
 VLIB_REGISTER_NODE (ip4_full_reass_node_custom) = {
     .name = "ip4-full-reassembly-custom",
     .vector_size = sizeof (u32),
@@ -1370,9 +1386,7 @@ VLIB_REGISTER_NODE (ip4_full_reass_node_custom) = {
                 [IP4_FULL_REASS_NEXT_HANDOFF] = "ip4-full-reass-custom-hoff",
         },
 };
-/* *INDENT-ON* */
 
-/* *INDENT-OFF* */
 VNET_FEATURE_INIT (ip4_full_reass_custom, static) = {
     .arc_name = "ip4-unicast",
     .node_name = "ip4-full-reassembly-feature",
@@ -1381,7 +1395,6 @@ VNET_FEATURE_INIT (ip4_full_reass_custom, static) = {
     .runs_after = 0,
 };
 
-/* *INDENT-ON* */
 
 #ifndef CLIB_MARCH_VARIANT
 uword
@@ -1524,17 +1537,17 @@ ip4_full_reass_init_function (vlib_main_t * vm)
   nbuckets = ip4_full_reass_get_nbuckets ();
   clib_bihash_init_16_8 (&rm->hash, "ip4-dr", nbuckets, nbuckets * 1024);
 
-  node = vlib_get_node_by_name (vm, (u8 *) "ip4-drop");
-  ASSERT (node);
-  rm->ip4_drop_idx = node->index;
-
   rm->fq_index = vlib_frame_queue_main_init (ip4_full_reass_node.index, 0);
+  rm->fq_local_index =
+    vlib_frame_queue_main_init (ip4_local_full_reass_node.index, 0);
   rm->fq_feature_index =
     vlib_frame_queue_main_init (ip4_full_reass_node_feature.index, 0);
   rm->fq_custom_index =
     vlib_frame_queue_main_init (ip4_full_reass_node_custom.index, 0);
 
   rm->feature_use_refcount_per_intf = NULL;
+  rm->is_local_reass_enabled = 1;
+
   return error;
 }
 
@@ -1542,8 +1555,8 @@ VLIB_INIT_FUNCTION (ip4_full_reass_init_function);
 #endif /* CLIB_MARCH_VARIANT */
 
 static uword
-ip4_full_reass_walk_expired (vlib_main_t * vm,
-                            vlib_node_runtime_t * node, vlib_frame_t * f)
+ip4_full_reass_walk_expired (vlib_main_t *vm, vlib_node_runtime_t *node,
+                            CLIB_UNUSED (vlib_frame_t *f))
 {
   ip4_full_reass_main_t *rm = &ip4_full_reass_main;
   uword event_type, *event_data = 0;
@@ -1558,10 +1571,11 @@ ip4_full_reass_walk_expired (vlib_main_t * vm,
 
       switch (event_type)
        {
-       case ~0:                /* no events => timeout */
-         /* nothing to do here */
-         break;
+       case ~0:
+         /* no events => timeout */
+         /* fallthrough */
        case IP4_EVENT_CONFIG_CHANGED:
+         /* nothing to do here */
          break;
        default:
          clib_warning ("BUG: event type 0x%wx", event_type);
@@ -1582,7 +1596,6 @@ ip4_full_reass_walk_expired (vlib_main_t * vm,
          clib_spinlock_lock (&rt->lock);
 
          vec_reset_length (pool_indexes_to_free);
-          /* *INDENT-OFF* */
           pool_foreach_index (index, rt->pool)  {
                                 reass = pool_elt_at_index (rt->pool, index);
                                 if (now > reass->last_heard + rm->timeout)
@@ -1590,16 +1603,13 @@ ip4_full_reass_walk_expired (vlib_main_t * vm,
                                     vec_add1 (pool_indexes_to_free, index);
                                   }
                               }
-          /* *INDENT-ON* */
          int *i;
-          /* *INDENT-OFF* */
           vec_foreach (i, pool_indexes_to_free)
           {
             ip4_full_reass_t *reass = pool_elt_at_index (rt->pool, i[0]);
-            ip4_full_reass_drop_all (vm, node, rm, reass);
-            ip4_full_reass_free (rm, rt, reass);
-          }
-          /* *INDENT-ON* */
+           ip4_full_reass_drop_all (vm, node, reass, ~0);
+           ip4_full_reass_free (rm, rt, reass);
+         }
 
          clib_spinlock_unlock (&rt->lock);
        }
@@ -1607,14 +1617,13 @@ ip4_full_reass_walk_expired (vlib_main_t * vm,
       vec_free (pool_indexes_to_free);
       if (event_data)
        {
-         _vec_len (event_data) = 0;
+         vec_set_len (event_data, 0);
        }
     }
 
   return 0;
 }
 
-/* *INDENT-OFF* */
 VLIB_REGISTER_NODE (ip4_full_reass_expire_node) = {
     .function = ip4_full_reass_walk_expired,
     .type = VLIB_NODE_TYPE_PROCESS,
@@ -1624,7 +1633,6 @@ VLIB_REGISTER_NODE (ip4_full_reass_expire_node) = {
     .error_strings = ip4_full_reass_error_strings,
 
 };
-/* *INDENT-ON* */
 
 static u8 *
 format_ip4_full_reass_key (u8 * s, va_list * args)
@@ -1702,11 +1710,9 @@ show_ip4_reass (vlib_main_t * vm,
       clib_spinlock_lock (&rt->lock);
       if (details)
        {
-          /* *INDENT-OFF* */
           pool_foreach (reass, rt->pool) {
             vlib_cli_output (vm, "%U", format_ip4_reass, vm, reass);
           }
-          /* *INDENT-ON* */
        }
       sum_reass_n += rt->reass_n;
       clib_spinlock_unlock (&rt->lock);
@@ -1717,6 +1723,10 @@ show_ip4_reass (vlib_main_t * vm,
   vlib_cli_output (vm,
                   "Maximum configured concurrent full IP4 reassemblies per worker-thread: %lu\n",
                   (long unsigned) rm->max_reass_n);
+  vlib_cli_output (vm,
+                  "Maximum configured amount of fragments "
+                  "per full IP4 reassembly: %lu\n",
+                  (long unsigned) rm->max_reass_len);
   vlib_cli_output (vm,
                   "Maximum configured full IP4 reassembly timeout: %lums\n",
                   (long unsigned) rm->timeout_ms);
@@ -1726,13 +1736,11 @@ show_ip4_reass (vlib_main_t * vm,
   return 0;
 }
 
-/* *INDENT-OFF* */
 VLIB_CLI_COMMAND (show_ip4_full_reass_cmd, static) = {
     .path = "show ip4-full-reassembly",
     .short_help = "show ip4-full-reassembly [details]",
     .function = show_ip4_reass,
 };
-/* *INDENT-ON* */
 
 #ifndef CLIB_MARCH_VARIANT
 vnet_api_error_t
@@ -1784,10 +1792,10 @@ format_ip4_full_reass_handoff_trace (u8 * s, va_list * args)
 }
 
 always_inline uword
-ip4_full_reass_handoff_node_inline (vlib_main_t * vm,
-                                   vlib_node_runtime_t * node,
-                                   vlib_frame_t * frame,
-                                   ip4_full_reass_node_type_t type)
+ip4_full_reass_handoff_node_inline (vlib_main_t *vm, vlib_node_runtime_t *node,
+                                   vlib_frame_t *frame,
+                                   ip4_full_reass_node_type_t type,
+                                   bool is_local)
 {
   ip4_full_reass_main_t *rm = &ip4_full_reass_main;
 
@@ -1806,7 +1814,14 @@ ip4_full_reass_handoff_node_inline (vlib_main_t * vm,
   switch (type)
     {
     case NORMAL:
-      fq_index = rm->fq_index;
+      if (is_local)
+       {
+         fq_index = rm->fq_local_index;
+       }
+      else
+       {
+         fq_index = rm->fq_index;
+       }
       break;
     case FEATURE:
       fq_index = rm->fq_feature_index;
@@ -1816,7 +1831,6 @@ ip4_full_reass_handoff_node_inline (vlib_main_t * vm,
       break;
     default:
       clib_warning ("Unexpected `type' (%d)!", type);
-      ASSERT (0);
     }
 
   while (n_left_from > 0)
@@ -1836,9 +1850,8 @@ ip4_full_reass_handoff_node_inline (vlib_main_t * vm,
       ti += 1;
       b += 1;
     }
-  n_enq =
-    vlib_buffer_enqueue_to_thread (vm, fq_index, from, thread_indices,
-                                  frame->n_vectors, 1);
+  n_enq = vlib_buffer_enqueue_to_thread (vm, node, fq_index, from,
+                                        thread_indices, frame->n_vectors, 1);
 
   if (n_enq < frame->n_vectors)
     vlib_node_increment_counter (vm, node->node_index,
@@ -1851,11 +1864,11 @@ VLIB_NODE_FN (ip4_full_reass_handoff_node) (vlib_main_t * vm,
                                            vlib_node_runtime_t * node,
                                            vlib_frame_t * frame)
 {
-  return ip4_full_reass_handoff_node_inline (vm, node, frame, NORMAL);
+  return ip4_full_reass_handoff_node_inline (vm, node, frame, NORMAL,
+                                            false /* is_local */);
 }
 
 
-/* *INDENT-OFF* */
 VLIB_REGISTER_NODE (ip4_full_reass_handoff_node) = {
   .name = "ip4-full-reassembly-handoff",
   .vector_size = sizeof (u32),
@@ -1869,21 +1882,37 @@ VLIB_REGISTER_NODE (ip4_full_reass_handoff_node) = {
     [0] = "error-drop",
   },
 };
-/* *INDENT-ON* */
 
+VLIB_NODE_FN (ip4_local_full_reass_handoff_node)
+(vlib_main_t *vm, vlib_node_runtime_t *node, vlib_frame_t *frame)
+{
+  return ip4_full_reass_handoff_node_inline (vm, node, frame, NORMAL,
+                                            true /* is_local */);
+}
+
+VLIB_REGISTER_NODE (ip4_local_full_reass_handoff_node) = {
+  .name = "ip4-local-full-reassembly-handoff",
+  .vector_size = sizeof (u32),
+  .n_errors = ARRAY_LEN(ip4_full_reass_handoff_error_strings),
+  .error_strings = ip4_full_reass_handoff_error_strings,
+  .format_trace = format_ip4_full_reass_handoff_trace,
+
+  .n_next_nodes = 1,
+
+  .next_nodes = {
+    [0] = "error-drop",
+  },
+};
 
-/* *INDENT-OFF* */
 VLIB_NODE_FN (ip4_full_reass_feature_handoff_node) (vlib_main_t * vm,
                                                    vlib_node_runtime_t *
                                                    node,
                                                    vlib_frame_t * frame)
 {
-  return ip4_full_reass_handoff_node_inline (vm, node, frame, FEATURE);
+  return ip4_full_reass_handoff_node_inline (vm, node, frame, FEATURE,
+                                            false /* is_local */);
 }
-/* *INDENT-ON* */
 
-
-/* *INDENT-OFF* */
 VLIB_REGISTER_NODE (ip4_full_reass_feature_handoff_node) = {
   .name = "ip4-full-reass-feature-hoff",
   .vector_size = sizeof (u32),
@@ -1897,20 +1926,16 @@ VLIB_REGISTER_NODE (ip4_full_reass_feature_handoff_node) = {
     [0] = "error-drop",
   },
 };
-/* *INDENT-ON* */
 
-/* *INDENT-OFF* */
 VLIB_NODE_FN (ip4_full_reass_custom_handoff_node) (vlib_main_t * vm,
                                                    vlib_node_runtime_t *
                                                    node,
                                                    vlib_frame_t * frame)
 {
-  return ip4_full_reass_handoff_node_inline (vm, node, frame, CUSTOM);
+  return ip4_full_reass_handoff_node_inline (vm, node, frame, CUSTOM,
+                                            false /* is_local */);
 }
-/* *INDENT-ON* */
-
 
-/* *INDENT-OFF* */
 VLIB_REGISTER_NODE (ip4_full_reass_custom_handoff_node) = {
   .name = "ip4-full-reass-custom-hoff",
   .vector_size = sizeof (u32),
@@ -1924,7 +1949,6 @@ VLIB_REGISTER_NODE (ip4_full_reass_custom_handoff_node) = {
     [0] = "error-drop",
   },
 };
-/* *INDENT-ON* */
 
 #ifndef CLIB_MARCH_VARIANT
 int
@@ -1953,6 +1977,26 @@ ip4_full_reass_enable_disable_with_refcnt (u32 sw_if_index, int is_enable)
     }
   return -1;
 }
+
+void
+ip4_local_full_reass_enable_disable (int enable)
+{
+  if (enable)
+    {
+      ip4_full_reass_main.is_local_reass_enabled = 1;
+    }
+  else
+    {
+      ip4_full_reass_main.is_local_reass_enabled = 0;
+    }
+}
+
+int
+ip4_local_full_reass_enabled ()
+{
+  return ip4_full_reass_main.is_local_reass_enabled;
+}
+
 #endif
 
 /*