Improve fifo allocator performance
[vpp.git] / src / vnet / session / segment_manager.c
index 16e5bc5..caf8eaa 100644 (file)
@@ -27,6 +27,11 @@ u32 segment_name_counter = 0;
  */
 segment_manager_t *segment_managers = 0;
 
+/**
+ * Process private segment index
+ */
+u32 private_segment_index = ~0;
+
 /**
  * Default fifo and segment size. TODO config.
  */
@@ -53,6 +58,9 @@ session_manager_add_segment_i (segment_manager_t * sm, u32 segment_size,
 
   ca->segment_name = (char *) segment_name;
   ca->segment_size = segment_size;
+  ca->rx_fifo_size = sm->properties->rx_fifo_size;
+  ca->tx_fifo_size = sm->properties->tx_fifo_size;
+  ca->preallocated_fifo_pairs = sm->properties->preallocated_fifo_pairs;
 
   rv = svm_fifo_segment_create (ca);
   if (rv)
@@ -89,17 +97,39 @@ session_manager_add_segment (segment_manager_t * sm)
 int
 session_manager_add_first_segment (segment_manager_t * sm, u32 segment_size)
 {
-  svm_fifo_segment_create_args_t _ca, *ca = &_ca;
   u8 *segment_name;
   int rv;
 
-  memset (ca, 0, sizeof (*ca));
   segment_name = format (0, "%d-%d%c", getpid (), segment_name_counter++, 0);
   rv = session_manager_add_segment_i (sm, segment_size, segment_name);
   vec_free (segment_name);
   return rv;
 }
 
+static void
+  segment_manager_alloc_process_private_segment
+  (segment_manager_properties_t * props)
+{
+  svm_fifo_segment_create_args_t _a, *a = &_a;
+
+  if (private_segment_index != ~0)
+    return;
+
+  memset (a, 0, sizeof (*a));
+  a->segment_name = "process-private-segment";
+  a->segment_size = ~0;
+  a->new_segment_index = ~0;
+  a->rx_fifo_size = props->rx_fifo_size;
+  a->tx_fifo_size = props->tx_fifo_size;
+  a->preallocated_fifo_pairs = props->preallocated_fifo_pairs;
+
+  if (svm_fifo_segment_create_process_private (a))
+    clib_warning ("Failed to create process private segment");
+
+  private_segment_index = a->new_segment_index;
+  ASSERT (private_segment_index != ~0);
+}
+
 /**
  * Initializes segment manager based on options provided.
  * Returns error if svm segment allocation fails.
@@ -114,7 +144,9 @@ segment_manager_init (segment_manager_t * sm,
   /* app allocates these */
   sm->properties = properties;
 
-  if (first_seg_size > 0)
+  first_seg_size = first_seg_size > 0 ? first_seg_size : default_segment_size;
+
+  if (sm->properties->use_private_segment == 0)
     {
       rv = session_manager_add_first_segment (sm, first_seg_size);
       if (rv)
@@ -123,7 +155,15 @@ segment_manager_init (segment_manager_t * sm,
          return rv;
        }
     }
+  else
+    {
+      if (private_segment_index == ~0)
+       segment_manager_alloc_process_private_segment (properties);
+      ASSERT (private_segment_index != ~0);
+      vec_add1 (sm->segment_indices, private_segment_index);
+    }
 
+  clib_spinlock_init (&sm->lockp);
   return 0;
 }
 
@@ -137,71 +177,46 @@ segment_manager_init (segment_manager_t * sm,
 void
 segment_manager_del (segment_manager_t * sm)
 {
-  u32 *deleted_sessions = 0;
-  u32 *deleted_thread_indices = 0;
-  int i, j;
+  int j;
 
   /* Across all fifo segments used by the server */
   for (j = 0; j < vec_len (sm->segment_indices); j++)
     {
       svm_fifo_segment_private_t *fifo_segment;
-      svm_fifo_t **fifos;
+      svm_fifo_t *fifo;
+
       /* Vector of fifos allocated in the segment */
       fifo_segment = svm_fifo_get_segment (sm->segment_indices[j]);
-      fifos = svm_fifo_segment_get_fifos (fifo_segment);
+      fifo = svm_fifo_segment_get_fifo_list (fifo_segment);
 
       /*
        * Remove any residual sessions from the session lookup table
        * Don't bother deleting the individual fifos, we're going to
        * throw away the fifo segment in a minute.
        */
-      for (i = 0; i < vec_len (fifos); i++)
+      while (fifo)
        {
-         svm_fifo_t *fifo;
          u32 session_index, thread_index;
          stream_session_t *session;
 
-         fifo = fifos[i];
-         session_index = fifo->server_session_index;
-         thread_index = fifo->server_thread_index;
+         session_index = fifo->master_session_index;
+         thread_index = fifo->master_thread_index;
 
          session = stream_session_get (session_index, thread_index);
 
-         /* Add to the deleted_sessions vector (once!) */
-         if (!session->is_deleted)
-           {
-             session->is_deleted = 1;
-             vec_add1 (deleted_sessions, session_index);
-             vec_add1 (deleted_thread_indices, thread_index);
-           }
-       }
-
-      for (i = 0; i < vec_len (deleted_sessions); i++)
-       {
-         stream_session_t *session;
-         session = stream_session_get (deleted_sessions[i],
-                                       deleted_thread_indices[i]);
-
          /* Instead of directly removing the session call disconnect */
-         stream_session_disconnect (session);
-
-         /*
-            stream_session_table_del (smm, session);
-            pool_put(smm->sessions[deleted_thread_indices[i]], session);
-          */
+         session_send_session_evt_to_thread (stream_session_handle (session),
+                                             FIFO_EVENT_DISCONNECT,
+                                             thread_index);
+         fifo = fifo->next;
        }
 
-      vec_reset_length (deleted_sessions);
-      vec_reset_length (deleted_thread_indices);
-
-      /* Instead of removing the segment, test when removing the session if
-       * the segment can be removed
+      /* Instead of removing the segment, test when cleaning up disconnected
+       * sessions if the segment can be removed.
        */
-      /* svm_fifo_segment_delete (fifo_segment); */
     }
 
-  vec_free (deleted_sessions);
-  vec_free (deleted_thread_indices);
+  clib_spinlock_free (&sm->lockp);
   pool_put (segment_managers, sm);
 }
 
@@ -232,29 +247,40 @@ segment_manager_alloc_session_fifos (segment_manager_t * sm,
   u8 added_a_segment = 0;
   int i;
 
-  /* Allocate svm fifos */
   ASSERT (vec_len (sm->segment_indices));
 
+  /* Make sure we don't have multiple threads trying to allocate segments
+   * at the same time. */
+  clib_spinlock_lock (&sm->lockp);
+
+  /* Allocate svm fifos */
 again:
   for (i = 0; i < vec_len (sm->segment_indices); i++)
     {
       *fifo_segment_index = sm->segment_indices[i];
       fifo_segment = svm_fifo_get_segment (*fifo_segment_index);
 
+      /* FC: cleanup, make sure sm->properties->xxx_fifo_size always set */
       fifo_size = sm->properties->rx_fifo_size;
       fifo_size = (fifo_size == 0) ? default_fifo_size : fifo_size;
-      *server_rx_fifo = svm_fifo_segment_alloc_fifo (fifo_segment, fifo_size);
+      *server_rx_fifo =
+       svm_fifo_segment_alloc_fifo (fifo_segment, fifo_size,
+                                    FIFO_SEGMENT_RX_FREELIST);
 
+      /* FC: cleanup, make sure sm->properties->xxx_fifo_size always set */
       fifo_size = sm->properties->tx_fifo_size;
       fifo_size = (fifo_size == 0) ? default_fifo_size : fifo_size;
-      *server_tx_fifo = svm_fifo_segment_alloc_fifo (fifo_segment, fifo_size);
+      *server_tx_fifo =
+       svm_fifo_segment_alloc_fifo (fifo_segment, fifo_size,
+                                    FIFO_SEGMENT_TX_FREELIST);
 
       if (*server_rx_fifo == 0)
        {
          /* This would be very odd, but handle it... */
          if (*server_tx_fifo != 0)
            {
-             svm_fifo_segment_free_fifo (fifo_segment, *server_tx_fifo);
+             svm_fifo_segment_free_fifo (fifo_segment, *server_tx_fifo,
+                                         FIFO_SEGMENT_TX_FREELIST);
              *server_tx_fifo = 0;
            }
          continue;
@@ -263,7 +289,8 @@ again:
        {
          if (*server_rx_fifo != 0)
            {
-             svm_fifo_segment_free_fifo (fifo_segment, *server_rx_fifo);
+             svm_fifo_segment_free_fifo (fifo_segment, *server_rx_fifo,
+                                         FIFO_SEGMENT_RX_FREELIST);
              *server_rx_fifo = 0;
            }
          continue;
@@ -283,7 +310,9 @@ again:
            }
 
          if (session_manager_add_segment (sm))
-           return VNET_API_ERROR_URI_FIFO_CREATE_FAILED;
+           {
+             return VNET_API_ERROR_URI_FIFO_CREATE_FAILED;
+           }
 
          added_a_segment = 1;
          goto again;
@@ -295,14 +324,16 @@ again:
        }
     }
 
-  if (added_a_segment)
-    return segment_manager_notify_app_seg_add (sm, *fifo_segment_index);
-
   /* Backpointers to segment manager */
   sm_index = segment_manager_index (sm);
   (*server_tx_fifo)->segment_manager = sm_index;
   (*server_rx_fifo)->segment_manager = sm_index;
 
+  clib_spinlock_unlock (&sm->lockp);
+
+  if (added_a_segment)
+    return segment_manager_notify_app_seg_add (sm, *fifo_segment_index);
+
   return 0;
 }
 
@@ -313,26 +344,74 @@ segment_manager_dealloc_fifos (u32 svm_segment_index, svm_fifo_t * rx_fifo,
   segment_manager_t *sm;
   svm_fifo_segment_private_t *fifo_segment;
 
-  fifo_segment = svm_fifo_get_segment (svm_segment_index);
-  svm_fifo_segment_free_fifo (fifo_segment, rx_fifo);
-  svm_fifo_segment_free_fifo (fifo_segment, tx_fifo);
+  sm = segment_manager_get_if_valid (rx_fifo->segment_manager);
 
-  /* If we have segment manager, try doing some cleanup.
-   * It's possible to have no segment manager if the session was removed
+  /* It's possible to have no segment manager if the session was removed
    * as result of a detach */
-  sm = segment_manager_get_if_valid (rx_fifo->segment_manager);
-  if (sm)
+  if (!sm)
+    return;
+
+  fifo_segment = svm_fifo_get_segment (svm_segment_index);
+  svm_fifo_segment_free_fifo (fifo_segment, rx_fifo,
+                             FIFO_SEGMENT_RX_FREELIST);
+  svm_fifo_segment_free_fifo (fifo_segment, tx_fifo,
+                             FIFO_SEGMENT_TX_FREELIST);
+
+  /* Remove segment only if it holds no fifos and not the first */
+  if (sm->segment_indices[0] != svm_segment_index
+      && !svm_fifo_segment_has_fifos (fifo_segment))
     {
-      /* Remove segment only if it holds no fifos and not the first */
-      if (sm->segment_indices[0] != svm_segment_index
-         && !svm_fifo_segment_has_fifos (fifo_segment))
-       {
-         svm_fifo_segment_delete (fifo_segment);
-         vec_del1 (sm->segment_indices, svm_segment_index);
-       }
+      svm_fifo_segment_delete (fifo_segment);
+      vec_del1 (sm->segment_indices, svm_segment_index);
     }
 }
 
+/**
+ * Allocates shm queue in the first segment
+ */
+unix_shared_memory_queue_t *
+segment_manager_alloc_queue (segment_manager_t * sm, u32 queue_size)
+{
+  ssvm_shared_header_t *sh;
+  svm_fifo_segment_private_t *segment;
+  unix_shared_memory_queue_t *q;
+  void *oldheap;
+
+  ASSERT (sm->segment_indices != 0);
+
+  segment = svm_fifo_get_segment (sm->segment_indices[0]);
+  sh = segment->ssvm.sh;
+
+  oldheap = ssvm_push_heap (sh);
+  q =
+    unix_shared_memory_queue_init (queue_size, sizeof (session_fifo_event_t),
+                                  0 /* consumer pid */ , 0
+                                  /* signal when queue non-empty */ );
+  ssvm_pop_heap (oldheap);
+  return q;
+}
+
+/**
+ * Frees shm queue allocated in the first segment
+ */
+void
+segment_manager_dealloc_queue (segment_manager_t * sm,
+                              unix_shared_memory_queue_t * q)
+{
+  ssvm_shared_header_t *sh;
+  svm_fifo_segment_private_t *segment;
+  void *oldheap;
+
+  ASSERT (sm->segment_indices != 0);
+
+  segment = svm_fifo_get_segment (sm->segment_indices[0]);
+  sh = segment->ssvm.sh;
+
+  oldheap = ssvm_push_heap (sh);
+  unix_shared_memory_queue_free (q);
+  ssvm_pop_heap (oldheap);
+}
+
 /*
  * fd.io coding-style-patch-verification: ON
  *