udp: fix inner packet checksum calculation in udp-encap
[vpp.git] / src / vnet / vxlan-gpe / encap.c
index 71faac5..35a5529 100644 (file)
@@ -22,6 +22,7 @@
 #include <vnet/vnet.h>
 #include <vnet/ip/ip.h>
 #include <vnet/ethernet/ethernet.h>
+#include <vnet/udp/udp_inlines.h>
 #include <vnet/vxlan-gpe/vxlan_gpe.h>
 
 /** Statistics (not really errors) */
@@ -87,13 +88,15 @@ format_vxlan_gpe_encap_trace (u8 * s, va_list * args)
  *
  */
 always_inline void
-vxlan_gpe_encap_one_inline (vxlan_gpe_main_t * ngm, vlib_buffer_t * b0,
-                           vxlan_gpe_tunnel_t * t0, u32 * next0, u8 is_v4)
+vxlan_gpe_encap_one_inline (vxlan_gpe_main_t *ngm, vlib_buffer_t *b0,
+                           vxlan_gpe_tunnel_t *t0, u32 *next0,
+                           ip_address_family_t af)
 {
   ASSERT (sizeof (ip4_vxlan_gpe_header_t) == 36);
   ASSERT (sizeof (ip6_vxlan_gpe_header_t) == 56);
 
-  ip_udp_encap_one (ngm->vlib_main, b0, t0->rewrite, t0->rewrite_size, is_v4);
+  ip_udp_encap_one (ngm->vlib_main, b0, t0->rewrite, t0->rewrite_size, af,
+                   N_AF);
   next0[0] = t0->encap_next_node;
 }
 
@@ -111,16 +114,18 @@ vxlan_gpe_encap_one_inline (vxlan_gpe_main_t * ngm, vlib_buffer_t * b0,
  *
  */
 always_inline void
-vxlan_gpe_encap_two_inline (vxlan_gpe_main_t * ngm, vlib_buffer_t * b0,
-                           vlib_buffer_t * b1, vxlan_gpe_tunnel_t * t0,
-                           vxlan_gpe_tunnel_t * t1, u32 * next0,
-                           u32 * next1, u8 is_v4)
+vxlan_gpe_encap_two_inline (vxlan_gpe_main_t *ngm, vlib_buffer_t *b0,
+                           vlib_buffer_t *b1, vxlan_gpe_tunnel_t *t0,
+                           vxlan_gpe_tunnel_t *t1, u32 *next0, u32 *next1,
+                           ip_address_family_t af)
 {
   ASSERT (sizeof (ip4_vxlan_gpe_header_t) == 36);
   ASSERT (sizeof (ip6_vxlan_gpe_header_t) == 56);
 
-  ip_udp_encap_one (ngm->vlib_main, b0, t0->rewrite, t0->rewrite_size, is_v4);
-  ip_udp_encap_one (ngm->vlib_main, b1, t1->rewrite, t1->rewrite_size, is_v4);
+  ip_udp_encap_one (ngm->vlib_main, b0, t0->rewrite, t0->rewrite_size, af,
+                   N_AF);
+  ip_udp_encap_one (ngm->vlib_main, b1, t1->rewrite, t1->rewrite_size, af,
+                   N_AF);
   next0[0] = next1[0] = t0->encap_next_node;
 }
 
@@ -151,8 +156,9 @@ vxlan_gpe_encap (vlib_main_t * vm,
   vnet_main_t *vnm = ngm->vnet_main;
   vnet_interface_main_t *im = &vnm->interface_main;
   u32 pkts_encapsulated = 0;
-  u32 thread_index = vlib_get_thread_index ();
+  u32 thread_index = vm->thread_index;
   u32 stats_sw_if_index, stats_n_packets, stats_n_bytes;
+  vlib_buffer_t *bufs[VLIB_FRAME_SIZE], **b = bufs;
 
   from = vlib_frame_vector_args (from_frame);
   n_left_from = from_frame->n_vectors;
@@ -160,37 +166,34 @@ vxlan_gpe_encap (vlib_main_t * vm,
   next_index = node->cached_next_index;
   stats_sw_if_index = node->runtime_data[0];
   stats_n_packets = stats_n_bytes = 0;
+  vlib_get_buffers (vm, from, bufs, n_left_from);
 
   while (n_left_from > 0)
     {
       u32 n_left_to_next;
+      u32 sw_if_index0 = ~0, sw_if_index1 = ~0, len0, len1;
+      vnet_hw_interface_t *hi0, *hi1;
+      vxlan_gpe_tunnel_t *t0 = NULL, *t1 = NULL;
+      ip_address_family_t af_0 = AF_IP4, af_1 = AF_IP4;
 
       vlib_get_next_frame (vm, node, next_index, to_next, n_left_to_next);
 
       while (n_left_from >= 4 && n_left_to_next >= 2)
        {
          u32 bi0, bi1;
-         vlib_buffer_t *b0, *b1;
          u32 next0, next1;
-         u32 sw_if_index0, sw_if_index1, len0, len1;
-         vnet_hw_interface_t *hi0, *hi1;
-         vxlan_gpe_tunnel_t *t0, *t1;
-         u8 is_ip4_0, is_ip4_1;
 
          next0 = next1 = VXLAN_GPE_ENCAP_NEXT_IP4_LOOKUP;
 
          /* Prefetch next iteration. */
          {
-           vlib_buffer_t *p2, *p3;
+           vlib_prefetch_buffer_header (b[2], LOAD);
+           vlib_prefetch_buffer_header (b[3], LOAD);
 
-           p2 = vlib_get_buffer (vm, from[2]);
-           p3 = vlib_get_buffer (vm, from[3]);
-
-           vlib_prefetch_buffer_header (p2, LOAD);
-           vlib_prefetch_buffer_header (p3, LOAD);
-
-           CLIB_PREFETCH (p2->data, 2 * CLIB_CACHE_LINE_BYTES, LOAD);
-           CLIB_PREFETCH (p3->data, 2 * CLIB_CACHE_LINE_BYTES, LOAD);
+           CLIB_PREFETCH (b[2]->data - CLIB_CACHE_LINE_BYTES,
+                          2 * CLIB_CACHE_LINE_BYTES, LOAD);
+           CLIB_PREFETCH (b[3]->data - CLIB_CACHE_LINE_BYTES,
+                          2 * CLIB_CACHE_LINE_BYTES, LOAD);
          }
 
          bi0 = from[0];
@@ -202,47 +205,61 @@ vxlan_gpe_encap (vlib_main_t * vm,
          n_left_to_next -= 2;
          n_left_from -= 2;
 
-         b0 = vlib_get_buffer (vm, bi0);
-         b1 = vlib_get_buffer (vm, bi1);
-
-         /* 1-wide cache? */
-         sw_if_index0 = vnet_buffer (b0)->sw_if_index[VLIB_TX];
-         sw_if_index1 = vnet_buffer (b1)->sw_if_index[VLIB_TX];
-         hi0 =
-           vnet_get_sup_hw_interface (vnm,
-                                      vnet_buffer (b0)->sw_if_index
-                                      [VLIB_TX]);
-         hi1 =
-           vnet_get_sup_hw_interface (vnm,
-                                      vnet_buffer (b1)->sw_if_index
-                                      [VLIB_TX]);
-
-         t0 = pool_elt_at_index (ngm->tunnels, hi0->dev_instance);
-         t1 = pool_elt_at_index (ngm->tunnels, hi1->dev_instance);
+         /* get "af_0" */
+         if (sw_if_index0 != vnet_buffer (b[0])->sw_if_index[VLIB_TX])
+           {
+             sw_if_index0 = vnet_buffer (b[0])->sw_if_index[VLIB_TX];
+             hi0 =
+               vnet_get_sup_hw_interface (vnm,
+                                          vnet_buffer (b[0])->sw_if_index
+                                          [VLIB_TX]);
+             t0 = pool_elt_at_index (ngm->tunnels, hi0->dev_instance);
+             af_0 = (t0->flags & VXLAN_GPE_TUNNEL_IS_IPV4 ? AF_IP4 : AF_IP6);
+           }
 
-         is_ip4_0 = (t0->flags & VXLAN_GPE_TUNNEL_IS_IPV4);
-         is_ip4_1 = (t1->flags & VXLAN_GPE_TUNNEL_IS_IPV4);
+         /* get "af_1" */
+         if (sw_if_index1 != vnet_buffer (b[1])->sw_if_index[VLIB_TX])
+           {
+             if (sw_if_index0 == vnet_buffer (b[1])->sw_if_index[VLIB_TX])
+               {
+                 sw_if_index1 = sw_if_index0;
+                 hi1 = hi0;
+                 t1 = t0;
+                 af_1 = af_0;
+               }
+             else
+               {
+                 sw_if_index1 = vnet_buffer (b[1])->sw_if_index[VLIB_TX];
+                 hi1 =
+                   vnet_get_sup_hw_interface (vnm,
+                                              vnet_buffer (b[1])->sw_if_index
+                                              [VLIB_TX]);
+                 t1 = pool_elt_at_index (ngm->tunnels, hi1->dev_instance);
+                 af_1 =
+                   (t1->flags & VXLAN_GPE_TUNNEL_IS_IPV4 ? AF_IP4 : AF_IP6);
+               }
+           }
 
-         if (PREDICT_TRUE (is_ip4_0 == is_ip4_1))
+         if (PREDICT_TRUE (af_0 == af_1))
            {
-             vxlan_gpe_encap_two_inline (ngm, b0, b1, t0, t1, &next0, &next1,
-                                         is_ip4_0);
+             vxlan_gpe_encap_two_inline (ngm, b[0], b[1], t0, t1, &next0,
+                                         &next1, af_0);
            }
          else
            {
-             vxlan_gpe_encap_one_inline (ngm, b0, t0, &next0, is_ip4_0);
-             vxlan_gpe_encap_one_inline (ngm, b1, t1, &next1, is_ip4_1);
+             vxlan_gpe_encap_one_inline (ngm, b[0], t0, &next0, af_0);
+             vxlan_gpe_encap_one_inline (ngm, b[1], t1, &next1, af_1);
            }
 
          /* Reset to look up tunnel partner in the configured FIB */
-         vnet_buffer (b0)->sw_if_index[VLIB_TX] = t0->encap_fib_index;
-         vnet_buffer (b1)->sw_if_index[VLIB_TX] = t1->encap_fib_index;
-         vnet_buffer (b0)->sw_if_index[VLIB_RX] = sw_if_index0;
-         vnet_buffer (b1)->sw_if_index[VLIB_RX] = sw_if_index1;
+         vnet_buffer (b[0])->sw_if_index[VLIB_TX] = t0->encap_fib_index;
+         vnet_buffer (b[1])->sw_if_index[VLIB_TX] = t1->encap_fib_index;
+         vnet_buffer (b[0])->sw_if_index[VLIB_RX] = sw_if_index0;
+         vnet_buffer (b[1])->sw_if_index[VLIB_RX] = sw_if_index1;
          pkts_encapsulated += 2;
 
-         len0 = vlib_buffer_length_in_chain (vm, b0);
-         len1 = vlib_buffer_length_in_chain (vm, b0);
+         len0 = vlib_buffer_length_in_chain (vm, b[0]);
+         len1 = vlib_buffer_length_in_chain (vm, b[1]);
          stats_n_packets += 2;
          stats_n_bytes += len0 + len1;
 
@@ -281,19 +298,20 @@ vxlan_gpe_encap (vlib_main_t * vm,
                }
            }
 
-         if (PREDICT_FALSE (b0->flags & VLIB_BUFFER_IS_TRACED))
+         if (PREDICT_FALSE (b[0]->flags & VLIB_BUFFER_IS_TRACED))
            {
              vxlan_gpe_encap_trace_t *tr =
-               vlib_add_trace (vm, node, b0, sizeof (*tr));
+               vlib_add_trace (vm, node, b[0], sizeof (*tr));
              tr->tunnel_index = t0 - ngm->tunnels;
            }
 
-         if (PREDICT_FALSE (b1->flags & VLIB_BUFFER_IS_TRACED))
+         if (PREDICT_FALSE (b[1]->flags & VLIB_BUFFER_IS_TRACED))
            {
-             vxlan_gpe_encap_trace_t *tr = vlib_add_trace (vm, node, b1,
+             vxlan_gpe_encap_trace_t *tr = vlib_add_trace (vm, node, b[1],
                                                            sizeof (*tr));
              tr->tunnel_index = t1 - ngm->tunnels;
            }
+         b += 2;
 
          vlib_validate_buffer_enqueue_x2 (vm, node, next_index, to_next,
                                           n_left_to_next, bi0, bi1, next0,
@@ -303,12 +321,7 @@ vxlan_gpe_encap (vlib_main_t * vm,
       while (n_left_from > 0 && n_left_to_next > 0)
        {
          u32 bi0;
-         vlib_buffer_t *b0;
          u32 next0 = VXLAN_GPE_ENCAP_NEXT_IP4_LOOKUP;
-         u32 sw_if_index0, len0;
-         vnet_hw_interface_t *hi0;
-         vxlan_gpe_tunnel_t *t0;
-         u8 is_ip4_0;
 
          bi0 = from[0];
          to_next[0] = bi0;
@@ -317,27 +330,28 @@ vxlan_gpe_encap (vlib_main_t * vm,
          n_left_from -= 1;
          n_left_to_next -= 1;
 
-         b0 = vlib_get_buffer (vm, bi0);
-
-         /* 1-wide cache? */
-         sw_if_index0 = vnet_buffer (b0)->sw_if_index[VLIB_TX];
-         hi0 =
-           vnet_get_sup_hw_interface (vnm,
-                                      vnet_buffer (b0)->sw_if_index
-                                      [VLIB_TX]);
+         /* get "af_0" */
+         if (sw_if_index0 != vnet_buffer (b[0])->sw_if_index[VLIB_TX])
+           {
+             sw_if_index0 = vnet_buffer (b[0])->sw_if_index[VLIB_TX];
+             hi0 =
+               vnet_get_sup_hw_interface (vnm,
+                                          vnet_buffer (b[0])->sw_if_index
+                                          [VLIB_TX]);
 
-         t0 = pool_elt_at_index (ngm->tunnels, hi0->dev_instance);
+             t0 = pool_elt_at_index (ngm->tunnels, hi0->dev_instance);
 
-         is_ip4_0 = (t0->flags & VXLAN_GPE_TUNNEL_IS_IPV4);
+             af_0 = (t0->flags & VXLAN_GPE_TUNNEL_IS_IPV4 ? AF_IP4 : AF_IP6);
+           }
 
-         vxlan_gpe_encap_one_inline (ngm, b0, t0, &next0, is_ip4_0);
+         vxlan_gpe_encap_one_inline (ngm, b[0], t0, &next0, af_0);
 
          /* Reset to look up tunnel partner in the configured FIB */
-         vnet_buffer (b0)->sw_if_index[VLIB_TX] = t0->encap_fib_index;
-         vnet_buffer (b0)->sw_if_index[VLIB_RX] = sw_if_index0;
+         vnet_buffer (b[0])->sw_if_index[VLIB_TX] = t0->encap_fib_index;
+         vnet_buffer (b[0])->sw_if_index[VLIB_RX] = sw_if_index0;
          pkts_encapsulated++;
 
-         len0 = vlib_buffer_length_in_chain (vm, b0);
+         len0 = vlib_buffer_length_in_chain (vm, b[0]);
          stats_n_packets += 1;
          stats_n_bytes += len0;
 
@@ -360,12 +374,14 @@ vxlan_gpe_encap (vlib_main_t * vm,
              stats_n_bytes = len0;
              stats_sw_if_index = sw_if_index0;
            }
-         if (PREDICT_FALSE (b0->flags & VLIB_BUFFER_IS_TRACED))
+         if (PREDICT_FALSE (b[0]->flags & VLIB_BUFFER_IS_TRACED))
            {
-             vxlan_gpe_encap_trace_t *tr = vlib_add_trace (vm, node, b0,
+             vxlan_gpe_encap_trace_t *tr = vlib_add_trace (vm, node, b[0],
                                                            sizeof (*tr));
              tr->tunnel_index = t0 - ngm->tunnels;
            }
+         b += 1;
+
          vlib_validate_buffer_enqueue_x1 (vm, node, next_index, to_next,
                                           n_left_to_next, bi0, next0);
        }