tests: Use errno value rather than a specific int

[vpp.git] / test / vpp_object.py

diff --git a/test/vpp_object.py b/test/vpp_object.py
index 2c07d47..d3652b1 100644 (file)
--- a/test/vpp_object.py
+++ b/test/vpp_object.py
@@ -1,46 +1,42 @@
 """ abstract vpp object and object registry """
 
 import abc
-import six
 
-from six import moves
 
-
-@six.add_metaclass(abc.ABCMeta)
-class VppObject(object):
-    """ Abstract vpp object """
+class VppObject(metaclass=abc.ABCMeta):
+    """Abstract vpp object"""
 
     @abc.abstractmethod
-    def add_vpp_config(self):
-        """ Add the configuration for this object to vpp. """
+    def add_vpp_config(self) -> None:
+        """Add the configuration for this object to vpp."""
         pass
 
     @abc.abstractmethod
-    def query_vpp_config(self):
+    def query_vpp_config(self) -> bool:
         """Query the vpp configuration.
 
         :return: True if the object is configured"""
         pass
 
     @abc.abstractmethod
-    def remove_vpp_config(self):
-        """ Remove the configuration for this object from vpp. """
+    def remove_vpp_config(self) -> None:
+        """Remove the configuration for this object from vpp."""
         pass
 
-    def object_id(self):
-        """ Return a unique string representing this object. """
+    def object_id(self) -> str:
+        """Return a unique string representing this object."""
         return "Undefined. for <%s %s>" % (self.__class__.__name__, id(self))
 
-    def __str__(self):
+    def __str__(self) -> str:
         return self.object_id()
 
-    def __repr__(self):
-        return '<%s>' % self.object_id()
+    def __repr__(self) -> str:
+        return "<%s>" % self.object_id()
 
-    def __hash__(self):
+    def __hash__(self) -> int:
         return hash(self.object_id())
 
-    def __eq__(self, other):
+    def __eq__(self, other) -> bool:
         if not isinstance(other, self.__class__):
             return NotImplemented
         if other.object_id() == self.object_id():
@@ -52,19 +48,20 @@ class VppObject(object):
         return not self.__eq__(other)
 
 
-class VppObjectRegistry(object):
-    """ Class which handles automatic configuration cleanup. """
+class VppObjectRegistry:
+    """Class which handles automatic configuration cleanup."""
+
     _shared_state = {}
 
-    def __init__(self):
+    def __init__(self) -> None:
         self.__dict__ = self._shared_state
         if not hasattr(self, "_object_registry"):
             self._object_registry = []
         if not hasattr(self, "_object_dict"):
             self._object_dict = dict()
 
-    def register(self, obj, logger):
-        """ Register an object in the registry. """
+    def register(self, obj: VppObject, logger) -> None:
+        """Register an object in the registry."""
         if obj.object_id() not in self._object_dict:
             self._object_registry.append(obj)
             self._object_dict[obj.object_id()] = obj
@@ -72,13 +69,13 @@ class VppObjectRegistry(object):
         else:
             logger.debug("REG: duplicate add, ignoring (%s)" % obj)
 
-    def unregister_all(self, logger):
-        """ Remove all object registrations from registry. """
+    def unregister_all(self, logger) -> None:
+        """Remove all object registrations from registry."""
         logger.debug("REG: removing all object registrations")
         self._object_registry = []
         self._object_dict = dict()
 
-    def remove_vpp_config(self, logger):
+    def remove_vpp_config(self, logger) -> None:
         """
         Remove configuration (if present) from vpp and then remove all objects
         from the registry.
@@ -97,12 +94,14 @@ class VppObjectRegistry(object):
                     failed.append(obj)
             else:
                 logger.info(
-                    "REG: Skipping removal for %s, configuration not present" %
-                    obj)
+                    "REG: Skipping removal for %s, configuration not present" % obj
+                )
         self.unregister_all(logger)
         if failed:
             logger.error("REG: Couldn't remove configuration for object(s):")
             for obj in failed:
                 logger.error(repr(obj))
-            raise Exception("Couldn't remove configuration for object(s): %s" %
-                            (", ".join(str(x) for x in failed)))
+            raise Exception(
+                "Couldn't remove configuration for object(s): %s"
+                % (", ".join(str(x) for x in failed))
+            )