VPP-376: Refactor LISP dump API + VAT
[vpp.git] / vlib / vlib / error.c
index b04ac91..a2c2317 100644 (file)
@@ -47,10 +47,9 @@ vlib_error_drop_buffers (vlib_main_t * vm,
                         u32 next_buffer_stride,
                         u32 n_buffers,
                         u32 next_index,
-                        u32 drop_error_node,
-                        u32 drop_error_code)
+                        u32 drop_error_node, u32 drop_error_code)
 {
-  u32 n_left_this_frame, n_buffers_left, * args, n_args_left;
+  u32 n_left_this_frame, n_buffers_left, *args, n_args_left;
   vlib_error_t drop_error;
 
   drop_error = vlib_error_set (drop_error_node, drop_error_code);
@@ -67,7 +66,7 @@ vlib_error_drop_buffers (vlib_main_t * vm,
       while (n_left_this_frame >= 4)
        {
          u32 bi0, bi1, bi2, bi3;
-         vlib_buffer_t * b0, * b1, * b2, * b3;
+         vlib_buffer_t *b0, *b1, *b2, *b3;
 
          args[0] = bi0 = buffers[0];
          args[1] = bi1 = buffers[1];
@@ -92,7 +91,7 @@ vlib_error_drop_buffers (vlib_main_t * vm,
       while (n_left_this_frame >= 1)
        {
          u32 bi0;
-         vlib_buffer_t * b0;
+         vlib_buffer_t *b0;
 
          args[0] = bi0 = buffers[0];
 
@@ -113,22 +112,21 @@ vlib_error_drop_buffers (vlib_main_t * vm,
 /* Convenience node to drop a vector of buffers with a "misc error". */
 static uword
 misc_drop_buffers (vlib_main_t * vm,
-                   vlib_node_runtime_t * node,
-                   vlib_frame_t * frame)
+                  vlib_node_runtime_t * node, vlib_frame_t * frame)
 {
-    return vlib_error_drop_buffers (vm, node,
-                                    vlib_frame_args (frame),
-                                   /* buffer stride */ 1,
-                                    frame->n_vectors,
-                                    /* next */ 0,
-                                    node->node_index,
-                                    /* error */ 0);
+  return vlib_error_drop_buffers (vm, node, vlib_frame_args (frame),
+                                 /* buffer stride */ 1,
+                                 frame->n_vectors,
+                                 /* next */ 0,
+                                 node->node_index,
+                                 /* error */ 0);
 }
 
-static char * misc_drop_buffers_error_strings[] = {
-    [0] = "misc. errors",
+static char *misc_drop_buffers_error_strings[] = {
+  [0] = "misc. errors",
 };
 
+/* *INDENT-OFF* */
 VLIB_REGISTER_NODE (misc_drop_buffers_node,static) = {
   .function = misc_drop_buffers,
   .name = "misc-drop-buffers",
@@ -140,18 +138,18 @@ VLIB_REGISTER_NODE (misc_drop_buffers_node,static) = {
   },
   .error_strings = misc_drop_buffers_error_strings,
 };
+/* *INDENT-ON* */
 
 /* Reserves given number of error codes for given node. */
-void vlib_register_errors (vlib_main_t * vm,
-                          u32 node_index,
-                          u32 n_errors,
-                          char * error_strings[])
+void
+vlib_register_errors (vlib_main_t * vm,
+                     u32 node_index, u32 n_errors, char *error_strings[])
 {
-  vlib_error_main_t * em = &vm->error_main;
-  vlib_node_t * n = vlib_get_node (vm, node_index);
+  vlib_error_main_t *em = &vm->error_main;
+  vlib_node_t *n = vlib_get_node (vm, node_index);
   uword l;
 
-  ASSERT(os_get_cpu_number() == 0);
+  ASSERT (os_get_cpu_number () == 0);
 
   /* Free up any previous error strings. */
   if (n->n_errors > 0)
@@ -164,14 +162,12 @@ void vlib_register_errors (vlib_main_t * vm,
     return;
 
   n->error_heap_index =
-    heap_alloc (em->error_strings_heap, n_errors,
-               n->error_heap_handle);
+    heap_alloc (em->error_strings_heap, n_errors, n->error_heap_handle);
 
   l = vec_len (em->error_strings_heap);
 
-  memcpy (vec_elt_at_index (em->error_strings_heap, n->error_heap_index),
-         error_strings,
-         n_errors * sizeof (error_strings[0]));
+  clib_memcpy (vec_elt_at_index (em->error_strings_heap, n->error_heap_index),
+              error_strings, n_errors * sizeof (error_strings[0]));
 
   /* Allocate a counter/elog type for each error. */
   vec_validate (em->counters, l - 1);
@@ -179,13 +175,12 @@ void vlib_register_errors (vlib_main_t * vm,
 
   /* Zero counters for re-registrations of errors. */
   if (n->error_heap_index + n_errors <= vec_len (em->counters_last_clear))
-    memcpy (em->counters + n->error_heap_index,
-           em->counters_last_clear + n->error_heap_index,
-           n_errors * sizeof (em->counters[0]));
+    clib_memcpy (em->counters + n->error_heap_index,
+                em->counters_last_clear + n->error_heap_index,
+                n_errors * sizeof (em->counters[0]));
   else
     memset (em->counters + n->error_heap_index,
-           0,
-           n_errors * sizeof (em->counters[0]));
+           0, n_errors * sizeof (em->counters[0]));
 
   {
     elog_event_type_t t;
@@ -195,8 +190,7 @@ void vlib_register_errors (vlib_main_t * vm,
     for (i = 0; i < n_errors; i++)
       {
        t.format = (char *) format (0, "%v %s: %%d",
-                                   n->name,
-                                   error_strings[i]);
+                                   n->name, error_strings[i]);
        vm->error_elog_event_types[n->error_heap_index + i] = t;
       }
   }
@@ -204,29 +198,37 @@ void vlib_register_errors (vlib_main_t * vm,
 
 static clib_error_t *
 show_errors (vlib_main_t * vm,
-            unformat_input_t * input,
-            vlib_cli_command_t * cmd)
+            unformat_input_t * input, vlib_cli_command_t * cmd)
 {
-  vlib_error_main_t * em = &vm->error_main;
-  vlib_node_t * n;
+  vlib_error_main_t *em = &vm->error_main;
+  vlib_node_t *n;
   u32 code, i, ni;
   u64 c;
   int index = 0;
   int verbose = 0;
-  u64 * sums = 0;
+  u64 *sums = 0;
 
-  if (unformat (input, "verbose"))
+  if (unformat (input, "verbose %d", &verbose))
+    ;
+  else if (unformat (input, "verbose"))
     verbose = 1;
 
-  vec_validate(sums, vec_len(em->counters));
+  vec_validate (sums, vec_len (em->counters));
 
-  vlib_cli_output (vm, "%=16s%=40s%=20s", "Count", "Node", "Reason");
+  if (verbose)
+    vlib_cli_output (vm, "%=10s%=40s%=20s%=6s", "Count", "Node", "Reason",
+                    "Index");
+  else
+    vlib_cli_output (vm, "%=10s%=40s%=6s", "Count", "Node", "Reason");
 
+
+  /* *INDENT-OFF* */
   foreach_vlib_main(({
     em = &this_vlib_main->error_main;
 
     if (verbose)
-      vlib_cli_output(vm, "Thread %u (%v):", index, vlib_worker_threads[index].name);
+      vlib_cli_output(vm, "Thread %u (%v):", index,
+                      vlib_worker_threads[index].name);
 
     for (ni = 0; ni < vec_len (this_vlib_main->node_main.nodes); ni++)
       {
@@ -239,17 +241,23 @@ show_errors (vlib_main_t * vm,
              c -= em->counters_last_clear[i];
            sums[i] += c;
 
-           if (c == 0 || !verbose)
+           if (c == 0 && verbose < 2)
              continue;
 
-           vlib_cli_output (vm, "%16Ld%=40v%s", c, n->name, em->error_strings_heap[i]);
+            if (verbose)
+              vlib_cli_output (vm, "%10Ld%=40v%=20s%=6d", c, n->name,
+                               em->error_strings_heap[i], i);
+            else
+              vlib_cli_output (vm, "%10d%=40v%s", c, n->name,
+                               em->error_strings_heap[i]);
          }
       }
     index++;
   }));
+  /* *INDENT-ON* */
 
   if (verbose)
-   vlib_cli_output(vm, "Total:");
+    vlib_cli_output (vm, "Total:");
 
   for (ni = 0; ni < vec_len (vm->node_main.nodes); ni++)
     {
@@ -258,52 +266,73 @@ show_errors (vlib_main_t * vm,
        {
          i = n->error_heap_index + code;
          if (sums[i])
-           vlib_cli_output (vm, "%16Ld%=40v%s", sums[i], n->name, em->error_strings_heap[i]);
+           {
+             if (verbose)
+               vlib_cli_output (vm, "%10Ld%=40v%=20s%=10d", sums[i], n->name,
+                                em->error_strings_heap[i], i);
+           }
        }
     }
 
-  vec_free(sums);
+  vec_free (sums);
 
   return 0;
 }
 
+/* *INDENT-OFF* */
 VLIB_CLI_COMMAND (cli_show_errors, static) = {
   .path = "show errors",
   .short_help = "Show error counts",
   .function = show_errors,
 };
+/* *INDENT-ON* */
 
+/* *INDENT-OFF* */
 VLIB_CLI_COMMAND (cli_show_node_counters, static) = {
   .path = "show node counters",
   .short_help = "Show node counters",
   .function = show_errors,
 };
+/* *INDENT-ON* */
 
 static clib_error_t *
 clear_error_counters (vlib_main_t * vm,
-                     unformat_input_t * input,
-                     vlib_cli_command_t * cmd)
+                     unformat_input_t * input, vlib_cli_command_t * cmd)
 {
-  vlib_error_main_t * em;
+  vlib_error_main_t *em;
   u32 i;
 
+  /* *INDENT-OFF* */
   foreach_vlib_main(({
     em = &this_vlib_main->error_main;
     vec_validate (em->counters_last_clear, vec_len (em->counters) - 1);
     for (i = 0; i < vec_len (em->counters); i++)
       em->counters_last_clear[i] = em->counters[i];
   }));
+  /* *INDENT-ON* */
   return 0;
 }
 
+/* *INDENT-OFF* */
 VLIB_CLI_COMMAND (cli_clear_error_counters, static) = {
   .path = "clear errors",
   .short_help = "Clear error counters",
   .function = clear_error_counters,
 };
+/* *INDENT-ON* */
 
+/* *INDENT-OFF* */
 VLIB_CLI_COMMAND (cli_clear_node_counters, static) = {
   .path = "clear node counters",
   .short_help = "Clear node counters",
   .function = clear_error_counters,
 };
+/* *INDENT-ON* */
+
+/*
+ * fd.io coding-style-patch-verification: ON
+ *
+ * Local Variables:
+ * eval: (c-set-style "gnu")
+ * End:
+ */