X-Git-Url: https://gerrit.fd.io/r/gitweb?a=blobdiff_plain;ds=sidebyside;f=resources%2Flibraries%2Fpython%2FVppCounters.py;h=dd1553538d548c7bff22293243db5c6990f972f8;hb=33fb34665214bbbd0a4b3154169b21c2da01f69b;hp=b65b58c89bb15d31ea43225fa457e25d9978aae7;hpb=cc0c2870a18fb74a56410eca2d1870bddc945397;p=csit.git diff --git a/resources/libraries/python/VppCounters.py b/resources/libraries/python/VppCounters.py index b65b58c89b..dd1553538d 100644 --- a/resources/libraries/python/VppCounters.py +++ b/resources/libraries/python/VppCounters.py @@ -1,4 +1,4 @@ -# Copyright (c) 2016 Cisco and/or its affiliates. +# Copyright (c) 2019 Cisco and/or its affiliates. # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at: @@ -15,10 +15,11 @@ import time +from pprint import pformat + from robot.api import logger from resources.libraries.python.PapiExecutor import PapiExecutor from resources.libraries.python.topology import NodeType, Topology -from resources.libraries.python.VatExecutor import VatExecutor, VatTerminal class VppCounters(object): @@ -27,6 +28,17 @@ class VppCounters(object): def __init__(self): self._stats_table = None + @staticmethod + def _get_non_zero_items(data): + """Extract and return non-zero items from the input data. + + :param data: Data to filter. + :type data: dict + :returns: Dictionary with non-zero items. + :rtype dict + """ + return {k: data[k] for k in data.keys() if sum(data[k])} + @staticmethod def vpp_show_errors(node): """Run "show errors" debug CLI command. @@ -34,9 +46,7 @@ class VppCounters(object): :param node: Node to run command on. :type node: dict """ - vat = VatExecutor() - vat.execute_script("show_errors.vat", node, json_out=False) - vat.script_should_have_passed() + PapiExecutor.run_cli_cmd(node, 'show errors') @staticmethod def vpp_show_errors_verbose(node): @@ -45,9 +55,7 @@ class VppCounters(object): :param node: Node to run command on. :type node: dict """ - vat = VatExecutor() - vat.execute_script("show_errors_verbose.vat", node, json_out=False) - vat.script_should_have_passed() + PapiExecutor.run_cli_cmd(node, 'show errors verbose') @staticmethod def vpp_show_errors_on_all_duts(nodes, verbose=False): @@ -58,7 +66,6 @@ class VppCounters(object): :type nodes: dict :type verbose: bool """ - for node in nodes.values(): if node['type'] == NodeType.DUT: if verbose: @@ -67,16 +74,74 @@ class VppCounters(object): VppCounters.vpp_show_errors(node) @staticmethod - def vpp_show_runtime(node): + def vpp_show_runtime(node, log_zeros=False): """Run "show runtime" CLI command. :param node: Node to run command on. + :param log_zeros: Log also items with zero values. :type node: dict + :type log_zeros: bool """ - vat = VatExecutor() - vat.execute_script("show_runtime.vat", node, json_out=False) - logger.info(vat.get_script_stdout()) - vat.script_should_have_passed() + args = dict(path='^/sys/node') + with PapiExecutor(node) as papi_exec: + stats = papi_exec.add("vpp-stats", **args).get_stats()[0] + # TODO: Introduce get_stat? + + names = stats['/sys/node/names'] + + if not names: + return + + runtime = [] + runtime_non_zero = [] + + for name in names: + runtime.append({'name': name}) + + for idx, runtime_item in enumerate(runtime): + + calls_th = [] + for thread in stats['/sys/node/calls']: + calls_th.append(thread[idx]) + runtime_item["calls"] = calls_th + + vectors_th = [] + for thread in stats['/sys/node/vectors']: + vectors_th.append(thread[idx]) + runtime_item["vectors"] = vectors_th + + suspends_th = [] + for thread in stats['/sys/node/suspends']: + suspends_th.append(thread[idx]) + runtime_item["suspends"] = suspends_th + + clocks_th = [] + for thread in stats['/sys/node/clocks']: + clocks_th.append(thread[idx]) + runtime_item["clocks"] = clocks_th + + if (sum(calls_th) or sum(vectors_th) or + sum(suspends_th) or sum(clocks_th)): + runtime_non_zero.append(runtime_item) + + if log_zeros: + logger.info("Runtime:\n{runtime}".format( + runtime=pformat(runtime))) + else: + logger.info("Runtime:\n{runtime}".format( + runtime=pformat(runtime_non_zero))) + + @staticmethod + def vpp_show_runtime_verbose(node): + """Run "show runtime verbose" CLI command. + + TODO: Remove? + Only verbose output is possible to get using VPPStats. + + :param node: Node to run command on. + :type node: dict + """ + VppCounters.vpp_show_runtime(node) @staticmethod def show_runtime_counters_on_all_duts(nodes): @@ -89,18 +154,6 @@ class VppCounters(object): if node['type'] == NodeType.DUT: VppCounters.vpp_show_runtime(node) - @staticmethod - def vpp_show_runtime_verbose(node): - """Run "show runtime verbose" CLI command. - - :param node: Node to run command on. - :type node: dict - """ - vat = VatExecutor() - vat.execute_script("show_runtime_verbose.vat", node, json_out=False) - logger.info(vat.get_script_stdout()) - vat.script_should_have_passed() - @staticmethod def vpp_show_hardware_detail(node): """Run "show hardware-interfaces detail" debug CLI command. @@ -108,9 +161,7 @@ class VppCounters(object): :param node: Node to run command on. :type node: dict """ - vat = VatExecutor() - vat.execute_script("show_hardware_detail.vat", node, json_out=False) - vat.script_should_have_passed() + PapiExecutor.run_cli_cmd(node, 'show hardware detail') @staticmethod def vpp_clear_runtime(node): @@ -118,18 +169,10 @@ class VppCounters(object): :param node: Node to run command on. :type node: dict + :returns: Verified data from PAPI response. + :rtype: dict """ - cmd = 'cli_inband' - cmd_reply = 'cli_inband_reply' - err_msg = "Failed to run '{cmd}' PAPI command on host {host}!".format( - host=node['host'], cmd=cmd) - args = dict(cmd='clear runtime') - with PapiExecutor(node) as papi_exec: - papi_resp = papi_exec.add(cmd, **args).execute_should_pass(err_msg) - data = papi_resp.reply[0]['api_reply'][cmd_reply] - if data['retval'] != 0: - raise RuntimeError("Failed to clear runtime on host {host}". - format(host=node['host'])) + return PapiExecutor.run_cli_cmd(node, 'clear runtime', log=False) @staticmethod def clear_runtime_counters_on_all_duts(nodes): @@ -144,22 +187,14 @@ class VppCounters(object): @staticmethod def vpp_clear_interface_counters(node): - """Clear interface counters on VPP node. + """Run "clear interfaces" CLI command. - :param node: Node to clear interface counters on. + :param node: Node to run command on. :type node: dict + :returns: Verified data from PAPI response. + :rtype: dict """ - cmd = 'cli_inband' - cmd_reply = 'cli_inband_reply' - err_msg = "Failed to run '{cmd}' PAPI command on host {host}!".format( - host=node['host'], cmd=cmd) - args = dict(cmd='clear interfaces') - with PapiExecutor(node) as papi_exec: - papi_resp = papi_exec.add(cmd, **args).execute_should_pass(err_msg) - data = papi_resp.reply[0]['api_reply'][cmd_reply] - if data['retval'] != 0: - raise RuntimeError("Failed to clear interfaces on host {host}". - format(host=node['host'])) + return PapiExecutor.run_cli_cmd(node, 'clear interfaces', log=False) @staticmethod def clear_interface_counters_on_all_duts(nodes): @@ -174,14 +209,14 @@ class VppCounters(object): @staticmethod def vpp_clear_hardware_counters(node): - """Clear interface hardware counters on VPP node. + """Run "clear hardware" CLI command. - :param node: Node to clear hardware counters on. + :param node: Node to run command on. :type node: dict + :returns: Verified data from PAPI response. + :rtype: dict """ - vat = VatExecutor() - vat.execute_script('clear_hardware.vat', node) - vat.script_should_have_passed() + return PapiExecutor.run_cli_cmd(node, 'clear hardware', log=False) @staticmethod def clear_hardware_counters_on_all_duts(nodes): @@ -196,14 +231,14 @@ class VppCounters(object): @staticmethod def vpp_clear_errors_counters(node): - """Clear errors counters on VPP node. + """Run "clear errors" CLI command. - :param node: Node to clear errors counters on. + :param node: Node to run command on. :type node: dict + :returns: Verified data from PAPI response. + :rtype: dict """ - vat = VatExecutor() - vat.execute_script('clear_errors.vat', node) - vat.script_should_have_passed() + return PapiExecutor.run_cli_cmd(node, 'clear errors', log=False) @staticmethod def clear_error_counters_on_all_duts(nodes): @@ -216,23 +251,6 @@ class VppCounters(object): if node['type'] == NodeType.DUT: VppCounters.vpp_clear_errors_counters(node) - def vpp_dump_stats_table(self, node): - """Dump stats table on VPP node. - - :param node: Node to dump stats table on. - :type node: dict - :returns: Stats table. - """ - with VatTerminal(node) as vat: - vat.vat_terminal_exec_cmd('want_stats enable') - for _ in range(0, 12): - stats_table = vat.vat_terminal_exec_cmd('dump_stats_table') - if stats_table['interface_counters']: - self._stats_table = stats_table - return stats_table - time.sleep(1) - return None - def vpp_get_ipv4_interface_counter(self, node, interface): """ @@ -271,9 +289,9 @@ class VppCounters(object): """ version = 'ip6' if is_ipv6 else 'ip4' topo = Topology() - if_index = topo.get_interface_sw_index(node, interface) - if if_index is None: - logger.trace('{i} sw_index not found.'.format(i=interface)) + sw_if_index = topo.get_interface_sw_index(node, interface) + if sw_if_index is None: + logger.trace('{i} sw_if_index not found.'.format(i=interface)) return 0 if_counters = self._stats_table.get('interface_counters') @@ -283,7 +301,7 @@ class VppCounters(object): for counter in if_counters: if counter['vnet_counter_type'] == version: data = counter['data'] - return data[if_index] + return data[sw_if_index] logger.trace('{i} {v} counter not found.'.format( i=interface, v=version)) return 0