X-Git-Url: https://gerrit.fd.io/r/gitweb?a=blobdiff_plain;ds=sidebyside;f=src%2Fplugins%2Fmactime%2Fmactime.c;h=b8b1884119d7d992b73bcaaeeb8f0432467b2bce;hb=8932e450224fccdd8dad8992eb90bfead0ae7a7d;hp=bcd40b4c9e6b04df84a0a48bb33aea2f9b8a9e72;hpb=197180031bad1e51ee032d30d8a095a51207454c;p=vpp.git

diff --git a/src/plugins/mactime/mactime.c b/src/plugins/mactime/mactime.c
index bcd40b4c9e6..b8b1884119d 100644
--- a/src/plugins/mactime/mactime.c
+++ b/src/plugins/mactime/mactime.c
@@ -37,7 +37,8 @@
 
 mactime_main_t mactime_main;
 
-/** \file time-base src-mac filter device-input feature arc implementation
+/** \file mactime.c
+ * time-base src-mac filter device-input feature arc implementation
  */
 
 static void
@@ -194,8 +195,8 @@ vl_api_mactime_dump_t_handler (vl_api_mactime_dump_t * mp)
     }
 
   /* *INDENT-OFF* */
-  pool_foreach (dev, mm->devices,
-  ({
+  pool_foreach (dev, mm->devices)
+   {
     message_size = sizeof(*ep) + vec_len(dev->device_name) +
       vec_len(dev->ranges) * sizeof(ep->ranges[0]);
 
@@ -229,7 +230,7 @@ vl_api_mactime_dump_t_handler (vl_api_mactime_dump_t * mp)
                       name_len);
     ep->device_name [ARRAY_LEN(ep->device_name) -1] = 0;
     vl_api_send_msg (rp, (u8 *)ep);
-  }));
+  }
   /* *INDENT-OFF* */
 
  send_reply:
@@ -471,11 +472,10 @@ VNET_FEATURE_INIT (mactime, static) =
 /* *INDENT-ON */
 
 /* *INDENT-OFF* */
-VNET_FEATURE_INIT (mactime_tx, static) =
-{
+VNET_FEATURE_INIT (mactime_tx, static) = {
   .arc_name = "interface-output",
   .node_name = "mactime-tx",
-  .runs_before = VNET_FEATURES ("interface-tx"),
+  .runs_before = VNET_FEATURES ("interface-output-arc-end"),
 };
 /* *INDENT-ON */
 
@@ -553,9 +553,14 @@ show_mactime_command_fn (vlib_main_t * vm,
   vlib_counter_t allow, drop;
   ip_neighbor_t *ipn;
 
+  if (mm->feature_initialized == 0)
+    return clib_error_return
+      (0,
+       "Feature not initialized, suggest 'help mactime enable-disable'...");
+
   vec_reset_length (mm->arp_cache_copy);
   /* Walk all ip4 neighbours on all interfaces */
-  ip_neighbor_walk (IP46_TYPE_IP4, ~0, mactime_ip_neighbor_copy, mm);
+  ip_neighbor_walk (AF_IP4, ~0, mactime_ip_neighbor_copy, mm);
 
   now = clib_timebase_now (&mm->timebase);
 
@@ -572,10 +577,10 @@ show_mactime_command_fn (vlib_main_t * vm,
     vlib_cli_output (vm, "Time now: %U", format_clib_timebase_time, now);
 
   /* *INDENT-OFF* */
-  pool_foreach (dp, mm->devices,
-  ({
+  pool_foreach (dp, mm->devices)
+   {
     vec_add1 (pool_indices, dp - mm->devices);
-  }));
+  }
   /* *INDENT-ON* */
 
   vlib_cli_output (vm, "%-15s %18s %14s %10s %11s %13s",
@@ -703,7 +708,9 @@ clear_mactime_command_fn (vlib_main_t * vm,
   mactime_main_t *mm = &mactime_main;
 
   if (mm->feature_initialized == 0)
-    return clib_error_return (0, "feature not enabled");
+    return clib_error_return
+      (0,
+       "Feature not initialized, suggest 'help mactime enable-disable'...");
 
   vlib_clear_combined_counters (&mm->allow_counters);
   vlib_clear_combined_counters (&mm->drop_counters);