X-Git-Url: https://gerrit.fd.io/r/gitweb?a=blobdiff_plain;ds=sidebyside;f=src%2Fvnet%2Ffib%2Ffib_attached_export.c;h=5ea96fd0cf6f672c55402ef1c13181b15efa5902;hb=62c25abaa3e93be5815172d391295a6ab0390122;hp=cc8ebc8653e3bc399730b732f8a2b3af027cff8d;hpb=88fc83eb716bf07f4634de6de5b569f795a56418;p=vpp.git diff --git a/src/vnet/fib/fib_attached_export.c b/src/vnet/fib/fib_attached_export.c index cc8ebc8653e..5ea96fd0cf6 100644 --- a/src/vnet/fib/fib_attached_export.c +++ b/src/vnet/fib/fib_attached_export.c @@ -20,6 +20,7 @@ #include #include #include +#include /** * A description of the need to import routes from the export table @@ -27,7 +28,7 @@ typedef struct fib_ae_import_t_ { /** - * The entry in the epxort table that this importer + * The entry in the export table that this importer * is importing covereds from */ fib_node_index_t faei_export_entry; @@ -85,7 +86,7 @@ typedef struct fib_ae_export_t_ { } fib_ae_export_t; /* - * memory pools for the importers and exportes + * memory pools for the importers and exporters */ static fib_ae_import_t *fib_ae_import_pool; static fib_ae_export_t *fib_ae_export_pool; @@ -98,15 +99,15 @@ fib_entry_ae_add_or_lock (fib_node_index_t connected) fib_entry_t *entry; entry = fib_entry_get(connected); - fed = fib_entry_delegate_get(entry, - FIB_ENTRY_DELEGATE_ATTACHED_EXPORT); + fed = fib_entry_delegate_find(entry, + FIB_ENTRY_DELEGATE_ATTACHED_EXPORT); if (NULL == fed) { fed = fib_entry_delegate_find_or_add(entry, FIB_ENTRY_DELEGATE_ATTACHED_EXPORT); pool_get(fib_ae_export_pool, export); - memset(export, 0, sizeof(*export)); + clib_memset(export, 0, sizeof(*export)); fed->fd_index = (export - fib_ae_export_pool); export->faee_ei = connected; @@ -125,7 +126,6 @@ static void fib_entry_import_remove (fib_ae_import_t *import, fib_node_index_t entry_index) { - fib_prefix_t prefix; u32 index; /* @@ -136,12 +136,10 @@ fib_entry_import_remove (fib_ae_import_t *import, if (index < vec_len(import->faei_importeds)) { /* - * this is an entry that was previsouly imported + * this is an entry that was previously imported */ - fib_entry_get_prefix(entry_index, &prefix); - fib_table_entry_special_remove(import->faei_import_fib, - &prefix, + fib_entry_get_prefix(entry_index), FIB_SOURCE_AE); fib_entry_unlock(entry_index); @@ -170,21 +168,21 @@ fib_entry_import_add (fib_ae_import_t *import, /* * this is the first time this export entry has been imported - * Add it to the import FIB and to the list of importeds + * Add it to the import FIB and to the list of importeds. + * make a copy of the prefix in case the underlying entry reallocs. */ - fib_entry_get_prefix(entry_index, &prefix); + fib_prefix_copy(&prefix, fib_entry_get_prefix(entry_index)); /* * don't import entries that have the same prefix the import entry */ - if (0 != fib_prefix_cmp(&prefix, - &import->faei_prefix)) + if (0 != fib_prefix_cmp(&prefix, &import->faei_prefix)) { const dpo_id_t *dpo; dpo = fib_entry_contribute_ip_forwarding(entry_index); - if (dpo_id_is_valid(dpo)) + if (dpo_id_is_valid(dpo) && !dpo_is_drop(dpo)) { fib_table_entry_special_dpo_add(import->faei_import_fib, &prefix, @@ -207,7 +205,7 @@ fib_entry_import_add (fib_ae_import_t *import, /** * Call back when walking a connected prefix's covered prefixes for import */ -static int +static walk_rc_t fib_entry_covered_walk_import (fib_entry_t *cover, fib_node_index_t covered, void *ctx) @@ -216,7 +214,7 @@ fib_entry_covered_walk_import (fib_entry_t *cover, fib_entry_import_add(import, covered); - return (0); + return (WALK_CONTINUE); } /* @@ -247,7 +245,7 @@ fib_attached_export_import (fib_entry_t *fib_entry, fib_node_index_t fei; /* - * save index for later post-realloc retreival + * save index for later post-realloc retrieval */ fei = fib_entry_get_index(fib_entry); @@ -312,15 +310,15 @@ fib_attached_export_import (fib_entry_t *fib_entry, } /** - * \brief All the imported entries need to be pruged + * \brief All the imported entries need to be purged */ void fib_attached_export_purge (fib_entry_t *fib_entry) { fib_entry_delegate_t *fed; - fed = fib_entry_delegate_get(fib_entry, - FIB_ENTRY_DELEGATE_ATTACHED_IMPORT); + fed = fib_entry_delegate_find(fib_entry, + FIB_ENTRY_DELEGATE_ATTACHED_IMPORT); if (NULL != fed) { @@ -336,12 +334,8 @@ fib_attached_export_purge (fib_entry_t *fib_entry) */ vec_foreach(import_index, import->faei_importeds) { - fib_prefix_t prefix; - - fib_entry_get_prefix(*import_index, &prefix); - fib_table_entry_delete(import->faei_import_fib, - &prefix, + fib_entry_get_prefix(*import_index), FIB_SOURCE_AE); fib_entry_unlock(*import_index); } @@ -368,9 +362,9 @@ fib_attached_export_purge (fib_entry_t *fib_entry) export_entry = fib_entry_get(import->faei_export_entry); - fed = fib_entry_delegate_get(export_entry, - FIB_ENTRY_DELEGATE_ATTACHED_EXPORT); - ASSERT(NULL != fed); + fed = fib_entry_delegate_find(export_entry, + FIB_ENTRY_DELEGATE_ATTACHED_EXPORT); + ALWAYS_ASSERT(NULL != fed); export = pool_elt_at_index(fib_ae_export_pool, fed->fd_index); @@ -397,7 +391,7 @@ fib_attached_export_purge (fib_entry_t *fib_entry) pool_put(fib_ae_import_pool, import); fib_entry_delegate_remove(fib_entry, FIB_ENTRY_DELEGATE_ATTACHED_IMPORT); - } + } } void @@ -406,8 +400,8 @@ fib_attached_export_covered_added (fib_entry_t *cover, { fib_entry_delegate_t *fed; - fed = fib_entry_delegate_get(cover, - FIB_ENTRY_DELEGATE_ATTACHED_EXPORT); + fed = fib_entry_delegate_find(cover, + FIB_ENTRY_DELEGATE_ATTACHED_EXPORT); if (NULL != fed) { @@ -438,8 +432,8 @@ fib_attached_export_covered_removed (fib_entry_t *cover, { fib_entry_delegate_t *fed; - fed = fib_entry_delegate_get(cover, - FIB_ENTRY_DELEGATE_ATTACHED_EXPORT); + fed = fib_entry_delegate_find(cover, + FIB_ENTRY_DELEGATE_ATTACHED_EXPORT); if (NULL != fed) { @@ -469,8 +463,8 @@ fib_attached_export_cover_modified_i (fib_entry_t *fib_entry) { fib_entry_delegate_t *fed; - fed = fib_entry_delegate_get(fib_entry, - FIB_ENTRY_DELEGATE_ATTACHED_IMPORT); + fed = fib_entry_delegate_find(fib_entry, + FIB_ENTRY_DELEGATE_ATTACHED_IMPORT); if (NULL != fed) { @@ -528,7 +522,7 @@ fib_ae_import_format (fib_node_index_t impi, s = format(s, "export-sibling:%d ", import->faei_export_sibling); s = format(s, "exporter:%d ", import->faei_exporter); s = format(s, "export-fib:%d ", import->faei_export_fib); - + s = format(s, "import-entry:%d ", import->faei_import_entry); s = format(s, "import-fib:%d ", import->faei_import_fib); @@ -550,7 +544,7 @@ fib_ae_export_format (fib_node_index_t expi, fib_ae_export_t *export; export = pool_elt_at_index(fib_ae_export_pool, expi); - + s = format(s, "\n Attached-Export:%d:[", (export - fib_ae_export_pool)); s = format(s, "export-entry:%d ", export->faee_ei);