X-Git-Url: https://gerrit.fd.io/r/gitweb?a=blobdiff_plain;f=src%2Fplugins%2Fabf%2Fabf_api.c;h=cc55b214e358c185129bc4e506b10c03d4f5f932;hb=61717cc38;hp=bf2566901c47da9613c8c3bc4d06f51e8beffab0;hpb=775f73c6baaf9bc2283e7ab9752c81984823be99;p=vpp.git diff --git a/src/plugins/abf/abf_api.c b/src/plugins/abf/abf_api.c index bf2566901c4..cc55b214e35 100644 --- a/src/plugins/abf/abf_api.c +++ b/src/plugins/abf/abf_api.c @@ -29,28 +29,9 @@ #include /* define message IDs */ -#include - -/* define message structures */ -#define vl_typedefs -#include -#undef vl_typedefs - -/* define generated endian-swappers */ -#define vl_endianfun -#include -#undef vl_endianfun - -/* instantiate all the print functions we know about */ -#define vl_print(handle, ...) vlib_cli_output (handle, __VA_ARGS__) -#define vl_printfun -#include -#undef vl_printfun - -/* Get the API version number */ -#define vl_api_version(n,v) static u32 api_version=(v); -#include -#undef vl_api_version +#include +#include +#include /** * Base message ID fot the plugin @@ -59,37 +40,24 @@ static u32 abf_base_msg_id; #include -/* List of message types that this plugin understands */ - -#define foreach_abf_plugin_api_msg \ -_(ABF_PLUGIN_GET_VERSION, abf_plugin_get_version) \ -_(ABF_POLICY_ADD_DEL, abf_policy_add_del) \ -_(ABF_POLICY_DUMP, abf_policy_dump) \ -_(ABF_ITF_ATTACH_ADD_DEL, abf_itf_attach_add_del) \ -_(ABF_ITF_ATTACH_DUMP, abf_itf_attach_dump) - static void vl_api_abf_plugin_get_version_t_handler (vl_api_abf_plugin_get_version_t * mp) { vl_api_abf_plugin_get_version_reply_t *rmp; - int msg_size = sizeof (*rmp); - unix_shared_memory_queue_t *q; + vl_api_registration_t *rp; - q = vl_api_client_index_to_input_queue (mp->client_index); - if (q == 0) - { - return; - } + rp = vl_api_client_index_to_registration (mp->client_index); + if (rp == 0) + return; - rmp = vl_msg_api_alloc (msg_size); - clib_memset (rmp, 0, msg_size); + rmp = vl_msg_api_alloc (sizeof (*rmp)); rmp->_vl_msg_id = ntohs (VL_API_ABF_PLUGIN_GET_VERSION_REPLY + abf_base_msg_id); rmp->context = mp->context; rmp->major = htonl (ABF_PLUGIN_VERSION_MAJOR); rmp->minor = htonl (ABF_PLUGIN_VERSION_MINOR); - vl_msg_api_send_shmem (q, (u8 *) & rmp); + vl_api_send_msg (rp, (u8 *) rmp); } static void @@ -105,7 +73,7 @@ vl_api_abf_policy_add_del_t_handler (vl_api_abf_policy_add_del_t * mp) for (pi = 0; pi < mp->policy.n_paths; pi++) { path = &paths[pi]; - rv = fib_path_api_parse (&mp->policy.paths[pi], path); + rv = fib_api_path_decode (&mp->policy.paths[pi], path); if (0 != rv) { @@ -115,12 +83,12 @@ vl_api_abf_policy_add_del_t_handler (vl_api_abf_policy_add_del_t * mp) if (mp->is_add) { - abf_policy_update (ntohl (mp->policy.policy_id), - ntohl (mp->policy.acl_index), paths); + rv = abf_policy_update (ntohl (mp->policy.policy_id), + ntohl (mp->policy.acl_index), paths); } else { - abf_policy_delete (ntohl (mp->policy.policy_id), paths); + rv = abf_policy_delete (ntohl (mp->policy.policy_id), paths); } done: vec_free (paths); @@ -155,16 +123,19 @@ vl_api_abf_itf_attach_add_del_t_handler (vl_api_abf_itf_attach_add_del_t * mp) typedef struct abf_dump_walk_ctx_t_ { - unix_shared_memory_queue_t *q; + vl_api_registration_t *rp; u32 context; } abf_dump_walk_ctx_t; static int abf_policy_send_details (u32 api, void *args) { - fib_route_path_encode_t *api_rpaths = NULL, *api_rpath; + fib_path_encode_ctx_t walk_ctx = { + .rpaths = NULL, + }; vl_api_abf_policy_details_t *mp; abf_dump_walk_ctx_t *ctx; + fib_route_path_t *rpath; vl_api_fib_path_t *fp; size_t msg_size; abf_policy_t *ap; @@ -185,16 +156,18 @@ abf_policy_send_details (u32 api, void *args) mp->policy.acl_index = htonl (ap->ap_acl); mp->policy.policy_id = htonl (ap->ap_id); - fib_path_list_walk_w_ext (ap->ap_pl, NULL, fib_path_encode, &api_rpaths); + fib_path_list_walk_w_ext (ap->ap_pl, NULL, fib_path_encode, &walk_ctx); fp = mp->policy.paths; - vec_foreach (api_rpath, api_rpaths) + vec_foreach (rpath, walk_ctx.rpaths) { - fib_api_path_encode (api_rpath, fp); + fib_api_path_encode (rpath, fp); fp++; } - vl_msg_api_send_shmem (ctx->q, (u8 *) & mp); + vl_api_send_msg (ctx->rp, (u8 *) mp); + + vec_free (walk_ctx.rpaths); return (1); } @@ -202,16 +175,14 @@ abf_policy_send_details (u32 api, void *args) static void vl_api_abf_policy_dump_t_handler (vl_api_abf_policy_dump_t * mp) { - unix_shared_memory_queue_t *q; + vl_api_registration_t *rp; - q = vl_api_client_index_to_input_queue (mp->client_index); - if (q == 0) - { - return; - } + rp = vl_api_client_index_to_registration (mp->client_index); + if (rp == 0) + return; abf_dump_walk_ctx_t ctx = { - .q = q, + .rp = rp, .context = mp->context, }; @@ -239,7 +210,7 @@ abf_itf_attach_send_details (u32 aiai, void *args) mp->attach.priority = htonl (aia->aia_prio); mp->attach.is_ipv6 = (aia->aia_proto == FIB_PROTOCOL_IP6); - vl_msg_api_send_shmem (ctx->q, (u8 *) & mp); + vl_api_send_msg (ctx->rp, (u8 *) mp); return (1); } @@ -247,72 +218,29 @@ abf_itf_attach_send_details (u32 aiai, void *args) static void vl_api_abf_itf_attach_dump_t_handler (vl_api_abf_itf_attach_dump_t * mp) { - unix_shared_memory_queue_t *q; + vl_api_registration_t *rp; - q = vl_api_client_index_to_input_queue (mp->client_index); - if (q == 0) - { - return; - } + rp = vl_api_client_index_to_registration (mp->client_index); + if (rp == 0) + return; abf_dump_walk_ctx_t ctx = { - .q = q, + .rp = rp, .context = mp->context, }; abf_itf_attach_walk (abf_itf_attach_send_details, &ctx); } -#define vl_msg_name_crc_list -#include -#undef vl_msg_name_crc_list - -/* Set up the API message handling tables */ -static clib_error_t * -abf_plugin_api_hookup (vlib_main_t * vm) -{ -#define _(N,n) \ - vl_msg_api_set_handlers((VL_API_##N + abf_base_msg_id), \ - #n, \ - vl_api_##n##_t_handler, \ - vl_noop_handler, \ - vl_api_##n##_t_endian, \ - vl_api_##n##_t_print, \ - sizeof(vl_api_##n##_t), 1); - foreach_abf_plugin_api_msg; -#undef _ - - return 0; -} - -static void -setup_message_id_table (api_main_t * apim) -{ -#define _(id,n,crc) \ - vl_msg_api_add_msg_name_crc (apim, #n "_" #crc, id + abf_base_msg_id); - foreach_vl_msg_name_crc_abf; -#undef _ -} +#include static clib_error_t * abf_api_init (vlib_main_t * vm) { - clib_error_t *error = 0; - - u8 *name = format (0, "abf_%08x%c", api_version, 0); - /* Ask for a correctly-sized block of API message decode slots */ - abf_base_msg_id = vl_msg_api_get_msg_ids ((char *) name, - VL_MSG_FIRST_AVAILABLE); - - error = abf_plugin_api_hookup (vm); + abf_base_msg_id = setup_message_id_table (); - /* Add our API messages to the global name_crc hash table */ - setup_message_id_table (&api_main); - - vec_free (name); - - return error; + return 0; } VLIB_INIT_FUNCTION (abf_api_init); @@ -320,7 +248,7 @@ VLIB_INIT_FUNCTION (abf_api_init); /* *INDENT-OFF* */ VLIB_PLUGIN_REGISTER () = { .version = VPP_BUILD_VER, - .description = "ACL based Forwarding", + .description = "Access Control List (ACL) Based Forwarding", }; /* *INDENT-ON* */