X-Git-Url: https://gerrit.fd.io/r/gitweb?a=blobdiff_plain;f=src%2Fplugins%2Fperfmon%2Fperfmon_periodic.c;h=37d669b8d132bf377a436269a9f595096fe387aa;hb=refs%2Fchanges%2F39%2F26639%2F2;hp=944a8e38e72caf4a799595726bd7a005a87ee151;hpb=7297f47088274b0759dbef5d2c19d564d32521e6;p=vpp.git

diff --git a/src/plugins/perfmon/perfmon_periodic.c b/src/plugins/perfmon/perfmon_periodic.c
index 944a8e38e72..37d669b8d13 100644
--- a/src/plugins/perfmon/perfmon_periodic.c
+++ b/src/plugins/perfmon/perfmon_periodic.c
@@ -33,7 +33,9 @@ perf_event_open (struct perf_event_attr *hw_event, pid_t pid, int cpu,
 }
 
 static void
-read_current_perf_counters (vlib_main_t * vm, u64 * c0, u64 * c1)
+read_current_perf_counters (vlib_main_t * vm, u64 * c0, u64 * c1,
+			    vlib_node_runtime_t * node,
+			    vlib_frame_t * frame, int before_or_after)
 {
   int i;
   u64 *cc;
@@ -50,12 +52,18 @@ read_current_perf_counters (vlib_main_t * vm, u64 * c0, u64 * c1)
       else
 	{
 	  u64 sw_value;
-	  if (read (pm->pm_fds[i][my_thread_index], &sw_value,
-		    sizeof (sw_value)) != sizeof (sw_value))
+	  int read_result;
+	  if ((read_result = read (pm->pm_fds[i][my_thread_index], &sw_value,
+				   sizeof (sw_value)) != sizeof (sw_value)))
 	    {
 	      clib_unix_warning
-		("counter read failed, disable collection...");
-	      vm->vlib_node_runtime_perf_counter_cb = 0;
+		("counter read returned %d, expected %d",
+		 read_result, sizeof (sw_value));
+	      clib_callback_enable_disable
+		(vm->vlib_node_runtime_perf_counter_cbs,
+		 vm->vlib_node_runtime_perf_counter_cb_tmp,
+		 vm->worker_thread_main_loop_callback_lock,
+		 read_current_perf_counters, 0 /* enable */ );
 	      return;
 	    }
 	  *cc = sw_value;
@@ -122,6 +130,10 @@ enable_current_events (perfmon_main_t * pm)
 
   for (i = 0; i < limit; i++)
     {
+      vec_validate (pm->pm_fds[i], vec_len (vlib_mains) - 1);
+      vec_validate (pm->perf_event_pages[i], vec_len (vlib_mains) - 1);
+      vec_validate (pm->rdpmc_indices[i], vec_len (vlib_mains) - 1);
+
       c = vec_elt_at_index (pm->single_events_to_collect,
 			    pm->current_event + i);
 
@@ -161,6 +173,7 @@ enable_current_events (perfmon_main_t * pm)
 	      close (fd);
 	      return;
 	    }
+	  CLIB_MEM_UNPOISON (p, pm->page_size);
 	}
       else
 	p = 0;
@@ -200,7 +213,11 @@ enable_current_events (perfmon_main_t * pm)
 
   pm->n_active = i;
   /* Enable the main loop counter snapshot mechanism */
-  vm->vlib_node_runtime_perf_counter_cb = read_current_perf_counters;
+  clib_callback_enable_disable
+    (vm->vlib_node_runtime_perf_counter_cbs,
+     vm->vlib_node_runtime_perf_counter_cb_tmp,
+     vm->worker_thread_main_loop_callback_lock,
+     read_current_perf_counters, 1 /* enable */ );
 }
 
 static void
@@ -211,7 +228,11 @@ disable_events (perfmon_main_t * pm)
   int i;
 
   /* Stop main loop collection */
-  vm->vlib_node_runtime_perf_counter_cb = 0;
+  clib_callback_enable_disable
+    (vm->vlib_node_runtime_perf_counter_cbs,
+     vm->vlib_node_runtime_perf_counter_cb_tmp,
+     vm->worker_thread_main_loop_callback_lock,
+     read_current_perf_counters, 0 /* enable */ );
 
   for (i = 0; i < pm->n_active; i++)
     {
@@ -223,12 +244,16 @@ disable_events (perfmon_main_t * pm)
 	clib_unix_warning ("disable ioctl");
 
       if (pm->perf_event_pages[i][my_thread_index])
-	if (munmap (pm->perf_event_pages[i][my_thread_index],
-		    pm->page_size) < 0)
-	  clib_unix_warning ("munmap");
+	{
+	  if (munmap (pm->perf_event_pages[i][my_thread_index],
+		      pm->page_size) < 0)
+	    clib_unix_warning ("munmap");
+	  pm->perf_event_pages[i][my_thread_index] = 0;
+	}
 
       (void) close (pm->pm_fds[i][my_thread_index]);
       pm->pm_fds[i][my_thread_index] = 0;
+
     }
 }
 
@@ -237,16 +262,22 @@ worker_thread_start_event (vlib_main_t * vm)
 {
   perfmon_main_t *pm = &perfmon_main;
 
+  clib_callback_enable_disable (vm->worker_thread_main_loop_callbacks,
+				vm->worker_thread_main_loop_callback_tmp,
+				vm->worker_thread_main_loop_callback_lock,
+				worker_thread_start_event, 0 /* enable */ );
   enable_current_events (pm);
-  vm->worker_thread_main_loop_callback = 0;
 }
 
 static void
 worker_thread_stop_event (vlib_main_t * vm)
 {
   perfmon_main_t *pm = &perfmon_main;
+  clib_callback_enable_disable (vm->worker_thread_main_loop_callbacks,
+				vm->worker_thread_main_loop_callback_tmp,
+				vm->worker_thread_main_loop_callback_lock,
+				worker_thread_stop_event, 0 /* enable */ );
   disable_events (pm);
-  vm->worker_thread_main_loop_callback = 0;
 }
 
 static void
@@ -283,8 +314,11 @@ start_event (perfmon_main_t * pm, f64 now, uword event_data)
 	continue;
 
       if (all || clib_bitmap_get (pm->thread_bitmap, i))
-	vlib_mains[i]->worker_thread_main_loop_callback = (void *)
-	  worker_thread_start_event;
+	clib_callback_enable_disable
+	  (vlib_mains[i]->worker_thread_main_loop_callbacks,
+	   vlib_mains[i]->worker_thread_main_loop_callback_tmp,
+	   vlib_mains[i]->worker_thread_main_loop_callback_lock,
+	   (void *) worker_thread_start_event, 1 /* enable */ );
     }
 }
 
@@ -443,8 +477,11 @@ handle_timeout (vlib_main_t * vm, perfmon_main_t * pm, f64 now)
       if (vlib_mains[i] == 0)
 	continue;
       if (all || clib_bitmap_get (pm->thread_bitmap, i))
-	vlib_mains[i]->worker_thread_main_loop_callback = (void *)
-	  worker_thread_stop_event;
+	clib_callback_enable_disable
+	  (vlib_mains[i]->worker_thread_main_loop_callbacks,
+	   vlib_mains[i]->worker_thread_main_loop_callback_tmp,
+	   vlib_mains[i]->worker_thread_main_loop_callback_lock,
+	   (void *) worker_thread_stop_event, 1 /* enable */ );
     }
 
   /* Make sure workers have stopped collection */
@@ -455,7 +492,10 @@ handle_timeout (vlib_main_t * vm, perfmon_main_t * pm, f64 now)
       for (i = 1; i < vec_len (vlib_mains); i++)
 	{
 	  /* Has the worker actually stopped collecting data? */
-	  while (vlib_mains[i]->worker_thread_main_loop_callback)
+	  while (clib_callback_is_set
+		 (vlib_mains[i]->worker_thread_main_loop_callbacks,
+		  vlib_mains[i]->worker_thread_main_loop_callback_lock,
+		  read_current_perf_counters))
 	    {
 	      if (vlib_time_now (vm) > deadman)
 		{
@@ -484,8 +524,11 @@ handle_timeout (vlib_main_t * vm, perfmon_main_t * pm, f64 now)
       if (vlib_mains[i] == 0)
 	continue;
       if (all || clib_bitmap_get (pm->thread_bitmap, i))
-	vlib_mains[i]->worker_thread_main_loop_callback = (void *)
-	  worker_thread_start_event;
+	clib_callback_enable_disable
+	  (vlib_mains[i]->worker_thread_main_loop_callbacks,
+	   vlib_mains[i]->worker_thread_main_loop_callback_tmp,
+	   vlib_mains[i]->worker_thread_main_loop_callback_lock,
+	   worker_thread_start_event, 1 /* enable */ );
     }
 }