X-Git-Url: https://gerrit.fd.io/r/gitweb?a=blobdiff_plain;f=src%2Fsvm%2Fssvm.c;h=0305278a6b6e439a65142e779601ee1a1b6687d8;hb=2c8e0023f91882e53f06eb99c901b97fe013f981;hp=3e45175da0ea71c9e2f1ca9a6984bcb79aa0ede0;hpb=404b8a36e737e2911ca8874363a4e87cb707e5f9;p=vpp.git

diff --git a/src/svm/ssvm.c b/src/svm/ssvm.c
index 3e45175da0e..0305278a6b6 100644
--- a/src/svm/ssvm.c
+++ b/src/svm/ssvm.c
@@ -29,9 +29,6 @@ int
 ssvm_master_init_shm (ssvm_private_t * ssvm)
 {
   int ssvm_fd;
-#if USE_DLMALLOC == 0
-  int mh_flags = MHEAP_FLAG_DISABLE_VM | MHEAP_FLAG_THREAD_SAFE;
-#endif
   clib_mem_vm_map_t mapa = { 0 };
   u8 junk = 0, *ssvm_filename;
   ssvm_shared_header_t *sh;
@@ -90,6 +87,7 @@ ssvm_master_init_shm (ssvm_private_t * ssvm)
   mapa.requested_va = requested_va;
   mapa.size = ssvm->ssvm_size;
   mapa.fd = ssvm_fd;
+  mapa.numa_node = ssvm->numa;
   if (clib_mem_vm_ext_map (&mapa))
     {
       clib_unix_warning ("mmap");
@@ -103,15 +101,10 @@ ssvm_master_init_shm (ssvm_private_t * ssvm)
   sh->ssvm_size = ssvm->ssvm_size;
   sh->ssvm_va = pointer_to_uword (sh);
   sh->type = SSVM_SEGMENT_SHM;
-#if USE_DLMALLOC == 0
-  sh->heap = mheap_alloc_with_flags (((u8 *) sh) + page_size,
-				     ssvm->ssvm_size - page_size, mh_flags);
-#else
   sh->heap = create_mspace_with_base (((u8 *) sh) + page_size,
 				      ssvm->ssvm_size - page_size,
 				      1 /* locked */ );
   mspace_disable_expand (sh->heap);
-#endif
 
   oldheap = ssvm_push_heap (sh);
   sh->name = format (0, "%s", ssvm->name, 0);
@@ -213,7 +206,7 @@ ssvm_delete_shm (ssvm_private_t * ssvm)
   vec_free (fn);
   vec_free (ssvm->name);
 
-  munmap ((void *) ssvm->requested_va, ssvm->ssvm_size);
+  munmap ((void *) ssvm->sh, ssvm->ssvm_size);
 }
 
 /**
@@ -237,6 +230,11 @@ ssvm_master_init_memfd (ssvm_private_t * memfd)
   alloc.size = memfd->ssvm_size;
   alloc.flags = CLIB_MEM_VM_F_SHARED;
   alloc.requested_va = memfd->requested_va;
+  if (memfd->numa)
+    {
+      alloc.numa_node = memfd->numa;
+      alloc.flags |= CLIB_MEM_VM_F_NUMA_PREFER;
+    }
   if ((err = clib_mem_vm_ext_alloc (&alloc)))
     {
       clib_error_report (err);
@@ -255,17 +253,10 @@ ssvm_master_init_memfd (ssvm_private_t * memfd)
   sh->ssvm_va = pointer_to_uword (sh);
   sh->type = SSVM_SEGMENT_MEMFD;
 
-#if USE_DLMALLOC == 0
-  uword flags = MHEAP_FLAG_DISABLE_VM | MHEAP_FLAG_THREAD_SAFE;
-
-  sh->heap = mheap_alloc_with_flags (((u8 *) sh) + page_size,
-				     memfd->ssvm_size - page_size, flags);
-#else
   sh->heap = create_mspace_with_base (((u8 *) sh) + page_size,
 				      memfd->ssvm_size - page_size,
 				      1 /* locked */ );
   mspace_disable_expand (sh->heap);
-#endif
   oldheap = ssvm_push_heap (sh);
   sh->name = format (0, "%s", memfd->name, 0);
   ssvm_pop_heap (oldheap);
@@ -347,44 +338,59 @@ ssvm_delete_memfd (ssvm_private_t * memfd)
 int
 ssvm_master_init_private (ssvm_private_t * ssvm)
 {
+  uword pagesize = clib_mem_get_page_size (), rnd_size = 0;
+  clib_mem_vm_alloc_t alloc = { 0 };
+  struct dlmallinfo dlminfo;
   ssvm_shared_header_t *sh;
-  u32 pagesize = clib_mem_get_page_size ();
-  u32 rnd_size = 0;
+  clib_error_t *err;
   u8 *heap;
 
-  rnd_size = (ssvm->ssvm_size + (pagesize - 1)) & ~(pagesize - 1);
-  rnd_size = clib_min (rnd_size, ((u64) 1 << 32) - pagesize);
-
-#if USE_DLMALLOC == 0
-  {
-    mheap_t *heap_header;
-
-    heap = mheap_alloc (0, rnd_size);
-    if (heap == 0)
-      {
-	clib_unix_warning ("mheap alloc");
-	return -1;
-      }
-    heap_header = mheap_header (heap);
-    heap_header->flags |= MHEAP_FLAG_THREAD_SAFE;
-  }
-#else
-  heap = create_mspace (rnd_size, 1 /* locked */ );
-#endif
+  rnd_size = clib_max (ssvm->ssvm_size + (pagesize - 1), ssvm->ssvm_size);
+  rnd_size &= ~(pagesize - 1);
+
+  alloc.name = (char *) ssvm->name;
+  alloc.size = rnd_size + pagesize;
+  if (ssvm->numa)
+    {
+      alloc.numa_node = ssvm->numa;
+      alloc.flags |= CLIB_MEM_VM_F_NUMA_PREFER;
+    }
+
+  if ((err = clib_mem_vm_ext_alloc (&alloc)))
+    {
+      clib_error_report (err);
+      return SSVM_API_ERROR_CREATE_FAILURE;
+    }
+
+  heap = create_mspace_with_base ((u8 *) alloc.addr + pagesize, rnd_size,
+				  1 /* locked */ );
+  if (heap == 0)
+    {
+      clib_unix_warning ("mheap alloc");
+      return -1;
+    }
+
+  mspace_disable_expand (heap);
+
+  /* Find actual size because mspace size is rounded up by dlmalloc */
+  dlminfo = mspace_mallinfo (heap);
+  rnd_size = dlminfo.fordblks;
 
   ssvm->ssvm_size = rnd_size;
   ssvm->i_am_master = 1;
   ssvm->my_pid = getpid ();
   ssvm->requested_va = ~0;
 
-  /* Allocate a [sic] shared memory header, in process memory... */
-  sh = clib_mem_alloc_aligned (sizeof (*sh), CLIB_CACHE_LINE_BYTES);
+  /* First page in allocated memory is set aside for the shared header */
+  sh = alloc.addr;
   ssvm->sh = sh;
 
   clib_memset (sh, 0, sizeof (*sh));
   sh->heap = heap;
+  sh->ssvm_size = rnd_size;
   sh->ssvm_va = pointer_to_uword (heap);
   sh->type = SSVM_SEGMENT_PRIVATE;
+  sh->name = ssvm->name;
 
   return 0;
 }
@@ -400,12 +406,8 @@ void
 ssvm_delete_private (ssvm_private_t * ssvm)
 {
   vec_free (ssvm->name);
-#if USE_DLMALLOC == 0
-  mheap_free (ssvm->sh->heap);
-#else
   destroy_mspace (ssvm->sh->heap);
-#endif
-  clib_mem_free (ssvm->sh);
+  clib_mem_vm_free (ssvm->sh, ssvm->ssvm_size + clib_mem_get_page_size ());
 }
 
 int