X-Git-Url: https://gerrit.fd.io/r/gitweb?a=blobdiff_plain;f=src%2Fsvm%2Fsvm_fifo.c;h=14729710aac27e79aecef9fdcddabb74a625b22c;hb=b46241889;hp=6bd6f9157bc0b000fe668b92363d4a09731131b3;hpb=73cad33b56ffc08943e9c0d73ecb14466558baae;p=vpp.git diff --git a/src/svm/svm_fifo.c b/src/svm/svm_fifo.c index 6bd6f9157bc..14729710aac 100644 --- a/src/svm/svm_fifo.c +++ b/src/svm/svm_fifo.c @@ -18,15 +18,19 @@ */ #include +#include #include -CLIB_MARCH_FN (svm_fifo_copy_to_chunk, void, svm_fifo_t * f, - svm_fifo_chunk_t * c, u32 tail_idx, const u8 * src, u32 len, - svm_fifo_chunk_t ** last) +#define F_INVALID_CPTR (svm_fifo_chunk_ptr_t) ~0ULL + +CLIB_MARCH_FN (svm_fifo_copy_to_chunk, void, svm_fifo_t *f, + svm_fifo_chunk_t *c, u32 tail_idx, const u8 *src, u32 len, + svm_fifo_chunk_ptr_t *last) { u32 n_chunk; - ASSERT (tail_idx >= c->start_byte && tail_idx < c->start_byte + c->length); + ASSERT (f_pos_geq (tail_idx, c->start_byte) + && f_pos_lt (tail_idx, c->start_byte + c->length)); tail_idx -= c->start_byte; n_chunk = c->length - tail_idx; @@ -34,15 +38,15 @@ CLIB_MARCH_FN (svm_fifo_copy_to_chunk, void, svm_fifo_t * f, { u32 to_copy = len; clib_memcpy_fast (&c->data[tail_idx], src, n_chunk); - c = c->next; + c = f_cptr (f, c->next); while ((to_copy -= n_chunk)) { n_chunk = clib_min (c->length, to_copy); clib_memcpy_fast (&c->data[0], src + (len - to_copy), n_chunk); - c = c->length <= to_copy ? c->next : c; + c = c->length <= to_copy ? f_cptr (f, c->next) : c; } if (*last) - *last = c; + *last = f_csptr (f, c); } else { @@ -50,13 +54,14 @@ CLIB_MARCH_FN (svm_fifo_copy_to_chunk, void, svm_fifo_t * f, } } -CLIB_MARCH_FN (svm_fifo_copy_from_chunk, void, svm_fifo_t * f, - svm_fifo_chunk_t * c, u32 head_idx, u8 * dst, u32 len, - svm_fifo_chunk_t ** last) +CLIB_MARCH_FN (svm_fifo_copy_from_chunk, void, svm_fifo_t *f, + svm_fifo_chunk_t *c, u32 head_idx, u8 *dst, u32 len, + svm_fifo_chunk_ptr_t *last) { u32 n_chunk; - ASSERT (head_idx >= c->start_byte && head_idx < c->start_byte + c->length); + ASSERT (f_pos_geq (head_idx, c->start_byte) + && f_pos_lt (head_idx, c->start_byte + c->length)); head_idx -= c->start_byte; n_chunk = c->length - head_idx; @@ -64,15 +69,17 @@ CLIB_MARCH_FN (svm_fifo_copy_from_chunk, void, svm_fifo_t * f, { u32 to_copy = len; clib_memcpy_fast (dst, &c->data[head_idx], n_chunk); - c = c->next; + c = f_cptr (f, c->next); while ((to_copy -= n_chunk)) { + CLIB_MEM_UNPOISON (c, sizeof (*c)); + CLIB_MEM_UNPOISON (c->data, c->length); n_chunk = clib_min (c->length, to_copy); clib_memcpy_fast (dst + (len - to_copy), &c->data[0], n_chunk); - c = c->length <= to_copy ? c->next : c; + c = c->length <= to_copy ? f_cptr (f, c->next) : c; } if (*last) - *last = c; + *last = f_csptr (f, c); } else { @@ -83,49 +90,25 @@ CLIB_MARCH_FN (svm_fifo_copy_from_chunk, void, svm_fifo_t * f, #ifndef CLIB_MARCH_VARIANT static inline void -svm_fifo_copy_to_chunk (svm_fifo_t * f, svm_fifo_chunk_t * c, u32 tail_idx, - const u8 * src, u32 len, svm_fifo_chunk_t ** last) +svm_fifo_copy_to_chunk (svm_fifo_t *f, svm_fifo_chunk_t *c, u32 tail_idx, + const u8 *src, u32 len, svm_fifo_chunk_ptr_t *last) { CLIB_MARCH_FN_SELECT (svm_fifo_copy_to_chunk) (f, c, tail_idx, src, len, last); } static inline void -svm_fifo_copy_from_chunk (svm_fifo_t * f, svm_fifo_chunk_t * c, u32 head_idx, - u8 * dst, u32 len, svm_fifo_chunk_t ** last) +svm_fifo_copy_from_chunk (svm_fifo_t *f, svm_fifo_chunk_t *c, u32 head_idx, + u8 *dst, u32 len, svm_fifo_chunk_ptr_t *last) { CLIB_MARCH_FN_SELECT (svm_fifo_copy_from_chunk) (f, c, head_idx, dst, len, last); } -static inline u8 -position_lt (svm_fifo_t * f, u32 a, u32 b, u32 tail) -{ - return (f_distance_to (f, a, tail) < f_distance_to (f, b, tail)); -} - -static inline u8 -position_leq (svm_fifo_t * f, u32 a, u32 b, u32 tail) -{ - return (f_distance_to (f, a, tail) <= f_distance_to (f, b, tail)); -} - -static inline u8 -position_gt (svm_fifo_t * f, u32 a, u32 b, u32 tail) -{ - return (f_distance_to (f, a, tail) > f_distance_to (f, b, tail)); -} - -static inline u32 -position_diff (svm_fifo_t * f, u32 a, u32 b, u32 tail) -{ - return f_distance_to (f, a, tail) - f_distance_to (f, b, tail); -} - static inline u32 -ooo_segment_end_pos (svm_fifo_t * f, ooo_segment_t * s) +ooo_segment_end_pos (ooo_segment_t * s) { - return (s->start + s->length) % f->size; + return (s->start + s->length); } void @@ -200,10 +183,10 @@ ooo_segment_add (svm_fifo_t * f, u32 offset, u32 head, u32 tail, u32 length) u32 new_index, s_end_pos, s_index; u32 offset_pos, offset_end_pos; - ASSERT (offset + length <= f_distance_to (f, head, tail) || head == tail); + ASSERT (offset + length <= f_free_count (f, head, tail)); - offset_pos = (tail + offset) % f->size; - offset_end_pos = (tail + offset + length) % f->size; + offset_pos = tail + offset; + offset_end_pos = tail + offset + length; f->ooos_newest = OOO_SEGMENT_INVALID_INDEX; @@ -218,28 +201,27 @@ ooo_segment_add (svm_fifo_t * f, u32 offset, u32 head, u32 tail, u32 length) /* Find first segment that starts after new segment */ s = pool_elt_at_index (f->ooo_segments, f->ooos_list_head); while (s->next != OOO_SEGMENT_INVALID_INDEX - && position_lt (f, s->start, offset_pos, tail)) + && f_pos_lt (s->start, offset_pos)) s = pool_elt_at_index (f->ooo_segments, s->next); /* If we have a previous and we overlap it, use it as starting point */ prev = ooo_segment_prev (f, s); - if (prev - && position_leq (f, offset_pos, ooo_segment_end_pos (f, prev), tail)) + if (prev && f_pos_leq (offset_pos, ooo_segment_end_pos (prev))) { s = prev; - s_end_pos = ooo_segment_end_pos (f, s); + s_end_pos = ooo_segment_end_pos (s); /* Since we have previous, offset start position cannot be smaller * than prev->start. Check tail */ - ASSERT (position_lt (f, s->start, offset_pos, tail)); + ASSERT (f_pos_lt (s->start, offset_pos)); goto check_tail; } s_index = s - f->ooo_segments; - s_end_pos = ooo_segment_end_pos (f, s); + s_end_pos = ooo_segment_end_pos (s); /* No overlap, add before current segment */ - if (position_lt (f, offset_end_pos, s->start, tail)) + if (f_pos_lt (offset_end_pos, s->start)) { new_s = ooo_segment_alloc (f, offset_pos, length); new_index = new_s - f->ooo_segments; @@ -264,7 +246,7 @@ ooo_segment_add (svm_fifo_t * f, u32 offset, u32 head, u32 tail, u32 length) return; } /* No overlap, add after current segment */ - else if (position_gt (f, offset_pos, s_end_pos, tail)) + else if (f_pos_gt (offset_pos, s_end_pos)) { new_s = ooo_segment_alloc (f, offset_pos, length); new_index = new_s - f->ooo_segments; @@ -287,24 +269,23 @@ ooo_segment_add (svm_fifo_t * f, u32 offset, u32 head, u32 tail, u32 length) */ /* Merge at head */ - if (position_lt (f, offset_pos, s->start, tail)) + if (f_pos_lt (offset_pos, s->start)) { s->start = offset_pos; - s->length = position_diff (f, s_end_pos, s->start, tail); + s->length = s_end_pos - s->start; f->ooos_newest = s - f->ooo_segments; } check_tail: /* Overlapping tail */ - if (position_gt (f, offset_end_pos, s_end_pos, tail)) + if (f_pos_gt (offset_end_pos, s_end_pos)) { - s->length = position_diff (f, offset_end_pos, s->start, tail); + s->length = offset_end_pos - s->start; /* Remove the completely overlapped segments in the tail */ it = ooo_segment_next (f, s); - while (it && position_leq (f, ooo_segment_end_pos (f, it), - offset_end_pos, tail)) + while (it && f_pos_leq (ooo_segment_end_pos (it), offset_end_pos)) { next = ooo_segment_next (f, it); ooo_segment_free (f, it - f->ooo_segments); @@ -312,10 +293,9 @@ check_tail: } /* If partial overlap with last, merge */ - if (it && position_leq (f, it->start, offset_end_pos, tail)) + if (it && f_pos_leq (it->start, offset_end_pos)) { - s->length = position_diff (f, ooo_segment_end_pos (f, it), - s->start, tail); + s->length = ooo_segment_end_pos (it) - s->start; ooo_segment_free (f, it - f->ooo_segments); } f->ooos_newest = s - f->ooo_segments; @@ -334,7 +314,7 @@ ooo_segment_try_collect (svm_fifo_t * f, u32 n_bytes_enqueued, u32 * tail) i32 diff; s = pool_elt_at_index (f->ooo_segments, f->ooos_list_head); - diff = f_distance_from (f, s->start, *tail); + diff = *tail - s->start; ASSERT (diff != n_bytes_enqueued); @@ -350,7 +330,7 @@ ooo_segment_try_collect (svm_fifo_t * f, u32 n_bytes_enqueued, u32 * tail) if (s->length > diff) { bytes = s->length - diff; - *tail = (*tail + bytes) % f->size; + *tail = *tail + bytes; ooo_segment_free (f, s_index); break; } @@ -359,7 +339,7 @@ ooo_segment_try_collect (svm_fifo_t * f, u32 n_bytes_enqueued, u32 * tail) if (s->next != OOO_SEGMENT_INVALID_INDEX) { s = pool_elt_at_index (f->ooo_segments, s->next); - diff = f_distance_from (f, s->start, *tail); + diff = *tail - s->start; ooo_segment_free (f, s_index); } /* End of search */ @@ -370,11 +350,11 @@ ooo_segment_try_collect (svm_fifo_t * f, u32 n_bytes_enqueued, u32 * tail) } } - ASSERT (bytes <= f->nitems); + ASSERT (bytes <= f->shr->size); return bytes; } -static ooo_segment_t * +__clib_unused static ooo_segment_t * ooo_segment_last (svm_fifo_t * f) { ooo_segment_t *s; @@ -391,41 +371,51 @@ ooo_segment_last (svm_fifo_t * f) void svm_fifo_init (svm_fifo_t * f, u32 size) { - f->size = size; - /* - * usable size of the fifo set to rounded_data_size - 1 - * to differentiate between free fifo and empty fifo. - */ - f->nitems = f->size - 1; + svm_fifo_chunk_t *c, *prev; + u32 min_alloc; + + f->shr->size = size; f->ooos_list_head = OOO_SEGMENT_INVALID_INDEX; f->segment_index = SVM_FIFO_INVALID_INDEX; f->refcnt = 1; - f->head = f->tail = f->flags = 0; - f->head_chunk = f->tail_chunk = f->ooo_enq = f->ooo_deq = f->start_chunk; -} - -void -svm_fifo_init_chunks (svm_fifo_t * f) -{ - svm_fifo_chunk_t *c, *prev; - - if (f->start_chunk->next == f->start_chunk) - return; + f->shr->head = f->shr->tail = f->flags = 0; + f->shr->head_chunk = f->shr->tail_chunk = f->shr->start_chunk; + f->ooo_deq = f->ooo_enq = 0; - f->flags |= SVM_FIFO_F_MULTI_CHUNK; - rb_tree_init (&f->chunk_lookup); - rb_tree_add2 (&f->chunk_lookup, 0, pointer_to_uword (f->start_chunk)); + min_alloc = size > 32 << 10 ? size >> 3 : 4096; + min_alloc = clib_min (min_alloc, 64 << 10); + f->shr->min_alloc = min_alloc; - f->start_chunk->start_byte = 0; - prev = f->start_chunk; - c = prev->next; + /* + * Initialize chunks + */ + prev = f_start_cptr (f); + prev->start_byte = 0; + prev->enq_rb_index = prev->deq_rb_index = RBTREE_TNIL_INDEX; + c = f_cptr (f, prev->next); - while (c != f->start_chunk) + while (c) { c->start_byte = prev->start_byte + prev->length; - rb_tree_add2 (&f->chunk_lookup, c->start_byte, pointer_to_uword (c)); + c->enq_rb_index = c->deq_rb_index = RBTREE_TNIL_INDEX; + ASSERT (c->length >= 1 << FS_MIN_LOG2_CHUNK_SZ); prev = c; - c = c->next; + c = f_cptr (f, c->next); + } +} + +void +svm_fifo_init_ooo_lookup (svm_fifo_t * f, u8 ooo_type) +{ + if (ooo_type == 0) + { + ASSERT (!rb_tree_is_init (&f->ooo_enq_lookup)); + rb_tree_init (&f->ooo_enq_lookup); + } + else + { + ASSERT (!rb_tree_is_init (&f->ooo_deq_lookup)); + rb_tree_init (&f->ooo_deq_lookup); } } @@ -433,7 +423,7 @@ svm_fifo_init_chunks (svm_fifo_t * f) * Creates a fifo in the current heap. Fails vs blow up the process */ svm_fifo_t * -svm_fifo_create (u32 data_size_in_bytes) +svm_fifo_alloc (u32 data_size_in_bytes) { u32 rounded_data_size; svm_fifo_chunk_t *c; @@ -455,12 +445,13 @@ svm_fifo_create (u32 data_size_in_bytes) return 0; } - c->next = c; + clib_memset (c, 0, sizeof (*c)); c->start_byte = 0; c->length = data_size_in_bytes; - f->start_chunk = f->end_chunk = c; + c->enq_rb_index = RBTREE_TNIL_INDEX; + c->deq_rb_index = RBTREE_TNIL_INDEX; + f->shr->start_chunk = f->shr->end_chunk = f_csptr (f, c); - svm_fifo_init (f, data_size_in_bytes); return f; } @@ -485,12 +476,6 @@ svm_fifo_chunk_alloc (u32 size) return c; } -static inline u8 -svm_fifo_chunk_includes_pos (svm_fifo_chunk_t * c, u32 pos) -{ - return (pos >= c->start_byte && pos < c->start_byte + c->length); -} - /** * Find chunk for given byte position * @@ -502,270 +487,281 @@ svm_fifo_chunk_includes_pos (svm_fifo_chunk_t * c, u32 pos) static svm_fifo_chunk_t * svm_fifo_find_chunk (svm_fifo_t * f, u32 pos) { - rb_tree_t *rt = &f->chunk_lookup; - rb_node_t *cur, *prev; svm_fifo_chunk_t *c; + c = f_start_cptr (f); + while (c && !f_chunk_includes_pos (c, pos)) + c = f_cptr (f, c->next); + + return c; +} + +static svm_fifo_chunk_t * +svm_fifo_find_next_chunk (svm_fifo_t * f, svm_fifo_chunk_t * start, u32 pos) +{ + svm_fifo_chunk_t *c; + + ASSERT (start != 0); + + c = start; + while (c && !f_chunk_includes_pos (c, pos)) + c = f_cptr (f, c->next); + + return c; +} + +u32 +svm_fifo_max_read_chunk (svm_fifo_t * f) +{ + u32 head, tail, end_chunk; + + f_load_head_tail_cons (f, &head, &tail); + ASSERT (!f->shr->head_chunk || f_chunk_includes_pos (f_head_cptr (f), head)); + + if (!f->shr->head_chunk) + { + f->shr->head_chunk = f_csptr (f, svm_fifo_find_chunk (f, head)); + if (PREDICT_FALSE (!f->shr->head_chunk)) + return 0; + } + + end_chunk = f_chunk_end (f_head_cptr (f)); + + return f_pos_lt (end_chunk, tail) ? end_chunk - head : tail - head; +} + +u32 +svm_fifo_max_write_chunk (svm_fifo_t * f) +{ + svm_fifo_chunk_t *tail_chunk; + u32 head, tail; + + f_load_head_tail_prod (f, &head, &tail); + tail_chunk = f_tail_cptr (f); + + ASSERT (!tail_chunk || f_chunk_includes_pos (tail_chunk, tail)); + + return tail_chunk ? f_chunk_end (tail_chunk) - tail : 0; +} + +static rb_node_t * +f_find_node_rbtree (rb_tree_t * rt, u32 pos) +{ + rb_node_t *cur, *prev; + cur = rb_node (rt, rt->root); + if (PREDICT_FALSE (rb_node_is_tnil (rt, cur))) + return 0; + while (pos != cur->key) { prev = cur; - if (pos < cur->key) - cur = rb_node_left (rt, cur); - else - cur = rb_node_right (rt, cur); - - if (rb_node_is_tnil (rt, cur)) + if (f_pos_lt (pos, cur->key)) { - /* Hit tnil as a left child. Find predecessor */ - if (pos < prev->key) + cur = rb_node_left (rt, cur); + if (rb_node_is_tnil (rt, cur)) { cur = rb_tree_predecessor (rt, prev); - if (rb_node_is_tnil (rt, cur)) - return 0; - c = uword_to_pointer (cur->opaque, svm_fifo_chunk_t *); - if (svm_fifo_chunk_includes_pos (c, pos)) - return c; - return 0; + break; + } + } + else + { + cur = rb_node_right (rt, cur); + if (rb_node_is_tnil (rt, cur)) + { + cur = prev; + break; } - /* Hit tnil as a right child. Check if this is the one */ - c = uword_to_pointer (prev->opaque, svm_fifo_chunk_t *); - if (svm_fifo_chunk_includes_pos (c, pos)) - return c; - - return 0; } } - if (!rb_node_is_tnil (rt, cur)) - return uword_to_pointer (cur->opaque, svm_fifo_chunk_t *); - return 0; + if (rb_node_is_tnil (rt, cur)) + return 0; + + return cur; } -static inline void -svm_fifo_grow (svm_fifo_t * f, svm_fifo_chunk_t * c) +static svm_fifo_chunk_t * +f_find_chunk_rbtree (rb_tree_t * rt, u32 pos) { - svm_fifo_chunk_t *prev; - u32 add_bytes = 0; - - if (!c) - return; + svm_fifo_chunk_t *c; + rb_node_t *n; - f->end_chunk->next = c; - while (c) - { - add_bytes += c->length; - prev = c; - c = c->next; - } - f->end_chunk = prev; - prev->next = f->start_chunk; - f->size += add_bytes; - f->nitems = f->size - 1; - f->new_chunks = 0; -} + if (!rb_tree_is_init (rt)) + return 0; -static void -svm_fifo_try_grow (svm_fifo_t * f, u32 new_head) -{ - if (new_head > f->tail) - return; + n = f_find_node_rbtree (rt, pos); + if (!n) + return 0; + c = uword_to_pointer (n->opaque, svm_fifo_chunk_t *); + if (f_chunk_includes_pos (c, pos)) + return c; - svm_fifo_grow (f, f->new_chunks); - f->flags &= ~SVM_FIFO_F_GROW; + return 0; } -void -svm_fifo_add_chunk (svm_fifo_t * f, svm_fifo_chunk_t * c) +static void +f_update_ooo_enq (svm_fifo_t * f, u32 start_pos, u32 end_pos) { - svm_fifo_chunk_t *cur, *prev; + rb_tree_t *rt = &f->ooo_enq_lookup; + svm_fifo_chunk_t *c; + rb_node_t *cur; - /* Initialize rbtree if needed and add default chunk to it. Expectation is - * that this is called with the heap where the rbtree's pool is pushed. */ - if (!(f->flags & SVM_FIFO_F_MULTI_CHUNK)) + /* Use linear search if rbtree is not initialized */ + if (PREDICT_FALSE (!rb_tree_is_init (rt))) { - ASSERT (f->start_chunk->next == f->start_chunk); - rb_tree_init (&f->chunk_lookup); - rb_tree_add2 (&f->chunk_lookup, 0, pointer_to_uword (f->start_chunk)); - f->flags |= SVM_FIFO_F_MULTI_CHUNK; + f->ooo_enq = svm_fifo_find_next_chunk (f, f_tail_cptr (f), start_pos); + return; } - /* Initialize chunks and add to lookup rbtree */ - cur = c; - if (f->new_chunks) + if (rt->root == RBTREE_TNIL_INDEX) { - prev = f->new_chunks; - while (prev->next) - prev = prev->next; - prev->next = c; + c = f_tail_cptr (f); + ASSERT (c->enq_rb_index == RBTREE_TNIL_INDEX); + c->enq_rb_index = rb_tree_add_custom (rt, c->start_byte, + pointer_to_uword (c), f_pos_lt); } else - prev = f->end_chunk; - - while (cur) { - cur->start_byte = prev->start_byte + prev->length; - rb_tree_add2 (&f->chunk_lookup, cur->start_byte, - pointer_to_uword (cur)); - prev = cur; - cur = cur->next; + cur = f_find_node_rbtree (rt, start_pos); + c = uword_to_pointer (cur->opaque, svm_fifo_chunk_t *); + ASSERT (f_pos_leq (c->start_byte, start_pos)); } - /* If fifo is not wrapped, update the size now */ - if (!svm_fifo_is_wrapped (f)) - { - ASSERT (!f->new_chunks); - svm_fifo_grow (f, c); - return; - } + if (f_chunk_includes_pos (c, start_pos)) + f->ooo_enq = c; - /* Postpone size update */ - if (!f->new_chunks) - { - f->new_chunks = c; - f->flags |= SVM_FIFO_F_GROW; - } -} + if (f_chunk_includes_pos (c, end_pos)) + return; -/** - * Removes chunks that are after fifo end byte - */ -svm_fifo_chunk_t * -svm_fifo_collect_chunks (svm_fifo_t * f) -{ - svm_fifo_chunk_t *list, *cur; + do + { + c = f_cptr (f, c->next); + if (!c || c->enq_rb_index != RBTREE_TNIL_INDEX) + break; - f->flags &= ~SVM_FIFO_F_COLLECT_CHUNKS; + c->enq_rb_index = rb_tree_add_custom (rt, c->start_byte, + pointer_to_uword (c), f_pos_lt); - list = f->new_chunks; - f->new_chunks = 0; - cur = list; - while (cur) - { - rb_tree_del (&f->chunk_lookup, cur->start_byte); - cur = cur->next; + if (f_chunk_includes_pos (c, start_pos)) + f->ooo_enq = c; } - - return list; + while (!f_chunk_includes_pos (c, end_pos)); } -void -svm_fifo_try_shrink (svm_fifo_t * f, u32 head, u32 tail) +static void +f_update_ooo_deq (svm_fifo_t * f, u32 start_pos, u32 end_pos) { - u32 len_to_shrink = 0, tail_pos, len, last_pos; - svm_fifo_chunk_t *cur, *prev, *next, *start; + rb_tree_t *rt = &f->ooo_deq_lookup; + rb_node_t *cur; + svm_fifo_chunk_t *c; - tail_pos = tail; - if (f->ooos_list_head != OOO_SEGMENT_INVALID_INDEX) + /* Use linear search if rbtree is not initialized */ + if (PREDICT_FALSE (!rb_tree_is_init (rt))) { - ooo_segment_t *last = ooo_segment_last (f); - tail_pos = ooo_segment_end_pos (f, last); + f->ooo_deq = svm_fifo_find_chunk (f, start_pos); + return; } - if (f->size_decrement) + if (rt->root == RBTREE_TNIL_INDEX) { - /* Figure out available free space considering that there may be - * ooo segments */ - len = clib_min (f->size_decrement, f_free_count (f, head, tail_pos)); - f->nitems -= len; - f->size_decrement -= len; + c = f_start_cptr (f); + ASSERT (c->deq_rb_index == RBTREE_TNIL_INDEX); + c->deq_rb_index = rb_tree_add_custom (rt, c->start_byte, + pointer_to_uword (c), f_pos_lt); } - - /* Remove tail chunks if the following hold: - * - not wrapped - * - last used byte less than start of last chunk - */ - if (tail_pos >= head && tail_pos < f->end_chunk->start_byte) + else { - /* Lookup the last position not to be removed. Since size still needs - * to be nitems + 1, nitems must fall within the usable space. Also, - * first segment is not removable, so tail_pos can be 0. */ - last_pos = tail_pos > 0 ? tail_pos - 1 : tail_pos; - prev = svm_fifo_find_chunk (f, clib_max (f->nitems, last_pos)); - next = prev->next; - /* If tail_pos is first position in next, skip the chunk, otherwise, - * we must update the tail and, if fifo size is 0, even the head. - * We should not invalidate the tail for the caller and must not change - * consumer owned variables from code that's typically called by the - * producer */ - if (next->start_byte == tail_pos) - { - prev = next; - next = next->next; - } - while (next != f->start_chunk) - { - cur = next; - next = cur->next; - len_to_shrink += cur->length; - } - if (len_to_shrink) - { - f->size -= len_to_shrink; - start = prev->next; - prev->next = f->start_chunk; - f->end_chunk = prev; - cur->next = f->new_chunks; - f->new_chunks = start; - } + cur = f_find_node_rbtree (rt, start_pos); + c = uword_to_pointer (cur->opaque, svm_fifo_chunk_t *); + ASSERT (f_pos_leq (c->start_byte, start_pos)); } - if (!f->size_decrement && f->size == f->nitems + 1) + if (f_chunk_includes_pos (c, start_pos)) + f->ooo_deq = c; + + if (f_chunk_includes_pos (c, end_pos)) + return; + + do { - f->flags &= ~SVM_FIFO_F_SHRINK; - f->flags |= SVM_FIFO_F_COLLECT_CHUNKS; - if (f->start_chunk == f->start_chunk->next) - f->flags &= ~SVM_FIFO_F_MULTI_CHUNK; + c = f_cptr (f, c->next); + if (!c || c->deq_rb_index != RBTREE_TNIL_INDEX) + break; + + c->deq_rb_index = rb_tree_add_custom (rt, c->start_byte, + pointer_to_uword (c), f_pos_lt); + + if (f_chunk_includes_pos (c, start_pos)) + f->ooo_deq = c; } + while (!f_chunk_includes_pos (c, end_pos)); } -/** - * Request to reduce fifo size by amount of bytes - */ -int -svm_fifo_reduce_size (svm_fifo_t * f, u32 len, u8 try_shrink) +static svm_fifo_chunk_t * +f_lookup_clear_enq_chunks (svm_fifo_t * f, svm_fifo_chunk_t * start, + u32 end_pos) { - svm_fifo_chunk_t *cur; - u32 actual_len = 0; + rb_tree_t *rt = &f->ooo_enq_lookup; + svm_fifo_chunk_t *c; + rb_node_t *n; - /* Abort if trying to reduce by more than fifo size or if - * fifo is undergoing resizing already */ - if (len >= f->size || f->size > f->nitems + 1 - || (f->flags & SVM_FIFO_F_SHRINK) || (f->flags & SVM_FIFO_F_GROW)) - return 0; + c = start; + while (c && !f_chunk_includes_pos (c, end_pos)) + { + if (c->enq_rb_index != RBTREE_TNIL_INDEX) + { + n = rb_node (rt, c->enq_rb_index); + rb_tree_del_node (rt, n); + c->enq_rb_index = RBTREE_TNIL_INDEX; + } - /* last chunk that will not be removed */ - cur = svm_fifo_find_chunk (f, f->nitems - len); + c = f_cptr (f, c->next); + } - /* sum length of chunks that will be removed */ - cur = cur->next; - while (cur != f->start_chunk) + /* No ooo segments left, so make sure the current chunk + * is not tracked in the enq rbtree */ + if (f->ooos_list_head == OOO_SEGMENT_INVALID_INDEX + && c && c->enq_rb_index != RBTREE_TNIL_INDEX) { - actual_len += cur->length; - cur = cur->next; + n = rb_node (rt, c->enq_rb_index); + rb_tree_del_node (rt, n); + c->enq_rb_index = RBTREE_TNIL_INDEX; } - ASSERT (actual_len <= len); - if (!actual_len) - return 0; + return c; +} - f->size_decrement = actual_len; - f->flags |= SVM_FIFO_F_SHRINK; +static svm_fifo_chunk_t * +f_lookup_clear_deq_chunks (svm_fifo_t * f, svm_fifo_chunk_t * start, + u32 end_pos) +{ + rb_tree_t *rt = &f->ooo_deq_lookup; + svm_fifo_chunk_t *c; + rb_node_t *n; - if (try_shrink) + c = start; + while (c && !f_chunk_includes_pos (c, end_pos)) { - u32 head, tail; - f_load_head_tail_prod (f, &head, &tail); - svm_fifo_try_shrink (f, head, tail); + if (c->deq_rb_index != RBTREE_TNIL_INDEX) + { + n = rb_node (rt, c->deq_rb_index); + rb_tree_del_node (rt, n); + c->deq_rb_index = RBTREE_TNIL_INDEX; + } + + c = f_cptr (f, c->next); } - return actual_len; + return c; } void svm_fifo_free_chunk_lookup (svm_fifo_t * f) { - rb_tree_free_nodes (&f->chunk_lookup); + rb_tree_free_nodes (&f->ooo_enq_lookup); + rb_tree_free_nodes (&f->ooo_deq_lookup); } void @@ -788,40 +784,98 @@ svm_fifo_overwrite_head (svm_fifo_t * f, u8 * src, u32 len) u32 head, tail, head_idx; svm_fifo_chunk_t *c; - ASSERT (len <= f->nitems); + ASSERT (len <= f->shr->size); f_load_head_tail_cons (f, &head, &tail); - c = f->head_chunk; + + if (!f->shr->head_chunk) + f->shr->head_chunk = f_csptr (f, svm_fifo_find_chunk (f, head)); + + c = f_head_cptr (f); head_idx = head - c->start_byte; n_chunk = c->length - head_idx; if (len <= n_chunk) clib_memcpy_fast (&c->data[head_idx], src, len); else { + ASSERT (len - n_chunk <= f_cptr (f, c->next)->length); clib_memcpy_fast (&c->data[head_idx], src, n_chunk); - clib_memcpy_fast (&c->next->data[0], src + n_chunk, len - n_chunk); + clib_memcpy_fast (&f_cptr (f, c->next)->data[0], src + n_chunk, + len - n_chunk); } } +static int +f_try_chunk_alloc (svm_fifo_t * f, u32 head, u32 tail, u32 len) +{ + svm_fifo_chunk_t *c, *cur, *prev; + u32 alloc_size, free_alloced; + + prev = f_end_cptr (f); + free_alloced = f_chunk_end (prev) - tail; + + alloc_size = clib_min (f->shr->min_alloc, f->shr->size - (tail - head)); + alloc_size = clib_max (alloc_size, len - free_alloced); + + c = fsh_alloc_chunk (f->fs_hdr, f->shr->slice_index, alloc_size); + if (PREDICT_FALSE (!c)) + return -1; + + cur = c; + + while (cur) + { + cur->start_byte = prev->start_byte + prev->length; + cur->enq_rb_index = RBTREE_TNIL_INDEX; + cur->deq_rb_index = RBTREE_TNIL_INDEX; + + prev = cur; + cur = f_cptr (f, cur->next); + } + + f_csptr_link (f, f->shr->end_chunk, c); + prev->next = 0; + f->shr->end_chunk = f_csptr (f, prev); + + if (!f->shr->tail_chunk) + f->shr->tail_chunk = f_csptr (f, c); + + return 0; +} + int svm_fifo_enqueue (svm_fifo_t * f, u32 len, const u8 * src) { u32 tail, head, free_count; + svm_fifo_chunk_t *old_tail_c; + + f->ooos_newest = OOO_SEGMENT_INVALID_INDEX; f_load_head_tail_prod (f, &head, &tail); /* free space in fifo can only increase during enqueue: SPSC */ free_count = f_free_count (f, head, tail); - f->ooos_newest = OOO_SEGMENT_INVALID_INDEX; - if (PREDICT_FALSE (free_count == 0)) return SVM_FIFO_EFULL; /* number of bytes we're going to copy */ len = clib_min (free_count, len); - svm_fifo_copy_to_chunk (f, f->tail_chunk, tail, src, len, &f->tail_chunk); - tail = (tail + len) % f->size; + + if (f_pos_gt (tail + len, f_chunk_end (f_end_cptr (f)))) + { + if (PREDICT_FALSE (f_try_chunk_alloc (f, head, tail, len))) + { + len = f_chunk_end (f_end_cptr (f)) - tail; + if (!len) + return SVM_FIFO_EGROW; + } + } + + old_tail_c = f_tail_cptr (f); + + svm_fifo_copy_to_chunk (f, old_tail_c, tail, src, len, &f->shr->tail_chunk); + tail = tail + len; svm_fifo_trace_add (f, head, len, 2); @@ -829,12 +883,14 @@ svm_fifo_enqueue (svm_fifo_t * f, u32 len, const u8 * src) if (PREDICT_FALSE (f->ooos_list_head != OOO_SEGMENT_INVALID_INDEX)) { len += ooo_segment_try_collect (f, len, &tail); - if (!svm_fifo_chunk_includes_pos (f->tail_chunk, tail)) - f->tail_chunk = svm_fifo_find_chunk (f, tail); + /* Tail chunk might've changed even if nothing was collected */ + f->shr->tail_chunk = + f_csptr (f, f_lookup_clear_enq_chunks (f, old_tail_c, tail)); + f->ooo_enq = 0; } /* store-rel: producer owned index (paired with load-acq in consumer) */ - clib_atomic_store_rel_n (&f->tail, tail); + clib_atomic_store_rel_n (&f->shr->tail, tail); return len; } @@ -849,29 +905,36 @@ svm_fifo_enqueue (svm_fifo_t * f, u32 len, const u8 * src) int svm_fifo_enqueue_with_offset (svm_fifo_t * f, u32 offset, u32 len, u8 * src) { - u32 tail, head, free_count, tail_idx; + u32 tail, head, free_count, enq_pos; + svm_fifo_chunk_ptr_t last = F_INVALID_CPTR; f_load_head_tail_prod (f, &head, &tail); - if (PREDICT_FALSE (f->flags & SVM_FIFO_F_SHRINK)) - svm_fifo_try_shrink (f, head, tail); - /* free space in fifo can only increase during enqueue: SPSC */ free_count = f_free_count (f, head, tail); + f->ooos_newest = OOO_SEGMENT_INVALID_INDEX; /* will this request fit? */ if ((len + offset) > free_count) return SVM_FIFO_EFULL; - f->ooos_newest = OOO_SEGMENT_INVALID_INDEX; + enq_pos = tail + offset; + + if (f_pos_gt (enq_pos + len, f_chunk_end (f_end_cptr (f)))) + { + if (PREDICT_FALSE (f_try_chunk_alloc (f, head, tail, offset + len))) + return SVM_FIFO_EGROW; + } + svm_fifo_trace_add (f, offset, len, 1); ooo_segment_add (f, offset, head, tail, len); - tail_idx = (tail + offset) % f->size; - if (!svm_fifo_chunk_includes_pos (f->ooo_enq, tail_idx)) - f->ooo_enq = svm_fifo_find_chunk (f, tail_idx); + if (!f->ooo_enq || !f_chunk_includes_pos (f->ooo_enq, enq_pos)) + f_update_ooo_enq (f, enq_pos, enq_pos + len); - svm_fifo_copy_to_chunk (f, f->ooo_enq, tail_idx, src, len, &f->ooo_enq); + svm_fifo_copy_to_chunk (f, f->ooo_enq, enq_pos, src, len, &last); + if (last != F_INVALID_CPTR) + f->ooo_enq = f_cptr (f, last); return 0; } @@ -886,14 +949,156 @@ svm_fifo_enqueue_nocopy (svm_fifo_t * f, u32 len) ASSERT (len <= svm_fifo_max_enqueue_prod (f)); /* load-relaxed: producer owned index */ - tail = f->tail; - tail = (tail + len) % f->size; + tail = f->shr->tail; + tail = tail + len; + + if (rb_tree_is_init (&f->ooo_enq_lookup)) + { + f->shr->tail_chunk = + f_csptr (f, f_lookup_clear_enq_chunks (f, f_tail_cptr (f), tail)); + f->ooo_enq = 0; + } + else + { + f->shr->tail_chunk = + f_csptr (f, svm_fifo_find_next_chunk (f, f_tail_cptr (f), tail)); + } + + /* store-rel: producer owned index (paired with load-acq in consumer) */ + clib_atomic_store_rel_n (&f->shr->tail, tail); +} + +int +svm_fifo_enqueue_segments (svm_fifo_t * f, const svm_fifo_seg_t segs[], + u32 n_segs, u8 allow_partial) +{ + u32 tail, head, free_count, len = 0, i; + svm_fifo_chunk_t *old_tail_c; + + f->ooos_newest = OOO_SEGMENT_INVALID_INDEX; + + f_load_head_tail_prod (f, &head, &tail); + + /* free space in fifo can only increase during enqueue: SPSC */ + free_count = f_free_count (f, head, tail); + + if (PREDICT_FALSE (free_count == 0)) + return SVM_FIFO_EFULL; + + for (i = 0; i < n_segs; i++) + len += segs[i].len; + + old_tail_c = f_tail_cptr (f); + + if (!allow_partial) + { + if (PREDICT_FALSE (free_count < len)) + return SVM_FIFO_EFULL; + + if (f_pos_gt (tail + len, f_chunk_end (f_end_cptr (f)))) + { + if (PREDICT_FALSE (f_try_chunk_alloc (f, head, tail, len))) + return SVM_FIFO_EGROW; + } - if (!svm_fifo_chunk_includes_pos (f->tail_chunk, tail)) - f->tail_chunk = svm_fifo_find_chunk (f, tail); + for (i = 0; i < n_segs; i++) + { + svm_fifo_copy_to_chunk (f, f_tail_cptr (f), tail, segs[i].data, + segs[i].len, &f->shr->tail_chunk); + tail += segs[i].len; + } + } + else + { + len = clib_min (free_count, len); + + if (f_pos_gt (tail + len, f_chunk_end (f_end_cptr (f)))) + { + if (PREDICT_FALSE (f_try_chunk_alloc (f, head, tail, len))) + { + len = f_chunk_end (f_end_cptr (f)) - tail; + if (!len) + return SVM_FIFO_EGROW; + } + } + + i = 0; + while (len) + { + u32 to_copy = clib_min (segs[i].len, len); + svm_fifo_copy_to_chunk (f, f_tail_cptr (f), tail, segs[i].data, + to_copy, &f->shr->tail_chunk); + len -= to_copy; + tail += to_copy; + i++; + } + } + + /* collect out-of-order segments */ + if (PREDICT_FALSE (f->ooos_list_head != OOO_SEGMENT_INVALID_INDEX)) + { + len += ooo_segment_try_collect (f, len, &tail); + /* Tail chunk might've changed even if nothing was collected */ + f->shr->tail_chunk = + f_csptr (f, f_lookup_clear_enq_chunks (f, old_tail_c, tail)); + f->ooo_enq = 0; + } /* store-rel: producer owned index (paired with load-acq in consumer) */ - clib_atomic_store_rel_n (&f->tail, tail); + clib_atomic_store_rel_n (&f->shr->tail, tail); + + return len; +} + +always_inline svm_fifo_chunk_t * +f_unlink_chunks (svm_fifo_t * f, u32 end_pos, u8 maybe_ooo) +{ + svm_fifo_chunk_t *start, *prev = 0, *c; + rb_tree_t *rt; + rb_node_t *n; + + if (maybe_ooo) + rt = &f->ooo_deq_lookup; + + c = f_start_cptr (f); + ASSERT (!f_chunk_includes_pos (c, end_pos)); + + do + { + if (maybe_ooo && c->deq_rb_index != RBTREE_TNIL_INDEX) + { + n = rb_node (rt, c->deq_rb_index); + ASSERT (n == f_find_node_rbtree (rt, c->start_byte)); + rb_tree_del_node (rt, n); + c->deq_rb_index = RBTREE_TNIL_INDEX; + } + if (!c->next) + break; + prev = c; + c = f_cptr (f, c->next); + } + while (!f_chunk_includes_pos (c, end_pos)); + + if (maybe_ooo) + { + if (f->ooo_deq && f_pos_lt (f->ooo_deq->start_byte, f_chunk_end (c))) + f->ooo_deq = 0; + } + else + { + if (PREDICT_FALSE (f->ooo_deq != 0)) + f->ooo_deq = 0; + } + + /* Avoid unlinking the last chunk */ + if (!prev) + return 0; + + prev->next = 0; + start = f_start_cptr (f); + f->shr->start_chunk = f_csptr (f, c); + + return start; } int @@ -910,14 +1115,24 @@ svm_fifo_dequeue (svm_fifo_t * f, u32 len, u8 * dst) return SVM_FIFO_EEMPTY; len = clib_min (cursize, len); - svm_fifo_copy_from_chunk (f, f->head_chunk, head, dst, len, &f->head_chunk); - head = (head + len) % f->size; - if (PREDICT_FALSE (f->flags & SVM_FIFO_F_GROW)) - svm_fifo_try_grow (f, head); + if (!f->shr->head_chunk) + f->shr->head_chunk = f_csptr (f, svm_fifo_find_chunk (f, head)); + + svm_fifo_copy_from_chunk (f, f_head_cptr (f), head, dst, len, + &f->shr->head_chunk); + head = head + len; + + /* In order dequeues are not supported in combination with ooo peeking. + * Use svm_fifo_dequeue_drop instead. */ + ASSERT (rb_tree_n_nodes (&f->ooo_deq_lookup) <= 1); + + if (f_pos_geq (head, f_chunk_end (f_start_cptr (f)))) + fsh_collect_chunks (f->fs_hdr, f->shr->slice_index, + f_unlink_chunks (f, head, 0)); /* store-rel: consumer owned index (paired with load-acq in producer) */ - clib_atomic_store_rel_n (&f->head, head); + clib_atomic_store_rel_n (&f->shr->head, head); return len; } @@ -926,6 +1141,7 @@ int svm_fifo_peek (svm_fifo_t * f, u32 offset, u32 len, u8 * dst) { u32 tail, head, cursize, head_idx; + svm_fifo_chunk_ptr_t last = F_INVALID_CPTR; f_load_head_tail_cons (f, &head, &tail); @@ -936,11 +1152,15 @@ svm_fifo_peek (svm_fifo_t * f, u32 offset, u32 len, u8 * dst) return SVM_FIFO_EEMPTY; len = clib_min (cursize - offset, len); - head_idx = (head + offset) % f->size; - if (!svm_fifo_chunk_includes_pos (f->ooo_deq, head_idx)) - f->ooo_deq = svm_fifo_find_chunk (f, head_idx); + head_idx = head + offset; + + CLIB_MEM_UNPOISON (f->ooo_deq, sizeof (*f->ooo_deq)); + if (!f->ooo_deq || !f_chunk_includes_pos (f->ooo_deq, head_idx)) + f_update_ooo_deq (f, head_idx, head_idx + len); - svm_fifo_copy_from_chunk (f, f->ooo_deq, head_idx, dst, len, &f->ooo_deq); + svm_fifo_copy_from_chunk (f, f->ooo_deq, head_idx, dst, len, &last); + if (last != F_INVALID_CPTR) + f->ooo_deq = f_cptr (f, last); return len; } @@ -962,40 +1182,107 @@ svm_fifo_dequeue_drop (svm_fifo_t * f, u32 len) svm_fifo_trace_add (f, tail, total_drop_bytes, 3); /* move head */ - head = (head + total_drop_bytes) % f->size; - - if (!svm_fifo_chunk_includes_pos (f->head_chunk, head)) - f->head_chunk = svm_fifo_find_chunk (f, head); + head = head + total_drop_bytes; - if (PREDICT_FALSE (f->flags & SVM_FIFO_F_GROW)) - svm_fifo_try_grow (f, head); + if (f_pos_geq (head, f_chunk_end (f_start_cptr (f)))) + { + fsh_collect_chunks (f->fs_hdr, f->shr->slice_index, + f_unlink_chunks (f, head, 1)); + f->shr->head_chunk = f_chunk_includes_pos (f_start_cptr (f), head) ? + f->shr->start_chunk : + 0; + } /* store-rel: consumer owned index (paired with load-acq in producer) */ - clib_atomic_store_rel_n (&f->head, head); + clib_atomic_store_rel_n (&f->shr->head, head); return total_drop_bytes; } +/** + * Drop all data from fifo + * + */ void svm_fifo_dequeue_drop_all (svm_fifo_t * f) { - /* consumer foreign index */ - u32 tail = clib_atomic_load_acq_n (&f->tail); + u32 head, tail; - if (!svm_fifo_chunk_includes_pos (f->head_chunk, tail)) - f->head_chunk = svm_fifo_find_chunk (f, tail); + f_load_head_tail_all_acq (f, &head, &tail); - if (PREDICT_FALSE (f->flags & SVM_FIFO_F_GROW)) - svm_fifo_try_grow (f, tail); + if (!f->shr->head_chunk || !f_chunk_includes_pos (f_head_cptr (f), head)) + f->shr->head_chunk = f_csptr (f, svm_fifo_find_chunk (f, head)); + + f->shr->head_chunk = + f_csptr (f, f_lookup_clear_deq_chunks (f, f_head_cptr (f), tail)); + + if (f_pos_geq (tail, f_chunk_end (f_start_cptr (f)))) + fsh_collect_chunks (f->fs_hdr, f->shr->slice_index, + f_unlink_chunks (f, tail, 0)); /* store-rel: consumer owned index (paired with load-acq in producer) */ - clib_atomic_store_rel_n (&f->head, tail); + clib_atomic_store_rel_n (&f->shr->head, tail); +} + +int +svm_fifo_fill_chunk_list (svm_fifo_t * f) +{ + u32 head, tail; + + f_load_head_tail_prod (f, &head, &tail); + + if (f_chunk_end (f_end_cptr (f)) - head >= f->shr->size) + return 0; + + if (f_try_chunk_alloc (f, head, tail, f->shr->size - (tail - head))) + return SVM_FIFO_EGROW; + + return 0; +} + +int +svm_fifo_provision_chunks (svm_fifo_t *f, svm_fifo_seg_t *fs, u32 n_segs, + u32 len) +{ + u32 head, tail, n_avail, head_pos, n_bytes, fs_index = 1, clen; + svm_fifo_chunk_t *c; + + f_load_head_tail_prod (f, &head, &tail); + + if (f_free_count (f, head, tail) < len) + return SVM_FIFO_EFULL; + + n_avail = f_chunk_end (f_end_cptr (f)) - tail; + + if (n_avail < len && f_try_chunk_alloc (f, head, tail, len)) + return SVM_FIFO_EGROW; + + c = f_tail_cptr (f); + head_pos = (tail - c->start_byte); + fs[0].data = c->data + head_pos; + fs[0].len = clib_min (c->length - head_pos, len); + n_bytes = fs[0].len; + + while (n_bytes < len && fs_index < n_segs) + { + c = f_cptr (f, c->next); + clen = clib_min (c->length, len - n_bytes); + fs[fs_index].data = c->data; + fs[fs_index].len = clen; + n_bytes += clen; + fs_index += 1; + } + + return fs_index; } int -svm_fifo_segments (svm_fifo_t * f, svm_fifo_seg_t * fs) +svm_fifo_segments (svm_fifo_t * f, u32 offset, svm_fifo_seg_t * fs, + u32 n_segs, u32 max_bytes) { - u32 cursize, head, tail, head_idx; + u32 cursize, to_read, head, tail, fs_index = 1; + u32 n_bytes, head_pos, len, start; + svm_fifo_chunk_t *c; f_load_head_tail_cons (f, &head, &tail); @@ -1005,37 +1292,36 @@ svm_fifo_segments (svm_fifo_t * f, svm_fifo_seg_t * fs) if (PREDICT_FALSE (cursize == 0)) return SVM_FIFO_EEMPTY; - head_idx = head; + if (offset >= cursize) + return SVM_FIFO_EEMPTY; - if (tail < head) - { - fs[0].len = f->size - head_idx; - fs[0].data = f->head_chunk->data + head_idx; - fs[1].len = cursize - fs[0].len; - fs[1].data = f->head_chunk->data; - } - else - { - fs[0].len = cursize; - fs[0].data = f->head_chunk->data + head_idx; - fs[1].len = 0; - fs[1].data = 0; - } - return cursize; -} + to_read = clib_min (cursize - offset, max_bytes); + start = head + offset; -void -svm_fifo_segments_free (svm_fifo_t * f, svm_fifo_seg_t * fs) -{ - u32 head; + if (!f->shr->head_chunk) + f->shr->head_chunk = f_csptr (f, svm_fifo_find_chunk (f, head)); - /* consumer owned index */ - head = f->head; + c = f_head_cptr (f); - ASSERT (fs[0].data == f->head_chunk->data + head); - head = (head + fs[0].len + fs[1].len) % f->size; - /* store-rel: consumer owned index (paired with load-acq in producer) */ - clib_atomic_store_rel_n (&f->head, head); + while (!f_chunk_includes_pos (c, start)) + c = f_cptr (f, c->next); + + head_pos = start - c->start_byte; + fs[0].data = c->data + head_pos; + fs[0].len = clib_min (c->length - head_pos, to_read); + n_bytes = fs[0].len; + + while (n_bytes < to_read && fs_index < n_segs) + { + c = f_cptr (f, c->next); + len = clib_min (c->length, to_read - n_bytes); + fs[fs_index].data = c->data; + fs[fs_index].len = len; + n_bytes += len; + fs_index += 1; + } + + return n_bytes; } /** @@ -1049,11 +1335,16 @@ void svm_fifo_clone (svm_fifo_t * df, svm_fifo_t * sf) { u32 head, tail; - clib_memcpy_fast (df->head_chunk->data, sf->head_chunk->data, sf->size); + + /* Support only single chunk clones for now */ + ASSERT (svm_fifo_n_chunks (sf) == 1); + + clib_memcpy_fast (f_head_cptr (df)->data, f_head_cptr (sf)->data, + sf->shr->size); f_load_head_tail_all_acq (sf, &head, &tail); - clib_atomic_store_rel_n (&df->head, head); - clib_atomic_store_rel_n (&df->tail, tail); + clib_atomic_store_rel_n (&df->shr->head, head); + clib_atomic_store_rel_n (&df->shr->tail, tail); } u32 @@ -1074,28 +1365,27 @@ svm_fifo_first_ooo_segment (svm_fifo_t * f) void svm_fifo_init_pointers (svm_fifo_t * f, u32 head, u32 tail) { - head = head % f->size; - tail = tail % f->size; - clib_atomic_store_rel_n (&f->head, head); - clib_atomic_store_rel_n (&f->tail, tail); - if (f->flags & SVM_FIFO_F_MULTI_CHUNK) - { - svm_fifo_chunk_t *c; - c = svm_fifo_find_chunk (f, head); - ASSERT (c != 0); - f->head_chunk = f->ooo_deq = c; - c = svm_fifo_find_chunk (f, tail); - ASSERT (c != 0); - f->tail_chunk = f->ooo_enq = c; - } + svm_fifo_chunk_t *c; + + clib_atomic_store_rel_n (&f->shr->head, head); + clib_atomic_store_rel_n (&f->shr->tail, tail); + + c = svm_fifo_find_chunk (f, head); + ASSERT (c != 0); + f->ooo_deq = c; + f->shr->head_chunk = f_csptr (f, c); + c = svm_fifo_find_chunk (f, tail); + ASSERT (c != 0); + f->ooo_enq = c; + f->shr->tail_chunk = f_csptr (f, c); } void svm_fifo_add_subscriber (svm_fifo_t * f, u8 subscriber) { - if (f->n_subscribers >= SVM_FIFO_MAX_EVT_SUBSCRIBERS) + if (f->shr->n_subscribers >= SVM_FIFO_MAX_EVT_SUBSCRIBERS) return; - f->subscribers[f->n_subscribers++] = subscriber; + f->shr->subscribers[f->shr->n_subscribers++] = subscriber; } void @@ -1103,12 +1393,12 @@ svm_fifo_del_subscriber (svm_fifo_t * f, u8 subscriber) { int i; - for (i = 0; i < f->n_subscribers; i++) + for (i = 0; i < f->shr->n_subscribers; i++) { - if (f->subscribers[i] != subscriber) + if (f->shr->subscribers[i] != subscriber) continue; - f->subscribers[i] = f->subscribers[f->n_subscribers - 1]; - f->n_subscribers--; + f->shr->subscribers[i] = f->shr->subscribers[f->shr->n_subscribers - 1]; + f->shr->n_subscribers--; break; } } @@ -1116,22 +1406,58 @@ svm_fifo_del_subscriber (svm_fifo_t * f, u8 subscriber) u8 svm_fifo_is_sane (svm_fifo_t * f) { - if (f->size - 1 != f->nitems && !(f->flags & SVM_FIFO_F_SHRINK)) - return 0; - if (!svm_fifo_chunk_includes_pos (f->head_chunk, f->head)) + svm_fifo_chunk_t *tmp; + + if (f->shr->head_chunk && + !f_chunk_includes_pos (f_head_cptr (f), f->shr->head)) return 0; - if (!svm_fifo_chunk_includes_pos (f->tail_chunk, f->tail)) + if (f->shr->tail_chunk && + !f_chunk_includes_pos (f_tail_cptr (f), f->shr->tail)) return 0; + if (f->ooo_deq) + { + if (rb_tree_is_init (&f->ooo_deq_lookup)) + { + if (f_pos_lt (f->ooo_deq->start_byte, + f_start_cptr (f)->start_byte) || + f_pos_gt (f->ooo_deq->start_byte, f_chunk_end (f_end_cptr (f)))) + return 0; - if (f->start_chunk->next != f->start_chunk) + tmp = f_find_chunk_rbtree (&f->ooo_deq_lookup, + f->ooo_deq->start_byte); + } + else + tmp = svm_fifo_find_chunk (f, f->ooo_deq->start_byte); + if (tmp != f->ooo_deq) + return 0; + } + if (f->ooo_enq) { - svm_fifo_chunk_t *c, *prev = 0, *tmp; - u32 size = 0; + if (rb_tree_is_init (&f->ooo_enq_lookup)) + { + if (f_pos_lt (f->ooo_enq->start_byte, + f_start_cptr (f)->start_byte) || + f_pos_gt (f->ooo_enq->start_byte, f_chunk_end (f_end_cptr (f)))) + return 0; - if (!(f->flags & SVM_FIFO_F_MULTI_CHUNK)) + tmp = f_find_chunk_rbtree (&f->ooo_enq_lookup, + f->ooo_enq->start_byte); + } + else + { + tmp = svm_fifo_find_next_chunk (f, f_tail_cptr (f), + f->ooo_enq->start_byte); + } + if (tmp != f->ooo_enq) return 0; + } + + if (f_start_cptr (f)->next) + { + svm_fifo_chunk_t *c, *prev = 0, *tmp; + u32 chunks_bytes = 0; - c = f->start_chunk; + c = f_start_cptr (f); do { tmp = svm_fifo_find_chunk (f, c->start_byte); @@ -1139,28 +1465,62 @@ svm_fifo_is_sane (svm_fifo_t * f) return 0; if (prev && (prev->start_byte + prev->length != c->start_byte)) return 0; - size += c->length; + + if (c->enq_rb_index != RBTREE_TNIL_INDEX) + { + tmp = f_find_chunk_rbtree (&f->ooo_enq_lookup, c->start_byte); + if (tmp) + { + if (tmp != c) + return 0; + } + } + if (c->deq_rb_index != RBTREE_TNIL_INDEX) + { + tmp = f_find_chunk_rbtree (&f->ooo_deq_lookup, c->start_byte); + if (tmp) + { + if (tmp != c) + return 0; + } + } + + chunks_bytes += c->length; prev = c; - c = c->next; + c = f_cptr (f, c->next); } - while (c != f->start_chunk); + while (c); - if (size != f->size) + if (chunks_bytes < f->shr->tail - f->shr->head) return 0; } return 1; } +u32 +svm_fifo_n_chunks (svm_fifo_t * f) +{ + svm_fifo_chunk_t *c; + int n_chunks = 0; + + c = f_start_cptr (f); + while (c) + { + n_chunks++; + c = f_cptr (f, c->next); + } + + return n_chunks; +} + u8 * format_ooo_segment (u8 * s, va_list * args) { - svm_fifo_t *f = va_arg (*args, svm_fifo_t *); + svm_fifo_t __clib_unused *f = va_arg (*args, svm_fifo_t *); ooo_segment_t *seg = va_arg (*args, ooo_segment_t *); - u32 normalized_start = (seg->start + f->nitems - f->tail) % f->size; - s = format (s, "[%u, %u], len %u, next %d, prev %d", normalized_start, - (normalized_start + seg->length) % f->size, seg->length, - seg->next, seg->prev); + s = format (s, "[%u, %u], len %u, next %d, prev %d", seg->start, + seg->start + seg->length, seg->length, seg->next, seg->prev); return s; } @@ -1195,7 +1555,7 @@ svm_fifo_replay (u8 * s, svm_fifo_t * f, u8 no_read, u8 verbose) u8 *data = 0; svm_fifo_trace_elem_t *trace; u32 offset; - svm_fifo_t *dummy_fifo; + svm_fifo_t *placeholder_fifo; if (!f) return s; @@ -1208,9 +1568,10 @@ svm_fifo_replay (u8 * s, svm_fifo_t * f, u8 no_read, u8 verbose) trace_len = 0; #endif - dummy_fifo = svm_fifo_create (f->size); - clib_memset (f->head_chunk->data, 0xFF, f->nitems); - vec_validate (data, f->nitems); + placeholder_fifo = svm_fifo_alloc (f->shr->size); + svm_fifo_init (f, f->shr->size); + clib_memset (f_head_cptr (f)->data, 0xFF, f->shr->size); + vec_validate (data, f->shr->size); for (i = 0; i < vec_len (data); i++) data[i] = i; @@ -1221,27 +1582,27 @@ svm_fifo_replay (u8 * s, svm_fifo_t * f, u8 no_read, u8 verbose) { if (verbose) s = format (s, "adding [%u, %u]:", trace[i].offset, - (trace[i].offset + trace[i].len) % dummy_fifo->size); - svm_fifo_enqueue_with_offset (dummy_fifo, trace[i].offset, + (trace[i].offset + trace[i].len)); + svm_fifo_enqueue_with_offset (placeholder_fifo, trace[i].offset, trace[i].len, &data[offset]); } else if (trace[i].action == 2) { if (verbose) s = format (s, "adding [%u, %u]:", 0, trace[i].len); - svm_fifo_enqueue (dummy_fifo, trace[i].len, &data[offset]); + svm_fifo_enqueue (placeholder_fifo, trace[i].len, &data[offset]); } else if (!no_read) { if (verbose) s = format (s, "read: %u", trace[i].len); - svm_fifo_dequeue_drop (dummy_fifo, trace[i].len); + svm_fifo_dequeue_drop (placeholder_fifo, trace[i].len); } if (verbose) - s = format (s, "%U", format_svm_fifo, dummy_fifo, 1); + s = format (s, "%U", format_svm_fifo, placeholder_fifo, 1); } - s = format (s, "result: %U", format_svm_fifo, dummy_fifo, 1); + s = format (s, "result: %U", format_svm_fifo, placeholder_fifo, 1); return s; } @@ -1276,16 +1637,16 @@ format_svm_fifo (u8 * s, va_list * args) return s; indent = format_get_indent (s); - s = format (s, "cursize %u nitems %u has_event %d\n", - svm_fifo_max_dequeue (f), f->nitems, f->has_event); + s = format (s, "cursize %u nitems %u has_event %d min_alloc %u\n", + svm_fifo_max_dequeue (f), f->shr->size, f->shr->has_event, + f->shr->min_alloc); s = format (s, "%Uhead %u tail %u segment manager %u\n", format_white_space, - indent, (f->head % f->size), (f->tail % f->size), - f->segment_manager); + indent, f->shr->head, f->shr->tail, f->segment_manager); if (verbose > 1) s = format (s, "%Uvpp session %d thread %d app session %d thread %d\n", - format_white_space, indent, f->master_session_index, - f->master_thread_index, f->client_session_index, + format_white_space, indent, f->shr->master_session_index, + f->master_thread_index, f->shr->client_session_index, f->client_thread_index); if (verbose)