X-Git-Url: https://gerrit.fd.io/r/gitweb?a=blobdiff_plain;f=src%2Fvppinfra%2Frandom.c;h=ea89f0a161898a299195cb38f4368ff6e024769b;hb=50f0ac0f097e5495da1f2b1816106e3d420ff34b;hp=e54a3bc8c7ca4a500ccaacf4311e240951ebb56a;hpb=0c332a358533ed24e2130b071c9250e3fae9f745;p=vpp.git diff --git a/src/vppinfra/random.c b/src/vppinfra/random.c index e54a3bc8c7c..ea89f0a1618 100644 --- a/src/vppinfra/random.c +++ b/src/vppinfra/random.c @@ -63,20 +63,26 @@ u32 standalone_random_default_seed = 1; f64 clib_chisquare (u64 * values) { - int i; + u32 i, len; f64 d, delta_d, actual_frequency, expected_frequency; u64 n_observations = 0; - ASSERT (vec_len (values)); + len = vec_len (values); + /* + * Shut up coverity. Return a huge number which should always exceed + * the X2 critical value. + */ + if (len == 0) + return (f64) 1e70; - for (i = 0; i < vec_len (values); i++) + for (i = 0; i < len; i++) n_observations += values[i]; - expected_frequency = (1.0 / (f64) vec_len (values)) * (f64) n_observations; + expected_frequency = (1.0 / (f64) len) * (f64) n_observations; d = 0.0; - for (i = 0; i < vec_len (values); i++) + for (i = 0; i < len; i++) { actual_frequency = ((f64) values[i]); delta_d = ((actual_frequency - expected_frequency)