X-Git-Url: https://gerrit.fd.io/r/gitweb?a=blobdiff_plain;f=test%2Fvpp_object.py;h=8dd2afac97c05cf96c2a61786fd40acae105628a;hb=da1b76aa89ede1f4d7947cdcd6ec2f61948ff7e7;hp=2c07d472a657070a7c7cf0be616b37d9b4693871;hpb=3593a9174a8e9faddb8d4eb451d1b4632c1e0df1;p=vpp.git diff --git a/test/vpp_object.py b/test/vpp_object.py index 2c07d472a65..8dd2afac97c 100644 --- a/test/vpp_object.py +++ b/test/vpp_object.py @@ -1,46 +1,42 @@ """ abstract vpp object and object registry """ import abc -import six -from six import moves - -@six.add_metaclass(abc.ABCMeta) -class VppObject(object): +class VppObject(metaclass=abc.ABCMeta): """ Abstract vpp object """ @abc.abstractmethod - def add_vpp_config(self): + def add_vpp_config(self) -> None: """ Add the configuration for this object to vpp. """ pass @abc.abstractmethod - def query_vpp_config(self): + def query_vpp_config(self) -> bool: """Query the vpp configuration. :return: True if the object is configured""" pass @abc.abstractmethod - def remove_vpp_config(self): + def remove_vpp_config(self) -> None: """ Remove the configuration for this object from vpp. """ pass - def object_id(self): + def object_id(self) -> str: """ Return a unique string representing this object. """ return "Undefined. for <%s %s>" % (self.__class__.__name__, id(self)) - def __str__(self): + def __str__(self) -> str: return self.object_id() - def __repr__(self): + def __repr__(self) -> str: return '<%s>' % self.object_id() - def __hash__(self): + def __hash__(self) -> int: return hash(self.object_id()) - def __eq__(self, other): + def __eq__(self, other) -> bool: if not isinstance(other, self.__class__): return NotImplemented if other.object_id() == self.object_id(): @@ -52,18 +48,18 @@ class VppObject(object): return not self.__eq__(other) -class VppObjectRegistry(object): +class VppObjectRegistry: """ Class which handles automatic configuration cleanup. """ _shared_state = {} - def __init__(self): + def __init__(self) -> None: self.__dict__ = self._shared_state if not hasattr(self, "_object_registry"): self._object_registry = [] if not hasattr(self, "_object_dict"): self._object_dict = dict() - def register(self, obj, logger): + def register(self, obj: VppObject, logger) -> None: """ Register an object in the registry. """ if obj.object_id() not in self._object_dict: self._object_registry.append(obj) @@ -72,13 +68,13 @@ class VppObjectRegistry(object): else: logger.debug("REG: duplicate add, ignoring (%s)" % obj) - def unregister_all(self, logger): + def unregister_all(self, logger) -> None: """ Remove all object registrations from registry. """ logger.debug("REG: removing all object registrations") self._object_registry = [] self._object_dict = dict() - def remove_vpp_config(self, logger): + def remove_vpp_config(self, logger) -> None: """ Remove configuration (if present) from vpp and then remove all objects from the registry.