Fix double-enqueued packet in interface-output dual-loop, fixes VPP-116 68/1568/1
authorDamjan Marion <[email protected]>
Fri, 10 Jun 2016 17:26:54 +0000 (19:26 +0200)
committerDamjan Marion <[email protected]>
Wed, 15 Jun 2016 14:38:41 +0000 (16:38 +0200)
commit1f25d1a2ec19283635b039e527edcee0e9301748
tree33263f2958cd3dc2a1a449f65860c8ae7ac125c6
parenta55cf2c1e5ee791e7bc1d657c75eb65255ce050f
Fix double-enqueued packet in interface-output dual-loop, fixes VPP-116

When speculative enqueue fails and a buffer needs to be moved to a new
node queue the original buffer is not correctly removed from the
original queue so buffer get send for transmit and encryption at the
same time. This issue will only be hit with the double loop so low
throughput traffic like pings will not hit the issue. This code path is
also only hit when the feature flag is enabled so will not be hit by
normal traffic

Patch also reorgnizes code to reduce number of branches in the interface
output node loop.

Change-Id: I3653400e58bdfd833e6c42823bab51586128b54b
Signed-off-by: Sergio Gonzalez Monroy <[email protected]>
Signed-off-by: Damjan Marion <[email protected]>
vnet/vnet/buffer.h
vnet/vnet/interface_output.c