igmp: fix igmp proxy group merge 87/28387/1
authorBenoît Ganne <bganne@cisco.com>
Thu, 16 Apr 2020 10:47:47 +0000 (12:47 +0200)
committerAndrew Yourtchenko <ayourtch@gmail.com>
Thu, 13 Aug 2020 17:20:47 +0000 (17:20 +0000)
commit8453fb7509b7fa43c8e94f8cf383c638d36dc0bf
tree95d90d8d34ff98c62654891ee2c7b7c3e1f45b07
parent7e5733ad1705280ce70b63169492e310b2c31917
igmp: fix igmp proxy group merge

When merging proxy groups in igmp_proxy_device_merge_group(), the call
to igmp_proxy_device_merge_src() can end up removing the current proxy
group via igmp_group_clear(). When that happens, it must returns NULL so
that igmp_proxy_device_merge_config() does not send a IGMPv3 report for
a dead proxy group.
Make igmp_group_clear() reset the group pointer to NULL to fix this bug
and to detect similar bugs more easily.

Type: fix

Change-Id: I229e55b5bfa71734d7844893f5209a66fa3cc8ae
Signed-off-by: Benoît Ganne <bganne@cisco.com>
(cherry picked from commit bd7f3422bbe38ba87888b765e94b56bfcbb9602c)
src/plugins/igmp/igmp.c
src/plugins/igmp/igmp_config.c
src/plugins/igmp/igmp_group.c
src/plugins/igmp/igmp_group.h
src/plugins/igmp/igmp_proxy.c
src/plugins/igmp/igmp_src.c