vppinfra: fix page boundary crossing bug in hash_memory64 11/22911/2
authorDave Barach <[email protected]>
Wed, 9 Oct 2019 16:57:13 +0000 (12:57 -0400)
committerDave Barach <[email protected]>
Wed, 23 Oct 2019 21:42:36 +0000 (21:42 +0000)
commit925b94aa3c91970cdb6c059191f95f7079f69b27
treebeafb2cdad2e223ffcec0583c3334eaf87467f14
parent0e520fdfd4e0c5d9ac8e37a56e9860d54ede3b35
vppinfra: fix page boundary crossing bug in hash_memory64

Fix a day-1 bug, possibly dating back as far as 2002. The zap64() game
involves fetching 8 byte chunks, and clearing octets not to be
included in the key.

That's fine *unless* the 8-byte fetch happens to cross a page boundary
into unmapped or no-access space.

Type: fix

Signed-off-by: Dave Barach <[email protected]>
Change-Id: I4607e9840032257c96ba7387f86c931c0921749d
(cherry picked from commit 7e2cea3d26701ff1d80fda7d8ca907890e3e7baa)
src/plugins/unittest/util_test.c
src/vppinfra/hash.c