ping: fix buffer allocator error handling 69/26469/2
authorDave Barach <[email protected]>
Wed, 8 Apr 2020 16:03:32 +0000 (12:03 -0400)
committerDave Wallace <[email protected]>
Mon, 13 Apr 2020 15:05:01 +0000 (15:05 +0000)
commit943fb1559396016ea452cb07f169e0d4c28760bf
treef207da886efd40aff6ed577d8fae968bf8ca2569
parent4603e34497fa9511c8fbd83b78bc5cffdd6a8997
ping: fix buffer allocator error handling

The code sets f->n_vectors = n_to_send, but it can bail out of the
loop if vlib_buffer_copy(...) returns 0.

Need to fix f->n_vectors in the error return path, or we enqueue some
number of 0xfefefefe buffer indices in a debug image or worse in a
production image.

Type: fix

Signed-off-by: Dave Barach <[email protected]>
Change-Id: I2d886266006c6c1c2f9ef8e3b95eb46ac6c0b3df
(cherry picked from commit 8324c55f95dd5ddbf1f5f9c47907204a12e152ef)
src/plugins/ping/ping.c