Code Review / honeycomb.git / commit
? search:
summary | shortlog | log | commit | commitdiff | review | tree
(parent: 75f0efb) | patch
HONEYCOMB-331: unify initialization handling 16/4616/1
authorMarek Gradzki <mgradzki@cisco.com>
Mon, 9 Jan 2017 07:23:45 +0000 (08:23 +0100)
committerMarek Gradzki <mgradzki@cisco.com>
Tue, 10 Jan 2017 07:41:32 +0000 (07:41 +0000)
commit98666a011d7538ac9742a8351856f76fbe7d8e69
tree1b955cd53a0a78eefb9e1c04413fd3f7dd0b6b9atree | snapshot
parent75f0efb8b1aff9e9be8d222fd90d1df7ce542bbccommit | diff
HONEYCOMB-331: unify initialization handling

Due to incorrect instance of check, InitSubtreeReader was never created
in CompositeReaderRegistryBuilder.getSubtreeHandler().

As a consequence, initializers registered by subtreeAdd*, were not invoked.

The patch:
- fixes mentioned check,
- makes readers implement InitReader instead of directly
  implementing Initializer
- includes missing unit tests for GenericReaders.

Change-Id: I93be59fafddb60dce00191958b5c8c62e7c2d289
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
12 files changed:
infra/translate-api/src/main/java/io/fd/honeycomb/translate/read/InitListReader.java diff | blob | history
infra/translate-impl/src/main/java/io/fd/honeycomb/translate/impl/read/GenericInitReader.java diff | blob | history
infra/translate-impl/src/main/java/io/fd/honeycomb/translate/impl/read/registry/CompositeReader.java diff | blob | history
infra/translate-impl/src/main/java/io/fd/honeycomb/translate/impl/read/registry/CompositeReaderRegistryBuilder.java diff | blob | history
infra/translate-impl/src/main/java/io/fd/honeycomb/translate/impl/read/registry/InitSubtreeReader.java diff | blob | history
infra/translate-impl/src/test/java/io/fd/honeycomb/translate/impl/read/AbstractListReaderTest.java [new file with mode: 0644] blob
infra/translate-impl/src/test/java/io/fd/honeycomb/translate/impl/read/AbstractReaderTest.java [new file with mode: 0644] blob
infra/translate-impl/src/test/java/io/fd/honeycomb/translate/impl/read/GenericInitListReaderTest.java [new file with mode: 0644] blob
infra/translate-impl/src/test/java/io/fd/honeycomb/translate/impl/read/GenericIntReaderTest.java [new file with mode: 0644] blob
infra/translate-impl/src/test/java/io/fd/honeycomb/translate/impl/read/GenericListReaderTest.java diff | blob | history
infra/translate-impl/src/test/java/io/fd/honeycomb/translate/impl/read/GenericReaderTest.java diff | blob | history
infra/translate-impl/src/test/java/io/fd/honeycomb/translate/impl/read/registry/InitSubtreeReaderTest.java [new file with mode: 0644] blob
ARCHIVED- 2020-12-03 at the request of the project